Skip to contentSkip to conversation

tests/qemu-iotests/264: Allow up to 5s for the BLOCK_JOB_CANCEL event to arrive

PATCH In review Thomas Huth 2 participants 2 messages Aug 2, 2022 – Aug 6, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/qemu-iotests/264: Allow up to 5s for the BLOCK_JOB_CANCEL event to arrive

It is possible to hit the assertTrue(delta_t < 2.0) on very loaded systems. Increase the value to 5.0 to ease the situation a little bit.

---
See also https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg03936.html

 tests/qemu-iotests/264 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/qemu-iotests/264 +1 -1
index bc431d1a19..289381e315 100755
@@ -101,7 +101,7 @@ class TestNbdReconnect(iotests.QMPTestCase):
         start_t = time.time()
         self.vm.event_wait('BLOCK_JOB_CANCELLED')
         delta_t = time.time() - start_t
-        self.assertTrue(delta_t < 2.0)
+        self.assertTrue(delta_t < 5.0)
 
     def test_mirror_cancel(self):
         # Mirror speed limit doesn't work well enough, it seems that mirror
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Thomas Huth

It is possible to hit the assertTrue(delta_t < 2.0) on very loaded systems. Increase the value to 5.0 to ease the situation a little bit.

---
See also https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg03936.html

  tests/qemu-iotests/264 | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tests/qemu-iotests/264 +0 -0
index bc431d1a19..289381e315 100755

tests/qemu-iotests/264 class TestNbdReconnect(iotests.QMPTestCase): · line 107

Quoted 8 lines
tests/qemu-iotests/264 +1 -1
@@ -101,7 +101,7 @@ class TestNbdReconnect(iotests.QMPTestCase):
          start_t = time.time()
          self.vm.event_wait('BLOCK_JOB_CANCELLED')
          delta_t = time.time() - start_t
-        self.assertTrue(delta_t < 2.0)
+        self.assertTrue(delta_t < 5.0)
 
      def test_mirror_cancel(self):
          # Mirror speed limit doesn't work well enough, it seems that mirror
Signature · 2 lines
Best regards,
Vladimir