Skip to contentSkip to conversation

wifi: rtw89: refine leaving LPS function

PATCH In review Ping-Ke Shih 2 participants 2 messages Aug 2, 2022 – Aug 9, 2022 Realtek wireless driver (rtw89)

lore
Share & tools
lore

Ping-Ke Shih

author maintainer
#0 lore raw

PATCH 1/1 wifi: rtw89: refine leaving LPS function

From: Zong-Zhe Yang <[email protected]>

It's unnecessary to iterate leaving PS mode.
So, move it out of the iteration.

---
 drivers/net/wireless/realtek/rtw89/ps.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw89/ps.c +2 -1
index a90b337205885..ea3260178e666 100644
@@ -127,7 +127,6 @@ static void rtw89_leave_lps_vif(struct rtw89_dev *rtwdev, struct rtw89_vif *rtwv
 	if (rtwvif->wifi_role != RTW89_WIFI_ROLE_STATION)
 		return;
 
-	__rtw89_leave_ps_mode(rtwdev);
 	__rtw89_leave_lps(rtwdev, rtwvif->mac_id);
 }
 
@@ -140,6 +139,8 @@ void rtw89_leave_lps(struct rtw89_dev *rtwdev)
 	if (!test_and_clear_bit(RTW89_FLAG_LEISURE_PS, rtwdev->flags))
 		return;
 
+	__rtw89_leave_ps_mode(rtwdev);
+
 	rtw89_for_each_rtwvif(rtwdev, rtwvif)
 		rtw89_leave_lps_vif(rtwdev, rtwvif);
 }
Signature · 1 line
2.25.1
#1 lore raw
Quoted 7 lines · Ping-Ke Shih

From: Zong-Zhe Yang <[email protected]>

It's unnecessary to iterate leaving PS mode.
So, move it out of the iteration.

Patch applied to wireless-next.git, thanks.

674ece275a8e wifi: rtw89: refine leaving LPS function

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches