Skip to contentSkip to conversation

Fix: revise obsolete command in README.md

PATCH Applied Shao-Tse Hung via lttng-dev 1 participant 2 messages Aug 2, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix: revise obsolete command in README.md

The obsolete command make bench was replaced by make short_bench and make long_bench in 2015. However, this command wasn't revised in README, so I follow the previous commit and rewrite it.

---
 README.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
README.md +3 -2
index a8318c8..1e75589 100644
@@ -426,14 +426,15 @@ Make targets
 ------------
 
 In addition to the usual `make check` target, Userspace RCU features
-`make regtest` and `make bench` targets:
+`make regtest`, `make short_bench` and `make long_bench` targets:
 
   - `make check`: short tests, meant to be run when rebuilding or
     porting Userspace RCU.
   - `make regtest`: long (many hours) test, meant to be run when
     modifying Userspace RCU or porting it to a new architecture or
     operating system.
-  - `make bench`: long (many hours) benchmarks.
+  - `make short_bench`: short benchmarks, 3 seconds per test.
+  - `make long_bench`: long (many hours) benchmarks, 30 seconds per test.
 
 
 Known issues
Signature · 6 lines
2.25.1

_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
#1 lore raw
Quoted 4 lines · ----- On Aug 2, 2022, at 1:44 PM, Shao-Tse Hung via lttng-dev…

The obsolete command make bench was replaced by make short_bench and make long_bench in 2015.
However, this command wasn't revised in README, so I follow the previous commit and rewrite it.

Merged into liburcu master, 0.13, 0.12 branches, thanks!

Mathieu

Quoted 35 lines

---
README.md | 5 +++--

1 file changed, 3 insertions(+), 2 deletions(-)
README.md +0 -1
index a8318c8..1e75589 100644
@@ -426,14 +426,15 @@ Make targets
------------
 

In addition to the usual make check target, Userspace RCU features -make regtest and make bench targets:
+make regtest, make short_bench and make long_bench targets:

- make check: short tests, meant to be run when rebuilding or porting Userspace RCU.
- make regtest: long (many hours) test, meant to be run when modifying Userspace RCU or porting it to a new architecture or operating system.

README.md +2 -1
-  - `make bench`: long (many hours) benchmarks.
+  - `make short_bench`: short benchmarks, 3 seconds per test.
+  - `make long_bench`: long (many hours) benchmarks, 30 seconds per test.

Known issues
--
2.25.1

_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Signature · 7 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev