NFSv4/pnfs: Fix a use-after-free bug in open
Subsystems (2)
[email protected]
maintainerPATCH 1/1 NFSv4/pnfs: Fix a use-after-free bug in open
From: Trond Myklebust <[email protected]>
If someone cancels the open RPC call, then we must not try to free either the open slot or the layoutget operation arguments, since they are likely still in use by the hung RPC call.
Fixes 6949493884fe ("NFSv4: Don't hold the layoutget locks across multiple RPC calls")
Signed-off-by Trond Myklebust <[email protected]>
--- fs/nfs/nfs4proc.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
fs/nfs/nfs4proc.c +6 -5
@@ -3096,12 +3096,13 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata, } out: -if (opendata->lgp) { -nfs4_lgopen_release (opendata->lgp); - opendata->lgp =NULL ; - } -if (!opendata->cancelled) +if (!opendata->cancelled) { +if (opendata->lgp) { +nfs4_lgopen_release (opendata->lgp); + opendata->lgp =NULL ; + }nfs4_sequence_free_slot (&opendata->o_res.seq_res); + }return ret; }
Signature · 1 line
2.37.1