Skip to contentSkip to conversation

examples/ipsec-secgw: fix flow pattern buffer overrun

PATCH Applied [email protected] 2 participants 2 messages Aug 3, 2022 – Aug 28, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 examples/ipsec-secgw: fix flow pattern buffer overrun

From: Satheesh Paul <[email protected]>

This patch fixes the patterns buffer overrun issue reported by Coverity.

Coverity issue: 379236

Fixes 8d0cdaa2d7 ("examples/ipsec-secgw: support mark and security flow action")
---
 examples/ipsec-secgw/flow.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
examples/ipsec-secgw/flow.c +2 -4
index aee97b2fc4..9b18be83af 100644
@@ -270,7 +270,7 @@ parse_flow_tokens(char **tokens, uint32_t n_tokens,
 	nb_flow_rule++;
 }
 
-#define MAX_RTE_FLOW_PATTERN (4)
+#define MAX_RTE_FLOW_PATTERN (5)
 #define MAX_RTE_FLOW_ACTIONS (5)
 
 static void
@@ -334,9 +334,7 @@ flow_init_single(struct flow_rule_entry *rule)
 		pattern[pattern_idx].spec = &rule->ipv4.spec;
 		pattern[pattern_idx].mask = &rule->ipv4.mask;
 		pattern_idx++;
-	}
-
-	if (rule->is_ipv6) {
+	} else if (rule->is_ipv6) {
 		pattern[pattern_idx].type = RTE_FLOW_ITEM_TYPE_IPV6;
 		pattern[pattern_idx].spec = &rule->ipv6.spec;
 		pattern[pattern_idx].mask = &rule->ipv6.mask;
Signature · 1 line
2.35.3
Applied
#1 lore raw
Quoted 8 lines

From: Satheesh Paul <[email protected]>

This patch fixes the patterns buffer overrun issue reported by Coverity.

Coverity issue: 379236

Fixes 8d0cdaa2d7 ("examples/ipsec-secgw: support mark and security flow

action")

Fixes tag is not correct.
Changed to: b3a4baf87f44 ("examples/ipsec-secgw: support more flow patterns and actions") While merging.

Quoted 4 lines

Applied to dpdk-next-crypto