Skip to contentSkip to conversation

support/scripts/pkg-stats: add linebreak opportunity in CPE ID

PATCH Applied Sen Hastings 2 participants 2 messages Aug 3, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support/scripts/pkg-stats: add linebreak opportunity in CPE ID

This adds an optional linebreak at the vendor attribute in the CPE ID.

It should be noted this is purely for formatting/layout purposes and does not actually insert any additional characters (newline or otherwise) into the rendered text.

This means that even though the text renders across two lines, copy-pasting will still yield one line of text.

example: https://sen-h.github.io/pkg-stats/c245575.html

see also: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/wbr

---
 support/scripts/pkg-stats | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
support/scripts/pkg-stats +3 -1
index 91d42206ca..d32abd7225 100755
@@ -1102,7 +1102,9 @@ def dump_html_pkg(f, pkg):
         div_class.append("cpe-unknown")
     f.write(f'  <div id=\"{data_field_id}\" class=\"{" ".join(div_class)}\">\n')
     if pkg.cpeid:
-        f.write("  <code>%s</code>\n" % pkg.cpeid)
+        cpeid_begin = ":".join(pkg.cpeid.split(":")[0:4]) + ":"
+        cpeid_formatted = pkg.cpeid.replace(cpeid_begin, cpeid_begin + "<wbr>")
+        f.write("  <code>%s</code>\n" % cpeid_formatted)
     if not pkg.is_status_ok("cpe"):
         if pkg.is_actual_package and pkg.current_version:
             if pkg.cpeid:
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 9 lines · On Wed, 3 Aug 2022 10:33:24 -0500 Sen Hastings <[email protected]> wrote:

This adds an optional linebreak at the vendor attribute in the CPE ID.

It should be noted this is purely for formatting/layout purposes and does not actually insert any additional characters (newline or otherwise) into the rendered text.

This means that even though the text renders across two lines, copy-pasting will still yield one line of text.

Quoted 8 lines

example: https://sen-h.github.io/pkg-stats/c245575.html

see also: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/wbr

---
 support/scripts/pkg-stats | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Applied to master, thanks.

I had initially thought we would add a <wbr> at every : separator in the CPE ID. Your choice to add only one after the 4th field makes the code slightly more complex, but probably avoids wrapping occurring at too many different locations. So I've applied as-is, we can always revisit/improve if needed later.

Thanks a lot!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot