Skip to contentSkip to conversation

drm: panel-orientation-quirks: Add quirk for Anbernic Win600

PATCH In review Maccraft123 2 participants 5 messages Aug 3, 2022 – Sep 17, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: panel-orientation-quirks: Add quirk for Anbernic Win600

From: Maya Matuszczyk <[email protected]>

This device is another x86 gaming handheld, and as (hopefully) there is only one set of DMI IDs it's using DMI_EXACT_MATCH

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +6 -0
index d4e0f2e85548..a8681610ede7 100644
@@ -128,6 +128,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* Anbernic Win600 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Anbernic"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
+		},
+		.driver_data = (void *)&lcd720x1280_rightside_up,
 	}, {	/* Asus T100HA */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
Signature · 1 line
2.37.1
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 6 lines · On 8/3/22 20:24, Maccraft123 wrote:

From: Maya Matuszczyk <[email protected]>

This device is another x86 gaming handheld, and as (hopefully) there is only one set of DMI IDs it's using DMI_EXACT_MATCH

Thanks, patch looks good to me:

Since we are currently in the middle of the merge window and this patch needs to go to a -fixes branch I'm not quite sure how to handle this.

Hopefully one of the drm-misc maintainers can pick this up (once rc1 is out?) .

Regards,

Hans

Quoted 21 lines
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +6 -0
index d4e0f2e85548..a8681610ede7 100644
@@ -128,6 +128,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* Anbernic Win600 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Anbernic"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
+		},
+		.driver_data = (void *)&lcd720x1280_rightside_up,
 	}, {	/* Asus T100HA */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
#2 lore raw

Hello,

czw., 4 sie 2022 o 10:32 Hans de Goede <[email protected]> napisał(a):

Quoted 13 lines

Hi,

Quoted 6 lines · On 8/3/22 20:24, Maccraft123 wrote:

From: Maya Matuszczyk <[email protected]>

This device is another x86 gaming handheld, and as (hopefully) there is only one set of DMI IDs it's using DMI_EXACT_MATCH

Thanks, patch looks good to me:

Quoted 8 lines

Since we are currently in the middle of the merge window and this patch needs to go to a -fixes branch I'm not quite sure how to handle this.

Hopefully one of the drm-misc maintainers can pick this up (once rc1 is out?) .

We're at -rc1 now, and -rc2 will likely release within couple of days, can anyone take a look at this patch now?

Best Regards,
Maya Matuszczyk

Quoted 29 lines

Regards,

Hans

Quoted 21 lines
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +6 -0
index d4e0f2e85548..a8681610ede7 100644
@@ -128,6 +128,12 @@ static const struct dmi_system_id orientation_data[] = {
                DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
              },
              .driver_data = (void *)&lcd800x1280_rightside_up,
+     }, {    /* Anbernic Win600 */
+             .matches = {
+               DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Anbernic"),
+               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
+             },
+             .driver_data = (void *)&lcd720x1280_rightside_up,
      }, {    /* Asus T100HA */
              .matches = {
                DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
#3 lore raw
In reply to Maccraft123

Hi,

Quoted 6 lines · On 8/3/22 20:24, Maccraft123 wrote:

From: Maya Matuszczyk <[email protected]>

This device is another x86 gaming handheld, and as (hopefully) there is only one set of DMI IDs it's using DMI_EXACT_MATCH

Thanks I have added this patch to my local drm-misc-next branch.

I will push this out to the official drm-misc-next branch after running some local tests.

(unfortunately it is too late now to push this to drm-misc-fixes for this cycle, sorry).

Regards,

Hans

Quoted 21 lines
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +6 -0
index d4e0f2e85548..a8681610ede7 100644
@@ -128,6 +128,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* Anbernic Win600 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Anbernic"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
+		},
+		.driver_data = (void *)&lcd720x1280_rightside_up,
 	}, {	/* Asus T100HA */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
#4 lore raw

Hello,

sob., 17 wrz 2022 o 15:04 Hans de Goede <[email protected]> napisał(a):

Quoted 9 lines

Hi,

Quoted 5 lines · On 8/3/22 20:24, Maccraft123 wrote:

From: Maya Matuszczyk <[email protected]>

This device is another x86 gaming handheld, and as (hopefully) there is only one set of DMI IDs it's using DMI_EXACT_MATCH

Quoted 6 lines
Quoted 1 line

Thanks I have added this patch to my local drm-misc-next branch.

I will push this out to the official drm-misc-next branch after running some local tests.

Can you also take a look at this patch too?
https://patchwork.freedesktop.org/patch/499589/

Best Regards,
Maya Matuszczyk

Quoted 32 lines

(unfortunately it is too late now to push this to drm-misc-fixes for this cycle, sorry).

Regards,

Hans

Quoted 21 lines
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +6 -0
index d4e0f2e85548..a8681610ede7 100644
@@ -128,6 +128,12 @@ static const struct dmi_system_id orientation_data[] = {
                DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
              },
              .driver_data = (void *)&lcd800x1280_rightside_up,
+     }, {    /* Anbernic Win600 */
+             .matches = {
+               DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Anbernic"),
+               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
+             },
+             .driver_data = (void *)&lcd720x1280_rightside_up,
      }, {    /* Asus T100HA */
              .matches = {
                DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),