ASoC: SOF: ipc3-topology: Fix clang -Wformat warning
Subsystems (3)
PATCH RESEND 1/1 ASoC: SOF: ipc3-topology: Fix clang -Wformat warning
When building with Clang we encounter these warnings:
| sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~
Use correct format specifier %d since args are of type int.
---
Note: resending with the subject corrected, this patch fixes a build warning that will break the Clang build when CONFIG_WERROR=y.
Original patch: https://lore.kernel.org/all/[email protected]/
Reported by Nathan here: https://lore.kernel.org/all/[email protected]/
sound/soc/sof/ipc3-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sof/ipc3-topology.c +1 -1
@@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index, }dev_info (scomp->dev, -"Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n" , +"Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n" , man->priv.data[0 ], man->priv.data[1 ], man->priv.data[2 ],SOF_ABI_MAJOR ,SOF_ABI_MINOR ,SOF_ABI_PATCH );
Signature · 1 line
2.37.1.359.gd136c6c3e2-goog
Quoted 6 lines · Justin Stitt
When building with Clang we encounter these warnings:
| sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~
Quoted 6 lines
Use correct format specifier
%dsince args are of type int.Reported-by Nathan Chancellor <[email protected]>Suggested-by Nathan Chancellor <[email protected]>Signed-off-by Justin Stitt <[email protected]>
Thanks for resending!
Quoted 26 lines
---
Note: resending with the subject corrected, this patch fixes a build warning that will break the Clang build whenCONFIG_WERROR=y.Original patch: https://lore.kernel.org/all/[email protected]/
Reported by Nathan here: https://lore.kernel.org/all/[email protected]/sound/soc/sof/ipc3-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/soc/sof/ipc3-topology.c +1
-1@@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index, }dev_info (scomp->dev, -"Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n" , +"Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n" , man->priv.data[0 ], man->priv.data[1 ], man->priv.data[2 ],SOF_ABI_MAJOR ,SOF_ABI_MINOR ,SOF_ABI_PATCH );Signature · 1 line
2.37.1.359.gd136c6c3e2-goog
Pierre-Louis Bossart
Acked-byQuoted 9 lines · Nathan Chancellor
Quoted 8 lines · Justin Stitt
When building with Clang we encounter these warnings:
| sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~Use correct format specifier
%dsince args are of type int.
Quoted 8 lines
Quoted 4 lines
Reported-by Nathan Chancellor <[email protected]>Suggested-by Nathan Chancellor <[email protected]>Signed-off-by Justin Stitt <[email protected]>Thanks for resending!
Reviewed-by Nathan Chancellor <[email protected]>
Quoted 27 lines
Quoted 27 lines
---
Note: resending with the subject corrected, this patch fixes a build warning that will break the Clang build whenCONFIG_WERROR=y.Original patch: https://lore.kernel.org/all/[email protected]/
Reported by Nathan here: https://lore.kernel.org/all/[email protected]/sound/soc/sof/ipc3-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/soc/sof/ipc3-topology.c +1
-1@@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index, }dev_info (scomp->dev, -"Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n" , +"Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n" , man->priv.data[0 ], man->priv.data[1 ], man->priv.data[2 ],SOF_ABI_MAJOR ,SOF_ABI_MINOR ,SOF_ABI_PATCH );Signature · 1 line
2.37.1.359.gd136c6c3e2-goog
Mark Brown
maintainerQuoted 9 lines · Justin Stitt
When building with Clang we encounter these warnings:
| sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~Use correct format specifier
%dsince args are of type int.[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: SOF: ipc3-topology: Fix clang -Wformat warning
commit: b7bf23c0865faac61564425ddc96a4a79ebf19b0
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark