Skip to contentSkip to conversation

crypto: keembay-ocs - Drop obsolete dependency on COMPILE_TEST

PATCH In review Jean Delvare 2 participants 2 messages Aug 3, 2022 – Aug 19, 2022 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: keembay-ocs - Drop obsolete dependency on COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues.

Cc Declan Murphy <[email protected]>
Cc Daniele Alessandrelli <[email protected]>
Cc Mark Gross <[email protected]>
Cc Herbert Xu <[email protected]>
Cc Prabhjot Khurana <[email protected]>
Cc "David S. Miller" <[email protected]>
---
 drivers/crypto/keembay/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/keembay/Kconfig +2 -2
@@ -42,7 +42,7 @@ config CRYPTO_DEV_KEEMBAY_OCS_AES_SM4_CT
 config CRYPTO_DEV_KEEMBAY_OCS_ECC
 	tristate "Support for Intel Keem Bay OCS ECC HW acceleration"
 	depends on ARCH_KEEMBAY || COMPILE_TEST
-	depends on OF || COMPILE_TEST
+	depends on OF
 	depends on HAS_IOMEM
 	select CRYPTO_ECDH
 	select CRYPTO_ENGINE
@@ -64,7 +64,7 @@ config CRYPTO_DEV_KEEMBAY_OCS_HCU
 	select CRYPTO_ENGINE
 	depends on HAS_IOMEM
 	depends on ARCH_KEEMBAY || COMPILE_TEST
-	depends on OF || COMPILE_TEST
+	depends on OF
 	help
 	  Support for Intel Keem Bay Offload and Crypto Subsystem (OCS) Hash
 	  Control Unit (HCU) hardware acceleration for use with Crypto API.
Signature · 2 lines
Jean Delvare
SUSE L3 Support
maintainer
#1 lore raw
Quoted 20 lines · Jean Delvare

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues.

Cc Declan Murphy <[email protected]>
Cc Daniele Alessandrelli <[email protected]>
Cc Mark Gross <[email protected]>
Cc Herbert Xu <[email protected]>
Cc Prabhjot Khurana <[email protected]>
Cc "David S. Miller" <[email protected]>
Quoted 3 lines
---
 drivers/crypto/keembay/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt