f2fs: do not set compression bit if kernel doesn't support
Jaegeuk Kim
maintainerPATCH 1/1 f2fs: do not set compression bit if kernel doesn't support
If kernel doesn't have CONFIG_F2FS_FS_COMPRESSION, a file having FS_COMPR_FL via ioctl(FS_IOC_SETFLAGS) is unaccessible due to f2fs_is_compress_backend_ready(). Let's avoid it.
Signed-off-by Jaegeuk Kim <[email protected]>
--- fs/f2fs/f2fs.h | 7 ++++++- fs/f2fs/file.c | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-)
fs/f2fs/f2fs.h +6 -1
@@ -4295,8 +4295,9 @@ static inline void f2fs_update_extent_tree_range_compressed(struct inode *inode, unsigned int c_len) { }#endif -static inline void set_compress_context (struct inode *inode) +static inline int set_compress_context (struct inode *inode) { +#ifdef CONFIG_F2FS_FS_COMPRESSION struct f2fs_sb_info *sbi =F2FS_I_SB (inode); F2FS_I(inode)->i_compress_algorithm =
@@ -4319,6 +4320,10 @@ static inline void set_compress_context(struct inode *inode)stat_inc_compr_inode (inode);inc_compr_inode_stat (inode);f2fs_mark_inode_dirty_sync (inode, true); +return 0 ; +#else +return -EOPNOTSUPP ; +#endif }static inline bool f2fs_disable_compressed_file (struct inode *inode)
fs/f2fs/file.c +2 -2
@@ -1878,8 +1878,8 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)return -EINVAL ;if (S_ISREG (inode->i_mode) &&F2FS_HAS_BLOCKS (inode))return -EINVAL ; - -set_compress_context (inode); +if (set_compress_context (inode)) +return -EOPNOTSUPP ; } }
Signature · 8 lines
2.37.1.455.g008518b4e5-goog _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 5 lines · Jaegeuk Kim
If kernel doesn't have
CONFIG_F2FS_FS_COMPRESSION, a file havingFS_COMPR_FLviaioctl(FS_IOC_SETFLAGS)is unaccessible due tof2fs_is_compress_backend_ready(). Let's avoid it.Signed-off-by Jaegeuk Kim <[email protected]>
Reviewed-by Chao Yu <[email protected]>
Thanks,