Skip to contentSkip to conversation

Backport "printk: Export is_console_locked"

PATCH In review Chen Jun 2 participants 3 messages Aug 4, 2022 Stable branch

lore
Share & tools
lore

Chen Jun

author
#0 lore raw

cover Backport "printk: Export is_console_locked"

https://lore.kernel.org/stable/[email protected]/
will make build failed if CONFIG_FB = M.
The error is:
ERROR: "is_console_locked" [drivers/video/fbdev/core/fb.ko] undefined!

To fix it, backport d48de54a9dab ("printk: Export is_console_locked").

Hans de Goede (1):
printk: Export is_console_locked

 kernel/printk/printk.c | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/1 printk: Export is_console_locked

From: Hans de Goede <[email protected]>

commit d48de54a9dab5370edd2e991f78cc7996cf5483e upstream

This is a preparation patch for adding a number of WARN_CONSOLE_UNLOCKED() calls to the fbcon code, which may be built as a module (event though usually it is not).

---
 kernel/printk/printk.c | 1 +
 1 file changed, 1 insertion(+)
kernel/printk/printk.c +1 -0
index 11173d0b51bc..ad4772869d48 100644
@@ -2259,6 +2259,7 @@ int is_console_locked(void)
 {
 	return console_locked;
 }
+EXPORT_SYMBOL(is_console_locked);
 
 /*
  * Check if we have any console that is capable of printing while cpu is
Signature · 1 line
2.17.1
maintainer
#2 lore raw

Re: [PATCH stable 4.14 1/1] printk: Export is_console_locked

Quoted 34 lines · Chen Jun

From: Hans de Goede <[email protected]>

commit d48de54a9dab5370edd2e991f78cc7996cf5483e upstream

This is a preparation patch for adding a number of WARN_CONSOLE_UNLOCKED() calls to the fbcon code, which may be built as a module (event though usually it is not).

---
 kernel/printk/printk.c | 1 +
 1 file changed, 1 insertion(+)
kernel/printk/printk.c +1 -0
index 11173d0b51bc..ad4772869d48 100644
@@ -2259,6 +2259,7 @@ int is_console_locked(void)
 {
 	return console_locked;
 }
+EXPORT_SYMBOL(is_console_locked);
 
 /*
  * Check if we have any console that is capable of printing while cpu is
Signature · 1 line
2.17.1

This patch makes no sense on it's own, please make it part of a larger series that requires it.

Also, for some reason you didn't cc: all of the people involved in the change, which is a bit odd.

thanks,

greg k-h