media: imx-jpeg: Disable useless interrupt to avoid kernel panic
PATCH 1/1 media: imx-jpeg: Disable useless interrupt to avoid kernel panic
There is a hardware bug that the interrupt STMBUF_HALF may be triggered after or when disable interrupt.
It may led to unexpected kernel panic.
And interrupt STMBUF_HALF and STMBUF_RTND have no other effect. So disable them and the unused interrupts.
meanwhile clear the interrupt status when disable interrupt.
Signed-off-by Ming Qian <[email protected]>
--- drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c +3 -1
@@ -76,12 +76,14 @@ void print_wrapper_info(struct device *dev, void __iomem *reg)void mxc_jpeg_enable_irq (void __iomem *reg,int slot) { -writel (0xFFFFFFFF , reg +MXC_SLOT_OFFSET (slot,SLOT_IRQ_EN )); +writel (0xFFFFFFFF , reg +MXC_SLOT_OFFSET (slot,SLOT_STATUS )); +writel (0xF0C , reg +MXC_SLOT_OFFSET (slot,SLOT_IRQ_EN )); }void mxc_jpeg_disable_irq (void __iomem *reg,int slot) {writel (0x0 , reg +MXC_SLOT_OFFSET (slot,SLOT_IRQ_EN )); +writel (0xFFFFFFFF , reg +MXC_SLOT_OFFSET (slot,SLOT_STATUS )); }void mxc_jpeg_sw_reset (void __iomem *reg)
Signature · 1 line
2.37.1
Quoted 10 lines · Ming Qian
There is a hardware bug that the interrupt
STMBUF_HALFmay be triggered
after or when disable interrupt.
It may led to unexpected kernel panic.
And interruptSTMBUF_HALFandSTMBUF_RTNDhave no other effect. So disable them and the unused interrupts.meanwhile clear the interrupt status when disable interrupt.
Signed-off-by Ming Qian <[email protected]>
Reviewed-by Mirela Rabulea <[email protected]>
Quoted 26 lines
--- drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c +3
-1@@ -76,12 +76,14 @@ void print_wrapper_info(struct device *dev, void __iomem *reg)void mxc_jpeg_enable_irq (void __iomem *reg,int slot) { -writel (0xFFFFFFFF , reg +MXC_SLOT_OFFSET (slot,SLOT_IRQ_EN )); +writel (0xFFFFFFFF , reg +MXC_SLOT_OFFSET (slot,SLOT_STATUS )); +writel (0xF0C , reg +MXC_SLOT_OFFSET (slot,SLOT_IRQ_EN )); }void mxc_jpeg_disable_irq (void __iomem *reg,int slot) {writel (0x0 , reg +MXC_SLOT_OFFSET (slot,SLOT_IRQ_EN )); +writel (0xFFFFFFFF , reg +MXC_SLOT_OFFSET (slot,SLOT_STATUS )); }void
mxc_jpeg_sw_reset(void __iomem *reg)