Skip to contentSkip to conversation

misc: atsha204a: Don't check for error when waking up the device

PATCH In review Pali Rohár 4 participants 7 messages Aug 4, 2022 – Aug 9, 2022 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc: atsha204a: Don't check for error when waking up the device

The device ignores any levels or transitions on the SCL pin when the device is idle, asleep or during waking up.

Linux kernel driver for atsha204a (atmel-sha204a.ko) also ignores return value from i2c wakeup send command, see:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/crypto/atmel-i2c.c?h=v5.19#n174

And also userspace Turris libatsha204 library ignores return value from wakeup send command, see:
https://gitlab.nic.cz/turris/libatsha204/-/blob/v29.2/src/libatsha204/layer_ni2c.c#L75-76

U-Boot driver should do same thing.

Fixes waking up ATSHA204 on Turris 1.x boards.

---
 drivers/misc/atsha204a-i2c.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/misc/atsha204a-i2c.c +6 -5
index 81ecb5b6177b..fa2d5948f128 100644
@@ -103,12 +103,13 @@ int atsha204a_wakeup(struct udevice *dev)
 	for (try = 1; try <= 10; ++try) {
 		debug("Try %i... ", try);
 
+		/*
+		 * The device ignores any levels or transitions on the SCL pin
+		 * when the device is idle, asleep or during waking up.
+		 * Don't check for error when waking up the device.
+		 */
 		memset(req, 0, 4);
-		res = atsha204a_send(dev, req, 4);
-		if (res) {
-			debug("failed on I2C send, trying again\n");
-			continue;
-		}
+		atsha204a_send(dev, req, 4);
 
 		udelay(ATSHA204A_TWLO_US + ATSHA204A_TWHI_US);
 
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Pali Rohár

The device ignores any levels or transitions on the SCL pin when the device is idle, asleep or during waking up.

Linux kernel driver for atsha204a (atmel-sha204a.ko) also ignores return value from i2c wakeup send command, see:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/crypto/atmel-i2c.c?h=v5.19#n174

And also userspace Turris libatsha204 library ignores return value from wakeup send command, see:
https://gitlab.nic.cz/turris/libatsha204/-/blob/v29.2/src/libatsha204/layer_ni2c.c#L75-76

Quoted 5 lines

U-Boot driver should do same thing.

Fixes waking up ATSHA204 on Turris 1.x boards.

Thanks,
Stefan

Quoted 17 lines
---
  drivers/misc/atsha204a-i2c.c | 11 ++++++-----
  1 file changed, 6 insertions(+), 5 deletions(-)
drivers/misc/atsha204a-i2c.c +5 -0
index 81ecb5b6177b..fa2d5948f128 100644
@@ -103,12 +103,13 @@ int atsha204a_wakeup(struct udevice *dev)
  	for (try = 1; try <= 10; ++try) {
  		debug("Try %i... ", try);
 
+		/*
+		 * The device ignores any levels or transitions on the SCL pin
+		 * when the device is idle, asleep or during waking up.
+		 * Don't check for error when waking up the device.
+		 */

drivers/misc/atsha204a-i2c.c int atsha204a_wakeup(struct udevice *dev) · line 115

Quoted 10 lines
drivers/misc/atsha204a-i2c.c +1 -5
  		memset(req, 0, 4);
-		res = atsha204a_send(dev, req, 4);
-		if (res) {
-			debug("failed on I2C send, trying again\n");
-			continue;
-		}
+		atsha204a_send(dev, req, 4);
 
  		udelay(ATSHA204A_TWLO_US + ATSHA204A_TWHI_US);
 

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#2 lore raw
In reply to Pali Rohár

Paweł, could you please test this change if it works on your board? I was that you were fixing another wakeup issue in patch "misc: atsha204a:
Increase wake delay by tWHI".

Quoted 46 lines · On Thursday 04 August 2022 13:03:44 Pali Rohár wrote:

The device ignores any levels or transitions on the SCL pin when the device is idle, asleep or during waking up.

Linux kernel driver for atsha204a (atmel-sha204a.ko) also ignores return value from i2c wakeup send command, see:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/crypto/atmel-i2c.c?h=v5.19#n174

And also userspace Turris libatsha204 library ignores return value from wakeup send command, see:
https://gitlab.nic.cz/turris/libatsha204/-/blob/v29.2/src/libatsha204/layer_ni2c.c#L75-76

U-Boot driver should do same thing.

Fixes waking up ATSHA204 on Turris 1.x boards.

---
 drivers/misc/atsha204a-i2c.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/misc/atsha204a-i2c.c +6 -5
index 81ecb5b6177b..fa2d5948f128 100644
@@ -103,12 +103,13 @@ int atsha204a_wakeup(struct udevice *dev)
 	for (try = 1; try <= 10; ++try) {
 		debug("Try %i... ", try);
 
+		/*
+		 * The device ignores any levels or transitions on the SCL pin
+		 * when the device is idle, asleep or during waking up.
+		 * Don't check for error when waking up the device.
+		 */
 		memset(req, 0, 4);
-		res = atsha204a_send(dev, req, 4);
-		if (res) {
-			debug("failed on I2C send, trying again\n");
-			continue;
-		}
+		atsha204a_send(dev, req, 4);
 
 		udelay(ATSHA204A_TWLO_US + ATSHA204A_TWHI_US);
 
Signature · 1 line
2.20.1
Tested-by
#3 lore raw

Hi Pali,

I applied the patch and it works fine on my board. Log from atsha204a_wakeup():
Waking up ATSHA204A
Try 1... success

Regards,
Paweł

Quoted 52 lines · Pali Rohár

Paweł, could you please test this change if it works on your board? I was that you were fixing another wakeup issue in patch "misc: atsha204a:
Increase wake delay by tWHI".

Quoted 46 lines · On Thursday 04 August 2022 13:03:44 Pali Rohár wrote:

The device ignores any levels or transitions on the SCL pin when the device is idle, asleep or during waking up.

Linux kernel driver for atsha204a (atmel-sha204a.ko) also ignores return value from i2c wakeup send command, see:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/crypto/atmel-i2c.c?h=v5.19#n174

And also userspace Turris libatsha204 library ignores return value from wakeup send command, see:
https://gitlab.nic.cz/turris/libatsha204/-/blob/v29.2/src/libatsha204/layer_ni2c.c#L75-76

U-Boot driver should do same thing.

Fixes waking up ATSHA204 on Turris 1.x boards.

---
 drivers/misc/atsha204a-i2c.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/misc/atsha204a-i2c.c +6 -6
index 81ecb5b6177b..fa2d5948f128 100644
@@ -103,12 +103,13 @@ int atsha204a_wakeup(struct udevice *dev)
      for (try = 1; try <= 10; ++try) {
              debug("Try %i... ", try);
 
+             /*
+              * The device ignores any levels or transitions on the SCL pin
+              * when the device is idle, asleep or during waking up.
+              * Don't check for error when waking up the device.
+              */
              memset(req, 0, 4);
-             res = atsha204a_send(dev, req, 4);
-             if (res) {
-                     debug("failed on I2C send, trying again\n");
-                     continue;
-             }
+             atsha204a_send(dev, req, 4);
 
              udelay(ATSHA204A_TWLO_US + ATSHA204A_TWHI_US);
 
--

2.20.1

Reviewed-by on v1 1/1
#4 lore raw
In reply to Pali Rohár
Quoted 11 lines · On Thu, 4 Aug 2022 13:03:44 +0200 Pali Rohár <[email protected]> wrote:

The device ignores any levels or transitions on the SCL pin when the device is idle, asleep or during waking up.

Linux kernel driver for atsha204a (atmel-sha204a.ko) also ignores return value from i2c wakeup send command, see:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/crypto/atmel-i2c.c?h=v5.19#n174

And also userspace Turris libatsha204 library ignores return value from wakeup send command, see:
https://gitlab.nic.cz/turris/libatsha204/-/blob/v29.2/src/libatsha204/layer_ni2c.c#L75-76

Quoted 5 lines

U-Boot driver should do same thing.

Fixes waking up ATSHA204 on Turris 1.x boards.

Stefan, will you apply this via marvell?

#5 lore raw
Quoted 16 lines · Marek Behún
Quoted 13 lines · On Thu, 4 Aug 2022 13:03:44 +0200 Pali Rohár <[email protected]> wrote:

The device ignores any levels or transitions on the SCL pin when the device is idle, asleep or during waking up.

Linux kernel driver for atsha204a (atmel-sha204a.ko) also ignores return value from i2c wakeup send command, see:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/crypto/atmel-i2c.c?h=v5.19#n174

And also userspace Turris libatsha204 library ignores return value from wakeup send command, see:
https://gitlab.nic.cz/turris/libatsha204/-/blob/v29.2/src/libatsha204/layer_ni2c.c#L75-76

U-Boot driver should do same thing.

Quoted 7 lines
Quoted 3 lines

Fixes waking up ATSHA204 on Turris 1.x boards.

Stefan, will you apply this via marvell?

I can do this, let me check. I plan to send a pull request soon anyways.

Thanks,
Stefan

#6 lore raw
In reply to Pali Rohár
Quoted 11 lines · Pali Rohár

The device ignores any levels or transitions on the SCL pin when the device is idle, asleep or during waking up.

Linux kernel driver for atsha204a (atmel-sha204a.ko) also ignores return value from i2c wakeup send command, see:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/crypto/atmel-i2c.c?h=v5.19#n174

And also userspace Turris libatsha204 library ignores return value from wakeup send command, see:
https://gitlab.nic.cz/turris/libatsha204/-/blob/v29.2/src/libatsha204/layer_ni2c.c#L75-76

Quoted 5 lines

U-Boot driver should do same thing.

Fixes waking up ATSHA204 on Turris 1.x boards.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 17 lines
---
  drivers/misc/atsha204a-i2c.c | 11 ++++++-----
  1 file changed, 6 insertions(+), 5 deletions(-)
drivers/misc/atsha204a-i2c.c +5 -0
index 81ecb5b6177b..fa2d5948f128 100644
@@ -103,12 +103,13 @@ int atsha204a_wakeup(struct udevice *dev)
  	for (try = 1; try <= 10; ++try) {
  		debug("Try %i... ", try);
 
+		/*
+		 * The device ignores any levels or transitions on the SCL pin
+		 * when the device is idle, asleep or during waking up.
+		 * Don't check for error when waking up the device.
+		 */

drivers/misc/atsha204a-i2c.c int atsha204a_wakeup(struct udevice *dev) · line 115

Quoted 10 lines
drivers/misc/atsha204a-i2c.c +1 -5
  		memset(req, 0, 4);
-		res = atsha204a_send(dev, req, 4);
-		if (res) {
-			debug("failed on I2C send, trying again\n");
-			continue;
-		}
+		atsha204a_send(dev, req, 4);
 
  		udelay(ATSHA204A_TWLO_US + ATSHA204A_TWHI_US);
 

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]