Skip to contentSkip to conversation

dt-binding: ipmi: add fallback to npcm845 compatible

PATCH Superseded Tomer Maimon 3 participants 4 messages Aug 4, 2022

Subsystems (3)
Device tree bindings IPMI Arm/nuvoton npcm architecture

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Tomer Maimon

author maintainer
#0 lore raw

PATCH 1/1 dt-binding: ipmi: add fallback to npcm845 compatible

Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible string.

Signed-off-by Tomer Maimon <[email protected]>
---
 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt +1 -1
index cbc10a68ddef..4fda76e63396 100644
@@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
 Required properties:
 - compatible : should be one of
     "nuvoton,npcm750-kcs-bmc"
-    "nuvoton,npcm845-kcs-bmc"
+    "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
 - interrupts : interrupt generated by the controller
 - kcs_chan : The KCS channel number in the controller
Signature · 1 line
2.33.0
#1 lore raw

Dear Tomer,

Am 04.08.22 um 16:55 schrieb Tomer Maimon:

Quoted 13 lines

Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible string.

Signed-off-by Tomer Maimon <[email protected]>
---
  Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt +0 -0
index cbc10a68ddef..4fda76e63396 100644

Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt used to perform in-band IPMI communication with their host. · line 10

Quoted 5 lines
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt +1 -1
@@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
  Required properties:
  - compatible : should be one of
      "nuvoton,npcm750-kcs-bmc"
-    "nuvoton,npcm845-kcs-bmc"
+    "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"

Isn’t the added string exactly the same as the one below the compatible line?

Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt used to perform in-band IPMI communication with their host. · line 12

Quoted 2 lines
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt +0 -0
  - interrupts : interrupt generated by the controller
  - kcs_chan : The KCS channel number in the controller

Kind regards,

Paul

author maintainer
#2 lore raw

Hi Paul,

Quoted 13 lines · Paul Menzel

Dear Tomer,

Am 04.08.22 um 16:55 schrieb Tomer Maimon:

Quoted 8 lines

Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible string.

Signed-off-by Tomer Maimon <[email protected]>
---
  Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt used to perform in-band IPMI communication with their host. · line 10

Quoted 10 lines
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt +1 -1
index cbc10a68ddef..4fda76e63396 100644
@@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
  Required properties:
  - compatible : should be one of
      "nuvoton,npcm750-kcs-bmc"
-    "nuvoton,npcm845-kcs-bmc"
+    "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"

Isn’t the added string exactly the same as the one below the compatible line?

it is not the same, it describes a fallback to NPCM7XX KCS Since NPCM8XX KCS and NPCM7XX KCS modules are similar.

Quoted 8 lines

Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt used to perform in-band IPMI communication with their host. · line 12

Quoted 3 lines
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt +0 -0
  - interrupts : interrupt generated by the controller
  - kcs_chan : The KCS channel number in the controller

Kind regards,

Paul

Best regards,

Tomer

#3 lore raw
In reply to Tomer Maimon
Quoted 2 lines · Tomer Maimon

Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible string.

It's easily visible in the code what you are doing, so instead you must explain why you are doing it.

Best regards,
Krzysztof