Skip to contentSkip to conversation

arm-toolchain/layer.conf: remove BB_DANGLINGAPPENDS_WARNONLY

PATCH In review Martin Jansa 4 participants 5 messages Aug 4, 2022 – Aug 8, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm-toolchain/layer.conf: remove BB_DANGLINGAPPENDS_WARNONLY

From: Ross Burton <[email protected]>

This appears to be historical from when the toolchain was in meta-linaro.

It isn't needed anymore, there's one bbappend in meta-arm-toolchain for grub which is part of oe-core, so will never be dangling.

This variable has a global effect, so leaving it in here has a negative impact on users.

---
 meta-arm-toolchain/conf/layer.conf | 3 ---
 1 file changed, 3 deletions(-)
meta-arm-toolchain/conf/layer.conf +0 -3
index 3512c34..dd54db8 100644
@@ -11,8 +11,5 @@ BBFILE_PRIORITY_arm-toolchain = "5"
 LAYERDEPENDS_arm-toolchain = "core"
 LAYERSERIES_COMPAT_arm-toolchain = "kirkstone"
 
-# do not error out on bbappends for missing recipes
-BB_DANGLINGAPPENDS_WARNONLY = "true"
-
 # These variables are used for armcompiler license
 BB_BASEHASH_IGNORE_VARS:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
Signature · 1 line
2.35.1
#1 lore raw

Odd email format. I beleive you are asking me to apply this patch to kirkstone. If not, please let me know.

Sumit/Denys, should I apply this all the way back to dunfell (as the grub entry is there in this oldest branch)?

Thanks,
Jon

Quoted 33 lines · Martin Jansa

From: Ross Burton <[email protected]>

This appears to be historical from when the toolchain was in meta-linaro.

It isn't needed anymore, there's one bbappend in meta-arm-toolchain for grub which is part of oe-core, so will never be dangling.

This variable has a global effect, so leaving it in here has a negative impact on users.

---
 meta-arm-toolchain/conf/layer.conf | 3 ---
 1 file changed, 3 deletions(-)
meta-arm-toolchain/conf/layer.conf +0 -3
index 3512c34..dd54db8 100644
@@ -11,8 +11,5 @@ BBFILE_PRIORITY_arm-toolchain = "5"
 LAYERDEPENDS_arm-toolchain = "core"
 LAYERSERIES_COMPAT_arm-toolchain = "kirkstone"
 
-# do not error out on bbappends for missing recipes
-BB_DANGLINGAPPENDS_WARNONLY = "true"
-
 # These variables are used for armcompiler license
 BB_BASEHASH_IGNORE_VARS:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
Signature · 1 line
2.35.1
#2 lore raw

Hi Jon,

Quoted 7 lines · Jon Mason

Odd email format. I beleive you are asking me to apply this patch to kirkstone. If not, please let me know.

Sumit/Denys, should I apply this all the way back to dunfell (as the grub entry is there in this oldest branch)?

Yeah, it makes sense.

-Sumit

Quoted 46 lines

Thanks,
Jon

Quoted 30 lines · Martin Jansa

From: Ross Burton <[email protected]>

This appears to be historical from when the toolchain was in meta-linaro.

It isn't needed anymore, there's one bbappend in meta-arm-toolchain for grub which is part of oe-core, so will never be dangling.

This variable has a global effect, so leaving it in here has a negative impact on users.

---
 meta-arm-toolchain/conf/layer.conf | 3 ---
 1 file changed, 3 deletions(-)
meta-arm-toolchain/conf/layer.conf +0 -4
index 3512c34..dd54db8 100644
@@ -11,8 +11,5 @@ BBFILE_PRIORITY_arm-toolchain = "5"
 LAYERDEPENDS_arm-toolchain = "core"
 LAYERSERIES_COMPAT_arm-toolchain = "kirkstone"
 
-# do not error out on bbappends for missing recipes
-BB_DANGLINGAPPENDS_WARNONLY = "true"
-
 # These variables are used for armcompiler license
 BB_BASEHASH_IGNORE_VARS:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
--
Quoted 3 lines

2.35.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#3642): https://lists.yoctoproject.org/g/meta-arm/message/3642
Mute This Topic: https://lists.yoctoproject.org/mt/92810132/1777089
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw
Quoted 4 lines · Sumit Garg

Hi Jon,

Quoted 1 line · Jon Mason
Quoted 8 lines
Quoted 6 lines

Odd email format. I beleive you are asking me to apply this patch to kirkstone. If not, please let me know.

Sumit/Denys, should I apply this all the way back to dunfell (as the grub entry is there in this oldest branch)?

Yeah, it makes sense.

I agree - this hasn't been needed for quite some time.

Signature · 1 line
Denys
Quoted 32 lines
Quoted 32 lines · Martin Jansa
Quoted 31 lines

From: Ross Burton <[email protected]>

This appears to be historical from when the toolchain was in meta-linaro.

It isn't needed anymore, there's one bbappend in meta-arm-toolchain for grub which is part of oe-core, so will never be dangling.

This variable has a global effect, so leaving it in here has a negative impact on users.

---
 meta-arm-toolchain/conf/layer.conf | 3 ---
 1 file changed, 3 deletions(-)
meta-arm-toolchain/conf/layer.conf +0 -4
index 3512c34..dd54db8 100644
@@ -11,8 +11,5 @@ BBFILE_PRIORITY_arm-toolchain = "5"
 LAYERDEPENDS_arm-toolchain = "core"
 LAYERSERIES_COMPAT_arm-toolchain = "kirkstone"
 
-# do not error out on bbappends for missing recipes
-BB_DANGLINGAPPENDS_WARNONLY = "true"
-
 # These variables are used for armcompiler license
 BB_BASEHASH_IGNORE_VARS:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
--

2.35.1

#4 lore raw
Quoted 8 lines · Denys Dmytriyenko
Quoted 7 lines · Sumit Garg

Hi Jon,

Quoted 4 lines · Jon Mason

Odd email format. I beleive you are asking me to apply this patch to kirkstone. If not, please let me know.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Sumit/Denys, should I apply this all the way back to dunfell (as the grub entry is there in this oldest branch)?

Yeah, it makes sense.

I agree - this hasn't been needed for quite some time.

Removing it has found a bug (of course). Testing a fix now. Sorry for the delay.

Thanks,
Jon

Quoted 37 lines
Signature · 1 line
Denys
Quoted 32 lines
Quoted 32 lines · Martin Jansa
Quoted 31 lines

From: Ross Burton <[email protected]>

This appears to be historical from when the toolchain was in meta-linaro.

It isn't needed anymore, there's one bbappend in meta-arm-toolchain for grub which is part of oe-core, so will never be dangling.

This variable has a global effect, so leaving it in here has a negative impact on users.

---
 meta-arm-toolchain/conf/layer.conf | 3 ---
 1 file changed, 3 deletions(-)
meta-arm-toolchain/conf/layer.conf +0 -4
index 3512c34..dd54db8 100644
@@ -11,8 +11,5 @@ BBFILE_PRIORITY_arm-toolchain = "5"
 LAYERDEPENDS_arm-toolchain = "core"
 LAYERSERIES_COMPAT_arm-toolchain = "kirkstone"
 
-# do not error out on bbappends for missing recipes
-BB_DANGLINGAPPENDS_WARNONLY = "true"
-
 # These variables are used for armcompiler license
 BB_BASEHASH_IGNORE_VARS:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
--

2.35.1