package/weston: add option to build seatd-based launcher
PATCH 1/1 package/weston: add option to build seatd-based launcher
Since version 10, the weston-launch command has been deprecated, and can only be built with -Ddeprecated-weston-launch=true, which Buildroot does not do.
So the only launcher currently available is logind, provided by systemd.
But weston provides an alternate way, based on the seatd daemon. This commit enables this possibility by adding an optional dependency on BR2_PACKAGE_SEATD and using -Dlauncher-libseat=true.
--- package/weston/weston.mk | 7 +++++++ 1 file changed, 7 insertions(+)
package/weston/weston.mk +7 -0
@@ -35,6 +35,13 @@ else WESTON_CONF_OPTS += -Dlauncher-logind=false endif +ifeq ($(BR2_PACKAGE_SEATD),y) +WESTON_CONF_OPTS += -Dlauncher-libseat=true +WESTON_DEPENDENCIES += seatd +else +WESTON_CONF_OPTS += -Dlauncher-libseat=false +endif + ifeq ($(BR2_PACKAGE_JPEG),y) WESTON_CONF_OPTS += -Dimage-jpeg=true WESTON_DEPENDENCIES += jpeg
Signature · 6 lines
2.37.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Yann E. MORIN
AppliedThomas, All,
On 2022-08-04 22:46 +0200, Thomas Petazzoni via buildroot spake thusly:
Quoted 4 lines
Since version 10, the weston-launch command has been deprecated, and can only be built with -Ddeprecated-weston-launch=true, which Buildroot does not do.
Quoted 8 lines
So the only launcher currently available is logind, provided by systemd.
But weston provides an alternate way, based on the seatd daemon. This commit enables this possibility by adding an optional dependency on
BR2_PACKAGE_SEATDand using -Dlauncher-libseat=true.Signed-off-by Thomas Petazzoni <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 29 lines
--- package/weston/weston.mk | 7 +++++++ 1 file changed, 7 insertions(+)package/weston/weston.mk +7
-0@@ -35,6 +35,13 @@ else WESTON_CONF_OPTS += -Dlauncher-logind=false endif +ifeq ($(BR2_PACKAGE_SEATD),y) +WESTON_CONF_OPTS += -Dlauncher-libseat=true +WESTON_DEPENDENCIES += seatd +else +WESTON_CONF_OPTS += -Dlauncher-libseat=false +endif + ifeq ($(BR2_PACKAGE_JPEG),y) WESTON_CONF_OPTS += -Dimage-jpeg=true WESTON_DEPENDENCIES += jpegSignature · 6 lines
2.37.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas, All,
On 2022-08-04 22:46 +0200, Thomas Petazzoni via buildroot spake thusly:
Quoted 6 lines
Since version 10, the weston-launch command has been deprecated, and can only be built with -Ddeprecated-weston-launch=true, which Buildroot does not do.
So the only launcher currently available is logind, provided by systemd.
Forgot to add in my previous reply...
Is a launcher mandatory? Should we en sure that at least one is present? I.e. if dbus+systemd is not set, then select seatd?
Regards,
Yann E. MORIN.
Quoted 34 lines
But weston provides an alternate way, based on the seatd daemon. This commit enables this possibility by adding an optional dependency on
BR2_PACKAGE_SEATDand using -Dlauncher-libseat=true.Signed-off-by Thomas Petazzoni <[email protected]>--- package/weston/weston.mk | 7 +++++++ 1 file changed, 7 insertions(+)package/weston/weston.mk +7
-0@@ -35,6 +35,13 @@ else WESTON_CONF_OPTS += -Dlauncher-logind=false endif +ifeq ($(BR2_PACKAGE_SEATD),y) +WESTON_CONF_OPTS += -Dlauncher-libseat=true +WESTON_DEPENDENCIES += seatd +else +WESTON_CONF_OPTS += -Dlauncher-libseat=false +endif + ifeq ($(BR2_PACKAGE_JPEG),y) WESTON_CONF_OPTS += -Dimage-jpeg=true WESTON_DEPENDENCIES += jpegSignature · 6 lines
2.37.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hello,
Quoted 5 lines · On Fri, 5 Aug 2022 18:57:05 +0200 "Yann E. MORIN" <[email protected]>…
On 2022-08-04 22:46 +0200, Thomas Petazzoni via buildroot spake thusly:
Quoted 4 lines
Since version 10, the weston-launch command has been deprecated, and can only be built with -Ddeprecated-weston-launch=true, which Buildroot does not do.
Quoted 7 lines
Quoted 2 lines
So the only launcher currently available is logind, provided by systemd.
Forgot to add in my previous reply...
Is a launcher mandatory? Should we en sure that at least one is present? I.e. if dbus+systemd is not set, then select seatd?
I am not 100% clear on this. My current understanding is indeed that a launcher is needed.
However, it would be possible to use the logind launcher with elogind, which is Gentoo's extract of logind from systemd as a standalone
project: https://wiki.gentoo.org/wiki/Elogind. Of course, we don't currently have elogind as a Buildroot package.
The options would be:
- logind launcher, with systemd
- logind launcher, with elogind
- libseat launcher, with seatd
Best regards,
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 13 lines · Thomas Petazzoni via buildroot
Hello,
Quoted 8 lines · On Fri, 5 Aug 2022 18:57:05 +0200 "Yann E. MORIN" <[email protected]>…
On 2022-08-04 22:46 +0200, Thomas Petazzoni via buildroot spake thusly:
Quoted 6 lines
Since version 10, the weston-launch command has been deprecated, and can only be built with -Ddeprecated-weston-launch=true, which Buildroot does not do.
So the only launcher currently available is logind, provided by systemd.
Quoted 7 lines
Quoted 4 lines
Forgot to add in my previous reply...
Is a launcher mandatory? Should we en sure that at least one is present? I.e. if dbus+systemd is not set, then select seatd?
I am not 100% clear on this. My current understanding is indeed that a launcher is needed.
My understanding is of course extremely limited, but I believe it is possible
(and relatively easy) to write your own launcher. This is relevant if you want to run a single application on Wayland (which is sometimes easier to get HW acceleration working in libraries than using DRM/Mesa directly).
So I think it's not really needed to force one of our "known" launchers on people.
This might be a use case for the newfangled "imply" Kconfig feature though.
Regards,
Arnout
Quoted 7 lines
However, it would be possible to use the logind launcher with elogind, which is Gentoo's extract of logind from systemd as a standalone
project: https://wiki.gentoo.org/wiki/Elogind. Of course, we don't currently have elogind as a Buildroot package.The options would be:
Quoted 7 lines
- logind launcher, with systemd
- logind launcher, with elogind
- libseat launcher, with seatdBest regards,
Thomas
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot