Skip to contentSkip to conversation

ipstats: Define MIN function to fix undefined references

PATCH In review Nick Hainke 2 participants 2 messages Aug 6, 2022 – Aug 17, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipstats: Define MIN function to fix undefined references

Fixes errors in the form of:
in function `ipstats_show_64':
<artificial>:(.text+0x4e30): undefined reference to `MIN'

---
 ip/ipstats.c | 4 ++++
 1 file changed, 4 insertions(+)
ip/ipstats.c +4 -0
index 5cdd15ae..2f500fc8 100644
@@ -6,6 +6,10 @@
 #include "utils.h"
 #include "ip_common.h"
 
+#ifndef MIN
+#define MIN(a, b) ((a) < (b) ? (a) : (b))
+#endif
+
 struct ipstats_stat_dump_filters {
 	/* mask[0] filters outer attributes. Then individual nests have their
 	 * filtering mask at the index of the nested attribute.
Signature · 1 line
2.37.1
#1 lore raw
Quoted 14 lines · On Sat, 6 Aug 2022 10:24:06 +0200 Nick Hainke <[email protected]> wrote:

Fixes errors in the form of:
in function `ipstats_show_64':
<artificial>:(.text+0x4e30): undefined reference to `MIN'

---
 ip/ipstats.c | 4 ++++
 1 file changed, 4 insertions(+)
ip/ipstats.c +0 -0
index 5cdd15ae..2f500fc8 100644

ip/ipstats.c line 15

Quoted 10 lines
ip/ipstats.c +4 -0
@@ -6,6 +6,10 @@
 #include "utils.h"
 #include "ip_common.h"
 
+#ifndef MIN
+#define MIN(a, b) ((a) < (b) ? (a) : (b))
+#endif
+
 struct ipstats_stat_dump_filters {
 	/* mask[0] filters outer attributes. Then individual nests have their
 	 * filtering mask at the index of the nested attribute

Not sure what non-standard headers you are using,
but this already addressed in main branch by:

commit cf6b60c504d4be5e1df2b2745e55d677967831d0

Author: Changhyeok Bae <[email protected]>
Date:   Tue Aug 9 04:01:05 2022 +0000

ipstats: Add param.h for musl

Fix build error for musl
| /usr/src/debug/iproute2/5.19.0-r0/iproute2-5.19.0/ip/ipstats.c:231: undefined reference to `MIN'