Add generic framebuffer support to EFI earlycon driver
Subsystems (6)
v2 cover Add generic framebuffer support to EFI earlycon driver
Make the EFI earlycon driver be suitable for any linear framebuffers. This should be helpful for early porting of boards with no other means of output, like smartphones/tablets. There seems to be an issue with early_ioremap function on ARM32, but I am unable to find the exact cause. It appears the mappings returned by it are somehow incorrect, thus the driver is disabled on ARM. EFI early console was disabled on IA64 previously because of missing early_memremap_prot, and this is inherited to this driver.
This patch also changes behavior on EFI systems, by selecting the mapping type based on if the framebuffer region intersects with system RAM. If it does, it's common sense that it should be in RAM as a whole, and so the system RAM mapping is used. It was tested to be working on my PC (Intel Z490 platform), as well as several ARM64 boards (Samsung Galaxy S9 (Exynos), iPad Air 2, Xiaomi Mi Pad 4, ...).
Markuss Broks (2):
drivers: serial: earlycon: Pass device-tree node
efi: earlycon: Add support for generic framebuffers and move to fbdev
subsystem
v1 -> v2:
- a new patch correcting serial/earlycon.c argument name to "offset" instead of "node"
- move IA64 exclusion from EFI earlycon Kconfig to earlycon driver Kconfig (IA64 has no early_memremap_prot)
- move driver from fbdev to console subsystem
- select EFI earlycon by default
- fetch stride manually from device-tree, as on some devices it seems stride doesn't match the horizontal resolution * bpp.
- use saner format (e.g. 1920x1080x32 instead of 1920,1080,32).
.../admin-guide/kernel-parameters.txt | 12 +- MAINTAINERS | 5 + drivers/firmware/efi/Kconfig | 6 +- drivers/firmware/efi/Makefile | 1 - drivers/firmware/efi/earlycon.c | 246 -------------- drivers/tty/serial/earlycon.c | 3 + drivers/video/fbdev/Kconfig | 11 + drivers/video/fbdev/Makefile | 1 + drivers/video/fbdev/earlycon.c | 301 ++++++++++++++++++ include/linux/serial_core.h | 1 + 10 files changed, 331 insertions(+), 256 deletions(-) delete mode 100644 drivers/firmware/efi/earlycon.c create mode 100644 drivers/video/fbdev/earlycon.c
Signature · 1 line
2.37.0
PATCH v2 1/3 drivers: serial: earlycon: Correct argument name
The "node" argument is actually an offset, and it's also an "int", and not "unsigned long". Correct the of_setup_earlycon function.
--- drivers/tty/serial/earlycon.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/tty/serial/earlycon.c +9 -9
@@ -244,7 +244,7 @@ early_param("earlycon", param_setup_earlycon);#ifdef CONFIG_OF_EARLY_FLATTREE int __init of_setup_earlycon (const struct earlycon_id *match, -unsigned long node, +int offset,const char *options) {int err;
@@ -255,25 +255,25 @@ int __init of_setup_earlycon(const struct earlycon_id *match,spin_lock_init (&port->lock); port->iotype =UPIO_MEM ; - addr =of_flat_dt_translate_address (node); + addr =of_flat_dt_translate_address (offset);if (addr ==OF_BAD_ADDR ) {pr_warn ("[%s] bad address\n" , match->name);return -ENXIO ; } port->mapbase = addr; - val =of_get_flat_dt_prop (node,"reg-offset" ,NULL ); + val =of_get_flat_dt_prop (offset,"reg-offset" ,NULL );if (val) port->mapbase +=be32_to_cpu (*val); port->membase =earlycon_map (port->mapbase,SZ_4K ); - val =of_get_flat_dt_prop (node,"reg-shift" ,NULL ); + val =of_get_flat_dt_prop (offset,"reg-shift" ,NULL );if (val) port->regshift =be32_to_cpu (*val); - big_endian =of_get_flat_dt_prop (node,"big-endian" ,NULL ) !=NULL || + big_endian =of_get_flat_dt_prop (offset,"big-endian" ,NULL ) !=NULL || (IS_ENABLED (CONFIG_CPU_BIG_ENDIAN ) && -of_get_flat_dt_prop (node,"native-endian" ,NULL ) !=NULL ); - val =of_get_flat_dt_prop (node,"reg-io-width" ,NULL ); +of_get_flat_dt_prop (offset,"native-endian" ,NULL ) !=NULL ); + val =of_get_flat_dt_prop (offset,"reg-io-width" ,NULL );if (val) {switch (be32_to_cpu (*val)) {case 1 :
@@ -291,11 +291,11 @@ int __init of_setup_earlycon(const struct earlycon_id *match, } } - val =of_get_flat_dt_prop (node,"current-speed" ,NULL ); + val =of_get_flat_dt_prop (offset,"current-speed" ,NULL );if (val) early_console_dev.baud =be32_to_cpu (*val); - val =of_get_flat_dt_prop (node,"clock-frequency" ,NULL ); + val =of_get_flat_dt_prop (offset,"clock-frequency" ,NULL );if (val) port->uartclk =be32_to_cpu (*val);
Signature · 1 line
2.37.0
Re: [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name
Quoted 4 lines · Markuss Broks
The "node" argument is actually an offset, and it's also an "int", and not "unsigned long". Correct the
of_setup_earlyconfunction.
Quoted 1 line
Signed-off-by Markuss Broks <[email protected]>
Signature · 2 lines
With Best Regards, Andy Shevchenko
kernel test robot
build botRe: [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name
In reply to Markuss BroksI love your patch! Yet something to improve:
Hi Markuss,
I love your patch! Yet something to improve:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on efi/next staging/staging-testing usb/usb-testing linus/master v5.19 next-20220805] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220807-003646 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: x86_64-randconfig-a012 (https://download.01.org/0day-ci/archive/20220807/[email protected]/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/dedd7c138e9492439eeda05fa75a18bf19883a08
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220807-003646 git checkout dedd7c138e9492439eeda05fa75a18bf19883a08
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
All errors (new ones prefixed by >>):
>> drivers/tty/serial/earlycon.c:246:12: error: conflicting types for 'of_setup_earlycon'
int __init of_setup_earlycon(const struct earlycon_id *match,
^
include/linux/serial_core.h:708:12: note: previous declaration is here
extern int of_setup_earlycon(const struct earlycon_id *match,
^1 error generated.
vim +/of_setup_earlycon +246 drivers/tty/serial/earlycon.c
8477614d9f7c5c Peter Hurley 2016-01-16 245
c90fe9c0394b06 Peter Hurley 2016-01-16 @246 int __init of_setup_earlycon(const struct earlycon_id *match,
dedd7c138e9492 Markuss Broks 2022-08-06 247 int offset,
4d118c9a866590 Peter Hurley 2016-01-16 248 const char *options)
b0b6abd34c1b50 Rob Herring 2014-03-27 249 {
b0b6abd34c1b50 Rob Herring 2014-03-27 250 int err;
b0b6abd34c1b50 Rob Herring 2014-03-27 251 struct uart_port *port = &early_console_dev.port;
088da2a17619cf Peter Hurley 2016-01-16 252 const __be32 *val;
088da2a17619cf Peter Hurley 2016-01-16 253 bool big_endian;
c90fe9c0394b06 Peter Hurley 2016-01-16 254 u64 addr;
b0b6abd34c1b50 Rob Herring 2014-03-27 255
65e20e8cbbccaf Michael Walle 2022-06-28 256 if (early_con.flags & CON_ENABLED)
65e20e8cbbccaf Michael Walle 2022-06-28 257 return -EALREADY;
65e20e8cbbccaf Michael Walle 2022-06-28 258
e1dd3bef6d03c9 Geert Uytterhoeven 2015-11-27 259 spin_lock_init(&port->lock);
b0b6abd34c1b50 Rob Herring 2014-03-27 260 port->iotype = UPIO_MEM;
dedd7c138e9492 Markuss Broks 2022-08-06 261 addr = of_flat_dt_translate_address(offset);
c90fe9c0394b06 Peter Hurley 2016-01-16 262 if (addr == OF_BAD_ADDR) {
c90fe9c0394b06 Peter Hurley 2016-01-16 263 pr_warn("[%s] bad address\n", match->name);
c90fe9c0394b06 Peter Hurley 2016-01-16 264 return -ENXIO;
c90fe9c0394b06 Peter Hurley 2016-01-16 265 }
b0b6abd34c1b50 Rob Herring 2014-03-27 266 port->mapbase = addr;
b0b6abd34c1b50 Rob Herring 2014-03-27 267
dedd7c138e9492 Markuss Broks 2022-08-06 268 val = of_get_flat_dt_prop(offset, "reg-offset", NULL);
088da2a17619cf Peter Hurley 2016-01-16 269 if (val)
088da2a17619cf Peter Hurley 2016-01-16 270 port->mapbase += be32_to_cpu(*val);
1f66dd36bb1843 Greentime Hu 2018-02-13 271 port->membase = earlycon_map(port->mapbase, SZ_4K);
1f66dd36bb1843 Greentime Hu 2018-02-13 272
dedd7c138e9492 Markuss Broks 2022-08-06 273 val = of_get_flat_dt_prop(offset, "reg-shift", NULL);
088da2a17619cf Peter Hurley 2016-01-16 274 if (val)
088da2a17619cf Peter Hurley 2016-01-16 275 port->regshift = be32_to_cpu(*val);
dedd7c138e9492 Markuss Broks 2022-08-06 276 big_endian = of_get_flat_dt_prop(offset, "big-endian", NULL) != NULL ||
088da2a17619cf Peter Hurley 2016-01-16 277 (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN) &&
dedd7c138e9492 Markuss Broks 2022-08-06 278 of_get_flat_dt_prop(offset, "native-endian", NULL) != NULL);
dedd7c138e9492 Markuss Broks 2022-08-06 279 val = of_get_flat_dt_prop(offset, "reg-io-width", NULL);
088da2a17619cf Peter Hurley 2016-01-16 280 if (val) {
088da2a17619cf Peter Hurley 2016-01-16 281 switch (be32_to_cpu(*val)) {
088da2a17619cf Peter Hurley 2016-01-16 282 case 1:
088da2a17619cf Peter Hurley 2016-01-16 283 port->iotype = UPIO_MEM;
088da2a17619cf Peter Hurley 2016-01-16 284 break;
088da2a17619cf Peter Hurley 2016-01-16 285 case 2:
088da2a17619cf Peter Hurley 2016-01-16 286 port->iotype = UPIO_MEM16;
088da2a17619cf Peter Hurley 2016-01-16 287 break;
088da2a17619cf Peter Hurley 2016-01-16 288 case 4:
088da2a17619cf Peter Hurley 2016-01-16 289 port->iotype = (big_endian) ? UPIO_MEM32BE : UPIO_MEM32;
088da2a17619cf Peter Hurley 2016-01-16 290 break;
088da2a17619cf Peter Hurley 2016-01-16 291 default:
088da2a17619cf Peter Hurley 2016-01-16 292 pr_warn("[%s] unsupported reg-io-width\n", match->name);
088da2a17619cf Peter Hurley 2016-01-16 293 return -EINVAL;
088da2a17619cf Peter Hurley 2016-01-16 294 }
088da2a17619cf Peter Hurley 2016-01-16 295 }
088da2a17619cf Peter Hurley 2016-01-16 296
dedd7c138e9492 Markuss Broks 2022-08-06 297 val = of_get_flat_dt_prop(offset, "current-speed", NULL);
31cb9a8575ca04 Eugeniy Paltsev 2017-08-21 298 if (val)
31cb9a8575ca04 Eugeniy Paltsev 2017-08-21 299 early_console_dev.baud = be32_to_cpu(*val);
31cb9a8575ca04 Eugeniy Paltsev 2017-08-21 300
dedd7c138e9492 Markuss Broks 2022-08-06 301 val = of_get_flat_dt_prop(offset, "clock-frequency", NULL);
814453adea7d08 Michal Simek 2018-04-10 302 if (val)
814453adea7d08 Michal Simek 2018-04-10 303 port->uartclk = be32_to_cpu(*val);
814453adea7d08 Michal Simek 2018-04-10 304
4d118c9a866590 Peter Hurley 2016-01-16 305 if (options) {
31cb9a8575ca04 Eugeniy Paltsev 2017-08-21 306 early_console_dev.baud = simple_strtoul(options, NULL, 0);
4d118c9a866590 Peter Hurley 2016-01-16 307 strlcpy(early_console_dev.options, options,
4d118c9a866590 Peter Hurley 2016-01-16 308 sizeof(early_console_dev.options));
4d118c9a866590 Peter Hurley 2016-01-16 309 }
05d961320ba624 Peter Hurley 2016-01-16 310 earlycon_init(&early_console_dev, match->name);
4d118c9a866590 Peter Hurley 2016-01-16 311 err = match->setup(&early_console_dev, options);
f28295cc8ce14b Hsin-Yi Wang 2020-09-15 312 earlycon_print_info(&early_console_dev);
b0b6abd34c1b50 Rob Herring 2014-03-27 313 if (err < 0)
b0b6abd34c1b50 Rob Herring 2014-03-27 314 return err;
b0b6abd34c1b50 Rob Herring 2014-03-27 315 if (!early_console_dev.con->write)
b0b6abd34c1b50 Rob Herring 2014-03-27 316 return -ENODEV;
b0b6abd34c1b50 Rob Herring 2014-03-27 317
b0b6abd34c1b50 Rob Herring 2014-03-27 318
b0b6abd34c1b50 Rob Herring 2014-03-27 319 register_console(early_console_dev.con);
b0b6abd34c1b50 Rob Herring 2014-03-27 320 return 0;
b0b6abd34c1b50 Rob Herring 2014-03-27 321 }
8477614d9f7c5c Peter Hurley 2016-01-16 322 Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp
Re: [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name
In reply to Markuss BroksQuoted 2 lines · Markuss Broks
The "node" argument is actually an offset,
It's an offset to a node in the FDT. The fact that it is an offset is an internal implementation detail of the FDT format. So really, it's a handle to a node. 'node' is more descriptive to its purpose.
Quoted 1 line
and it's also an "int", and not "unsigned long".
Uh, no it's not. of_flat_dt_*() functions all take an unsigned long.
Rob
PATCH v2 2/3 drivers: serial: earlycon: Pass device-tree node
In reply to Markuss BroksPass a pointer to device-tree node in case the driver probed from OF. This makes early console drivers able to fetch options from device-tree node properties.
--- drivers/tty/serial/earlycon.c | 3 +++ include/linux/serial_core.h | 1 + 2 files changed, 4 insertions(+)
drivers/tty/serial/earlycon.c +3 -0
@@ -304,6 +304,9 @@ int __init of_setup_earlycon(const struct earlycon_id *match,strlcpy (early_console_dev.options, options,sizeof (early_console_dev.options)); } + + early_console_dev.offset = offset; +earlycon_init (&early_console_dev, match->name); err = match->setup (&early_console_dev, options);earlycon_print_info (&early_console_dev);
include/linux/serial_core.h +1 -0
@@ -349,6 +349,7 @@ struct earlycon_device {struct uart_port port;char options[16 ];/* e.g., 115200n8 */ unsigned int baud; +int offset; };struct earlycon_id {
Signature · 1 line
2.37.0
PATCH v2 3/3 efi: earlycon: Add support for generic framebuffers and move to console subsystem
In reply to Markuss BroksAdd early console support for generic linear framebuffer devices. This driver supports probing from cmdline early parameters
or from the device-tree using information in simple-framebuffer node. The EFI functionality should be retained in whole.
The driver was disabled on ARM because of a bug in early_ioremap implementation on ARM and on IA64 because of lack of early_memremap_prot.
--- .../admin-guide/kernel-parameters.txt | 12 +- MAINTAINERS | 5 + drivers/firmware/efi/Kconfig | 7 +- drivers/firmware/efi/Makefile | 1 - drivers/firmware/efi/earlycon.c | 246 -------------- drivers/video/console/Kconfig | 11 + drivers/video/console/Makefile | 1 + drivers/video/console/earlycon.c | 305 ++++++++++++++++++ 8 files changed, 332 insertions(+), 256 deletions(-) delete mode 100644 drivers/firmware/efi/earlycon.c create mode 100644 drivers/video/console/earlycon.c
Documentation/admin-guide/kernel-parameters.txt +7 -5
@@ -1281,12 +1281,9 @@ specified address. The serial port must already be setup and configured. Options are not yet supported. - efifb,[options] + efifb Start an early, unaccelerated console on the EFI - memory mapped framebuffer (if available). On cache - coherent non-x86 systems that use system memory for - the framebuffer, pass the 'ram' option so that it is - mapped with the correct attributes. + memory mapped framebuffer (if available). linflex,<addr> Use early console provided by Freescale LINFlexD UART
@@ -1294,6 +1291,11 @@ address must be provided, and the serial port must already be setup and configured. + simplefb,<addr>,<width>x<height>x<bpp> + Use early console with simple framebuffer that is + pre-initialized by firmware. A valid base address, + width, height and pixel size must be provided. + earlyprintk= [X86,SH,ARM,M68k,S390] earlyprintk=vga earlyprintk=sclp
MAINTAINERS +5 -0
@@ -7033,6 +7033,11 @@ Q: http://patchwork.linuxtv.org/project/linux-media/list/ T: git git://linuxtv.org/anttip/media_tree.git F: drivers/media/tuners/e4000* +EARLY CONSOLE FRAMEBUFFER DRIVER +M: Markuss Broks <[email protected]> +S: Maintained +F: drivers/video/console/earlycon.c + EARTH_PT1 MEDIA DRIVER M: Akihiro Tsukada <[email protected]> L: [email protected]
drivers/firmware/efi/Kconfig +3 -4
@@ -259,10 +259,9 @@ config EFI_DISABLE_PCI_DMA may be used to override this option. config EFI_EARLYCON - def_bool y - depends on SERIAL_EARLYCON && !ARM && !IA64 - select FONT_SUPPORT - select ARCH_USE_MEMREMAP_PROT + bool "EFI early console support" + select FB_EARLYCON + default y config EFI_CUSTOM_SSDT_OVERLAYS bool "Load custom ACPI SSDT overlay from an EFI variable"
drivers/firmware/efi/Makefile +0 -1
@@ -44,6 +44,5 @@ obj-$(CONFIG_ARM64) += $(arm-obj-y) riscv-obj-$(CONFIG_EFI) := efi-init.o riscv-runtime.o obj-$(CONFIG_RISCV) += $(riscv-obj-y) obj-$(CONFIG_EFI_CAPSULE_LOADER) += capsule-loader.o -obj-$(CONFIG_EFI_EARLYCON) += earlycon.o obj-$(CONFIG_UEFI_CPER_ARM) += cper-arm.o obj-$(CONFIG_UEFI_CPER_X86) += cper-x86.o
drivers/firmware/efi/earlycon.c deleted +0 -246
246 lines not on this page · raw message
drivers/video/console/Kconfig +11 -0
@@ -69,6 +69,17 @@ config DUMMY_CONSOLE_ROWS monitor. Select 25 if you use a 640x480 resolution by default. +config FB_EARLYCON + bool "Generic framebuffer early console" + depends on SERIAL_EARLYCON && !ARM && !IA64 + select FONT_SUPPORT + select ARCH_USE_MEMREMAP_PROT + help + Say Y here if you want early console support for firmware established + linear framebuffer. Unless you are using EFI framebuffer, you need to + specify framebuffer geometry and address in device-tree or in kernel + command line. + config FRAMEBUFFER_CONSOLE bool "Framebuffer Console support" depends on FB && !UML
drivers/video/console/Makefile +1 -0
@@ -9,4 +9,5 @@ obj-$(CONFIG_STI_CONSOLE) += sticon.o sticore.o obj-$(CONFIG_VGA_CONSOLE) += vgacon.o obj-$(CONFIG_MDA_CONSOLE) += mdacon.o +obj-$(CONFIG_FB_EARLYCON) += earlycon.o obj-$(CONFIG_FB_STI) += sticore.o
drivers/video/console/earlycon.c new file +305 -0
305 lines not on this page · raw message
Signature · 1 line
2.37.0
Re: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem
Quoted 6 lines · Markuss Broks
Add early console support for generic linear framebuffer devices. This driver supports probing from cmdline early parameters or from the device-tree using information in simple-framebuffer node. The EFI functionality should be retained in whole.
The driver was disabled on ARM because of a bug inearly_ioremap
We refer to functions like func().
Quoted 1 line
implementation on ARM and on IA64 because of lack of
early_memremap_prot.
Ditto.
...
Quoted 1 line
+#include <
asm/early_ioremap.h>
Can it be placed after linux/* ones?
Quoted 10 lines
drivers/video/console/earlycon.c new file +10
-0+#include <linux/console.h> +#include <linux/efi.h> +#include <linux/font.h> +#include <linux/io.h> +#include <linux/kernel.h> +#include <linux/mm.h> +#include <linux/of.h> +#include <linux/of_fdt.h> +#include <linux/serial_core.h> +#include <linux/screen_info.h>
...
drivers/video/console/earlycon.c line 32
Quoted 3 lines
drivers/video/console/earlycon.c new file +3
-0+static int __init simplefb_earlycon_remap_fb (void ) +{ +unsigned long mapping;
+ Blank line.
drivers/video/console/earlycon.c line 45
Quoted 13 lines
drivers/video/console/earlycon.c new file +12
-0+/* bail if there is no bootconsole or it has been disabled already */ +if (!earlycon_console || !(earlycon_console->flags &CON_ENABLED )) +return 0 ; + +if (region_intersects (info.phys_base, info.size, +IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) ==REGION_INTERSECTS ) + mapping =MEMREMAP_WB ; +else + mapping =MEMREMAP_WC ; + info.virt_base =memremap (info.phys_base, info.size, mapping); + +return info.virt_base ?0 : -ENOMEM ;
Easier to read the standard pattern:
if (!info.virt_base)
return -ENOMEM;
return 0;
Quoted 1 line
+}
...
drivers/video/console/earlycon.c line 129
Quoted 12 lines
drivers/video/console/earlycon.c new file +12
-0+static void simplefb_earlycon_write_char (u8 *dst,unsigned char c,unsigned int h) +{ +const u8 *src; +int m, n, bytes; +u8 x; + + bytes =BITS_TO_BYTES (font->width); + src = font->data + c * font->height * bytes + h * bytes; + +for (m =0 ; m < font->width; m++) { + n = m %8 ; + x = *(src + m /8 );
I would write it as
x = src[m / 8];
drivers/video/console/earlycon.c line 131
Quoted 3 lines
drivers/video/console/earlycon.c new file +2
-0+if ((x >> (7 - n)) &1 ) +memset (dst,0xff , (info.depth /8 ));
Too many parentheses.
drivers/video/console/earlycon.c line 133
Quoted 2 lines
drivers/video/console/earlycon.c new file +2
-0+else +memset (dst,0 , (info.depth /8 ));
Ditto.
Quoted 1 line
+ dst += (info.depth / 8);
Ditto.
Quoted 2 lines
(quoted diff) +2
-0+ } +}
Signature · 2 lines
With Best Regards, Andy Shevchenko
kernel test robot
build botRe: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem
In reply to Markuss BroksI love your patch! Yet something to improve:
Hi Markuss,
I love your patch! Yet something to improve:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on efi/next staging/staging-testing usb/usb-testing linus/master v5.19 next-20220805] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220807-003646 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220807/[email protected]/config) compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/97dfc2aa69b065de769a191352afe2099c52fedb
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220807-003646 git checkout 97dfc2aa69b065de769a191352afe2099c52fedb
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
All errors (new ones prefixed by >>):
>> drivers/video/console/earlycon.c:7:10: fatal error: asm/early_ioremap.h: No such file or directory
7 | #include <asm/early_ioremap.h>
| ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
vim +7 drivers/video/console/earlycon.c
> 7 #include <asm/early_ioremap.h>
8 #include <linux/console.h>
9 #include <linux/efi.h>
10 #include <linux/font.h>
11 #include <linux/io.h>
12 #include <linux/kernel.h>
13 #include <linux/mm.h>
14 #include <linux/of.h>
15 #include <linux/of_fdt.h>
16 #include <linux/serial_core.h>
17 #include <linux/screen_info.h>
18 Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp
kernel test robot
build botRe: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem
In reply to Markuss BroksI love your patch! Perhaps something to improve:
Hi Markuss,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on efi/next staging/staging-testing usb/usb-testing linus/master v5.19 next-20220812] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220807-003646 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: loongarch-randconfig-s031-20220807 (https://download.01.org/0day-ci/archive/20220814/[email protected]/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/97dfc2aa69b065de769a191352afe2099c52fedb
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220807-003646
git checkout 97dfc2aa69b065de769a191352afe2099c52fedb
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/video/console/
If you fix the issue, kindly add following tag where applicable
sparse warnings: (new ones prefixed by >>)
>> drivers/video/console/earlycon.c:43:24: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __iomem *static [toplevel] virt_base @@ got void * @@ drivers/video/console/earlycon.c:43:24: sparse: expected void [noderef] __iomem *static [toplevel] virt_base drivers/video/console/earlycon.c:43:24: sparse: got void * >> drivers/video/console/earlycon.c:53:30: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *addr @@ got void [noderef] __iomem *static [toplevel] virt_base @@ drivers/video/console/earlycon.c:53:30: sparse: expected void *addr drivers/video/console/earlycon.c:53:30: sparse: got void [noderef] __iomem *static [toplevel] virt_base >> drivers/video/console/earlycon.c:63:39: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void * @@ got void [noderef] __iomem * @@ drivers/video/console/earlycon.c:63:39: sparse: expected void * drivers/video/console/earlycon.c:63:39: sparse: got void [noderef] __iomem * >> drivers/video/console/earlycon.c:74:24: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __iomem *addr @@ got void *addr @@
drivers/video/console/earlycon.c:74:24: sparse: expected void [noderef] __iomem *addr
drivers/video/console/earlycon.c:74:24: sparse: got void *addr
vim +43 drivers/video/console/earlycon.c
29
30 static int __init simplefb_earlycon_remap_fb(void)
31 {
32 unsigned long mapping;
33 /* bail if there is no bootconsole or it has been disabled already */
34 if (!earlycon_console || !(earlycon_console->flags & CON_ENABLED))
35 return 0;
36
37 if (region_intersects(info.phys_base, info.size,
38 IORESOURCE_SYSTEM_RAM, IORES_DESC_NONE) == REGION_INTERSECTS)
39 mapping = MEMREMAP_WB;
40 else
41 mapping = MEMREMAP_WC;
42
> 43 info.virt_base = memremap(info.phys_base, info.size, mapping);
44
45 return info.virt_base ? 0 : -ENOMEM;
46 }
47 early_initcall(simplefb_earlycon_remap_fb);
48
49 static int __init simplefb_earlycon_unmap_fb(void)
50 {
51 /* unmap the bootconsole fb unless keep_bootcon has left it enabled */
52 if (info.virt_base && !(earlycon_console->flags & CON_ENABLED))
> 53 memunmap(info.virt_base);
54 return 0;
55 }
56 late_initcall(simplefb_earlycon_unmap_fb);
57
58 static __ref void *simplefb_earlycon_map(unsigned long start, unsigned long len)
59 {
60 pgprot_t fb_prot;
61
62 if (info.virt_base)
> 63 return info.virt_base + start;
64
65 fb_prot = PAGE_KERNEL;
66 return early_memremap_prot(info.phys_base + start, len, pgprot_val(fb_prot));
67 }
68
69 static __ref void simplefb_earlycon_unmap(void *addr, unsigned long len)
70 {
71 if (info.virt_base)
72 return;
73
> 74 early_memunmap(addr, len);
75 }
76 Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp
kernel test robot
build botRe: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem
In reply to Markuss BroksI love your patch! Perhaps something to improve:
Hi Markuss,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on efi/next staging/staging-testing usb/usb-testing linus/master v5.19 next-20220812] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220807-003646 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: x86_64-kismet-CONFIG_FB_EARLYCON-CONFIG_EFI_EARLYCON-0-0 (https://download.01.org/0day-ci/archive/20220814/[email protected]/config)
reproduce:
# https://github.com/intel-lab-lkp/linux/commit/97dfc2aa69b065de769a191352afe2099c52fedb
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220807-003646 git checkout 97dfc2aa69b065de769a191352afe2099c52fedb
# 1. reproduce by kismet
# install kmax per https://github.com/paulgazz/kmax/blob/master/README.md
kismet --linux-ksrc=linux --selectees CONFIG_FB_EARLYCON --selectors CONFIG_EFI_EARLYCON -a=x86_64
# 2. reproduce by make
# save the config file to linux source tree
cd linux
make ARCH=x86_64 olddefconfig
If you fix the issue, kindly add following tag where applicable
kismet warnings: (new ones prefixed by >>)
>> kismet: WARNING: unmet direct dependencies detected for FB_EARLYCON when selected by EFI_EARLYCON
WARNING: unmet direct dependencies detected for FB_EARLYCON
Depends on [n]: VT [=y] && SERIAL_EARLYCON [=n] && !ARM && !IA64 Selected by [y]:
- EFI_EARLYCON [=y] && EFI [=y]
Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp
Re: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem
In reply to Markuss BroksQuoted 8 lines · Markuss Broks
Add early console support for generic linear framebuffer devices. This driver supports probing from cmdline early parameters
or from the device-tree using information in simple-framebuffer node. The EFI functionality should be retained in whole.
The driver was disabled on ARM because of a bug inearly_ioremapimplementation on ARM and on IA64 because of lack ofearly_memremap_prot.Signed-off-by Markuss Broks <[email protected]>
Quoted 9 lines
--- .../admin-guide/kernel-parameters.txt | 12 +- MAINTAINERS | 5 + drivers/firmware/efi/Kconfig | 7 +- drivers/firmware/efi/Makefile | 1 - drivers/firmware/efi/earlycon.c | 246 -------------- drivers/video/console/Kconfig | 11 + drivers/video/console/Makefile | 1 + drivers/video/console/earlycon.c | 305 ++++++++++++++++++
Ok I have a more fundamental issue with this than the lack of proper patch splitting I mentioned in the other thread.
This is the wrong place.
drivers/video/console is about the various vt console implementations, which supply a struct consw to con_register_driver.
This otoh is an (early) kernel/printk console implemented using struct console. Totally different thing, and really shouldn't end up in drivers/video/console imo. Somewhere in drivers/firmware might still be the best place, the sysfb stuff is also there. Maybe drivers/firmware/sysfb_earlycon.c?
Also patch split is still an issue here, like I and Greg already said. -Daniel
Quoted 678 lines
8 files changed, 332 insertions(+), 256 deletions(-) delete mode 100644 drivers/firmware/efi/earlycon.c create mode 100644 drivers/video/console/earlycon.cDocumentation/admin-guide/kernel-parameters.txt +7
-5@@ -1281,12 +1281,9 @@ specified address. The serial port must already be setup and configured. Options are not yet supported. - efifb,[options] + efifb Start an early, unaccelerated console on the EFI - memory mapped framebuffer (if available). On cache - coherent non-x86 systems that use system memory for - the framebuffer, pass the 'ram' option so that it is - mapped with the correct attributes. + memory mapped framebuffer (if available). linflex,<addr> Use early console provided by Freescale LINFlexD UART@@ -1294,6 +1291,11 @@ address must be provided, and the serial port must already be setup and configured. + simplefb,<addr>,<width>x<height>x<bpp> + Use early console with simple framebuffer that is + pre-initialized by firmware. A valid base address, + width, height and pixel size must be provided. + earlyprintk= [X86,SH,ARM,M68k,S390] earlyprintk=vga earlyprintk=sclpMAINTAINERS +5
-0@@ -7033,6 +7033,11 @@ Q: http://patchwork.linuxtv.org/project/linux-media/list/ T: git git://linuxtv.org/anttip/media_tree.git F: drivers/media/tuners/e4000* +EARLY CONSOLE FRAMEBUFFER DRIVER +M: Markuss Broks <[email protected]> +S: Maintained +F: drivers/video/console/earlycon.c + EARTH_PT1 MEDIA DRIVER M: Akihiro Tsukada <[email protected]> L: [email protected]drivers/firmware/efi/Kconfig +3
-4@@ -259,10 +259,9 @@ config EFI_DISABLE_PCI_DMA may be used to override this option. config EFI_EARLYCON - def_bool y - depends on SERIAL_EARLYCON && !ARM && !IA64 - select FONT_SUPPORT - select ARCH_USE_MEMREMAP_PROT + bool "EFI early console support" + select FB_EARLYCON + default y config EFI_CUSTOM_SSDT_OVERLAYS bool "Load custom ACPI SSDT overlay from an EFI variable"drivers/firmware/efi/Makefile +0
-1@@ -44,6 +44,5 @@ obj-$(CONFIG_ARM64) += $(arm-obj-y) riscv-obj-$(CONFIG_EFI) := efi-init.o riscv-runtime.o obj-$(CONFIG_RISCV) += $(riscv-obj-y) obj-$(CONFIG_EFI_CAPSULE_LOADER) += capsule-loader.o -obj-$(CONFIG_EFI_EARLYCON) += earlycon.o obj-$(CONFIG_UEFI_CPER_ARM) += cper-arm.o obj-$(CONFIG_UEFI_CPER_X86) += cper-x86.odrivers/firmware/efi/earlycon.c deleted +0
-246@@ -1,246 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* -* Copyright (C) 2013 Intel Corporation; author Matt Fleming -*/ - -#include <linux/console.h> -#include <linux/efi.h> -#include <linux/font.h> -#include <linux/io.h> -#include <linux/kernel.h> -#include <linux/serial_core.h> -#include <linux/screen_info.h> - -#include <asm/early_ioremap.h> - -static const struct console *earlycon_console__initdata ; -static const struct font_desc *font; -static u32 efi_x, efi_y; -static u64 fb_base; -static bool fb_wb; -static void *efi_fb; - -/* -* EFI earlycon needs to use early_memremap() to map the framebuffer. -* But early_memremap() is not usable for 'earlycon=efifb keep_bootcon', -* memremap() should be used instead. memremap() will be available after -* paging_init() which is earlier than initcall callbacks. Thus adding this -* early initcall function early_efi_map_fb() to map the whole EFI framebuffer. -*/ -static int __init efi_earlycon_remap_fb (void ) -{ -/* bail if there is no bootconsole or it has been disabled already */ -if (!earlycon_console || !(earlycon_console->flags &CON_ENABLED )) -return 0 ; - - efi_fb =memremap (fb_base, screen_info.lfb_size, - fb_wb ?MEMREMAP_WB :MEMREMAP_WC ); - -return efi_fb ?0 : -ENOMEM ; -} -early_initcall (efi_earlycon_remap_fb); - -static int __init efi_earlycon_unmap_fb (void ) -{ -/* unmap the bootconsole fb unless keep_bootcon has left it enabled */ -if (efi_fb && !(earlycon_console->flags &CON_ENABLED )) -memunmap (efi_fb); -return 0 ; -} -late_initcall (efi_earlycon_unmap_fb); - -static __ref void *efi_earlycon_map (unsigned long start,unsigned long len) -{ -pgprot_t fb_prot; - -if (efi_fb) -return efi_fb + start; - - fb_prot = fb_wb ?PAGE_KERNEL :pgprot_writecombine (PAGE_KERNEL ); -return early_memremap_prot (fb_base + start, len,pgprot_val (fb_prot)); -} - -static __ref void efi_earlycon_unmap (void *addr,unsigned long len) -{ -if (efi_fb) -return ; - -early_memunmap (addr, len); -} - -static void efi_earlycon_clear_scanline (unsigned int y) -{ -unsigned long *dst; -u16 len; - - len = screen_info.lfb_linelength; - dst =efi_earlycon_map (y*len, len); -if (!dst) -return ; - -memset (dst,0 , len); -efi_earlycon_unmap (dst, len); -} - -static void efi_earlycon_scroll_up (void ) -{ -unsigned long *dst, *src; -u16 len; -u32 i, height; - - len = screen_info.lfb_linelength; - height = screen_info.lfb_height; - -for (i =0 ; i < height - font->height; i++) { - dst =efi_earlycon_map (i*len, len); -if (!dst) -return ; - - src =efi_earlycon_map ((i + font->height) * len, len); -if (!src) { -efi_earlycon_unmap (dst, len); -return ; - } - -memmove (dst, src, len); - -efi_earlycon_unmap (src, len); -efi_earlycon_unmap (dst, len); - } -} - -static void efi_earlycon_write_char (u32 *dst,unsigned char c,unsigned int h) -{ -const u32 color_black =0x00000000 ; -const u32 color_white =0x00ffffff ; -const u8 *src; -int m, n, bytes; -u8 x; - - bytes =BITS_TO_BYTES (font->width); - src = font->data + c * font->height * bytes + h * bytes; - -for (m =0 ; m < font->width; m++) { - n = m %8 ; - x = *(src + m /8 ); -if ((x >> (7 - n)) &1 ) - *dst = color_white; -else - *dst = color_black; - dst++; - } -} - -static void -efi_earlycon_write (struct console *con,const char *str,unsigned int num) -{ -struct screen_info *si; -unsigned int len; -const char *s; -void *dst; - - si = &screen_info; - len = si->lfb_linelength; - -while (num) { -unsigned int linemax; -unsigned int h, count =0 ; - -for (s = str; *s && *s !='\n' ; s++) { -if (count == num) -break ; - count++; - } - - linemax = (si->lfb_width - efi_x) / font->width; -if (count > linemax) - count = linemax; - -for (h =0 ; h < font->height; h++) { -unsigned int n, x; - - dst =efi_earlycon_map ((efi_y + h) * len, len); -if (!dst) -return ; - - s = str; - n = count; - x = efi_x; - -while (n-- >0 ) { -efi_earlycon_write_char (dst + x*4 , *s, h); - x += font->width; - s++; - } - -efi_earlycon_unmap (dst, len); - } - - num -= count; - efi_x += count * font->width; - str += count; - -if (num >0 && *s =='\n' ) { - efi_x =0 ; - efi_y += font->height; - str++; - num--; - } - -if (efi_x + font->width > si->lfb_width) { - efi_x =0 ; - efi_y += font->height; - } - -if (efi_y + font->height > si->lfb_height) { -u32 i; - - efi_y -= font->height; -efi_earlycon_scroll_up (); - -for (i =0 ; i < font->height; i++) -efi_earlycon_clear_scanline (efi_y + i); - } - } -} - -static int __init efi_earlycon_setup (struct earlycon_device *device, -const char *opt) -{ -struct screen_info *si; -u16 xres, yres; -u32 i; - -if (screen_info.orig_video_isVGA !=VIDEO_TYPE_EFI ) -return -ENODEV ; - - fb_base = screen_info.lfb_base; -if (screen_info.capabilities &VIDEO_CAPABILITY_64BIT_BASE ) - fb_base |= (u64 )screen_info.ext_lfb_base <<32 ; - - fb_wb = opt && !strcmp (opt,"ram" ); - - si = &screen_info; - xres = si->lfb_width; - yres = si->lfb_height; - -/* -* efi_earlycon_write_char() implicitly assumes a framebuffer with -* 32 bits per pixel. -*/ -if (si->lfb_depth !=32 ) -return -ENODEV ; - - font =get_default_font (xres, yres,-1 ,-1 ); -if (!font) -return -ENODEV ; - - efi_y =rounddown (yres, font->height) - font->height; -for (i =0 ; i < (yres - efi_y) / font->height; i++) -efi_earlycon_scroll_up (); - - device->con->write = efi_earlycon_write; - earlycon_console = device->con; -return 0 ; -} -EARLYCON_DECLARE (efifb, efi_earlycon_setup);drivers/video/console/Kconfig +11
-0@@ -69,6 +69,17 @@ config DUMMY_CONSOLE_ROWS monitor. Select 25 if you use a 640x480 resolution by default. +config FB_EARLYCON + bool "Generic framebuffer early console" + depends on SERIAL_EARLYCON && !ARM && !IA64 + select FONT_SUPPORT + select ARCH_USE_MEMREMAP_PROT + help + Say Y here if you want early console support for firmware established + linear framebuffer. Unless you are using EFI framebuffer, you need to + specify framebuffer geometry and address in device-tree or in kernel + command line. + config FRAMEBUFFER_CONSOLE bool "Framebuffer Console support" depends on FB && !UMLdrivers/video/console/Makefile +1
-0@@ -9,4 +9,5 @@ obj-$(CONFIG_STI_CONSOLE) += sticon.o sticore.o obj-$(CONFIG_VGA_CONSOLE) += vgacon.o obj-$(CONFIG_MDA_CONSOLE) += mdacon.o +obj-$(CONFIG_FB_EARLYCON) += earlycon.o obj-$(CONFIG_FB_STI) += sticore.odrivers/video/console/earlycon.c new file +305
-0@@ -0,0 +1,305 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (C) 2013 Intel Corporation; author Matt Fleming +* Copyright (C) 2022 Markuss Broks <[email protected]> +*/ + +#include <asm/early_ioremap.h> +#include <linux/console.h> +#include <linux/efi.h> +#include <linux/font.h> +#include <linux/io.h> +#include <linux/kernel.h> +#include <linux/mm.h> +#include <linux/of.h> +#include <linux/of_fdt.h> +#include <linux/serial_core.h> +#include <linux/screen_info.h> + +struct fb_earlycon { +u32 x, y, curr_x, curr_y, depth, stride; +size_t size; +phys_addr_t phys_base; +void __iomem *virt_base; +}; + +static const struct console *earlycon_console__initconst ; +static struct fb_earlycon info; +static const struct font_desc *font; + +static int __init simplefb_earlycon_remap_fb (void ) +{ +unsigned long mapping; +/* bail if there is no bootconsole or it has been disabled already */ +if (!earlycon_console || !(earlycon_console->flags &CON_ENABLED )) +return 0 ; + +if (region_intersects (info.phys_base, info.size, +IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) ==REGION_INTERSECTS ) + mapping =MEMREMAP_WB ; +else + mapping =MEMREMAP_WC ; + + info.virt_base =memremap (info.phys_base, info.size, mapping); + +return info.virt_base ?0 : -ENOMEM ; +} +early_initcall (simplefb_earlycon_remap_fb); + +static int __init simplefb_earlycon_unmap_fb (void ) +{ +/* unmap the bootconsole fb unless keep_bootcon has left it enabled */ +if (info.virt_base && !(earlycon_console->flags &CON_ENABLED )) +memunmap (info.virt_base); +return 0 ; +} +late_initcall (simplefb_earlycon_unmap_fb); + +static __ref void *simplefb_earlycon_map (unsigned long start,unsigned long len) +{ +pgprot_t fb_prot; + +if (info.virt_base) +return info.virt_base + start; + + fb_prot =PAGE_KERNEL ; +return early_memremap_prot (info.phys_base + start, len,pgprot_val (fb_prot)); +} + +static __ref void simplefb_earlycon_unmap (void *addr,unsigned long len) +{ +if (info.virt_base) +return ; + +early_memunmap (addr, len); +} + +static void simplefb_earlycon_clear_scanline (unsigned int y) +{ +unsigned long *dst; +u16 len; + + len = info.stride; + dst =simplefb_earlycon_map (y * len, len); +if (!dst) +return ; + +memset (dst,0 , len); +simplefb_earlycon_unmap (dst, len); +} + +static void simplefb_earlycon_scroll_up (void ) +{ +unsigned long *dst, *src; +u16 len; +u32 i, height; + + len = info.stride; + height = info.y; + +for (i =0 ; i < height - font->height; i++) { + dst =simplefb_earlycon_map (i * len, len); +if (!dst) +return ; + + src =simplefb_earlycon_map ((i + font->height) * len, len); +if (!src) { +simplefb_earlycon_unmap (dst, len); +return ; + } + +memmove (dst, src, len); + +simplefb_earlycon_unmap (src, len); +simplefb_earlycon_unmap (dst, len); + } +} + +static void simplefb_earlycon_write_char (u8 *dst,unsigned char c,unsigned int h) +{ +const u8 *src; +int m, n, bytes; +u8 x; + + bytes =BITS_TO_BYTES (font->width); + src = font->data + c * font->height * bytes + h * bytes; + +for (m =0 ; m < font->width; m++) { + n = m %8 ; + x = *(src + m /8 ); +if ((x >> (7 - n)) &1 ) +memset (dst,0xff , (info.depth /8 )); +else +memset (dst,0 , (info.depth /8 )); + dst += (info.depth /8 ); + } +} + +static void +simplefb_earlycon_write (struct console *con,const char *str,unsigned int num) +{ +unsigned int len; +const char *s; +void *dst; + + len = info.stride; + +while (num) { +unsigned int linemax; +unsigned int h, count =0 ; + +for (s = str; *s && *s !='\n' ; s++) { +if (count == num) +break ; + count++; + } + + linemax = (info.x - info.curr_x) / font->width; +if (count > linemax) + count = linemax; + +for (h =0 ; h < font->height; h++) { +unsigned int n, x; + + dst =simplefb_earlycon_map ((info.curr_y + h) * len, len); +if (!dst) +return ; + + s = str; + n = count; + x = info.curr_x; + +while (n-- >0 ) { +simplefb_earlycon_write_char (dst + (x *4 ), *s, h); + x += font->width; + s++; + } + +simplefb_earlycon_unmap (dst, len); + } + + num -= count; + info.curr_x += count * font->width; + str += count; + +if (num >0 && *s =='\n' ) { + info.curr_x =0 ; + info.curr_y += font->height; + str++; + num--; + } + +if (info.curr_x + font->width > info.x) { + info.curr_x =0 ; + info.curr_y += font->height; + } + +if (info.curr_y + font->height > info.y) { +u32 i; + + info.curr_y -= font->height; +simplefb_earlycon_scroll_up (); + +for (i =0 ; i < font->height; i++) +simplefb_earlycon_clear_scanline (info.curr_y + i); + } + } +} + +static int __init simplefb_earlycon_setup_common (struct earlycon_device *device, +const char *opt) +{ +int i; + + info.size = info.x * info.y * (info.depth /8 ); + + font =get_default_font (info.x, info.y,-1 ,-1 ); +if (!font) +return -ENODEV ; + + info.curr_y =rounddown (info.y, font->height) - font->height; +for (i =0 ; i < (info.y - info.curr_y) / font->height; i++) +simplefb_earlycon_scroll_up (); + + device->con->write = simplefb_earlycon_write; + earlycon_console = device->con; +return 0 ; +} + +static int __init simplefb_earlycon_setup (struct earlycon_device *device, +const char *opt) +{ +struct uart_port *port = &device->port; +int ret; + +if (!port->mapbase) +return -ENODEV ; + + info.phys_base = port->mapbase; + + ret =sscanf (device->options,"%ux%ux%u" , &info.x, &info.y, &info.depth); +if (ret !=3 ) +return -ENODEV ; + + info.stride = info.x * (info.depth /8 ); + +return simplefb_earlycon_setup_common (device, opt); +} + +EARLYCON_DECLARE (simplefb, simplefb_earlycon_setup); + +#ifdef CONFIG_EFI_EARLYCON +static int __init simplefb_earlycon_setup_efi (struct earlycon_device *device, +const char *opt) +{ +if (screen_info.orig_video_isVGA !=VIDEO_TYPE_EFI ) +return -ENODEV ; + + info.phys_base = screen_info.lfb_base; +if (screen_info.capabilities &VIDEO_CAPABILITY_64BIT_BASE ) + info.phys_base |= (u64 )screen_info.ext_lfb_base <<32 ; + + info.x = screen_info.lfb_width; + info.y = screen_info.lfb_height; + info.depth = screen_info.lfb_depth; + info.stride = screen_info.lfb_linelength; + +return simplefb_earlycon_setup_common (device, opt); +} + +EARLYCON_DECLARE (efifb, simplefb_earlycon_setup_efi); +#endif + +#ifdef CONFIG_OF_EARLY_FLATTREE +static int __init simplefb_earlycon_setup_of (struct earlycon_device *device, +const char *opt) +{ +struct uart_port *port = &device->port; +const __be32 *val; + +if (!port->mapbase) +return -ENODEV ; + + info.phys_base = port->mapbase; + + val =of_get_flat_dt_prop (device->offset,"width" ,NULL ); +if (!val) +return -ENODEV ; + info.x =be32_to_cpu (*val); + + val =of_get_flat_dt_prop (device->offset,"height" ,NULL ); +if (!val) +return -ENODEV ; + info.y =be32_to_cpu (*val); + + val =of_get_flat_dt_prop (device->offset,"stride" ,NULL ); +if (!val) +return -ENODEV ; + info.stride =be32_to_cpu (*val); + info.depth = (info.stride / info.x) *8 ; + +return simplefb_earlycon_setup_common (device, opt); +} + +OF_EARLYCON_DECLARE (simplefb,"simple-framebuffer" , simplefb_earlycon_setup_of); +#endif Signature · 1 line
2.37.0
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem
Hi
Am 06.09.22 um 23:52 schrieb Daniel Vetter:
Quoted 24 lines · Markuss Broks
Quoted 8 lines
Add early console support for generic linear framebuffer devices. This driver supports probing from cmdline early parameters
or from the device-tree using information in simple-framebuffer node. The EFI functionality should be retained in whole.
The driver was disabled on ARM because of a bug inearly_ioremapimplementation on ARM and on IA64 because of lack ofearly_memremap_prot.Signed-off-by Markuss Broks <[email protected]>Quoted 9 lines
--- .../admin-guide/kernel-parameters.txt | 12 +- MAINTAINERS | 5 + drivers/firmware/efi/Kconfig | 7 +- drivers/firmware/efi/Makefile | 1 - drivers/firmware/efi/earlycon.c | 246 -------------- drivers/video/console/Kconfig | 11 + drivers/video/console/Makefile | 1 + drivers/video/console/earlycon.c | 305 ++++++++++++++++++Ok I have a more fundamental issue with this than the lack of proper patch splitting I mentioned in the other thread.
This is the wrong place.
Quoted 8 lines
drivers/video/consoleis about the various vt console implementations, which supply a struct consw tocon_register_driver.This otoh is an (early) kernel/printk console implemented using struct console. Totally different thing, and really shouldn't end up in
drivers/video/consoleimo. Somewhere indrivers/firmwaremight still be the best place, the sysfb stuff is also there. Maybedrivers/firmware/sysfb_earlycon.c?
Then better use just earlycon.c in that directory. We use the sysfb_ prefix for code of the framebuffer devices that simpledrm and simplefb run on top. It would not fit well here.
Best regards
Thomas
Quoted 683 lines
Also patch split is still an issue here, like I and Greg already said. -Daniel
Quoted 678 lines
8 files changed, 332 insertions(+), 256 deletions(-)delete mode 100644
drivers/firmware/efi/earlycon.ccreate mode 100644drivers/video/console/earlycon.cDocumentation/admin-guide/kernel-parameters.txt +7
-5@@ -1281,12 +1281,9 @@ specified address. The serial port must already be setup and configured. Options are not yet supported. - efifb,[options] + efifb Start an early, unaccelerated console on the EFI - memory mapped framebuffer (if available). On cache - coherent non-x86 systems that use system memory for - the framebuffer, pass the 'ram' option so that it is - mapped with the correct attributes. + memory mapped framebuffer (if available). linflex,<addr> Use early console provided by Freescale LINFlexD UART@@ -1294,6 +1291,11 @@ address must be provided, and the serial port must already be setup and configured. + simplefb,<addr>,<width>x<height>x<bpp> + Use early console with simple framebuffer that is + pre-initialized by firmware. A valid base address, + width, height and pixel size must be provided. + earlyprintk= [X86,SH,ARM,M68k,S390] earlyprintk=vga earlyprintk=sclpMAINTAINERS +5
-0@@ -7033,6 +7033,11 @@ Q: http://patchwork.linuxtv.org/project/linux-media/list/ T: git git://linuxtv.org/anttip/media_tree.git F: drivers/media/tuners/e4000* +EARLY CONSOLE FRAMEBUFFER DRIVER +M: Markuss Broks <[email protected]> +S: Maintained +F: drivers/video/console/earlycon.c + EARTH_PT1 MEDIA DRIVER M: Akihiro Tsukada <[email protected]> L: [email protected]drivers/firmware/efi/Kconfig +3
-4@@ -259,10 +259,9 @@ config EFI_DISABLE_PCI_DMA may be used to override this option. config EFI_EARLYCON - def_bool y - depends on SERIAL_EARLYCON && !ARM && !IA64 - select FONT_SUPPORT - select ARCH_USE_MEMREMAP_PROT + bool "EFI early console support" + select FB_EARLYCON + default y config EFI_CUSTOM_SSDT_OVERLAYS bool "Load custom ACPI SSDT overlay from an EFI variable"drivers/firmware/efi/Makefile +0
-1@@ -44,6 +44,5 @@ obj-$(CONFIG_ARM64) += $(arm-obj-y) riscv-obj-$(CONFIG_EFI) := efi-init.o riscv-runtime.o obj-$(CONFIG_RISCV) += $(riscv-obj-y) obj-$(CONFIG_EFI_CAPSULE_LOADER) += capsule-loader.o -obj-$(CONFIG_EFI_EARLYCON) += earlycon.o obj-$(CONFIG_UEFI_CPER_ARM) += cper-arm.o obj-$(CONFIG_UEFI_CPER_X86) += cper-x86.odrivers/firmware/efi/earlycon.c deleted +0
-246@@ -1,246 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* -* Copyright (C) 2013 Intel Corporation; author Matt Fleming -*/ - -#include <linux/console.h> -#include <linux/efi.h> -#include <linux/font.h> -#include <linux/io.h> -#include <linux/kernel.h> -#include <linux/serial_core.h> -#include <linux/screen_info.h> - -#include <asm/early_ioremap.h> - -static const struct console *earlycon_console__initdata ; -static const struct font_desc *font; -static u32 efi_x, efi_y; -static u64 fb_base; -static bool fb_wb; -static void *efi_fb; - -/* -* EFI earlycon needs to use early_memremap() to map the framebuffer. -* But early_memremap() is not usable for 'earlycon=efifb keep_bootcon', -* memremap() should be used instead. memremap() will be available after -* paging_init() which is earlier than initcall callbacks. Thus adding this -* early initcall function early_efi_map_fb() to map the whole EFI framebuffer. -*/ -static int __init efi_earlycon_remap_fb (void ) -{ -/* bail if there is no bootconsole or it has been disabled already */ -if (!earlycon_console || !(earlycon_console->flags &CON_ENABLED )) -return 0 ; - - efi_fb =memremap (fb_base, screen_info.lfb_size, - fb_wb ?MEMREMAP_WB :MEMREMAP_WC ); - -return efi_fb ?0 : -ENOMEM ; -} -early_initcall (efi_earlycon_remap_fb); - -static int __init efi_earlycon_unmap_fb (void ) -{ -/* unmap the bootconsole fb unless keep_bootcon has left it enabled */ -if (efi_fb && !(earlycon_console->flags &CON_ENABLED )) -memunmap (efi_fb); -return 0 ; -} -late_initcall (efi_earlycon_unmap_fb); - -static __ref void *efi_earlycon_map (unsigned long start,unsigned long len) -{ -pgprot_t fb_prot; - -if (efi_fb) -return efi_fb + start; - - fb_prot = fb_wb ?PAGE_KERNEL :pgprot_writecombine (PAGE_KERNEL ); -return early_memremap_prot (fb_base + start, len,pgprot_val (fb_prot)); -} - -static __ref void efi_earlycon_unmap (void *addr,unsigned long len) -{ -if (efi_fb) -return ; - -early_memunmap (addr, len); -} - -static void efi_earlycon_clear_scanline (unsigned int y) -{ -unsigned long *dst; -u16 len; - - len = screen_info.lfb_linelength; - dst =efi_earlycon_map (y*len, len); -if (!dst) -return ; - -memset (dst,0 , len); -efi_earlycon_unmap (dst, len); -} - -static void efi_earlycon_scroll_up (void ) -{ -unsigned long *dst, *src; -u16 len; -u32 i, height; - - len = screen_info.lfb_linelength; - height = screen_info.lfb_height; - -for (i =0 ; i < height - font->height; i++) { - dst =efi_earlycon_map (i*len, len); -if (!dst) -return ; - - src =efi_earlycon_map ((i + font->height) * len, len); -if (!src) { -efi_earlycon_unmap (dst, len); -return ; - } - -memmove (dst, src, len); - -efi_earlycon_unmap (src, len); -efi_earlycon_unmap (dst, len); - } -} - -static void efi_earlycon_write_char (u32 *dst,unsigned char c,unsigned int h) -{ -const u32 color_black =0x00000000 ; -const u32 color_white =0x00ffffff ; -const u8 *src; -int m, n, bytes; -u8 x; - - bytes =BITS_TO_BYTES (font->width); - src = font->data + c * font->height * bytes + h * bytes; - -for (m =0 ; m < font->width; m++) { - n = m %8 ; - x = *(src + m /8 ); -if ((x >> (7 - n)) &1 ) - *dst = color_white; -else - *dst = color_black; - dst++; - } -} - -static void -efi_earlycon_write (struct console *con,const char *str,unsigned int num) -{ -struct screen_info *si; -unsigned int len; -const char *s; -void *dst; - - si = &screen_info; - len = si->lfb_linelength; - -while (num) { -unsigned int linemax; -unsigned int h, count =0 ; - -for (s = str; *s && *s !='\n' ; s++) { -if (count == num) -break ; - count++; - } - - linemax = (si->lfb_width - efi_x) / font->width; -if (count > linemax) - count = linemax; - -for (h =0 ; h < font->height; h++) { -unsigned int n, x; - - dst =efi_earlycon_map ((efi_y + h) * len, len); -if (!dst) -return ; - - s = str; - n = count; - x = efi_x; - -while (n-- >0 ) { -efi_earlycon_write_char (dst + x*4 , *s, h); - x += font->width; - s++; - } - -efi_earlycon_unmap (dst, len); - } - - num -= count; - efi_x += count * font->width; - str += count; - -if (num >0 && *s =='\n' ) { - efi_x =0 ; - efi_y += font->height; - str++; - num--; - } - -if (efi_x + font->width > si->lfb_width) { - efi_x =0 ; - efi_y += font->height; - } - -if (efi_y + font->height > si->lfb_height) { -u32 i; - - efi_y -= font->height; -efi_earlycon_scroll_up (); - -for (i =0 ; i < font->height; i++) -efi_earlycon_clear_scanline (efi_y + i); - } - } -} - -static int __init efi_earlycon_setup (struct earlycon_device *device, -const char *opt) -{ -struct screen_info *si; -u16 xres, yres; -u32 i; - -if (screen_info.orig_video_isVGA !=VIDEO_TYPE_EFI ) -return -ENODEV ; - - fb_base = screen_info.lfb_base; -if (screen_info.capabilities &VIDEO_CAPABILITY_64BIT_BASE ) - fb_base |= (u64 )screen_info.ext_lfb_base <<32 ; - - fb_wb = opt && !strcmp (opt,"ram" ); - - si = &screen_info; - xres = si->lfb_width; - yres = si->lfb_height; - -/* -* efi_earlycon_write_char() implicitly assumes a framebuffer with -* 32 bits per pixel. -*/ -if (si->lfb_depth !=32 ) -return -ENODEV ; - - font =get_default_font (xres, yres,-1 ,-1 ); -if (!font) -return -ENODEV ; - - efi_y =rounddown (yres, font->height) - font->height; -for (i =0 ; i < (yres - efi_y) / font->height; i++) -efi_earlycon_scroll_up (); - - device->con->write = efi_earlycon_write; - earlycon_console = device->con; -return 0 ; -} -EARLYCON_DECLARE (efifb, efi_earlycon_setup);drivers/video/console/Kconfig +11
-0@@ -69,6 +69,17 @@ config DUMMY_CONSOLE_ROWS monitor. Select 25 if you use a 640x480 resolution by default. +config FB_EARLYCON + bool "Generic framebuffer early console" + depends on SERIAL_EARLYCON && !ARM && !IA64 + select FONT_SUPPORT + select ARCH_USE_MEMREMAP_PROT + help + Say Y here if you want early console support for firmware established + linear framebuffer. Unless you are using EFI framebuffer, you need to + specify framebuffer geometry and address in device-tree or in kernel + command line. + config FRAMEBUFFER_CONSOLE bool "Framebuffer Console support" depends on FB && !UMLdrivers/video/console/Makefile +1
-0@@ -9,4 +9,5 @@ obj-$(CONFIG_STI_CONSOLE) += sticon.o sticore.o obj-$(CONFIG_VGA_CONSOLE) += vgacon.o obj-$(CONFIG_MDA_CONSOLE) += mdacon.o +obj-$(CONFIG_FB_EARLYCON) += earlycon.o obj-$(CONFIG_FB_STI) += sticore.odrivers/video/console/earlycon.c new file +305
-0@@ -0,0 +1,305 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (C) 2013 Intel Corporation; author Matt Fleming +* Copyright (C) 2022 Markuss Broks <[email protected]> +*/ + +#include <asm/early_ioremap.h> +#include <linux/console.h> +#include <linux/efi.h> +#include <linux/font.h> +#include <linux/io.h> +#include <linux/kernel.h> +#include <linux/mm.h> +#include <linux/of.h> +#include <linux/of_fdt.h> +#include <linux/serial_core.h> +#include <linux/screen_info.h> + +struct fb_earlycon { +u32 x, y, curr_x, curr_y, depth, stride; +size_t size; +phys_addr_t phys_base; +void __iomem *virt_base; +}; + +static const struct console *earlycon_console__initconst ; +static struct fb_earlycon info; +static const struct font_desc *font; + +static int __init simplefb_earlycon_remap_fb (void ) +{ +unsigned long mapping; +/* bail if there is no bootconsole or it has been disabled already */ +if (!earlycon_console || !(earlycon_console->flags &CON_ENABLED )) +return 0 ; + +if (region_intersects (info.phys_base, info.size, +IORESOURCE_SYSTEM_RAM ,IORES_DESC_NONE ) ==REGION_INTERSECTS ) + mapping =MEMREMAP_WB ; +else + mapping =MEMREMAP_WC ; + + info.virt_base =memremap (info.phys_base, info.size, mapping); + +return info.virt_base ?0 : -ENOMEM ; +} +early_initcall (simplefb_earlycon_remap_fb); + +static int __init simplefb_earlycon_unmap_fb (void ) +{ +/* unmap the bootconsole fb unless keep_bootcon has left it enabled */ +if (info.virt_base && !(earlycon_console->flags &CON_ENABLED )) +memunmap (info.virt_base); +return 0 ; +} +late_initcall (simplefb_earlycon_unmap_fb); + +static __ref void *simplefb_earlycon_map (unsigned long start,unsigned long len) +{ +pgprot_t fb_prot; + +if (info.virt_base) +return info.virt_base + start; + + fb_prot =PAGE_KERNEL ; +return early_memremap_prot (info.phys_base + start, len,pgprot_val (fb_prot)); +} + +static __ref void simplefb_earlycon_unmap (void *addr,unsigned long len) +{ +if (info.virt_base) +return ; + +early_memunmap (addr, len); +} + +static void simplefb_earlycon_clear_scanline (unsigned int y) +{ +unsigned long *dst; +u16 len; + + len = info.stride; + dst =simplefb_earlycon_map (y * len, len); +if (!dst) +return ; + +memset (dst,0 , len); +simplefb_earlycon_unmap (dst, len); +} + +static void simplefb_earlycon_scroll_up (void ) +{ +unsigned long *dst, *src; +u16 len; +u32 i, height; + + len = info.stride; + height = info.y; + +for (i =0 ; i < height - font->height; i++) { + dst =simplefb_earlycon_map (i * len, len); +if (!dst) +return ; + + src =simplefb_earlycon_map ((i + font->height) * len, len); +if (!src) { +simplefb_earlycon_unmap (dst, len); +return ; + } + +memmove (dst, src, len); + +simplefb_earlycon_unmap (src, len); +simplefb_earlycon_unmap (dst, len); + } +} + +static void simplefb_earlycon_write_char (u8 *dst,unsigned char c,unsigned int h) +{ +const u8 *src; +int m, n, bytes; +u8 x; + + bytes =BITS_TO_BYTES (font->width); + src = font->data + c * font->height * bytes + h * bytes; + +for (m =0 ; m < font->width; m++) { + n = m %8 ; + x = *(src + m /8 ); +if ((x >> (7 - n)) &1 ) +memset (dst,0xff , (info.depth /8 )); +else +memset (dst,0 , (info.depth /8 )); + dst += (info.depth /8 ); + } +} + +static void +simplefb_earlycon_write (struct console *con,const char *str,unsigned int num) +{ +unsigned int len; +const char *s; +void *dst; + + len = info.stride; + +while (num) { +unsigned int linemax; +unsigned int h, count =0 ; + +for (s = str; *s && *s !='\n' ; s++) { +if (count == num) +break ; + count++; + } + + linemax = (info.x - info.curr_x) / font->width; +if (count > linemax) + count = linemax; + +for (h =0 ; h < font->height; h++) { +unsigned int n, x; + + dst =simplefb_earlycon_map ((info.curr_y + h) * len, len); +if (!dst) +return ; + + s = str; + n = count; + x = info.curr_x; + +while (n-- >0 ) { +simplefb_earlycon_write_char (dst + (x *4 ), *s, h); + x += font->width; + s++; + } + +simplefb_earlycon_unmap (dst, len); + } + + num -= count; + info.curr_x += count * font->width; + str += count; + +if (num >0 && *s =='\n' ) { + info.curr_x =0 ; + info.curr_y += font->height; + str++; + num--; + } + +if (info.curr_x + font->width > info.x) { + info.curr_x =0 ; + info.curr_y += font->height; + } + +if (info.curr_y + font->height > info.y) { +u32 i; + + info.curr_y -= font->height; +simplefb_earlycon_scroll_up (); + +for (i =0 ; i < font->height; i++) +simplefb_earlycon_clear_scanline (info.curr_y + i); + } + } +} + +static int __init simplefb_earlycon_setup_common (struct earlycon_device *device, +const char *opt) +{ +int i; + + info.size = info.x * info.y * (info.depth /8 ); + + font =get_default_font (info.x, info.y,-1 ,-1 ); +if (!font) +return -ENODEV ; + + info.curr_y =rounddown (info.y, font->height) - font->height; +for (i =0 ; i < (info.y - info.curr_y) / font->height; i++) +simplefb_earlycon_scroll_up (); + + device->con->write = simplefb_earlycon_write; + earlycon_console = device->con; +return 0 ; +} + +static int __init simplefb_earlycon_setup (struct earlycon_device *device, +const char *opt) +{ +struct uart_port *port = &device->port; +int ret; + +if (!port->mapbase) +return -ENODEV ; + + info.phys_base = port->mapbase; + + ret =sscanf (device->options,"%ux%ux%u" , &info.x, &info.y, &info.depth); +if (ret !=3 ) +return -ENODEV ; + + info.stride = info.x * (info.depth /8 ); + +return simplefb_earlycon_setup_common (device, opt); +} + +EARLYCON_DECLARE (simplefb, simplefb_earlycon_setup); + +#ifdef CONFIG_EFI_EARLYCON +static int __init simplefb_earlycon_setup_efi (struct earlycon_device *device, +const char *opt) +{ +if (screen_info.orig_video_isVGA !=VIDEO_TYPE_EFI ) +return -ENODEV ; + + info.phys_base = screen_info.lfb_base; +if (screen_info.capabilities &VIDEO_CAPABILITY_64BIT_BASE ) + info.phys_base |= (u64 )screen_info.ext_lfb_base <<32 ; + + info.x = screen_info.lfb_width; + info.y = screen_info.lfb_height; + info.depth = screen_info.lfb_depth; + info.stride = screen_info.lfb_linelength; + +return simplefb_earlycon_setup_common (device, opt); +} + +EARLYCON_DECLARE (efifb, simplefb_earlycon_setup_efi); +#endif + +#ifdef CONFIG_OF_EARLY_FLATTREE +static int __init simplefb_earlycon_setup_of (struct earlycon_device *device, +const char *opt) +{ +struct uart_port *port = &device->port; +const __be32 *val; + +if (!port->mapbase) +return -ENODEV ; + + info.phys_base = port->mapbase; + + val =of_get_flat_dt_prop (device->offset,"width" ,NULL ); +if (!val) +return -ENODEV ; + info.x =be32_to_cpu (*val); + + val =of_get_flat_dt_prop (device->offset,"height" ,NULL ); +if (!val) +return -ENODEV ; + info.y =be32_to_cpu (*val); + + val =of_get_flat_dt_prop (device->offset,"stride" ,NULL ); +if (!val) +return -ENODEV ; + info.stride =be32_to_cpu (*val); + info.depth = (info.stride / info.x) *8 ; + +return simplefb_earlycon_setup_common (device, opt); +} + +OF_EARLYCON_DECLARE (simplefb,"simple-framebuffer" , simplefb_earlycon_setup_of); +#endif Signature · 1 line
2.37.0
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Re: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem
In reply to Daniel VetterQuoted 9 lines · Daniel Vetter
On Sat, Aug 06, 2022 at 07:32:24PM +0300, Markuss Broks wrote:
Ok I have a more fundamental issue with this than the lack of proper patch splitting I mentioned in the other thread.
This is the wrong place.
drivers/video/consoleis about the various vt console implementations, which supply a struct consw tocon_register_driver.
You are right, that was my mistake. The original patch was for drivers/video/fbdev/, and I suggested moving it out of there because it does not depend on the fbdev subsystem, but clearly my suggestions of drivers/video/console was equally wrong.
Quoted 5 lines
This otoh is an (early) kernel/printk console implemented using struct console. Totally different thing, and really shouldn't end up in
drivers/video/consoleimo. Somewhere indrivers/firmwaremight still be the best place, the sysfb stuff is also there. Maybedrivers/firmware/sysfb_earlycon.c?
drivers/firmware/ is better but doesn't sound great to me either, since one important thing the patch does is to not make it depend on EFI firmware or BIOS style screen_info any more.
Maybe drivers/tty/earlycon_simplefb.c would work better, keeping it close to the earlycon base support in drivers/tty/serial/, the vt console and the old simplefb driver/, without tying to too closely to fbdev of UEFI.
Arnd
Ard Biesheuvel
maintainerQuoted 21 lines · Markuss Broks
Make the EFI earlycon driver be suitable for any linear framebuffers. This should be helpful for early porting of boards with no other means of output, like smartphones/tablets. There seems to be an issue with
early_ioremapfunction on ARM32, but I am unable to find the exact cause. It appears the mappings returned by it are somehow incorrect, thus the driver is disabled on ARM. EFI early console was disabled on IA64 previously because of missingearly_memremap_prot, and this is inherited to this driver.This patch also changes behavior on EFI systems, by selecting the mapping type based on if the framebuffer region intersects with system RAM. If it does, it's common sense that it should be in RAM as a whole, and so the system RAM mapping is used. It was tested to be working on my PC (Intel Z490 platform), as well as several ARM64 boards (Samsung Galaxy S9 (Exynos), iPad Air 2, Xiaomi Mi Pad 4, ...).
Markuss Broks (2):
drivers: serial: earlycon: Pass device-tree node
efi: earlycon: Add support for generic framebuffers and move to fbdev
subsystem
Quoted 8 lines
v1 -> v2:
- a new patch correcting
serial/earlycon.cargument name to "offset" instead of "node"
- move IA64 exclusion from EFI earlyconKconfigto earlycon driverKconfig(IA64 has noearly_memremap_prot)
- move driver from fbdev to console subsystem
- select EFI earlycon by default
Wasn't EFI earlycon already enabled by default?
Quoted 21 lines
- fetch stride manually from device-tree, as on some devices it seems stride doesn't match the horizontal resolution * bpp.
- use saner format (e.g. 1920x1080x32 instead of 1920,1080,32)..../admin-guide/kernel-parameters.txt | 12 +- MAINTAINERS | 5 + drivers/firmware/efi/Kconfig | 6 +- drivers/firmware/efi/Makefile | 1 - drivers/firmware/efi/earlycon.c | 246 -------------- drivers/tty/serial/earlycon.c | 3 + drivers/video/fbdev/Kconfig | 11 + drivers/video/fbdev/Makefile | 1 + drivers/video/fbdev/earlycon.c | 301 ++++++++++++++++++ include/linux/serial_core.h | 1 + 10 files changed, 331 insertions(+), 256 deletions(-) delete mode 100644 drivers/firmware/efi/earlycon.c create mode 100644 drivers/video/fbdev/earlycon.c--
2.37.0