Skip to contentSkip to conversation

iio: adc: mt6360: Drop an incorrect __maybe_unused marking.

PATCH In review Jonathan Cameron 2 participants 3 messages Aug 7, 2022 – Aug 13, 2022

Subsystems (2)
lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: mt6360: Drop an incorrect __maybe_unused marking.

From: Jonathan Cameron <[email protected]>

Given the struct platform_driver has one of it's elements assigned to point to the of_device_id table, it is never going to be unused.

Drop the marking.

---
 drivers/iio/adc/mt6360-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/mt6360-adc.c +1 -1
index 35260d9e4e47..3710473e526f 100644
@@ -353,7 +353,7 @@ static int mt6360_adc_probe(struct platform_device *pdev)
 	return devm_iio_device_register(&pdev->dev, indio_dev);
 }
 
-static const struct of_device_id __maybe_unused mt6360_adc_of_id[] = {
+static const struct of_device_id mt6360_adc_of_id[] = {
 	{ .compatible = "mediatek,mt6360-adc", },
 	{}
 };
Signature · 1 line
2.37.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Given the struct platform_driver has one of it's elements assigned to point to the of_device_id table, it is never going to be unused.

Drop the marking.

Quoted 22 lines
---
 drivers/iio/adc/mt6360-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/mt6360-adc.c +1 -2
index 35260d9e4e47..3710473e526f 100644
@@ -353,7 +353,7 @@ static int mt6360_adc_probe(struct platform_device *pdev)
        return devm_iio_device_register(&pdev->dev, indio_dev);
 }
 
-static const struct of_device_id __maybe_unused mt6360_adc_of_id[] = {
+static const struct of_device_id mt6360_adc_of_id[] = {
        { .compatible = "mediatek,mt6360-adc", },
        {}
 };
--

2.37.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author maintainer Applied
#2 lore raw
Quoted 10 lines · On Mon, 8 Aug 2022 11:22:37 +0200 Andy Shevchenko <[email protected]>…
Quoted 7 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Given the struct platform_driver has one of it's elements assigned to point to the of_device_id table, it is never going to be unused.

Drop the marking.

Thanks,

Applied

Quoted 25 lines
Quoted 23 lines
---
 drivers/iio/adc/mt6360-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/mt6360-adc.c +1 -2
index 35260d9e4e47..3710473e526f 100644
@@ -353,7 +353,7 @@ static int mt6360_adc_probe(struct platform_device *pdev)
        return devm_iio_device_register(&pdev->dev, indio_dev);
 }
 
-static const struct of_device_id __maybe_unused mt6360_adc_of_id[] = {
+static const struct of_device_id mt6360_adc_of_id[] = {
        { .compatible = "mediatek,mt6360-adc", },
        {}
 };
--

2.37.1