Skip to contentSkip to conversation

documentation-mm-dont-kmap-pages-which-cant-come-from-highmem.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Aug 9, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: Documentation/mm: don't kmap*() pages which can't come from HIGHMEM
has been removed from the -mm tree. Its filename was
documentation-mm-dont-kmap-pages-which-cant-come-from-highmem.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: "Fabio M. De Francesco" <[email protected]>
Subject: Documentation/mm: don't kmap*() pages which can't come from HIGHMEM
Date: Thu, 28 Jul 2022 17:48:40 +0200

There is no need to kmap*() pages which are guaranteed to come from ZONE_NORMAL (or lower). Linux has currently several call sites of kmap{,_atomic,_local_page}() on pages which are clearly known which can't come from ZONE_HIGHMEM.

Therefore, add a paragraph to highmem.rst, to explain better that a plain page_address() may be used for getting the address of pages which cannot come from ZONE_HIGHMEM, although it is always safe to use kmap_local_page() / kunmap_local() also on those pages.

Cc Matthew Wilcox (Oracle) <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Sebastian Andrzej Siewior <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Peter Collingbourne <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Will Deacon <[email protected]>

---

 Documentation/mm/highmem.rst |    6 ++++++
 1 file changed, 6 insertions(+)
Documentation/mm/highmem.rst renamed from Documentation/mm/highmem.rst~documentation-mm-dont-kmap-pages-which-cant-come-from-highmem +6 -0
@@ -71,6 +71,12 @@ list shows them in order of preference o
   kmap_local_page() always returns a valid virtual address and it is assumed
   that kunmap_local() will never fail.
 
+  On CONFIG_HIGHMEM=n kernels and for low memory pages this returns the
+  virtual address of the direct mapping. Only real highmem pages are
+  temporarily mapped. Therefore, users may call a plain page_address()
+  for pages which are known to not come from ZONE_HIGHMEM. However, it is
+  always safe to use kmap_local_page() / kunmap_local().
+
   Nesting kmap_local_page() and kmap_atomic() mappings is allowed to a certain
   extent (up to KMAP_TYPE_NR) but their invocations have to be strictly ordered
   because the map implementation is stack based. See kmap_local_page() kdocs

_

Patches currently in -mm which might be from [email protected] are