Skip to contentSkip to conversation

documentation-mm-avoid-invalid-use-of-addresses-from-kmap_local_page.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Aug 9, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: Documentation/mm: avoid invalid use of addresses from kmap_local_page()
has been removed from the -mm tree. Its filename was
documentation-mm-avoid-invalid-use-of-addresses-from-kmap_local_page.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: "Fabio M. De Francesco" <[email protected]>
Subject: Documentation/mm: avoid invalid use of addresses from kmap_local_page()
Date: Thu, 28 Jul 2022 17:48:41 +0200

Users of kmap_local_page() must be absolutely sure to not hand kernel virtual address obtained calling kmap_local_page() on highmem pages to other contexts because those pointers are thread local, therefore, they are no longer valid across different contexts.

Extend the documentation of kmap_local_page() to warn users about the above-mentioned potential invalid use of pointers returned by kmap_local_page().

Cc Matthew Wilcox (Oracle) <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Sebastian Andrzej Siewior <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Peter Collingbourne <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Will Deacon <[email protected]>

---

 Documentation/mm/highmem.rst |    7 +++++++
 1 file changed, 7 insertions(+)
Documentation/mm/highmem.rst renamed from Documentation/mm/highmem.rst~documentation-mm-avoid-invalid-use-of-addresses-from-kmap_local_page +7 -0
@@ -77,6 +77,13 @@ list shows them in order of preference o
   for pages which are known to not come from ZONE_HIGHMEM. However, it is
   always safe to use kmap_local_page() / kunmap_local().
 
+  While it is significantly faster than kmap(), for the higmem case it
+  comes with restrictions about the pointers validity. Contrary to kmap()
+  mappings, the local mappings are only valid in the context of the caller
+  and cannot be handed to other contexts. This implies that users must
+  be absolutely sure to keep the use of the return address local to the
+  thread which mapped it.
+
   Nesting kmap_local_page() and kmap_atomic() mappings is allowed to a certain
   extent (up to KMAP_TYPE_NR) but their invocations have to be strictly ordered
   because the map implementation is stack based. See kmap_local_page() kdocs

_

Patches currently in -mm which might be from [email protected] are