Skip to contentSkip to conversation

dt-bindings: pinctrl: qcom,ipq6018: Fix example 'gpio-ranges' size

PATCH In review Rob Herring 3 participants 4 messages Aug 9, 2022 – Aug 25, 2022

Subsystems (6)
Device tree bindings Arm Qualcomm mailing list GPIO Pin control +2 more subsystems
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: pinctrl: qcom,ipq6018: Fix example 'gpio-ranges' size

'gpio-ranges' entries have a fixed size of 1 phandle plus arg 3 cells. The qcom,ipq6018-pinctrl example is a cell short:

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.example.dtb: pinctrl@1000000: gpio-ranges:0: [1, 0, 80] is too short
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/gpio/gpio.yaml

Signed-off-by Rob Herring <[email protected]>

---
Please ack and I can send to Linus before rc1.

---
 .../devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml +1 -1
index b83c7f476e19..931e5c190ead 100644
@@ -144,7 +144,7 @@ examples:
               #interrupt-cells = <2>;
               gpio-controller;
               #gpio-cells = <2>;
-              gpio-ranges = <&tlmm 0 80>;
+              gpio-ranges = <&tlmm 0 0 80>;
 
               serial3-pinmux {
                       pins = "gpio44", "gpio45";
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Rob Herring

'gpio-ranges' entries have a fixed size of 1 phandle plus arg 3 cells. The qcom,ipq6018-pinctrl example is a cell short:

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.example.dtb: pinctrl@1000000: gpio-ranges:0: [1, 0, 80] is too short
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/gpio/gpio.yaml

Signed-off-by Rob Herring <[email protected]>

---
Please ack and I can send to Linus before rc1.
---

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Acked-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 9 lines · Rob Herring

'gpio-ranges' entries have a fixed size of 1 phandle plus arg 3 cells. The qcom,ipq6018-pinctrl example is a cell short:

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.example.dtb: pinctrl@1000000: gpio-ranges:0: [1, 0, 80] is too short
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/gpio/gpio.yaml

Signed-off-by Rob Herring <[email protected]>

---
Please ack and I can send to Linus before rc1.

Sorry for delay, was on vacation :/

Acked-by Linus Walleij <[email protected]>

I think as binding maintainer you can just submit this kind of smaller stuff without any subsystem consent, if you have it acked by Krzysztof, even more so.

Yours,
Linus Walleij

author maintainer
#3 lore raw
Quoted 12 lines · Linus Walleij
Quoted 9 lines · Rob Herring

'gpio-ranges' entries have a fixed size of 1 phandle plus arg 3 cells. The qcom,ipq6018-pinctrl example is a cell short:

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.example.dtb: pinctrl@1000000: gpio-ranges:0: [1, 0, 80] is too short
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/gpio/gpio.yaml

Signed-off-by Rob Herring <[email protected]>

---
Please ack and I can send to Linus before rc1.

Quoted 5 lines

Sorry for delay, was on vacation :/

Acked-by Linus Walleij <[email protected]>

I think as binding maintainer you can just submit this kind of smaller stuff without any subsystem consent, if you have it acked by Krzysztof, even more so.

Don't worry, I did. It is in rc1.

Rob