drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only
Subsystems (7)
Lyude Paul
maintainerv2 cover drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only
For quite a while we've been carrying around a lot of legacy modesetting code in the MST helpers that has been rather annoying to keep around, and very often gets in the way of trying to implement additional functionality in MST such as fallback link rate retraining, dynamic BPC management and DSC support, etc. because of the fact that we can't rely on atomic for everything.
Luckily, we only actually have one user of the legacy MST code in the kernel - radeon. Originally I was thinking of trying to maintain this code and keep it around in some form, but I'm pretty unconvinced anyone is actually using this. My reasoning for that is because I've seen nearly no issues regarding MST on radeon for quite a while now - despite the fact my local testing seems to indicate it's quite broken. This isn't too surprising either, as MST support in radeon.ko is gated behind a module parameter that isn't enabled by default. This isn't to say I wouldn't be open to alternative suggestions, but I'd rather not be the one to have to spend time on that if at all possible! Plus, I already floated the idea of dropping this code by AMD folks a few times and didn't get much resistance.
As well, this series has some basic refactoring that I did along the way and some bugs I had to fix in order to get my atomic-only MST code working. Most of this is pretty straight forward and simply renaming things to more closely match the DisplayPort specification, as I think this will also make maintaining this code a lot easier in the long run (I've gotten myself confused way too many times because of this).
So far I've tested this on all three MST drivers: amdgpu, i915 and nouveau, along with making sure that removing the radeon MST code doesn't break anything else. The one thing I very much could use help with regarding testing though is making sure that this works with amdgpu's DSC support on MST.
So, with this we should be using the atomic state as much as possible with MST modesetting, hooray!
Lyude Paul (18):
drm/amdgpu/dc/mst: Rename dp_mst_stream_allocation(_table) drm/amdgpu/dm/mst: Rename get_payload_table() drm/display/dp_mst: Rename drm_dp_mst_vcpi_allocation drm/display/dp_mst: Call them time slots, not VCPI slots drm/display/dp_mst: Fix confusing docs for
drm_dp_atomic_release_time_slots()
drm/display/dp_mst: Add some missing kdocs for atomic MST structs drm/display/dp_mst: Add helper for finding payloads in atomic MST
state
drm/display/dp_mst: Add nonblocking helpers for DP MST drm/display/dp_mst: Don't open code modeset checks for releasing time
slots
drm/display/dp_mst: Fix modeset tracking in
drm_dp_atomic_release_vcpi_slots()
drm/nouveau/kms: Cache DP encoders in nouveau_connector drm/nouveau/kms: Pull mst state in for all modesets drm/display/dp_mst: Add helpers for serializing SST <-> MST
transitions
drm/display/dp_mst: Drop all ports from topology on CSNs before
queueing link address work
drm/display/dp_mst: Skip releasing payloads if last connected port
isn't connected
drm/display/dp_mst: Maintain time slot allocations when deleting
payloads
drm/radeon: Drop legacy MST support
drm/display/dp_mst: Move all payload info into the atomic state
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 68 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 108 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 125 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 10 +- drivers/gpu/drm/amd/display/dc/dm_helpers.h | 4 +- .../amd/display/include/link_service_types.h | 14 +- drivers/gpu/drm/display/drm_dp_mst_topology.c | 1154 ++++++++--------- drivers/gpu/drm/i915/display/intel_display.c | 6 + drivers/gpu/drm/i915/display/intel_dp.c | 9 + drivers/gpu/drm/i915/display/intel_dp_mst.c | 91 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 24 +- drivers/gpu/drm/nouveau/dispnv50/disp.c | 197 ++- drivers/gpu/drm/nouveau/dispnv50/disp.h | 2 + drivers/gpu/drm/nouveau/nouveau_connector.c | 18 +- drivers/gpu/drm/nouveau/nouveau_connector.h | 3 + drivers/gpu/drm/radeon/Makefile | 2 +- drivers/gpu/drm/radeon/atombios_crtc.c | 11 +- drivers/gpu/drm/radeon/atombios_encoders.c | 59 - drivers/gpu/drm/radeon/radeon_atombios.c | 2 - drivers/gpu/drm/radeon/radeon_connectors.c | 61 +- drivers/gpu/drm/radeon/radeon_device.c | 1 - drivers/gpu/drm/radeon/radeon_dp_mst.c | 778 ----------- drivers/gpu/drm/radeon/radeon_drv.c | 4 - drivers/gpu/drm/radeon/radeon_encoders.c | 14 +- drivers/gpu/drm/radeon/radeon_irq_kms.c | 10 +- drivers/gpu/drm/radeon/radeon_mode.h | 40 - include/drm/display/drm_dp_mst_helper.h | 234 ++-- 27 files changed, 964 insertions(+), 2085 deletions(-) delete mode 100644 drivers/gpu/drm/radeon/radeon_dp_mst.c
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 1/18 drm/amdgpu/dc/mst: Rename dp_mst_stream_allocation(_table)
Just to make this more clear to outside contributors that these are DC-specific structs, as this also threw me into a loop a number of times before I figured out the purpose of this.
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 9 ++++----- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 10 +++++----- drivers/gpu/drm/amd/display/dc/dm_helpers.h | 4 ++-- .../gpu/drm/amd/display/include/link_service_types.h | 11 ++++++++--- 4 files changed, 19 insertions(+), 15 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +4 -5
@@ -153,9 +153,8 @@ enum dc_edid_status dm_helpers_parse_edid_caps(return result; } -static void get_payload_table ( -struct amdgpu_dm_connector *aconnector, -struct dp_mst_stream_allocation_table *proposed_table) +static void get_payload_table (struct amdgpu_dm_connector *aconnector, +struct dc_dp_mst_stream_allocation_table *proposed_table) {int i; struct drm_dp_mst_topology_mgr *mst_mgr =
@@ -177,7 +176,7 @@ static void get_payload_table( mst_mgr->payloads[i].payload_state == DP_PAYLOAD_REMOTE) { -struct dp_mst_stream_allocation *sa = +struct dc_dp_mst_stream_allocation *sa = &proposed_table->stream_allocations[ proposed_table->stream_count];
@@ -201,7 +200,7 @@ void dm_helpers_dp_update_branch_info(bool dm_helpers_dp_mst_write_payload_allocation_table (struct dc_context *ctx,const struct dc_stream_state *stream, -struct dp_mst_stream_allocation_table *proposed_table, +struct dc_dp_mst_stream_allocation_table *proposed_table,bool enable) {struct amdgpu_dm_connector *aconnector;
drivers/gpu/drm/amd/display/dc/core/dc_link.c +5 -5
@@ -3516,7 +3516,7 @@ static void update_mst_stream_alloc_table(struct dc_link *link, struct stream_encoder *stream_enc, struct hpo_dp_stream_encoder *hpo_dp_stream_enc, // TODO: Rename stream_enc to dio_stream_enc? - const struct dp_mst_stream_allocation_table *proposed_table) + const struct dc_dp_mst_stream_allocation_table *proposed_table) { struct link_mst_stream_allocation work_table[MAX_CONTROLLER_NUM] = { 0 };struct link_mst_stream_allocation *dc_alloc;
@@ -3679,7 +3679,7 @@ enum dc_status dc_link_allocate_mst_payload(struct pipe_ctx *pipe_ctx) {struct dc_stream_state *stream = pipe_ctx->stream;struct dc_link *link = stream->link; -struct dp_mst_stream_allocation_table proposed_table = {0 }; +struct dc_dp_mst_stream_allocation_table proposed_table = {0 };struct fixed31_32 avg_time_slots_per_mtp;struct fixed31_32 pbn;struct fixed31_32 pbn_per_slot;
@@ -3784,7 +3784,7 @@ enum dc_status dc_link_reduce_mst_payload(struct pipe_ctx *pipe_ctx, uint32_t bwstruct fixed31_32 avg_time_slots_per_mtp;struct fixed31_32 pbn;struct fixed31_32 pbn_per_slot; -struct dp_mst_stream_allocation_table proposed_table = {0 }; +struct dc_dp_mst_stream_allocation_table proposed_table = {0 };uint8_t i;const struct link_hwss *link_hwss =get_link_hwss (link, &pipe_ctx->link_res);DC_LOGGER_INIT (link->ctx->logger);
@@ -3873,7 +3873,7 @@ enum dc_status dc_link_increase_mst_payload(struct pipe_ctx *pipe_ctx, uint32_tstruct fixed31_32 avg_time_slots_per_mtp;struct fixed31_32 pbn;struct fixed31_32 pbn_per_slot; -struct dp_mst_stream_allocation_table proposed_table = {0 }; +struct dc_dp_mst_stream_allocation_table proposed_table = {0 };uint8_t i;enum act_return_status ret;const struct link_hwss *link_hwss =get_link_hwss (link, &pipe_ctx->link_res);
@@ -3957,7 +3957,7 @@ static enum dc_status deallocate_mst_payload(struct pipe_ctx *pipe_ctx) {struct dc_stream_state *stream = pipe_ctx->stream;struct dc_link *link = stream->link; -struct dp_mst_stream_allocation_table proposed_table = {0 }; +struct dc_dp_mst_stream_allocation_table proposed_table = {0 };struct fixed31_32 avg_time_slots_per_mtp =dc_fixpt_from_int (0 );int i;bool mst_mode = (link->type == dc_connection_mst_branch);
drivers/gpu/drm/amd/display/dc/dm_helpers.h +2 -2
@@ -33,7 +33,7 @@#include "dc_types.h" #include "dc.h" -struct dp_mst_stream_allocation_table ; +struct dc_dp_mst_stream_allocation_table ;struct aux_payload ;enum aux_return_code_type ;
@@ -77,7 +77,7 @@ void dm_helpers_dp_update_branch_info(bool dm_helpers_dp_mst_write_payload_allocation_table (struct dc_context *ctx,const struct dc_stream_state *stream, -struct dp_mst_stream_allocation_table *proposed_table, +struct dc_dp_mst_stream_allocation_table *proposed_table,bool enable);/*
drivers/gpu/drm/amd/display/include/link_service_types.h +8 -3
@@ -246,8 +246,13 @@ union dpcd_training_lane_set { }; +/* AMD's copy of various payload data for MST. We have two copies of the payload table (one in DRM, +* one in DC) since DRM's MST helpers can't be accessed here. This stream allocation table should +* _ONLY_ be filled out from DM and then passed to DC, do NOT use these for _any_ kind of atomic +* state calculations in DM, or you will break something. +*/ /* DP MST stream allocation (payload bandwidth number) */ -struct dp_mst_stream_allocation { +struct dc_dp_mst_stream_allocation {uint8_t vcp_id;/* number of slots required for the DP stream in * transport packet */
@@ -255,11 +260,11 @@ struct dp_mst_stream_allocation { };/* DP MST stream allocation table */ -struct dp_mst_stream_allocation_table { +struct dc_dp_mst_stream_allocation_table {/* number of DP video streams */ int stream_count;/* array of stream allocations */ -struct dp_mst_stream_allocation stream_allocations[MAX_CONTROLLER_NUM ]; +struct dc_dp_mst_stream_allocation stream_allocations[MAX_CONTROLLER_NUM ]; };#endif /*__DAL_LINK_SERVICE_TYPES_H__*/
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 2/18 drm/amdgpu/dm/mst: Rename get_payload_table()
In reply to Lyude PaulThis function isn't too confusing if you see the comment around the call-site for it, but if you don't then it's not at all obvious this is meant to copy DRM's payload table over to DC's internal state structs. Seeing this function before finding that comment definitely threw me into a loop a few times.
So, let's rename this to make it's purpose more obvious regardless of where in the code you are.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +4 -3
@@ -153,8 +153,9 @@ enum dc_edid_status dm_helpers_parse_edid_caps(return result; } -static void get_payload_table (struct amdgpu_dm_connector *aconnector, -struct dc_dp_mst_stream_allocation_table *proposed_table) +static void +fill_dc_mst_payload_table_from_drm (struct amdgpu_dm_connector *aconnector, +struct dc_dp_mst_stream_allocation_table *proposed_table) {int i; struct drm_dp_mst_topology_mgr *mst_mgr =
@@ -252,7 +253,7 @@ bool dm_helpers_dp_mst_write_payload_allocation_table(* stream. AMD ASIC stream slot allocation should follow the same * sequence. copy DRM MST allocation to dc */ -get_payload_table (aconnector, proposed_table); +fill_dc_mst_payload_table_from_drm (aconnector, proposed_table);return true; }
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 3/18 drm/display/dp_mst: Rename drm_dp_mst_vcpi_allocation
In reply to Lyude PaulIn retrospect, the name I chose for this originally is confusing, as there's a lot more info in here then just the VCPI. This really should be called a payload. Let's make it more obvious that this is meant to be related to the atomic state and is about payloads by renaming it to drm_dp_mst_atomic_payload. Also, rename various variables throughout the code that use atomic payloads.
--- drivers/gpu/drm/display/drm_dp_mst_topology.c | 96 +++++++++---------- include/drm/display/drm_dp_mst_helper.h | 4 +- 2 files changed, 50 insertions(+), 50 deletions(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +48 -48
@@ -4370,7 +4370,7 @@ int drm_dp_atomic_find_vcpi_slots(struct drm_atomic_state *state, int pbn_div) {struct drm_dp_mst_topology_state *topology_state; -struct drm_dp_vcpi_allocation *pos, *vcpi =NULL ; +struct drm_dp_mst_atomic_payload *pos, *payload =NULL ;int prev_slots, prev_bw, req_slots; topology_state =drm_atomic_get_mst_topology_state (state, mgr);
@@ -4378,11 +4378,11 @@ int drm_dp_atomic_find_vcpi_slots(struct drm_atomic_state *state,return PTR_ERR (topology_state);/* Find the current allocation for this port, if any */ -list_for_each_entry (pos, &topology_state->vcpis, next) { +list_for_each_entry (pos, &topology_state->payloads, next) {if (pos->port == port) { - vcpi = pos; - prev_slots = vcpi->vcpi; - prev_bw = vcpi->pbn; + payload = pos; + prev_slots = payload->vcpi; + prev_bw = payload->pbn;/* * This should never happen, unless the driver tries
@@ -4399,7 +4399,7 @@ int drm_dp_atomic_find_vcpi_slots(struct drm_atomic_state *state,break ; } } -if (!vcpi) { +if (!payload) { prev_slots =0 ; prev_bw =0 ; }
@@ -4417,17 +4417,17 @@ int drm_dp_atomic_find_vcpi_slots(struct drm_atomic_state *state, port, prev_bw, pbn);/* Add the new allocation to the state */ -if (!vcpi) { - vcpi =kzalloc (sizeof (*vcpi),GFP_KERNEL ); -if (!vcpi) +if (!payload) { + payload =kzalloc (sizeof (*payload),GFP_KERNEL ); +if (!payload)return -ENOMEM ;drm_dp_mst_get_port_malloc (port); - vcpi->port = port; -list_add (&vcpi->next, &topology_state->vcpis); + payload->port = port; +list_add (&payload->next, &topology_state->payloads); } - vcpi->vcpi = req_slots; - vcpi->pbn = pbn; + payload->vcpi = req_slots; + payload->pbn = pbn;return req_slots; }
@@ -4464,21 +4464,21 @@ int drm_dp_atomic_release_vcpi_slots(struct drm_atomic_state *state, struct drm_dp_mst_port *port) {struct drm_dp_mst_topology_state *topology_state; -struct drm_dp_vcpi_allocation *pos; +struct drm_dp_mst_atomic_payload *pos;bool found = false; topology_state =drm_atomic_get_mst_topology_state (state, mgr);if (IS_ERR (topology_state))return PTR_ERR (topology_state); -list_for_each_entry (pos, &topology_state->vcpis, next) { +list_for_each_entry (pos, &topology_state->payloads, next) {if (pos->port == port) { found = true;break ; } }if (WARN_ON (!found)) { -drm_err (mgr->dev,"no VCPI for [MST PORT:%p] found in mst state %p\n" , +drm_err (mgr->dev,"No payload for [MST PORT:%p] found in mst state %p\n" , port, &topology_state->base);return -EINVAL ; }
@@ -5060,7 +5060,7 @@ drm_dp_mst_duplicate_state(struct drm_private_obj *obj) {struct drm_dp_mst_topology_state *state, *old_state =to_dp_mst_topology_state (obj->state); -struct drm_dp_vcpi_allocation *pos, *vcpi; +struct drm_dp_mst_atomic_payload *pos, *payload; state =kmemdup (old_state,sizeof (*state),GFP_KERNEL );if (!state)
@@ -5068,25 +5068,25 @@ drm_dp_mst_duplicate_state(struct drm_private_obj *obj)__drm_atomic_helper_private_obj_duplicate_state (obj, &state->base); -INIT_LIST_HEAD (&state->vcpis); +INIT_LIST_HEAD (&state->payloads); -list_for_each_entry (pos, &old_state->vcpis, next) { +list_for_each_entry (pos, &old_state->payloads, next) {/* Prune leftover freed VCPI allocations */ if (!pos->vcpi)continue ; - vcpi =kmemdup (pos,sizeof (*vcpi),GFP_KERNEL ); -if (!vcpi) + payload =kmemdup (pos,sizeof (*payload),GFP_KERNEL ); +if (!payload) goto fail; -drm_dp_mst_get_port_malloc (vcpi->port); -list_add (&vcpi->next, &state->vcpis); +drm_dp_mst_get_port_malloc (payload->port); +list_add (&payload->next, &state->payloads); }return &state->base; fail: -list_for_each_entry_safe (pos, vcpi, &state->vcpis, next) { +list_for_each_entry_safe (pos, payload, &state->payloads, next) {drm_dp_mst_put_port_malloc (pos->port);kfree (pos); }
@@ -5100,9 +5100,9 @@ static void drm_dp_mst_destroy_state(struct drm_private_obj *obj, {struct drm_dp_mst_topology_state *mst_state =to_dp_mst_topology_state (state); -struct drm_dp_vcpi_allocation *pos, *tmp; +struct drm_dp_mst_atomic_payload *pos, *tmp; -list_for_each_entry_safe (pos, tmp, &mst_state->vcpis, next) { +list_for_each_entry_safe (pos, tmp, &mst_state->payloads, next) {/* We only keep references to ports with non-zero VCPIs */ if (pos->vcpi)drm_dp_mst_put_port_malloc (pos->port);
@@ -5135,7 +5135,7 @@ static int drm_dp_mst_atomic_check_mstb_bw_limit(struct drm_dp_mst_branch *mstb, struct drm_dp_mst_topology_state *state) { - struct drm_dp_vcpi_allocation *vcpi; + struct drm_dp_mst_atomic_payload *payload;struct drm_dp_mst_port *port;int pbn_used =0 , ret;bool found = false;
@@ -5143,9 +5143,9 @@ drm_dp_mst_atomic_check_mstb_bw_limit(struct drm_dp_mst_branch *mstb,/* Check that we have at least one port in our state that's downstream * of this branch, otherwise we can skip this branch */ -list_for_each_entry (vcpi, &state->vcpis, next) { -if (!vcpi->pbn || - !drm_dp_mst_port_downstream_of_branch (vcpi->port, mstb)) +list_for_each_entry (payload, &state->payloads, next) { +if (!payload->pbn || + !drm_dp_mst_port_downstream_of_branch (payload->port, mstb))continue ; found = true;
@@ -5176,7 +5176,7 @@ static int drm_dp_mst_atomic_check_port_bw_limit(struct drm_dp_mst_port *port, struct drm_dp_mst_topology_state *state) { - struct drm_dp_vcpi_allocation *vcpi; + struct drm_dp_mst_atomic_payload *payload;int pbn_used =0 ;if (port->pdt ==DP_PEER_DEVICE_NONE )
@@ -5185,10 +5185,10 @@ drm_dp_mst_atomic_check_port_bw_limit(struct drm_dp_mst_port *port,if (drm_dp_mst_is_end_device (port->pdt, port->mcs)) {bool found = false; -list_for_each_entry (vcpi, &state->vcpis, next) { -if (vcpi->port != port) +list_for_each_entry (payload, &state->payloads, next) { +if (payload->port != port)continue ; -if (!vcpi->pbn) +if (!payload->pbn)return 0 ; found = true;
@@ -5208,7 +5208,7 @@ drm_dp_mst_atomic_check_port_bw_limit(struct drm_dp_mst_port *port,return -EINVAL ; } - pbn_used = vcpi->pbn; + pbn_used = payload->pbn; }else { pbn_used =drm_dp_mst_atomic_check_mstb_bw_limit (port->mstb, state);
@@ -5233,25 +5233,25 @@ static inline int drm_dp_mst_atomic_check_vcpi_alloc_limit(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_topology_state *mst_state) { - struct drm_dp_vcpi_allocation *vcpi; + struct drm_dp_mst_atomic_payload *payload;int avail_slots = mst_state->total_avail_slots, payload_count =0 ; -list_for_each_entry (vcpi, &mst_state->vcpis, next) { -/* Releasing VCPI is always OK-even if the port is gone */ -if (!vcpi->vcpi) { +list_for_each_entry (payload, &mst_state->payloads, next) { +/* Releasing payloads is always OK-even if the port is gone */ +if (!payload->vcpi) {drm_dbg_atomic (mgr->dev,"[MST PORT:%p] releases all VCPI slots\n" , - vcpi->port); + payload->port);continue ; }drm_dbg_atomic (mgr->dev,"[MST PORT:%p] requires %d vcpi slots\n" , - vcpi->port, vcpi->vcpi); + payload->port, payload->vcpi); - avail_slots -= vcpi->vcpi; + avail_slots -= payload->vcpi;if (avail_slots <0 ) {drm_dbg_atomic (mgr->dev,"[MST PORT:%p] not enough VCPI slots in mst state %p (avail=%d)\n" , - vcpi->port, mst_state, avail_slots + vcpi->vcpi); + payload->port, mst_state, avail_slots + payload->vcpi);return -ENOSPC ; }
@@ -5284,7 +5284,7 @@ drm_dp_mst_atomic_check_vcpi_alloc_limit(struct drm_dp_mst_topology_mgr *mgr,int drm_dp_mst_add_affected_dsc_crtcs (struct drm_atomic_state *state,struct drm_dp_mst_topology_mgr *mgr) {struct drm_dp_mst_topology_state *mst_state; -struct drm_dp_vcpi_allocation *pos; +struct drm_dp_mst_atomic_payload *pos;struct drm_connector *connector;struct drm_connector_state *conn_state;struct drm_crtc *crtc;
@@ -5295,7 +5295,7 @@ int drm_dp_mst_add_affected_dsc_crtcs(struct drm_atomic_state *state, struct drmif (IS_ERR (mst_state))return -EINVAL ; -list_for_each_entry (pos, &mst_state->vcpis, next) { +list_for_each_entry (pos, &mst_state->payloads, next) { connector = pos->port->connector;
@@ -5349,7 +5349,7 @@ int drm_dp_mst_atomic_enable_dsc(struct drm_atomic_state *state, bool enable) {struct drm_dp_mst_topology_state *mst_state; -struct drm_dp_vcpi_allocation *pos; +struct drm_dp_mst_atomic_payload *pos;bool found = false;int vcpi =0 ;
@@ -5358,7 +5358,7 @@ int drm_dp_mst_atomic_enable_dsc(struct drm_atomic_state *state,if (IS_ERR (mst_state))return PTR_ERR (mst_state); -list_for_each_entry (pos, &mst_state->vcpis, next) { +list_for_each_entry (pos, &mst_state->payloads, next) {if (pos->port == port) { found = true;break ;
@@ -5544,7 +5544,7 @@ int drm_dp_mst_topology_mgr_init(struct drm_dp_mst_topology_mgr *mgr, mst_state->start_slot =1 ; mst_state->mgr = mgr; -INIT_LIST_HEAD (&mst_state->vcpis); +INIT_LIST_HEAD (&mst_state->payloads); drm_atomic_private_obj_init(dev, &mgr->base, &mst_state->base,
include/drm/display/drm_dp_mst_helper.h +2 -2
@@ -542,7 +542,7 @@ struct drm_dp_payload {#define to_dp_mst_topology_state (x) container_of(x, struct drm_dp_mst_topology_state, base) -struct drm_dp_vcpi_allocation { +struct drm_dp_mst_atomic_payload {struct drm_dp_mst_port *port;int vcpi;int pbn;
@@ -552,7 +552,7 @@ struct drm_dp_vcpi_allocation {struct drm_dp_mst_topology_state {struct drm_private_state base; -struct list_head vcpis; +struct list_head payloads;struct drm_dp_mst_topology_mgr *mgr;u8 total_avail_slots;u8 start_slot;
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 4/18 drm/display/dp_mst: Call them time slots, not VCPI slots
In reply to Lyude PaulVCPI is only sort of the correct term here, originally the majority of this code simply referred to timeslots vaguely as "slots" - and since I started working on it and adding atomic functionality, the name "VCPI slots" has been used to represent time slots.
Now that we actually have consistent access to the DisplayPort spec thanks to VESA, I now know this isn't actually the proper term - as the specification refers to these as time slots.
Since we're trying to make this code as easy to figure out as possible, let's take this opportunity to correct this nomenclature and call them by their proper name - timeslots. Likewise, we rename various functions appropriately, along with replacing references in the kernel documentation and various debugging messages.
It's important to note that this patch series leaves the legacy MST code untouched for the most part, which is fine since we'll be removing it soon anyhow. There should be no functional changes in this series.
v2:
* Add note that Wayne Lin from AMD suggested regarding slots being between the source DP Tx and the immediate downstream DP Rx
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 28 ++--- drivers/gpu/drm/display/drm_dp_mst_topology.c | 106 +++++++++--------- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 +- drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +- include/drm/display/drm_dp_mst_helper.h | 12 +- 6 files changed, 81 insertions(+), 76 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
@@ -6428,7 +6428,7 @@ static int dm_encoder_helper_atomic_check(struct drm_encoder *encoder, clock = adjusted_mode->clock; dm_new_connector_state->pbn =drm_dp_calc_pbn_mode (clock, bpp, false); } - dm_new_connector_state->vcpi_slots = drm_dp_atomic_find_vcpi_slots(state, + dm_new_connector_state->vcpi_slots = drm_dp_atomic_find_time_slots(state, mst_mgr, mst_port, dm_new_connector_state->pbn,
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +14 -14
@@ -472,7 +472,7 @@ static int dm_dp_mst_atomic_check(struct drm_connector *connector,return 0 ; } -return drm_dp_atomic_release_vcpi_slots (state, +return drm_dp_atomic_release_time_slots (state, mst_mgr, mst_port); }
@@ -785,7 +785,7 @@ static bool increase_dsc_bpp(struct drm_atomic_state *state,if (initial_slack[next_index] > fair_pbn_alloc) { vars[next_index].pbn += fair_pbn_alloc; - if (drm_dp_atomic_find_vcpi_slots(state, + if (drm_dp_atomic_find_time_slots(state, params[next_index].port->mgr, params[next_index].port, vars[next_index].pbn,
@@ -795,7 +795,7 @@ static bool increase_dsc_bpp(struct drm_atomic_state *state, vars[next_index].bpp_x16 =bpp_x16_from_pbn (params[next_index], vars[next_index].pbn); }else { vars[next_index].pbn -= fair_pbn_alloc; - if (drm_dp_atomic_find_vcpi_slots(state, + if (drm_dp_atomic_find_time_slots(state, params[next_index].port->mgr, params[next_index].port, vars[next_index].pbn,
@@ -804,7 +804,7 @@ static bool increase_dsc_bpp(struct drm_atomic_state *state, } }else { vars[next_index].pbn += initial_slack[next_index]; - if (drm_dp_atomic_find_vcpi_slots(state, + if (drm_dp_atomic_find_time_slots(state, params[next_index].port->mgr, params[next_index].port, vars[next_index].pbn,
@@ -814,7 +814,7 @@ static bool increase_dsc_bpp(struct drm_atomic_state *state, vars[next_index].bpp_x16 = params[next_index].bw_range.max_target_bpp_x16; }else { vars[next_index].pbn -= initial_slack[next_index]; - if (drm_dp_atomic_find_vcpi_slots(state, + if (drm_dp_atomic_find_time_slots(state, params[next_index].port->mgr, params[next_index].port, vars[next_index].pbn,
@@ -872,7 +872,7 @@ static bool try_disable_dsc(struct drm_atomic_state *state,break ; vars[next_index].pbn =kbps_to_peak_pbn (params[next_index].bw_range.stream_kbps); - if (drm_dp_atomic_find_vcpi_slots(state, + if (drm_dp_atomic_find_time_slots(state, params[next_index].port->mgr, params[next_index].port, vars[next_index].pbn,
@@ -884,7 +884,7 @@ static bool try_disable_dsc(struct drm_atomic_state *state, vars[next_index].bpp_x16 =0 ; }else { vars[next_index].pbn =kbps_to_peak_pbn (params[next_index].bw_range.max_kbps); - if (drm_dp_atomic_find_vcpi_slots(state, + if (drm_dp_atomic_find_time_slots(state, params[next_index].port->mgr, params[next_index].port, vars[next_index].pbn,
@@ -971,11 +971,11 @@ static bool compute_mst_dsc_configs_for_link(struct drm_atomic_state *state, vars[i + k].pbn =kbps_to_peak_pbn (params[i].bw_range.stream_kbps); vars[i + k].dsc_enabled = false; vars[i + k].bpp_x16 =0 ; -if (drm_dp_atomic_find_vcpi_slots (state, - params[i].port->mgr, - params[i].port, - vars[i + k].pbn, -dm_mst_get_pbn_divider (dc_link)) <0 ) +if (drm_dp_atomic_find_time_slots (state, + params[i].port->mgr, + params[i].port, + vars[i + k].pbn, +dm_mst_get_pbn_divider (dc_link)) <0 )return false; }if (!drm_dp_mst_atomic_check (state) && !debugfs_overwrite) {
@@ -989,7 +989,7 @@ static bool compute_mst_dsc_configs_for_link(struct drm_atomic_state *state, vars[i + k].pbn =kbps_to_peak_pbn (params[i].bw_range.min_kbps); vars[i + k].dsc_enabled = true; vars[i + k].bpp_x16 = params[i].bw_range.min_target_bpp_x16; - if (drm_dp_atomic_find_vcpi_slots(state, + if (drm_dp_atomic_find_time_slots(state, params[i].port->mgr, params[i].port, vars[i + k].pbn,
@@ -999,7 +999,7 @@ static bool compute_mst_dsc_configs_for_link(struct drm_atomic_state *state, vars[i + k].pbn =kbps_to_peak_pbn (params[i].bw_range.stream_kbps); vars[i + k].dsc_enabled = false; vars[i + k].bpp_x16 =0 ; - if (drm_dp_atomic_find_vcpi_slots(state, + if (drm_dp_atomic_find_time_slots(state, params[i].port->mgr, params[i].port, vars[i + k].pbn,
drivers/gpu/drm/display/drm_dp_mst_topology.c +53 -53
292 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dp_mst.c +2 -3
@@ -70,7 +70,7 @@ static int intel_dp_mst_compute_link_config(struct intel_encoder *encoder, crtc_state->pipe_bpp, false); - slots = drm_dp_atomic_find_vcpi_slots(state, &intel_dp->mst_mgr, + slots = drm_dp_atomic_find_time_slots(state, &intel_dp->mst_mgr, connector->port, crtc_state->pbn, drm_dp_get_vc_payload_bw(&intel_dp->mst_mgr,
@@ -344,8 +344,7 @@ intel_dp_mst_atomic_check(struct drm_connector *connector, } mgr = &enc_to_mst (to_intel_encoder (old_conn_state->best_encoder))->primary->dp.mst_mgr; - ret =drm_dp_atomic_release_vcpi_slots (&state->base, mgr, - intel_connector->port); + ret =drm_dp_atomic_release_time_slots (&state->base, mgr, intel_connector->port);return ret; }
drivers/gpu/drm/nouveau/dispnv50/disp.c +2 -2
@@ -1065,7 +1065,7 @@ nv50_msto_atomic_check(struct drm_encoder *encoder, false); } - slots =drm_dp_atomic_find_vcpi_slots (state, &mstm->mgr, mstc->port, + slots =drm_dp_atomic_find_time_slots (state, &mstm->mgr, mstc->port, asyh->dp.pbn,0 );if (slots <0 )return slots;
@@ -1277,7 +1277,7 @@ nv50_mstc_atomic_check(struct drm_connector *connector,return 0 ; } -return drm_dp_atomic_release_vcpi_slots (state, mgr, mstc->port); +return drm_dp_atomic_release_time_slots (state, mgr, mstc->port); } static int
include/drm/display/drm_dp_mst_helper.h +9 -3
@@ -544,7 +544,13 @@ struct drm_dp_payload {struct drm_dp_mst_atomic_payload {struct drm_dp_mst_port *port; -int vcpi; + +/** +* @time_slots: +* The number of timeslots allocated to this payload from the source DP Tx to +* the immediate downstream DP Rx +*/ +int time_slots;int pbn;bool dsc_enabled;struct list_head next;
@@ -846,7 +852,7 @@ void drm_dp_mst_connector_early_unregister(struct drm_connector *connector,struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state (struct drm_atomic_state *state,struct drm_dp_mst_topology_mgr *mgr);int __must_check -drm_dp_atomic_find_vcpi_slots (struct drm_atomic_state *state, +drm_dp_atomic_find_time_slots (struct drm_atomic_state *state,struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_mst_port *port,int pbn,int pbn_div);
@@ -858,7 +864,7 @@ int __must_check drm_dp_mst_add_affected_dsc_crtcs(struct drm_atomic_state *state, struct drm_dp_mst_topology_mgr *mgr);int __must_check -drm_dp_atomic_release_vcpi_slots (struct drm_atomic_state *state, +drm_dp_atomic_release_time_slots (struct drm_atomic_state *state,struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_mst_port *port); int drm_dp_send_power_updown_phy(struct drm_dp_mst_topology_mgr *mgr,
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 5/18 drm/display/dp_mst: Fix confusing docs for drm_dp_atomic_release_time_slots()
In reply to Lyude PaulFor some reason we mention returning 0 if "slots have been added back to drm_dp_mst_topology_state->avail_slots". This is totally misleading, avail_slots is simply for figuring out the total number of slots available in total on the topology and has no relation to the current payload allocations.
So, let's get rid of that comment.
--- drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +1 -2
@@ -4456,8 +4456,7 @@ EXPORT_SYMBOL(drm_dp_atomic_find_time_slots);* drm_dp_mst_atomic_check() * * Returns: -* 0 if all slots for this port were added back to -* &drm_dp_mst_topology_state.avail_slots or negative error code +* 0 on success, negative error code otherwise */ int drm_dp_atomic_release_time_slots(struct drm_atomic_state *state, struct drm_dp_mst_topology_mgr *mgr,
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 6/18 drm/display/dp_mst: Add some missing kdocs for atomic MST structs
In reply to Lyude PaulSince we're about to start adding some stuff here, we may as well fill in any missing documentation that we forgot to write.
--- include/drm/display/drm_dp_mst_helper.h | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)
include/drm/display/drm_dp_mst_helper.h +23 -0
@@ -542,7 +542,14 @@ struct drm_dp_payload {#define to_dp_mst_topology_state (x) container_of(x, struct drm_dp_mst_topology_state, base) +/** +* struct drm_dp_mst_atomic_payload - Atomic state struct for an MST payload +* +* The primary atomic state structure for a given MST payload. Stores information like current +* bandwidth allocation, intended action for this payload, etc. +*/ struct drm_dp_mst_atomic_payload { +/** @port: The MST port assigned to this payload */ struct drm_dp_mst_port *port;/**
@@ -551,16 +558,32 @@ struct drm_dp_mst_atomic_payload {* the immediate downstream DP Rx */ int time_slots; +/** @pbn: The payload bandwidth for this payload */ int pbn; +/** @dsc_enabled: Whether or not this payload has DSC enabled */ bool dsc_enabled; + +/** @next: The list node for this payload */ struct list_head next; }; +/** +* struct drm_dp_mst_topology_state - DisplayPort MST topology atomic state +* +* This struct represents the atomic state of the toplevel DisplayPort MST manager +*/ struct drm_dp_mst_topology_state { +/** @base: Base private state for atomic */ struct drm_private_state base; + +/** @payloads: The list of payloads being created/destroyed in this state */ struct list_head payloads; +/** @mgr: The topology manager */ struct drm_dp_mst_topology_mgr *mgr; + +/** @total_avail_slots: The total number of slots this topology can handle (63 or 64) */ u8 total_avail_slots; +/** @start_slot: The first usable time slot in this topology (1 or 0) */ u8 start_slot; };
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 7/18 drm/display/dp_mst: Add helper for finding payloads in atomic MST state
In reply to Lyude PaulWe already open-code this quite often, and will be iterating through payloads even more once we've moved all of the payload tracking into the atomic state. So, let's add a helper for doing this.
--- drivers/gpu/drm/display/drm_dp_mst_topology.c | 109 ++++++++---------- 1 file changed, 45 insertions(+), 64 deletions(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +45 -64
@@ -1738,6 +1738,19 @@ drm_dp_mst_dump_port_topology_history(struct drm_dp_mst_port *port) {}#define save_port_topology_ref (port, type)#endif +static struct drm_dp_mst_atomic_payload * +drm_atomic_get_mst_payload_state (struct drm_dp_mst_topology_state *state, +struct drm_dp_mst_port *port) +{ +struct drm_dp_mst_atomic_payload *payload; + +list_for_each_entry (payload, &state->payloads, next) +if (payload->port == port) +return payload; + +return NULL ; +} +static void drm_dp_destroy_mst_branch_device (struct kref *kref) { struct drm_dp_mst_branch *mstb =
@@ -4370,39 +4383,31 @@ int drm_dp_atomic_find_time_slots(struct drm_atomic_state *state, int pbn_div) {struct drm_dp_mst_topology_state *topology_state; -struct drm_dp_mst_atomic_payload *pos, *payload =NULL ; -int prev_slots, prev_bw, req_slots; +struct drm_dp_mst_atomic_payload *payload =NULL ; +int prev_slots =0 , prev_bw =0 , req_slots; topology_state =drm_atomic_get_mst_topology_state (state, mgr);if (IS_ERR (topology_state))return PTR_ERR (topology_state);/* Find the current allocation for this port, if any */ -list_for_each_entry (pos, &topology_state->payloads, next) { -if (pos->port == port) { - payload = pos; - prev_slots = payload->time_slots; - prev_bw = payload->pbn; - -/* -* This should never happen, unless the driver tries -* releasing and allocating the same timeslot allocation, -* which is an error -*/ -if (WARN_ON (!prev_slots)) { -drm_err (mgr->dev, -"cannot allocate and release time slots on [MST PORT:%p] in the same state\n" , - port); -return -EINVAL ; - } + payload =drm_atomic_get_mst_payload_state (topology_state, port); +if (payload) { + prev_slots = payload->time_slots; + prev_bw = payload->pbn; -break ; +/* +* This should never happen, unless the driver tries +* releasing and allocating the same timeslot allocation, +* which is an error +*/ +if (WARN_ON (!prev_slots)) { +drm_err (mgr->dev, +"cannot allocate and release time slots on [MST PORT:%p] in the same state\n" , + port); +return -EINVAL ; } } -if (!payload) { - prev_slots =0 ; - prev_bw =0 ; - }if (pbn_div <=0 ) pbn_div = mgr->pbn_div;
@@ -4463,30 +4468,24 @@ int drm_dp_atomic_release_time_slots(struct drm_atomic_state *state, struct drm_dp_mst_port *port) {struct drm_dp_mst_topology_state *topology_state; -struct drm_dp_mst_atomic_payload *pos; -bool found = false; +struct drm_dp_mst_atomic_payload *payload; topology_state =drm_atomic_get_mst_topology_state (state, mgr);if (IS_ERR (topology_state))return PTR_ERR (topology_state); -list_for_each_entry (pos, &topology_state->payloads, next) { -if (pos->port == port) { - found = true; -break ; - } - } -if (WARN_ON (!found)) { + payload =drm_atomic_get_mst_payload_state (topology_state, port); +if (WARN_ON (!payload)) {drm_err (mgr->dev,"No payload for [MST PORT:%p] found in mst state %p\n" , port, &topology_state->base);return -EINVAL ; } -drm_dbg_atomic (mgr->dev,"[MST PORT:%p] TU %d -> 0\n" , port, pos->time_slots); -if (pos->time_slots) { +drm_dbg_atomic (mgr->dev,"[MST PORT:%p] TU %d -> 0\n" , port, payload->time_slots); +if (payload->time_slots) {drm_dp_mst_put_port_malloc (port); - pos->time_slots =0 ; - pos->pbn =0 ; + payload->time_slots =0 ; + payload->pbn =0 ; }return 0 ;
@@ -5182,18 +5181,8 @@ drm_dp_mst_atomic_check_port_bw_limit(struct drm_dp_mst_port *port,return 0 ;if (drm_dp_mst_is_end_device (port->pdt, port->mcs)) { -bool found = false; - -list_for_each_entry (payload, &state->payloads, next) { -if (payload->port != port) -continue ; -if (!payload->pbn) -return 0 ; - - found = true; -break ; - } -if (!found) + payload =drm_atomic_get_mst_payload_state (state, port); +if (!payload)return 0 ;/*
@@ -5348,34 +5337,26 @@ int drm_dp_mst_atomic_enable_dsc(struct drm_atomic_state *state, bool enable) {struct drm_dp_mst_topology_state *mst_state; -struct drm_dp_mst_atomic_payload *pos; -bool found = false; +struct drm_dp_mst_atomic_payload *payload;int time_slots =0 ; mst_state =drm_atomic_get_mst_topology_state (state, port->mgr); -if (IS_ERR (mst_state))return PTR_ERR (mst_state); -list_for_each_entry (pos, &mst_state->payloads, next) { -if (pos->port == port) { - found = true; -break ; - } - } - -if (!found) { + payload =drm_atomic_get_mst_payload_state (mst_state, port); +if (!payload) {drm_dbg_atomic (state->dev,"[MST PORT:%p] Couldn't find payload in mst state %p\n" , port, mst_state);return -EINVAL ; } -if (pos->dsc_enabled == enable) { +if (payload->dsc_enabled == enable) {drm_dbg_atomic (state->dev,"[MST PORT:%p] DSC flag is already set to %d, returning %d time slots\n" , - port, enable, pos->time_slots); - time_slots = pos->time_slots; + port, enable, payload->time_slots); + time_slots = payload->time_slots; }if (enable) {
@@ -5387,7 +5368,7 @@ int drm_dp_mst_atomic_enable_dsc(struct drm_atomic_state *state,return -EINVAL ; } - pos->dsc_enabled = enable; + payload->dsc_enabled = enable;return time_slots; }
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 8/18 drm/display/dp_mst: Add nonblocking helpers for DP MST
In reply to Lyude PaulAs Daniel Vetter pointed out, if we only use the atomic modesetting locks with MST it's technically possible for a driver with non-blocking modesets to race when it comes to MST displays - as we make the mistake of not doing our own CRTC commit tracking in the topology_state object.
This could potentially cause problems if something like this happens:
* User starts non-blocking commit to disable CRTC-1 on MST topology 1
* User starts non-blocking commit to enable CRTC-2 on MST topology 1
There's no guarantee here that the commit for disabling CRTC-2 will only occur after CRTC-1 has finished, since neither commit shares a CRTC - only the private modesetting object for MST. Keep in mind this likely isn't a problem for blocking modesets, only non-blocking.
So, begin fixing this by keeping track of which CRTCs on a topology have changed by keeping track of which CRTCs we release or allocate timeslots on. As well, add some helpers for:
* Setting up the drm_crtc_commit structs in the ->commit_setup hook
* Waiting for any CRTC dependencies from the previous topology state
v2:
* Use drm_dp_mst_atomic_setup_commit() directly - Jani
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +- drivers/gpu/drm/display/drm_dp_mst_topology.c | 93 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_display.c | 6 ++ drivers/gpu/drm/nouveau/dispnv50/disp.c | 7 ++ include/drm/display/drm_dp_mst_helper.h | 15 +++ 5 files changed, 124 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +3 -2
@@ -2808,7 +2808,8 @@ static const struct drm_mode_config_funcs amdgpu_dm_mode_funcs = { };static struct drm_mode_config_helper_funcs amdgpu_dm_mode_config_helperfuncs = { - .atomic_commit_tail = amdgpu_dm_atomic_commit_tail + .atomic_commit_tail = amdgpu_dm_atomic_commit_tail, + .atomic_commit_setup = drm_dp_mst_atomic_setup_commit, };static void update_connector_ext_caps (struct amdgpu_dm_connector *aconnector)
@@ -7986,6 +7987,7 @@ static void amdgpu_dm_atomic_commit_tail(struct drm_atomic_state *state)DRM_ERROR ("Waiting for fences timed out!" );drm_atomic_helper_update_legacy_modeset_state (dev, state); +drm_dp_mst_atomic_wait_for_dependencies (state); dm_state =dm_atomic_get_new_state (state);if (dm_state && dm_state->context) {
@@ -8384,7 +8386,6 @@ static void amdgpu_dm_atomic_commit_tail(struct drm_atomic_state *state)dc_release_state (dc_state_temp); } -static int dm_force_atomic_commit (struct drm_connector *connector) {int ret =0 ;
drivers/gpu/drm/display/drm_dp_mst_topology.c +93 -0
140 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display.c +6 -0
@@ -7530,6 +7530,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)intel_atomic_commit_fence_wait (state);drm_atomic_helper_wait_for_dependencies (&state->base); +drm_dp_mst_atomic_wait_for_dependencies (&state->base);if (state->modeset) wakeref =intel_display_power_get (dev_priv,POWER_DOMAIN_MODESET );
@@ -8598,6 +8599,10 @@ static int intel_initial_commit(struct drm_device *dev)return ret; } +static const struct drm_mode_config_helper_funcs intel_mode_config_funcs = { + .atomic_commit_setup = drm_dp_mst_atomic_setup_commit, +}; +static void intel_mode_config_init (struct drm_i915_private *i915) {struct drm_mode_config *mode_config = &i915->drm.mode_config;
@@ -8612,6 +8617,7 @@ static void intel_mode_config_init(struct drm_i915_private *i915) mode_config->prefer_shadow =1 ; mode_config->funcs = &intel_mode_funcs; + mode_config->helper_private = &intel_mode_config_funcs; mode_config->async_page_flip =HAS_ASYNC_FLIPS (i915);
drivers/gpu/drm/nouveau/dispnv50/disp.c +7 -0
@@ -2136,6 +2136,7 @@ nv50_disp_atomic_commit_tail(struct drm_atomic_state *state)nv50_crc_atomic_stop_reporting (state);drm_atomic_helper_wait_for_fences (dev, state, false);drm_atomic_helper_wait_for_dependencies (state); +drm_dp_mst_atomic_wait_for_dependencies (state);drm_atomic_helper_update_legacy_modeset_state (dev, state);drm_atomic_helper_calc_timestamping_constants (state);
@@ -2616,6 +2617,11 @@ nv50_disp_func = { .atomic_state_free = nv50_disp_atomic_state_free, }; +static const struct drm_mode_config_helper_funcs +nv50_disp_helper_func = { + .atomic_commit_setup = drm_dp_mst_atomic_setup_commit, +}; +/****************************************************************************** * Init *****************************************************************************/
@@ -2699,6 +2705,7 @@ nv50_display_create(struct drm_device *dev)nouveau_display (dev)->fini = nv50_display_fini; disp->disp = &nouveau_display (dev)->disp; dev->mode_config.funcs = &nv50_disp_func; + dev->mode_config.helper_private = &nv50_disp_helper_func; dev->mode_config.quirk_addfb_prefer_xbgr_30bpp = true; dev->mode_config.normalize_zpos = true;
include/drm/display/drm_dp_mst_helper.h +15 -0
@@ -581,6 +581,19 @@ struct drm_dp_mst_topology_state {/** @mgr: The topology manager */ struct drm_dp_mst_topology_mgr *mgr; +/** +* @pending_crtc_mask: A bitmask of all CRTCs this topology state touches, drivers may +* modify this to add additional dependencies if needed. +*/ +u32 pending_crtc_mask; +/** +* @commit_deps: A list of all CRTC commits affecting this topology, this field isn't +* populated until drm_dp_mst_atomic_wait_for_dependencies() is called. +*/ +struct drm_crtc_commit **commit_deps; +/** @num_commit_deps: The number of CRTC commits in @commit_deps */ +size_t num_commit_deps; +/** @total_avail_slots: The total number of slots this topology can handle (63 or 64) */ u8 total_avail_slots;/** @start_slot: The first usable time slot in this topology (1 or 0) */
@@ -890,6 +903,8 @@ int __must_check drm_dp_atomic_release_time_slots(struct drm_atomic_state *state, struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port); +void drm_dp_mst_atomic_wait_for_dependencies (struct drm_atomic_state *state); +int __must_check drm_dp_mst_atomic_setup_commit (struct drm_atomic_state *state);int drm_dp_send_power_updown_phy (struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_mst_port *port,bool power_up); int drm_dp_send_query_stream_enc_status(struct drm_dp_mst_topology_mgr *mgr,
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 9/18 drm/display/dp_mst: Don't open code modeset checks for releasing time slots
In reply to Lyude PaulI'm not sure why, but at the time I originally wrote the find/release time slot helpers I thought we should avoid keeping modeset tracking out of the MST helpers. In retrospect though there's no actual good reason to do this, and the logic has ended up being identical across all the drivers using the helpers. Also, it needs to be fixed anyway so we don't break things when going atomic-only with MST.
So, let's just move this code into drm_dp_atomic_release_time_slots() and stop open coding it.
--- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 29 +++---------------- drivers/gpu/drm/display/drm_dp_mst_topology.c | 21 ++++++++++++-- drivers/gpu/drm/i915/display/intel_dp_mst.c | 24 +-------------- drivers/gpu/drm/nouveau/dispnv50/disp.c | 21 -------------- 4 files changed, 23 insertions(+), 72 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +4 -25
@@ -447,34 +447,13 @@ dm_dp_mst_detect(struct drm_connector *connector, }static int dm_dp_mst_atomic_check (struct drm_connector *connector, -struct drm_atomic_state *state) +struct drm_atomic_state *state) { -struct drm_connector_state *new_conn_state = -drm_atomic_get_new_connector_state (state, connector); -struct drm_connector_state *old_conn_state = -drm_atomic_get_old_connector_state (state, connector);struct amdgpu_dm_connector *aconnector =to_amdgpu_dm_connector (connector); -struct drm_crtc_state *new_crtc_state; -struct drm_dp_mst_topology_mgr *mst_mgr; -struct drm_dp_mst_port *mst_port; +struct drm_dp_mst_topology_mgr *mst_mgr = &aconnector->mst_port->mst_mgr; +struct drm_dp_mst_port *mst_port = aconnector->port; - mst_port = aconnector->port; - mst_mgr = &aconnector->mst_port->mst_mgr; - -if (!old_conn_state->crtc) -return 0 ; - -if (new_conn_state->crtc) { - new_crtc_state =drm_atomic_get_new_crtc_state (state, new_conn_state->crtc); -if (!new_crtc_state || - !drm_atomic_crtc_needs_modeset (new_crtc_state) || - new_crtc_state->enable) -return 0 ; - } - -return drm_dp_atomic_release_time_slots (state, - mst_mgr, - mst_port); +return drm_dp_atomic_release_time_slots (state, mst_mgr, mst_port); }static const struct drm_connector_helper_funcs dm_dp_mst_connector_helper_funcs = {
drivers/gpu/drm/display/drm_dp_mst_topology.c +18 -3
@@ -4473,14 +4473,29 @@ int drm_dp_atomic_release_time_slots(struct drm_atomic_state *state, {struct drm_dp_mst_topology_state *topology_state;struct drm_dp_mst_atomic_payload *payload; -struct drm_connector_state *conn_state; +struct drm_connector_state *old_conn_state, *new_conn_state; + + old_conn_state =drm_atomic_get_old_connector_state (state, port->connector); +if (!old_conn_state->crtc) +return 0 ; + +/* If the CRTC isn't disabled by this state, don't release it's payload */ + new_conn_state =drm_atomic_get_new_connector_state (state, port->connector); +if (new_conn_state->crtc) { +struct drm_crtc_state *crtc_state = +drm_atomic_get_new_crtc_state (state, new_conn_state->crtc); + +if (!crtc_state || + !drm_atomic_crtc_needs_modeset (crtc_state) || + crtc_state->enable) +return 0 ; + } topology_state =drm_atomic_get_mst_topology_state (state, mgr);if (IS_ERR (topology_state))return PTR_ERR (topology_state); - conn_state =drm_atomic_get_old_connector_state (state, port->connector); - topology_state->pending_crtc_mask |=drm_crtc_mask (conn_state->crtc); + topology_state->pending_crtc_mask |=drm_crtc_mask (old_conn_state->crtc); payload =drm_atomic_get_mst_payload_state (topology_state, port);if (WARN_ON (!payload)) {
drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -23
@@ -308,13 +308,10 @@ intel_dp_mst_atomic_check(struct drm_connector *connector, struct drm_atomic_state *_state) {struct intel_atomic_state *state =to_intel_atomic_state (_state); -struct drm_connector_state *new_conn_state = -drm_atomic_get_new_connector_state (&state->base, connector);struct drm_connector_state *old_conn_state =drm_atomic_get_old_connector_state (&state->base, connector);struct intel_connector *intel_connector =to_intel_connector (connector); -struct drm_crtc *new_crtc = new_conn_state->crtc;struct drm_dp_mst_topology_mgr *mgr;int ret;
@@ -326,27 +323,8 @@ intel_dp_mst_atomic_check(struct drm_connector *connector,if (ret)return ret; -if (!old_conn_state->crtc) -return 0 ; - -/* We only want to free VCPI if this state disables the CRTC on this -* connector -*/ -if (new_crtc) { -struct intel_crtc *crtc =to_intel_crtc (new_crtc); -struct intel_crtc_state *crtc_state = -intel_atomic_get_new_crtc_state (state, crtc); - -if (!crtc_state || - !drm_atomic_crtc_needs_modeset (&crtc_state->uapi) || - crtc_state->uapi.enable) -return 0 ; - } - mgr = &enc_to_mst (to_intel_encoder (old_conn_state->best_encoder))->primary->dp.mst_mgr; - ret =drm_dp_atomic_release_time_slots (&state->base, mgr, intel_connector->port); - -return ret; +return drm_dp_atomic_release_time_slots (&state->base, mgr, intel_connector->port); } static void clear_act_sent(struct intel_encoder *encoder,
drivers/gpu/drm/nouveau/dispnv50/disp.c +0 -21
@@ -1255,27 +1255,6 @@ nv50_mstc_atomic_check(struct drm_connector *connector, {struct nv50_mstc *mstc =nv50_mstc (connector);struct drm_dp_mst_topology_mgr *mgr = &mstc->mstm->mgr; -struct drm_connector_state *new_conn_state = -drm_atomic_get_new_connector_state (state, connector); -struct drm_connector_state *old_conn_state = -drm_atomic_get_old_connector_state (state, connector); -struct drm_crtc_state *crtc_state; -struct drm_crtc *new_crtc = new_conn_state->crtc; - -if (!old_conn_state->crtc) -return 0 ; - -/* We only want to free VCPI if this state disables the CRTC on this -* connector -*/ -if (new_crtc) { - crtc_state =drm_atomic_get_new_crtc_state (state, new_crtc); - -if (!crtc_state || - !drm_atomic_crtc_needs_modeset (crtc_state) || - crtc_state->enable) -return 0 ; - }return drm_dp_atomic_release_time_slots (state, mgr, mstc->port); }
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 10/18 drm/display/dp_mst: Fix modeset tracking in drm_dp_atomic_release_vcpi_slots()
In reply to Lyude PaulCurrently with the MST helpers we avoid releasing payloads _and_ avoid pulling in the MST state if there aren't any actual payload changes. While we want to keep the first step, we need to now make sure that we're always pulling in the MST state on all modesets that can modify payloads - even if the resulting payloads in the atomic state are identical to the previous ones.
This is mainly to make it so that if a CRTC is still assigned to a connector but is set to DPMS off, the CRTC still holds it's payload allocation in the atomic state and still appropriately pulls in the MST state for commit tracking. Otherwise, we'll occasionally forget to update MST payloads from changes caused by non-atomic DPMS changes. Doing this also allows us to track bandwidth limitations in a state correctly even between DPMS changes, so that there's no chance of a simple ->active change being rejected by the atomic check.
--- drivers/gpu/drm/display/drm_dp_mst_topology.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +8 -3
@@ -4474,6 +4474,7 @@ int drm_dp_atomic_release_time_slots(struct drm_atomic_state *state,struct drm_dp_mst_topology_state *topology_state;struct drm_dp_mst_atomic_payload *payload;struct drm_connector_state *old_conn_state, *new_conn_state; +bool update_payload = true; old_conn_state =drm_atomic_get_old_connector_state (state, port->connector);if (!old_conn_state->crtc)
@@ -4485,10 +4486,12 @@ int drm_dp_atomic_release_time_slots(struct drm_atomic_state *state,struct drm_crtc_state *crtc_state =drm_atomic_get_new_crtc_state (state, new_conn_state->crtc); -if (!crtc_state || - !drm_atomic_crtc_needs_modeset (crtc_state) || - crtc_state->enable) +/* No modeset means no payload changes, so it's safe to not pull in the MST state */ +if (!crtc_state || !drm_atomic_crtc_needs_modeset (crtc_state))return 0 ; + +if (!crtc_state->mode_changed && !crtc_state->connectors_changed) + update_payload = false; } topology_state =drm_atomic_get_mst_topology_state (state, mgr);
@@ -4496,6 +4499,8 @@ int drm_dp_atomic_release_time_slots(struct drm_atomic_state *state,return PTR_ERR (topology_state); topology_state->pending_crtc_mask |=drm_crtc_mask (old_conn_state->crtc); +if (!update_payload) +return 0 ; payload =drm_atomic_get_mst_payload_state (topology_state, port);if (WARN_ON (!payload)) {
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 11/18 drm/nouveau/kms: Cache DP encoders in nouveau_connector
In reply to Lyude PaulPost-NV50, the only kind of encoder you'll find for DP connectors on Nvidia GPUs are SORs (serial output resources). Because SORs have fixed associations with their connectors, we can correctly assume that any DP connector on a nvidia GPU will have exactly one SOR encoder routed to it for DisplayPort.
Since we're going to need to be able to retrieve this fixed SOR DP encoder much more often as a result of hooking up MST helpers for tracking SST<->MST transitions in atomic states, let's simply cache this encoder in nouveau_connector for any DP connectors on the system to avoid looking it up each time. This isn't safe for NV50 since PIORs then come into play, however there's no code pre-NV50 that would need to look this up anyhow - so it's not really an issue.
--- drivers/gpu/drm/nouveau/nouveau_connector.c | 4 +++- drivers/gpu/drm/nouveau/nouveau_connector.h | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_connector.c +3 -1
@@ -1367,7 +1367,7 @@ nouveau_connector_create(struct drm_device *dev,return ERR_PTR (-ENOMEM ); }drm_dp_aux_init (&nv_connector->aux); - fallthrough; +break ;default : funcs = &nouveau_connector_funcs;break ;
@@ -1430,6 +1430,8 @@ nouveau_connector_create(struct drm_device *dev,switch (type) {case DRM_MODE_CONNECTOR_DisplayPort: + nv_connector->dp_encoder =find_encoder (&nv_connector->base,DCB_OUTPUT_DP ); + fallthrough;case DRM_MODE_CONNECTOR_eDP:drm_dp_cec_register_connector (&nv_connector->aux, connector);break ;
drivers/gpu/drm/nouveau/nouveau_connector.h +3 -0
@@ -128,6 +128,9 @@ struct nouveau_connector {struct drm_dp_aux aux; +/* The fixed DP encoder for this connector, if there is one */ +struct nouveau_encoder *dp_encoder; +int dithering_mode;int scaling_mode;
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 12/18 drm/nouveau/kms: Pull mst state in for all modesets
In reply to Lyude PaulSince we're going to be relying on atomic locking for payloads now (and the MST mgr needs to track CRTCs), pull in the topology state for all modesets in nv50_msto_atomic_check().
--- drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -1
@@ -1049,7 +1049,7 @@ nv50_msto_atomic_check(struct drm_encoder *encoder,if (ret)return ret; -if (!crtc_state->mode_changed && !crtc_state->connectors_changed) +if (!drm_atomic_crtc_needs_modeset (crtc_state))return 0 ;/*
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 13/18 drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions
In reply to Lyude PaulThere's another kind of situation where we could potentially race with nonblocking modesets and MST, especially if we were to only use the locking provided by atomic modesetting:
* Display 1 begins as enabled on DP-1 in SST mode
* Display 1 switches to MST mode, exposes one sink in MST mode
* Userspace does non-blocking modeset to disable the SST display
* Userspace does non-blocking modeset to enable the MST display with a different CRTC, but the SST display hasn't been fully taken down yet
* Execution order between the last two commits isn't guaranteed since they share no drm resources
We can fix this however, by ensuring that we always pull in the atomic topology state whenever a connector capable of driving an MST display performs its atomic check - and then tracking CRTC commits happening on the SST connector in the MST topology state. So, let's add some simple helpers for doing that and hook them up in various drivers.
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++ drivers/gpu/drm/display/drm_dp_mst_topology.c | 59 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dp.c | 9 +++ drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/disp.h | 2 + drivers/gpu/drm/nouveau/nouveau_connector.c | 14 +++++ include/drm/display/drm_dp_mst_helper.h | 2 + 7 files changed, 94 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +7 -0
@@ -6318,10 +6318,17 @@ amdgpu_dm_connector_atomic_check(struct drm_connector *conn,drm_atomic_get_old_connector_state (state, conn);struct drm_crtc *crtc = new_con_state->crtc;struct drm_crtc_state *new_crtc_state; +struct amdgpu_dm_connector *aconn =to_amdgpu_dm_connector (conn);int ret;trace_amdgpu_dm_connector_atomic_check (new_con_state); +if (conn->connector_type == DRM_MODE_CONNECTOR_DisplayPort) { + ret =drm_dp_mst_root_conn_atomic_check (new_con_state, &aconn->mst_mgr); +if (ret <0 ) +return ret; + } +if (!crtc)return 0 ;
drivers/gpu/drm/display/drm_dp_mst_topology.c +59 -0
65 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dp.c +9 -0
@@ -4992,12 +4992,21 @@ static int intel_dp_connector_atomic_check(struct drm_connector *conn, {struct drm_i915_private *dev_priv =to_i915 (conn->dev);struct intel_atomic_state *state =to_intel_atomic_state (_state); +struct drm_connector_state *conn_state =drm_atomic_get_new_connector_state (_state, conn); +struct intel_connector *intel_conn =to_intel_connector (conn); +struct intel_dp *intel_dp =enc_to_intel_dp (intel_conn->encoder);int ret; ret =intel_digital_connector_atomic_check (conn, &state->base);if (ret)return ret; +if (HAS_DP_MST (dev_priv) && !intel_dp_is_edp (intel_dp)) { + ret =drm_dp_mst_root_conn_atomic_check (conn_state, &intel_dp->mst_mgr); +if (ret) +return ret; + } +/* * We don't enable port sync on BDW due to missing w/as and * due to not having adjusted the modeset sequence appropriately.
drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -1
@@ -1813,7 +1813,7 @@ nv50_sor_func = { .destroy = nv50_sor_destroy, }; -static bool nv50_has_mst (struct nouveau_drm *drm) +bool nv50_has_mst (struct nouveau_drm *drm) {struct nvkm_bios *bios =nvxx_bios (&drm->client.device);u32 data;
drivers/gpu/drm/nouveau/dispnv50/disp.h +2 -0
@@ -106,6 +106,8 @@ void nv50_dmac_destroy(struct nv50_dmac *);*/ struct nouveau_encoder *nv50_real_outp (struct drm_encoder *encoder); +bool nv50_has_mst (struct nouveau_drm *drm); +u32 *evo_wait (struct nv50_dmac *,int nr);void evo_kick (u32 *,struct nv50_dmac *);
drivers/gpu/drm/nouveau/nouveau_connector.c +14 -0
@@ -1105,11 +1105,25 @@ nouveau_connector_best_encoder(struct drm_connector *connector)return NULL ; } +static int +nouveau_connector_atomic_check (struct drm_connector *connector,struct drm_atomic_state *state) +{ +struct nouveau_connector *nv_conn =nouveau_connector (connector); +struct drm_connector_state *conn_state = +drm_atomic_get_new_connector_state (state, connector); + +if (!nv_conn->dp_encoder || !nv50_has_mst (nouveau_drm (connector->dev))) +return 0 ; + +return drm_dp_mst_root_conn_atomic_check (conn_state, &nv_conn->dp_encoder->dp.mstm->mgr); +} +static const struct drm_connector_helper_funcs nouveau_connector_helper_funcs = { .get_modes = nouveau_connector_get_modes, .mode_valid = nouveau_connector_mode_valid, .best_encoder = nouveau_connector_best_encoder, + .atomic_check = nouveau_connector_atomic_check, }; static const struct drm_connector_funcs
include/drm/display/drm_dp_mst_helper.h +2 -0
@@ -911,6 +911,8 @@ int drm_dp_send_query_stream_enc_status(struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_mst_port *port, struct drm_dp_query_stream_enc_status_ack_reply *status);int __must_check drm_dp_mst_atomic_check (struct drm_atomic_state *state); +int __must_check drm_dp_mst_root_conn_atomic_check (struct drm_connector_state *new_conn_state, +struct drm_dp_mst_topology_mgr *mgr);void drm_dp_mst_get_port_malloc (struct drm_dp_mst_port *port);void drm_dp_mst_put_port_malloc (struct drm_dp_mst_port *port);
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v3 1/1 drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions
There's another kind of situation where we could potentially race with nonblocking modesets and MST, especially if we were to only use the locking provided by atomic modesetting:
* Display 1 begins as enabled on DP-1 in SST mode
* Display 1 switches to MST mode, exposes one sink in MST mode
* Userspace does non-blocking modeset to disable the SST display
* Userspace does non-blocking modeset to enable the MST display with a different CRTC, but the SST display hasn't been fully taken down yet
* Execution order between the last two commits isn't guaranteed since they share no drm resources
We can fix this however, by ensuring that we always pull in the atomic topology state whenever a connector capable of driving an MST display performs its atomic check - and then tracking CRTC commits happening on the SST connector in the MST topology state. So, let's add some simple helpers for doing that and hook them up in various drivers.
v2:
* Use intel_dp_mst_source_support() to check for MST support in i915, fixes CI failures
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++ drivers/gpu/drm/display/drm_dp_mst_topology.c | 59 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dp.c | 9 +++ drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/disp.h | 2 + drivers/gpu/drm/nouveau/nouveau_connector.c | 14 +++++ include/drm/display/drm_dp_mst_helper.h | 2 + 7 files changed, 94 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +7 -0
@@ -6318,10 +6318,17 @@ amdgpu_dm_connector_atomic_check(struct drm_connector *conn,drm_atomic_get_old_connector_state (state, conn);struct drm_crtc *crtc = new_con_state->crtc;struct drm_crtc_state *new_crtc_state; +struct amdgpu_dm_connector *aconn =to_amdgpu_dm_connector (conn);int ret;trace_amdgpu_dm_connector_atomic_check (new_con_state); +if (conn->connector_type == DRM_MODE_CONNECTOR_DisplayPort) { + ret =drm_dp_mst_root_conn_atomic_check (new_con_state, &aconn->mst_mgr); +if (ret <0 ) +return ret; + } +if (!crtc)return 0 ;
drivers/gpu/drm/display/drm_dp_mst_topology.c +59 -0
65 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dp.c +9 -0
@@ -4992,12 +4992,21 @@ static int intel_dp_connector_atomic_check(struct drm_connector *conn, {struct drm_i915_private *dev_priv =to_i915 (conn->dev);struct intel_atomic_state *state =to_intel_atomic_state (_state); +struct drm_connector_state *conn_state =drm_atomic_get_new_connector_state (_state, conn); +struct intel_connector *intel_conn =to_intel_connector (conn); +struct intel_dp *intel_dp =enc_to_intel_dp (intel_conn->encoder);int ret; ret =intel_digital_connector_atomic_check (conn, &state->base);if (ret)return ret; +if (intel_dp_mst_source_support (intel_dp)) { + ret =drm_dp_mst_root_conn_atomic_check (conn_state, &intel_dp->mst_mgr); +if (ret) +return ret; + } +/* * We don't enable port sync on BDW due to missing w/as and * due to not having adjusted the modeset sequence appropriately.
drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -1
@@ -1813,7 +1813,7 @@ nv50_sor_func = { .destroy = nv50_sor_destroy, }; -static bool nv50_has_mst (struct nouveau_drm *drm) +bool nv50_has_mst (struct nouveau_drm *drm) {struct nvkm_bios *bios =nvxx_bios (&drm->client.device);u32 data;
drivers/gpu/drm/nouveau/dispnv50/disp.h +2 -0
@@ -106,6 +106,8 @@ void nv50_dmac_destroy(struct nv50_dmac *);*/ struct nouveau_encoder *nv50_real_outp (struct drm_encoder *encoder); +bool nv50_has_mst (struct nouveau_drm *drm); +u32 *evo_wait (struct nv50_dmac *,int nr);void evo_kick (u32 *,struct nv50_dmac *);
drivers/gpu/drm/nouveau/nouveau_connector.c +14 -0
@@ -1105,11 +1105,25 @@ nouveau_connector_best_encoder(struct drm_connector *connector)return NULL ; } +static int +nouveau_connector_atomic_check (struct drm_connector *connector,struct drm_atomic_state *state) +{ +struct nouveau_connector *nv_conn =nouveau_connector (connector); +struct drm_connector_state *conn_state = +drm_atomic_get_new_connector_state (state, connector); + +if (!nv_conn->dp_encoder || !nv50_has_mst (nouveau_drm (connector->dev))) +return 0 ; + +return drm_dp_mst_root_conn_atomic_check (conn_state, &nv_conn->dp_encoder->dp.mstm->mgr); +} +static const struct drm_connector_helper_funcs nouveau_connector_helper_funcs = { .get_modes = nouveau_connector_get_modes, .mode_valid = nouveau_connector_mode_valid, .best_encoder = nouveau_connector_best_encoder, + .atomic_check = nouveau_connector_atomic_check, }; static const struct drm_connector_funcs
include/drm/display/drm_dp_mst_helper.h +2 -0
@@ -911,6 +911,8 @@ int drm_dp_send_query_stream_enc_status(struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_mst_port *port, struct drm_dp_query_stream_enc_status_ack_reply *status);int __must_check drm_dp_mst_atomic_check (struct drm_atomic_state *state); +int __must_check drm_dp_mst_root_conn_atomic_check (struct drm_connector_state *new_conn_state, +struct drm_dp_mst_topology_mgr *mgr);void drm_dp_mst_get_port_malloc (struct drm_dp_mst_port *port);void drm_dp_mst_put_port_malloc (struct drm_dp_mst_port *port);
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 14/18 drm/display/dp_mst: Drop all ports from topology on CSNs before queueing link address work
In reply to Lyude PaulWe want to start cutting down on all of the places that we use port validation, so that ports may be removed from the topology as quickly as possible to minimize the number of errors we run into as a result of being out of sync with the current topology status. This isn't a very typical scenario and I don't think I've ever even run into it - but since the next commit is going to make some changes to payload updates depending on their hotplug status I think it's a probably good idea to take precautions.
Let's do this with CSNs by moving some code around so that we only queue link address probing work at the end of handling all CSNs - allowing us to make sure we drop as many topology references as we can beforehand.
--- drivers/gpu/drm/display/drm_dp_mst_topology.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +8 -6
@@ -2509,7 +2509,7 @@ drm_dp_mst_handle_link_address_port(struct drm_dp_mst_branch *mstb,return ret; } -static void +static int drm_dp_mst_handle_conn_stat (struct drm_dp_mst_branch *mstb,struct drm_dp_connection_status_notify *conn_stat) {
@@ -2522,7 +2522,7 @@ drm_dp_mst_handle_conn_stat(struct drm_dp_mst_branch *mstb, port =drm_dp_get_port (mstb, conn_stat->port_number);if (!port) -return ; +return 0 ;if (port->connector) {if (!port->input && conn_stat->input_port) {
@@ -2575,8 +2575,7 @@ drm_dp_mst_handle_conn_stat(struct drm_dp_mst_branch *mstb, out:drm_dp_mst_topology_put_port (port); -if (dowork) -queue_work (system_long_wq, &mstb->mgr->work); +return dowork; } static struct drm_dp_mst_branch *drm_dp_get_mst_branch_device(struct drm_dp_mst_topology_mgr *mgr,
@@ -4060,7 +4059,7 @@ drm_dp_mst_process_up_req(struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_mst_branch *mstb =NULL ;struct drm_dp_sideband_msg_req_body *msg = &up_req->msg;struct drm_dp_sideband_msg_hdr *hdr = &up_req->hdr; -bool hotplug = false; +bool hotplug = false, dowork = false;if (hdr->broadcast) {const u8 *guid =NULL ;
@@ -4083,11 +4082,14 @@ drm_dp_mst_process_up_req(struct drm_dp_mst_topology_mgr *mgr,/* TODO: Add missing handler for DP_RESOURCE_STATUS_NOTIFY events */ if (msg->req_type ==DP_CONNECTION_STATUS_NOTIFY ) { -drm_dp_mst_handle_conn_stat (mstb, &msg->u.conn_stat); + dowork =drm_dp_mst_handle_conn_stat (mstb, &msg->u.conn_stat); hotplug = true; }drm_dp_mst_topology_put_mstb (mstb); + +if (dowork) +queue_work (system_long_wq, &mgr->work);return hotplug; }
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 15/18 drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected
In reply to Lyude PaulIn the past, we've ran into strange issues regarding errors in response to trying to destroy payloads after a port has been unplugged. We fixed this back in:
This is intended to replace the workaround that was added here:
commit 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by ports in stale topology")
which was intended fix to some of the payload leaks that were observed before, where we would attempt to determine if the port was still connected to the topology before updating payloads using drm_dp_mst_port_downstream_of_branch. This wasn't a particularly good solution, since one of the points of still having port and mstb validation is to avoid sending messages to newly disconnected branches wherever possible - thus the required use of drm_dp_mst_port_downstream_of_branch would indicate something may be wrong with said validation.
It seems like it may have just been races and luck that made drm_dp_mst_port_downstream_of_branch work however, as while I was trying to figure out the true cause of this issue when removing the legacy MST code - I discovered an important excerpt in section 2.14.2.3.3.6 of the DP 2.0 specs:
"BAD_PARAM - This reply is transmitted when a Message Transaction parameter is in error; for example, the next port number is invalid or /no device is connected/ to the port associated with the port number."
Sure enough - removing the calls to drm_dp_mst_port_downstream_of_branch() and instead checking the ->ddps field of the parent port to see whether we should release a given payload or not seems to totally fix the issue. This does actually make sense to me, as it seems the implication is that given a topology where an MSTB is removed, the payload for the MST parent's port will be released automatically if that port is also marked as disconnected. However, if there's another parent in the chain after that which is connected - payloads must be released there with an ALLOCATE_PAYLOAD message.
So, let's do that!
--- drivers/gpu/drm/display/drm_dp_mst_topology.c | 51 +++++++------------ 1 file changed, 17 insertions(+), 34 deletions(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +17 -34
@@ -3128,7 +3128,7 @@ static struct drm_dp_mst_port *drm_dp_get_last_connected_port_to_mstb(struct drmstatic struct drm_dp_mst_branch *drm_dp_get_last_connected_port_and_mstb (struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_mst_branch *mstb, -int *port_num) +struct drm_dp_mst_port **last_port) {struct drm_dp_mst_branch *rmstb =NULL ;struct drm_dp_mst_port *found_port;
@@ -3144,7 +3144,8 @@ drm_dp_get_last_connected_port_and_mstb(struct drm_dp_mst_topology_mgr *mgr,if (drm_dp_mst_topology_try_get_mstb (found_port->parent)) { rmstb = found_port->parent; - *port_num = found_port->port_num; + *last_port = found_port; +drm_dp_mst_get_port_malloc (found_port); }else {/* Search again, starting from this parent */ mstb = found_port->parent;
@@ -3161,7 +3162,7 @@ static int drm_dp_payload_send_msg(struct drm_dp_mst_topology_mgr *mgr, int pbn) {struct drm_dp_sideband_msg_tx *txmsg; -struct drm_dp_mst_branch *mstb; +struct drm_dp_mst_branch *mstb =NULL ;int ret, port_num;u8 sinks[DRM_DP_MAX_SDP_STREAMS ];int i;
@@ -3169,12 +3170,22 @@ static int drm_dp_payload_send_msg(struct drm_dp_mst_topology_mgr *mgr, port_num = port->port_num; mstb =drm_dp_mst_topology_get_mstb_validated (mgr, port->parent);if (!mstb) { - mstb =drm_dp_get_last_connected_port_and_mstb (mgr, - port->parent, - &port_num); +struct drm_dp_mst_port *rport =NULL ; +bool ddps; + mstb =drm_dp_get_last_connected_port_and_mstb (mgr, port->parent, &rport);if (!mstb)return -EINVAL ; + + ddps = rport->ddps; + port_num = rport->port_num; +drm_dp_mst_put_port_malloc (rport); + +/* If the port is currently marked as disconnected, don't send a payload message */ +if (!ddps) { + ret = -EINVAL ; + goto fail_put; + } } txmsg =kzalloc (sizeof (*txmsg),GFP_KERNEL );
@@ -3375,7 +3386,6 @@ int drm_dp_update_payload_part1(struct drm_dp_mst_topology_mgr *mgr, int start_sstruct drm_dp_mst_port *port;int i, j;int cur_slots = start_slot; -bool skip;mutex_lock (&mgr->payload_lock);for (i =0 ; i < mgr->max_payloads; i++) {
@@ -3390,16 +3400,6 @@ int drm_dp_update_payload_part1(struct drm_dp_mst_topology_mgr *mgr, int start_s port = container_of(vcpi, struct drm_dp_mst_port, vcpi); -mutex_lock (&mgr->lock); - skip = !drm_dp_mst_port_downstream_of_branch (port, mgr->mst_primary); -mutex_unlock (&mgr->lock); - -if (skip) { -drm_dbg_kms (mgr->dev, -"Virtual channel %d is not in current topology\n" , - i); -continue ; - }/* Validated ports don't matter if we're releasing * VCPI */
@@ -3500,7 +3500,6 @@ int drm_dp_update_payload_part2(struct drm_dp_mst_topology_mgr *mgr)struct drm_dp_mst_port *port;int i;int ret =0 ; -bool skip;mutex_lock (&mgr->payload_lock);for (i =0 ; i < mgr->max_payloads; i++) {
@@ -3510,13 +3509,6 @@ int drm_dp_update_payload_part2(struct drm_dp_mst_topology_mgr *mgr) port = container_of(mgr->proposed_vcpis[i], struct drm_dp_mst_port, vcpi); -mutex_lock (&mgr->lock); - skip = !drm_dp_mst_port_downstream_of_branch (port, mgr->mst_primary); -mutex_unlock (&mgr->lock); - -if (skip) -continue ; -drm_dbg_kms (mgr->dev,"payload %d %d\n" , i, mgr->payloads[i].payload_state);if (mgr->payloads[i].payload_state ==DP_PAYLOAD_LOCAL ) { ret =drm_dp_create_payload_step2 (mgr, port, mgr->proposed_vcpis[i]->vcpi, &mgr->payloads[i]);
@@ -4769,18 +4761,9 @@ EXPORT_SYMBOL(drm_dp_mst_reset_vcpi_slots);void drm_dp_mst_deallocate_vcpi (struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_mst_port *port) { -bool skip; -if (!port->vcpi.vcpi)return ; -mutex_lock (&mgr->lock); - skip = !drm_dp_mst_port_downstream_of_branch (port, mgr->mst_primary); -mutex_unlock (&mgr->lock); - -if (skip) -return ; -drm_dp_mst_put_payload_id (mgr, port->vcpi.vcpi); port->vcpi.num_slots =0 ; port->vcpi.pbn =0 ;
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 16/18 drm/display/dp_mst: Maintain time slot allocations when deleting payloads
In reply to Lyude PaulCurrently, we set drm_dp_atomic_payload->time_slots to 0 in order to indicate that we're about to delete a payload in the current atomic state. Since we're going to be dropping all of the legacy code for handling the payload table however, we need to be able to ensure that we still keep track of the current time slot allocations for each payload so we can reuse this info when asking the root MST hub to delete payloads. We'll also be using it to recalculate the start slots of each VC.
So, let's keep track of the intent of a payload in drm_dp_atomic_payload by adding ->delete, which we set whenever we're planning on deleting a payload during the current atomic commit.
--- drivers/gpu/drm/display/drm_dp_mst_topology.c | 14 +++++++------- include/drm/display/drm_dp_mst_helper.h | 5 ++++- 2 files changed, 11 insertions(+), 8 deletions(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +7 -7
@@ -4399,7 +4399,7 @@ int drm_dp_atomic_find_time_slots(struct drm_atomic_state *state,* releasing and allocating the same timeslot allocation, * which is an error */ -if (WARN_ON (!prev_slots)) { +if (drm_WARN_ON (mgr->dev, payload->delete)) {drm_err (mgr->dev,"cannot allocate and release time slots on [MST PORT:%p] in the same state\n" , port);
@@ -4504,10 +4504,10 @@ int drm_dp_atomic_release_time_slots(struct drm_atomic_state *state, }drm_dbg_atomic (mgr->dev,"[MST PORT:%p] TU %d -> 0\n" , port, payload->time_slots); -if (payload->time_slots) { +if (!payload->delete) {drm_dp_mst_put_port_malloc (port); - payload->time_slots =0 ; payload->pbn =0 ; + payload->delete = true; }return 0 ;
@@ -5222,7 +5222,7 @@ drm_dp_mst_duplicate_state(struct drm_private_obj *obj)list_for_each_entry (pos, &old_state->payloads, next) {/* Prune leftover freed timeslot allocations */ -if (!pos->time_slots) +if (pos->delete)continue ; payload =kmemdup (pos,sizeof (*payload),GFP_KERNEL );
@@ -5254,8 +5254,8 @@ static void drm_dp_mst_destroy_state(struct drm_private_obj *obj,int i;list_for_each_entry_safe (pos, tmp, &mst_state->payloads, next) { -/* We only keep references to ports with non-zero VCPIs */ -if (pos->time_slots) +/* We only keep references to ports with active payloads */ +if (!pos->delete)drm_dp_mst_put_port_malloc (pos->port);kfree (pos); }
@@ -5383,7 +5383,7 @@ drm_dp_mst_atomic_check_payload_alloc_limits(struct drm_dp_mst_topology_mgr *mgrlist_for_each_entry (payload, &mst_state->payloads, next) {/* Releasing payloads is always OK-even if the port is gone */ -if (!payload->time_slots) { +if (payload->delete) {drm_dbg_atomic (mgr->dev,"[MST PORT:%p] releases all time slots\n" , payload->port);continue ;
include/drm/display/drm_dp_mst_helper.h +4 -1
@@ -560,8 +560,11 @@ struct drm_dp_mst_atomic_payload {int time_slots;/** @pbn: The payload bandwidth for this payload */ int pbn; + +/** @delete: Whether or not we intend to delete this payload during this atomic commit */ + bool delete : 1;/** @dsc_enabled: Whether or not this payload has DSC enabled */ -bool dsc_enabled; + bool dsc_enabled : 1;/** @next: The list node for this payload */ struct list_head next;
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 17/18 drm/radeon: Drop legacy MST support
In reply to Lyude PaulRight now, radeon is technically the only non-atomic driver still making use of the MST helpers - and thus the final user of all of the legacy MST helpers. Originally I was going to look into seeing if we could move legacy MST into the radeon driver itself, however:
* SI and CIK both can use amdgpu, which still supports MST
* It currently doesn't work according to my own testing. I'm sure with some troubleshooting we could likely fix it, but that brings me to point #2:
* It was never actually enabled by default, and is still marked as experimental in the module parameter description
* If people were using it, someone probably would have probably seen a bug report about how it is currently not functional by now. That certainly doesn't appear to be the case, since before getting access to my own hardware I had to go out of my way to try finding someone to help test whether this legacy MST code even works - even amongst AMD employees.
* Getting rid of this code and only having atomic versions of the MST helpers to maintain is likely going to be a lot easier in the long run, and will make it a lot easier for others contributing to this code to follow along with what's happening.
FWIW - if anyone still wants this code to be in the tree and has a good idea of how to support this without needing to maintain the legacy MST helpers (trying to move them would probably be acceptable), I'm happy to suggestions. But my hope is that we can just drop this code and forget about it. I've already run this idea by Harry Wentland and Alex Deucher a few times as well.
--- drivers/gpu/drm/radeon/Makefile | 2 +- drivers/gpu/drm/radeon/atombios_crtc.c | 11 +- drivers/gpu/drm/radeon/atombios_encoders.c | 59 -- drivers/gpu/drm/radeon/radeon_atombios.c | 2 - drivers/gpu/drm/radeon/radeon_connectors.c | 61 +- drivers/gpu/drm/radeon/radeon_device.c | 1 - drivers/gpu/drm/radeon/radeon_dp_mst.c | 778 --------------------- drivers/gpu/drm/radeon/radeon_drv.c | 4 - drivers/gpu/drm/radeon/radeon_encoders.c | 14 +- drivers/gpu/drm/radeon/radeon_irq_kms.c | 10 +- drivers/gpu/drm/radeon/radeon_mode.h | 40 -- 11 files changed, 7 insertions(+), 975 deletions(-) delete mode 100644 drivers/gpu/drm/radeon/radeon_dp_mst.c
drivers/gpu/drm/radeon/Makefile +1 -1
@@ -49,7 +49,7 @@ radeon-y += radeon_device.o radeon_asic.o radeon_kms.o \ rv770_smc.o cypress_dpm.o btc_dpm.o sumo_dpm.o sumo_smc.o trinity_dpm.o \ trinity_smc.o ni_dpm.o si_smc.o si_dpm.o kv_smc.o kv_dpm.o ci_smc.o \ ci_dpm.o dce6_afmt.o radeon_vm.o radeon_ucode.o radeon_ib.o \ - radeon_sync.o radeon_audio.o radeon_dp_auxch.o radeon_dp_mst.o + radeon_sync.o radeon_audio.o radeon_dp_auxch.o radeon-$(CONFIG_MMU_NOTIFIER) += radeon_mn.o
drivers/gpu/drm/radeon/atombios_crtc.c +1 -10
@@ -617,13 +617,6 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, } } -if (radeon_encoder->is_mst_encoder) { -struct radeon_encoder_mst *mst_enc = radeon_encoder->enc_priv; -struct radeon_connector_atom_dig *dig_connector = mst_enc->connector->con_priv; - - dp_clock = dig_connector->dp_clock; - } -/* use recommended ref_div for ss */ if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT )) {if (radeon_crtc->ss_enabled) {
@@ -972,9 +965,7 @@ static bool atombios_crtc_prepare_pll(struct drm_crtc *crtc, struct drm_display_ radeon_crtc->bpc =8 ; radeon_crtc->ss_enabled = false; -if (radeon_encoder->is_mst_encoder) { -radeon_dp_mst_prepare_pll (crtc, mode); - }else if ((radeon_encoder->active_device & (ATOM_DEVICE_LCD_SUPPORT |ATOM_DEVICE_DFP_SUPPORT )) || +if ((radeon_encoder->active_device & (ATOM_DEVICE_LCD_SUPPORT |ATOM_DEVICE_DFP_SUPPORT )) || (radeon_encoder_get_dp_bridge_encoder_id (radeon_crtc->encoder) !=ENCODER_OBJECT_ID_NONE )) {struct radeon_encoder_atom_dig *dig = radeon_encoder->enc_priv; struct drm_connector *connector =
drivers/gpu/drm/radeon/atombios_encoders.c +0 -59
78 lines not on this page · raw message
drivers/gpu/drm/radeon/radeon_atombios.c +0 -2
@@ -826,8 +826,6 @@ bool radeon_get_atom_connector_info_from_object_table(struct drm_device *dev) }radeon_link_encoder_connector (dev); - -radeon_setup_mst_connector (dev);return true; }
drivers/gpu/drm/radeon/radeon_connectors.c +3 -58
91 lines not on this page · raw message
drivers/gpu/drm/radeon/radeon_device.c +0 -1
@@ -1438,7 +1438,6 @@ int radeon_device_init(struct radeon_device *rdev, goto failed;radeon_gem_debugfs_init (rdev); -radeon_mst_debugfs_init (rdev);if (rdev->flags &RADEON_IS_AGP && !rdev->accel_working) {/* Acceleration not working on AGP card try again
drivers/gpu/drm/radeon/radeon_dp_mst.c deleted +0 -778
778 lines not on this page · raw message
drivers/gpu/drm/radeon/radeon_drv.c +0 -4
@@ -172,7 +172,6 @@ int radeon_use_pflipirq = 2;int radeon_bapm =-1 ;int radeon_backlight =-1 ;int radeon_auxch =-1 ; -int radeon_mst =0 ;int radeon_uvd =1 ;int radeon_vce =1 ;
@@ -263,9 +262,6 @@ module_param_named(backlight, radeon_backlight, int, 0444);MODULE_PARM_DESC (auxch,"Use native auxch experimental support (1 = enable, 0 = disable, -1 = auto)" );module_param_named (auxch, radeon_auxch, int,0444 ); -MODULE_PARM_DESC (mst,"DisplayPort MST experimental support (1 = enable, 0 = disable)" ); -module_param_named (mst, radeon_mst, int,0444 ); -MODULE_PARM_DESC (uvd,"uvd enable/disable uvd support (1 = enable, 0 = disable)" );module_param_named (uvd, radeon_uvd, int,0444 );
drivers/gpu/drm/radeon/radeon_encoders.c +1 -13
@@ -244,16 +244,7 @@ radeon_get_connector_for_encoder(struct drm_encoder *encoder)list_for_each_entry (connector, &dev->mode_config.connector_list, head) { radeon_connector =to_radeon_connector (connector); -if (radeon_encoder->is_mst_encoder) { -struct radeon_encoder_mst *mst_enc; - -if (!radeon_connector->is_mst_connector) -continue ; - - mst_enc = radeon_encoder->enc_priv; -if (mst_enc->connector == radeon_connector->mst_port) -return connector; - }else if (radeon_encoder->active_device & radeon_connector->devices) +if (radeon_encoder->active_device & radeon_connector->devices)return connector; }return NULL ;
@@ -399,9 +390,6 @@ bool radeon_dig_monitor_is_duallink(struct drm_encoder *encoder,case DRM_MODE_CONNECTOR_DVID :case DRM_MODE_CONNECTOR_HDMIA :case DRM_MODE_CONNECTOR_DisplayPort: -if (radeon_connector->is_mst_connector) -return false; - dig_connector = radeon_connector->con_priv;if ((dig_connector->dp_sink_type ==CONNECTOR_OBJECT_ID_DISPLAYPORT ) || (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP))
drivers/gpu/drm/radeon/radeon_irq_kms.c +1 -9
@@ -100,16 +100,8 @@ static void radeon_hotplug_work_func(struct work_struct *work)static void radeon_dp_work_func (struct work_struct *work) { - struct radeon_device *rdev = container_of(work, struct radeon_device, - dp_work); -struct drm_device *dev = rdev->ddev; -struct drm_mode_config *mode_config = &dev->mode_config; -struct drm_connector *connector; - -/* this should take a mutex */ -list_for_each_entry (connector, &mode_config->connector_list, head) -radeon_connector_hotplug (connector); } +/** * radeon_driver_irq_preinstall_kms - drm irq preinstall callback *
drivers/gpu/drm/radeon/radeon_mode.h +0 -40
@@ -31,7 +31,6 @@#define RADEON_MODE_H #include <drm/display/drm_dp_helper.h> -#include <drm/display/drm_dp_mst_helper.h> #include <drm/drm_crtc.h> #include <drm/drm_edid.h> #include <drm/drm_encoder.h>
@@ -436,24 +435,12 @@ struct radeon_encoder_atom_dig {int panel_mode;struct radeon_afmt *afmt;struct r600_audio_pin *pin; -int active_mst_links; };struct radeon_encoder_atom_dac {enum radeon_tv_std tv_std; }; -struct radeon_encoder_mst { -int crtc; -struct radeon_encoder *primary; -struct radeon_connector *connector; -struct drm_dp_mst_port *port; -int pbn; -int fe; -bool fe_from_be; -bool enc_active; -}; -struct radeon_encoder {struct drm_encoder base;uint32_t encoder_enum;
@@ -475,8 +462,6 @@ struct radeon_encoder {enum radeon_output_csc output_csc;bool can_mst;uint32_t offset; -bool is_mst_encoder; -/* front end for this mst encoder */ };struct radeon_connector_atom_dig {
@@ -487,7 +472,6 @@ struct radeon_connector_atom_dig {int dp_clock;int dp_lane_count;bool edp_on; -bool is_mst; };struct radeon_gpio_rec {
@@ -531,11 +515,6 @@ enum radeon_connector_dither { RADEON_FMT_DITHER_ENABLE = 1, }; -struct stream_attribs { -uint16_t fe; -uint16_t slots; -}; -struct radeon_connector {struct drm_connector base;uint32_t connector_id;
@@ -558,14 +537,6 @@ struct radeon_connector {enum radeon_connector_audio audio;enum radeon_connector_dither dither;int pixelclock_for_modeset; -bool is_mst_connector; -struct radeon_connector *mst_port; -struct drm_dp_mst_port *port; -struct drm_dp_mst_topology_mgr mst_mgr; - -struct radeon_encoder *mst_encoder; -struct stream_attribs cur_stream_attribs[6 ]; -int enabled_attribs; };#define ENCODER_MODE_IS_DP (em) (((em) == ATOM_ENCODER_MODE_DP) || \
@@ -767,8 +738,6 @@ extern void atombios_dig_transmitter_setup(struct drm_encoder *encoder,extern void atombios_dig_transmitter_setup2 (struct drm_encoder *encoder,int action,uint8_t lane_num,uint8_t lane_set,int fe); -extern void atombios_set_mst_encoder_crtc_source (struct drm_encoder *encoder, -int fe);extern void radeon_atom_ext_encoder_setup_ddc (struct drm_encoder *encoder);extern struct drm_encoder *radeon_get_external_encoder (struct drm_encoder *encoder);void radeon_atom_copy_swap (u8 *dst,u8 *src,u8 num_bytes,bool to_le);
@@ -986,15 +955,6 @@ void radeon_crtc_handle_flip(struct radeon_device *rdev, int crtc_id);int radeon_align_pitch (struct radeon_device *rdev,int width,int bpp,bool tiled); -/* mst */ -int radeon_dp_mst_init (struct radeon_connector *radeon_connector); -int radeon_dp_mst_probe (struct radeon_connector *radeon_connector); -int radeon_dp_mst_check_status (struct radeon_connector *radeon_connector); -void radeon_mst_debugfs_init (struct radeon_device *rdev); -void radeon_dp_mst_prepare_pll (struct drm_crtc *crtc,struct drm_display_mode *mode); - -void radeon_setup_mst_connector (struct drm_device *dev); -int radeon_atom_pick_dig_encoder (struct drm_encoder *encoder,int fe_idx);void radeon_atom_release_dig_encoder (struct radeon_device *rdev,int enc_idx);#endif
Signature · 1 line
2.37.1
Lyude Paul
maintainerRFC v2 18/18 drm/display/dp_mst: Move all payload info into the atomic state
In reply to Lyude PaulNow that we've finally gotten rid of the non-atomic MST users leftover in the kernel, we can finally get rid of all of the legacy payload code we have and move as much as possible into the MST atomic state structs. The main purpose of this is to make the MST code a lot less confusing to work on, as there's a lot of duplicated logic that doesn't really need to be here. As well, this should make introducing features like fallback link retraining and DSC support far easier.
Since the old payload code was pretty gnarly and there's a Lot of changes here, I expect this might be a bit difficult to review. So to make things as easy as possible for reviewers, I'll sum up how both the old and new code worked here (it took me a while to figure this out too!).
The old MST code basically worked by maintaining two different payload tables - proposed_vcpis, and payloads. proposed_vcpis would hold the modified payload we wanted to push to the topology, while payloads held the payload table that was currently programmed in hardware. Modifications to proposed_vcpis would be handled through drm_dp_allocate_vcpi(), drm_dp_mst_deallocate_vcpi(), and drm_dp_mst_reset_vcpi_slots(). Then, they would be pushed via drm_dp_mst_update_payload_step1() and drm_dp_mst_update_payload_step2().
Furthermore, it's important to note how adding and removing VC payloads actually worked with drm_dp_mst_update_payload_step1(). When a VC payload is removed from the VC table, all VC payloads which come after the removed VC payload's slots must have their time slots shifted towards the start of the table. The old code handles this by looping through the entire payload table and recomputing the start slot for every payload in the topology from scratch. While very much overkill, this ends up doing the right thing because we always order the VCPIs for payloads from first to last starting timeslot.
It's important to also note that drm_dp_mst_update_payload_step2() isn't actually limited to updating a single payload - the driver can use it to queue up multiple payload changes so that as many of them can be sent as possible before waiting for the ACT. This is -technically- not against spec, but as Wayne Lin has pointed out it's not consistently implemented correctly in hubs - so it might as well be.
drm_dp_mst_update_payload_step2() is pretty self explanatory and basically the same between the old and new code, save for the fact we don't have a second step for deleting payloads anymore -and thus rename it to drm_dp_mst_add_payload_step2().
The new payload code stores all of the current payload info within the MST atomic state and computes as much of the state as possible ahead of time. This has the one exception of the starting timeslots for payloads, which can't be determined at atomic check time since the starting time slots will vary depending on what order CRTCs are enabled in the atomic state - which varies from driver to driver. These are still stored in the atomic MST state, but are only copied from the old MST state during atomic commit time. Likewise, this is when new start slots are determined.
Adding/removing payloads now works much more closely to how things are described in the spec. When we delete a payload, we loop through the current list of payloads and update the start slots for any payloads whose time slots came after the payload we just deleted. Determining the starting time slots for new payloads being added is done by simply keeping track of where the end of the VC table is in drm_dp_mst_topology_mgr->next_start_slot. Additionally, it's worth noting that we no longer have a single update_payload() function. Instead, we now have drm_dp_mst_add_payload_step1|2() and drm_dp_mst_remove_payload(). As such, it's now left it up to the driver to figure out when to add or remove payloads. The driver already knows when it's disabling/enabling CRTCs, so it also already knows when payloads should be added or removed.
Changes since v1:
* Refactor around all of the completely dead code changes that are happening in amdgpu for some reason when they really shouldn't even be there in the first place… :\
* Remove mention of sending one ACT per series of payload updates. As Wayne Lin pointed out, there are apparently hubs on the market that don't work correctly with this scheme and require a separate ACT per payload update.
* Fix accidental drop of mst_mgr.lock - Wayne Lin
* Remove mentions of allowing multiple ACT updates per payload change, mention that this is a result of vendors not consistently supporting this part of the spec and requiring a unique ACT for each payload change.
* Get rid of reference to drm_dp_mst_port in DC - turns out I just got myself confused by DC and we don't actually need this.
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 56 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 104 +-- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 84 +-- .../amd/display/include/link_service_types.h | 3 + drivers/gpu/drm/display/drm_dp_mst_topology.c | 693 ++++++------------ drivers/gpu/drm/i915/display/intel_dp_mst.c | 64 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 24 +- drivers/gpu/drm/nouveau/dispnv50/disp.c | 163 ++-- include/drm/display/drm_dp_mst_helper.h | 177 ++--- 9 files changed, 519 insertions(+), 849 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +14 -42
@@ -6412,6 +6412,7 @@ static int dm_encoder_helper_atomic_check(struct drm_encoder *encoder,const struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode;struct drm_dp_mst_topology_mgr *mst_mgr;struct drm_dp_mst_port *mst_port; +struct drm_dp_mst_topology_state *mst_state;enum dc_color_depth color_depth;int clock, bpp =0 ;bool is_y420 = false;
@@ -6425,6 +6426,13 @@ static int dm_encoder_helper_atomic_check(struct drm_encoder *encoder,if (!crtc_state->connectors_changed && !crtc_state->mode_changed)return 0 ; + mst_state =drm_atomic_get_mst_topology_state (state, mst_mgr); +if (IS_ERR (mst_state)) +return PTR_ERR (mst_state); + +if (!mst_state->pbn_div) + mst_state->pbn_div =dm_mst_get_pbn_divider (aconnector->mst_port->dc_link); +if (!state->duplicated) {int max_bpc = conn_state->max_requested_bpc; is_y420 = drm_mode_is_420_also(&connector->display_info, adjusted_mode) &&
@@ -6436,11 +6444,10 @@ static int dm_encoder_helper_atomic_check(struct drm_encoder *encoder, clock = adjusted_mode->clock; dm_new_connector_state->pbn =drm_dp_calc_pbn_mode (clock, bpp, false); } - dm_new_connector_state->vcpi_slots =drm_dp_atomic_find_time_slots (state, - mst_mgr, - mst_port, - dm_new_connector_state->pbn, -dm_mst_get_pbn_divider (aconnector->dc_link)); + + dm_new_connector_state->vcpi_slots = +drm_dp_atomic_find_time_slots (state, mst_mgr, mst_port, + dm_new_connector_state->pbn);if (dm_new_connector_state->vcpi_slots <0 ) {DRM_DEBUG_ATOMIC ("failed finding vcpi slots: %d\n" , (int )dm_new_connector_state->vcpi_slots);return dm_new_connector_state->vcpi_slots;
@@ -6510,18 +6517,12 @@ static int dm_update_mst_vcpi_slots_for_dsc(struct drm_atomic_state *state, dm_conn_state->pbn = pbn; dm_conn_state->vcpi_slots = slot_num; -drm_dp_mst_atomic_enable_dsc (state, - aconnector->port, - dm_conn_state->pbn, -0 , +drm_dp_mst_atomic_enable_dsc (state, aconnector->port, dm_conn_state->pbn, false);continue ; } - vcpi =drm_dp_mst_atomic_enable_dsc (state, - aconnector->port, - pbn, pbn_div, - true); + vcpi =drm_dp_mst_atomic_enable_dsc (state, aconnector->port, pbn, true);if (vcpi <0 )return vcpi;
@@ -9363,8 +9364,6 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,struct dm_crtc_state *dm_old_crtc_state, *dm_new_crtc_state;#if defined(CONFIG_DRM_AMD_DC_DCN )struct dsc_mst_fairness_vars vars[MAX_PIPES ]; -struct drm_dp_mst_topology_state *mst_state; -struct drm_dp_mst_topology_mgr *mgr;#endif trace_amdgpu_dm_atomic_check_begin (state);
@@ -9603,33 +9602,6 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev, lock_and_validation_needed = true; } -#if defined(CONFIG_DRM_AMD_DC_DCN ) -/* set the slot info for each mst_state based on the link encoding format */ -for_each_new_mst_mgr_in_state (state, mgr, mst_state, i) { -struct amdgpu_dm_connector *aconnector; -struct drm_connector *connector; -struct drm_connector_list_iter iter; -u8 link_coding_cap; - -if (!mgr->mst_state ) -continue ; - -drm_connector_list_iter_begin (dev, &iter); -drm_for_each_connector_iter (connector, &iter) { -int id = connector->index; - -if (id == mst_state->mgr->conn_base_id) { - aconnector =to_amdgpu_dm_connector (connector); - link_coding_cap =dc_link_dp_mst_decide_link_encoding_format (aconnector->dc_link); -drm_dp_mst_update_slots (mst_state, link_coding_cap); - -break ; - } - } -drm_connector_list_iter_end (&iter); - - } -#endif /** * Streams and planes are reset when there are changes that affect * bandwidth. Anything that affects bandwidth needs to go through
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +33 -71
166 lines not on this page · raw message
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +35 -49
199 lines not on this page · raw message
drivers/gpu/drm/amd/display/include/link_service_types.h +3 -0
@@ -251,6 +251,9 @@ union dpcd_training_lane_set {* _ONLY_ be filled out from DM and then passed to DC, do NOT use these for _any_ kind of atomic * state calculations in DM, or you will break something. */ + +struct drm_dp_mst_port ; +/* DP MST stream allocation (payload bandwidth number) */ struct dc_dp_mst_stream_allocation {uint8_t vcp_id;
drivers/gpu/drm/display/drm_dp_mst_topology.c +220 -473
1,015 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dp_mst.c +30 -34
150 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_hdcp.c +23 -1
@@ -30,8 +30,30 @@static int intel_conn_to_vcpi (struct intel_connector *connector) { +struct drm_dp_mst_topology_mgr *mgr; +struct drm_dp_mst_atomic_payload *payload; +struct drm_dp_mst_topology_state *mst_state; +int vcpi =0 ; +/* For HDMI this is forced to be 0x0. For DP SST also this is 0x0. */ -return connector->port ? connector->port->vcpi.vcpi :0 ; +if (!connector->port) +return 0 ; + mgr = connector->port->mgr; + +drm_modeset_lock (&mgr->base.lock,NULL ); + mst_state =to_drm_dp_mst_topology_state (mgr->base.state); + payload =drm_atomic_get_mst_payload_state (mst_state, connector->port); +if (drm_WARN_ON (mgr->dev, !payload)) + goto out; + + vcpi = payload->vcpi; +if (drm_WARN_ON (mgr->dev, vcpi <0 )) { + vcpi =0 ; + goto out; + } +out: +drm_modeset_unlock (&mgr->base.lock); +return vcpi; }/*
drivers/gpu/drm/nouveau/dispnv50/disp.c +81 -82
295 lines not on this page · raw message
include/drm/display/drm_dp_mst_helper.h +80 -97
272 lines not on this page · raw message
Signature · 1 line
2.37.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only
URL : https://patchwork.freedesktop.org/series/107073/
State : warning
== Summary ==
Error: dim checkpatch failed1edd44d8fda1 drm/amdgpu/dc/mst: Rename dp_mst_stream_allocation(_table)0dc527949f22 drm/amdgpu/dm/mst: Rename get_payload_table()f1bacadf3e76 drm/display/dp_mst: Rename drm_dp_mst_vcpi_allocation2ecdbe11bc3e drm/display/dp_mst: Call them time slots, not VCPI slots3316d1b378c1 drm/display/dp_mst: Fix confusing docs for drm_dp_atomic_release_time_slots() 16f2c9ea3e8e drm/display/dp_mst: Add some missing kdocs for atomic MST structs38425abd1273 drm/display/dp_mst: Add helper for finding payloads in atomic MST state 691008feb57c drm/display/dp_mst: Add nonblocking helpers for DP MSTb4e4b9170780 drm/display/dp_mst: Don't open code modeset checks for releasing time slots ccfdf2d4da8d drm/display/dp_mst: Fix modeset tracking in drm_dp_atomic_release_vcpi_slots() 0ef70825a260 drm/nouveau/kms: Cache DP encoders in nouveau_connector84f6326888b8 drm/nouveau/kms: Pull mst state in for all modesets2947158dda3e drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions a96b55fd2dfc drm/display/dp_mst: Drop all ports from topology on CSNs before queueing link address work 190816415106 drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected -:16: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #16:
commit 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by ports in stale topology")
total: 0 errors, 1 warnings, 0 checks, 111 lines checked854fb3e71cfb drm/display/dp_mst: Maintain time slot allocations when deleting payloads c1758ae54e11 drm/radeon: Drop legacy MST support
-:299: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #299:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 checks, 346 lines checked 71b255266310 drm/display/dp_mst: Move all payload info into the atomic state -:790: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #790: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:3294:
{
+
-:1453: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf #1453: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:4753:
+ seq_printf(m, "\n*** Atomic state info ***\n");
-:1458: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf #1458: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:4757:
+ seq_printf(m, "\n| idx | port | vcpi | slots | pbn | dsc | sink name |\n");
-:1789: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #1789: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:511:
+ drm_atomic_get_mst_payload_state(mst_state, connector->port));
-:2128: WARNING:LINE_SPACING: Missing a blank line after declarations #2128: FILE: drivers/gpu/drm/nouveau/dispnv50/disp.c:1401:
+ struct nv50_mstc *mstc = msto->mstc;
+ if (mstc && mstc->mstm == mstm && !msto->disabled)
total: 0 errors, 4 warnings, 1 checks, 2233 lines checked
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only
URL : https://patchwork.freedesktop.org/series/107073/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11975 -> Patchwork_107073v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_107073v1 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_107073v1, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/index.html
Participating hosts (42 -> 37)
------------------------------
Missing (5): fi-kbl-soraka bat-dg2-9 bat-adlp-4 bat-jsl-3 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107073v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@load:
- fi-skl-6700k2: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11975/fi-skl-6700k2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/fi-skl-6700k2/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@fbdev@eof:
- {bat-rpls-2}: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11975/bat-rpls-2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/bat-rpls-2/igt@[email protected]
* igt@runner@aborted:
- {bat-rpls-2}: [FAIL][5] ([i915#4312]) -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11975/bat-rpls-2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/bat-rpls-2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_107073v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][7] -> [INCOMPLETE][8] ([i915#4785])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11975/fi-hsw-4770/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/fi-hsw-4770/igt@i915_selftest@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [PASS][9] -> [INCOMPLETE][10] ([i915#146])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11975/fi-bdw-5557u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/fi-bdw-5557u/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-blb-e6850: NOTRUN -> [SKIP][11] ([fdo#109271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/fi-blb-e6850/igt@[email protected]
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][12] ([fdo#109271] / [i915#4312] / [i915#5594] / [i915#6246])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/fi-hsw-4770/igt@[email protected]
- fi-skl-6700k2: NOTRUN -> [FAIL][13] ([i915#4312])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/fi-skl-6700k2/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gem:
- fi-blb-e6850: [DMESG-FAIL][14] ([i915#4528]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11975/fi-blb-e6850/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/fi-blb-e6850/igt@i915_selftest@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][16] ([i915#6298]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11975/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828
[i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
[i915#6246]: https://gitlab.freedesktop.org/drm/intel/issues/6246
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
Build changes
-------------
* Linux: CI_DRM_11975 -> Patchwork_107073v1
CI-20190529: 20190529
CI_DRM_11975: 5b5ad12f8d971a9feeb54a3f3d58b48de8978ad2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6617: 22fa5ae83a8854f32e28b2c2a8581f4e36f78288 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107073v1: 5b5ad12f8d971a9feeb54a3f3d58b48de8978ad2 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
81c4d57cd2b5 drm/display/dp_mst: Move all payload info into the atomic state 443660a8f2bc drm/radeon: Drop legacy MST support7caab8710200 drm/display/dp_mst: Maintain time slot allocations when deleting payloads 7b505ed2f9f7 drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected 841abedcedaa drm/display/dp_mst: Drop all ports from topology on CSNs before queueing link address work 0f74b7ad3487 drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions 4adf749247ad drm/nouveau/kms: Pull mst state in for all modesets45b6adfadad5 drm/nouveau/kms: Cache DP encoders in nouveau_connectorca10ef490a51 drm/display/dp_mst: Fix modeset tracking in drm_dp_atomic_release_vcpi_slots() 814cda0ad96f drm/display/dp_mst: Don't open code modeset checks for releasing time slots 0e18729a7280 drm/display/dp_mst: Add nonblocking helpers for DP MST1b969a7b14cd drm/display/dp_mst: Add helper for finding payloads in atomic MST state 3a0f00538f04 drm/display/dp_mst: Add some missing kdocs for atomic MST structs 969b79b56ecd drm/display/dp_mst: Fix confusing docs for drm_dp_atomic_release_time_slots() b0c5e202c311 drm/display/dp_mst: Call them time slots, not VCPI slots147dafdff211 drm/display/dp_mst: Rename drm_dp_mst_vcpi_allocationa90076fe7b2a drm/amdgpu/dm/mst: Rename get_payload_table()62fd63119a27 drm/amdgpu/dc/mst: Rename dp_mst_stream_allocation(_table)
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v1/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev2)
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev2)
URL : https://patchwork.freedesktop.org/series/107073/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11977 -> Patchwork_107073v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/index.html
Participating hosts (42 -> 37)
------------------------------
Missing (5): fi-hsw-4200u bat-dg2-9 fi-ctg-p8600 bat-jsl-3 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107073v2:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@debugfs_test@read_all_entries:
- {bat-rpls-2}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/bat-rpls-2/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/bat-rpls-2/igt@debugfs_test@read_all_entries.html
Known issues
------------
Here are the changes found in Patchwork_107073v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][3] -> [INCOMPLETE][4] ([i915#3921])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/fi-snb-2600/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/fi-snb-2600/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][5] -> [DMESG-FAIL][6] ([i915#4528])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/fi-blb-e6850/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/fi-blb-e6850/igt@i915_selftest@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-bdw-5557u: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/fi-bdw-5557u/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- {bat-adlm-1}: [DMESG-WARN][8] ([i915#2867]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/bat-adlm-1/igt@gem_exec_suspend@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/bat-adlm-1/igt@gem_exec_suspend@[email protected]
#### Warnings ####
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [DMESG-FAIL][10] ([i915#4494] / [i915#4957]) -> [DMESG-FAIL][11] ([i915#4957])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/bat-dg1-5/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/bat-dg1-5/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
Build changes
-------------
* Linux: CI_DRM_11977 -> Patchwork_107073v2
CI-20190529: 20190529
CI_DRM_11977: 71776a3cc166e6400e713acdd2b03094120e1baa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6619: ec2ab8e3a151ce05bd2726319c528c2ab99e8a96 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107073v2: 71776a3cc166e6400e713acdd2b03094120e1baa @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
36278c461712 drm/display/dp_mst: Move all payload info into the atomic state bc63574e60fa drm/radeon: Drop legacy MST supportd6febec6c602 drm/display/dp_mst: Maintain time slot allocations when deleting payloads bf2bdda736b0 drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected bb0243f1a496 drm/display/dp_mst: Drop all ports from topology on CSNs before queueing link address work 55d383c46eef drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions 79354823c545 drm/nouveau/kms: Pull mst state in for all modesets6e79bd460773 drm/nouveau/kms: Cache DP encoders in nouveau_connector088373c522b0 drm/display/dp_mst: Fix modeset tracking in drm_dp_atomic_release_vcpi_slots() 04abdc6435ef drm/display/dp_mst: Don't open code modeset checks for releasing time slots 0dbb1df1c648 drm/display/dp_mst: Add nonblocking helpers for DP MST76f3f8878254 drm/display/dp_mst: Add helper for finding payloads in atomic MST state 392e8f9645e9 drm/display/dp_mst: Add some missing kdocs for atomic MST structs 9d929d819574 drm/display/dp_mst: Fix confusing docs for drm_dp_atomic_release_time_slots() bb4bce13609a drm/display/dp_mst: Call them time slots, not VCPI slots3e36f6eb4da0 drm/display/dp_mst: Rename drm_dp_mst_vcpi_allocation52cc4993511a drm/amdgpu/dm/mst: Rename get_payload_table()83534dafea6f drm/amdgpu/dc/mst: Rename dp_mst_stream_allocation(_table)
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev2)
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev2)
URL : https://patchwork.freedesktop.org/series/107073/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11977_full -> Patchwork_107073v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_107073v2_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_107073v2_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107073v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
- shard-apl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl1/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_cursor_crc@cursor-onscreen@pipe-a-hdmi-a-4-64x21:
- {shard-dg1}: NOTRUN -> [CRASH][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-dg1-15/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_crc@cursor-onscreen@pipe-d-hdmi-a-4-64x21:
- {shard-dg1}: NOTRUN -> [FAIL][4] +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-dg1-15/igt@kms_cursor_crc@[email protected]
Known issues
------------
Here are the changes found in Patchwork_107073v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-contexts:
- shard-skl: NOTRUN -> [SKIP][5] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl6/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][6] -> [SKIP][7] ([i915#4525]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb6/igt@[email protected]
* igt@gem_exec_endless@dispatch@bcs0:
- shard-tglb: [PASS][8] -> [INCOMPLETE][9] ([i915#3778])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-tglb7/igt@gem_exec_endless@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-tglb3/igt@gem_exec_endless@[email protected]
* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [PASS][10] -> [FAIL][11] ([i915#2842]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl4/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-apl: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl4/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl8/igt@gem_exec_fair@[email protected]
- shard-tglb: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-tglb2/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-tglb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][16] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [PASS][17] -> [FAIL][18] ([i915#2842]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb7/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-wc-gtt-active:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#62]) +81 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl8/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl1/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl7/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-kbl4/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-apl: NOTRUN -> [DMESG-WARN][23] ([i915#5566] / [i915#716])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl6/igt@[email protected]
- shard-glk: [PASS][24] -> [DMESG-WARN][25] ([i915#5566] / [i915#716])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-glk8/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-glk6/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl6/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271]) +24 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-kbl7/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-crc-fast:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl6/igt@[email protected]
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-kbl7/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][31] -> [FAIL][32] ([i915#72])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-glk6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-glk8/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][33] -> [FAIL][34] ([i915#79]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl10/igt@kms_flip@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-edp1:
- shard-skl: [PASS][35] -> [INCOMPLETE][36] ([i915#4939])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl9/igt@kms_flip@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-skl: [PASS][37] -> [INCOMPLETE][38] ([i915#4839] / [i915#4939])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl10/igt@kms_flip@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#2122])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl7/igt@kms_flip@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl1/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][41] ([i915#2672]) +4 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][42] ([i915#2672] / [i915#3555]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode.html
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-kbl: [PASS][43] -> [FAIL][44] ([i915#1188]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl4/igt@kms_hdr@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-kbl7/igt@kms_hdr@[email protected]
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-apl: [PASS][45] -> [DMESG-WARN][46] ([i915#180]) +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl1/igt@kms_hdr@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl4/igt@kms_hdr@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][47] -> [FAIL][48] ([fdo#108145] / [i915#265])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl9/igt@[email protected]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-4:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271]) +18 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-kbl7/igt@[email protected]
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-a-dp-1:
- shard-apl: [PASS][50] -> [SKIP][51] ([fdo#109271]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl8/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-a-dp-1.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl1/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-a-dp-1.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [PASS][52] -> [SKIP][53] ([fdo#109441]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb3/igt@kms_psr@psr2_primary_blt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [PASS][54] -> [SKIP][55] ([i915#5519])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb5/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb4/igt@[email protected]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-b:
- shard-apl: [PASS][56] -> [DMESG-WARN][57] ([i915#1982] / [i915#62]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl8/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl1/igt@[email protected]
* igt@perf@blocking:
- shard-skl: [PASS][58] -> [FAIL][59] ([i915#1542])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl1/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl1/igt@[email protected]
* igt@sysfs_heartbeat_interval@mixed@vcs0:
- shard-skl: [PASS][60] -> [FAIL][61] ([i915#1731])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl9/igt@sysfs_heartbeat_interval@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl6/igt@sysfs_heartbeat_interval@[email protected]
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [FAIL][62] ([i915#6268]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-tglb5/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-tglb7/igt@[email protected]
- {shard-rkl}: [FAIL][64] ([i915#6268]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-1/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-5/igt@[email protected]
* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][66] ([i915#4525]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb8/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][68] ([i915#2846]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl1/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-kbl1/igt@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][70] ([i915#2842]) -> [PASS][71] +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl4/igt@gem_exec_fair@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][72] ([i915#2842]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-tglu-1/igt@gem_exec_fair@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-tglu-4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][74] ([i915#2842]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-glk2/igt@gem_exec_fair@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fence@basic-busy@bcs0:
- {shard-rkl}: [SKIP][76] ([i915#6251]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@gem_exec_fence@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-1/igt@gem_exec_fence@[email protected]
* igt@gem_exec_reloc@basic-cpu-gtt-noreloc:
- {shard-rkl}: [SKIP][78] ([i915#3281]) -> [PASS][79] +7 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-2/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-5/igt@[email protected]
* igt@gem_madvise@dontneed-before-pwrite:
- {shard-rkl}: [SKIP][80] ([i915#3282]) -> [PASS][81] +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-6/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-5/igt@[email protected]
* igt@gem_ppgtt@blt-vs-render-ctx0:
- {shard-rkl}: [INCOMPLETE][82] ([i915#3692]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-5/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [INCOMPLETE][84] -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl4/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-kbl7/igt@[email protected]
* igt@gen9_exec_parse@bb-start-param:
- {shard-rkl}: [SKIP][86] ([i915#2527]) -> [PASS][87] +2 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-2/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-5/igt@[email protected]
* igt@i915_hangman@engine-engine-error@bcs0:
- {shard-rkl}: [SKIP][88] ([i915#6258]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@i915_hangman@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-1/igt@i915_hangman@[email protected]
* igt@i915_pm_dc@dc5-psr:
- {shard-rkl}: [SKIP][90] ([i915#658]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-1/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@i2c:
- {shard-rkl}: [SKIP][92] ([fdo#109308]) -> [PASS][93] +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-1/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rps@basic-api:
- {shard-dg1}: [FAIL][94] ([i915#4032]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-dg1-18/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-dg1-18/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1:
- shard-skl: [FAIL][96] ([i915#2521]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl9/igt@kms_async_flips@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl7/igt@kms_async_flips@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1:
- shard-apl: [DMESG-WARN][98] ([i915#180]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl2/igt@kms_cursor_crc@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl6/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [FAIL][100] ([i915#2346]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-glk7/igt@kms_cursor_legacy@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-glk1/igt@kms_cursor_legacy@[email protected]
- shard-iclb: [FAIL][102] ([i915#2346]) -> [PASS][103] +2 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb7/igt@kms_cursor_legacy@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb1/igt@kms_cursor_legacy@[email protected]
* igt@kms_dp_aux_dev:
- {shard-rkl}: [SKIP][104] ([i915#1257]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@kms_dp_aux_dev.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-6/igt@kms_dp_aux_dev.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled:
- {shard-rkl}: [SKIP][106] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][107] +5 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-1/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-6/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [FAIL][108] ([i915#79]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl10/igt@kms_flip@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: [DMESG-WARN][110] ([i915#180]) -> [PASS][111] +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl1/igt@kms_flip@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-kbl7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@a-edp1:
- shard-skl: [FAIL][112] ([i915#2122]) -> [PASS][113] +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl1/igt@kms_flip@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl10/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][114] ([i915#3555]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu:
- {shard-dg1}: [FAIL][116] -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-dg1-19/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-dg1-15/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- {shard-rkl}: [SKIP][118] ([i915#1849] / [i915#4098]) -> [PASS][119] +11 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-skl: [DMESG-WARN][120] ([i915#1982]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl1/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl10/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- {shard-rkl}: [SKIP][122] ([i915#1849] / [i915#3558]) -> [PASS][123] +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@kms_plane@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant:
- {shard-rkl}: [SKIP][124] ([i915#1849] / [i915#3546] / [i915#4098]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-6/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- {shard-rkl}: [SKIP][126] ([i915#1849] / [i915#3546] / [i915#4070] / [i915#4098]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-1/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-6/igt@[email protected]
- shard-skl: [FAIL][128] ([fdo#108145] / [i915#265]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl1/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl9/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [SKIP][130] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb8/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][132] ([fdo#109441]) -> [PASS][133] +2 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb8/igt@kms_psr@psr2_cursor_plane_move.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_psr@sprite_mmap_gtt:
- {shard-rkl}: [SKIP][134] ([i915#1072]) -> [PASS][135] +1 similar issue
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@kms_psr@sprite_mmap_gtt.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-6/igt@kms_psr@sprite_mmap_gtt.html
* igt@kms_vblank@pipe-b-query-idle:
- {shard-rkl}: [SKIP][136] ([i915#1845] / [i915#4098]) -> [PASS][137] +15 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-1/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-rkl-6/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][138] ([i915#5639]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl7/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl1/igt@[email protected]
#### Warnings ####
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][140] ([i915#2842]) -> [FAIL][141] ([i915#2852])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb1/igt@gem_exec_fair@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][142] ([i915#2842]) -> [SKIP][143] ([fdo#109271])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl7/igt@gem_exec_fair@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@kms_content_protection@srm:
- shard-apl: [TIMEOUT][144] ([i915#1319]) -> [SKIP][145] ([fdo#109271]) +1 similar issue
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl8/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc:
- shard-skl: [SKIP][146] ([fdo#109271] / [i915#1888]) -> [SKIP][147] ([fdo#109271]) +2 similar issues
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl7/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-apl: [FAIL][148] ([i915#265]) -> [DMESG-FAIL][149] ([i915#62])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl8/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: [FAIL][150] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][151] ([fdo#108145] / [i915#62])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl8/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl1/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-iclb: [SKIP][152] ([i915#658]) -> [SKIP][153] ([i915#2920])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb1/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb2/igt@[email protected]
- shard-skl: [SKIP][154] ([fdo#109271] / [i915#1888] / [i915#658]) -> [SKIP][155] ([fdo#109271] / [i915#658])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl1/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl1/igt@[email protected]
* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [FAIL][156] ([i915#5939]) -> [SKIP][157] ([fdo#109642] / [fdo#111068] / [i915#658])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-iclb6/igt@kms_psr2_su@page_flip-nv12.html
* igt@runner@aborted:
- shard-apl: ([FAIL][158], [FAIL][159], [FAIL][160], [FAIL][161], [FAIL][162]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][163], [FAIL][164], [FAIL][165], [FAIL][166], [FAIL][167], [FAIL][168], [FAIL][169]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl8/igt@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl6/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl2/igt@[email protected]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl7/igt@[email protected]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl2/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl2/igt@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl6/igt@[email protected]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl8/igt@[email protected]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl8/igt@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl4/igt@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl3/igt@[email protected]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-apl6/igt@[email protected]
* igt@sysfs_clients@busy:
- shard-skl: [SKIP][170] ([fdo#109271] / [i915#1888] / [i915#2994]) -> [SKIP][171] ([fdo#109271] / [i915#2994])
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl4/igt@[email protected]
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/shard-skl9/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3692]: https://gitlab.freedesktop.org/drm/intel/issues/3692
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016
[i915#4032]: https://gitlab.freedesktop.org/drm/intel/issues/4032
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4941]: https://gitlab.freedesktop.org/drm/intel/issues/4941
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_11977 -> Patchwork_107073v2
CI-20190529: 20190529
CI_DRM_11977: 71776a3cc166e6400e713acdd2b03094120e1baa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6619: ec2ab8e3a151ce05bd2726319c528c2ab99e8a96 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107073v2: 71776a3cc166e6400e713acdd2b03094120e1baa @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v2/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev3)
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev3)
URL : https://patchwork.freedesktop.org/series/107073/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11981 -> Patchwork_107073v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/index.html
Participating hosts (42 -> 28)
------------------------------
Missing (14): fi-kbl-soraka bat-dg1-6 bat-dg1-5 fi-hsw-4200u bat-dg2-8 bat-adlm-1 bat-dg2-9 bat-adlp-6 bat-adlp-4 fi-ctg-p8600 bat-jsl-3 bat-rplp-1 bat-rpls-1 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_107073v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gem:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][1] ([i915#4528])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/fi-pnv-d510/igt@i915_selftest@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [PASS][2] -> [INCOMPLETE][3] ([i915#146])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/fi-bdw-5557u/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/fi-bdw-5557u/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- {fi-ehl-2}: [DMESG-FAIL][4] ([i915#5334]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/fi-ehl-2/igt@i915_selftest@live@gt_heartbeat.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/fi-ehl-2/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][6] ([i915#4528]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/fi-pnv-d510/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/fi-pnv-d510/igt@i915_selftest@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][8] ([i915#6298]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
Build changes
-------------
* Linux: CI_DRM_11981 -> Patchwork_107073v3
CI-20190529: 20190529
CI_DRM_11981: 6f207fdd93a13166b4adfe2f3a2972a9c632e757 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6619: ec2ab8e3a151ce05bd2726319c528c2ab99e8a96 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107073v3: 6f207fdd93a13166b4adfe2f3a2972a9c632e757 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
9310c663430f drm/display/dp_mst: Move all payload info into the atomic state 8e7e26d72dc2 drm/radeon: Drop legacy MST supportd82cdc1ecb46 drm/display/dp_mst: Maintain time slot allocations when deleting payloads 50aedded245e drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected d7dfd325cf08 drm/display/dp_mst: Drop all ports from topology on CSNs before queueing link address work 243ab1025c79 drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions a150e19f23b2 drm/nouveau/kms: Pull mst state in for all modesets30d55742e722 drm/nouveau/kms: Cache DP encoders in nouveau_connectorb3ba7f27e7d6 drm/display/dp_mst: Fix modeset tracking in drm_dp_atomic_release_vcpi_slots() 4f2b27dce718 drm/display/dp_mst: Don't open code modeset checks for releasing time slots 054350d3417a drm/display/dp_mst: Add nonblocking helpers for DP MSTf9c51036ef86 drm/display/dp_mst: Add helper for finding payloads in atomic MST state 93cac2df77db drm/display/dp_mst: Add some missing kdocs for atomic MST structs 9f4d2d50cb78 drm/display/dp_mst: Fix confusing docs for drm_dp_atomic_release_time_slots() 381e9b3c424b drm/display/dp_mst: Call them time slots, not VCPI slots0871c9b75f49 drm/display/dp_mst: Rename drm_dp_mst_vcpi_allocation
353115345666 drm/amdgpu/dm/mst: Rename get_payload_table()12ff7e585006 drm/amdgpu/dc/mst: Rename dp_mst_stream_allocation(_table)
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev3)
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev3)
URL : https://patchwork.freedesktop.org/series/107073/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11981_full -> Patchwork_107073v3_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_107073v3_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-apl: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [FAIL][50]) ([i915#4386])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl8/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl8/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl8/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl8/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl7/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl6/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl4/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl4/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl4/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl4/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl3/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl3/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl3/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl2/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl2/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl2/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl1/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl1/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl1/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl8/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl8/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl7/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl7/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl7/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl6/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl6/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl6/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl4/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl4/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl3/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl3/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl3/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl3/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl3/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl2/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl2/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl2/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/boot.html
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@busy-idle@rcs0:
- shard-iclb: [PASS][51] -> [DMESG-WARN][52] ([i915#4391])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb3/igt@drm_fdinfo@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb7/igt@drm_fdinfo@[email protected]
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][53] -> [SKIP][54] ([i915#658])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb6/igt@[email protected]
* igt@gem_exec_balancer@parallel-contexts:
- shard-skl: NOTRUN -> [SKIP][55] ([fdo#109271]) +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl9/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][56] -> [FAIL][57] ([i915#2842])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-tglb3/igt@gem_exec_fair@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][58] -> [FAIL][59] ([i915#2842]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@gem_exec_fair@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][60] -> [FAIL][61] ([i915#2849])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb8/igt@gem_exec_fair@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb8/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-kbl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2190])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl7/igt@[email protected]
- shard-tglb: [PASS][63] -> [SKIP][64] ([i915#2190])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-tglb3/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-tglb7/igt@[email protected]
* igt@gem_lmem_swapping@parallel-multi:
- shard-kbl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#4613]) +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl4/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-apl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#4613]) +2 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/igt@[email protected]
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271]) +138 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#3323])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl4/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-kbl: NOTRUN -> [DMESG-WARN][69] ([i915#4991])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][70] ([i915#4991])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][71] ([i915#454])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl7/igt@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][72] -> [DMESG-WARN][73] ([i915#180]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl6/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl3/igt@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: NOTRUN -> [DMESG-WARN][74] ([i915#180])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl4/igt@[email protected]
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#3886]) +7 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl4/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_ccs:
- shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271]) +182 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl7/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#3886]) +6 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl4/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-kbl: NOTRUN -> [SKIP][78] ([fdo#109271] / [fdo#111827]) +7 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-storm:
- shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [fdo#111827]) +6 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][80] -> [FAIL][81] ([i915#72])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-glk7/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-glk8/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][82] -> [FAIL][83] ([i915#2346])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-glk6/igt@kms_cursor_legacy@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-glk2/igt@kms_cursor_legacy@[email protected]
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][84] ([fdo#109271])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-glk5/igt@kms_dither@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][85] ([i915#180]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: [PASS][86] -> [FAIL][87] ([i915#2122]) +2 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-skl4/igt@kms_flip@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][88] ([i915#2672]) +8 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][89] ([i915#3555]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-kbl: [PASS][90] -> [DMESG-WARN][91] ([i915#180]) +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@kms_plane@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl7/igt@kms_plane@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][92] ([fdo#108145] / [i915#265]) +3 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][93] ([fdo#108145] / [i915#265])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][94] ([i915#265])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl4/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#658]) +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl2/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-kbl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#658]) +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][97] -> [SKIP][98] ([fdo#109441]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb6/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [PASS][99] -> [SKIP][100] ([i915#5519])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb5/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb8/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-snb: [PASS][101] -> [DMESG-WARN][102] ([i915#5090])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-snb5/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-snb5/igt@[email protected]
* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#533])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl4/igt@[email protected]
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#2437])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl2/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-apl: [PASS][105] -> [FAIL][106] ([i915#5639])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl8/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/igt@[email protected]
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#2994]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl2/igt@[email protected]
* igt@sysfs_clients@sema-10:
- shard-kbl: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#2994]) +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@in-flight-contexts-1us:
- shard-apl: [TIMEOUT][109] ([i915#3063]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl1/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/igt@[email protected]
* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][111] ([i915#4525]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb6/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb1/igt@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][113] ([i915#2842]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl6/igt@gem_exec_fair@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [FAIL][115] ([i915#2842]) -> [PASS][116] +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-glk6/igt@gem_exec_fair@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][117] ([i915#2842]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@gem_exec_fair@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [INCOMPLETE][119] ([i915#5129]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl4/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl7/igt@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-kbl: [DMESG-WARN][121] ([i915#180]) -> [PASS][122] +8 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl7/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1:
- shard-glk: [FAIL][123] ([i915#2521]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-glk3/igt@kms_async_flips@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-glk3/igt@kms_async_flips@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip@varying-size:
- shard-iclb: [FAIL][125] ([i915#5072]) -> [PASS][126] +1 similar issue
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb7/igt@kms_cursor_legacy@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb4/igt@kms_cursor_legacy@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][127] ([i915#2346]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-glk6/igt@kms_cursor_legacy@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-glk2/igt@kms_cursor_legacy@[email protected]
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [FAIL][129] ([i915#4767]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-skl7/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl10/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][131] ([i915#79]) -> [PASS][132] +2 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-skl4/igt@kms_flip@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
- shard-glk: [FAIL][133] ([i915#79]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-glk3/igt@kms_flip@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [FAIL][135] ([i915#2122]) -> [PASS][136] +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-skl1/igt@kms_flip@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
- shard-skl: [DMESG-WARN][137] ([i915#1982]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl10/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_hdr@bpc-switch@pipe-a-dp-1:
- shard-kbl: [FAIL][139] ([i915#1188]) -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@kms_hdr@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl4/igt@kms_hdr@[email protected]
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [SKIP][141] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb8/igt@kms_psr2_su@page_flip-xrgb8888.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][143] ([fdo#109441]) -> [PASS][144] +1 similar issue
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb5/igt@kms_psr@psr2_sprite_render.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-b:
- shard-apl: [DMESG-WARN][145] ([i915#1982] / [i915#62]) -> [PASS][146] +1 similar issue
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl3/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl2/igt@[email protected]
* igt@kms_vblank@pipe-a-accuracy-idle:
- shard-apl: [DMESG-WARN][147] ([i915#62]) -> [PASS][148] +6 similar issues
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl3/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl2/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
- shard-apl: [FAIL][149] -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl3/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl2/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][151] ([i915#180]) -> [PASS][152] +4 similar issues
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl2/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl1/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-glk: [FAIL][153] ([i915#5639]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-glk9/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-glk9/igt@[email protected]
#### Warnings ####
* igt@gem_userptr_blits@unsync-unmap-after-close:
- shard-skl: [SKIP][155] ([fdo#109271] / [i915#1888]) -> [SKIP][156] ([fdo#109271]) +2 similar issues
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-skl1/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl7/igt@[email protected]
* igt@i915_selftest@mock@vma:
- shard-skl: [INCOMPLETE][157] ([i915#6473]) -> [INCOMPLETE][158] ([i915#6473] / [i915#6509])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-skl10/igt@i915_selftest@[email protected]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl1/igt@i915_selftest@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-skl: [SKIP][159] ([fdo#109271]) -> [SKIP][160] ([fdo#109271] / [i915#1888])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-skl9/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_chamelium@hdmi-crc-fast:
- shard-skl: [SKIP][161] ([fdo#109271] / [fdo#111827]) -> [SKIP][162] ([fdo#109271] / [fdo#111827] / [i915#1888])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-skl9/igt@[email protected]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl4/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][163] ([i915#79]) -> [FAIL][164] ([i915#2122])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-skl9/igt@kms_flip@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-kbl: [DMESG-WARN][165] ([i915#180]) -> [DMESG-FAIL][166] ([i915#180])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@kms_hdr@[email protected]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@kms_hdr@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: [DMESG-FAIL][167] ([fdo#108145] / [i915#62]) -> [FAIL][168] ([fdo#108145] / [i915#265])
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-apl3/igt@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-apl2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][169] ([i915#658]) -> [SKIP][170] ([i915#2920])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb7/igt@[email protected]
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][171] ([i915#2920]) -> [SKIP][172] ([fdo#111068] / [i915#658])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb2/igt@[email protected]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb6/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][173] ([fdo#111068] / [i915#658]) -> [SKIP][174] ([i915#2920]) +1 similar issue
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-iclb8/igt@[email protected]
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-skl: [SKIP][175] ([fdo#109271] / [i915#658]) -> [SKIP][176] ([fdo#109271] / [i915#1888] / [i915#658])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-skl1/igt@[email protected]
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-skl7/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][177], [FAIL][178], [FAIL][179], [FAIL][180], [FAIL][181], [FAIL][182], [FAIL][183], [FAIL][184], [FAIL][185], [FAIL][186], [FAIL][187], [FAIL][188]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92]) -> ([FAIL][189], [FAIL][190], [FAIL][191], [FAIL][192], [FAIL][193], [FAIL][194], [FAIL][195], [FAIL][196], [FAIL][197], [FAIL][198], [FAIL][199]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92])
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl7/igt@[email protected]
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@[email protected]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl4/igt@[email protected]
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl7/igt@[email protected]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@[email protected]
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl7/igt@[email protected]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@[email protected]
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@[email protected]
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@[email protected]
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@[email protected]
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl1/igt@[email protected]
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11981/shard-kbl4/igt@[email protected]
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl7/igt@[email protected]
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl7/igt@[email protected]
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl7/igt@[email protected]
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/shard-kbl1/igt@[email protected]
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5090]: https://gitlab.freedesktop.org/drm/intel/issues/5090
[i915#5129]: https://gitlab.freedesktop.org/drm/intel/issues/5129
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6473]: https://gitlab.freedesktop.org/drm/intel/issues/6473
[i915#6509]: https://gitlab.freedesktop.org/drm/intel/issues/6509
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* Linux: CI_DRM_11981 -> Patchwork_107073v3
CI-20190529: 20190529
CI_DRM_11981: 6f207fdd93a13166b4adfe2f3a2972a9c632e757 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6619: ec2ab8e3a151ce05bd2726319c528c2ab99e8a96 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107073v3: 6f207fdd93a13166b4adfe2f3a2972a9c632e757 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107073v3/index.html