drm/i915/pxp: don't start pxp without mei_pxp bind
Subsystems (2)
PATCH v2 1/1 drm/i915/pxp: don't start pxp without mei_pxp bind
pxp will not start correctly until after mei_pxp bind completes and intel_pxp_init_hw() is called.
This fixes a race condition during bootup where we observed a small window for pxp commands to be sent before mei_pxp bind completed.
Changes since v1:
- check pxp_component instead of pxp_component_added (Daniele)
- pxp_component needs tee_mutex (Daniele)
- return -EAGAIN so caller knows to retry (Daniele)
--- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/pxp/intel_pxp.c +8 -0
@@ -187,6 +187,14 @@ int intel_pxp_start(struct intel_pxp *pxp)if (!intel_pxp_is_enabled (pxp))return -ENODEV ; +mutex_lock (&pxp->tee_mutex); +/* check if mei_pxp is bound */ +if (!pxp->pxp_component) { +mutex_unlock (&pxp->tee_mutex); +return -EAGAIN ; + } +mutex_unlock (&pxp->tee_mutex); +mutex_lock (&pxp->arb_mutex);if (pxp->arb_is_valid)
Signature · 1 line
2.37.1.559.g78731f0fdb-goog
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: don't start pxp without mei_pxp bind (rev2)
== Series Details ==
== Series Details ==
Series: drm/i915/pxp: don't start pxp without mei_pxp bind (rev2)
URL : https://patchwork.freedesktop.org/series/107099/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11977 -> Patchwork_107099v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/index.html
Participating hosts (42 -> 36)
------------------------------
Missing (6): fi-hsw-4200u bat-adlm-1 bat-adlp-4 fi-ctg-p8600 bat-rpls-2 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107099v2:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live@gt_heartbeat:
- {bat-dg2-8}: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/bat-dg2-8/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/bat-dg2-8/igt@i915_selftest@live@gt_heartbeat.html
Known issues
------------
Here are the changes found in Patchwork_107099v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_render_tiled_blits@basic:
- fi-apl-guc: [PASS][3] -> [INCOMPLETE][4] ([i915#6532])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/fi-apl-guc/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/fi-apl-guc/igt@[email protected]
* igt@i915_selftest@live@hugepages:
- fi-bdw-gvtdvm: [PASS][5] -> [DMESG-FAIL][6] ([i915#6217])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/fi-bdw-gvtdvm/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/fi-bdw-gvtdvm/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][7] -> [DMESG-FAIL][8] ([i915#4528])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/fi-blb-e6850/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/fi-blb-e6850/igt@i915_selftest@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-bdw-5557u: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/fi-bdw-5557u/igt@[email protected]
* igt@runner@aborted:
- fi-bdw-gvtdvm: NOTRUN -> [FAIL][10] ([i915#4312])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/fi-bdw-gvtdvm/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#6217]: https://gitlab.freedesktop.org/drm/intel/issues/6217
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6532]: https://gitlab.freedesktop.org/drm/intel/issues/6532
Build changes
-------------
* Linux: CI_DRM_11977 -> Patchwork_107099v2
CI-20190529: 20190529
CI_DRM_11977: 71776a3cc166e6400e713acdd2b03094120e1baa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6619: ec2ab8e3a151ce05bd2726319c528c2ab99e8a96 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107099v2: 71776a3cc166e6400e713acdd2b03094120e1baa @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
c31091fc15d3 drm/i915/pxp: don't start pxp without mei_pxp bind
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pxp: don't start pxp without mei_pxp bind (rev2)
In reply to Juston Li== Series Details ==
== Series Details ==
Series: drm/i915/pxp: don't start pxp without mei_pxp bind (rev2)
URL : https://patchwork.freedesktop.org/series/107099/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11977_full -> Patchwork_107099v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_107099v2_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_107099v2_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107099v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-tglb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-tglb2/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_vblank@pipe-d-query-idle-hang:
- {shard-dg1}: [SKIP][3] ([i915#6277]) -> [SKIP][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-dg1-14/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-dg1-14/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_107099v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][5] -> [SKIP][6] ([i915#4525])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb5/igt@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl1/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-apl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-glk9/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-glk1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb7/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb7/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-apl6/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][15] ([i915#2658])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-apl6/igt@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- shard-skl: [PASS][16] -> [DMESG-WARN][17] ([i915#1982])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl4/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl9/igt@[email protected]
* igt@i915_suspend@forcewake:
- shard-kbl: [PASS][18] -> [DMESG-WARN][19] ([i915#180]) +7 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl4/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-kbl1/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#3886]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-apl2/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3886])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-kbl1/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271]) +77 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-apl6/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-crc-fast:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-apl2/igt@[email protected]
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl6/igt@[email protected]
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-kbl: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-kbl1/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][26] -> [FAIL][27] ([i915#79])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-glk5/igt@kms_flip@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-glk6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][28] -> [FAIL][29] ([i915#79]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl10/igt@kms_flip@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl9/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-dp1:
- shard-kbl: [PASS][30] -> [FAIL][31] ([i915#79])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl4/igt@kms_flip@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-kbl7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@a-edp1:
- shard-skl: [PASS][32] -> [FAIL][33] ([i915#2122])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl7/igt@kms_flip@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][34] ([i915#2672]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb4/igt@kms_flip_scaled_crc@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#3555])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_hdr@bpc-switch@pipe-a-dp-1:
- shard-kbl: [PASS][36] -> [FAIL][37] ([i915#1188])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl1/igt@kms_hdr@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-kbl4/igt@kms_hdr@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][38] ([fdo#108145] / [i915#265])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-apl6/igt@[email protected]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-4:
- shard-kbl: NOTRUN -> [SKIP][39] ([fdo#109271]) +16 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-kbl1/igt@[email protected]
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [PASS][40] -> [SKIP][41] ([fdo#109441]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb4/igt@kms_psr@psr2_primary_blt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [PASS][42] -> [SKIP][43] ([i915#5519])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb5/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb4/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [PASS][44] -> [DMESG-WARN][45] ([i915#180]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl8/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-apl2/igt@[email protected]
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#2437])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-apl6/igt@[email protected]
#### Possible fixes ####
* igt@feature_discovery@psr1:
- {shard-rkl}: [SKIP][47] ([i915#658]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [FAIL][49] ([i915#6268]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-tglb5/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-tglb3/igt@[email protected]
* igt@gem_exec_balancer@fairslice:
- {shard-rkl}: [SKIP][51] ([i915#6259]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@[email protected]
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][53] ([i915#4525]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][55] ([i915#2846]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-kbl7/igt@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- {shard-rkl}: [FAIL][57] ([i915#2842]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@gem_exec_fair@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][59] ([i915#2842]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-glk7/igt@gem_exec_fair@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [FAIL][61] ([i915#2842]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl1/igt@gem_exec_fair@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fence@basic-busy@bcs0:
- {shard-rkl}: [SKIP][63] ([i915#6251]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@gem_exec_fence@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-2/igt@gem_exec_fence@[email protected]
* igt@gem_exec_reloc@basic-cpu-gtt-noreloc:
- {shard-rkl}: [SKIP][65] ([i915#3281]) -> [PASS][66] +9 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-5/igt@[email protected]
* igt@gem_madvise@dontneed-before-pwrite:
- {shard-rkl}: [SKIP][67] ([i915#3282]) -> [PASS][68] +5 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-5/igt@[email protected]
* igt@gem_ppgtt@blt-vs-render-ctx0:
- {shard-rkl}: [INCOMPLETE][69] ([i915#3692]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [INCOMPLETE][71] -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl4/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-kbl7/igt@[email protected]
* igt@gen9_exec_parse@bb-start-param:
- {shard-rkl}: [SKIP][73] ([i915#2527]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-2/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-5/igt@[email protected]
* igt@i915_hangman@engine-engine-error@bcs0:
- {shard-rkl}: [SKIP][75] ([i915#6258]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@i915_hangman@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-2/igt@i915_hangman@[email protected]
* igt@i915_pm_backlight@fade_with_dpms:
- {shard-rkl}: [SKIP][77] ([i915#3012]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@i915_pm_backlight@fade_with_dpms.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@i915_pm_backlight@fade_with_dpms.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][79] ([i915#1397]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-2/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp:
- {shard-dg1}: [SKIP][81] ([i915#1397]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-dg1-14/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-dg1-13/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1:
- shard-skl: [FAIL][83] ([i915#2521]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl9/igt@kms_async_flips@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl10/igt@kms_async_flips@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- {shard-rkl}: [SKIP][85] ([i915#1845] / [i915#4098]) -> [PASS][86] +32 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-2/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1:
- shard-apl: [DMESG-WARN][87] ([i915#180]) -> [PASS][88] +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-apl2/igt@kms_cursor_crc@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-apl2/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [FAIL][89] ([i915#2346]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-glk7/igt@kms_cursor_legacy@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-glk8/igt@kms_cursor_legacy@[email protected]
- shard-iclb: [FAIL][91] ([i915#2346]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb7/igt@kms_cursor_legacy@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb7/igt@kms_cursor_legacy@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled:
- {shard-rkl}: [SKIP][93] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][94] +5 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][95] ([i915#79]) -> [PASS][96] +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl6/igt@kms_flip@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: [DMESG-WARN][97] ([i915#180]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-kbl1/igt@kms_flip@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-kbl1/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@a-edp1:
- shard-skl: [FAIL][99] ([i915#2122]) -> [PASS][100] +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl1/igt@kms_flip@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu:
- {shard-dg1}: [FAIL][101] -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-dg1-19/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-dg1-18/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
- {shard-rkl}: [SKIP][103] ([i915#1849] / [i915#4098]) -> [PASS][104] +20 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-skl: [DMESG-WARN][105] ([i915#1982]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl1/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- {shard-rkl}: [SKIP][107] ([i915#1849] / [i915#3546] / [i915#4098]) -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@[email protected]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
- {shard-rkl}: [SKIP][109] ([i915#1849] / [i915#3558]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@[email protected]
* igt@kms_psr@no_drrs:
- {shard-rkl}: [SKIP][111] ([i915#1072]) -> [PASS][112] +2 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@kms_psr@no_drrs.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-6/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][113] ([fdo#109441]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@perf@gen12-unprivileged-single-ctx-counters:
- {shard-rkl}: [SKIP][115] ([fdo#109289]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-5/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-2/igt@[email protected]
* igt@prime_vgem@basic-fence-read:
- {shard-rkl}: [SKIP][117] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-rkl-6/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-rkl-5/igt@[email protected]
#### Warnings ####
* igt@gem_eio@kms:
- shard-tglb: [FAIL][119] ([i915#5784]) -> [TIMEOUT][120] ([i915#3063])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-tglb5/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-tglb2/igt@[email protected]
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [SKIP][121] ([i915#4525]) -> [FAIL][122] ([i915#6117])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb6/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][123] ([i915#2842]) -> [FAIL][124] ([i915#2852])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb1/igt@gem_exec_fair@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb8/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][125] ([i915#658]) -> [SKIP][126] ([i915#588])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb6/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb2/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- shard-skl: [FAIL][127] ([i915#3524]) -> [FAIL][128] ([i915#3650])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl10/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl9/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc:
- shard-skl: [SKIP][129] ([fdo#109271] / [i915#1888]) -> [SKIP][130] ([fdo#109271]) +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl7/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl1/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][131] ([i915#658]) -> [SKIP][132] ([i915#2920])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-iclb5/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-skl: [SKIP][133] ([fdo#109271] / [i915#1888] / [i915#658]) -> [SKIP][134] ([fdo#109271] / [i915#658])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl1/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl7/igt@[email protected]
* igt@sysfs_clients@busy:
- shard-skl: [SKIP][135] ([fdo#109271] / [i915#1888] / [i915#2994]) -> [SKIP][136] ([fdo#109271] / [i915#2994])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11977/shard-skl4/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/shard-skl1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3524]: https://gitlab.freedesktop.org/drm/intel/issues/3524
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3650]: https://gitlab.freedesktop.org/drm/intel/issues/3650
[i915#3692]: https://gitlab.freedesktop.org/drm/intel/issues/3692
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6277]: https://gitlab.freedesktop.org/drm/intel/issues/6277
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_11977 -> Patchwork_107099v2
CI-20190529: 20190529
CI_DRM_11977: 71776a3cc166e6400e713acdd2b03094120e1baa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6619: ec2ab8e3a151ce05bd2726319c528c2ab99e8a96 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107099v2: 71776a3cc166e6400e713acdd2b03094120e1baa @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107099v2/index.html
Quoted 10 lines · Juston Li
pxp will not start correctly until after
mei_pxpbind completes andintel_pxp_init_hw()is called.This fixes a race condition during bootup where we observed a small window for pxp commands to be sent before
mei_pxpbind completed.Changes since v1:
- checkpxp_componentinstead ofpxp_component_added(Daniele)
-pxp_componentneedstee_mutex(Daniele)
- return-EAGAINso caller knows to retry (Daniele)
Sorry for the follow up, but I have reflected on this a bit more and I was thinking that maybe it would be better to wait a bit for the component to be bound, instead of immediately failing the call. Do you have a measure of how long after your failure you see the component bind complete? The wait would make sense only if relatively short (< 1s).
Daniele
Quoted 24 lines
Signed-off-by Juston Li <[email protected]>--- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/i915/pxp/intel_pxp.c +8
-0@@ -187,6 +187,14 @@ int intel_pxp_start(struct intel_pxp *pxp)if (!intel_pxp_is_enabled (pxp))return -ENODEV ; +mutex_lock (&pxp->tee_mutex); +/* check if mei_pxp is bound */ +if (!pxp->pxp_component) { +mutex_unlock (&pxp->tee_mutex); +return -EAGAIN ; + } +mutex_unlock (&pxp->tee_mutex); +mutex_lock (&pxp->arb_mutex);if (pxp->arb_is_valid)
Quoted 15 lines · Daniele
Quoted 10 lines · Juston Li
pxp will not start correctly until after
mei_pxpbind completes andintel_pxp_init_hw()is called.This fixes a race condition during bootup where we observed a small window for pxp commands to be sent before
mei_pxpbind completed.Changes since v1:
- checkpxp_componentinstead ofpxp_component_added(Daniele)
-pxp_componentneedstee_mutex(Daniele)
- return-EAGAINso caller knows to retry (Daniele)
Quoted 5 lines
Sorry for the follow up, but I have reflected on this a bit more and I was thinking that maybe it would be better to wait a bit for the component to be bound, instead of immediately failing the call. Do you have a measure of how long after your failure you see the component bind complete? The wait would make sense only if relatively short (< 1s).
No worries, that sounds better.
Media driver does end up allowing it in its retry loop but it's trying quite a few times.
The bind happens shortly after, ~ 0.08 seconds.
2022-08-15T16:27:12.190032Z ERR kernel: [ 8.384979] i915 0000:00:02.0: [drm] 1st PXP start no mei_pxp 2022-08-15T16:27:12.238027Z INFO kernel: [ 8.433168] pci 0000:00:16.0: attach allowed to drvr mei_me [trusted device] 2022-08-15T16:27:12.238046Z INFO kernel: [ 8.433222] mei_me 0000:00:16.0: enabling device (0000 -> 0002) 2022-08-15T16:27:12.255546Z INFO pciguard[953]: INFO pciguard: [udev_monitor.cc(106)] UdevEvent: pci change ALLOWED mei_me / sys/devices/pci0000:00/0000:00:16.0 2022-08-15T16:27:12.262298Z INFO kernel: [ 8.457702] mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops 0xffffffffb6cc6850) 2022-08-15T16:27:12.264027Z INFO kernel: [ 8.458920] mei_hdcp
0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops 0xffffffffb6cbcce0)
Juston
Quoted 27 lines
Daniele
Quoted 24 lines
Signed-off-by Juston Li <[email protected]>--- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/i915/pxp/intel_pxp.c +8
-0@@ -187,6 +187,14 @@ int intel_pxp_start(struct intel_pxp *pxp)if (!intel_pxp_is_enabled (pxp))return -ENODEV ; +mutex_lock (&pxp->tee_mutex); +/* check if mei_pxp is bound */ +if (!pxp->pxp_component) { +mutex_unlock (&pxp->tee_mutex); +return -EAGAIN ; + } +mutex_unlock (&pxp->tee_mutex); +mutex_lock (&pxp->arb_mutex);if (pxp->arb_is_valid)
Quoted 15 lines · Daniele
Quoted 10 lines · Juston Li
pxp will not start correctly until after
mei_pxpbind completes andintel_pxp_init_hw()is called.This fixes a race condition during bootup where we observed a small window for pxp commands to be sent before
mei_pxpbind completed.Changes since v1:
- checkpxp_componentinstead ofpxp_component_added(Daniele)
-pxp_componentneedstee_mutex(Daniele)
- return-EAGAINso caller knows to retry (Daniele)
Quoted 5 lines
Sorry for the follow up, but I have reflected on this a bit more and I was thinking that maybe it would be better to wait a bit for the component to be bound, instead of immediately failing the call. Do you have a measure of how long after your failure you see the component bind complete? The wait would make sense only if relatively short (< 1s).
No worries, that sounds better.
Media driver does end up allowing it in its retry loop but it's trying quite a few
times.
The bind happens shortly after, ~ 0.08 seconds.
2022-08-15T16:27:12.190032Z ERR kernel: [ 8.384979] i915 0000:00:02.0: [drm] 1st PXP start no mei_pxp 2022-08-15T16:27:12.238027Z INFO kernel: [ 8.433168] pci 0000:00:16.0: attach allowed to drvr mei_me [trusted device] 2022-08-15T16:27:12.238046Z INFO kernel: [ 8.433222] mei_me 0000:00:16.0: enabling device (0000 -> 0002) 2022-08-15T16:27:12.255546Z INFO pciguard[953]: INFO pciguard: [udev_monitor.cc(106)] UdevEvent: pci change ALLOWED mei_me / sys/devices/pci0000:00/0000:00:16.0 2022-08-15T16:27:12.262298Z INFO kernel: [ 8.457702] mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops 0xffffffffb6cc6850) 2022-08-15T16:27:12.264027Z INFO kernel: [ 8.458920] mei_hdcp
0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops 0xffffffffb6cbcce0)
Juston
Quoted 27 lines
Daniele
Quoted 24 lines
Signed-off-by Juston Li <[email protected]>--- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/i915/pxp/intel_pxp.c +8
-0@@ -187,6 +187,14 @@ int intel_pxp_start(struct intel_pxp *pxp)if (!intel_pxp_is_enabled (pxp))return -ENODEV ; +mutex_lock (&pxp->tee_mutex); +/* check if mei_pxp is bound */ +if (!pxp->pxp_component) { +mutex_unlock (&pxp->tee_mutex); +return -EAGAIN ; + } +mutex_unlock (&pxp->tee_mutex); +mutex_lock (&pxp->arb_mutex);if (pxp->arb_is_valid)