net/iavf: fix pattern check for flow director parser
PATCH 1/1 net/iavf: fix pattern check for flow director parser
FDIR rules with masks are not supported in current code. Thus add pattern check for IPv4/UDP/TCP/SCTP addr/port to terminate the FDIR programming stage.
Fixes d5eb3e600d9e ("net/iavf: support flow director basic rule")
Signed-off-by Steve Yang <[email protected]>
--- drivers/net/iavf/iavf_fdir.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
drivers/net/iavf/iavf_fdir.c +32 -0
@@ -932,6 +932,14 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,return -rte_errno; } +/* Mask for IPv4 src/dst addrs not supported */ +if (ipv4_mask->hdr.src_addr && + ipv4_mask->hdr.src_addr !=UINT32_MAX ) +return -rte_errno; +if (ipv4_mask->hdr.dst_addr && + ipv4_mask->hdr.dst_addr !=UINT32_MAX ) +return -rte_errno; +if (ipv4_mask->hdr.type_of_service ==UINT8_MAX ) { input_set |=IAVF_INSET_IPV4_TOS ;
@@ -1122,6 +1130,14 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,return -rte_errno; } +/* Mask for UDP src/dst ports not supported */ +if (udp_mask->hdr.src_port && + udp_mask->hdr.src_port !=UINT16_MAX ) +return -rte_errno; +if (udp_mask->hdr.dst_port && + udp_mask->hdr.dst_port !=UINT16_MAX ) +return -rte_errno; +if (udp_mask->hdr.src_port ==UINT16_MAX ) { input_set |=IAVF_INSET_UDP_SRC_PORT ;VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT (hdr,UDP ,SRC_PORT );
@@ -1171,6 +1187,14 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,return -rte_errno; } +/* Mask for TCP src/dst ports not supported */ +if (tcp_mask->hdr.src_port && + tcp_mask->hdr.src_port !=UINT16_MAX ) +return -rte_errno; +if (tcp_mask->hdr.dst_port && + tcp_mask->hdr.dst_port !=UINT16_MAX ) +return -rte_errno; +if (tcp_mask->hdr.src_port ==UINT16_MAX ) { input_set |=IAVF_INSET_TCP_SRC_PORT ;VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT (hdr,TCP ,SRC_PORT );
@@ -1214,6 +1238,14 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,return -rte_errno; } +/* Mask for SCTP src/dst ports not supported */ +if (sctp_mask->hdr.src_port && + sctp_mask->hdr.src_port !=UINT16_MAX ) +return -rte_errno; +if (sctp_mask->hdr.dst_port && + sctp_mask->hdr.dst_port !=UINT16_MAX ) +return -rte_errno; +if (sctp_mask->hdr.src_port ==UINT16_MAX ) { input_set |=IAVF_INSET_SCTP_SRC_PORT ;VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT (hdr,SCTP ,SRC_PORT );
Signature · 1 line
2.25.1
Quoted 11 lines
-----Original Message-----
From: Steve Yang <[email protected]>
Sent: Wednesday, August 10, 2022 2:48 PM
To: [email protected]
Cc: Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Subject: [PATCH v1] net/iavf: fix pattern check for flow director parser
Quoted 8 lines
FDIR rules with masks are not supported in current code. Thus add pattern check for IPv4/UDP/TCP/SCTP addr/port to terminate the FDIR programming stage.
Fixes d5eb3e600d9e ("net/iavf: support flow director basic rule")Signed-off-by Steve Yang <[email protected]>
Acked-by Qi Zhang <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi