Skip to contentSkip to conversation

thermal/core: Add missing EXPORT_SYMBOL_GPL

PATCH Applied Daniel Lezcano 3 participants 5 messages Aug 10, 2022 – Aug 15, 2022 Thermal

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 thermal/core: Add missing EXPORT_SYMBOL_GPL

The function thermal_zone_device_register_with_trips() is not exported for modules.

Add the missing EXPORT_SYMBOL_GPL().

---
 drivers/thermal/thermal_core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/thermal/thermal_core.c +1 -0
index b4c68410c158..10c979dce512 100644
@@ -1329,6 +1329,7 @@ thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t
 	kfree(tz);
 	return ERR_PTR(result);
 }
+EXPORT_SYMBOL_GPL(thermal_zone_device_register_with_trips);
 
 struct thermal_zone_device *thermal_zone_device_register(const char *type, int ntrips, int mask,
 							 void *devdata, struct thermal_zone_device_ops *ops,
Signature · 1 line
2.34.1
#1 lore raw
Quoted 7 lines · Daniel Lezcano

The function thermal_zone_device_register_with_trips() is not exported for modules.

Add the missing EXPORT_SYMBOL_GPL().

A Fixes tag missing?

Quoted 19 lines
---
 drivers/thermal/thermal_core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/thermal/thermal_core.c +1 -1
index b4c68410c158..10c979dce512 100644
@@ -1329,6 +1329,7 @@ thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t
        kfree(tz);
        return ERR_PTR(result);
 }
+EXPORT_SYMBOL_GPL(thermal_zone_device_register_with_trips);
 
 struct thermal_zone_device *thermal_zone_device_register(const char *type, int ntrips, int mask,
                                                         void *devdata, struct thermal_zone_device_ops *ops,
--

2.34.1

#2 lore raw
Quoted 11 lines · Rafael J. Wysocki
Quoted 7 lines · Daniel Lezcano

The function thermal_zone_device_register_with_trips() is not exported for modules.

Add the missing EXPORT_SYMBOL_GPL().

A Fixes tag missing?

He he :) Indeed ...

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#3 lore raw
In reply to Rafael J. Wysocki
Quoted 11 lines · Rafael J. Wysocki
Quoted 7 lines · Daniel Lezcano

The function thermal_zone_device_register_with_trips() is not exported for modules.

Add the missing EXPORT_SYMBOL_GPL().

A Fixes tag missing?

I've added the missing tag in the thermal/linux-next branch

https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/commit/?h=thermal/linux-next&id=78ad78d78b43538e6dcbce3fd0699f15b79cfe3f

Quoted 20 lines
Quoted 20 lines
---
  drivers/thermal/thermal_core.c | 1 +
  1 file changed, 1 insertion(+)
drivers/thermal/thermal_core.c +1 -1
index b4c68410c158..10c979dce512 100644
@@ -1329,6 +1329,7 @@ thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t
         kfree(tz);
         return ERR_PTR(result);
  }
+EXPORT_SYMBOL_GPL(thermal_zone_device_register_with_trips);
 
  struct thermal_zone_device *thermal_zone_device_register(const char *type, int ntrips, int mask,
                                                          void *devdata, struct thermal_zone_device_ops *ops,
--

2.34.1

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#4 lore raw
In reply to Daniel Lezcano
The following commit has been merged into the thermal/fixes branch of thermal:

The following commit has been merged into the thermal/fixes branch of thermal:

Commit-ID:     a921be53b46c393d8d594a62a44f418c97e5504b
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//a921be53b46c393d8d594a62a44f418c97e5504b
Author:        Daniel Lezcano <[email protected]>
AuthorDate:    Wed, 10 Aug 2022 12:07:31 +02:00
Committer:     Daniel Lezcano <[email protected]>
CommitterDate: Mon, 15 Aug 2022 20:38:19 +02:00

thermal/core: Add missing EXPORT_SYMBOL_GPL

The function thermal_zone_device_register_with_trips() is not exported for modules.

Add the missing EXPORT_SYMBOL_GPL().

Fixes fae11de507f0e ("thermal/core: Add thermal_trip in thermal_zone")
---
 drivers/thermal/thermal_core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/thermal/thermal_core.c +1 -0
index 6a5d0ae..50d50ce 100644
@@ -1329,6 +1329,7 @@ free_tz:
 	kfree(tz);
 	return ERR_PTR(result);
 }
+EXPORT_SYMBOL_GPL(thermal_zone_device_register_with_trips);
 
 struct thermal_zone_device *thermal_zone_device_register(const char *type, int ntrips, int mask,
 							 void *devdata, struct thermal_zone_device_ops *ops,