Skip to contentSkip to conversation

Convert arm,versatile-sysreg to DT schema

PATCH In review Rob Herring 3 participants 5 messages Aug 10, 2022 – Aug 22, 2022

Subsystems (5)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

cover Convert arm,versatile-sysreg to DT schema

This short series converts the arm,versatile-sysreg binding to DT schema. The binding is already in use in examples which unsurprisingly needs a fix with the schema added.

This is part of getting rid of the remaining ~40 cases of compatibles without a schema in the examples.

Rob

Rob Herring (2):
dt-bindings: display: arm,versatile-tft-panel: Drop erroneous
properties in example
dt-bindings: arm,versatile-sysreg: Convert to DT schema format

 .../bindings/arm/arm,versatile-sysreg.yaml    | 35 +++++++++++++++++++
 .../bindings/arm/versatile-sysreg.txt         | 10 ------
 .../panel/arm,versatile-tft-panel.yaml        |  3 --
 3 files changed, 35 insertions(+), 13 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/arm,versatile-sysreg.yaml
 delete mode 100644 Documentation/devicetree/bindings/arm/versatile-sysreg.txt

--
2.34.1

author maintainer
#1 lore raw

PATCH 1/2 dt-bindings: display: arm,versatile-tft-panel: Drop erroneous properties in example

The 'arm,versatile-sysreg' node in the example should not have '#address-cells' and '#size-cells' properties as the child node doesn't have 'reg'.

---
 .../bindings/display/panel/arm,versatile-tft-panel.yaml        | 3 ---
 1 file changed, 3 deletions(-)
Documentation/devicetree/bindings/display/panel/arm,versatile-tft-panel.yaml +0 -3
index be69e0cc50fc..c9958f824d9a 100644
@@ -37,9 +37,6 @@ examples:
         compatible = "arm,versatile-sysreg", "syscon", "simple-mfd";
         reg = <0x00000 0x1000>;
 
-        #address-cells = <1>;
-        #size-cells = <0>;
-
         panel {
             compatible = "arm,versatile-tft-panel";
 
Signature · 1 line
2.34.1
author maintainer
#2 lore raw

PATCH 2/2 dt-bindings: arm,versatile-sysreg: Convert to DT schema format

In reply to Rob Herring

Convert the arm,versatile-sysreg binding to DT schema format.

The original binding was missing 'simple-mfd' and a 'panel' sub node which the only user (versatile-ab.dts) of this binding has.

---
 .../bindings/arm/arm,versatile-sysreg.yaml    | 35 +++++++++++++++++++
 .../bindings/arm/versatile-sysreg.txt         | 10 ------
 2 files changed, 35 insertions(+), 10 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/arm,versatile-sysreg.yaml
 delete mode 100644 Documentation/devicetree/bindings/arm/versatile-sysreg.txt
Documentation/devicetree/bindings/arm/arm,versatile-sysreg.yaml new file +35 -0
new file mode 100644
index 000000000000..491eef1e1b10
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/arm,versatile-sysreg.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Arm Versatile system registers
+
+maintainers:
+  - Linus Walleij <[email protected]>
+
+description:
+  This is a system control registers block, providing multiple low level
+  platform functions like board detection and identification, software
+  interrupt generation, MMC and NOR Flash control, etc.
+
+properties:
+  compatible:
+    items:
+      - const: arm,versatile-sysreg
+      - const: syscon
+      - const: simple-mfd
+
+  reg:
+    maxItems: 1
+
+  panel:
+    type: object
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+...
Documentation/devicetree/bindings/arm/versatile-sysreg.txt deleted +0 -10
deleted file mode 100644
index a4f15262d717..000000000000
@@ -1,10 +0,0 @@
-ARM Versatile system registers
---------------------------------------
-
-This is a system control registers block, providing multiple low level
-platform functions like board detection and identification, software
-interrupt generation, MMC and NOR Flash control etc.
-
-Required node properties:
-- compatible value : = "arm,versatile-sysreg", "syscon"
-- reg : physical base address and the size of the registers window
Signature · 1 line
2.34.1
Reviewed-by on the v1 series
#4 lore raw
In reply to Rob Herring
Quoted 3 lines · Rob Herring

This short series converts the arm,versatile-sysreg binding to DT schema. The binding is already in use in examples which unsurprisingly needs a fix with the schema added.

Excellent, thanks!

I assume you will apply this to the binding tree or similar, else tell me what to do!

Yours,
Linus Walleij