Move the address of FW_JUMP_FDT_ADDR forward
cover Move the address of FW_JUMP_FDT_ADDR forward
From: "Nylon.Chen" <[email protected]>
A while ago.
when we boot from QEMU by OpenSBI Jump mode with initramfs kerenl.
The kernel encountered panic because the kernel's section was overwritten, and the address was FW_JUMP_FDT_ADDR.
we find out the the rule $(FW_TEXT_START) + 0x2200000 in platform/generic/config.mk
The situation is our kernel size big than it.
e.g.
# readelf -h vmlinux init.bss's LMA is "0x00000000024a96a0", and when we use this rule, it exceeds its size.
0x24a96a0 > 0x2200000
After our experiment, we can add offset FW_JUMP_FDT_ADDR, and the problem is solved.
But in my opinion, this is not a good method because the next time the kernel size increases, the same situation occurs again.
So maybe we can move the address forward and normalize the address to FW_JUMP_FDT_ADDR?
Signature · 1 line
2.36.1
cover Move the address of FW_JUMP_FDT_ADDR forward
? 2022-08-11???? 16:58 +0800?Nylon Chen???
Quoted 23 lines
From: "Nylon.Chen" <[email protected]>
A while ago.
when we boot from QEMU by OpenSBI Jump mode with initramfs kerenl.The kernel encountered panic because the kernel's section was overwritten, and the address was
FW_JUMP_FDT_ADDR.we find out the the rule
$(FW_TEXT_START) + 0x2200000inplatform/generic/config.mkThe situation is our kernel size big than it.
e.g.
# readelf -h vmlinux init.bss's LMA is "0x00000000024a96a0", and when we use this rule, it exceeds its size.
0x24a96a0>0x2200000After our experiment, we can add offset
FW_JUMP_FDT_ADDR, and the problem is solved.
Quoted 11 lines
But in my opinion, this is not a good method because the next time the kernel size increases, the same situation occurs again.
So maybe we can move the address forward and normalize the address to
FW_JUMP_FDT_ADDR?Signed-off-by Nylon Chen <[email protected]>Signature · 1 line
2.36.1
Overwriting may occur regardless of the bit value adjustment. You can build with:
make ... FW_JUMP_FDT_ADDR=xxx ...
Regards,
Xiang W
cover Move the address of FW_JUMP_FDT_ADDR forward
In reply to Nylon ChenQuoted 5 lines · Nylon Chen
From: "Nylon.Chen" <[email protected]>
A while ago.
when we boot from QEMU by OpenSBI Jump mode with initramfs kerenl.
Quoted 7 lines
The kernel encountered panic because the kernel's section was overwritten, and the address was
FW_JUMP_FDT_ADDR.we find out the the rule
$(FW_TEXT_START) + 0x2200000inplatform/generic/config.mkThe situation is our kernel size big than it.
This implies opensbi is being used as a FW_PAYLOAD firmware.
Quoted 10 lines
e.g.
# readelf -h vmlinux init.bss's LMA is "0x00000000024a96a0", and when we use this rule, it exceeds its size.
0x24a96a0>0x2200000After our experiment, we can add offset
FW_JUMP_FDT_ADDR, and the problem is solved.
Since this is a FW_PAYLOAD firmware you should be adjusting FW_PAYLOAD_FDT_ADDR. Adjusting FW_JUMP_FDT_ADDR only works because by default FW_PAYLOAD_FDT_ADDR = FW_JUMP_FDT_ADDR (for the generic platform).
Quoted 3 lines
But in my opinion, this is not a good method because the next time the kernel size increases, the same situation occurs again.
I haven't tried it, but I think it should be possible to embed the FDT into the kernel (CONFIG_BUILTIN_DTB) and then ensure FW_PAYLOAD_FDT_ADDR is *not* defined. Doing that will hopefully keep opensbi from overwriting the payload and linux will still find the DTB without looking at a1 for it. Taking that approach (if it works) would avoid having to adjust FW_PAYLOAD_FDT_ADDR for different payload sizes.
Quoted 3 lines
So maybe we can move the address forward and normalize the address to
FW_JUMP_FDT_ADDR?
These types of defaults are impossible to get right for everybody. IMHO, what's there today should stay as is and we should work at making it as easy as possible to adjust at build- and/or run- time when necessary.
Thanks,
drew
cover Move the address of FW_JUMP_FDT_ADDR forward
Hi Andrew,Xiang
Thanks for your comment.
maybe we can add some information in docs/firmware/fw_jump.md to help the developer avoid this issue?
e.g.
If your PLATFORM=generic and your FW_JUMP_FDT_ADDR is default, you must check your Linux size because Linux will be overwritten in OpneSBI's FDT copy loop.
You can use the following method.
```
LAST_SECTION=`${CROSS_COMPILE}objdump -h vmlinux | grep "00*" | awk
'{print $5,$3}'| sort -rfu | head -n 1 | awk '{split($0,addr,"
");print addr[1]}'` && \
LAST_SECTION_SIZE=`${CROSS_COMPILE}objdump -h vmlinux | grep "00*" |
awk '{print $5,$3}'| sort -rfu | head -n 1 | awk '{split($0,addr,"
")}'` && \
OFFSET_ADDR=$(( 16#$LAST_SECTION_SIZE + 16#$LAST_SECTION)) && \
printf "The LMA of the last section of the Kernel is 0x%X\n" ${OFFSET_ADDR}
```If the result is bigger than the default of FW_JUMP_FDT_ADDR(0x2200000), you must change it to avoid the problem of being overwritten.
Andrew Jones <[email protected]> ? 2022?8?11? ?? ??8:49???
Quoted 54 lines · Nylon Chen
Quoted 5 lines
From: "Nylon.Chen" <[email protected]>
A while ago.
when we boot from QEMU by OpenSBI Jump mode with initramfs kerenl.Quoted 7 lines
The kernel encountered panic because the kernel's section was overwritten, and the address was
FW_JUMP_FDT_ADDR.we find out the the rule
$(FW_TEXT_START) + 0x2200000inplatform/generic/config.mkThe situation is our kernel size big than it.
This implies opensbi is being used as a
FW_PAYLOADfirmware.Quoted 10 lines
e.g.
# readelf -h vmlinux init.bss's LMA is "0x00000000024a96a0", and when we use this rule, it exceeds its size.
0x24a96a0>0x2200000After our experiment, we can add offset
FW_JUMP_FDT_ADDR, and the problem is solved.Since this is a
FW_PAYLOADfirmware you should be adjustingFW_PAYLOAD_FDT_ADDR. AdjustingFW_JUMP_FDT_ADDRonly works because by defaultFW_PAYLOAD_FDT_ADDR=FW_JUMP_FDT_ADDR(for the generic platform).Quoted 3 lines
But in my opinion, this is not a good method because the next time the kernel size increases, the same situation occurs again.
I haven't tried it, but I think it should be possible to embed the FDT into the kernel (
CONFIG_BUILTIN_DTB) and then ensureFW_PAYLOAD_FDT_ADDRis *not* defined. Doing that will hopefully keep opensbi from overwriting the payload and linux will still find the DTB without looking at a1 for it. Taking that approach (if it works) would avoid having to adjustFW_PAYLOAD_FDT_ADDRfor different payload sizes.Quoted 3 lines
So maybe we can move the address forward and normalize the address to
FW_JUMP_FDT_ADDR?These types of defaults are impossible to get right for everybody. IMHO, what's there today should stay as is and we should work at making it as easy as possible to adjust at build- and/or run- time when necessary.
Thanks,
drew