Skip to contentSkip to conversation

netfilter: nf_tables: fix scheduling-while-atomic splat

PATCH Applied Florian Westphal 2 participants 2 messages Aug 11, 2022

Subsystems (2)
lore
Share & tools
lore

Florian Westphal

author maintainer
#0 lore raw

PATCH 1/1 netfilter: nf_tables: fix scheduling-while-atomic splat

nf_tables_check_loops() can be called from rhashtable list walk so cond_resched() cannot be used here.

Fixes 81ea01066741 ("netfilter: nf_tables: add rescheduling points during loop detection walks")
---
 net/netfilter/nf_tables_api.c | 4 ----
 1 file changed, 4 deletions(-)
net/netfilter/nf_tables_api.c +0 -4
index 3cc88998b879..210cbb9ea5d4 100644
@@ -9419,13 +9419,9 @@ static int nf_tables_check_loops(const struct nft_ctx *ctx,
 				break;
 			}
 		}
-
-		cond_resched();
 	}
 
 	list_for_each_entry(set, &ctx->table->sets, list) {
-		cond_resched();
-
 		if (!nft_is_active_next(ctx->net, set))
 			continue;
 		if (!(set->flags & NFT_SET_MAP) ||
Signature · 1 line
2.37.1
maintainer Applied
#1 lore raw
Quoted 2 lines · Florian Westphal

nf_tables_check_loops() can be called from rhashtable list walk so cond_resched() cannot be used here.

Applied, thanks