Skip to contentSkip to conversation

Expand amdgpu documentation

PATCH In review Rodrigo Siqueira 4 participants 8 messages Aug 11, 2022 – Aug 30, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v2 cover Expand amdgpu documentation

This patchset introduces some new AMDGPU documentation. You will find:

1. A CSV table that maps which component version is part of some ASIC

    families. This can be useful to narrow down bugs;

2. Some explanation about AMD Display Pipeline;
3. An explanation of Multiple Plane Overlay, which can be useful for userspace applications.

Since we have some diagrams, I recommend applying these patches and building the documentation to have a better experience.

In this new version, I just rebased this patchset with the latest code from amd-staging-drm-next, and I also changed patch 2.

Thanks
Siqueira

Rodrigo Siqueira (3):
Documentation/gpu: Add info table for ASICs Documentation/gpu: Add an explanation about the DCN pipeline Documentation/gpu: Add Multiplane Overlay doc

 .../gpu/amdgpu/apu-asic-info-table.csv        |    8 +
 .../gpu/amdgpu/dgpu-asic-info-table.csv       |   24 +
 .../gpu/amdgpu/display/dcn-overview.rst       |   59 +
 Documentation/gpu/amdgpu/display/index.rst    |    1 +
 .../gpu/amdgpu/display/mpo-cursor.svg         |  435 +++++++
 .../gpu/amdgpu/display/mpo-overview.rst       |  242 ++++
 .../multi-display-hdcp-mpo-less-pipe-ex.svg   |  220 ++++
 .../amdgpu/display/multi-display-hdcp-mpo.svg |  171 +++
 .../amdgpu/display/pipeline_4k_no_split.svg   |  958 +++++++++++++++
 .../gpu/amdgpu/display/pipeline_4k_split.svg  | 1062 +++++++++++++++++
 .../single-display-mpo-multi-video.svg        |  339 ++++++
 .../gpu/amdgpu/display/single-display-mpo.svg |  266 +++++
 Documentation/gpu/amdgpu/driver-misc.rst      |   17 +
 13 files changed, 3802 insertions(+)
 create mode 100644 Documentation/gpu/amdgpu/apu-asic-info-table.csv
 create mode 100644 Documentation/gpu/amdgpu/dgpu-asic-info-table.csv
 create mode 100644 Documentation/gpu/amdgpu/display/mpo-cursor.svg
 create mode 100644 Documentation/gpu/amdgpu/display/mpo-overview.rst
 create mode 100644 Documentation/gpu/amdgpu/display/multi-display-hdcp-mpo-less-pipe-ex.svg
 create mode 100644 Documentation/gpu/amdgpu/display/multi-display-hdcp-mpo.svg
 create mode 100644 Documentation/gpu/amdgpu/display/pipeline_4k_no_split.svg
 create mode 100644 Documentation/gpu/amdgpu/display/pipeline_4k_split.svg
 create mode 100644 Documentation/gpu/amdgpu/display/single-display-mpo-multi-video.svg
 create mode 100644 Documentation/gpu/amdgpu/display/single-display-mpo.svg
Signature · 1 line
2.35.1
#1 lore raw

PATCH v2 1/3 Documentation/gpu: Add info table for ASICs

Amdgpu driver is used in an extensive range of devices, and each ASIC has some specific configuration. As a result of this variety, sometimes it is hard to identify the correct block that might cause the issue. This commit expands the amdgpu kernel-doc to alleviate this issue by introducing one ASIC table that describes dGPU and another one that shares the APU info.

Cc Harry Wentland <[email protected]>
Cc Nicholas Kazlauskas <[email protected]>
Cc Bhawanpreet Lakha <[email protected]>
Cc Hersen Wu <[email protected]>
Cc Alex Hung <[email protected]>
Cc Pierre-Eric Pelloux-Prayer <[email protected]>
Cc Leo Li <[email protected]>
Cc Simon Ser <[email protected]>
Cc Pekka Paalanen <[email protected]>
Cc Sean Paul <[email protected]>
Cc Mark Yacoub <[email protected]>
Cc Pierre-Loup <[email protected]>
Cc Michel Dänzer <[email protected]>
Cc Kent Russell <[email protected]>
---
 .../gpu/amdgpu/apu-asic-info-table.csv        |  8 +++++++
 .../gpu/amdgpu/dgpu-asic-info-table.csv       | 24 +++++++++++++++++++
 Documentation/gpu/amdgpu/driver-misc.rst      | 17 +++++++++++++
 3 files changed, 49 insertions(+)
 create mode 100644 Documentation/gpu/amdgpu/apu-asic-info-table.csv
 create mode 100644 Documentation/gpu/amdgpu/dgpu-asic-info-table.csv
Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +8 -0
new file mode 100644
index 000000000000..98c6988e424e
@@ -0,0 +1,8 @@
+Product Name, Code Reference, DCN/DCE version, GC version, VCE/UVD/VCN version, SDMA version
+Radeon R* Graphics, CARRIZO/STONEY, DCE 11, 8, VCE 3 / UVD 6, 3
+Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx, RAVEN/PICASSO, DCN 1.0, 9.1.0, VCN 1.0, 4.1.0
+Ryzen 4000 series, RENOIR, DCN 2.1, 9.3, VCN 2.2, 4.1.2
+Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx, RAVEN2, DCN 1.0, 9.2.2, VCN 1.0.1, 4.1.1
+SteamDeck, VANGOGH, DCN 3.0.1, 10.3.1, VCN 3.1.0, 5.2.1
+Ryzen 5000 series, GREEN SARDINE, DCN 2.1, 9.3, VCN 2.2, 4.1.1
+Ryzen 6000 Zen, YELLOW CARP, 3.1.2, 10.3.3, VCN 3.1.1, 5.2.3
Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +24 -0
new file mode 100644
index 000000000000..84617aa35dab
@@ -0,0 +1,24 @@
+Product Name, Code Reference, DCN/DCE version, GC version, VCN version, SDMA version
+AMD Radeon (TM) HD 8500M/ 8600M /M200 /M320 /M330 /M335 Series, HAINAN, --,  6, --, --
+AMD Radeon HD 7800 /7900 /FireGL Series, TAHITI, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon R7 (TM|HD) M265 /M370 /8500M /8600 /8700 /8700M, OLAND, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon (TM) (HD|R7) 7800 /7970 /8800 /8970 /370/ Series, PITCAIRN, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon (TM|R7|R9|HD) E8860 /M360 /7700 /7800 /8800 /9000(M) /W4100 Series, VERDE, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon HD M280X /M380 /7700 /8950 /W5100, BONAIRE, DCE 8, 7, VCE 2 / UVD 4.2, 1
+AMD Radeon (R9|TM) 200 /390 /W8100 /W9100 Series, HAWAII, DCE 8, 7, VCE 2 / UVD 4.2, 1
+AMD Radeon (TM) R(5|7) M315 /M340 /M360, TOPAZ, *, 8, --, 2
+AMD Radeon (TM) R9 200 /380 /W7100 /S7150 /M390 /M395 Series, TONGA, DCE 10, 8, VCE 3 / UVD 5, 3
+AMD Radeon (FirePro) (TM) R9 Fury Series, FIJI, DCE 10, 8, VCE 3 / UVD 6, 3
+Radeon RX 470 /480 /570 /580 /590 Series - AMD Radeon (TM) (Pro WX) 5100 /E9390 /E9560 /E9565 /V7350 /7100 /P30PH, POLARIS10, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (TM) (RX|Pro WX) E9260 /460 /V5300X /550 /560(X) Series, POLARIS11, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (RX/Pro) 500 /540(X) /550 /640 /WX2100 /WX3100 /WX200 Series, POLARIS12, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (RX|TM) (PRO|WX) Vega /MI25 /V320 /V340L /8200 /9100 /SSG MxGPU, VEGA10, DCE 12, 9.0.1, VCE 4.0.0 / UVD 7.0.0, 4.0.0
+AMD Radeon (Pro) VII /MI50 /MI60, VEGA20, DCE 12, 9.4.0, VCE 4.1.0 / UVD 7.2.0, 4.2.0
+MI100, ARCTURUS, *, 9.4.1, VCN 2.5.0, 4.2.2
+MI200, ALDEBARAN, *, 9.4.2, VCN 2.6.0, 4.4.0
+AMD Radeon (RX|Pro) 5600(M|XT) /5700 (M|XT|XTB) /W5700, NAVI10, DCN 2.0.0, 10.1.10, VCN 2.0.0, 5.0.0
+AMD Radeon (Pro) 5300 /5500XTB/5500(XT|M) /W5500M /W5500, NAVI14, DCN 2.0.0, 10.1.1, VCN 2.0.2, 5.0.2
+AMD Radeon RX 6800(XT) /6900(XT) /W6800, SIENNA_CICHLID, DCN 3.0.0, 10.3.0, VCN 3.0.0, 5.2.0
+AMD Radeon RX 6700 XT / 6800M / 6700M, NAVY_FLOUNDER, DCN 3.0.0, 10.3.2, VCN 3.0.0, 5.2.2
+AMD Radeon RX 6600(XT) /6600M /W6600 /W6600M, DIMGREY_CAVEFISH, DCN 3.0.2, 10.3.4, VCN 3.0.16, 5.2.4
+AMD Radeon RX 6500M /6300M /W6500M /W6300M, BEIGE_GOBY, DCN 3.0.3, 10.3.5, VCN 3.0.33, 5.2.5
Documentation/gpu/amdgpu/driver-misc.rst +17 -0
index e3d6b2fa2493..1800543d45f7 100644
@@ -32,6 +32,23 @@ unique_id
 .. kernel-doc:: drivers/gpu/drm/amd/pm/amdgpu_pm.c
    :doc: unique_id
 
+Accelerated Processing Units (APU) Info
+---------------------------------------
+
+.. csv-table::
+   :header-rows: 1
+   :widths: 3, 2, 2, 1, 1, 1
+   :file: ./apu-asic-info-table.csv
+
+Discrete GPU Info
+-----------------
+
+.. csv-table::
+   :header-rows: 1
+   :widths: 3, 2, 2, 1, 1, 1
+   :file: ./dgpu-asic-info-table.csv
+
+
 GPU Memory Usage Information
 ============================
 
Signature · 1 line
2.35.1
#2 lore raw

RE: [PATCH v2 1/3] Documentation/gpu: Add info table for ASICs

[AMD Official Use Only - General]

I noticed that you added DCE and VCE/UVD prefixes in the columns, but not GC or SDMA. E.g.
CHIP DCE GC VCE SDMA
BONAIRE DCE 8 7 VCE 2 / UVD 4.2 1

For consistency, should we drop the DCE/VCE/UVD prefixes and add a separate UVD column, so it's just:
CHIP DCE GC VCE UVD SDMA
BONAIRE 8 7 VCE 2 4.2 1
? I know that from a compute perspective, I'd like to have the columns represent the fields, so there's less to parse through, but I am not a display guy so the DCE/VCE/UVD relationship is a mystery to me.

Also, for VG10 you have SDMA 4.0.0, but Polaris it's SDMA 3 . Again, just consistency with trailing decimals. I don't know if that's just because we didn't do point releases on SDMA <4 or whatnot, but it's something I observed.

I am not staunchly steadfast one way or another, I just wanted to hear rationale for it. Especially if we're maintaining it going forward, and for when someone inevitably starts parsing it via automated script and needs consistency. If you're confident in the format and can justify it, then that's sufficient for me.

Kent

Quoted 146 lines

-----Original Message-----
From: Siqueira, Rodrigo <[email protected]>
Sent: Thursday, August 11, 2022 11:48 AM
To: [email protected]
Cc: Wentland, Harry <[email protected]>; Kazlauskas, Nicholas <[email protected]>; Lakha, Bhawanpreet <[email protected]>; Wu, Hersen <[email protected]>; Hung, Alex <[email protected]>; Pelloux-Prayer, Pierre-Eric <Pierre- [email protected]>; Li, Sun peng (Leo) <[email protected]>; Simon Ser <[email protected]>; Pekka Paalanen <[email protected]>; Sean Paul <[email protected]>; Mark Yacoub <[email protected]>; Pierre-Loup <[email protected]>; Michel Dänzer <[email protected]>; Russell, Kent <[email protected]>
Subject: [PATCH v2 1/3] Documentation/gpu: Add info table for ASICs

Amdgpu driver is used in an extensive range of devices, and each ASIC has some specific configuration. As a result of this variety, sometimes it is hard to identify the correct block that might cause the issue. This commit expands the amdgpu kernel-doc to alleviate this issue by introducing one ASIC table that describes dGPU and another one that shares the APU info.

Cc Harry Wentland <[email protected]>
Cc Nicholas Kazlauskas <[email protected]>
Cc Bhawanpreet Lakha <[email protected]>
Cc Hersen Wu <[email protected]>
Cc Alex Hung <[email protected]>
Cc Pierre-Eric Pelloux-Prayer <[email protected]>
Cc Leo Li <[email protected]>
Cc Simon Ser <[email protected]>
Cc Pekka Paalanen <[email protected]>
Cc Sean Paul <[email protected]>
Cc Mark Yacoub <[email protected]>
Cc Pierre-Loup <[email protected]>
Cc Michel Dänzer <[email protected]>
Cc Kent Russell <[email protected]>
---
 .../gpu/amdgpu/apu-asic-info-table.csv        |  8 +++++++
 .../gpu/amdgpu/dgpu-asic-info-table.csv       | 24 +++++++++++++++++++
 Documentation/gpu/amdgpu/driver-misc.rst      | 17 +++++++++++++
 3 files changed, 49 insertions(+)
 create mode 100644 Documentation/gpu/amdgpu/apu-asic-info-table.csv
 create mode 100644 Documentation/gpu/amdgpu/dgpu-asic-info-table.csv
Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +1 -0
new file mode 100644
index 000000000000..98c6988e424e
@@ -0,0 +1,8 @@
+Product Name, Code Reference, DCN/DCE version, GC version, VCE/UVD/VCN

version, SDMA version

Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +2 -0
+Radeon R* Graphics, CARRIZO/STONEY, DCE 11, 8, VCE 3 / UVD 6, 3
+Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx,

RAVEN/PICASSO, DCN 1.0, 9.1.0, VCN 1.0, 4.1.0

Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +2 -0
+Ryzen 4000 series, RENOIR, DCN 2.1, 9.3, VCN 2.2, 4.1.2
+Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx,

RAVEN2, DCN 1.0, 9.2.2, VCN 1.0.1, 4.1.1

Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +3 -0
+SteamDeck, VANGOGH, DCN 3.0.1, 10.3.1, VCN 3.1.0, 5.2.1
+Ryzen 5000 series, GREEN SARDINE, DCN 2.1, 9.3, VCN 2.2, 4.1.1
+Ryzen 6000 Zen, YELLOW CARP, 3.1.2, 10.3.3, VCN 3.1.1, 5.2.3
Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +1 -0
new file mode 100644
index 000000000000..84617aa35dab
@@ -0,0 +1,24 @@
+Product Name, Code Reference, DCN/DCE version, GC version, VCN version,

SDMA version
+AMD Radeon (TM) HD 8500M/ 8600M /M200 /M320 /M330 /M335 Series, HAINAN, --, 6, --, --

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +2 -0
+AMD Radeon HD 7800 /7900 /FireGL Series, TAHITI, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon R7 (TM|HD) M265 /M370 /8500M /8600 /8700 /8700M, OLAND,

DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon (TM) (HD|R7) 7800 /7970 /8800 /8970 /370/ Series, PITCAIRN, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon (TM|R7|R9|HD) E8860 /M360 /7700 /7800 /8800 /9000(M) /W4100 Series, VERDE, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon HD M280X /M380 /7700 /8950 /W5100, BONAIRE, DCE 8, 7, VCE 2 / UVD 4.2, 1
+AMD Radeon (R9|TM) 200 /390 /W8100 /W9100 Series, HAWAII, DCE 8, 7, VCE 2 / UVD 4.2, 1

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +2 -0
+AMD Radeon (TM) R(5|7) M315 /M340 /M360, TOPAZ, *, 8, --, 2
+AMD Radeon (TM) R9 200 /380 /W7100 /S7150 /M390 /M395 Series, TONGA,

DCE 10, 8, VCE 3 / UVD 5, 3

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +2 -0
+AMD Radeon (FirePro) (TM) R9 Fury Series, FIJI, DCE 10, 8, VCE 3 / UVD 6, 3
+Radeon RX 470 /480 /570 /580 /590 Series - AMD Radeon (TM) (Pro WX) 5100

/E9390 /E9560 /E9565 /V7350 /7100 /P30PH, POLARIS10, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (TM) (RX|Pro WX) E9260 /460 /V5300X /550 /560(X) Series, POLARIS11, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (RX/Pro) 500 /540(X) /550 /640 /WX2100 /WX3100 /WX200 Series, POLARIS12, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (RX|TM) (PRO|WX) Vega /MI25 /V320 /V340L /8200 /9100 /SSG MxGPU, VEGA10, DCE 12, 9.0.1, VCE 4.0.0 / UVD 7.0.0, 4.0.0
+AMD Radeon (Pro) VII /MI50 /MI60, VEGA20, DCE 12, 9.4.0, VCE 4.1.0 / UVD 7.2.0, 4.2.0

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +3 -0
+MI100, ARCTURUS, *, 9.4.1, VCN 2.5.0, 4.2.2
+MI200, ALDEBARAN, *, 9.4.2, VCN 2.6.0, 4.4.0
+AMD Radeon (RX|Pro) 5600(M|XT) /5700 (M|XT|XTB) /W5700, NAVI10, DCN

2.0.0, 10.1.10, VCN 2.0.0, 5.0.0
+AMD Radeon (Pro) 5300 /5500XTB/5500(XT|M) /W5500M /W5500, NAVI14, DCN 2.0.0, 10.1.1, VCN 2.0.2, 5.0.2
+AMD Radeon RX 6800(XT) /6900(XT) /W6800, SIENNA_CICHLID, DCN 3.0.0, 10.3.0, VCN 3.0.0, 5.2.0
+AMD Radeon RX 6700 XT / 6800M / 6700M, NAVY_FLOUNDER, DCN 3.0.0, 10.3.2, VCN 3.0.0, 5.2.2
+AMD Radeon RX 6600(XT) /6600M /W6600 /W6600M, DIMGREY_CAVEFISH, DCN 3.0.2, 10.3.4, VCN 3.0.16, 5.2.4
+AMD Radeon RX 6500M /6300M /W6500M /W6300M, BEIGE_GOBY, DCN 3.0.3, 10.3.5, VCN 3.0.33, 5.2.5

Documentation/gpu/amdgpu/driver-misc.rst +17 -1
index e3d6b2fa2493..1800543d45f7 100644
@@ -32,6 +32,23 @@ unique_id
 .. kernel-doc:: drivers/gpu/drm/amd/pm/amdgpu_pm.c
    :doc: unique_id
 
+Accelerated Processing Units (APU) Info
+---------------------------------------
+
+.. csv-table::
+   :header-rows: 1
+   :widths: 3, 2, 2, 1, 1, 1
+   :file: ./apu-asic-info-table.csv
+
+Discrete GPU Info
+-----------------
+
+.. csv-table::
+   :header-rows: 1
+   :widths: 3, 2, 2, 1, 1, 1
+   :file: ./dgpu-asic-info-table.csv
+
+
 GPU Memory Usage Information
 ============================
 
--

2.35.1

#3 lore raw

Re: [PATCH v2 1/3] Documentation/gpu: Add info table for ASICs

Hi Kent,

First of all, thanks for your feedback.
See my comments inline.

Quoted 7 lines · Kent

[AMD Official Use Only - General]

I noticed that you added DCE and VCE/UVD prefixes in the columns, but not GC or SDMA. E.g.
CHIP DCE GC VCE SDMA
BONAIRE DCE 8 7 VCE 2 / UVD 4.2 1

Are you referencing when I added it in some specific lines? If so, I added it because we may have a different architecture for the same area. For example, DCE is our old display architecture, and we replaced it with DCN. That's why I added DCE/DCN in the label, and in the ASIC description, I specify if it is a DCE or DCN.

Quoted 1 line

For consistency, should we drop the DCE/VCE/UVD prefixes and add a separate UVD column, so it's just:

Iirc UVD is the previous version of VCE; in that case, I think they should be grouped. Or is UVD a different component?

Quoted 5 lines

CHIP DCE GC VCE UVD SDMA
BONAIRE 8 7 VCE 2 4.2 1
? I know that from a compute perspective, I'd like to have the columns represent the fields, so there's less to parse through, but I am not a display guy so the DCE/VCE/UVD relationship is a mystery to me.

Also, for VG10 you have SDMA 4.0.0, but Polaris it's SDMA 3 . Again, just consistency with trailing decimals. I don't know if that's just because we didn't do point releases on SDMA <4 or whatnot, but it's something I observed.

I also don't know if we have a good reason for not using the decimal part, but I can add it to all components if it makes sense. Maybe Alex know?

Thanks
Siqueira

Quoted 151 lines

I am not staunchly steadfast one way or another, I just wanted to hear rationale for it. Especially if we're maintaining it going forward, and for when someone inevitably starts parsing it via automated script and needs consistency. If you're confident in the format and can justify it, then that's sufficient for me.

Kent

Quoted 146 lines

-----Original Message-----
From: Siqueira, Rodrigo <[email protected]>
Sent: Thursday, August 11, 2022 11:48 AM
To: [email protected]
Cc: Wentland, Harry <[email protected]>; Kazlauskas, Nicholas <[email protected]>; Lakha, Bhawanpreet <[email protected]>; Wu, Hersen <[email protected]>; Hung, Alex <[email protected]>; Pelloux-Prayer, Pierre-Eric <Pierre- [email protected]>; Li, Sun peng (Leo) <[email protected]>; Simon Ser <[email protected]>; Pekka Paalanen <[email protected]>; Sean Paul <[email protected]>; Mark Yacoub <[email protected]>; Pierre-Loup <[email protected]>; Michel Dänzer <[email protected]>; Russell, Kent <[email protected]>
Subject: [PATCH v2 1/3] Documentation/gpu: Add info table for ASICs

Amdgpu driver is used in an extensive range of devices, and each ASIC has some specific configuration. As a result of this variety, sometimes it is hard to identify the correct block that might cause the issue. This commit expands the amdgpu kernel-doc to alleviate this issue by introducing one ASIC table that describes dGPU and another one that shares the APU info.

Cc Harry Wentland <[email protected]>
Cc Nicholas Kazlauskas <[email protected]>
Cc Bhawanpreet Lakha <[email protected]>
Cc Hersen Wu <[email protected]>
Cc Alex Hung <[email protected]>
Cc Pierre-Eric Pelloux-Prayer <[email protected]>
Cc Leo Li <[email protected]>
Cc Simon Ser <[email protected]>
Cc Pekka Paalanen <[email protected]>
Cc Sean Paul <[email protected]>
Cc Mark Yacoub <[email protected]>
Cc Pierre-Loup <[email protected]>
Cc Michel Dänzer <[email protected]>
Cc Kent Russell <[email protected]>
---
  .../gpu/amdgpu/apu-asic-info-table.csv        |  8 +++++++
  .../gpu/amdgpu/dgpu-asic-info-table.csv       | 24 +++++++++++++++++++
  Documentation/gpu/amdgpu/driver-misc.rst      | 17 +++++++++++++
  3 files changed, 49 insertions(+)

create mode 100644 Documentation/gpu/amdgpu/apu-asic-info-table.csv create mode 100644 Documentation/gpu/amdgpu/dgpu-asic-info-table.csv

Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +1 -0
new file mode 100644
index 000000000000..98c6988e424e
@@ -0,0 +1,8 @@
+Product Name, Code Reference, DCN/DCE version, GC version, VCE/UVD/VCN

version, SDMA version

Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +2 -0
+Radeon R* Graphics, CARRIZO/STONEY, DCE 11, 8, VCE 3 / UVD 6, 3
+Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx,

RAVEN/PICASSO, DCN 1.0, 9.1.0, VCN 1.0, 4.1.0

Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +2 -0
+Ryzen 4000 series, RENOIR, DCN 2.1, 9.3, VCN 2.2, 4.1.2
+Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx,

RAVEN2, DCN 1.0, 9.2.2, VCN 1.0.1, 4.1.1

Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +3 -0
+SteamDeck, VANGOGH, DCN 3.0.1, 10.3.1, VCN 3.1.0, 5.2.1
+Ryzen 5000 series, GREEN SARDINE, DCN 2.1, 9.3, VCN 2.2, 4.1.1
+Ryzen 6000 Zen, YELLOW CARP, 3.1.2, 10.3.3, VCN 3.1.1, 5.2.3
Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +1 -0
new file mode 100644
index 000000000000..84617aa35dab
@@ -0,0 +1,24 @@
+Product Name, Code Reference, DCN/DCE version, GC version, VCN version,

SDMA version
+AMD Radeon (TM) HD 8500M/ 8600M /M200 /M320 /M330 /M335 Series, HAINAN, --, 6, --, --

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +2 -0
+AMD Radeon HD 7800 /7900 /FireGL Series, TAHITI, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon R7 (TM|HD) M265 /M370 /8500M /8600 /8700 /8700M, OLAND,

DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon (TM) (HD|R7) 7800 /7970 /8800 /8970 /370/ Series, PITCAIRN, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon (TM|R7|R9|HD) E8860 /M360 /7700 /7800 /8800 /9000(M) /W4100 Series, VERDE, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon HD M280X /M380 /7700 /8950 /W5100, BONAIRE, DCE 8, 7, VCE 2 / UVD 4.2, 1
+AMD Radeon (R9|TM) 200 /390 /W8100 /W9100 Series, HAWAII, DCE 8, 7, VCE 2 / UVD 4.2, 1

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +2 -0
+AMD Radeon (TM) R(5|7) M315 /M340 /M360, TOPAZ, *, 8, --, 2
+AMD Radeon (TM) R9 200 /380 /W7100 /S7150 /M390 /M395 Series, TONGA,

DCE 10, 8, VCE 3 / UVD 5, 3

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +2 -0
+AMD Radeon (FirePro) (TM) R9 Fury Series, FIJI, DCE 10, 8, VCE 3 / UVD 6, 3
+Radeon RX 470 /480 /570 /580 /590 Series - AMD Radeon (TM) (Pro WX) 5100

/E9390 /E9560 /E9565 /V7350 /7100 /P30PH, POLARIS10, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (TM) (RX|Pro WX) E9260 /460 /V5300X /550 /560(X) Series, POLARIS11, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (RX/Pro) 500 /540(X) /550 /640 /WX2100 /WX3100 /WX200 Series, POLARIS12, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (RX|TM) (PRO|WX) Vega /MI25 /V320 /V340L /8200 /9100 /SSG MxGPU, VEGA10, DCE 12, 9.0.1, VCE 4.0.0 / UVD 7.0.0, 4.0.0
+AMD Radeon (Pro) VII /MI50 /MI60, VEGA20, DCE 12, 9.4.0, VCE 4.1.0 / UVD 7.2.0, 4.2.0

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +3 -0
+MI100, ARCTURUS, *, 9.4.1, VCN 2.5.0, 4.2.2
+MI200, ALDEBARAN, *, 9.4.2, VCN 2.6.0, 4.4.0
+AMD Radeon (RX|Pro) 5600(M|XT) /5700 (M|XT|XTB) /W5700, NAVI10, DCN

2.0.0, 10.1.10, VCN 2.0.0, 5.0.0
+AMD Radeon (Pro) 5300 /5500XTB/5500(XT|M) /W5500M /W5500, NAVI14, DCN 2.0.0, 10.1.1, VCN 2.0.2, 5.0.2
+AMD Radeon RX 6800(XT) /6900(XT) /W6800, SIENNA_CICHLID, DCN 3.0.0, 10.3.0, VCN 3.0.0, 5.2.0
+AMD Radeon RX 6700 XT / 6800M / 6700M, NAVY_FLOUNDER, DCN 3.0.0, 10.3.2, VCN 3.0.0, 5.2.2
+AMD Radeon RX 6600(XT) /6600M /W6600 /W6600M, DIMGREY_CAVEFISH, DCN 3.0.2, 10.3.4, VCN 3.0.16, 5.2.4
+AMD Radeon RX 6500M /6300M /W6500M /W6300M, BEIGE_GOBY, DCN 3.0.3, 10.3.5, VCN 3.0.33, 5.2.5

Documentation/gpu/amdgpu/driver-misc.rst +17 -1
index e3d6b2fa2493..1800543d45f7 100644
@@ -32,6 +32,23 @@ unique_id
  .. kernel-doc:: drivers/gpu/drm/amd/pm/amdgpu_pm.c
     :doc: unique_id
 
+Accelerated Processing Units (APU) Info
+---------------------------------------
+
+.. csv-table::
+   :header-rows: 1
+   :widths: 3, 2, 2, 1, 1, 1
+   :file: ./apu-asic-info-table.csv
+
+Discrete GPU Info
+-----------------
+
+.. csv-table::
+   :header-rows: 1
+   :widths: 3, 2, 2, 1, 1, 1
+   :file: ./dgpu-asic-info-table.csv
+
+
  GPU Memory Usage Information
  ============================
 
--

2.35.1

#4 lore raw

Re: [PATCH v2 1/3] Documentation/gpu: Add info table for ASICs

Quoted 21 lines · Rodrigo Siqueira Jordao

Hi Kent,

First of all, thanks for your feedback.
See my comments inline.

Quoted 7 lines · Kent

[AMD Official Use Only - General]

I noticed that you added DCE and VCE/UVD prefixes in the columns, but not GC or SDMA. E.g.
CHIP DCE GC VCE SDMA
BONAIRE DCE 8 7 VCE 2 / UVD 4.2 1

Are you referencing when I added it in some specific lines? If so, I added it because we may have a different architecture for the same area. For example, DCE is our old display architecture, and we replaced it with DCN. That's why I added DCE/DCN in the label, and in the ASIC description, I specify if it is a DCE or DCN.

Quoted 4 lines
Quoted 1 line

For consistency, should we drop the DCE/VCE/UVD prefixes and add a separate UVD column, so it's just:

Iirc UVD is the previous version of VCE; in that case, I think they should be grouped. Or is UVD a different component?

DCE was the old display IP and it was replaced with DCN. UVD/VCE where the old video decode/encode IPs and they were replaced with VCN.

Quoted 9 lines
Quoted 6 lines

CHIP DCE GC VCE UVD SDMA
BONAIRE 8 7 VCE 2 4.2 1
? I know that from a compute perspective, I'd like to have the columns represent the fields, so there's less to parse through, but I am not a display guy so the DCE/VCE/UVD relationship is a mystery to me.

Also, for VG10 you have SDMA 4.0.0, but Polaris it's SDMA 3 . Again, just consistency with trailing decimals. I don't know if that's just because we didn't do point releases on SDMA <4 or whatnot, but it's something I observed.

I also don't know if we have a good reason for not using the decimal part, but I can add it to all components if it makes sense. Maybe Alex know?

The old parts didn't really have well enumerated IP minor versions like we do today. We could make up minor/rev numbers, but we don't really have them in most cases. We could do something like 8.x or 7.x if you think that is clearer.

Alex

Quoted 156 lines

Thanks
Siqueira

Quoted 151 lines

I am not staunchly steadfast one way or another, I just wanted to hear rationale for it. Especially if we're maintaining it going forward, and for when someone inevitably starts parsing it via automated script and needs consistency. If you're confident in the format and can justify it, then that's sufficient for me.

Kent

Quoted 146 lines

-----Original Message-----
From: Siqueira, Rodrigo <[email protected]>
Sent: Thursday, August 11, 2022 11:48 AM
To: [email protected]
Cc: Wentland, Harry <[email protected]>; Kazlauskas, Nicholas <[email protected]>; Lakha, Bhawanpreet <[email protected]>; Wu, Hersen <[email protected]>; Hung, Alex <[email protected]>; Pelloux-Prayer, Pierre-Eric <Pierre- [email protected]>; Li, Sun peng (Leo) <[email protected]>; Simon Ser <[email protected]>; Pekka Paalanen <[email protected]>; Sean Paul <[email protected]>; Mark Yacoub <[email protected]>; Pierre-Loup <[email protected]>; Michel Dänzer <[email protected]>; Russell, Kent <[email protected]>
Subject: [PATCH v2 1/3] Documentation/gpu: Add info table for ASICs

Amdgpu driver is used in an extensive range of devices, and each ASIC has some specific configuration. As a result of this variety, sometimes it is hard to identify the correct block that might cause the issue. This commit expands the amdgpu kernel-doc to alleviate this issue by introducing one ASIC table that describes dGPU and another one that shares the APU info.

Cc Harry Wentland <[email protected]>
Cc Nicholas Kazlauskas <[email protected]>
Cc Bhawanpreet Lakha <[email protected]>
Cc Hersen Wu <[email protected]>
Cc Alex Hung <[email protected]>
Cc Pierre-Eric Pelloux-Prayer <[email protected]>
Cc Leo Li <[email protected]>
Cc Simon Ser <[email protected]>
Cc Pekka Paalanen <[email protected]>
Cc Sean Paul <[email protected]>
Cc Mark Yacoub <[email protected]>
Cc Pierre-Loup <[email protected]>
Cc Michel Dänzer <[email protected]>
Cc Kent Russell <[email protected]>
---
  .../gpu/amdgpu/apu-asic-info-table.csv        |  8 +++++++
  .../gpu/amdgpu/dgpu-asic-info-table.csv       | 24 +++++++++++++++++++
  Documentation/gpu/amdgpu/driver-misc.rst      | 17 +++++++++++++
  3 files changed, 49 insertions(+)

create mode 100644 Documentation/gpu/amdgpu/apu-asic-info-table.csv create mode 100644 Documentation/gpu/amdgpu/dgpu-asic-info-table.csv

Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +1 -0
new file mode 100644
index 000000000000..98c6988e424e
@@ -0,0 +1,8 @@
+Product Name, Code Reference, DCN/DCE version, GC version, VCE/UVD/VCN

version, SDMA version

Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +2 -0
+Radeon R* Graphics, CARRIZO/STONEY, DCE 11, 8, VCE 3 / UVD 6, 3
+Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx,

RAVEN/PICASSO, DCN 1.0, 9.1.0, VCN 1.0, 4.1.0

Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +2 -0
+Ryzen 4000 series, RENOIR, DCN 2.1, 9.3, VCN 2.2, 4.1.2
+Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx,

RAVEN2, DCN 1.0, 9.2.2, VCN 1.0.1, 4.1.1

Documentation/gpu/amdgpu/apu-asic-info-table.csv new file +3 -0
+SteamDeck, VANGOGH, DCN 3.0.1, 10.3.1, VCN 3.1.0, 5.2.1
+Ryzen 5000 series, GREEN SARDINE, DCN 2.1, 9.3, VCN 2.2, 4.1.1
+Ryzen 6000 Zen, YELLOW CARP, 3.1.2, 10.3.3, VCN 3.1.1, 5.2.3
Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +1 -0
new file mode 100644
index 000000000000..84617aa35dab
@@ -0,0 +1,24 @@
+Product Name, Code Reference, DCN/DCE version, GC version, VCN version,

SDMA version
+AMD Radeon (TM) HD 8500M/ 8600M /M200 /M320 /M330 /M335 Series, HAINAN, --, 6, --, --

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +2 -0
+AMD Radeon HD 7800 /7900 /FireGL Series, TAHITI, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon R7 (TM|HD) M265 /M370 /8500M /8600 /8700 /8700M, OLAND,

DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon (TM) (HD|R7) 7800 /7970 /8800 /8970 /370/ Series, PITCAIRN, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon (TM|R7|R9|HD) E8860 /M360 /7700 /7800 /8800 /9000(M) /W4100 Series, VERDE, DCE 6, 6, VCE 1 / UVD 3, --
+AMD Radeon HD M280X /M380 /7700 /8950 /W5100, BONAIRE, DCE 8, 7, VCE 2 / UVD 4.2, 1
+AMD Radeon (R9|TM) 200 /390 /W8100 /W9100 Series, HAWAII, DCE 8, 7, VCE 2 / UVD 4.2, 1

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +2 -0
+AMD Radeon (TM) R(5|7) M315 /M340 /M360, TOPAZ, *, 8, --, 2
+AMD Radeon (TM) R9 200 /380 /W7100 /S7150 /M390 /M395 Series, TONGA,

DCE 10, 8, VCE 3 / UVD 5, 3

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +2 -0
+AMD Radeon (FirePro) (TM) R9 Fury Series, FIJI, DCE 10, 8, VCE 3 / UVD 6, 3
+Radeon RX 470 /480 /570 /580 /590 Series - AMD Radeon (TM) (Pro WX) 5100

/E9390 /E9560 /E9565 /V7350 /7100 /P30PH, POLARIS10, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (TM) (RX|Pro WX) E9260 /460 /V5300X /550 /560(X) Series, POLARIS11, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (RX/Pro) 500 /540(X) /550 /640 /WX2100 /WX3100 /WX200 Series, POLARIS12, DCE 11.2, 8, VCE 3.4 / UVD 6.3, 3
+Radeon (RX|TM) (PRO|WX) Vega /MI25 /V320 /V340L /8200 /9100 /SSG MxGPU, VEGA10, DCE 12, 9.0.1, VCE 4.0.0 / UVD 7.0.0, 4.0.0
+AMD Radeon (Pro) VII /MI50 /MI60, VEGA20, DCE 12, 9.4.0, VCE 4.1.0 / UVD 7.2.0, 4.2.0

Documentation/gpu/amdgpu/dgpu-asic-info-table.csv new file +3 -0
+MI100, ARCTURUS, *, 9.4.1, VCN 2.5.0, 4.2.2
+MI200, ALDEBARAN, *, 9.4.2, VCN 2.6.0, 4.4.0
+AMD Radeon (RX|Pro) 5600(M|XT) /5700 (M|XT|XTB) /W5700, NAVI10, DCN

2.0.0, 10.1.10, VCN 2.0.0, 5.0.0
+AMD Radeon (Pro) 5300 /5500XTB/5500(XT|M) /W5500M /W5500, NAVI14, DCN 2.0.0, 10.1.1, VCN 2.0.2, 5.0.2
+AMD Radeon RX 6800(XT) /6900(XT) /W6800, SIENNA_CICHLID, DCN 3.0.0, 10.3.0, VCN 3.0.0, 5.2.0
+AMD Radeon RX 6700 XT / 6800M / 6700M, NAVY_FLOUNDER, DCN 3.0.0, 10.3.2, VCN 3.0.0, 5.2.2
+AMD Radeon RX 6600(XT) /6600M /W6600 /W6600M, DIMGREY_CAVEFISH, DCN 3.0.2, 10.3.4, VCN 3.0.16, 5.2.4
+AMD Radeon RX 6500M /6300M /W6500M /W6300M, BEIGE_GOBY, DCN 3.0.3, 10.3.5, VCN 3.0.33, 5.2.5

Documentation/gpu/amdgpu/driver-misc.rst +17 -1
index e3d6b2fa2493..1800543d45f7 100644
@@ -32,6 +32,23 @@ unique_id
  .. kernel-doc:: drivers/gpu/drm/amd/pm/amdgpu_pm.c
     :doc: unique_id
 
+Accelerated Processing Units (APU) Info
+---------------------------------------
+
+.. csv-table::
+   :header-rows: 1
+   :widths: 3, 2, 2, 1, 1, 1
+   :file: ./apu-asic-info-table.csv
+
+Discrete GPU Info
+-----------------
+
+.. csv-table::
+   :header-rows: 1
+   :widths: 3, 2, 2, 1, 1, 1
+   :file: ./dgpu-asic-info-table.csv
+
+
  GPU Memory Usage Information
  ============================
 
--

2.35.1

#5 lore raw

PATCH v2 2/3 Documentation/gpu: Add an explanation about the DCN pipeline

In reply to Rodrigo Siqueira

In the DCN code, we constantly talk about hardware pipeline, pipeline, or even just pipes, which is a concept that is not obvious to everyone. For this reason, this commit expands the DCN overview explanation by adding a new section that describes what a pipeline is from the DCN perspective.

Changes since V1:
- Rewrite the first paragraph that describes AMD hardware pipeline.

Cc Harry Wentland <[email protected]>
Cc Nicholas Kazlauskas <[email protected]>
Cc Bhawanpreet Lakha <[email protected]>
Cc Hersen Wu <[email protected]>
Cc Alex Hung <[email protected]>
Cc Pierre-Eric Pelloux-Prayer <[email protected]>
Cc Leo Li <[email protected]>
Cc Simon Ser <[email protected]>
Cc Pekka Paalanen <[email protected]>
Cc Sean Paul <[email protected]>
Cc Mark Yacoub <[email protected]>
Cc Pierre-Loup <[email protected]>
Cc Michel Dänzer <[email protected]>
---
 .../gpu/amdgpu/display/dcn-overview.rst       |   59 +
 .../amdgpu/display/pipeline_4k_no_split.svg   |  958 +++++++++++++++
 .../gpu/amdgpu/display/pipeline_4k_split.svg  | 1062 +++++++++++++++++
 3 files changed, 2079 insertions(+)
 create mode 100644 Documentation/gpu/amdgpu/display/pipeline_4k_no_split.svg
 create mode 100644 Documentation/gpu/amdgpu/display/pipeline_4k_split.svg
Documentation/gpu/amdgpu/display/dcn-overview.rst +59 -0
index f98624d7828e..9fea6500448b 100644
@@ -124,6 +124,65 @@ depth format), bit-depth reduction/dithering would kick in. In OPP, we would
 also apply a regamma function to introduce the gamma removed earlier back.
 Eventually, we output data in integer format at DIO.
 
+AMD Hardware Pipeline
+---------------------
+
+When discussing graphics on Linux, the **pipeline** term can sometimes be
+overloaded with multiple meanings, so it is important to define what we mean
+when we say **pipeline**. In the DCN driver, we use the term **hardware
+pipeline** or **pipeline** or just **pipe** as an abstraction to indicate a
+sequence of DCN blocks instantiated to address some specific configuration. DC
+core treats DCN blocks as individual resources, meaning we can build a pipeline
+by taking resources for all individual hardware blocks to compose one pipeline.
+In actuality, we can't connect an arbitrary block from one pipe to a block from
+another pipe; they are routed linearly, except for DSC, which can be
+arbitrarily assigned as needed. We have this pipeline concept for trying to
+optimize bandwidth utilization.
+
+.. kernel-figure:: pipeline_4k_no_split.svg
+
+Additionally, let's take a look at parts of the DTN log (see
+'Documentation/gpu/amdgpu/display/dc-debug.rst' for more information) since
+this log can help us to see part of this pipeline behavior in real-time::
+
+ HUBP:  format  addr_hi  width  height ...
+ [ 0]:      8h      81h   3840    2160
+ [ 1]:      0h       0h      0       0
+ [ 2]:      0h       0h      0       0
+ [ 3]:      0h       0h      0       0
+ [ 4]:      0h       0h      0       0
+ ...
+ MPCC:  OPP  DPP ...
+ [ 0]:   0h   0h ...
+
+The first thing to notice from the diagram and DTN log it is the fact that we
+have different clock domains for each part of the DCN blocks. In this example,
+we have just a single **pipeline** where the data flows from DCHUB to DIO, as
+we intuitively expect. Nonetheless, DCN is flexible, as mentioned before, and
+we can split this single pipe differently, as described in the below diagram:
+
+.. kernel-figure:: pipeline_4k_split.svg
+
+Now, if we inspect the DTN log again we can see some interesting changes::
+
+ HUBP:  format  addr_hi  width  height ...
+ [ 0]:      8h      81h   1920    2160 ...
+ ...
+ [ 4]:      0h       0h      0       0 ...
+ [ 5]:      8h      81h   1920    2160 ...
+ ...
+ MPCC:  OPP  DPP ...
+ [ 0]:   0h   0h ...
+ [ 5]:   0h   5h ...
+
+From the above example, we now split the display pipeline into two vertical
+parts of 1920x2160 (i.e., 3440x2160), and as a result, we could reduce the
+clock frequency in the DPP part. This is not only useful for saving power but
+also to better handle the required throughput. The idea to keep in mind here is
+that the pipe configuration can vary a lot according to the display
+configuration, and it is the DML's responsibility to set up all required
+configuration parameters for multiple scenarios supported by our hardware.
+
 Global Sync
 -----------
 
Documentation/gpu/amdgpu/display/pipeline_4k_no_split.svg new file +958 -0

958 lines not on this page · raw message

Documentation/gpu/amdgpu/display/pipeline_4k_split.svg new file +1062 -0

1,062 lines not on this page · raw message

Signature · 1 line
2.35.1
#6 lore raw

PATCH v2 3/3 Documentation/gpu: Add Multiplane Overlay doc

In reply to Rodrigo Siqueira

Multiple plane overlay is a feature supported by AMD hardware, but it has specific details that deserve proper documentation. This commit introduces a documentation that describes some of the features, limitations, and use cases for this feature. Part of this documentation came from some discussion in the public upstream [1][2].

[1]. https://lore.kernel.org/amd-gfx/3qY-QeukF_Q_MJeIXAuBjO4szbS4jRtqkTifXnbnN3bp88SxVodFQRpah3mIIVJq24DUkF6g0rOGdCmSqTvVxx9LCGEItmzLw8uWU44jtXE=@emersion.fr/
[2]. https://lore.kernel.org/amd-gfx/[email protected]/

Cc Harry Wentland <[email protected]>
Cc Nicholas Kazlauskas <[email protected]>
Cc Bhawanpreet Lakha <[email protected]>
Cc Hersen Wu <[email protected]>
Cc Alex Hung <[email protected]>
Cc Pierre-Eric Pelloux-Prayer <[email protected]>
Cc Simon Ser <[email protected]>
Cc Pekka Paalanen <[email protected]>
Cc Sean Paul <[email protected]>
Cc Mark Yacoub <[email protected]>
Cc Leo Li <[email protected]>
Cc Pierre-Loup <[email protected]>
Cc Michel Dänzer <[email protected]>
---
 Documentation/gpu/amdgpu/display/index.rst    |   1 +
 .../gpu/amdgpu/display/mpo-cursor.svg         | 435 ++++++++++++++++++
 .../gpu/amdgpu/display/mpo-overview.rst       | 242 ++++++++++
 .../multi-display-hdcp-mpo-less-pipe-ex.svg   | 220 +++++++++
 .../amdgpu/display/multi-display-hdcp-mpo.svg | 171 +++++++
 .../single-display-mpo-multi-video.svg        | 339 ++++++++++++++
 .../gpu/amdgpu/display/single-display-mpo.svg | 266 +++++++++++
 7 files changed, 1674 insertions(+)
 create mode 100644 Documentation/gpu/amdgpu/display/mpo-cursor.svg
 create mode 100644 Documentation/gpu/amdgpu/display/mpo-overview.rst
 create mode 100644 Documentation/gpu/amdgpu/display/multi-display-hdcp-mpo-less-pipe-ex.svg
 create mode 100644 Documentation/gpu/amdgpu/display/multi-display-hdcp-mpo.svg
 create mode 100644 Documentation/gpu/amdgpu/display/single-display-mpo-multi-video.svg
 create mode 100644 Documentation/gpu/amdgpu/display/single-display-mpo.svg
Documentation/gpu/amdgpu/display/index.rst +1 -0
index c1fb2fb3c710..f8a4f53d70d8 100644
@@ -28,4 +28,5 @@ table of content:
    display-manager.rst
    dc-debug.rst
    dcn-overview.rst
+   mpo-overview.rst
    dc-glossary.rst
Documentation/gpu/amdgpu/display/mpo-cursor.svg new file +435 -0

435 lines not on this page · raw message

Documentation/gpu/amdgpu/display/mpo-overview.rst new file +242 -0

242 lines not on this page · raw message

Documentation/gpu/amdgpu/display/multi-display-hdcp-mpo-less-pipe-ex.svg new file +220 -0

220 lines not on this page · raw message

Documentation/gpu/amdgpu/display/multi-display-hdcp-mpo.svg new file +171 -0

171 lines not on this page · raw message

Documentation/gpu/amdgpu/display/single-display-mpo-multi-video.svg new file +339 -0

339 lines not on this page · raw message

Documentation/gpu/amdgpu/display/single-display-mpo.svg new file +266 -0

266 lines not on this page · raw message

Signature · 1 line
2.35.1
Reviewed-by on the v2 series
#7 lore raw
In reply to Rodrigo Siqueira
Quoted 8 lines · Rodrigo Siqueira

This patchset introduces some new AMDGPU documentation. You will find:

1. A CSV table that maps which component version is part of some ASIC

    families. This can be useful to narrow down bugs;

2. Some explanation about AMD Display Pipeline;
3. An explanation of Multiple Plane Overlay, which can be useful for userspace applications.

Quoted 8 lines

Since we have some diagrams, I recommend applying these patches and building the documentation to have a better experience.

In this new version, I just rebased this patchset with the latest code from amd-staging-drm-next, and I also changed patch 2.

Thanks
Siqueira

This set looks good to me and should hopefully help others when digging into the AMD display driver.

Harry

Quoted 31 lines

Rodrigo Siqueira (3):
Documentation/gpu: Add info table for ASICs Documentation/gpu: Add an explanation about the DCN pipeline Documentation/gpu: Add Multiplane Overlay doc

 .../gpu/amdgpu/apu-asic-info-table.csv        |    8 +
 .../gpu/amdgpu/dgpu-asic-info-table.csv       |   24 +
 .../gpu/amdgpu/display/dcn-overview.rst       |   59 +
 Documentation/gpu/amdgpu/display/index.rst    |    1 +
 .../gpu/amdgpu/display/mpo-cursor.svg         |  435 +++++++
 .../gpu/amdgpu/display/mpo-overview.rst       |  242 ++++
 .../multi-display-hdcp-mpo-less-pipe-ex.svg   |  220 ++++
 .../amdgpu/display/multi-display-hdcp-mpo.svg |  171 +++
 .../amdgpu/display/pipeline_4k_no_split.svg   |  958 +++++++++++++++
 .../gpu/amdgpu/display/pipeline_4k_split.svg  | 1062 +++++++++++++++++
 .../single-display-mpo-multi-video.svg        |  339 ++++++
 .../gpu/amdgpu/display/single-display-mpo.svg |  266 +++++
 Documentation/gpu/amdgpu/driver-misc.rst      |   17 +
 13 files changed, 3802 insertions(+)
 create mode 100644 Documentation/gpu/amdgpu/apu-asic-info-table.csv
 create mode 100644 Documentation/gpu/amdgpu/dgpu-asic-info-table.csv
 create mode 100644 Documentation/gpu/amdgpu/display/mpo-cursor.svg
 create mode 100644 Documentation/gpu/amdgpu/display/mpo-overview.rst
 create mode 100644 Documentation/gpu/amdgpu/display/multi-display-hdcp-mpo-less-pipe-ex.svg
 create mode 100644 Documentation/gpu/amdgpu/display/multi-display-hdcp-mpo.svg
 create mode 100644 Documentation/gpu/amdgpu/display/pipeline_4k_no_split.svg
 create mode 100644 Documentation/gpu/amdgpu/display/pipeline_4k_split.svg
 create mode 100644 Documentation/gpu/amdgpu/display/single-display-mpo-multi-video.svg
 create mode 100644 Documentation/gpu/amdgpu/display/single-display-mpo.svg