hid: hid-logitech-hidpp: avoid unnecessary assignments in hidpp_connect_event
Subsystems (3)
PATCH 1/1 hid: hid-logitech-hidpp: avoid unnecessary assignments in hidpp_connect_event
hidpp->delayed_input can't be assigned to an object that already call input_free_device when input_register_device fails.
--- drivers/hid/hid-logitech-hidpp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/hid/hid-logitech-hidpp.c +3 -1
@@ -3959,8 +3959,10 @@ static void hidpp_connect_event(struct hidpp_device *hidpp)hidpp_populate_input (hidpp, input); ret =input_register_device (input); -if (ret) +if (ret) {input_free_device (input); +return ; + } hidpp->delayed_input = input; }
Signature · 1 line
2.25.1
Quoted 15 lines · Hangyu Hua
hidpp->delayed_inputcan't be assigned to an object that already callinput_free_devicewheninput_register_devicefails.Fixes c39e3d5fc9dd ("HID: logitech-hidpp: late bind the input device on wireless connection")Signed-off-by Hangyu Hua <[email protected]>--- drivers/hid/hid-logitech-hidpp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/hid/hid-logitech-hidpp.c +0
-0@@ -3959,8 +3959,10 @@ static void hidpp_connect_event(struct hidpp_device *hidpp)hidpp_populate_input (hidpp, input);
drivers/hid/hid-logitech-hidpp.c static void hidpp_connect_event(struct hidpp_device *hidpp) · line 3968
Quoted 10 lines
drivers/hid/hid-logitech-hidpp.c +3
-1ret =input_register_device (input); -if (ret) +if (ret) {input_free_device (input); +return ; + } hidpp->delayed_input = input; }
Gentel ping.
Benjamin Tissoires
AppliedQuoted 25 lines · Hangyu Hua
Quoted 23 lines · Hangyu Hua
hidpp->delayed_inputcan't be assigned to an object that already callinput_free_devicewheninput_register_devicefails.Fixes c39e3d5fc9dd ("HID: logitech-hidpp: late bind the input device on wireless connection")Signed-off-by Hangyu Hua <[email protected]>--- drivers/hid/hid-logitech-hidpp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/hid/hid-logitech-hidpp.c +3
-1@@ -3959,8 +3959,10 @@ static void hidpp_connect_event(struct hidpp_device *hidpp)hidpp_populate_input (hidpp, input); ret =input_register_device (input); -if (ret) +if (ret) {input_free_device (input); +return ; + }
Quoted 4 lines
drivers/hid/hid-logitech-hidpp.c static void hidpp_connect_event(struct hidpp_device *hidpp) · line 3968
Quoted 2 lines
drivers/hid/hid-logitech-hidpp.c +0
-0hidpp->delayed_input = input; }Gentel ping.
Applied to for-6.1/logitech in hid.git
Sorry for the delay
Cheers,
Benjamin