Add IMX8 SCU GPIO support
Subsystems (3)
v5 cover Add IMX8 SCU GPIO support
The system controller (SCU) is the central unit to manage the resources on i.MX8 platforms. The SCU firmware provides a set of APIs to access the GPIO PINs on the SCU domain.
This patch series implements the standard GPIO driver over the SCU firmware APIs, so that the GPIOs on the SCU domain could be accessed like a local GPIO PINs.
Changes in V5:
- rename the file name from fsl,imx-sc-gpio to fsl,imx8qxp-sc-gpio to match the compatible string
Changes in V4:
- remove the generic compatible of "fsl,imx-sc-gpio"
- update the gpio $ref in "fsl,scu.yaml" as the file name is changed
- update the commit comment for 0003 because the driver is moved to the directory of "drivers/gpio"
Changes in V3:
- follow the other imx8 SCU binding rule and rename the compatible string from fsl,imx8-scu-gpio to fsl,imx8qxp-sc-gpio
- rename the doc file from fsl,imx8-scu-gpio.yaml to fsl,imx-sc-gpio.yaml
Changes in V2:
- move the driver into the gpio directory per Krzysztof's feedback
- change the subnode description in file fsl,scu.yaml
- fix the dt_binding_check error
Shenwei Wang (3):
dt-bindings: gpio: Add imx scu gpio driver bindings
dt-bindings: firmware: imx: Add imx-scu gpio node
gpio: imx-scu: add imx-scu GPIO driver
.../devicetree/bindings/firmware/fsl,scu.yaml | 5 + .../bindings/gpio/fsl,imx8qxp-sc-gpio.yaml | 39 +++++ drivers/gpio/Kconfig | 4 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-imx-scu.c | 139 ++++++++++++++++++ 5 files changed, 188 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8qxp-sc-gpio.yaml create mode 100644 drivers/gpio/gpio-imx-scu.c
--
2.25.1
PATCH v5 1/3 dt-bindings: gpio: Add imx scu gpio driver bindings
Add binding document for the imx scu gpio driver.
--- .../bindings/gpio/fsl,imx8qxp-sc-gpio.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8qxp-sc-gpio.yaml
Documentation/devicetree/bindings/gpio/fsl,imx8qxp-sc-gpio.yaml new file +39 -0
@@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/fsl,imx8qxp-sc-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GPIO driver over IMX SCU firmware API + +maintainers: + - Shenwei Wang <[email protected]> + +description: | + This module provides the standard interface to control the + resource pins in SCU domain on i.MX8 platforms. + +properties: + compatible: + enum: + - fsl,imx8qxp-sc-gpio + + "#gpio-cells": + const: 2 + + gpio-controller: true + +required: + - compatible + - "#gpio-cells" + - gpio-controller + +additionalProperties: false + +examples: + - | + gpio0: gpio { + compatible = "fsl,imx8qxp-sc-gpio"; + gpio-controller; + #gpio-cells = <2>; + };
Signature · 1 line
2.25.1
Re: [PATCH v5 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings
Quoted 3 lines · Shenwei Wang
Add binding document for the imx scu gpio driver.
Signed-off-by Shenwei Wang <[email protected]>
Best regards,
Krzysztof
PATCH v5 2/3 dt-bindings: firmware: imx: Add imx-scu gpio node
In reply to Shenwei WangAdd the description for imx-scu gpio subnode.
--- Documentation/devicetree/bindings/firmware/fsl,scu.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/firmware/fsl,scu.yaml +5 -0
@@ -30,6 +30,11 @@ properties: Clock controller node that provides the clocks controlled by the SCU $ref: /schemas/clock/fsl,scu-clk.yaml + gpio: + description: + Control the GPIO PINs on SCU domain over the firmware APIs + $ref: /schemas/gpio/fsl,imx8qxp-sc-gpio.yaml + ocotp: description: OCOTP controller node provided by the SCU
Signature · 1 line
2.25.1
PATCH v5 3/3 gpio: imx-scu: add imx-scu GPIO driver
In reply to Shenwei WangThe SCU firmware on i.MX8 platforms provides a set of APIs to control the GPIO PINs on the SCU domain. This patch implements the standard GPIO driver interface to access those PINs on the SCU domain over the SCU APIs.
--- drivers/gpio/Kconfig | 4 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-imx-scu.c | 139 ++++++++++++++++++++++++++++++++++++ 3 files changed, 144 insertions(+) create mode 100644 drivers/gpio/gpio-imx-scu.c
drivers/gpio/Kconfig +4 -0
@@ -341,6 +341,10 @@ config GPIO_ICH If unsure, say N. +config GPIO_IMX_SCU + def_bool y + depends on IMX_SCU + config GPIO_IOP tristate "Intel IOP GPIO" depends on ARCH_IOP32X || COMPILE_TEST
drivers/gpio/Makefile +1 -0
@@ -70,6 +70,7 @@ obj-$(CONFIG_HTC_EGPIO) += gpio-htc-egpio.o obj-$(CONFIG_GPIO_I8255) += gpio-i8255.o obj-$(CONFIG_GPIO_ICH) += gpio-ich.o obj-$(CONFIG_GPIO_IDT3243X) += gpio-idt3243x.o +obj-$(CONFIG_GPIO_IMX_SCU) += gpio-imx-scu.o obj-$(CONFIG_GPIO_IOP) += gpio-iop.o obj-$(CONFIG_GPIO_IT87) += gpio-it87.o obj-$(CONFIG_GPIO_IXP4XX) += gpio-ixp4xx.o
drivers/gpio/gpio-imx-scu.c new file +139 -0
139 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [PATCH v5 3/3] gpio: imx-scu: add imx-scu GPIO driver
Quoted 8 lines · Shenwei Wang
The SCU firmware on i.MX8 platforms provides a set of APIs to control the GPIO PINs on the SCU domain. This patch implements the standard GPIO driver interface to access those PINs on the SCU domain over the SCU APIs.
Signed-off-by Shenwei Wang <[email protected]>---
This looks good to me - Krzysztof: do you have any other comments? Otherwise, I'll pick it up soon.
Bart
Re: [PATCH v5 3/3] gpio: imx-scu: add imx-scu GPIO driver
Quoted 7 lines · Bartosz Golaszewski
Quoted 6 lines · Shenwei Wang
The SCU firmware on i.MX8 platforms provides a set of APIs to control the GPIO PINs on the SCU domain. This patch implements the standard GPIO driver interface to access those PINs on the SCU domain over the SCU APIs.
Quoted 5 lines
Quoted 2 lines
Signed-off-by Shenwei Wang <[email protected]>---
This looks good to me - Krzysztof: do you have any other comments? Otherwise, I'll pick it up soon.
No, I acked/reviewed bindings, so entire set is for you. Thanks!
Best regards,
Krzysztof
Quoted 3 lines · Shenwei Wang
Changes in V5:
- rename the file name from fsl,imx-sc-gpio to fsl,imx8qxp-sc-gpio to match the compatible string
v5 looks good to me!
Yours,
Linus Walleij
Bartosz Golaszewski
AppliedQuoted 43 lines · Shenwei Wang
The system controller (SCU) is the central unit to manage the resources on i.MX8 platforms. The SCU firmware provides a set of APIs to access the GPIO PINs on the SCU domain.
This patch series implements the standard GPIO driver over the SCU firmware APIs, so that the GPIOs on the SCU domain could be accessed like a local GPIO PINs.
Changes in V5:
- rename the file name from fsl,imx-sc-gpio to fsl,imx8qxp-sc-gpio to match the compatible stringChanges in V4:
- remove the generic compatible of "fsl,imx-sc-gpio"
- update the gpio $ref in "fsl,scu.yaml" as the file name is changed
- update the commit comment for 0003 because the driver is moved to the directory of "drivers/gpio"Changes in V3:
- follow the other imx8 SCU binding rule and rename the compatible string from fsl,imx8-scu-gpio to fsl,imx8qxp-sc-gpio
- rename the doc file from fsl,imx8-scu-gpio.yaml to fsl,imx-sc-gpio.yamlChanges in V2:
- move the driver into the gpio directory per Krzysztof's feedback
- change the subnode description in file fsl,scu.yaml
- fix thedt_binding_checkerrorShenwei Wang (3):
dt-bindings: gpio: Add imx scu gpio driver bindings
dt-bindings: firmware: imx: Add imx-scu gpio node
gpio: imx-scu: add imx-scu GPIO driver.../devicetree/bindings/firmware/fsl,scu.yaml | 5 + .../bindings/gpio/fsl,imx8qxp-sc-gpio.yaml | 39 +++++ drivers/gpio/Kconfig | 4 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-imx-scu.c | 139 ++++++++++++++++++ 5 files changed, 188 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8qxp-sc-gpio.yaml create mode 100644 drivers/gpio/gpio-imx-scu.c
Quoted 3 lines
--
2.25.1
Applied the series, thanks!
Bart