Skip to contentSkip to conversation

iio: Add single and double tap events support

PATCH Superseded Jagath Jog J 3 participants 8 messages Aug 13, 2022 – Aug 20, 2022

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover iio: Add single and double tap events support

This patch series adds new event type for tap called gesture and direction is used to differentiate single and double tap. This series adds single and double tap support for bma400 accelerometer device driver.

Changes since v1
1. Included headers in alphabetical order.
2. Changing tap_event_en variable name to tap_event_en_bitmask since it is used in bit manipulation operation.
3. Assigning boolean value to step_event_en and activity_event_en instead of 0, since they are boolean type members.
4. Using local variable for regmap_read() instead for *val itself.
5. Correcting typos.
6. Remove of IIO_EV_INFO_PERIOD.
7. Now all 4 tap controls like threshold, quiet, tics_dt and quiet_dt can be configured from the userspace.
8. Introducing new event info IIO_EV_INFO_RESET_TIMEOUT, and IIO_EV_INFO_TAP_2MIN_DELAY into iio_event_info.
9. Creating custom read/write attributes for tics_dt called in_accel_gesture_maxtomin_time.
10. Time based tap controls can be configured in seconds instead of raw values.
11. Provided all available values for time base tap controls in seconds.
12. Adding one more MODULE_AUTHOR().

Changes since RFC
1. Corrected the "quite" typo to "quiet".
2. Added proper reference and name of the section from datasheet.
3. Changed the ABI documentation to make it more generic.
4. Added ABI documentation for double tap quiet period.
5. Added available list by registering new event attribute for tap threshold values and double tap quiet period values.
6. Sending both single and double tap events separately.
8. Removed checking for tap enabled while changing data rate.
9. Returning invalid with error message if the input data rate is not 200Hz while enabling tap interrupts.
7. Added datasheet reference for interrupt engine overrun.

Jagath Jog J (2):
iio: Add new event type gesture and use direction for single and
double tap
iio: accel: bma400: Add support for single and double tap events

 Documentation/ABI/testing/sysfs-bus-iio |  41 +++
 drivers/iio/accel/bma400.h              |  13 +
 drivers/iio/accel/bma400_core.c         | 337 +++++++++++++++++++++++-
 drivers/iio/industrialio-event.c        |   7 +-
 include/linux/iio/types.h               |   2 +
 include/uapi/linux/iio/types.h          |   3 +
 tools/iio/iio_event_monitor.c           |   8 +-
 7 files changed, 399 insertions(+), 12 deletions(-)

base-commit: 180c6cb6b9b79c55b79e8414f4c0208f2463af7d

Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/2 iio: Add new event type gesture and use direction for single and double tap

Add new event type for tap called gesture and the direction can be used to differentiate single and double tap. This may be used by accelerometer sensors to express single and double tap events. For directional tap, modifiers like IIO_MOD_(X/Y/Z) can be used along with singletap and doubletap direction.

---
 Documentation/ABI/testing/sysfs-bus-iio | 41 +++++++++++++++++++++++++
 drivers/iio/industrialio-event.c        |  7 ++++-
 include/linux/iio/types.h               |  2 ++
 include/uapi/linux/iio/types.h          |  3 ++
 tools/iio/iio_event_monitor.c           |  8 ++++-
 5 files changed, 59 insertions(+), 2 deletions(-)
Documentation/ABI/testing/sysfs-bus-iio +41 -0
index e81ba6f5e1c8..54cb925f714c 100644
@@ -2038,3 +2038,44 @@ Description:
 		Available range for the forced calibration value, expressed as:
 
 		- a range specified as "[min step max]"
+
+What:		/sys/.../events/in_accel_gesture_singletap_en
+What:		/sys/.../events/in_accel_gesture_doubletap_en
+KernelVersion:	5.21
+Contact:	[email protected]
+Description:
+		Device generates an event on a single or double tap.
+
+What:		/sys/.../events/in_accel_gesture_singletap_value
+What:		/sys/.../events/in_accel_gesture_doubletap_value
+KernelVersion:	5.21
+Contact:	[email protected]
+Description:
+		Specifies the threshold value that the device is comparing
+		against to generate the tap gesture event. Units and exact
+		meaning of value are device specific.
+
+What:		/sys/.../events/in_accel_gesture_singletap_reset_timeout
+What:		/sys/.../events/in_accel_gesture_doubletap_reset_timeout
+KernelVersion:	5.21
+Contact:	[email protected]
+Description:
+		Specifies the timeout value in seconds for the tap detector
+		to not to look for another tap event after the event as
+		occoured. Basically the minimum quiet time between the two
+		single-tap's or two double-tap's.
+
+What:		/sys/.../events/in_accel_gesture_doubletap_tap_2min_delay
+KernelVersion:	5.21
+Contact:	[email protected]
+Description:
+		Specifies the minimum quiet time in seconds between the two
+		taps of a double tap.
+
+What:		/sys/.../events/in_accel_gesture_maxtomin_time
+KernelVersion:	5.21
+Contact:	[email protected]
+Description:
+		Specifies the maximum time difference allowed between upper
+		and lower peak of tap to consider it as the valid tap event.
+		Units in seconds.
drivers/iio/industrialio-event.c +6 -1
index b5e059e15b0a..b63be2a4ac02 100644
@@ -231,12 +231,15 @@ static const char * const iio_ev_type_text[] = {
 	[IIO_EV_TYPE_MAG_ADAPTIVE] = "mag_adaptive",
 	[IIO_EV_TYPE_CHANGE] = "change",
 	[IIO_EV_TYPE_MAG_REFERENCED] = "mag_referenced",
+	[IIO_EV_TYPE_GESTURE] = "gesture",
 };
 
 static const char * const iio_ev_dir_text[] = {
 	[IIO_EV_DIR_EITHER] = "either",
 	[IIO_EV_DIR_RISING] = "rising",
-	[IIO_EV_DIR_FALLING] = "falling"
+	[IIO_EV_DIR_FALLING] = "falling",
+	[IIO_EV_DIR_SINGLETAP] = "singletap",
+	[IIO_EV_DIR_DOUBLETAP] = "doubletap",
 };
 
 static const char * const iio_ev_info_text[] = {
@@ -247,6 +250,8 @@ static const char * const iio_ev_info_text[] = {
 	[IIO_EV_INFO_HIGH_PASS_FILTER_3DB] = "high_pass_filter_3db",
 	[IIO_EV_INFO_LOW_PASS_FILTER_3DB] = "low_pass_filter_3db",
 	[IIO_EV_INFO_TIMEOUT] = "timeout",
+	[IIO_EV_INFO_RESET_TIMEOUT] = "reset_timeout",
+	[IIO_EV_INFO_TAP_2MIN_DELAY] = "tap_2min_delay",
 };
 
 static enum iio_event_direction iio_ev_attr_dir(struct iio_dev_attr *attr)
include/linux/iio/types.h +2 -0
index a7aa91f3a8dc..e33069d6a3d8 100644
@@ -17,6 +17,8 @@ enum iio_event_info {
 	IIO_EV_INFO_HIGH_PASS_FILTER_3DB,
 	IIO_EV_INFO_LOW_PASS_FILTER_3DB,
 	IIO_EV_INFO_TIMEOUT,
+	IIO_EV_INFO_RESET_TIMEOUT,
+	IIO_EV_INFO_TAP_2MIN_DELAY,
 };
 
 #define IIO_VAL_INT 1
include/uapi/linux/iio/types.h +3 -0
index 472cead10d8d..913864221ac4 100644
@@ -105,6 +105,7 @@ enum iio_event_type {
 	IIO_EV_TYPE_MAG_ADAPTIVE,
 	IIO_EV_TYPE_CHANGE,
 	IIO_EV_TYPE_MAG_REFERENCED,
+	IIO_EV_TYPE_GESTURE,
 };
 
 enum iio_event_direction {
@@ -112,6 +113,8 @@ enum iio_event_direction {
 	IIO_EV_DIR_RISING,
 	IIO_EV_DIR_FALLING,
 	IIO_EV_DIR_NONE,
+	IIO_EV_DIR_SINGLETAP,
+	IIO_EV_DIR_DOUBLETAP,
 };
 
 #endif /* _UAPI_IIO_TYPES_H_ */
tools/iio/iio_event_monitor.c +7 -1
index 2f4581658859..b3b3ea399f67 100644
@@ -69,12 +69,15 @@ static const char * const iio_ev_type_text[] = {
 	[IIO_EV_TYPE_MAG_ADAPTIVE] = "mag_adaptive",
 	[IIO_EV_TYPE_CHANGE] = "change",
 	[IIO_EV_TYPE_MAG_REFERENCED] = "mag_referenced",
+	[IIO_EV_TYPE_GESTURE] = "gesture",
 };
 
 static const char * const iio_ev_dir_text[] = {
 	[IIO_EV_DIR_EITHER] = "either",
 	[IIO_EV_DIR_RISING] = "rising",
-	[IIO_EV_DIR_FALLING] = "falling"
+	[IIO_EV_DIR_FALLING] = "falling",
+	[IIO_EV_DIR_SINGLETAP] = "singletap",
+	[IIO_EV_DIR_DOUBLETAP] = "doubletap",
 };
 
 static const char * const iio_modifier_names[] = {
@@ -227,6 +230,7 @@ static bool event_is_known(struct iio_event_data *event)
 	case IIO_EV_TYPE_THRESH_ADAPTIVE:
 	case IIO_EV_TYPE_MAG_ADAPTIVE:
 	case IIO_EV_TYPE_CHANGE:
+	case IIO_EV_TYPE_GESTURE:
 		break;
 	default:
 		return false;
@@ -236,6 +240,8 @@ static bool event_is_known(struct iio_event_data *event)
 	case IIO_EV_DIR_EITHER:
 	case IIO_EV_DIR_RISING:
 	case IIO_EV_DIR_FALLING:
+	case IIO_EV_DIR_SINGLETAP:
+	case IIO_EV_DIR_DOUBLETAP:
 	case IIO_EV_DIR_NONE:
 		break;
 	default:
Signature · 1 line
2.17.1
maintainer
#2 lore raw

Re: [PATCH v2 1/2] iio: Add new event type gesture and use direction for single and double tap

Quoted 7 lines · On Sat, 13 Aug 2022 12:48:02 +0530 Jagath Jog J <[email protected]> wrote:

Add new event type for tap called gesture and the direction can be used to differentiate single and double tap. This may be used by accelerometer sensors to express single and double tap events. For directional tap, modifiers like IIO_MOD_(X/Y/Z) can be used along with singletap and doubletap direction.

Hi Jagath,

This ABI is definitely something I want more eyes than ours on, so whatever happens I'll leave it on the list for a few weeks.

Quoted 22 lines
---
 Documentation/ABI/testing/sysfs-bus-iio | 41 +++++++++++++++++++++++++
 drivers/iio/industrialio-event.c        |  7 ++++-
 include/linux/iio/types.h               |  2 ++
 include/uapi/linux/iio/types.h          |  3 ++
 tools/iio/iio_event_monitor.c           |  8 ++++-
 5 files changed, 59 insertions(+), 2 deletions(-)
Documentation/ABI/testing/sysfs-bus-iio +6 -0
index e81ba6f5e1c8..54cb925f714c 100644
@@ -2038,3 +2038,44 @@ Description:
 		Available range for the forced calibration value, expressed as:
 
 		- a range specified as "[min step max]"
+
+What:		/sys/.../events/in_accel_gesture_singletap_en
+What:		/sys/.../events/in_accel_gesture_doubletap_en
+KernelVersion:	5.21
+Contact:	[email protected]
+Description:

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2056

Quoted 10 lines
Documentation/ABI/testing/sysfs-bus-iio +10 -0
+		Device generates an event on a single or double tap.
+
+What:		/sys/.../events/in_accel_gesture_singletap_value
+What:		/sys/.../events/in_accel_gesture_doubletap_value
+KernelVersion:	5.21
+Contact:	[email protected]
+Description:
+		Specifies the threshold value that the device is comparing
+		against to generate the tap gesture event. Units and exact
+		meaning of value are device specific.

I wonder if we should list a direction? As in smaller is more sensitive? (at least to first approximation)
That way a user would at least be able to consistently decide if they should raise or lower the number to get the perf the want.

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2065

Quoted 9 lines
Documentation/ABI/testing/sysfs-bus-iio +9 -0
+
+What:		/sys/.../events/in_accel_gesture_singletap_reset_timeout
+What:		/sys/.../events/in_accel_gesture_doubletap_reset_timeout
+KernelVersion:	5.21
+Contact:	[email protected]
+Description:
+		Specifies the timeout value in seconds for the tap detector
+		to not to look for another tap event after the event as
+		occoured. Basically the minimum quiet time between the two

spelling. occured

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2068

Quoted 3 lines
Documentation/ABI/testing/sysfs-bus-iio +3 -0
+		single-tap's or two double-tap's.
+
+What:		/sys/.../events/in_accel_gesture_doubletap_tap_2min_delay

I'm not sure this naming is intuitive enough. Might be a simple as doubletap_tap2_min_delay? My brain didn't parse 2min correctly.

This one is a bit odd, so definitely want to hear more view points on whether this is general enough to cover sensors and intuitive enough that people have some hope of setting it right.

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2081

Quoted 13 lines
Documentation/ABI/testing/sysfs-bus-iio +13 -0
+KernelVersion:	5.21
+Contact:	[email protected]
+Description:
+		Specifies the minimum quiet time in seconds between the two
+		taps of a double tap.
+
+What:		/sys/.../events/in_accel_gesture_maxtomin_time
+KernelVersion:	5.21
+Contact:	[email protected]
+Description:
+		Specifies the maximum time difference allowed between upper
+		and lower peak of tap to consider it as the valid tap event.
+		Units in seconds.

Needs to be associated with 'tap' in the naming. Easiest is probably only to define it as singletap_maxtomin_time + doubletap_maxtomin_time and not have the shared version as we'd lose the 'tap' part of the name.

#3 lore raw

Re: [PATCH v2 1/2] iio: Add new event type gesture and use direction for single and double tap

Hi Jonathan,

Quoted 10 lines · Jonathan Cameron
Quoted 6 lines · On Sat, 13 Aug 2022 12:48:02 +0530 Jagath Jog J <[email protected]> wrote:

Add new event type for tap called gesture and the direction can be used to differentiate single and double tap. This may be used by accelerometer sensors to express single and double tap events. For directional tap, modifiers like IIO_MOD_(X/Y/Z) can be used along with singletap and doubletap direction.

Quoted 5 lines
Quoted 1 line

Hi Jagath,

This ABI is definitely something I want more eyes than ours on, so whatever happens I'll leave it on the list for a few weeks.

Sure, I will leave KernelVersion blank in the next series.

Quoted 27 lines
Quoted 27 lines
---
 Documentation/ABI/testing/sysfs-bus-iio | 41 +++++++++++++++++++++++++
 drivers/iio/industrialio-event.c        |  7 ++++-
 include/linux/iio/types.h               |  2 ++
 include/uapi/linux/iio/types.h          |  3 ++
 tools/iio/iio_event_monitor.c           |  8 ++++-
 5 files changed, 59 insertions(+), 2 deletions(-)
Documentation/ABI/testing/sysfs-bus-iio +10 -0
index e81ba6f5e1c8..54cb925f714c 100644
@@ -2038,3 +2038,44 @@ Description:
              Available range for the forced calibration value, expressed as:
 
              - a range specified as "[min step max]"
+
+What:                /sys/.../events/in_accel_gesture_singletap_en
+What:                /sys/.../events/in_accel_gesture_doubletap_en
+KernelVersion:       5.21
+Contact:     [email protected]
+Description:
+             Device generates an event on a single or double tap.
+
+What:                /sys/.../events/in_accel_gesture_singletap_value
+What:                /sys/.../events/in_accel_gesture_doubletap_value
Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2056

Quoted 6 lines
Documentation/ABI/testing/sysfs-bus-iio +6 -0
+KernelVersion:       5.21
+Contact:     [email protected]
+Description:
+             Specifies the threshold value that the device is comparing
+             against to generate the tap gesture event. Units and exact
+             meaning of value are device specific.

I wonder if we should list a direction? As in smaller is more sensitive?

Yeah in most of the devices which support tap, this value represents the threshold, the lower the value higher the tap sensitivity. I will add it to the description in the next series.

Quoted 1 line

(at least to first approximation)

Do I need to add available attributes into ABI docs?

Quoted 13 lines

That way a user would at least be able to consistently decide if they should raise or lower the number to get the perf the want.

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2065

Quoted 9 lines
Documentation/ABI/testing/sysfs-bus-iio +9 -0
+
+What:                /sys/.../events/in_accel_gesture_singletap_reset_timeout
+What:                /sys/.../events/in_accel_gesture_doubletap_reset_timeout
+KernelVersion:       5.21
+Contact:     [email protected]
+Description:
+             Specifies the timeout value in seconds for the tap detector
+             to not to look for another tap event after the event as
+             occoured. Basically the minimum quiet time between the two

spelling. occured

Sorry, I will correct this.

Thank you
Jagath

Quoted 31 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2068

Quoted 4 lines
Documentation/ABI/testing/sysfs-bus-iio +3 -0
+             single-tap's or two double-tap's.
+
+What:                /sys/.../events/in_accel_gesture_doubletap_tap_2min_delay

I'm not sure this naming is intuitive enough. Might be a simple as doubletap_tap2_min_delay? My brain didn't parse 2min correctly.

This one is a bit odd, so definitely want to hear more view points on whether this is general enough to cover sensors and intuitive enough that people have some hope of setting it right.

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2081

Quoted 13 lines
Documentation/ABI/testing/sysfs-bus-iio +13 -0
+KernelVersion:       5.21
+Contact:     [email protected]
+Description:
+             Specifies the minimum quiet time in seconds between the two
+             taps of a double tap.
+
+What:                /sys/.../events/in_accel_gesture_maxtomin_time
+KernelVersion:       5.21
+Contact:     [email protected]
+Description:
+             Specifies the maximum time difference allowed between upper
+             and lower peak of tap to consider it as the valid tap event.
+             Units in seconds.

Needs to be associated with 'tap' in the naming. Easiest is probably only to define it as singletap_maxtomin_time + doubletap_maxtomin_time and not have the shared version as we'd lose the 'tap' part of the name.

#4 lore raw

Re: [PATCH v2 1/2] iio: Add new event type gesture and use direction for single and double tap

Quoted 3 lines · Jagath Jog J

On Sun, Aug 14, 2022 at 10:24 PM Jonathan Cameron <[email protected]> wrote:

Sure, I will leave KernelVersion blank in the next series.

You may use 6.1, that way we don't forget about it.

I'm wondering if checkpatch or other tools can validate the ABI descriptions.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#5 lore raw

Re: [PATCH v2 1/2] iio: Add new event type gesture and use direction for single and double tap

In reply to Jagath Jog J
Quoted 13 lines · On Tue, 16 Aug 2022 00:03:47 +0530 Jagath Jog J <[email protected]> wrote:

Hi Jonathan,

Quoted 10 lines · Jonathan Cameron
Quoted 6 lines · On Sat, 13 Aug 2022 12:48:02 +0530 Jagath Jog J <[email protected]> wrote:

Add new event type for tap called gesture and the direction can be used to differentiate single and double tap. This may be used by accelerometer sensors to express single and double tap events. For directional tap, modifiers like IIO_MOD_(X/Y/Z) can be used along with singletap and doubletap direction.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Hi Jagath,

This ABI is definitely something I want more eyes than ours on, so whatever happens I'll leave it on the list for a few weeks.

Sure, I will leave KernelVersion blank in the next series.

Please don't. Just take a guess at 6.1. That will probably be right and it'll save me effort when applying :) If it's not right then no harm done as I need to edit it anyway.

Quoted 37 lines
Quoted 28 lines
Quoted 28 lines
 
---
 Documentation/ABI/testing/sysfs-bus-iio | 41 +++++++++++++++++++++++++
 drivers/iio/industrialio-event.c        |  7 ++++-
 include/linux/iio/types.h               |  2 ++
 include/uapi/linux/iio/types.h          |  3 ++
 tools/iio/iio_event_monitor.c           |  8 ++++-
 5 files changed, 59 insertions(+), 2 deletions(-)
Documentation/ABI/testing/sysfs-bus-iio +10 -0
index e81ba6f5e1c8..54cb925f714c 100644
@@ -2038,3 +2038,44 @@ Description:
              Available range for the forced calibration value, expressed as:
 
              - a range specified as "[min step max]"
+
+What:                /sys/.../events/in_accel_gesture_singletap_en
+What:                /sys/.../events/in_accel_gesture_doubletap_en
+KernelVersion:       5.21
+Contact:     [email protected]
+Description:
+             Device generates an event on a single or double tap.
+
+What:                /sys/.../events/in_accel_gesture_singletap_value
+What:                /sys/.../events/in_accel_gesture_doubletap_value
Quoted 8 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2056

Quoted 6 lines
Documentation/ABI/testing/sysfs-bus-iio +6 -0
+KernelVersion:       5.21
+Contact:     [email protected]
+Description:
+             Specifies the threshold value that the device is comparing
+             against to generate the tap gesture event. Units and exact
+             meaning of value are device specific.  

I wonder if we should list a direction? As in smaller is more sensitive?

Quoted 6 lines

Yeah in most of the devices which support tap, this value represents the threshold, the lower the value higher the tap sensitivity. I will add it to the description in the next series.

Quoted 1 line

(at least to first approximation)

Do I need to add available attributes into ABI docs?

Yes, though no need to give much description of them.
There is a script that compares the ABI exposed on a given platform with these files and warns if things are missing. Right now it gives so many warnings (outside of IIO) that it's more or less unusable but the end goal is to get to the pointer where systems doing build and boot tests will general warnings for undocumented ABI.

Quoted 51 lines
Quoted 4 lines

That way a user would at least be able to consistently decide if they should raise or lower the number to get the perf the want.

Quoted 10 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2065

Quoted 9 lines
Documentation/ABI/testing/sysfs-bus-iio +9 -0
+
+What:                /sys/.../events/in_accel_gesture_singletap_reset_timeout
+What:                /sys/.../events/in_accel_gesture_doubletap_reset_timeout
+KernelVersion:       5.21
+Contact:     [email protected]
+Description:
+             Specifies the timeout value in seconds for the tap detector
+             to not to look for another tap event after the event as
+             occoured. Basically the minimum quiet time between the two  

spelling. occured

Sorry, I will correct this.

Thank you
Jagath

Quoted 31 lines

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2068

Quoted 4 lines
Documentation/ABI/testing/sysfs-bus-iio +3 -0
+             single-tap's or two double-tap's.
+
+What:                /sys/.../events/in_accel_gesture_doubletap_tap_2min_delay  

I'm not sure this naming is intuitive enough. Might be a simple as doubletap_tap2_min_delay? My brain didn't parse 2min correctly.

This one is a bit odd, so definitely want to hear more view points on whether this is general enough to cover sensors and intuitive enough that people have some hope of setting it right.

Documentation/ABI/testing/sysfs-bus-iio Description: · line 2081

Quoted 13 lines
Documentation/ABI/testing/sysfs-bus-iio +13 -0
+KernelVersion:       5.21
+Contact:     [email protected]
+Description:
+             Specifies the minimum quiet time in seconds between the two
+             taps of a double tap.
+
+What:                /sys/.../events/in_accel_gesture_maxtomin_time
+KernelVersion:       5.21
+Contact:     [email protected]
+Description:
+             Specifies the maximum time difference allowed between upper
+             and lower peak of tap to consider it as the valid tap event.
+             Units in seconds.  

Needs to be associated with 'tap' in the naming. Easiest is probably only to define it as singletap_maxtomin_time + doubletap_maxtomin_time and not have the shared version as we'd lose the 'tap' part of the name.

#6 lore raw

PATCH v2 2/2 iio: accel: bma400: Add support for single and double tap events

In reply to Jagath Jog J

Add support for single and double tap events based on the tap threshold value, minimum quiet time before and after the tap and minimum time between the taps in the double tap. The INT1 pin is used to interrupt and the event is pushed to userspace.

---
 drivers/iio/accel/bma400.h      |  13 ++
 drivers/iio/accel/bma400_core.c | 337 +++++++++++++++++++++++++++++++-
 2 files changed, 340 insertions(+), 10 deletions(-)
drivers/iio/accel/bma400.h +13 -0
index e8f802a82300..d9e8eccb524b 100644
@@ -40,6 +40,7 @@
 #define BMA400_INT_STAT1_REG        0x0f
 #define BMA400_INT_STAT2_REG        0x10
 #define BMA400_INT12_MAP_REG        0x23
+#define BMA400_INT_ENG_OVRUN_MSK    BIT(4)
 
 /* Temperature register */
 #define BMA400_TEMP_DATA_REG        0x11
@@ -105,6 +106,18 @@
 #define BMA400_INT_GEN2_MSK         BIT(3)
 #define BMA400_GEN_HYST_MSK         GENMASK(1, 0)
 
+/* TAP config registers */
+#define BMA400_TAP_CONFIG           0x57
+#define BMA400_TAP_CONFIG1          0x58
+#define BMA400_S_TAP_MSK            BIT(2)
+#define BMA400_D_TAP_MSK            BIT(3)
+#define BMA400_INT_S_TAP_MSK        BIT(10)
+#define BMA400_INT_D_TAP_MSK        BIT(11)
+#define BMA400_TAP_SEN_MSK          GENMASK(2, 0)
+#define BMA400_TAP_TICSTH_MSK       GENMASK(1, 0)
+#define BMA400_TAP_QUIET_MSK        GENMASK(3, 2)
+#define BMA400_TAP_QUIETDT_MSK      GENMASK(5, 4)
+
 /*
  * BMA400_SCALE_MIN macro value represents m/s^2 for 1 LSB before
  * converting to micro values for +-2g range.
drivers/iio/accel/bma400_core.c +327 -10

422 lines not on this page · raw message

Signature · 1 line
2.17.1
maintainer
#7 lore raw

Re: [PATCH v2 2/2] iio: accel: bma400: Add support for single and double tap events

Quoted 6 lines · On Sat, 13 Aug 2022 12:48:03 +0530 Jagath Jog J <[email protected]> wrote:

Add support for single and double tap events based on the tap threshold value, minimum quiet time before and after the tap and minimum time between the taps in the double tap. The INT1 pin is used to interrupt and the event is pushed to userspace.

Hi Jagath,

As, for this series, the difficult bit from review point of view is the ABI I've only taken a quick look at the implementation. Basically looks fine to me, but one trivial thing below (and that might just be me failing to read a diff)

...

drivers/iio/accel/bma400_core.c static int bma400_read_event_value(struct iio_dev *indio_dev, · line 1163

Quoted 10 lines
drivers/iio/accel/bma400_core.c +1 -3
 		ret = bma400_steps_event_enable(data, state);
@@ -1157,10 +1379,10 @@ static int bma400_read_event_value(struct iio_dev *indio_dev,
 				   int *val, int *val2)
 {
 	struct bma400_data *data = iio_priv(indio_dev);
-	int ret, reg;
+	int ret, reg, reg_val, raw;
 
-	switch (chan->type) {
-	case IIO_ACCEL:

We've lost the check on ACCEL I think. Might be worth putting it back as

	if (chan->type != ACCEL)
		return -EINVAL;
Quoted 45 lines
drivers/iio/accel/bma400_core.c +35 -0
+	switch (type) {
+	case IIO_EV_TYPE_MAG:
 		reg = get_gen_config_reg(dir);
 		if (reg < 0)
 			return -EINVAL;
@@ -1196,6 +1418,39 @@ static int bma400_read_event_value(struct iio_dev *indio_dev,
 		default:
 			return -EINVAL;
 		}
+	case IIO_EV_TYPE_GESTURE:
+		switch (info) {
+		case IIO_EV_INFO_VALUE:
+			ret = regmap_read(data->regmap, BMA400_TAP_CONFIG,
+					  &reg_val);
+			if (ret)
+				return ret;
+
+			*val = FIELD_GET(BMA400_TAP_SEN_MSK, reg_val);
+			return IIO_VAL_INT;
+		case IIO_EV_INFO_RESET_TIMEOUT:
+			ret = regmap_read(data->regmap, BMA400_TAP_CONFIG1,
+					  &reg_val);
+			if (ret)
+				return ret;
+
+			raw = FIELD_GET(BMA400_TAP_QUIET_MSK, reg_val);
+			*val = 0;
+			*val2 = tap_timeout[raw];
+			return IIO_VAL_INT_PLUS_MICRO;
+		case IIO_EV_INFO_TAP_2MIN_DELAY:
+			ret = regmap_read(data->regmap, BMA400_TAP_CONFIG1,
+					  &reg_val);
+			if (ret)
+				return ret;
+
+			raw = FIELD_GET(BMA400_TAP_QUIETDT_MSK, reg_val);
+			*val = 0;
+			*val2 = doubletap_2min_delay[raw];
+			return IIO_VAL_INT_PLUS_MICRO;
+		default:
+			return -EINVAL;
+		}
 	default:
 		return -EINVAL;
 	}