Skip to contentSkip to conversation

rng-tools: Remove disabling DefaultDependencies

PATCH In review Khem Raj 2 participants 4 messages Aug 13, 2022 – Aug 14, 2022

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/3 rng-tools: Remove disabling DefaultDependencies

Delete dependency on dev-hwrng.device and systemd-udev-settle services as they can be troublesome because difference devices may have different devices to detect resulting in delayed boot. default dependencies would add some delay that the race condition for creating the device by kernel module and daemon using it is not seen often.

do not run if included in a container image

---
 meta/recipes-support/rng-tools/rng-tools/rng-tools.service | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
meta/recipes-support/rng-tools/rng-tools/rng-tools.service +1 -4
index 0f50890dcb1..c8b46aebab0 100644
@@ -1,10 +1,7 @@
 [Unit]
 Description=Hardware RNG Entropy Gatherer Daemon
-DefaultDependencies=no
-After=systemd-udev-settle.service
+ConditionVirtualization=!container
 Before=sysinit.target shutdown.target
-Requires=dev-hwrng.device
-After=dev-hwrng.device
 Conflicts=shutdown.target
 
 [Service]
Signature · 1 line
2.37.2
author
#1 lore raw

PATCH 2/3 gstreamer1.0-plugins-base: Include required system headers for isspace() and sscanf()

---
 ...-system-headers-for-isspace-and-ssca.patch | 35 +++++++++++++++++++
 .../gstreamer1.0-plugins-base_1.20.3.bb       |  1 +
 2 files changed, 36 insertions(+)
 create mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0001-include-required-system-headers-for-isspace-and-ssca.patch
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0001-include-required-system-headers-for-isspace-and-ssca.patch new file +35 -0
new file mode 100644
index 00000000000..23c1048a362
@@ -0,0 +1,35 @@
+From c85a53a41d4e6bfc49c377217ece12a1f330a690 Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+Date: Fri, 12 Aug 2022 22:50:06 -0700
+Subject: [PATCH] include required system headers for isspace() and sscanf()
+ functions
+
+Newer compilers ( clang 15 ) has turned stricter and errors out instead
+of warning on implicit function declations
+Fixes
+gstssaparse.c:297:12: error: call to undeclared library function 'isspace' with type 'int (int)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
+while (isspace(*t))
+
+Upstream-Status: Submitted [https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2879]
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ gst/subparse/gstssaparse.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/gst/subparse/gstssaparse.c b/gst/subparse/gstssaparse.c
+index ff802fa..5ebe678 100755
+--- a/gst/subparse/gstssaparse.c
++++ b/gst/subparse/gstssaparse.c
+@@ -24,6 +24,8 @@
+ #include "config.h"
+ #endif
+ 
++#include <ctype.h>              /* isspace() */
++#include <stdio.h>              /* sscanf() */
+ #include <stdlib.h>             /* atoi() */
+ #include <string.h>
+ 
+-- 
+2.37.1
+
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.20.3.bb +1 -0
index 7eebbba9497..e5e346e5e96 100644
@@ -10,6 +10,7 @@ SRC_URI = "https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-ba
            file://0001-ENGR00312515-get-caps-from-src-pad-when-query-caps.patch \
            file://0003-viv-fb-Make-sure-config.h-is-included.patch \
            file://0002-ssaparse-enhance-SSA-text-lines-parsing.patch \
+           file://0001-include-required-system-headers-for-isspace-and-ssca.patch \
            "
 SRC_URI[sha256sum] = "7e30b3dd81a70380ff7554f998471d6996ff76bbe6fc5447096f851e24473c9f"
 
Signature · 1 line
2.37.2
author
#2 lore raw

PATCH 3/3 musl: Upgrade to latest tip of trunk

In reply to Khem Raj

Brings in following changes

* 46d1c780 fix strings.h feature test macro usage due to missing features.h
* baaf257f fix ESRCH error handling for clock_getcpuclockid
* 4f48da00 aarch64: add vfork
* 7d568410 fix mishandling of errno in getaddrinfo AI_ADDRCONFIG logic
* d16d7b10 early stage ldso: remove symbolic references via error handling function
* 63c67053 in early stage ldso before __dls2b, call mprotect with __syscall
* a23a3da2 avoid limited space of random temp file names if clock resolution is low
* 41002798 remove random filename obfuscation that leaks ASLR information
* 6c858d6f ensure distinct query id for parallel A and AAAA queries in resolver
* 8974ef21 mntent: fix potential mishandling of extremely long lines
* 751bee0e mntent: fix parsing lines with optional fields
* dcb31f6b fix constraint violation in qsort wrapper around qsort_r

---
 meta/recipes-core/musl/musl_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/musl/musl_git.bb +1 -1
index fde5fc0ccec..510dd4eeeea 100644
@@ -4,7 +4,7 @@
 require musl.inc
 inherit linuxloader
 
-SRCREV = "6e9d2370c7559af80b32a91f20898f41597e093b"
+SRCREV = "46d1c7801bb509e1097e8fadbaf359367fa4ef0b"
 
 BASEVER = "1.2.3"
 
Signature · 1 line
2.37.2
#3 lore raw
In reply to Khem Raj
Quoted 19 lines · Khem Raj

Delete dependency on dev-hwrng.device and systemd-udev-settle services as they can be troublesome because difference devices may have different devices to detect resulting in delayed boot. default dependencies would add some delay that the race condition for creating the device by kernel module and daemon using it is not seen often.

do not run if included in a container image

---
 meta/recipes-support/rng-tools/rng-tools/rng-tools.service | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
meta/recipes-support/rng-tools/rng-tools/rng-tools.service +0 -0
index 0f50890dcb1..c8b46aebab0 100644
@@ -1,10 +1,7 @@
 [Unit]

meta/recipes-support/rng-tools/rng-tools/rng-tools.service line 7

Quoted 10 lines
meta/recipes-support/rng-tools/rng-tools/rng-tools.service +1 -4
 Description=Hardware RNG Entropy Gatherer Daemon
-DefaultDependencies=no
-After=systemd-udev-settle.service
+ConditionVirtualization=!container
 Before=sysinit.target shutdown.target
-Requires=dev-hwrng.device
-After=dev-hwrng.device
 Conflicts=shutdown.target
 
 [Service]

Fails in testing:

https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/4496/steps/14/logs/stdio

Cheers,

Richard