package/hawktracer: fix build without threads
PATCH v2 1/1 package/hawktracer: fix build without threads
Fix the following build failure without threads raised since the addition of the package in commit 94d8764ef938936aa5432f1f13bd1b2d8b62a159:
/home/giuliobenetti/autobuild/run/instance-2/output-1/build/hawktracer-e53b07bc812c4cfe8f6253ddb48ac43de8fa74a8/lib/platform/linux/cpu_usage.c:5:10: fatal error: pthread.h: No such file or directory
5 | #include <pthread.h>
| ^~~~~~~~~~~
Fixes:
- http://autobuild.buildroot.org/results/7edc29e21e441e66ad7c4df1673e506950930913
---
Changes v1 -> v2:
- Update patch to avoid a build failure on macos
...eatures.cmake-fix-DENABLE_CPU_USAGE_.patch | 38 +++++++++++++++++++ package/hawktracer/hawktracer.mk | 8 +++- 2 files changed, 44 insertions(+), 2 deletions(-) create mode 100644 package/hawktracer/0001-cmake-platform_features.cmake-fix-DENABLE_CPU_USAGE_.patch
package/hawktracer/0001-cmake-platform_features.cmake-fix-DENABLE_CPU_USAGE_.patch new file +38 -0
@@ -0,0 +1,38 @@ +From 65e78e2b972e2fab76b18732941ae611ec782dee Mon Sep 17 00:00:00 2001 +From: Fabrice Fontaine <[email protected]> +Date: Fri, 12 Aug 2022 14:51:33 +0200 +Subject: [PATCH] cmake/platform_features.cmake: fix + -DENABLE_CPU_USAGE_FEATURE=OFF + +Fix -DENABLE_CPU_USAGE_FEATURE=OFF to allow the user to disable +CPU_USAGE and avoid the following build failure without threads: + +/home/giuliobenetti/autobuild/run/instance-2/output-1/build/hawktracer-e53b07bc812c4cfe8f6253ddb48ac43de8fa74a8/lib/platform/linux/cpu_usage.c:5:10: fatal error: pthread.h: No such file or directory + 5 | #include <pthread.h> + | ^~~~~~~~~~~ + +Fixes: + - http://autobuild.buildroot.org/results/7edc29e21e441e66ad7c4df1673e506950930913 + +Signed-off-by: Fabrice Fontaine <[email protected]> +[Upstream status: https://github.com/amzn/hawktracer/pull/86] +--- + cmake/platform_features.cmake | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/cmake/platform_features.cmake b/cmake/platform_features.cmake +index 1abbd41..8d7cfd9 100644 +--- a/cmake/platform_features.cmake ++++ b/cmake/platform_features.cmake +@@ -18,7 +18,7 @@ macro(_validate_feature_enabled FEATURE_NAME VARIABLE) + endmacro(_validate_feature_enabled) + + macro(define_platform_feature FEATURE_NAME FEATURE_DEFAULT_FILE DEFAULT_ENABLE) +- if (NOT "${DEFAULT_ENABLE}" STREQUAL "OFF" OR "${ENABLE_${FEATURE_NAME}_FEATURE}" STREQUAL "ON") ++ if (NOT "${DEFAULT_ENABLE}" STREQUAL "OFF" AND NOT "${ENABLE_${FEATURE_NAME}_FEATURE}" STREQUAL "OFF") + set(OPTION_VALUE ON) + else() + set(OPTION_VALUE OFF) +-- +2.35.1 +
package/hawktracer/hawktracer.mk +6 -2
@@ -36,9 +36,13 @@ endif # Enable threads support if supported by toolchain ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) -HAWKTRACER_CONF_OPTS += -DENABLE_THREADS=ON +HAWKTRACER_CONF_OPTS += \ + -DENABLE_CPU_USAGE_FEATURE=ON \ + -DENABLE_THREADS=ON else -HAWKTRACER_CONF_OPTS += -DENABLE_THREADS=OFF +HAWKTRACER_CONF_OPTS += \ + -DENABLE_CPU_USAGE_FEATURE=OFF \ + -DENABLE_THREADS=OFF endif $(eval $(cmake-package))
Signature · 6 lines
2.35.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedQuoted 8 lines · On Fri, 12 Aug 2022 16:38:59 +0200 Fabrice Fontaine…
Fix the following build failure without threads raised since the addition of the package in commit
94d8764ef938936aa5432f1f13bd1b2d8b62a159:
/home/giuliobenetti/autobuild/run/instance-2/output-1/build/hawktracer-e53b07bc812c4cfe8f6253ddb48ac43de8fa74a8/lib/platform/linux/cpu_usage.c:5:10: fatal error:pthread.h: No such file or directory
5 | #include <pthread.h>
| ^~~~~~~~~~~
Quoted 7 lines
Fixes:
- http://autobuild.buildroot.org/results/7edc29e21e441e66ad7c4df1673e506950930913Signed-off-by Fabrice Fontaine <[email protected]>---
Changes v1 -> v2:
- Update patch to avoid a build failure on macos
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot