Skip to contentSkip to conversation

crypto: axis: artpec6_crypto: move spin_lock_bh to spin_lock in tasklet

PATCH In review Tuo Cao 2 participants 2 messages Aug 14, 2022 – Aug 19, 2022

Subsystems (2)
lore
Share & tools
lore

Tuo Cao

author
#0 lore raw

PATCH 1/1 crypto: axis: artpec6_crypto: move spin_lock_bh to spin_lock in tasklet

it is unnecessary to call spin_lock_bh in a tasklet.

---
 drivers/crypto/axis/artpec6_crypto.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/axis/artpec6_crypto.c +2 -2
index 9ad188cffd0d..b4820594ab80 100644
@@ -2091,7 +2091,7 @@ static void artpec6_crypto_task(unsigned long data)
 		return;
 	}
 
-	spin_lock_bh(&ac->queue_lock);
+	spin_lock(&ac->queue_lock);
 
 	list_for_each_entry_safe(req, n, &ac->pending, list) {
 		struct artpec6_crypto_dma_descriptors *dma = req->dma;
@@ -2128,7 +2128,7 @@ static void artpec6_crypto_task(unsigned long data)
 
 	artpec6_crypto_process_queue(ac, &complete_in_progress);
 
-	spin_unlock_bh(&ac->queue_lock);
+	spin_unlock(&ac->queue_lock);
 
 	/* Perform the completion callbacks without holding the queue lock
 	 * to allow new request submissions from the callbacks.
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 6 lines · Tuo Cao

it is unnecessary to call spin_lock_bh in a tasklet.

---
 drivers/crypto/axis/artpec6_crypto.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt