Skip to contentSkip to conversation

dmaengine: qcom: gpi: move read_lock_bh to read_lock in tasklet

PATCH Applied Tuo Cao 2 participants 2 messages Aug 14, 2022 – Sep 29, 2022

Subsystems (2)
lore
Share & tools
lore

Tuo Cao

author
#0 lore raw

PATCH 1/1 dmaengine: qcom: gpi: move read_lock_bh to read_lock in tasklet

it is unnecessary to call read_lock_bh in a tasklet.

---
 drivers/dma/qcom/gpi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/dma/qcom/gpi.c +3 -3
index 8f0c9c4e2efd..236005f7dd30 100644
@@ -1150,9 +1150,9 @@ static void gpi_ev_tasklet(unsigned long data)
 {
 	struct gpii *gpii = (struct gpii *)data;
 
-	read_lock_bh(&gpii->pm_lock);
+	read_lock(&gpii->pm_lock);
 	if (!REG_ACCESS_VALID(gpii->pm_state)) {
-		read_unlock_bh(&gpii->pm_lock);
+		read_unlock(&gpii->pm_lock);
 		dev_err(gpii->gpi_dev->dev, "not processing any events, pm_state:%s\n",
 			TO_GPI_PM_STR(gpii->pm_state));
 		return;
@@ -1163,7 +1163,7 @@ static void gpi_ev_tasklet(unsigned long data)
 
 	/* enable IEOB, switching back to interrupts */
 	gpi_config_interrupts(gpii, MASK_IEOB_SETTINGS, 1);
-	read_unlock_bh(&gpii->pm_lock);
+	read_unlock(&gpii->pm_lock);
 }
 
 /* marks all pending events for the channel as stale */
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 1 line · Tuo Cao

it is unnecessary to call read_lock_bh in a tasklet.

Applied, thanks

Signature · 1 line
~Vinod