crypto: tcrypt - remove mode=1000
PATCH 1/1 crypto: tcrypt - remove mode=1000
The lists of algothms checked for existence by
modprobe tcrypt mode=1000
generates three bogus errors:
modprobe tcrypt mode=1000
console log:
tcrypt: alg rot13 not found
tcrypt: alg cts not found
tcrypt: alg arc4 not found
rot13 is not an algorithm in the crypto API or tested.
cts is a wrapper, not a base algorithm.
arc4 is named ecb(arc4), not arc4.
Also, the list is missing numerous algorithms that are tested by other test modes:
blake2b-512
blake2s-256
crct10dif
xxhash64
ghash
cast5
sm4
ansi_prngSeveral of the algorithms are only available if CONFIG_CRYPTO_USER_API_ENABLE_OBSOLETE is enabled:
arc4
khazad
seed
tea, xtea, xeta
Rather that fix that list, remove test mode=1000 entirely. It seems to have limited utility, and a web search shows no discussion of anybody using it.
--- crypto/tcrypt.c | 28 ---------------------------- 1 file changed, 28 deletions(-)
crypto/tcrypt.c +0 -28
@@ -65,18 +65,6 @@ static int mode;static u32 num_mb =8 ;static unsigned int klen;static char *tvmem[TVMEMSIZE ]; - -static const char *check[] = { -"des" ,"md5" ,"des3_ede" ,"rot13" ,"sha1" ,"sha224" ,"sha256" ,"sm3" , -"blowfish" ,"twofish" ,"serpent" ,"sha384" ,"sha512" ,"md4" ,"aes" , -"cast6" ,"arc4" ,"michael_mic" ,"deflate" ,"crc32c" ,"tea" ,"xtea" , -"khazad" ,"wp512" ,"wp384" ,"wp256" ,"xeta" ,"fcrypt" , -"camellia" ,"seed" ,"rmd160" , -"lzo" ,"lzo-rle" ,"cts" ,"sha3-224" ,"sha3-256" ,"sha3-384" , -"sha3-512" ,"streebog256" ,"streebog512" , -NULL -}; -static const int block_sizes[] = {16 ,64 ,128 ,256 ,1024 ,1420 ,4096 ,0 };static const int aead_sizes[] = {16 ,64 ,256 ,512 ,1024 ,1420 ,4096 ,8192 ,0 };
@@ -1454,18 +1442,6 @@ static void test_cipher_speed(const char *algo, int enc, unsigned int secs, false); } -static void test_available (void ) -{ -const char **name = check; - -while (*name) { -printk ("alg %s " , *name); -printk (crypto_has_alg (*name,0 ,0 ) ? -"found\n" :"not found\n" ); - name++; - } -} -static inline int tcrypt_test (const char *alg) {int ret;
@@ -2825,10 +2801,6 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb)test_mb_skcipher_speed ("ctr(blowfish)" ,DECRYPT , sec,NULL ,0 , speed_template_8_32, num_mb);break ; - -case 1000 : -test_available (); -break ; }return ret;
Signature · 1 line
2.37.1
Quoted 35 lines · Robert Elliott
The lists of algothms checked for existence by
modprobe tcrypt mode=1000
generates three bogus errors:
modprobe tcrypt mode=1000console log:
tcrypt: alg rot13 not found
tcrypt: alg cts not found
tcrypt: alg arc4 not foundrot13 is not an algorithm in the crypto API or tested.
cts is a wrapper, not a base algorithm.
arc4 is named ecb(arc4), not arc4.
Also, the list is missing numerous algorithms that are tested by other test modes:
blake2b-512 blake2s-256 crct10dif xxhash64 ghash cast5 sm4 ansi_prngSeveral of the algorithms are only available if
CONFIG_CRYPTO_USER_API_ENABLE_OBSOLETEis enabled:
arc4
khazad
seed
tea, xtea, xeta
Quoted 6 lines
Rather that fix that list, remove test mode=1000 entirely. It seems to have limited utility, and a web search shows no discussion of anybody using it.
Suggested-by Ard Biesheuvel <[email protected]>Signed-off-by Robert Elliott <[email protected]>
Quoted 60 lines
--- crypto/tcrypt.c | 28 ---------------------------- 1 file changed, 28 deletions(-)crypto/tcrypt.c +0
-29@@ -65,18 +65,6 @@ static int mode;static u32 num_mb =8 ;static unsigned int klen;static char *tvmem[TVMEMSIZE ]; - -static const char *check[] = { -"des" ,"md5" ,"des3_ede" ,"rot13" ,"sha1" ,"sha224" ,"sha256" ,"sm3" , -"blowfish" ,"twofish" ,"serpent" ,"sha384" ,"sha512" ,"md4" ,"aes" , -"cast6" ,"arc4" ,"michael_mic" ,"deflate" ,"crc32c" ,"tea" ,"xtea" , -"khazad" ,"wp512" ,"wp384" ,"wp256" ,"xeta" ,"fcrypt" , -"camellia" ,"seed" ,"rmd160" , -"lzo" ,"lzo-rle" ,"cts" ,"sha3-224" ,"sha3-256" ,"sha3-384" , -"sha3-512" ,"streebog256" ,"streebog512" , -NULL -}; -static const int block_sizes[] = {16 ,64 ,128 ,256 ,1024 ,1420 ,4096 ,0 };static const int aead_sizes[] = {16 ,64 ,256 ,512 ,1024 ,1420 ,4096 ,8192 ,0 };@@ -1454,18 +1442,6 @@ static void test_cipher_speed(const char *algo, int enc, unsigned int secs, false); } -static void test_available (void ) -{ -const char **name = check; - -while (*name) { -printk ("alg %s " , *name); -printk (crypto_has_alg (*name,0 ,0 ) ? -"found\n" :"not found\n" ); - name++; - } -} -static inline int tcrypt_test (const char *alg) {int ret;@@ -2825,10 +2801,6 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb)test_mb_skcipher_speed ("ctr(blowfish)" ,DECRYPT , sec,NULL ,0 , speed_template_8_32, num_mb);break ; - -case 1000 : -test_available (); -break ; }return ret; --2.37.1
Herbert Xu
maintainerQuoted 38 lines · Robert Elliott
The lists of algothms checked for existence by
modprobe tcrypt mode=1000
generates three bogus errors:
modprobe tcrypt mode=1000console log:
tcrypt: alg rot13 not found
tcrypt: alg cts not found
tcrypt: alg arc4 not foundrot13 is not an algorithm in the crypto API or tested.
cts is a wrapper, not a base algorithm.
arc4 is named ecb(arc4), not arc4.
Also, the list is missing numerous algorithms that are tested by other test modes:
blake2b-512 blake2s-256 crct10dif xxhash64 ghash cast5 sm4 ansi_prngSeveral of the algorithms are only available if
CONFIG_CRYPTO_USER_API_ENABLE_OBSOLETEis enabled:
arc4
khazad
seed
tea, xtea, xetaRather that fix that list, remove test mode=1000 entirely. It seems to have limited utility, and a web search shows no discussion of anybody using it.
Quoted 5 lines
Suggested-by Ard Biesheuvel <[email protected]>Signed-off-by Robert Elliott <[email protected]>--- crypto/tcrypt.c | 28 ---------------------------- 1 file changed, 28 deletions(-)
I think it would be better to use alg_test_descs as the source list of get rid of check. But I never use this so unless someone else complains I'm fine with removing it.
Thanks,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Herbert Xu
maintainerQuoted 38 lines · Robert Elliott
The lists of algothms checked for existence by
modprobe tcrypt mode=1000
generates three bogus errors:
modprobe tcrypt mode=1000console log:
tcrypt: alg rot13 not found
tcrypt: alg cts not found
tcrypt: alg arc4 not foundrot13 is not an algorithm in the crypto API or tested.
cts is a wrapper, not a base algorithm.
arc4 is named ecb(arc4), not arc4.
Also, the list is missing numerous algorithms that are tested by other test modes:
blake2b-512 blake2s-256 crct10dif xxhash64 ghash cast5 sm4 ansi_prngSeveral of the algorithms are only available if
CONFIG_CRYPTO_USER_API_ENABLE_OBSOLETEis enabled:
arc4
khazad
seed
tea, xtea, xetaRather that fix that list, remove test mode=1000 entirely. It seems to have limited utility, and a web search shows no discussion of anybody using it.
Quoted 5 lines
Suggested-by Ard Biesheuvel <[email protected]>Signed-off-by Robert Elliott <[email protected]>--- crypto/tcrypt.c | 28 ---------------------------- 1 file changed, 28 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt