Skip to contentSkip to conversation

media: rockchip: rga: Fix probe rga_parse_dt bugs

PATCH New Jarrah Gosbell 1 participant 1 message Aug 15, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 media: rockchip: rga: Fix probe rga_parse_dt bugs

From: Ondrej Jirman <[email protected]>

rga_parse_dt is missing a error return, so if some of the resources return DEFER_PROBE, probe will succeed without these resources.

---
v1 -> v2: use dev_err_probe to handle -EPROBE_DEFER.

 drivers/media/platform/rockchip/rga/rga.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/rockchip/rga/rga.c +1 -1
index 2f8df74ad0fd..61b25fcf826e 100644
@@ -816,7 +816,7 @@ static int rga_probe(struct platform_device *pdev)
 
 	ret = rga_parse_dt(rga);
 	if (ret)
-		dev_err(&pdev->dev, "Unable to parse OF data\n");
+		return dev_err_probe(&pdev->dev, ret, "Unable to parse OF data\n");
 
 	pm_runtime_enable(rga->dev);
 
Signature · 1 line
2.35.1