5.18.18-rc1 review
Subsystems (12)
Greg Kroah-Hartman
maintainerPATCH 465/1095 media: uapi: HEVC: Change pic_order_cnt definition in v4l2_hevc_dpb_entry
In reply to Greg Kroah-HartmanFrom: Benjamin Gaignard <[email protected]>
[ Upstream commit c4a179c7167ee16aad1267f9c99bc1ecff475585 ]
The HEVC specification describes the following:
"PicOrderCntVal is derived as follows:
PicOrderCntVal = PicOrderCntMsb + slice_pic_order_cnt_lsb The value of PicOrderCntVal shall be in the range of −2^31 to 2^31 − 1, inclusive."
To match with these definitions change __u16 pic_order_cnt[2] into __s32 pic_order_cnt_val.
Change v4l2_ctrl_hevc_slice_params->slice_pic_order_cnt to __s32 too.
--- Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 2 +- drivers/staging/media/hantro/hantro_g2_hevc_dec.c | 7 +++---- drivers/staging/media/hantro/hantro_hevc.c | 2 +- drivers/staging/media/hantro/hantro_hw.h | 4 ++-- drivers/staging/media/sunxi/cedrus/cedrus_h265.c | 4 ++-- include/media/hevc-ctrls.h | 4 ++-- 6 files changed, 11 insertions(+), 12 deletions(-)
Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst +1 -1
@@ -2975,7 +2975,7 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - * - __u8 - ``colour_plane_id`` - - * - __u16 + * - __s32 - ``slice_pic_order_cnt`` - * - __u8
drivers/staging/media/hantro/hantro_g2_hevc_dec.c +3 -4
@@ -390,11 +390,10 @@ static int set_ref(struct hantro_ctx *ctx) !!(pps->flags & V4L2_HEVC_PPS_FLAG_LOOP_FILTER_ACROSS_TILES_ENABLED));/* -* Write POC count diff from current pic. For frame decoding only compute -* pic_order_cnt[0] and ignore pic_order_cnt[1] used in field-coding. +* Write POC count diff from current pic. */ for (i =0 ; i < decode_params->num_active_dpb_entries && i <ARRAY_SIZE (cur_poc); i++) { -char poc_diff = decode_params->pic_order_cnt_val - dpb[i].pic_order_cnt[0 ]; +char poc_diff = decode_params->pic_order_cnt_val - dpb[i].pic_order_cnt_val;hantro_reg_write (vpu, &cur_poc[i], poc_diff); }
@@ -421,7 +420,7 @@ static int set_ref(struct hantro_ctx *ctx) dpb_longterm_e =0 ;for (i =0 ; i < decode_params->num_active_dpb_entries && i < (V4L2_HEVC_DPB_ENTRIES_NUM_MAX -1 ); i++) { - luma_addr =hantro_hevc_get_ref_buf (ctx, dpb[i].pic_order_cnt[0 ]); + luma_addr =hantro_hevc_get_ref_buf (ctx, dpb[i].pic_order_cnt_val);if (!luma_addr)return -ENOMEM ;
drivers/staging/media/hantro/hantro_hevc.c +1 -1
@@ -33,7 +33,7 @@ void hantro_hevc_ref_init(struct hantro_ctx *ctx) }dma_addr_t hantro_hevc_get_ref_buf (struct hantro_ctx *ctx, -int poc) +s32 poc) {struct hantro_hevc_dec_hw_ctx *hevc_dec = &ctx->hevc_dec;int i;
drivers/staging/media/hantro/hantro_hw.h +2 -2
@@ -143,7 +143,7 @@ struct hantro_hevc_dec_hw_ctx {struct hantro_aux_buf tile_bsd;struct hantro_aux_buf ref_bufs[NUM_REF_PICTURES ];struct hantro_aux_buf scaling_lists; -int ref_bufs_poc[NUM_REF_PICTURES ]; +s32 ref_bufs_poc[NUM_REF_PICTURES ];u32 ref_bufs_used;struct hantro_hevc_dec_ctrls ctrls;unsigned int num_tile_cols_allocated;
@@ -351,7 +351,7 @@ void hantro_hevc_dec_exit(struct hantro_ctx *ctx);int hantro_g2_hevc_dec_run (struct hantro_ctx *ctx);int hantro_hevc_dec_prepare_run (struct hantro_ctx *ctx);void hantro_hevc_ref_init (struct hantro_ctx *ctx); -dma_addr_t hantro_hevc_get_ref_buf (struct hantro_ctx *ctx,int poc); +dma_addr_t hantro_hevc_get_ref_buf (struct hantro_ctx *ctx,s32 poc);int hantro_hevc_add_ref_buf (struct hantro_ctx *ctx,int poc,dma_addr_t addr);int hantro_hevc_validate_sps (struct hantro_ctx *ctx,const struct v4l2_ctrl_hevc_sps *sps);
drivers/staging/media/sunxi/cedrus/cedrus_h265.c +2 -2
@@ -143,8 +143,8 @@ static void cedrus_h265_frame_info_write_dpb(struct cedrus_ctx *ctx,for (i =0 ; i < num_active_dpb_entries; i++) {int buffer_index =vb2_find_timestamp (vq, dpb[i].timestamp,0 );u32 pic_order_cnt[2 ] = { - dpb[i].pic_order_cnt[0 ], - dpb[i].pic_order_cnt[1 ] + dpb[i].pic_order_cnt_val, + dpb[i].pic_order_cnt_val }; cedrus_h265_frame_info_write_single(ctx, i, dpb[i].field_pic,
include/media/hevc-ctrls.h +2 -2
@@ -135,7 +135,7 @@ struct v4l2_hevc_dpb_entry {__u64 timestamp;__u8 flags;__u8 field_pic; -__u16 pic_order_cnt[2 ]; +__s32 pic_order_cnt_val;__u8 padding[2 ]; };
@@ -178,7 +178,7 @@ struct v4l2_ctrl_hevc_slice_params {/* ISO/IEC 23008-2, ITU-T Rec. H.265: General slice segment header */ __u8 slice_type;__u8 colour_plane_id; -__u16 slice_pic_order_cnt; +__s32 slice_pic_order_cnt;__u8 num_ref_idx_l0_active_minus1;__u8 num_ref_idx_l1_active_minus1;__u8 collocated_ref_idx;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 466/1095 media: cedrus: h265: Fix logic for not low delay flag
In reply to Greg Kroah-HartmanFrom: Jernej Skrabec <[email protected]>
[ Upstream commit f1a413902aa71044b6ec41265e5e28ebaf29a9ce ]
Now that we know real purpose of "not low delay" flag, logic for applying this flag should be fixed too. According to vendor and reference implementation, low delay is signaled when POC of current frame is lower than POC of at least one reference of a slice.
Implement mentioned logic and invert it to conform to flag meaning. Also don't apply flag for I frames. They don't have any reference.
This fixes decoding of 3 reference bitstreams.
--- .../staging/media/sunxi/cedrus/cedrus_h265.c | 27 ++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-)
drivers/staging/media/sunxi/cedrus/cedrus_h265.c +26 -1
@@ -301,6 +301,31 @@ static void cedrus_h265_write_scaling_list(struct cedrus_ctx *ctx, } } +static int cedrus_h265_is_low_delay (struct cedrus_run *run) +{ +const struct v4l2_ctrl_hevc_slice_params *slice_params; +const struct v4l2_hevc_dpb_entry *dpb; +s32 poc; +int i; + + slice_params = run->h265.slice_params; + poc = run->h265.decode_params->pic_order_cnt_val; + dpb = run->h265.decode_params->dpb; + +for (i =0 ; i < slice_params->num_ref_idx_l0_active_minus1 +1 ; i++) +if (dpb[slice_params->ref_idx_l0[i]].pic_order_cnt_val > poc) +return 1 ; + +if (slice_params->slice_type !=V4L2_HEVC_SLICE_TYPE_B ) +return 0 ; + +for (i =0 ; i < slice_params->num_ref_idx_l1_active_minus1 +1 ; i++) +if (dpb[slice_params->ref_idx_l1[i]].pic_order_cnt_val > poc) +return 1 ; + +return 0 ; +} +static void cedrus_h265_setup (struct cedrus_ctx *ctx,struct cedrus_run *run) {
@@ -571,7 +596,7 @@ static void cedrus_h265_setup(struct cedrus_ctx *ctx,V4L2_HEVC_SLICE_PARAMS_FLAG_SLICE_LOOP_FILTER_ACROSS_SLICES_ENABLED , slice_params->flags); -if (decode_params->num_poc_st_curr_after ==0 ) +if (slice_params->slice_type !=V4L2_HEVC_SLICE_TYPE_I && !cedrus_h265_is_low_delay (run)) reg |=VE_DEC_H265_DEC_SLICE_HDR_INFO1_FLAG_SLICE_NOT_LOW_DELAY ;cedrus_write (dev,VE_DEC_H265_DEC_SLICE_HDR_INFO1 , reg);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 467/1095 wifi: wil6210: debugfs: fix info leak in wil_write_file_wmi()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit 7a4836560a6198d245d5732e26f94898b12eb760 ]
The simple_write_to_buffer() function will succeed if even a single byte is initialized. However, we need to initialize the whole buffer to prevent information leaks. Just use memdup_user().
--- drivers/net/wireless/ath/wil6210/debugfs.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)
drivers/net/wireless/ath/wil6210/debugfs.c +4 -10
@@ -1012,18 +1012,12 @@ static ssize_t wil_write_file_wmi(struct file *file, const char __user *buf,u16 cmdid;int rc, rc1; -if (cmdlen <0 ) +if (cmdlen <0 || *ppos !=0 )return -EINVAL ; - wmi =kmalloc (len,GFP_KERNEL ); -if (!wmi) -return -ENOMEM ; - - rc =simple_write_to_buffer (wmi, len, ppos, buf, len); -if (rc <0 ) { -kfree (wmi); -return rc; - } + wmi =memdup_user (buf, len); +if (IS_ERR (wmi)) +return PTR_ERR (wmi); cmd = (cmdlen >0 ) ? &wmi[1 ] :NULL ; cmdid =le16_to_cpu (wmi->command_id);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 468/1095 wifi: p54: Fix an error handling path in p54spi_probe()
In reply to Greg Kroah-HartmanFrom: Christophe JAILLET <[email protected]>
[ Upstream commit 83781f0162d080fec7dcb911afd1bc2f5ad04471 ]
If an error occurs after a successful call to p54spi_request_firmware(), it must be undone by a corresponding release_firmware() as already done in the error handling path of p54spi_request_firmware() and in the .remove() function.
Add the missing call in the error handling path and remove it from p54spi_request_firmware() now that it is the responsibility of the caller to release the firmware
--- drivers/net/wireless/intersil/p54/p54spi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/intersil/p54/p54spi.c +2 -1
@@ -164,7 +164,7 @@ static int p54spi_request_firmware(struct ieee80211_hw *dev) ret =p54_parse_firmware (dev, priv->firmware);if (ret) { -release_firmware (priv->firmware); +/* the firmware is released by the caller */ return ret; }
@@ -659,6 +659,7 @@ static int p54spi_probe(struct spi_device *spi)return 0 ; err_free_common: +release_firmware (priv->firmware);free_irq (gpio_to_irq (p54spi_gpio_irq), spi); err_free_gpio_irq:gpio_free (p54spi_gpio_irq);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 469/1095 wifi: p54: add missing parentheses in p54_flush()
In reply to Greg Kroah-HartmanFrom: Rustam Subkhankulov <[email protected]>
[ Upstream commit bcfd9d7f6840b06d5988c7141127795cf405805e ]
The assignment of the value to the variable total in the loop condition must be enclosed in additional parentheses, since otherwise, in accordance with the precedence of the operators, the conjunction will be performed first, and only then the assignment.
Due to this error, a warning later in the function after the loop may not occur in the situation when it should.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
--- drivers/net/wireless/intersil/p54/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intersil/p54/main.c +1 -1
@@ -682,7 +682,7 @@ static void p54_flush(struct ieee80211_hw *dev, struct ieee80211_vif *vif,* queues have already been stopped and no new frames can sneak * up from behind. */ -while ((total =p54_flush_count (priv) && i--)) { +while ((total =p54_flush_count (priv)) && i--) {/* waste time */ msleep (20 ); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 470/1095 drm/amdgpu: use the same HDP flush registers for all nbio 7.4.x
In reply to Greg Kroah-HartmanFrom: Alex Deucher <[email protected]>
[ Upstream commit 912db6a58738e8be502838eb6a88f207ba356cd7 ]
Align aldebaran with all other asics. One HDP bit per
SDMA instance, aligned with firmware. This is effectively
a revert of
commit a0f9f8546668 ("drm/amdgpu/nbio7.4: don't use GPU_HDP_FLUSH bit 12"). On further discussions with the relevant hardware teams, re-align the bits for SDMA.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 +---- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 21 ------------------- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.h | 1 - 3 files changed, 1 insertion(+), 26 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +1 -4
@@ -1891,12 +1891,9 @@ int amdgpu_discovery_set_ip_blocks(struct amdgpu_device *adev)break ;case IP_VERSION (7 ,4 ,0 ):case IP_VERSION (7 ,4 ,1 ): - adev->nbio.funcs = &nbio_v7_4_funcs; - adev->nbio.hdp_flush_reg = &nbio_v7_4_hdp_flush_reg; -break ;case IP_VERSION (7 ,4 ,4 ): adev->nbio.funcs = &nbio_v7_4_funcs; - adev->nbio.hdp_flush_reg = &nbio_v7_4_hdp_flush_reg_ald; + adev->nbio.hdp_flush_reg = &nbio_v7_4_hdp_flush_reg;break ;case IP_VERSION (7 ,2 ,0 ):case IP_VERSION (7 ,2 ,1 ):
drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c +0 -21
@@ -339,27 +339,6 @@ const struct nbio_hdp_flush_reg nbio_v7_4_hdp_flush_reg = { .ref_and_mask_sdma1 = GPU_HDP_FLUSH_DONE__SDMA1_MASK, }; -const struct nbio_hdp_flush_reg nbio_v7_4_hdp_flush_reg_ald = { - .ref_and_mask_cp0 =GPU_HDP_FLUSH_DONE__CP0_MASK , - .ref_and_mask_cp1 =GPU_HDP_FLUSH_DONE__CP1_MASK , - .ref_and_mask_cp2 =GPU_HDP_FLUSH_DONE__CP2_MASK , - .ref_and_mask_cp3 =GPU_HDP_FLUSH_DONE__CP3_MASK , - .ref_and_mask_cp4 =GPU_HDP_FLUSH_DONE__CP4_MASK , - .ref_and_mask_cp5 =GPU_HDP_FLUSH_DONE__CP5_MASK , - .ref_and_mask_cp6 =GPU_HDP_FLUSH_DONE__CP6_MASK , - .ref_and_mask_cp7 =GPU_HDP_FLUSH_DONE__CP7_MASK , - .ref_and_mask_cp8 =GPU_HDP_FLUSH_DONE__CP8_MASK , - .ref_and_mask_cp9 =GPU_HDP_FLUSH_DONE__CP9_MASK , - .ref_and_mask_sdma0 =GPU_HDP_FLUSH_DONE__RSVD_ENG1_MASK , - .ref_and_mask_sdma1 =GPU_HDP_FLUSH_DONE__RSVD_ENG2_MASK , - .ref_and_mask_sdma2 =GPU_HDP_FLUSH_DONE__RSVD_ENG3_MASK , - .ref_and_mask_sdma3 =GPU_HDP_FLUSH_DONE__RSVD_ENG4_MASK , - .ref_and_mask_sdma4 =GPU_HDP_FLUSH_DONE__RSVD_ENG5_MASK , - .ref_and_mask_sdma5 =GPU_HDP_FLUSH_DONE__RSVD_ENG6_MASK , - .ref_and_mask_sdma6 =GPU_HDP_FLUSH_DONE__RSVD_ENG7_MASK , - .ref_and_mask_sdma7 =GPU_HDP_FLUSH_DONE__RSVD_ENG8_MASK , -}; -static void nbio_v7_4_init_registers (struct amdgpu_device *adev) {uint32_t baco_cntl;
drivers/gpu/drm/amd/amdgpu/nbio_v7_4.h +0 -1
@@ -27,7 +27,6 @@#include "soc15_common.h" extern const struct nbio_hdp_flush_reg nbio_v7_4_hdp_flush_reg; -extern const struct nbio_hdp_flush_reg nbio_v7_4_hdp_flush_reg_ald;extern const struct amdgpu_nbio_funcs nbio_v7_4_funcs;extern struct amdgpu_nbio_ras nbio_v7_4_ras;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 471/1095 drm/amdgpu: use the same HDP flush registers for all nbio 2.3.x
In reply to Greg Kroah-HartmanFrom: Alex Deucher <[email protected]>
[ Upstream commit 98a90f1f0fdd112b85b16ef6ceee69f319ab9311 ]
Align RDNA2.x with other asics. One HDP bit per SDMA instance, aligned with firmware. This is effectively a revert of
commit 369b7d04baf3 ("drm/amdgpu/nbio2.3: don't use GPU_HDP_FLUSH bit 12"). On further discussions with the relevant hardware teams, re-align the bits for SDMA.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 +---- drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 21 ------------------- drivers/gpu/drm/amd/amdgpu/nbio_v2_3.h | 1 - 3 files changed, 1 insertion(+), 26 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +1 -4
@@ -1907,15 +1907,12 @@ int amdgpu_discovery_set_ip_blocks(struct amdgpu_device *adev)case IP_VERSION (2 ,3 ,0 ):case IP_VERSION (2 ,3 ,1 ):case IP_VERSION (2 ,3 ,2 ): - adev->nbio.funcs = &nbio_v2_3_funcs; - adev->nbio.hdp_flush_reg = &nbio_v2_3_hdp_flush_reg; -break ;case IP_VERSION (3 ,3 ,0 ):case IP_VERSION (3 ,3 ,1 ):case IP_VERSION (3 ,3 ,2 ):case IP_VERSION (3 ,3 ,3 ): adev->nbio.funcs = &nbio_v2_3_funcs; - adev->nbio.hdp_flush_reg = &nbio_v2_3_hdp_flush_reg_sc; + adev->nbio.hdp_flush_reg = &nbio_v2_3_hdp_flush_reg;break ;default :break ;
drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c +0 -21
@@ -328,27 +328,6 @@ const struct nbio_hdp_flush_reg nbio_v2_3_hdp_flush_reg = { .ref_and_mask_sdma1 = BIF_BX_PF_GPU_HDP_FLUSH_DONE__SDMA1_MASK, }; -const struct nbio_hdp_flush_reg nbio_v2_3_hdp_flush_reg_sc = { - .ref_and_mask_cp0 =BIF_BX_PF_GPU_HDP_FLUSH_DONE__CP0_MASK , - .ref_and_mask_cp1 =BIF_BX_PF_GPU_HDP_FLUSH_DONE__CP1_MASK , - .ref_and_mask_cp2 =BIF_BX_PF_GPU_HDP_FLUSH_DONE__CP2_MASK , - .ref_and_mask_cp3 =BIF_BX_PF_GPU_HDP_FLUSH_DONE__CP3_MASK , - .ref_and_mask_cp4 =BIF_BX_PF_GPU_HDP_FLUSH_DONE__CP4_MASK , - .ref_and_mask_cp5 =BIF_BX_PF_GPU_HDP_FLUSH_DONE__CP5_MASK , - .ref_and_mask_cp6 =BIF_BX_PF_GPU_HDP_FLUSH_DONE__CP6_MASK , - .ref_and_mask_cp7 =BIF_BX_PF_GPU_HDP_FLUSH_DONE__CP7_MASK , - .ref_and_mask_cp8 =BIF_BX_PF_GPU_HDP_FLUSH_DONE__CP8_MASK , - .ref_and_mask_cp9 =BIF_BX_PF_GPU_HDP_FLUSH_DONE__CP9_MASK , - .ref_and_mask_sdma0 =GPU_HDP_FLUSH_DONE__RSVD_ENG1_MASK , - .ref_and_mask_sdma1 =GPU_HDP_FLUSH_DONE__RSVD_ENG2_MASK , - .ref_and_mask_sdma2 =GPU_HDP_FLUSH_DONE__RSVD_ENG3_MASK , - .ref_and_mask_sdma3 =GPU_HDP_FLUSH_DONE__RSVD_ENG4_MASK , - .ref_and_mask_sdma4 =GPU_HDP_FLUSH_DONE__RSVD_ENG5_MASK , - .ref_and_mask_sdma5 =GPU_HDP_FLUSH_DONE__RSVD_ENG6_MASK , - .ref_and_mask_sdma6 =GPU_HDP_FLUSH_DONE__RSVD_ENG7_MASK , - .ref_and_mask_sdma7 =GPU_HDP_FLUSH_DONE__RSVD_ENG8_MASK , -}; -static void nbio_v2_3_init_registers (struct amdgpu_device *adev) {uint32_t def, data;
drivers/gpu/drm/amd/amdgpu/nbio_v2_3.h +0 -1
@@ -27,7 +27,6 @@#include "soc15_common.h" extern const struct nbio_hdp_flush_reg nbio_v2_3_hdp_flush_reg; -extern const struct nbio_hdp_flush_reg nbio_v2_3_hdp_flush_reg_sc;extern const struct amdgpu_nbio_funcs nbio_v2_3_funcs;#endif
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 472/1095 drm/amdgpu: cleanup ctx implementation
In reply to Greg Kroah-HartmanFrom: Christian König <[email protected]>
[ Upstream commit 69493c034d2455204dfcd370de8c4dc204374a94 ]
Let each context have a pointer to the ctx manager and properly initialize the adev pointer inside the context manager.
Reduce the BUG_ON() in amdgpu_ctx_add_fence() into a WARN_ON() and directly return the sequence number instead of writing into a parmeter.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 46 ++++++++++++------------- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h | 11 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- 4 files changed, 30 insertions(+), 31 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +1 -1
@@ -1260,7 +1260,7 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p, p->fence =dma_fence_get (&job->base.s_fence->finished); -amdgpu_ctx_add_fence (p->ctx, entity, p->fence, &seq); + seq =amdgpu_ctx_add_fence (p->ctx, entity, p->fence);amdgpu_cs_post_dependencies (p); if ((job->preamble_status & AMDGPU_PREAMBLE_IB_PRESENT) &&
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c +22 -24
131 lines not on this page · raw message
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h +6 -5
@@ -40,7 +40,7 @@ struct amdgpu_ctx_entity {struct amdgpu_ctx {struct kref refcount; -struct amdgpu_device *adev; +struct amdgpu_ctx_mgr *mgr;unsigned reset_counter;unsigned reset_counter_query;uint32_t vram_lost_counter;
@@ -70,9 +70,9 @@ int amdgpu_ctx_put(struct amdgpu_ctx *ctx);int amdgpu_ctx_get_entity (struct amdgpu_ctx *ctx,u32 hw_ip,u32 instance,u32 ring,struct drm_sched_entity **entity); -void amdgpu_ctx_add_fence (struct amdgpu_ctx *ctx, -struct drm_sched_entity *entity, -struct dma_fence *fence,uint64_t *seq); +uint64_t amdgpu_ctx_add_fence (struct amdgpu_ctx *ctx, +struct drm_sched_entity *entity, +struct dma_fence *fence);struct dma_fence *amdgpu_ctx_get_fence (struct amdgpu_ctx *ctx,struct drm_sched_entity *entity,uint64_t seq);
@@ -85,7 +85,8 @@ int amdgpu_ctx_ioctl(struct drm_device *dev, void *data,int amdgpu_ctx_wait_prev_fence (struct amdgpu_ctx *ctx,struct drm_sched_entity *entity); -void amdgpu_ctx_mgr_init (struct amdgpu_ctx_mgr *mgr); +void amdgpu_ctx_mgr_init (struct amdgpu_ctx_mgr *mgr, +struct amdgpu_device *adev);void amdgpu_ctx_mgr_entity_fini (struct amdgpu_ctx_mgr *mgr);long amdgpu_ctx_mgr_entity_flush (struct amdgpu_ctx_mgr *mgr,long timeout);void amdgpu_ctx_mgr_fini (struct amdgpu_ctx_mgr *mgr);
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1 -1
@@ -1142,7 +1142,7 @@ int amdgpu_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv)mutex_init (&fpriv->bo_list_lock);idr_init (&fpriv->bo_list_handles); -amdgpu_ctx_mgr_init (&fpriv->ctx_mgr); +amdgpu_ctx_mgr_init (&fpriv->ctx_mgr, adev); file_priv->driver_priv = fpriv; goto out_suspend;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 473/1095 drm/amdgpu: restore original stable pstate on ctx fini
In reply to Greg Kroah-HartmanFrom: Alex Deucher <[email protected]>
[ Upstream commit 958afce98c2c86732483458c03540d3c6ef45254 ]
Save the original stable pstate on ctx init and restore it on ctx fini so that we restore a manually selected stable pstate on ctx exit.
v2: fix init order (Alex)
v3: don't add new variable to ctx struct (Evan)
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 60 ++++++++++++++----------- 1 file changed, 33 insertions(+), 27 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c +33 -27
@@ -220,32 +220,6 @@ static int amdgpu_ctx_init_entity(struct amdgpu_ctx *ctx, u32 hw_ip,return r; } -static int amdgpu_ctx_init (struct amdgpu_ctx_mgr *mgr,int32_t priority, -struct drm_file *filp,struct amdgpu_ctx *ctx) -{ -int r; - - r =amdgpu_ctx_priority_permit (filp, priority); -if (r) -return r; - -memset (ctx,0 ,sizeof (*ctx)); - -kref_init (&ctx->refcount); - ctx->mgr = mgr; -spin_lock_init (&ctx->ring_lock); -mutex_init (&ctx->lock); - - ctx->reset_counter =atomic_read (&mgr->adev->gpu_reset_counter); - ctx->reset_counter_query = ctx->reset_counter; - ctx->vram_lost_counter =atomic_read (&mgr->adev->vram_lost_counter); - ctx->init_priority = priority; - ctx->override_priority =AMDGPU_CTX_PRIORITY_UNSET ; - ctx->stable_pstate =AMDGPU_CTX_STABLE_PSTATE_NONE ; - -return 0 ; -} -static void amdgpu_ctx_fini_entity (struct amdgpu_ctx_entity *entity) {
@@ -288,6 +262,38 @@ static int amdgpu_ctx_get_stable_pstate(struct amdgpu_ctx *ctx,return 0 ; } +static int amdgpu_ctx_init (struct amdgpu_ctx_mgr *mgr,int32_t priority, +struct drm_file *filp,struct amdgpu_ctx *ctx) +{ +u32 current_stable_pstate; +int r; + + r =amdgpu_ctx_priority_permit (filp, priority); +if (r) +return r; + +memset (ctx,0 ,sizeof (*ctx)); + +kref_init (&ctx->refcount); + ctx->mgr = mgr; +spin_lock_init (&ctx->ring_lock); +mutex_init (&ctx->lock); + + ctx->reset_counter =atomic_read (&mgr->adev->gpu_reset_counter); + ctx->reset_counter_query = ctx->reset_counter; + ctx->vram_lost_counter =atomic_read (&mgr->adev->vram_lost_counter); + ctx->init_priority = priority; + ctx->override_priority =AMDGPU_CTX_PRIORITY_UNSET ; + + r =amdgpu_ctx_get_stable_pstate (ctx, ¤t_stable_pstate); +if (r) +return r; + + ctx->stable_pstate = current_stable_pstate; + +return 0 ; +} +static int amdgpu_ctx_set_stable_pstate (struct amdgpu_ctx *ctx,u32 stable_pstate) {
@@ -357,7 +363,7 @@ static void amdgpu_ctx_fini(struct kref *ref) }if (drm_dev_enter (&adev->ddev, &idx)) { -amdgpu_ctx_set_stable_pstate (ctx,AMDGPU_CTX_STABLE_PSTATE_NONE ); +amdgpu_ctx_set_stable_pstate (ctx, ctx->stable_pstate);drm_dev_exit (idx); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 474/1095 bpf: Make btf_find_field more generic
In reply to Greg Kroah-HartmanFrom: Kumar Kartikeya Dwivedi <[email protected]>
[ Upstream commit 42ba1308074d9046386d58b56e793604be48ce22 ]
Next commit introduces field type 'kptr' whose kind will not be struct, but pointer, and it will not be limited to one offset, but multiple ones. Make existing btf_find_struct_field and btf_find_datasec_var functions amenable to use for finding kptrs in map value, by moving spin_lock and timer specific checks into their own function.
The alignment, and name are checked before the function is called, so it is the last point where we can skip field or return an error before the next loop iteration happens. Size of the field and type is meant to be checked inside the function.
--- kernel/bpf/btf.c | 120 +++++++++++++++++++++++++++++++++++------------ 1 file changed, 89 insertions(+), 31 deletions(-)
kernel/bpf/btf.c +89 -31
@@ -3163,24 +3163,44 @@ static void btf_struct_log(struct btf_verifier_env *env,btf_verifier_log (env,"size=%u vlen=%u" , t->size,btf_type_vlen (t)); } +enum btf_field_type { +BTF_FIELD_SPIN_LOCK , +BTF_FIELD_TIMER , +}; + +struct btf_field_info { +u32 off; +}; + +static int btf_find_struct (const struct btf *btf,const struct btf_type *t, +u32 off,int sz,struct btf_field_info *info) +{ +if (!__btf_type_is_struct (t)) +return 0 ; +if (t->size != sz) +return 0 ; +if (info->off != -ENOENT ) +/* only one such field is allowed */ +return -E2BIG ; + info->off = off; +return 0 ; +} +static int btf_find_struct_field (const struct btf *btf,const struct btf_type *t, -const char *name,int sz,int align) +const char *name,int sz,int align, +enum btf_field_type field_type, +struct btf_field_info *info) {const struct btf_member *member; -u32 i, off = -ENOENT ; +u32 i, off;for_each_member (i, t, member) {const struct btf_type *member_type =btf_type_by_id (btf, member->type); -if (!__btf_type_is_struct (member_type)) -continue ; -if (member_type->size != sz) -continue ; +if (strcmp (__btf_name_by_offset (btf, member_type->name_off), name))continue ; -if (off != -ENOENT ) -/* only one such field is allowed */ -return -E2BIG ; + off =__btf_member_bit_offset (t, member);if (off %8 )/* valid C code cannot generate such BTF */
@@ -3188,46 +3208,76 @@ static int btf_find_struct_field(const struct btf *btf, const struct btf_type *t off /=8 ;if (off % align)return -EINVAL ; + +switch (field_type) { +case BTF_FIELD_SPIN_LOCK : +case BTF_FIELD_TIMER : +return btf_find_struct (btf, member_type, off, sz, info); +default : +return -EFAULT ; + } } -return off; +return 0 ; }static int btf_find_datasec_var (const struct btf *btf,const struct btf_type *t, -const char *name,int sz,int align) +const char *name,int sz,int align, +enum btf_field_type field_type, +struct btf_field_info *info) {const struct btf_var_secinfo *vsi; -u32 i, off = -ENOENT ; +u32 i, off;for_each_vsi (i, t, vsi) {const struct btf_type *var =btf_type_by_id (btf, vsi->type);const struct btf_type *var_type =btf_type_by_id (btf, var->type); -if (!__btf_type_is_struct (var_type)) -continue ; -if (var_type->size != sz) + off = vsi->offset; + +if (strcmp (__btf_name_by_offset (btf, var_type->name_off), name))continue ;if (vsi->size != sz)continue ; -if (strcmp (__btf_name_by_offset (btf, var_type->name_off), name)) -continue ; -if (off != -ENOENT ) -/* only one such field is allowed */ -return -E2BIG ; - off = vsi->offset;if (off % align)return -EINVAL ; + +switch (field_type) { +case BTF_FIELD_SPIN_LOCK : +case BTF_FIELD_TIMER : +return btf_find_struct (btf, var_type, off, sz, info); +default : +return -EFAULT ; + } } -return off; +return 0 ; }static int btf_find_field (const struct btf *btf,const struct btf_type *t, -const char *name,int sz,int align) +enum btf_field_type field_type, +struct btf_field_info *info) { +const char *name; +int sz, align; + +switch (field_type) { +case BTF_FIELD_SPIN_LOCK : + name ="bpf_spin_lock" ; + sz =sizeof (struct bpf_spin_lock ); + align = __alignof__(struct bpf_spin_lock ); +break ; +case BTF_FIELD_TIMER : + name ="bpf_timer" ; + sz =sizeof (struct bpf_timer ); + align = __alignof__(struct bpf_timer ); +break ; +default : +return -EFAULT ; + }if (__btf_type_is_struct (t)) -return btf_find_struct_field (btf, t, name, sz, align); +return btf_find_struct_field (btf, t, name, sz, align, field_type, info);else if (btf_type_is_datasec (t)) -return btf_find_datasec_var (btf, t, name, sz, align); +return btf_find_datasec_var (btf, t, name, sz, align, field_type, info);return -EINVAL ; }
@@ -3237,16 +3287,24 @@ static int btf_find_field(const struct btf *btf, const struct btf_type *t,*/ int btf_find_spin_lock (const struct btf *btf,const struct btf_type *t) { -return btf_find_field (btf, t,"bpf_spin_lock" , -sizeof (struct bpf_spin_lock ), - __alignof__(struct bpf_spin_lock )); +struct btf_field_info info = { .off = -ENOENT }; +int ret; + + ret =btf_find_field (btf, t,BTF_FIELD_SPIN_LOCK , &info); +if (ret <0 ) +return ret; +return info.off; }int btf_find_timer (const struct btf *btf,const struct btf_type *t) { -return btf_find_field (btf, t,"bpf_timer" , -sizeof (struct bpf_timer ), - __alignof__(struct bpf_timer )); +struct btf_field_info info = { .off = -ENOENT }; +int ret; + + ret =btf_find_field (btf, t,BTF_FIELD_TIMER , &info); +if (ret <0 ) +return ret; +return info.off; } static void __btf_struct_show(const struct btf *btf, const struct btf_type *t,
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 475/1095 bpf: Move check_ptr_off_reg before check_map_access
In reply to Greg Kroah-HartmanFrom: Kumar Kartikeya Dwivedi <[email protected]>
[ Upstream commit e9147b4422e1f35b9c229c980c596ccf03d61562 ]
Some functions in next patch want to use this function, and those functions will be called by check_map_access, hence move it before check_map_access.
--- kernel/bpf/verifier.c | 76 +++++++++++++++++++++---------------------- 1 file changed, 38 insertions(+), 38 deletions(-)
kernel/bpf/verifier.c +38 -38
@@ -3468,6 +3468,44 @@ static int check_mem_region_access(struct bpf_verifier_env *env, u32 regno,return 0 ; } +static int __check_ptr_off_reg (struct bpf_verifier_env *env, +const struct bpf_reg_state *reg,int regno, +bool fixed_off_ok) +{ +/* Access to this pointer-typed register or passing it to a helper +* is only allowed in its original, unmodified form. +*/ + +if (reg->off <0 ) { +verbose (env,"negative offset %s ptr R%d off=%d disallowed\n" , +reg_type_str (env, reg->type), regno, reg->off); +return -EACCES ; + } + +if (!fixed_off_ok && reg->off) { +verbose (env,"dereference of modified %s ptr R%d off=%d disallowed\n" , +reg_type_str (env, reg->type), regno, reg->off); +return -EACCES ; + } + +if (!tnum_is_const (reg->var_off) || reg->var_off.value) { +char tn_buf[48 ]; + +tnum_strn (tn_buf,sizeof (tn_buf), reg->var_off); +verbose (env,"variable %s access var_off=%s disallowed\n" , +reg_type_str (env, reg->type), tn_buf); +return -EACCES ; + } + +return 0 ; +} + +int check_ptr_off_reg (struct bpf_verifier_env *env, +const struct bpf_reg_state *reg,int regno) +{ +return __check_ptr_off_reg (env, reg, regno, false); +} +/* check read/write into a map element with possible variable offset */ static int check_map_access (struct bpf_verifier_env *env,u32 regno,int off,int size,bool zero_size_allowed)
@@ -3979,44 +4017,6 @@ static int get_callee_stack_depth(struct bpf_verifier_env *env, }#endif -static int __check_ptr_off_reg (struct bpf_verifier_env *env, -const struct bpf_reg_state *reg,int regno, -bool fixed_off_ok) -{ -/* Access to this pointer-typed register or passing it to a helper -* is only allowed in its original, unmodified form. -*/ - -if (reg->off <0 ) { -verbose (env,"negative offset %s ptr R%d off=%d disallowed\n" , -reg_type_str (env, reg->type), regno, reg->off); -return -EACCES ; - } - -if (!fixed_off_ok && reg->off) { -verbose (env,"dereference of modified %s ptr R%d off=%d disallowed\n" , -reg_type_str (env, reg->type), regno, reg->off); -return -EACCES ; - } - -if (!tnum_is_const (reg->var_off) || reg->var_off.value) { -char tn_buf[48 ]; - -tnum_strn (tn_buf,sizeof (tn_buf), reg->var_off); -verbose (env,"variable %s access var_off=%s disallowed\n" , -reg_type_str (env, reg->type), tn_buf); -return -EACCES ; - } - -return 0 ; -} - -int check_ptr_off_reg (struct bpf_verifier_env *env, -const struct bpf_reg_state *reg,int regno) -{ -return __check_ptr_off_reg (env, reg, regno, false); -} - static int __check_buffer_access(struct bpf_verifier_env *env, const char *buf_info, const struct bpf_reg_state *reg,
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 476/1095 bpf: Allow storing unreferenced kptr in map
In reply to Greg Kroah-HartmanFrom: Kumar Kartikeya Dwivedi <[email protected]>
[ Upstream commit 61df10c7799e27807ad5e459eec9d77cddf8bf45 ]
This commit introduces a new pointer type 'kptr' which can be embedded in a map value to hold a PTR_TO_BTF_ID stored by a BPF program during its invocation. When storing such a kptr, BPF program's PTR_TO_BTF_ID register must have the same type as in the map value's BTF, and loading a kptr marks the destination register as PTR_TO_BTF_ID with the correct kernel BTF and BTF ID.
Such kptr are unreferenced, i.e. by the time another invocation of the BPF program loads this pointer, the object which the pointer points to may not longer exist. Since PTR_TO_BTF_ID loads (using BPF_LDX) are patched to PROBE_MEM loads by the verifier, it would safe to allow user to still access such invalid pointer, but passing such pointers into BPF helpers and kfuncs should not be permitted. A future patch in this series will close this gap.
The flexibility offered by allowing programs to dereference such invalid pointers while being safe at runtime frees the verifier from doing complex lifetime tracking. As long as the user may ensure that the object remains valid, it can ensure data read by it from the kernel object is valid.
The user indicates that a certain pointer must be treated as kptr capable of accepting stores of PTR_TO_BTF_ID of a certain type, by using a BTF type tag 'kptr' on the pointed to type of the pointer. Then, this information is recorded in the object BTF which will be passed into the kernel by way of map's BTF information. The name and kind from the map value BTF is used to look up the in-kernel type, and the actual BTF and BTF ID is recorded in the map struct in a new kptr_off_tab member. For now, only storing pointers to structs is permitted.
An example of this specification is shown below:
#define __kptr __attribute__((btf_type_tag("kptr")))
struct map_value {
...
struct task_struct __kptr *task;
...
};Then, in a BPF program, user may store PTR_TO_BTF_ID with the type task_struct into the map, and then load it later.
Note that the destination register is marked PTR_TO_BTF_ID_OR_NULL, as the verifier cannot know whether the value is NULL or not statically, it must treat all potential loads at that map value offset as loading a possibly NULL pointer.
Only BPF_LDX, BPF_STX, and BPF_ST (with insn->imm = 0 to denote NULL) are allowed instructions that can access such a pointer. On BPF_LDX, the destination register is updated to be a PTR_TO_BTF_ID, and on BPF_STX, it is checked whether the source register type is a PTR_TO_BTF_ID with same BTF type as specified in the map BTF. The access size must always be BPF_DW.
For the map in map support, the kptr_off_tab for outer map is copied from the inner map's kptr_off_tab. It was chosen to do a deep copy instead of introducing a refcount to kptr_off_tab, because the copy only needs to be done when paramterizing using inner_map_fd in the map in map case, hence would be unnecessary for all other users.
It is not permitted to use MAP_FREEZE command and mmap for BPF map having kptrs, similar to the bpf_timer case. A kptr also requires that BPF program has both read and write access to the map (hence both BPF_F_RDONLY_PROG and BPF_F_WRONLY_PROG are disallowed).
Note that check_map_access must be called from both check_helper_mem_access and for the BPF instructions, hence the kptr check must distinguish between ACCESS_DIRECT and ACCESS_HELPER, and reject ACCESS_HELPER cases. We rename stack_access_src to bpf_access_src and reuse it for this purpose.
--- include/linux/bpf.h | 31 +++++++- include/linux/btf.h | 2 + kernel/bpf/btf.c | 167 +++++++++++++++++++++++++++++++++++----- kernel/bpf/map_in_map.c | 5 +- kernel/bpf/syscall.c | 103 ++++++++++++++++++++++++- kernel/bpf/verifier.c | 161 +++++++++++++++++++++++++++++++++++--- 6 files changed, 433 insertions(+), 36 deletions(-)
include/linux/bpf.h +30 -1
@@ -155,6 +155,24 @@ struct bpf_map_ops {const struct bpf_iter_seq_info *iter_seq_info; }; +enum { +/* Support at most 8 pointers in a BPF map value */ +BPF_MAP_VALUE_OFF_MAX =8 , +}; + +struct bpf_map_value_off_desc { +u32 offset; +struct { +struct btf *btf; +u32 btf_id; + } kptr; +}; + +struct bpf_map_value_off { +u32 nr_off; +struct bpf_map_value_off_desc off[]; +}; +struct bpf_map {/* The first two cachelines with read-mostly members of which some * are also accessed in fast-path (e.g. ops, max_entries).
@@ -171,6 +189,7 @@ struct bpf_map {u64 map_extra;/* any per-map-type extra fields */ u32 map_flags;int spin_lock_off;/* >=0 valid offset, <0 error */ +struct bpf_map_value_off *kptr_off_tab;int timer_off;/* >=0 valid offset, <0 error */ u32 id;int numa_node;
@@ -184,7 +203,7 @@ struct bpf_map {char name[BPF_OBJ_NAME_LEN ];bool bypass_spec_v1;bool frozen;/* write-once; write-protected by freeze_mutex */ -/* 14 bytes hole */ +/* 6 bytes hole */ /* The 3rd and 4th cacheline with misc members to avoid false sharing * particularly with refcounting.
@@ -217,6 +236,11 @@ static inline bool map_value_has_timer(const struct bpf_map *map)return map->timer_off >=0 ; } +static inline bool map_value_has_kptrs (const struct bpf_map *map) +{ +return !IS_ERR_OR_NULL (map->kptr_off_tab); +} +static inline void check_and_init_map_value (struct bpf_map *map,void *dst) {if (unlikely (map_value_has_spin_lock (map)))
@@ -1407,6 +1431,11 @@ void bpf_prog_put(struct bpf_prog *prog);void bpf_prog_free_id (struct bpf_prog *prog,bool do_idr_lock);void bpf_map_free_id (struct bpf_map *map,bool do_idr_lock); +struct bpf_map_value_off_desc *bpf_map_kptr_off_contains (struct bpf_map *map,u32 offset); +void bpf_map_free_kptr_off_tab (struct bpf_map *map); +struct bpf_map_value_off *bpf_map_copy_kptr_off_tab (const struct bpf_map *map); +bool bpf_map_equal_kptr_off_tab (const struct bpf_map *map_a,const struct bpf_map *map_b); +struct bpf_map *bpf_map_get (u32 ufd);struct bpf_map *bpf_map_get_with_uref (u32 ufd);struct bpf_map *__bpf_map_get (struct fd f);
include/linux/btf.h +2 -0
@@ -123,6 +123,8 @@ bool btf_member_is_reg_int(const struct btf *btf, const struct btf_type *s, u32 expected_offset, u32 expected_size);int btf_find_spin_lock (const struct btf *btf,const struct btf_type *t);int btf_find_timer (const struct btf *btf,const struct btf_type *t); +struct bpf_map_value_off *btf_parse_kptrs (const struct btf *btf, +const struct btf_type *t);bool btf_type_is_void (const struct btf_type *t);s32 btf_find_by_name_kind (const struct btf *btf,const char *name,u8 kind); const struct btf_type *btf_type_skip_modifiers(const struct btf *btf,
kernel/bpf/btf.c +146 -21
268 lines not on this page · raw message
kernel/bpf/map_in_map.c +4 -1
@@ -52,6 +52,7 @@ struct bpf_map *bpf_map_meta_alloc(int inner_map_ufd) inner_map_meta->max_entries = inner_map->max_entries; inner_map_meta->spin_lock_off = inner_map->spin_lock_off; inner_map_meta->timer_off = inner_map->timer_off; + inner_map_meta->kptr_off_tab =bpf_map_copy_kptr_off_tab (inner_map);if (inner_map->btf) {btf_get (inner_map->btf); inner_map_meta->btf = inner_map->btf;
@@ -71,6 +72,7 @@ struct bpf_map *bpf_map_meta_alloc(int inner_map_ufd)void bpf_map_meta_free (struct bpf_map *map_meta) { +bpf_map_free_kptr_off_tab (map_meta);btf_put (map_meta->btf);kfree (map_meta); }
@@ -83,7 +85,8 @@ bool bpf_map_meta_equal(const struct bpf_map *meta0, meta0->key_size == meta1->key_size && meta0->value_size == meta1->value_size && meta0->timer_off == meta1->timer_off && - meta0->map_flags == meta1->map_flags; + meta0->map_flags == meta1->map_flags && +bpf_map_equal_kptr_off_tab (meta0, meta1); } void *bpf_map_fd_get_ptr(struct bpf_map *map,
kernel/bpf/syscall.c +100 -3
141 lines not on this page · raw message
kernel/bpf/verifier.c +151 -10
229 lines not on this page · raw message
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 477/1095 bpf: Tag argument to be released in bpf_func_proto
In reply to Greg Kroah-HartmanFrom: Kumar Kartikeya Dwivedi <[email protected]>
[ Upstream commit 8f14852e89113d738c99c375b4c8b8b7e1073df1 ]
Add a new type flag for bpf_arg_type that when set tells verifier that for a release function, that argument's register will be the one for which meta.ref_obj_id will be set, and which will then be released using release_reference. To capture the regno, introduce a new field release_regno in bpf_call_arg_meta.
This would be required in the next patch, where we may either pass NULL or a refcounted pointer as an argument to the release function bpf_kptr_xchg. Just releasing only when meta.ref_obj_id is set is not enough, as there is a case where the type of argument needed matches, but the ref_obj_id is set to 0. Hence, we must enforce that whenever meta.ref_obj_id is zero, the register that is to be released can only be NULL for a release function.
Since we now indicate whether an argument is to be released in bpf_func_proto itself, is_release_function helper has lost its utitlity, hence refactor code to work without it, and just rely on meta.release_regno to know when to release state for a ref_obj_id. Still, the restriction of one release argument and only one ref_obj_id passed to BPF helper or kfunc remains. This may be lifted in the future.
--- include/linux/bpf.h | 5 +- include/linux/bpf_verifier.h | 3 +- kernel/bpf/btf.c | 11 ++- kernel/bpf/ringbuf.c | 4 +- kernel/bpf/verifier.c | 76 +++++++++++-------- net/core/filter.c | 2 +- .../selftests/bpf/verifier/ref_tracking.c | 2 +- tools/testing/selftests/bpf/verifier/sock.c | 6 +- 8 files changed, 60 insertions(+), 49 deletions(-)
include/linux/bpf.h +4 -1
@@ -366,7 +366,10 @@ enum bpf_type_flag {*/ MEM_PERCPU =BIT (4 +BPF_BASE_TYPE_BITS ), - __BPF_TYPE_LAST_FLAG = MEM_PERCPU, +/* Indicates that the argument will be released. */ +OBJ_RELEASE =BIT (5 +BPF_BASE_TYPE_BITS ), + + __BPF_TYPE_LAST_FLAG = OBJ_RELEASE, };/* Max number of base types. */
include/linux/bpf_verifier.h +1 -2
@@ -523,8 +523,7 @@ int check_ptr_off_reg(struct bpf_verifier_env *env, const struct bpf_reg_state *reg, int regno);int check_func_arg_reg_off (struct bpf_verifier_env *env,const struct bpf_reg_state *reg,int regno, -enum bpf_arg_type arg_type, -bool is_release_func); +enum bpf_arg_type arg_type);int check_kfunc_mem_size_reg (struct bpf_verifier_env *env,struct bpf_reg_state *reg,u32 regno); int check_mem_reg(struct bpf_verifier_env *env, struct bpf_reg_state *reg,
kernel/bpf/btf.c +5 -6
@@ -5994,6 +5994,7 @@ static int btf_check_func_arg_match(struct bpf_verifier_env *env,* verifier sees. */ for (i =0 ; i < nargs; i++) { +enum bpf_arg_type arg_type =ARG_DONTCARE ;u32 regno = i +1 ;struct bpf_reg_state *reg = ®s[regno];
@@ -6014,7 +6015,9 @@ static int btf_check_func_arg_match(struct bpf_verifier_env *env, ref_t =btf_type_skip_modifiers (btf, t->type, &ref_id); ref_tname =btf_name_by_offset (btf, ref_t->name_off); - ret =check_func_arg_reg_off (env, reg, regno,ARG_DONTCARE , rel); +if (rel && reg->ref_obj_id) + arg_type |=OBJ_RELEASE ; + ret =check_func_arg_reg_off (env, reg, regno, arg_type);if (ret <0 )return ret;
@@ -6045,11 +6048,7 @@ static int btf_check_func_arg_match(struct bpf_verifier_env *env,if (reg->type ==PTR_TO_BTF_ID ) { reg_btf = reg->btf; reg_ref_id = reg->btf_id; -/* Ensure only one argument is referenced -* PTR_TO_BTF_ID, check_func_arg_reg_off relies -* on only one referenced register being allowed -* for kfuncs. -*/ +/* Ensure only one argument is referenced PTR_TO_BTF_ID */ if (reg->ref_obj_id) {if (ref_obj_id) { bpf_log(log, "verifier internal error: more than one arg with ref_obj_id R%d %u %u\n",
kernel/bpf/ringbuf.c +2 -2
@@ -404,7 +404,7 @@ BPF_CALL_2(bpf_ringbuf_submit, void *, sample, u64, flags)const struct bpf_func_proto bpf_ringbuf_submit_proto = { .func = bpf_ringbuf_submit, .ret_type =RET_VOID , - .arg1_type =ARG_PTR_TO_ALLOC_MEM , + .arg1_type =ARG_PTR_TO_ALLOC_MEM |OBJ_RELEASE , .arg2_type =ARG_ANYTHING , };
@@ -417,7 +417,7 @@ BPF_CALL_2(bpf_ringbuf_discard, void *, sample, u64, flags)const struct bpf_func_proto bpf_ringbuf_discard_proto = { .func = bpf_ringbuf_discard, .ret_type =RET_VOID , - .arg1_type =ARG_PTR_TO_ALLOC_MEM , + .arg1_type =ARG_PTR_TO_ALLOC_MEM |OBJ_RELEASE , .arg2_type =ARG_ANYTHING , };
kernel/bpf/verifier.c +43 -33
153 lines not on this page · raw message
net/core/filter.c +1 -1
@@ -6642,7 +6642,7 @@ static const struct bpf_func_proto bpf_sk_release_proto = { .func = bpf_sk_release, .gpl_only = false, .ret_type = RET_INTEGER, - .arg1_type = ARG_PTR_TO_BTF_ID_SOCK_COMMON, + .arg1_type = ARG_PTR_TO_BTF_ID_SOCK_COMMON | OBJ_RELEASE, }; BPF_CALL_5(bpf_xdp_sk_lookup_udp, struct xdp_buff *, ctx,
tools/testing/selftests/bpf/verifier/ref_tracking.c +1 -1
@@ -796,7 +796,7 @@ }, .prog_type = BPF_PROG_TYPE_SCHED_CLS, .result = REJECT, - .errstr = "reference has not been acquired before", + .errstr = "R1 must be referenced when passed to release function", }, {/* !bpf_sk_fullsock(sk) is checked but !bpf_tcp_sock(sk) is not checked */
tools/testing/selftests/bpf/verifier/sock.c +3 -3
@@ -417,7 +417,7 @@ }, .prog_type = BPF_PROG_TYPE_SCHED_CLS, .result = REJECT, - .errstr = "reference has not been acquired before", + .errstr = "R1 must be referenced when passed to release function", }, { "bpf_sk_release(bpf_sk_fullsock(skb->sk))",
@@ -436,7 +436,7 @@ }, .prog_type = BPF_PROG_TYPE_SCHED_CLS, .result = REJECT, - .errstr = "reference has not been acquired before", + .errstr = "R1 must be referenced when passed to release function", }, { "bpf_sk_release(bpf_tcp_sock(skb->sk))",
@@ -455,7 +455,7 @@ }, .prog_type = BPF_PROG_TYPE_SCHED_CLS, .result = REJECT, - .errstr = "reference has not been acquired before", + .errstr = "R1 must be referenced when passed to release function", }, { "sk_storage_get(map, skb->sk, NULL, 0): value == NULL",
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 478/1095 bpf: Allow storing referenced kptr in map
In reply to Greg Kroah-HartmanFrom: Kumar Kartikeya Dwivedi <[email protected]>
[ Upstream commit c0a5a21c25f37c9fd7b36072f9968cdff1e4aa13 ]
Extending the code in previous commits, introduce referenced kptr support, which needs to be tagged using 'kptr_ref' tag instead. Unlike unreferenced kptr, referenced kptr have a lot more restrictions. In addition to the type matching, only a newly introduced bpf_kptr_xchg helper is allowed to modify the map value at that offset. This transfers the referenced pointer being stored into the map, releasing the references state for the program, and returning the old value and creating new reference state for the returned pointer.
Similar to unreferenced pointer case, return value for this case will also be PTR_TO_BTF_ID_OR_NULL. The reference for the returned pointer must either be eventually released by calling the corresponding release function, otherwise it must be transferred into another map.
It is also allowed to call bpf_kptr_xchg with a NULL pointer, to clear the value, and obtain the old value if any.
BPF_LDX, BPF_STX, and BPF_ST cannot access referenced kptr. A future commit will permit using BPF_LDX for such pointers, but attempt at making it safe, since the lifetime of object won't be guaranteed.
There are valid reasons to enforce the restriction of permitting only bpf_kptr_xchg to operate on referenced kptr. The pointer value must be consistent in face of concurrent modification, and any prior values contained in the map must also be released before a new one is moved into the map. To ensure proper transfer of this ownership, bpf_kptr_xchg returns the old value, which the verifier would require the user to either free or move into another map, and releases the reference held for the pointer being moved in.
In the future, direct BPF_XCHG instruction may also be permitted to work like bpf_kptr_xchg helper.
Note that process_kptr_func doesn't have to call check_helper_mem_access, since we already disallow rdonly/wronly flags for map, which is what check_map_access_type checks, and we already ensure the PTR_TO_MAP_VALUE refers to kptr by obtaining its off_desc, so check_map_access is also not required.
--- include/linux/bpf.h | 8 +++ include/uapi/linux/bpf.h | 12 +++++ kernel/bpf/btf.c | 10 +++- kernel/bpf/helpers.c | 24 +++++++++ kernel/bpf/verifier.c | 98 +++++++++++++++++++++++++++++----- tools/include/uapi/linux/bpf.h | 12 +++++ 6 files changed, 151 insertions(+), 13 deletions(-)
include/linux/bpf.h +8 -0
@@ -160,8 +160,14 @@ enum { BPF_MAP_VALUE_OFF_MAX = 8, }; +enum bpf_kptr_type { +BPF_KPTR_UNREF , +BPF_KPTR_REF , +}; +struct bpf_map_value_off_desc {u32 offset; +enum bpf_kptr_type type;struct {struct btf *btf;u32 btf_id;
@@ -418,6 +424,7 @@ enum bpf_arg_type {ARG_PTR_TO_STACK ,/* pointer to stack */ ARG_PTR_TO_CONST_STR ,/* pointer to a null terminated read-only string */ ARG_PTR_TO_TIMER ,/* pointer to bpf_timer */ +ARG_PTR_TO_KPTR ,/* pointer to referenced kptr */ __BPF_ARG_TYPE_MAX,/* Extended arg_types. */
@@ -427,6 +434,7 @@ enum bpf_arg_type {ARG_PTR_TO_SOCKET_OR_NULL =PTR_MAYBE_NULL |ARG_PTR_TO_SOCKET ,ARG_PTR_TO_ALLOC_MEM_OR_NULL =PTR_MAYBE_NULL |ARG_PTR_TO_ALLOC_MEM ,ARG_PTR_TO_STACK_OR_NULL =PTR_MAYBE_NULL |ARG_PTR_TO_STACK , +ARG_PTR_TO_BTF_ID_OR_NULL =PTR_MAYBE_NULL |ARG_PTR_TO_BTF_ID ,/* This must be the last entry. Its purpose is to ensure the enum is * wide enough to hold the higher bits reserved for bpf_type_flag.
include/uapi/linux/bpf.h +12 -0
@@ -5144,6 +5144,17 @@ union bpf_attr {* The **hash_algo** is returned on success, * **-EOPNOTSUP** if the hash calculation failed or **-EINVAL** if * invalid arguments are passed. +* +* void *bpf_kptr_xchg(void *map_value, void *ptr) +* Description +* Exchange kptr at pointer *map_value* with *ptr*, and return the +* old value. *ptr* can be NULL, otherwise it must be a referenced +* pointer which will be released when this helper is called. +* Return +* The old value of kptr (which can be NULL). The returned pointer +* if not NULL, is a reference which must be released using its +* corresponding release function, or moved into a BPF map before +* program exit. */ #define __BPF_FUNC_MAPPER (FN ) \ FN(unspec), \
@@ -5340,6 +5351,7 @@ union bpf_attr {FN (copy_from_user_task), \FN (skb_set_tstamp), \FN (ima_file_hash), \ +FN (kptr_xchg), \/* */ /* integer value in 'imm' field of BPF_CALL instruction selects which helper
kernel/bpf/btf.c +9 -1
@@ -3177,6 +3177,7 @@ enum {struct btf_field_info {u32 type_id;u32 off; +enum bpf_kptr_type type; }; static int btf_find_struct(const struct btf *btf, const struct btf_type *t,
@@ -3193,6 +3194,7 @@ static int btf_find_struct(const struct btf *btf, const struct btf_type *t,static int btf_find_kptr (const struct btf *btf,const struct btf_type *t,u32 off,int sz,struct btf_field_info *info) { +enum bpf_kptr_type type;u32 res_id;/* For PTR, sz is always == 8 */
@@ -3205,7 +3207,11 @@ static int btf_find_kptr(const struct btf *btf, const struct btf_type *t,/* Reject extra tags */ if (btf_type_is_type_tag (btf_type_by_id (btf, t->type)))return -EINVAL ; -if (strcmp ("kptr" ,__btf_name_by_offset (btf, t->name_off))) +if (!strcmp ("kptr" ,__btf_name_by_offset (btf, t->name_off))) + type =BPF_KPTR_UNREF ; +else if (!strcmp ("kptr_ref" ,__btf_name_by_offset (btf, t->name_off))) + type =BPF_KPTR_REF ; +else return -EINVAL ;/* Get the base type */
@@ -3216,6 +3222,7 @@ static int btf_find_kptr(const struct btf *btf, const struct btf_type *t, info->type_id = res_id; info->off = off; + info->type = type;return BTF_FIELD_FOUND ; }
@@ -3420,6 +3427,7 @@ struct bpf_map_value_off *btf_parse_kptrs(const struct btf *btf, } tab->off[i].offset = info_arr[i].off; + tab->off[i].type = info_arr[i].type; tab->off[i].kptr.btf_id = id; tab->off[i].kptr.btf = kernel_btf; }
kernel/bpf/helpers.c +24 -0
@@ -1374,6 +1374,28 @@ void bpf_timer_cancel_and_free(void *val)kfree (t); } +BPF_CALL_2(bpf_kptr_xchg, void *, map_value, void *, ptr) +{ +unsigned long *kptr = map_value; + +return xchg (kptr, (unsigned long )ptr); +} + +/* Unlike other PTR_TO_BTF_ID helpers the btf_id in bpf_kptr_xchg() +* helper is determined dynamically by the verifier. +*/ +#define BPF_PTR_POISON ((void *)((0xeB9FUL << 2) + POISON_POINTER_DELTA)) + +const struct bpf_func_proto bpf_kptr_xchg_proto = { + .func = bpf_kptr_xchg, + .gpl_only = false, + .ret_type =RET_PTR_TO_BTF_ID_OR_NULL , + .ret_btf_id =BPF_PTR_POISON , + .arg1_type =ARG_PTR_TO_KPTR , + .arg2_type =ARG_PTR_TO_BTF_ID_OR_NULL |OBJ_RELEASE , + .arg2_btf_id =BPF_PTR_POISON , +}; +const struct bpf_func_proto bpf_get_current_task_proto__weak ;const struct bpf_func_proto bpf_get_current_task_btf_proto__weak ;const struct bpf_func_proto bpf_probe_read_user_proto__weak ;
@@ -1452,6 +1474,8 @@ bpf_base_func_proto(enum bpf_func_id func_id)return &bpf_timer_start_proto;case BPF_FUNC_timer_cancel:return &bpf_timer_cancel_proto; +case BPF_FUNC_kptr_xchg: +return &bpf_kptr_xchg_proto;default :break ; }
kernel/bpf/verifier.c +86 -12
186 lines not on this page · raw message
tools/include/uapi/linux/bpf.h +12 -0
@@ -5144,6 +5144,17 @@ union bpf_attr {* The **hash_algo** is returned on success, * **-EOPNOTSUP** if the hash calculation failed or **-EINVAL** if * invalid arguments are passed. +* +* void *bpf_kptr_xchg(void *map_value, void *ptr) +* Description +* Exchange kptr at pointer *map_value* with *ptr*, and return the +* old value. *ptr* can be NULL, otherwise it must be a referenced +* pointer which will be released when this helper is called. +* Return +* The old value of kptr (which can be NULL). The returned pointer +* if not NULL, is a reference which must be released using its +* corresponding release function, or moved into a BPF map before +* program exit. */ #define __BPF_FUNC_MAPPER (FN ) \ FN(unspec), \
@@ -5340,6 +5351,7 @@ union bpf_attr {FN (copy_from_user_task), \FN (skb_set_tstamp), \FN (ima_file_hash), \ +FN (kptr_xchg), \/* */ /* integer value in 'imm' field of BPF_CALL instruction selects which helper
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 479/1095 bpf: Adapt copy_map_value for multiple offset case
In reply to Greg Kroah-HartmanFrom: Kumar Kartikeya Dwivedi <[email protected]>
[ Upstream commit 4d7d7f69f4b104b2ddeec6a1e7fcfd2d044ed8c4 ]
Since now there might be at most 10 offsets that need handling in copy_map_value, the manual shuffling and special case is no longer going to work. Hence, let's generalise the copy_map_value function by using a sorted array of offsets to skip regions that must be avoided while copying into and out of a map value.
When the map is created, we populate the offset array in struct map, Then, copy_map_value uses this sorted offset array is used to memcpy while skipping timer, spin lock, and kptr. The array is allocated as in most cases none of these special fields would be present in map value, hence we can save on space for the common case by not embedding the entire object inside bpf_map struct.
--- include/linux/bpf.h | 56 +++++++++++++++------------- kernel/bpf/syscall.c | 88 +++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 117 insertions(+), 27 deletions(-)
include/linux/bpf.h +30 -26
@@ -158,6 +158,9 @@ struct bpf_map_ops {enum {/* Support at most 8 pointers in a BPF map value */ BPF_MAP_VALUE_OFF_MAX =8 , +BPF_MAP_OFF_ARR_MAX =BPF_MAP_VALUE_OFF_MAX + +1 +/* for bpf_spin_lock */ +1 ,/* for bpf_timer */ };enum bpf_kptr_type {
@@ -179,6 +182,12 @@ struct bpf_map_value_off {struct bpf_map_value_off_desc off[]; }; +struct bpf_map_off_arr { +u32 cnt; +u32 field_off[BPF_MAP_OFF_ARR_MAX ]; +u8 field_sz[BPF_MAP_OFF_ARR_MAX ]; +}; +struct bpf_map {/* The first two cachelines with read-mostly members of which some * are also accessed in fast-path (e.g. ops, max_entries).
@@ -207,10 +216,7 @@ struct bpf_map {struct mem_cgroup *memcg;#endif char name[BPF_OBJ_NAME_LEN ]; -bool bypass_spec_v1; -bool frozen;/* write-once; write-protected by freeze_mutex */ -/* 6 bytes hole */ - +struct bpf_map_off_arr *off_arr;/* The 3rd and 4th cacheline with misc members to avoid false sharing * particularly with refcounting. */
@@ -230,6 +236,8 @@ struct bpf_map {bool jited;bool xdp_has_frags; } owner; +bool bypass_spec_v1; +bool frozen;/* write-once; write-protected by freeze_mutex */ };static inline bool map_value_has_spin_lock (const struct bpf_map *map)
@@ -253,37 +261,33 @@ static inline void check_and_init_map_value(struct bpf_map *map, void *dst)memset (dst + map->spin_lock_off,0 ,sizeof (struct bpf_spin_lock ));if (unlikely (map_value_has_timer (map)))memset (dst + map->timer_off,0 ,sizeof (struct bpf_timer )); +if (unlikely (map_value_has_kptrs (map))) { +struct bpf_map_value_off *tab = map->kptr_off_tab; +int i; + +for (i =0 ; i < tab->nr_off; i++) + *(u64 *)(dst + tab->off[i].offset) =0 ; + } }/* copy everything but bpf_spin_lock and bpf_timer. There could be one of each. */ static inline void copy_map_value (struct bpf_map *map,void *dst,void *src) { -u32 s_off =0 , s_sz =0 , t_off =0 , t_sz =0 ; +u32 curr_off =0 ; +int i; -if (unlikely (map_value_has_spin_lock (map))) { - s_off = map->spin_lock_off; - s_sz =sizeof (struct bpf_spin_lock ); - } -if (unlikely (map_value_has_timer (map))) { - t_off = map->timer_off; - t_sz =sizeof (struct bpf_timer ); +if (likely (!map->off_arr)) { +memcpy (dst, src, map->value_size); +return ; } -if (unlikely (s_sz || t_sz)) { -if (s_off < t_off || !s_sz) { -swap (s_off, t_off); -swap (s_sz, t_sz); - } -memcpy (dst, src, t_off); -memcpy (dst + t_off + t_sz, - src + t_off + t_sz, - s_off - t_off - t_sz); -memcpy (dst + s_off + s_sz, - src + s_off + s_sz, - map->value_size - s_off - s_sz); - }else { -memcpy (dst, src, map->value_size); +for (i =0 ; i < map->off_arr->cnt; i++) { +u32 next_off = map->off_arr->field_off[i]; + +memcpy (dst + curr_off, src + curr_off, next_off - curr_off); + curr_off += map->off_arr->field_sz[i]; } +memcpy (dst + curr_off, src + curr_off, map->value_size - curr_off); }void copy_map_value_locked (struct bpf_map *map,void *dst,void *src,bool lock_src);
kernel/bpf/syscall.c +87 -1
121 lines not on this page · raw message
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 480/1095 bpf: Populate pairs of btf_id and destructor kfunc in btf
In reply to Greg Kroah-HartmanFrom: Kumar Kartikeya Dwivedi <[email protected]>
[ Upstream commit 5ce937d613a423ca3102f53d9f3daf4210c1b6e2 ]
To support storing referenced PTR_TO_BTF_ID in maps, we require associating a specific BTF ID with a 'destructor' kfunc. This is because we need to release a live referenced pointer at a certain offset in map value from the map destruction path, otherwise we end up leaking resources.
Hence, introduce support for passing an array of btf_id, kfunc_btf_id pairs that denote a BTF ID and its associated release function. Then, add an accessor 'btf_find_dtor_kfunc' which can be used to look up the destructor kfunc of a certain BTF ID. If found, we can use it to free the object from the map free path.
The registration of these pairs also serve as a whitelist of structures which are allowed as referenced PTR_TO_BTF_ID in a BPF map, because without finding the destructor kfunc, we will bail and return an error.
--- include/linux/btf.h | 17 +++++++ kernel/bpf/btf.c | 108 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 125 insertions(+)
include/linux/btf.h +17 -0
@@ -40,6 +40,11 @@ struct btf_kfunc_id_set { }; }; +struct btf_id_dtor_kfunc { +u32 btf_id; +u32 kfunc_btf_id; +}; +extern const struct file_operations btf_fops;void btf_get (struct btf *btf);
@@ -346,6 +351,9 @@ bool btf_kfunc_id_set_contains(const struct btf *btf, enum btf_kfunc_type type, u32 kfunc_btf_id);int register_btf_kfunc_id_set (enum bpf_prog_type prog_type,const struct btf_kfunc_id_set *s); +s32 btf_find_dtor_kfunc (struct btf *btf,u32 btf_id); +int register_btf_id_dtor_kfuncs (const struct btf_id_dtor_kfunc *dtors,u32 add_cnt, +struct module *owner);#else static inline const struct btf_type *btf_type_by_id (const struct btf *btf,u32 type_id)
@@ -369,6 +377,15 @@ static inline int register_btf_kfunc_id_set(enum bpf_prog_type prog_type, {return 0 ; } +static inline s32 btf_find_dtor_kfunc (struct btf *btf,u32 btf_id) +{ +return -ENOENT ; +} +static inline int register_btf_id_dtor_kfuncs (const struct btf_id_dtor_kfunc *dtors, +u32 add_cnt,struct module *owner) +{ +return 0 ; +}#endif #endif
kernel/bpf/btf.c +108 -0
140 lines not on this page · raw message
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 481/1095 bpf: Wire up freeing of referenced kptr
In reply to Greg Kroah-HartmanFrom: Kumar Kartikeya Dwivedi <[email protected]>
[ Upstream commit 14a324f6a67ef6a53e04362a70160a47eb8afffa ]
A destructor kfunc can be defined as void func(type *), where type may be void or any other pointer type as per convenience.
In this patch, we ensure that the type is sane and capture the function pointer into off_desc of ptr_off_tab for the specific pointer offset, with the invariant that the dtor pointer is always set when 'kptr_ref' tag is applied to the pointer's pointee type, which is indicated by the flag BPF_MAP_VALUE_OFF_F_REF.
Note that only BTF IDs whose destructor kfunc is registered, thus become the allowed BTF IDs for embedding as referenced kptr. Hence it serves the purpose of finding dtor kfunc BTF ID, as well acting as a check against the whitelist of allowed BTF IDs for this purpose.
Finally, wire up the actual freeing of the referenced pointer if any at all available offsets, so that no references are leaked after the BPF map goes away and the BPF program previously moved the ownership a referenced pointer into it.
The behavior is similar to BPF timers, where bpf_map_{update,delete}_elem will free any existing referenced kptr. The same case is with LRU map's bpf_lru_push_free/htab_lru_push_free functions, which are extended to reset unreferenced and free referenced kptr.
Note that unlike BPF timers, kptr is not reset or freed when map uref drops to zero.
--- include/linux/bpf.h | 4 ++ include/linux/btf.h | 2 + kernel/bpf/arraymap.c | 18 ++++++-- kernel/bpf/btf.c | 98 ++++++++++++++++++++++++++++++++++++++++++- kernel/bpf/hashtab.c | 64 +++++++++++++++++++++------- kernel/bpf/syscall.c | 49 ++++++++++++++++++++-- 6 files changed, 210 insertions(+), 25 deletions(-)
include/linux/bpf.h +4 -0
@@ -23,6 +23,7 @@#include <linux/slab.h> #include <linux/percpu-refcount.h> #include <linux/bpfptr.h> +#include <linux/btf.h> struct bpf_verifier_env ;struct bpf_verifier_log ;
@@ -173,6 +174,8 @@ struct bpf_map_value_off_desc {enum bpf_kptr_type type;struct {struct btf *btf; +struct module *module; +btf_dtor_kfunc_t dtor;u32 btf_id; } kptr; };
@@ -1450,6 +1453,7 @@ struct bpf_map_value_off_desc *bpf_map_kptr_off_contains(struct bpf_map *map, u3void bpf_map_free_kptr_off_tab (struct bpf_map *map);struct bpf_map_value_off *bpf_map_copy_kptr_off_tab (const struct bpf_map *map);bool bpf_map_equal_kptr_off_tab (const struct bpf_map *map_a,const struct bpf_map *map_b); +void bpf_map_free_kptrs (struct bpf_map *map,void *map_value);struct bpf_map *bpf_map_get (u32 ufd);struct bpf_map *bpf_map_get_with_uref (u32 ufd);
include/linux/btf.h +2 -0
@@ -45,6 +45,8 @@ struct btf_id_dtor_kfunc {u32 kfunc_btf_id; }; +typedef void (*btf_dtor_kfunc_t )(void *); +extern const struct file_operations btf_fops;void btf_get (struct btf *btf);
kernel/bpf/arraymap.c +14 -4
@@ -287,10 +287,12 @@ static int array_map_get_next_key(struct bpf_map *map, void *key, void *next_keyreturn 0 ; } -static void check_and_free_timer_in_array (struct bpf_array *arr,void *val) +static void check_and_free_fields (struct bpf_array *arr,void *val) { -if (unlikely (map_value_has_timer (&arr->map))) +if (map_value_has_timer (&arr->map))bpf_timer_cancel_and_free (val + arr->map.timer_off); +if (map_value_has_kptrs (&arr->map)) +bpf_map_free_kptrs (&arr->map, val); }/* Called from syscall or from eBPF program */
@@ -327,7 +329,7 @@ static int array_map_update_elem(struct bpf_map *map, void *key, void *value,copy_map_value_locked (map, val, value, false); elsecopy_map_value (map ,val ,value ); -check_and_free_timer_in_array (array, val); +check_and_free_fields (array, val); }return 0 ; }
@@ -386,7 +388,8 @@ static void array_map_free_timers(struct bpf_map *map) struct bpf_array *array = container_of(map, struct bpf_array, map);int i; -if (likely (!map_value_has_timer (map))) +/* We don't reset or free kptr on uref dropping to zero. */ +if (!map_value_has_timer (map))return ;for (i =0 ; i < array->map.max_entries; i++)
@@ -398,6 +401,13 @@ static void array_map_free_timers(struct bpf_map *map)static void array_map_free (struct bpf_map *map) { struct bpf_array *array = container_of(map, struct bpf_array, map); +int i; + +if (map_value_has_kptrs (map)) { +for (i =0 ; i < array->map.max_entries; i++) +bpf_map_free_kptrs (map, array->value + array->elem_size * i); +bpf_map_free_kptr_off_tab (map); + }if (array->map.map_type ==BPF_MAP_TYPE_PERCPU_ARRAY )bpf_array_free_percpu (array);
kernel/bpf/btf.c +97 -1
131 lines not on this page · raw message
kernel/bpf/hashtab.c +48 -16
134 lines not on this page · raw message
kernel/bpf/syscall.c +45 -4
76 lines not on this page · raw message
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 482/1095 bpf: fix potential 32-bit overflow when accessing ARRAY map element
In reply to Greg Kroah-HartmanFrom: Andrii Nakryiko <[email protected]>
[ Upstream commit 87ac0d600943994444e24382a87aa19acc4cd3d4 ]
If BPF array map is bigger than 4GB, element pointer calculation can overflow because both index and elem_size are u32. Fix this everywhere by forcing 64-bit multiplication. Extract this formula into separate small helper and use it consistently in various places.
Speculative-preventing formula utilizing index_mask trick is left as is, but explicit u64 casts are added in both places.
--- kernel/bpf/arraymap.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)
kernel/bpf/arraymap.c +12 -8
@@ -155,6 +155,11 @@ static struct bpf_map *array_map_alloc(union bpf_attr *attr)return &array->map; } +static void *array_map_elem_ptr (struct bpf_array * array,u32 index) +{ +return array->value + (u64 )array->elem_size * index; +} +/* Called from syscall or from eBPF program */ static void *array_map_lookup_elem (struct bpf_map *map,void *key) {
@@ -164,7 +169,7 @@ static void *array_map_lookup_elem(struct bpf_map *map, void *key)if (unlikely (index >= array->map.max_entries))return NULL ; -return array->value + array->elem_size * (index & array->index_mask); +return array->value + (u64 )array->elem_size * (index & array->index_mask); } static int array_map_direct_value_addr(const struct bpf_map *map, u64 *imm,
@@ -324,7 +329,7 @@ static int array_map_update_elem(struct bpf_map *map, void *key, void *value, value, map->value_size); }else { val = array->value + - array->elem_size * (index & array->index_mask); + (u64 )array->elem_size * (index & array->index_mask);if (map_flags &BPF_F_LOCK )copy_map_value_locked (map, val, value, false);else
@@ -393,8 +398,7 @@ static void array_map_free_timers(struct bpf_map *map)return ;for (i =0 ; i < array->map.max_entries; i++) -bpf_timer_cancel_and_free (array->value + array->elem_size * i + - map->timer_off); +bpf_timer_cancel_and_free (array_map_elem_ptr (array, i) + map->timer_off); }/* Called when map->refcnt goes to zero, either from workqueue or from syscall */
@@ -405,7 +409,7 @@ static void array_map_free(struct bpf_map *map)if (map_value_has_kptrs (map)) {for (i =0 ; i < array->map.max_entries; i++) -bpf_map_free_kptrs (map, array->value + array->elem_size * i); +bpf_map_free_kptrs (map,array_map_elem_ptr (array, i));bpf_map_free_kptr_off_tab (map); }
@@ -541,7 +545,7 @@ static void *bpf_array_map_seq_start(struct seq_file *seq, loff_t *pos) index = info->index & array->index_mask;if (info->percpu_value_buf)return array->pptrs[index]; -return array->value + array->elem_size * index; +return array_map_elem_ptr (array, index); }static void *bpf_array_map_seq_next (struct seq_file *seq,void *v,loff_t *pos)
@@ -560,7 +564,7 @@ static void *bpf_array_map_seq_next(struct seq_file *seq, void *v, loff_t *pos) index = info->index & array->index_mask;if (info->percpu_value_buf)return array->pptrs[index]; -return array->value + array->elem_size * index; +return array_map_elem_ptr (array, index); }static int __bpf_array_map_seq_show (struct seq_file *seq,void *v)
@@ -675,7 +679,7 @@ static int bpf_for_each_array_elem(struct bpf_map *map, bpf_callback_t callback_if (is_percpu) val =this_cpu_ptr (array->pptrs[i]);else - val = array->value + array->elem_size * i; + val =array_map_elem_ptr (array, i); num_elems++; key = i; ret = callback_fn((u64)(long)map, (u64)(long)&key,
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 483/1095 selftests/bpf: fix a test for snprintf() overflow
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit c5d22f4cfe8dfb93f1db0a1e7e2e7ebc41395d98 ]
The snprintf() function returns the number of bytes which *would* have been copied if there were space. In other words, it can be
Quoted 1 line
sizeof(pin_path).
--- tools/testing/selftests/bpf/prog_tests/btf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/btf.c +1 -1
@@ -5226,7 +5226,7 @@ static void do_test_pprint(int test_num) ret =snprintf (pin_path,sizeof (pin_path),"%s/%s" ,"/sys/fs/bpf" , test->map_name); -if (CHECK (ret ==sizeof (pin_path),"pin_path %s/%s is too long" , +if (CHECK (ret >=sizeof (pin_path),"pin_path %s/%s is too long" ,"/sys/fs/bpf" , test->map_name)) { err =-1 ; goto done;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 484/1095 libbpf: fix an snprintf() overflow check
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit b77ffb30cfc5f58e957571d8541c6a7e3da19221 ]
The snprintf() function returns the number of bytes it *would* have copied if there were enough space. So it can return > the sizeof(gen->attach_target).
--- tools/lib/bpf/gen_loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/bpf/gen_loader.c +1 -1
@@ -533,7 +533,7 @@ void bpf_gen__record_attach_target(struct bpf_gen *gen, const char *attach_name, gen->attach_kind = kind; ret =snprintf (gen->attach_target,sizeof (gen->attach_target),"%s%s" , prefix, attach_name); -if (ret ==sizeof (gen->attach_target)) +if (ret >=sizeof (gen->attach_target)) gen->error = -ENOSPC ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 485/1095 can: pch_can: do not report txerr and rxerr during bus-off
In reply to Greg Kroah-HartmanFrom: Vincent Mailhol <[email protected]>
[ Upstream commit 3a5c7e4611ddcf0ef37a3a17296b964d986161a6 ]
During bus off, the error count is greater than 255 and can not fit in a u8.
--- drivers/net/can/pch_can.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/can/pch_can.c +3 -3
@@ -496,6 +496,9 @@ static void pch_can_error(struct net_device *ndev, u32 status) cf->can_id |=CAN_ERR_BUSOFF ; priv->can.can_stats.bus_off++;can_bus_off (ndev); + }else { + cf->data[6 ] = errc &PCH_TEC ; + cf->data[7 ] = (errc &PCH_REC ) >>8 ; } errc =ioread32 (&priv->regs->errc);
@@ -556,9 +559,6 @@ static void pch_can_error(struct net_device *ndev, u32 status)break ; } - cf->data[6 ] = errc &PCH_TEC ; - cf->data[7 ] = (errc &PCH_REC ) >>8 ; - priv->can.state = state;netif_receive_skb (skb); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 486/1095 can: rcar_can: do not report txerr and rxerr during bus-off
In reply to Greg Kroah-HartmanFrom: Vincent Mailhol <[email protected]>
[ Upstream commit a37b7245e831a641df360ca41db6a71c023d3746 ]
During bus off, the error count is greater than 255 and can not fit in a u8.
--- drivers/net/can/rcar/rcar_can.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/net/can/rcar/rcar_can.c +4 -4
@@ -233,11 +233,8 @@ static void rcar_can_error(struct net_device *ndev)if (eifr & (RCAR_CAN_EIFR_EWIF |RCAR_CAN_EIFR_EPIF )) { txerr =readb (&priv->regs->tecr); rxerr =readb (&priv->regs->recr); -if (skb) { +if (skb) cf->can_id |=CAN_ERR_CRTL ; - cf->data[6 ] = txerr; - cf->data[7 ] = rxerr; - } }if (eifr &RCAR_CAN_EIFR_BEIF ) {int rx_errors =0 , tx_errors =0 ;
@@ -337,6 +334,9 @@ static void rcar_can_error(struct net_device *ndev)can_bus_off (ndev);if (skb) cf->can_id |=CAN_ERR_BUSOFF ; + }else if (skb) { + cf->data[6 ] = txerr; + cf->data[7 ] = rxerr; }if (eifr &RCAR_CAN_EIFR_ORIF ) {netdev_dbg (priv->ndev,"Receive overrun error interrupt\n" );
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 487/1095 can: sja1000: do not report txerr and rxerr during bus-off
In reply to Greg Kroah-HartmanFrom: Vincent Mailhol <[email protected]>
[ Upstream commit 164d7cb2d5a30f1b3a5ab4fab1a27731fb1494a8 ]
During bus off, the error count is greater than 255 and can not fit in a u8.
--- drivers/net/can/sja1000/sja1000.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/can/sja1000/sja1000.c +4 -3
@@ -405,9 +405,6 @@ static int sja1000_err(struct net_device *dev, uint8_t isrc, uint8_t status) txerr = priv->read_reg (priv,SJA1000_TXERR ); rxerr = priv->read_reg (priv,SJA1000_RXERR ); - cf->data[6 ] = txerr; - cf->data[7 ] = rxerr; -if (isrc &IRQ_DOI ) {/* data overrun interrupt */ netdev_dbg (dev,"data overrun interrupt\n" );
@@ -429,6 +426,10 @@ static int sja1000_err(struct net_device *dev, uint8_t isrc, uint8_t status)else state =CAN_STATE_ERROR_ACTIVE ; } +if (state !=CAN_STATE_BUS_OFF ) { + cf->data[6 ] = txerr; + cf->data[7 ] = rxerr; + }if (isrc &IRQ_BEI ) {/* bus error interrupt */ priv->can.can_stats.bus_error++;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 488/1095 can: hi311x: do not report txerr and rxerr during bus-off
In reply to Greg Kroah-HartmanFrom: Vincent Mailhol <[email protected]>
[ Upstream commit a22bd630cfff496b270211745536e50e98eb3a45 ]
During bus off, the error count is greater than 255 and can not fit in a u8.
--- drivers/net/can/spi/hi311x.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/can/spi/hi311x.c +3 -2
@@ -672,8 +672,6 @@ static irqreturn_t hi3110_can_ist(int irq, void *dev_id) txerr =hi3110_read (spi,HI3110_READ_TEC ); rxerr =hi3110_read (spi,HI3110_READ_REC ); - cf->data[6 ] = txerr; - cf->data[7 ] = rxerr; tx_state = txerr >= rxerr ? new_state :0 ; rx_state = txerr <= rxerr ? new_state :0 ;can_change_state (net, cf, tx_state, rx_state);
@@ -686,6 +684,9 @@ static irqreturn_t hi3110_can_ist(int irq, void *dev_id)hi3110_hw_sleep (spi);break ; } + }else { + cf->data[6 ] = txerr; + cf->data[7 ] = rxerr; } }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 489/1095 can: sun4i_can: do not report txerr and rxerr during bus-off
In reply to Greg Kroah-HartmanFrom: Vincent Mailhol <[email protected]>
[ Upstream commit 0ac15a8f661b941519379831d09bfb12271b23ee ]
During bus off, the error count is greater than 255 and can not fit in a u8.
--- drivers/net/can/sun4i_can.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/net/can/sun4i_can.c +4 -5
@@ -538,11 +538,6 @@ static int sun4i_can_err(struct net_device *dev, u8 isrc, u8 status) rxerr = (errc >>16 ) &0xFF ; txerr = errc &0xFF ; -if (skb) { - cf->data[6 ] = txerr; - cf->data[7 ] = rxerr; - } -if (isrc &SUN4I_INT_DATA_OR ) {/* data overrun interrupt */ netdev_dbg (dev,"data overrun interrupt\n" );
@@ -573,6 +568,10 @@ static int sun4i_can_err(struct net_device *dev, u8 isrc, u8 status)else state =CAN_STATE_ERROR_ACTIVE ; } +if (skb && state !=CAN_STATE_BUS_OFF ) { + cf->data[6 ] = txerr; + cf->data[7 ] = rxerr; + }if (isrc &SUN4I_INT_BUS_ERR ) {/* bus error interrupt */ netdev_dbg (dev,"bus error interrupt\n" );
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 490/1095 can: kvaser_usb_hydra: do not report txerr and rxerr during bus-off
In reply to Greg Kroah-HartmanFrom: Vincent Mailhol <[email protected]>
[ Upstream commit 936e90595376e64b6247c72d3ea8b8b164b7ac96 ]
During bus off, the error count is greater than 255 and can not fit in a u8.
--- drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c +8 -4
@@ -917,8 +917,10 @@ static void kvaser_usb_hydra_update_state(struct kvaser_usb_net_priv *priv, new_state < CAN_STATE_BUS_OFF) priv->can.can_stats.restarts++; - cf->data[6 ] = bec->txerr; - cf->data[7 ] = bec->rxerr; +if (new_state !=CAN_STATE_BUS_OFF ) { + cf->data[6 ] = bec->txerr; + cf->data[7 ] = bec->rxerr; + }netif_rx (skb); }
@@ -1069,8 +1071,10 @@ kvaser_usb_hydra_error_frame(struct kvaser_usb_net_priv *priv, shhwtstamps->hwtstamp = hwtstamp; cf->can_id |=CAN_ERR_BUSERROR ; - cf->data[6 ] = bec.txerr; - cf->data[7 ] = bec.rxerr; +if (new_state !=CAN_STATE_BUS_OFF ) { + cf->data[6 ] = bec.txerr; + cf->data[7 ] = bec.rxerr; + }netif_rx (skb);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 491/1095 can: kvaser_usb_leaf: do not report txerr and rxerr during bus-off
In reply to Greg Kroah-HartmanFrom: Vincent Mailhol <[email protected]>
[ Upstream commit a57732084e06791d37ea1ea447cca46220737abd ]
During bus off, the error count is greater than 255 and can not fit in a u8.
--- drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c +4 -2
@@ -853,8 +853,10 @@ static void kvaser_usb_leaf_rx_error(const struct kvaser_usb *dev,break ; } - cf->data[6 ] = es->txerr; - cf->data[7 ] = es->rxerr; +if (new_state !=CAN_STATE_BUS_OFF ) { + cf->data[6 ] = es->txerr; + cf->data[7 ] = es->rxerr; + }netif_rx (skb); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 492/1095 can: usb_8dev: do not report txerr and rxerr during bus-off
In reply to Greg Kroah-HartmanFrom: Vincent Mailhol <[email protected]>
[ Upstream commit aebe8a2433cd090ccdc222861f44bddb75eb01de ]
During bus off, the error count is greater than 255 and can not fit in a u8.
--- drivers/net/can/usb/usb_8dev.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/can/usb/usb_8dev.c +4 -3
@@ -439,9 +439,10 @@ static void usb_8dev_rx_err_msg(struct usb_8dev_priv *priv,if (rx_errors) stats->rx_errors++; - - cf->data[6 ] = txerr; - cf->data[7 ] = rxerr; +if (priv->can.state !=CAN_STATE_BUS_OFF ) { + cf->data[6 ] = txerr; + cf->data[7 ] = rxerr; + } priv->bec.txerr = txerr; priv->bec.rxerr = rxerr;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 493/1095 can: error: specify the values of data[5..7] of CAN error frames
In reply to Greg Kroah-HartmanFrom: Vincent Mailhol <[email protected]>
[ Upstream commit e70a3263a7eed768d5f947b8f2aff8d2a79c9d97 ]
Currently, data[5..7] of struct can_frame, when used as a CAN error frame, are defined as being "controller specific". Device specific behaviours are problematic because it prevents someone from writing code which is portable between devices.
As a matter of fact, data[5] is never used, data[6] is always used to report TX error counter and data[7] is always used to report RX error counter. can-utils also relies on this.
This patch updates the comment in the uapi header to specify that data[5] is reserved (and thus should not be used) and that data[6..7] are used for error counters.
--- include/uapi/linux/can/error.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
include/uapi/linux/can/error.h +4 -1
@@ -120,6 +120,9 @@#define CAN_ERR_TRX_CANL_SHORT_TO_GND 0x70/* 0111 0000 */ #define CAN_ERR_TRX_CANL_SHORT_TO_CANH 0x80/* 1000 0000 */ -/* controller specific additional information / data[5..7] */ +/* data[5] is reserved (do not use) */ + +/* TX error counter / data[6] */ +/* RX error counter / data[7] */ #endif /* _UAPI_CAN_ERROR_H */
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 494/1095 can: pch_can: pch_can_error(): initialize errc before using it
In reply to Greg Kroah-HartmanFrom: Vincent Mailhol <[email protected]>
[ Upstream commit 9950f11211331180269867aef848c7cf56861742 ]
After commit 3a5c7e4611dd, the variable errc is accessed before being initialized, c.f. below W=2 warning:
| In function 'pch_can_error', | inlined from 'pch_can_poll' at drivers/net/can/pch_can.c:739:4: | drivers/net/can/pch_can.c:501:29: warning: 'errc' may be used uninitialized [-Wmaybe-uninitialized] | 501 | cf->data[6] = errc & PCH_TEC; | | ^ | drivers/net/can/pch_can.c: In function 'pch_can_poll': | drivers/net/can/pch_can.c:484:13: note: 'errc' was declared here | 484 | u32 errc, lec; | | ^~~~
Moving errc initialization up solves this issue.
--- drivers/net/can/pch_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/can/pch_can.c +1 -1
@@ -489,6 +489,7 @@ static void pch_can_error(struct net_device *ndev, u32 status)if (!skb)return ; + errc =ioread32 (&priv->regs->errc);if (status &PCH_BUS_OFF ) {pch_can_set_tx_all (priv,0 );pch_can_set_rx_all (priv,0 );
@@ -501,7 +502,6 @@ static void pch_can_error(struct net_device *ndev, u32 status) cf->data[7 ] = (errc &PCH_REC ) >>8 ; } - errc =ioread32 (&priv->regs->errc);/* Warning interrupt. */ if (status &PCH_EWARN ) { state =CAN_STATE_ERROR_WARNING ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 495/1095 Bluetooth: hci_intel: Add check for platform_driver_register
In reply to Greg Kroah-HartmanFrom: Jiasheng Jiang <[email protected]>
[ Upstream commit ab2d2a982ff721f4b029282d9a40602ea46a745e ]
As platform_driver_register() could fail, it should be better to deal with the return value in order to maintain the code consisitency.
--- drivers/bluetooth/hci_intel.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/bluetooth/hci_intel.c +5 -1
@@ -1217,7 +1217,11 @@ static struct platform_driver intel_driver = {int __init intel_init (void ) { -platform_driver_register (&intel_driver); +int err; + + err =platform_driver_register (&intel_driver); +if (err) +return err;return hci_uart_register_proto (&intel_proto); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 496/1095 Bluetooth: When HCI work queue is drained, only queue chained work
In reply to Greg Kroah-HartmanFrom: Schspa Shi <[email protected]>
[ Upstream commit 877afadad2dce8aae1f2aad8ce47e072d4f6165e ]
The HCI command, event, and data packet processing workqueue is drained to avoid deadlock in commit76727c02c1e1 ("Bluetooth: Call drain_workqueue() before resetting state").
There is another delayed work, which will queue command to this drained workqueue. Which results in the following error report:
Bluetooth: hci2: command 0x040f tx timeout
WARNING: CPU: 1 PID: 18374 at kernel/workqueue.c:1438 __queue_work+0xdad/0x1140 Workqueue: events hci_cmd_timeout RIP: 0010:__queue_work+0xdad/0x1140 RSP: 0000:ffffc90002cffc60 EFLAGS: 00010093 RAX: 0000000000000000 RBX: ffff8880b9d3ec00 RCX: 0000000000000000 RDX: ffff888024ba0000 RSI: ffffffff814e048d RDI: ffff8880b9d3ec08 RBP: 0000000000000008 R08: 0000000000000000 R09: 00000000b9d39700 R10: ffffffff814f73c6 R11: 0000000000000000 R12: ffff88807cce4c60 R13: 0000000000000000 R14: ffff8880796d8800 R15: ffff8880796d8800 FS: 0000000000000000(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 000000c0174b4000 CR3: 000000007cae9000 CR4: 00000000003506e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> ? queue_work_on+0xcb/0x110 ? lockdep_hardirqs_off+0x90/0xd0 queue_work_on+0xee/0x110 process_one_work+0x996/0x1610 ? pwq_dec_nr_in_flight+0x2a0/0x2a0 ? rwlock_bug.part.0+0x90/0x90 ? _raw_spin_lock_irq+0x41/0x50 worker_thread+0x665/0x1080 ? process_one_work+0x1610/0x1610 kthread+0x2e9/0x3a0 ? kthread_complete_and_exit+0x40/0x40 ret_from_fork+0x1f/0x30 </TASK>
To fix this, we can add a new HCI_DRAIN_WQ flag, and don't queue the timeout workqueue while command workqueue is draining.
--- include/net/bluetooth/hci.h | 1 + net/bluetooth/hci_core.c | 10 +++++++++- net/bluetooth/hci_event.c | 5 +++-- 3 files changed, 13 insertions(+), 3 deletions(-)
include/net/bluetooth/hci.h +1 -0
@@ -361,6 +361,7 @@ enum {HCI_QUALITY_REPORT ,HCI_OFFLOAD_CODECS_ENABLED ,HCI_LE_SIMULTANEOUS_ROLES , +HCI_CMD_DRAIN_WORKQUEUE , __HCI_NUM_FLAGS, };
net/bluetooth/hci_core.c +9 -1
@@ -593,6 +593,11 @@ static int hci_dev_do_reset(struct hci_dev *hdev)skb_queue_purge (&hdev->rx_q);skb_queue_purge (&hdev->cmd_q); +/* Cancel these to avoid queueing non-chained pending work */ +hci_dev_set_flag (hdev,HCI_CMD_DRAIN_WORKQUEUE ); +cancel_delayed_work (&hdev->cmd_timer); +cancel_delayed_work (&hdev->ncmd_timer); +/* Avoid potential lockdep warnings from the *_flush() calls by * ensuring the workqueue is empty up front. */
@@ -606,6 +611,8 @@ static int hci_dev_do_reset(struct hci_dev *hdev)if (hdev->flush) hdev->flush (hdev); +hci_dev_clear_flag (hdev,HCI_CMD_DRAIN_WORKQUEUE ); +atomic_set (&hdev->cmd_cnt,1 ); hdev->acl_cnt =0 ; hdev->sco_cnt =0 ; hdev->le_cnt =0 ;
@@ -3863,7 +3870,8 @@ static void hci_cmd_work(struct work_struct *work)if (res <0 )__hci_cmd_sync_cancel (hdev, -res); -if (test_bit (HCI_RESET , &hdev->flags)) +if (test_bit (HCI_RESET , &hdev->flags) || +hci_dev_test_flag (hdev,HCI_CMD_DRAIN_WORKQUEUE ))cancel_delayed_work (&hdev->cmd_timer);else schedule_delayed_work(&hdev->cmd_timer,
net/bluetooth/hci_event.c +3 -2
@@ -3768,8 +3768,9 @@ static inline void handle_cmd_cnt_and_timer(struct hci_dev *hdev, u8 ncmd)cancel_delayed_work (&hdev->ncmd_timer);atomic_set (&hdev->cmd_cnt,1 ); }else { -schedule_delayed_work (&hdev->ncmd_timer, -HCI_NCMD_TIMEOUT ); +if (!hci_dev_test_flag (hdev,HCI_CMD_DRAIN_WORKQUEUE )) +schedule_delayed_work (&hdev->ncmd_timer, +HCI_NCMD_TIMEOUT ); } } }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 497/1095 Bluetooth: mgmt: Fix refresh cached connection info
In reply to Greg Kroah-HartmanFrom: Zhengping Jiang <[email protected]>
[ Upstream commit d7b2fdfb53ea09382941c0a4950dc9b00d51d1c7 ]
Set the connection data before calling get_conn_info_sync, so it can be verified the connection is still connected, before refreshing cached values.
--- net/bluetooth/mgmt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
net/bluetooth/mgmt.c +5 -5
@@ -6821,11 +6821,14 @@ static int get_conn_info(struct sock *sk, struct hci_dev *hdev, void *data, cmd =mgmt_pending_new (sk,MGMT_OP_GET_CONN_INFO , hdev, data, len); -if (!cmd) +if (!cmd) { err = -ENOMEM ; -else + }else { +hci_conn_hold (conn); + cmd->user_data =hci_conn_get (conn); err =hci_cmd_sync_queue (hdev, get_conn_info_sync, cmd, get_conn_info_complete); + }if (err <0 ) { mgmt_cmd_complete(sk, hdev->id, MGMT_OP_GET_CONN_INFO,
@@ -6837,9 +6840,6 @@ static int get_conn_info(struct sock *sk, struct hci_dev *hdev, void *data, goto unlock; } -hci_conn_hold (conn); - cmd->user_data =hci_conn_get (conn); - conn->conn_info_timestamp = jiffies; }else {/* Cache is valid, just reply with values cached in hci_conn */
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 498/1095 Bluetooth: hci_sync: Fix resuming scan after suspend resume
In reply to Greg Kroah-HartmanFrom: Zhengping Jiang <[email protected]>
[ Upstream commit 68253f3cd715e819bc4bff2b0e6b21234e259d56 ]
After resuming, remove setting scanning_paused to false, because it is checked and set to false in hci_resume_scan_sync. Also move setting the value to false before updating passive scan, because the value is used when resuming passive scan.
unfiltered passive scan)
--- net/bluetooth/hci_sync.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
net/bluetooth/hci_sync.c +2 -3
@@ -5008,13 +5008,13 @@ static int hci_resume_scan_sync(struct hci_dev *hdev)if (!hdev->scanning_paused)return 0 ; + hdev->scanning_paused = false; +hci_update_scan_sync (hdev);/* Reset passive scanning to normal */ hci_update_passive_scan_sync (hdev); - hdev->scanning_paused = false; -return 0 ; }
@@ -5033,7 +5033,6 @@ int hci_resume_sync(struct hci_dev *hdev)return 0 ; hdev->suspended = false; - hdev->scanning_paused = false;/* Restore event mask */ hci_set_event_mask_sync (hdev);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 499/1095 Bluetooth: hci_sync: Fix not updating privacy_mode
In reply to Greg Kroah-HartmanFrom: Luiz Augusto von Dentz <[email protected]>
[ Upstream commit 0900b1c62f43e495d04ca4bebdf80b34f3c12432 ]
When programming a new entry into the resolving list it shall default to network mode since the params may contain the mode programmed when the device was last added to the resolving list.
--- net/bluetooth/hci_sync.c | 3 +++ 1 file changed, 3 insertions(+)
net/bluetooth/hci_sync.c +3 -0
@@ -1612,6 +1612,9 @@ static int hci_le_add_resolve_list_sync(struct hci_dev *hdev,bacpy (&cp.bdaddr, ¶ms->addr);memcpy (cp.peer_irk, irk->val,16 ); +/* Default privacy mode is always Network */ + params->privacy_mode =HCI_NETWORK_PRIVACY ; + done:if (hci_dev_test_flag (hdev,HCI_PRIVACY ))memcpy (cp.local_irk, hdev->irk,16 );
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 500/1095 Bluetooth: Add default wakeup callback for HCI UART driver
In reply to Greg Kroah-HartmanFrom: Ying Hsu <[email protected]>
[ Upstream commit bee5395ced44c5a312348557eb2dfb0c2a7bfaa2 ]
Bluetooth HCI devices indicate if they are able to wakeup in the wakeup callback since 'commit 4539ca67fe8e ("Bluetooth: Rename driver .prevent_wake to .wakeup")'. This patch adds a default wakeup callback for Bluetooth HCI UAR devices. It assumes Bluetooth HCI UART devices are wakeable for backward compatibility. For those who need a customized behavior, one can override it before calling hci_uart_register_device().
--- drivers/bluetooth/hci_serdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/bluetooth/hci_serdev.c +11 -0
@@ -231,6 +231,15 @@ static int hci_uart_setup(struct hci_dev *hdev)return 0 ; } +/* Check if the device is wakeable */ +static bool hci_uart_wakeup (struct hci_dev *hdev) +{ +/* HCI UART devices are assumed to be wakeable by default. +* Implement wakeup callback to override this behavior. +*/ +return true; +} +/** hci_uart_write_wakeup - transmit buffer wakeup * @serdev: serial device *
@@ -342,6 +351,8 @@ int hci_uart_register_device(struct hci_uart *hu, hdev->flush = hci_uart_flush; hdev->send = hci_uart_send_frame; hdev->setup = hci_uart_setup; +if (!hdev->wakeup) + hdev->wakeup = hci_uart_wakeup;SET_HCIDEV_DEV (hdev, &hu->serdev->dev);if (test_bit (HCI_UART_NO_SUSPEND_NOTIFIER , &hu->flags))
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 501/1095 i2c: cadence: Support PEC for SMBus block read
In reply to Greg Kroah-HartmanFrom: Lars-Peter Clausen <[email protected]>
[ Upstream commit 9fdf6d97f03035ad5298e2d1635036c74c2090ed ]
SMBus packet error checking (PEC) is implemented by appending one additional byte of checksum data at the end of the message. This provides additional protection and allows to detect data corruption on the I2C bus.
SMBus block reads support variable length reads. The first byte in the read message is the number of available data bytes.
The combination of PEC and block read is currently not supported by the Cadence I2C driver.
* When PEC is enabled the maximum transfer length for block reads increases from 33 to 34 bytes.
* The I2C core smbus emulation layer relies on the driver updating the i2c_msg len field with the number of received bytes. The updated length is used when checking the PEC.
Add support to the Cadence I2C driver for handling SMBus block reads with PEC. To determine the maximum transfer length uses the initial len value of the i2c_msg. When PEC is enabled this will be 2, when it is disabled it will be 1.
Once a read transfer is done also increment the len field by the amount of received data bytes.
This change has been tested with a UCM90320 PMBus power monitor, which requires block reads to access certain data fields, but also has PEC enabled by default.
--- drivers/i2c/busses/i2c-cadence.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/i2c/busses/i2c-cadence.c +9 -1
@@ -573,8 +573,13 @@ static void cdns_i2c_mrecv(struct cdns_i2c *id) ctrl_reg =cdns_i2c_readreg (CDNS_I2C_CR_OFFSET ); ctrl_reg |=CDNS_I2C_CR_RW |CDNS_I2C_CR_CLR_FIFO ; +/* +* Receive up to I2C_SMBUS_BLOCK_MAX data bytes, plus one message length +* byte, plus one checksum byte if PEC is enabled. p_msg->len will be 2 if +* PEC is enabled, otherwise 1. +*/ if (id->p_msg->flags &I2C_M_RECV_LEN ) - id->recv_count =I2C_SMBUS_BLOCK_MAX +1 ; + id->recv_count =I2C_SMBUS_BLOCK_MAX + id->p_msg->len; id->curr_recv_count = id->recv_count;
@@ -789,6 +794,9 @@ static int cdns_i2c_process_msg(struct cdns_i2c *id, struct i2c_msg *msg,if (id->err_status &CDNS_I2C_IXR_ARB_LOST )return -EAGAIN ; +if (msg->flags &I2C_M_RECV_LEN ) + msg->len += min_t(unsigned int, msg->buf[0], I2C_SMBUS_BLOCK_MAX); +return 0 ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 502/1095 i2c: qcom-geni: Use the correct return value
In reply to Greg Kroah-HartmanFrom: Bjorn Andersson <[email protected]>
[ Upstream commit b3f0ceb7c2037c6e3affd7d9c84ac5f97af7a5b5 ]
The introduction of GPI support moved things around and instead of returning the result from geni_i2c_xfer() the number of messages in the request was returned, ignoring the actual result. Fix this.
--- drivers/i2c/busses/i2c-qcom-geni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-qcom-geni.c +1 -1
@@ -688,7 +688,7 @@ static int geni_i2c_xfer(struct i2c_adapter *adap,pm_runtime_put_autosuspend (gi2c->se.dev); gi2c->cur =NULL ; gi2c->err =0 ; -return num; +return ret; }static u32 geni_i2c_func (struct i2c_adapter *adap)
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 503/1095 bpf: Fix bpf_xdp_pointer return pointer
In reply to Greg Kroah-HartmanFrom: Joanne Koong <[email protected]>
[ Upstream commit bbd52178e249fe893ef4a9b87cde5b6c473b0a7c ]
For the case where offset + len == size, bpf_xdp_pointer should return a valid pointer to the addr because that access is permitted. We should only return NULL in the case where offset + len exceeds size.
--- net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/filter.c +1 -1
@@ -3917,7 +3917,7 @@ static void *bpf_xdp_pointer(struct xdp_buff *xdp, u32 offset, u32 len) offset -= frag_size; } out: -return offset + len < size ? addr + offset :NULL ; +return offset + len <= size ? addr + offset :NULL ; } BPF_CALL_4(bpf_xdp_load_bytes, struct xdp_buff *, xdp, u32, offset,
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 504/1095 i2c: mux-gpmux: Add of_node_put() when breaking out of loop
In reply to Greg Kroah-HartmanFrom: Liang He <[email protected]>
[ Upstream commit 6435319c34704994e19b0767f6a4e6f37439867b ]
In i2c_mux_probe(), we should call of_node_put() when breaking out of for_each_child_of_node() which will automatically increase and decrease the refcount.
--- drivers/i2c/muxes/i2c-mux-gpmux.c | 1 + 1 file changed, 1 insertion(+)
drivers/i2c/muxes/i2c-mux-gpmux.c +1 -0
@@ -134,6 +134,7 @@ static int i2c_mux_probe(struct platform_device *pdev)return 0 ; err_children: +of_node_put (child);i2c_mux_del_adapters (muxc); err_parent:i2c_put_adapter (parent);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 505/1095 wifi: wil6210: debugfs: fix uninitialized variable use in `wil_write_file_wmi()`
In reply to Greg Kroah-HartmanFrom: Ammar Faizi <[email protected]>
[ Upstream commit d578e0af3a003736f6c440188b156483d451b329 ]
Commit 7a4836560a61 changes simple_write_to_buffer() with memdup_user() but it forgets to change the value to be returned that came from simple_write_to_buffer() call. It results in the following warning:
warning: variable 'rc' is uninitialized when used here [-Wuninitialized]
return rc;
^~Remove rc variable and just return the passed in length if the memdup_user() succeeds.
--- drivers/net/wireless/ath/wil6210/debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/wil6210/debugfs.c +2 -2
@@ -1010,7 +1010,7 @@ static ssize_t wil_write_file_wmi(struct file *file, const char __user *buf,void *cmd;int cmdlen = len -sizeof (struct wmi_cmd_hdr );u16 cmdid; -int rc, rc1; +int rc1;if (cmdlen <0 || *ppos !=0 )return -EINVAL ;
@@ -1027,7 +1027,7 @@ static ssize_t wil_write_file_wmi(struct file *file, const char __user *buf,wil_info (wil,"0x%04x[%d] -> %d\n" , cmdid, cmdlen, rc1); -return rc; +return len; }static const struct file_operations fops_wmi = {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 506/1095 wifi: iwlwifi: mvm: fix double list_add at iwl_mvm_mac_wake_tx_queue
In reply to Greg Kroah-HartmanFrom: Jose Ignacio Tornos Martinez <[email protected]>
[ Upstream commit 14a3aacf517a9de725dd3219dbbcf741e31763c4 ]
After successfull station association, if station queues are disabled for some reason, the related lists are not emptied. So if some new element is added to the list in iwl_mvm_mac_wake_tx_queue, it can match with the old one and produce a BUG like this:
[ 46.535263] list_add corruption. prev->next should be next (ffff94c1c318a360), but was 0000000000000000. (prev=ffff94c1d02d3388). [ 46.535283] ------------[ cut here ]------------ [ 46.535284] kernel BUG at lib/list_debug.c:26! [ 46.535290] invalid opcode: 0000 [#1] PREEMPT SMP PTI [ 46.585304] CPU: 0 PID: 623 Comm: wpa_supplicant Not tainted 5.19.0-rc3+ #1 [ 46.592380] Hardware name: Dell Inc. Inspiron 660s/0478VN , BIOS A07 08/24/2012 [ 46.600336] RIP: 0010:__list_add_valid.cold+0x3d/0x3f [ 46.605475] Code: f2 4c 89 c1 48 89 fe 48 c7 c7 c8 40 67 93 e8 20 cc fd ff 0f 0b 48 89 d1 4c 89 c6 4c 89 ca 48 c7 c7 70 40 67 93 e8 09 cc fd ff <0f> 0b 48 89 fe 48 c7 c7 00 41 67 93 e8 f8 cb fd ff 0f 0b 48 89 d1 [ 46.624469] RSP: 0018:ffffb20800ab76d8 EFLAGS: 00010286 [ 46.629854] RAX: 0000000000000075 RBX: ffff94c1c318a0e0 RCX: 0000000000000000 [ 46.637105] RDX: 0000000000000201 RSI: ffffffff9365e100 RDI: 00000000ffffffff [ 46.644356] RBP: ffff94c1c5f43370 R08: 0000000000000075 R09: 3064316334396666 [ 46.651607] R10: 3364323064316334 R11: 39666666663d7665 R12: ffff94c1c5f43388 [ 46.658857] R13: ffff94c1d02d3388 R14: ffff94c1c318a360 R15: ffff94c1cf2289c0 [ 46.666108] FS: 00007f65634ff7c0(0000) GS:ffff94c1da200000(0000) knlGS:0000000000000000 [ 46.674331] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 46.680170] CR2: 00007f7dfe984460 CR3: 000000010e894003 CR4: 00000000000606f0 [ 46.687422] Call Trace: [ 46.689906] <TASK> [ 46.691950] iwl_mvm_mac_wake_tx_queue+0xec/0x15c [iwlmvm] [ 46.697601] ieee80211_queue_skb+0x4b3/0x720 [mac80211] [ 46.702973] ? sta_info_get+0x46/0x60 [mac80211] [ 46.707703] ieee80211_tx+0xad/0x110 [mac80211] [ 46.712355] __ieee80211_tx_skb_tid_band+0x71/0x90 [mac80211]
...
In order to avoid this problem, we must also remove the related lists when station queues are disabled.
--- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/wireless/intel/iwlwifi/mvm/sta.c +1 -0
@@ -1862,6 +1862,7 @@ static void iwl_mvm_disable_sta_queues(struct iwl_mvm *mvm,iwl_mvm_txq_from_mac80211 (sta->txq[i]); mvmtxq->txq_id =IWL_MVM_INVALID_QUEUE ; +list_del_init (&mvmtxq->list); } }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 507/1095 wifi: libertas: Fix possible refcount leak in if_usb_probe()
In reply to Greg Kroah-HartmanFrom: Hangyu Hua <[email protected]>
[ Upstream commit 6fd57e1d120bf13d4dc6c200a7cf914e6347a316 ]
usb_get_dev will be called before lbs_get_firmware_async which means that usb_put_dev need to be called when lbs_get_firmware_async fails.
--- drivers/net/wireless/marvell/libertas/if_usb.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/wireless/marvell/libertas/if_usb.c +1 -0
@@ -287,6 +287,7 @@ static int if_usb_probe(struct usb_interface *intf,return 0 ; err_get_fw: +usb_put_dev (udev);lbs_remove_card (priv); err_add_card:if_usb_reset_device (cardp);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 508/1095 media: cedrus: hevc: Add check for invalid timestamp
In reply to Greg Kroah-HartmanFrom: Jernej Skrabec <[email protected]>
[ Upstream commit 143201a6435bf65f0115435e9dc6d95c66b908e9 ]
Not all DPB entries will be used most of the time. Unused entries will thus have invalid timestamps. They will produce negative buffer index which is not specifically handled. This works just by chance in current code. It will even produce bogus pointer, but since it's not used, it won't do any harm.
Let's fix that brittle design by skipping writing DPB entry altogether if timestamp is invalid.
--- drivers/staging/media/sunxi/cedrus/cedrus_h265.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/staging/media/sunxi/cedrus/cedrus_h265.c +3 -0
@@ -147,6 +147,9 @@ static void cedrus_h265_frame_info_write_dpb(struct cedrus_ctx *ctx, dpb[i].pic_order_cnt_val }; +if (buffer_index <0 ) +continue ; +cedrus_h265_frame_info_write_single (ctx, i, dpb[i].field_pic, pic_order_cnt, buffer_index);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 509/1095 hantro: Remove incorrect HEVC SPS validation
In reply to Greg Kroah-HartmanFrom: Ezequiel Garcia <[email protected]>
[ Upstream commit df9ec2fc8e70e01532fd9161cd98711969561ff6 ]
Currently, the driver tries to validat the HEVC SPS against the CAPTURE queue format (i.e. the decoded format). This is not correct, because typically the SPS control is set before the CAPTURE queue is negotiated.
--- drivers/staging/media/hantro/hantro_drv.c | 12 ++++++------ drivers/staging/media/hantro/hantro_hevc.c | 9 +-------- drivers/staging/media/hantro/hantro_hw.h | 1 - 3 files changed, 7 insertions(+), 15 deletions(-)
drivers/staging/media/hantro/hantro_drv.c +6 -6
@@ -253,11 +253,6 @@ queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *dst_vq)static int hantro_try_ctrl (struct v4l2_ctrl *ctrl) { -struct hantro_ctx *ctx; - - ctx =container_of (ctrl->handler, - struct hantro_ctx, ctrl_handler); -if (ctrl->id ==V4L2_CID_STATELESS_H264_SPS ) {const struct v4l2_ctrl_h264_sps *sps = ctrl->p_new.p_h264_sps;
@@ -273,7 +268,12 @@ static int hantro_try_ctrl(struct v4l2_ctrl *ctrl) }else if (ctrl->id ==V4L2_CID_MPEG_VIDEO_HEVC_SPS ) {const struct v4l2_ctrl_hevc_sps *sps = ctrl->p_new.p_hevc_sps; -return hantro_hevc_validate_sps (ctx, sps); +if (sps->bit_depth_luma_minus8 != sps->bit_depth_chroma_minus8) +/* Luma and chroma bit depth mismatch */ +return -EINVAL ; +if (sps->bit_depth_luma_minus8 !=0 ) +/* Only 8-bit is supported */ +return -EINVAL ; }else if (ctrl->id ==V4L2_CID_STATELESS_VP9_FRAME ) {const struct v4l2_ctrl_vp9_frame *dec_params = ctrl->p_new.p_vp9_frame;
drivers/staging/media/hantro/hantro_hevc.c +1 -8
@@ -154,15 +154,8 @@ static int tile_buffer_reallocate(struct hantro_ctx *ctx)return -ENOMEM ; } -int hantro_hevc_validate_sps (struct hantro_ctx *ctx,const struct v4l2_ctrl_hevc_sps *sps) +static int hantro_hevc_validate_sps (struct hantro_ctx *ctx,const struct v4l2_ctrl_hevc_sps *sps) { -if (sps->bit_depth_luma_minus8 != sps->bit_depth_chroma_minus8) -/* Luma and chroma bit depth mismatch */ -return -EINVAL ; -if (sps->bit_depth_luma_minus8 !=0 ) -/* Only 8-bit is supported */ -return -EINVAL ; -/* * for tile pixel format check if the width and height match * hardware constraints
drivers/staging/media/hantro/hantro_hw.h +0 -1
@@ -353,7 +353,6 @@ int hantro_hevc_dec_prepare_run(struct hantro_ctx *ctx);void hantro_hevc_ref_init (struct hantro_ctx *ctx);dma_addr_t hantro_hevc_get_ref_buf (struct hantro_ctx *ctx,s32 poc);int hantro_hevc_add_ref_buf (struct hantro_ctx *ctx,int poc,dma_addr_t addr); -int hantro_hevc_validate_sps (struct hantro_ctx *ctx,const struct v4l2_ctrl_hevc_sps *sps);static inline unsigned short hantro_vp9_num_sbs (unsigned short dimension)
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 510/1095 drm/amd/display: fix signedness bug in execute_synaptics_rc_command()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit 06ac561fb0edf868f7b292fb4a3c8ffbbb1e14bb ]
The "ret" variable needs to be signed for the error handling to work.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +1 -1
@@ -571,7 +571,7 @@ static bool execute_synaptics_rc_command(struct drm_dp_aux *aux,unsigned char rc_cmd =0 ;unsigned char rc_result =0xFF ;unsigned char i =0 ; -uint8_t ret =0 ; +int ret;if (is_write_cmd) {// write rc data
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 511/1095 net/mlx5e: Remove WARN_ON when trying to offload an unsupported TLS cipher/version
In reply to Greg Kroah-HartmanFrom: Gal Pressman <[email protected]>
[ Upstream commit 115d9f95ea7ab780ef315dc356bebba2e07cb731 ]
The driver reports whether TX/RX TLS device offloads are supported, but not which ciphers/versions, these should be handled by returning -EOPNOTSUPP when .tls_dev_add() is called.
Remove the WARN_ON kernel trace when the driver gets a request to offload a cipher/version that is not supported as it is expected.
--- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c +1 -1
@@ -16,7 +16,7 @@ static int mlx5e_ktls_add(struct net_device *netdev, struct sock *sk,struct mlx5_core_dev *mdev = priv->mdev;int err; -if (WARN_ON (!mlx5e_ktls_type_check (mdev, crypto_info))) +if (!mlx5e_ktls_type_check (mdev, crypto_info))return -EOPNOTSUPP ;if (direction ==TLS_OFFLOAD_CTX_DIR_TX )
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 512/1095 net/mlx5e: TC, Fix post_act to not match on in_port metadata
In reply to Greg Kroah-HartmanFrom: Maor Dickman <[email protected]>
[ Upstream commit 903f2194f74bbd289f3170114035d472a36a8ab4 ]
The cited commit changed CT to use multi table actions post act infrastructure instead of using it own post act infrastructure, this broke decap during VF tunnel offload (Stack devices) with CT due to wrong match on in_port metadata in the post act table. This changed only broke VF tunnel offload because it modify the packet in_port metadata to be VF metadata and it isn't propagate the post act creation.
Fixed by modify post act rules to match only on fte_id and not match on in_port metadata which isn't needed.
--- drivers/net/ethernet/mellanox/mlx5/core/en/tc/post_act.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/mellanox/mlx5/core/en/tc/post_act.c +1 -0
@@ -128,6 +128,7 @@ mlx5e_tc_post_act_add(struct mlx5e_post_act *post_act, struct mlx5_flow_attr *at post_attr->inner_match_level =MLX5_MATCH_NONE ; post_attr->outer_match_level =MLX5_MATCH_NONE ; post_attr->action &= ~MLX5_FLOW_CONTEXT_ACTION_DECAP ; + post_attr->flags |=MLX5_ATTR_FLAG_NO_IN_PORT ; handle->ns_type = post_act->ns_type;/* Splits were handled before post action */
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 513/1095 net/mlx5e: Fix the value of MLX5E_MAX_RQ_NUM_MTTS
In reply to Greg Kroah-HartmanFrom: Maxim Mikityanskiy <[email protected]>
[ Upstream commit 562696c3c62c7c23dd896e9447252ce9268cb812 ]
MLX5E_MAX_RQ_NUM_MTTS should be the maximum value, so that MLX5_MTT_OCTW(MLX5E_MAX_RQ_NUM_MTTS) fits into u16. The current value of 1 << 17 results in MLX5_MTT_OCTW(1 << 17) = 1 << 16, which doesn't fit into u16. This commit replaces it with the maximum value that still fits u16.
--- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en.h +1 -1
@@ -109,7 +109,7 @@ struct page_pool;#define MLX5E_REQUIRED_WQE_MTTS (MLX5_ALIGN_MTTS(MLX5_MPWRQ_PAGES_PER_WQE + 1))#define MLX5E_REQUIRED_MTTS (wqes) (wqes * MLX5E_REQUIRED_WQE_MTTS)#define MLX5E_MAX_RQ_NUM_MTTS \ - ((1 << 16) * 2)/* So that MLX5_MTT_OCTW(num_mtts) fits into u16 */ + (ALIGN_DOWN(U16_MAX, 4) * 2)/* So that MLX5_MTT_OCTW(num_mtts) fits into u16 */ #define MLX5E_ORDER2_MAX_PACKET_MTU (order_base_2(10 * 1024))#define MLX5E_PARAMS_MAXIMUM_LOG_RQ_SIZE_MPW \ (ilog2(MLX5E_MAX_RQ_NUM_MTTS / MLX5E_REQUIRED_WQE_MTTS))
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 514/1095 net/mlx5e: xsk: Account for XSK RQ UMRs when calculating ICOSQ size
In reply to Greg Kroah-HartmanFrom: Maxim Mikityanskiy <[email protected]>
[ Upstream commit 52586d2f56b3e4f528ca7268d65074e92c936681 ]
ICOSQ is used to post UMR WQEs for both regular RQ and XSK RQ. However, space in ICOSQ is reserved only for the regular RQ, which may cause ICOSQ overflows when using XSK (the most risk is on activating channels).
This commit fixes the issue by reserving space for XSK UMR WQEs as well. As XSK may be enabled without restarting the channel and recreating the ICOSQ, this space is reserved unconditionally.
--- drivers/net/ethernet/mellanox/mlx5/core/en/params.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/en/params.c +12 -0
@@ -797,8 +797,20 @@ static u8 mlx5e_build_icosq_log_wq_sz(struct mlx5_core_dev *mdev,return MLX5E_PARAMS_MINIMUM_LOG_SQ_SIZE ; wqebbs =MLX5E_UMR_WQEBBS *BIT (mlx5e_get_rq_log_wq_sz (rqp->rqc)); + +/* If XDP program is attached, XSK may be turned on at any time without +* restarting the channel. ICOSQ must be big enough to fit UMR WQEs of +* both regular RQ and XSK RQ. +* Although mlx5e_mpwqe_get_log_rq_size accepts mlx5e_xsk_param, it +* doesn't affect its return value, as long as params->xdp_prog != NULL, +* so we can just multiply by 2. +*/ +if (params->xdp_prog) + wqebbs *=2 ; +if (params->packet_merge.type ==MLX5E_PACKET_MERGE_SHAMPO ) wqebbs +=mlx5e_shampo_icosq_sz (mdev, params, rqp); +return max_t (u8,MLX5E_PARAMS_MINIMUM_LOG_SQ_SIZE ,order_base_2 (wqebbs)); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 515/1095 net/mlx5e: Fix calculations related to max MPWQE size
In reply to Greg Kroah-HartmanFrom: Maxim Mikityanskiy <[email protected]>
[ Upstream commit 677e78c8d44f326a73a77d71acf3a49ea562c1d9 ]
Before commit 76c31e5f7585 ("net/mlx5e: Use FW limitation for max MPW WQEBBs"), the maximum size of MPWQE in WQEBBs was hardcoded as a driver constant. That commit started using the firmware capability that can further limit the size, however, it unintentionally changed a few things:
1. The calculation of MLX5E_MAX_KLM_PER_WQE used the size in DS, which was replaced by the size in WQEBBs, making the resulting value 4 times smaller.
2. MLX5E_TX_MPW_MAX_WQEBBS used to be aligned to the cache line size (either 64 or 128 bytes, i.e. 1 or 2 WQEBBs), but it's no longer the case if the firmware capability is smaller than the driver maximum.
Fix both issues by using the correct units for MLX5E_MAX_KLM_PER_WQE and by aligning mlx5e_get_sw_max_sq_mpw_wqebbs after taking the minimum.
Besides fixing the arithmetics in calculation of MLX5E_MAX_KLM_PER_WQE, also use appropriate constants: size of BSF * num of DS per WQEBB * number of WQEBBs (the calculation before the blamed commit) doesn't make much sense to calculate the WQE size in bytes, so just use size of WQEBB * number of WQEBBs.
While at it, replace the types that hold the number of WQEBBs by u8. These values don't exceed 16, and it allows to fill holes in two structs.
--- drivers/net/ethernet/mellanox/mlx5/core/en.h | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en.h +10 -9
@@ -174,8 +174,8 @@ struct page_pool; ALIGN_DOWN(MLX5E_KLM_MAX_ENTRIES_PER_WQE(wqe_size), MLX5_UMR_KLM_ALIGNMENT)#define MLX5E_MAX_KLM_PER_WQE (mdev) \ - MLX5E_KLM_ENTRIES_PER_WQE(mlx5e_get_sw_max_sq_mpw_wqebbs(mlx5e_get_max_sq_wqebbs(mdev)) \ - << MLX5_MKEY_BSF_OCTO_SIZE) + MLX5E_KLM_ENTRIES_PER_WQE(MLX5_SEND_WQE_BB * \ + mlx5e_get_sw_max_sq_mpw_wqebbs(mlx5e_get_max_sq_wqebbs(mdev)))#define MLX5E_MSG_LEVEL NETIF_MSG_LINK
@@ -233,7 +233,7 @@ static inline u16 mlx5e_get_max_sq_wqebbs(struct mlx5_core_dev *mdev) MLX5_CAP_GEN(mdev, max_wqe_sz_sq) / MLX5_SEND_WQE_BB); } -static inline u16 mlx5e_get_sw_max_sq_mpw_wqebbs (u16 max_sq_wqebbs) +static inline u8 mlx5e_get_sw_max_sq_mpw_wqebbs (u8 max_sq_wqebbs) {/* The return value will be multiplied by MLX5_SEND_WQEBB_NUM_DS. * Since max_sq_wqebbs may be up to MLX5_SEND_WQE_MAX_WQEBBS == 16,
@@ -242,11 +242,12 @@ static inline u16 mlx5e_get_sw_max_sq_mpw_wqebbs(u16 max_sq_wqebbs)* than MLX5_SEND_WQE_MAX_WQEBBS to let a full-session WQE be * cache-aligned. */ -#if L1_CACHE_BYTES <128 -return min_t (u16, max_sq_wqebbs,MLX5_SEND_WQE_MAX_WQEBBS -1 ); -#else -return min_t (u16, max_sq_wqebbs,MLX5_SEND_WQE_MAX_WQEBBS -2 ); +u8 wqebbs =min_t (u8, max_sq_wqebbs,MLX5_SEND_WQE_MAX_WQEBBS -1 ); + +#if L1_CACHE_BYTES >=128 + wqebbs =ALIGN_DOWN (wqebbs,2 );#endif +return wqebbs; }struct mlx5e_tx_wqe {
@@ -456,7 +457,7 @@ struct mlx5e_txqsq {struct netdev_queue *txq;u32 sqn;u16 stop_room; -u16 max_sq_mpw_wqebbs; +u8 max_sq_mpw_wqebbs;u8 min_inline_mode;struct device *pdev;__be32 mkey_be;
@@ -571,7 +572,7 @@ struct mlx5e_xdpsq {struct device *pdev;__be32 mkey_be;u16 stop_room; -u16 max_sq_mpw_wqebbs; +u8 max_sq_mpw_wqebbs;u8 min_inline_mode;unsigned long state;unsigned int hw_mtu;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 516/1095 net/mlx5e: Modify slow path rules to go to slow fdb
In reply to Greg Kroah-HartmanFrom: Vlad Buslov <[email protected]>
[ Upstream commit c0063a43700fa8c98cac2637aa1afcf40bb9e403 ]
While extending available range of supported chains/prios referenced commit also modified slow path rules to go to FT chain instead of actual slow FDB. However neither of existing users of the MLX5_ATTR_FLAG_SLOW_PATH flag (tunnel encap entries with invalid encap and flows with trap action) need to match on FT chain. After bridge offload was implemented packets of such flows can also be matched by bridge priority tables which is undesirable. Restore slow path flows implementation to redirect packets to slow_fdb.
--- .../mellanox/mlx5/core/eswitch_offloads.c | 23 ++++++++++++++----- 1 file changed, 17 insertions(+), 6 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +17 -6
@@ -230,10 +230,8 @@ esw_setup_ft_dest(struct mlx5_flow_destination *dest, }static void -esw_setup_slow_path_dest (struct mlx5_flow_destination *dest, -struct mlx5_flow_act *flow_act, -struct mlx5_fs_chains *chains, -int i) +esw_setup_accept_dest (struct mlx5_flow_destination *dest,struct mlx5_flow_act *flow_act, +struct mlx5_fs_chains *chains,int i) {if (mlx5_chains_ignore_flow_level_supported (chains)) flow_act->flags |=FLOW_ACT_IGNORE_FLOW_LEVEL ;
@@ -241,6 +239,16 @@ esw_setup_slow_path_dest(struct mlx5_flow_destination *dest, dest[i].ft =mlx5_chains_get_tc_end_ft (chains); } +static void +esw_setup_slow_path_dest (struct mlx5_flow_destination *dest,struct mlx5_flow_act *flow_act, +struct mlx5_eswitch *esw,int i) +{ +if (MLX5_CAP_ESW_FLOWTABLE_FDB (esw->dev, ignore_flow_level)) + flow_act->flags |=FLOW_ACT_IGNORE_FLOW_LEVEL ; + dest[i].type =MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE ; + dest[i].ft = esw->fdb_table.offloads.slow_fdb; +} + static int esw_setup_chain_dest(struct mlx5_flow_destination *dest, struct mlx5_flow_act *flow_act,
@@ -473,8 +481,11 @@ esw_setup_dests(struct mlx5_flow_destination *dest, }else if (attr->dest_ft) {esw_setup_ft_dest (dest, flow_act, esw, attr, spec, *i); (*i)++; - }else if (mlx5e_tc_attr_flags_skip (attr->flags)) { -esw_setup_slow_path_dest (dest, flow_act, chains, *i); + }else if (attr->flags &MLX5_ATTR_FLAG_SLOW_PATH ) { +esw_setup_slow_path_dest (dest, flow_act, esw, *i); + (*i)++; + }else if (attr->flags &MLX5_ATTR_FLAG_ACCEPT ) { +esw_setup_accept_dest (dest, flow_act, chains, *i); (*i)++; }else if (attr->dest_chain) { err = esw_setup_chain_dest(dest, flow_act, chains, attr->dest_chain,
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 517/1095 net/mlx5: Adjust log_max_qp to be 18 at most
In reply to Greg Kroah-HartmanFrom: Maher Sanalla <[email protected]>
[ Upstream commit a6e9085d791f8306084fd5bc44dd3fdd4e1ac27b ]
The cited commit limited log_max_qp to be 17 due to FW capabilities. Recently, it turned out that there are old FW versions that supported more than 17, so the cited commit caused a degradation.
Thus, set the maximum log_max_qp back to 18 as it was before the cited commit.
--- drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/main.c +1 -1
@@ -526,7 +526,7 @@ static int handle_hca_cap(struct mlx5_core_dev *dev, void *set_ctx)/* Check log_max_qp from HCA caps to set in current profile */ if (prof->log_max_qp ==LOG_MAX_SUPPORTED_QPS ) { - prof->log_max_qp =min_t (u8,17 ,MLX5_CAP_GEN_MAX (dev, log_max_qp)); + prof->log_max_qp =min_t (u8,18 ,MLX5_CAP_GEN_MAX (dev, log_max_qp)); }else if (MLX5_CAP_GEN_MAX (dev, log_max_qp) < prof->log_max_qp) { mlx5_core_warn(dev, "log_max_qp value in current profile is %d, changing it to HCA capability limit (%d)\n", prof->log_max_qp,
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 518/1095 net/mlx5: DR, Fix SMFS steering info dump format
In reply to Greg Kroah-HartmanFrom: Yevgeny Kliteynik <[email protected]>
[ Upstream commit 62d2664351ef37da34f6f3a3fd8ab34257d6fe30 ]
Fix several issues in SMFS steering info dump:
- Fix outdated macro value for matcher mask in the SMFS debug dump format. The existing value denotes the old format of the matcher mask, as it was used during the early stages of development, and it results in wrong parsing by the steering dump parser - wrong fields are shown in the parsed output.
- Add the missing destination table to the dumped action.
The missing dest table handle breaks the ability to associate between the "go to table" action and the actual table in the steering info.
--- .../ethernet/mellanox/mlx5/core/steering/dr_dbg.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_dbg.c +8 -5
@@ -21,10 +21,11 @@ enum dr_dump_rec_type {DR_DUMP_REC_TYPE_TABLE_TX =3102 ,DR_DUMP_REC_TYPE_MATCHER =3200 , -DR_DUMP_REC_TYPE_MATCHER_MASK =3201 , +DR_DUMP_REC_TYPE_MATCHER_MASK_DEPRECATED =3201 ,DR_DUMP_REC_TYPE_MATCHER_RX =3202 ,DR_DUMP_REC_TYPE_MATCHER_TX =3203 ,DR_DUMP_REC_TYPE_MATCHER_BUILDER =3204 , +DR_DUMP_REC_TYPE_MATCHER_MASK =3205 ,DR_DUMP_REC_TYPE_RULE =3300 , DR_DUMP_REC_TYPE_RULE_RX_ENTRY_V0 = 3301,
@@ -114,13 +115,15 @@ dr_dump_rule_action_mem(struct seq_file *file, const u64 rule_id,break ;case DR_ACTION_TYP_FT :if (action->dest_tbl->is_fw_tbl) -seq_printf (file,"%d,0x%llx,0x%llx,0x%x\n" , +seq_printf (file,"%d,0x%llx,0x%llx,0x%x,0x%x\n" ,DR_DUMP_REC_TYPE_ACTION_FT , action_id, - rule_id, action->dest_tbl->fw_tbl.id); + rule_id, action->dest_tbl->fw_tbl.id, +-1 );else -seq_printf (file,"%d,0x%llx,0x%llx,0x%x\n" , +seq_printf (file,"%d,0x%llx,0x%llx,0x%x,0x%llx\n" ,DR_DUMP_REC_TYPE_ACTION_FT , action_id, - rule_id, action->dest_tbl->tbl->table_id); + rule_id, action->dest_tbl->tbl->table_id, +DR_DBG_PTR_TO_ID (action->dest_tbl->tbl));break ;case DR_ACTION_TYP_CTR :
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 519/1095 net/mlx5: Fix driver use of uninitialized timeout
In reply to Greg Kroah-HartmanFrom: Shay Drory <[email protected]>
[ Upstream commit 42b4f7f66a43cdb9216e76e595c8a9af154806da ]
Currently, driver is setting default values to all timeouts during
function setup. The offending commit is using a timeout before
function setup, meaning: the timeout is 0 (or garbage), since no
value have been set.
This may result in failure to probe the driver:
mlx5_function_setup:1034:(pid 69850): Firmware over 4294967296 MS in pre-initializing state, aborting probe_one:1591:(pid 69850): mlx5_init_one failed with error code -16
Hence, set default values to timeouts during tout_init()
--- drivers/net/ethernet/mellanox/mlx5/core/lib/tout.c | 11 ++++------- drivers/net/ethernet/mellanox/mlx5/core/lib/tout.h | 1 - drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 -- 3 files changed, 4 insertions(+), 10 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/lib/tout.c +4 -7
@@ -32,20 +32,17 @@ static void tout_set(struct mlx5_core_dev *dev, u64 val, enum mlx5_timeouts_type dev->timeouts->to[type] = val; } -void mlx5_tout_set_def_val (struct mlx5_core_dev *dev) +int mlx5_tout_init (struct mlx5_core_dev *dev) {int i; -for (i =0 ; i <MAX_TIMEOUT_TYPES ; i++) -tout_set (dev, tout_def_sw_val[i], i); -} - -int mlx5_tout_init (struct mlx5_core_dev *dev) -{ dev->timeouts =kmalloc (sizeof (*dev->timeouts),GFP_KERNEL );if (!dev->timeouts)return -ENOMEM ; +for (i =0 ; i <MAX_TIMEOUT_TYPES ; i++) +tout_set (dev, tout_def_sw_val[i], i); +return 0 ; }
drivers/net/ethernet/mellanox/mlx5/core/lib/tout.h +0 -1
@@ -35,7 +35,6 @@ int mlx5_tout_init(struct mlx5_core_dev *dev);void mlx5_tout_cleanup (struct mlx5_core_dev *dev);void mlx5_tout_query_iseg (struct mlx5_core_dev *dev);int mlx5_tout_query_dtor (struct mlx5_core_dev *dev); -void mlx5_tout_set_def_val (struct mlx5_core_dev *dev);u64 _mlx5_tout_ms (struct mlx5_core_dev *dev,enum mlx5_timeouts_types type);#define mlx5_tout_ms (dev, type) _mlx5_tout_ms(dev, MLX5_TO_##type##_MS)
drivers/net/ethernet/mellanox/mlx5/core/main.c +0 -2
@@ -1025,8 +1025,6 @@ static int mlx5_function_setup(struct mlx5_core_dev *dev, u64 timeout)if (mlx5_core_is_pf (dev))pcie_print_link_status (dev->pdev); -mlx5_tout_set_def_val (dev); -/* wait for firmware to accept initialization segments configurations */ err = wait_fw_init(dev, timeout,
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 520/1095 ax25: fix incorrect dev_tracker usage
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit d7c4c9e075f8cc6d88d277bc24e5d99297f03c06 ]
While investigating a separate rose issue [1], and enabling CONFIG_NET_DEV_REFCNT_TRACKER=y, Bernard reported an orthogonal ax25 issue [2]
An ax25_dev can be used by one (or many) struct ax25_cb. We thus need different dev_tracker, one per struct ax25_cb.
After this patch is applied, we are able to focus on rose.
[1] https://lore.kernel.org/netdev/[email protected]/
[2]
[ 205.798723] reference already released. [ 205.798732] allocated in: [ 205.798734] ax25_bind+0x1a2/0x230 [ax25] [ 205.798747] __sys_bind+0xea/0x110 [ 205.798753] __x64_sys_bind+0x18/0x20 [ 205.798758] do_syscall_64+0x5c/0x80 [ 205.798763] entry_SYSCALL_64_after_hwframe+0x44/0xae [ 205.798768] freed in: [ 205.798770] ax25_release+0x115/0x370 [ax25] [ 205.798778] __sock_release+0x42/0xb0 [ 205.798782] sock_close+0x15/0x20 [ 205.798785] __fput+0x9f/0x260 [ 205.798789] ____fput+0xe/0x10 [ 205.798792] task_work_run+0x64/0xa0 [ 205.798798] exit_to_user_mode_prepare+0x18b/0x190 [ 205.798804] syscall_exit_to_user_mode+0x26/0x40 [ 205.798808] do_syscall_64+0x69/0x80 [ 205.798812] entry_SYSCALL_64_after_hwframe+0x44/0xae [ 205.798827] ------------[ cut here ]------------ [ 205.798829] WARNING: CPU: 2 PID: 2605 at lib/ref_tracker.c:136 ref_tracker_free.cold+0x60/0x81 [ 205.798837] Modules linked in: rose netrom mkiss ax25 rfcomm cmac algif_hash algif_skcipher af_alg bnep snd_hda_codec_hdmi nls_iso8859_1 i915 rtw88_8821ce rtw88_8821c x86_pkg_temp_thermal rtw88_pci intel_powerclamp rtw88_core snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio coretemp snd_hda_intel kvm_intel snd_intel_dspcfg mac80211 snd_hda_codec kvm i2c_algo_bit drm_buddy drm_dp_helper btusb drm_kms_helper snd_hwdep btrtl snd_hda_core btbcm joydev crct10dif_pclmul btintel crc32_pclmul ghash_clmulni_intel mei_hdcp btmtk intel_rapl_msr aesni_intel bluetooth input_leds snd_pcm crypto_simd syscopyarea processor_thermal_device_pci_legacy sysfillrect cryptd intel_soc_dts_iosf snd_seq sysimgblt ecdh_generic fb_sys_fops rapl libarc4 processor_thermal_device intel_cstate processor_thermal_rfim cec snd_timer ecc snd_seq_device cfg80211 processor_thermal_mbox mei_me processor_thermal_rapl mei rc_core at24 snd intel_pch_thermal intel_rapl_common ttm soundcore int340x_thermal_zone video [ 205.798948] mac_hid acpi_pad sch_fq_codel ipmi_devintf ipmi_msghandler drm msr parport_pc ppdev lp parport ramoops pstore_blk reed_solomon pstore_zone efi_pstore ip_tables x_tables autofs4 hid_generic usbhid hid i2c_i801 i2c_smbus r8169 xhci_pci ahci libahci realtek lpc_ich xhci_pci_renesas [last unloaded: ax25] [ 205.798992] CPU: 2 PID: 2605 Comm: ax25ipd Not tainted 5.18.11-F6BVP #3 [ 205.798996] Hardware name: To be filled by O.E.M. To be filled by O.E.M./CK3, BIOS 5.011 09/16/2020 [ 205.798999] RIP: 0010:ref_tracker_free.cold+0x60/0x81 [ 205.799005] Code: e8 d2 01 9b ff 83 7b 18 00 74 14 48 c7 c7 2f d7 ff 98 e8 10 6e fc ff 8b 7b 18 e8 b8 01 9b ff 4c 89 ee 4c 89 e7 e8 5d fd 07 00 <0f> 0b b8 ea ff ff ff e9 30 05 9b ff 41 0f b6 f7 48 c7 c7 a0 fa 4e [ 205.799008] RSP: 0018:ffffaf5281073958 EFLAGS: 00010286 [ 205.799011] RAX: 0000000080000000 RBX: ffff9a0bd687ebe0 RCX: 0000000000000000 [ 205.799014] RDX: 0000000000000001 RSI: 0000000000000282 RDI: 00000000ffffffff [ 205.799016] RBP: ffffaf5281073a10 R08: 0000000000000003 R09: fffffffffffd5618 [ 205.799019] R10: 0000000000ffff10 R11: 000000000000000f R12: ffff9a0bc53384d0 [ 205.799022] R13: 0000000000000282 R14: 00000000ae000001 R15: 0000000000000001 [ 205.799024] FS: 0000000000000000(0000) GS:ffff9a0d0f300000(0000) knlGS:0000000000000000 [ 205.799028] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 205.799031] CR2: 00007ff6b8311554 CR3: 000000001ac10004 CR4: 00000000001706e0 [ 205.799033] Call Trace: [ 205.799035] <TASK> [ 205.799038] ? ax25_dev_device_down+0xd9/0x1b0 [ax25] [ 205.799047] ? ax25_device_event+0x9f/0x270 [ax25] [ 205.799055] ? raw_notifier_call_chain+0x49/0x60 [ 205.799060] ? call_netdevice_notifiers_info+0x52/0xa0 [ 205.799065] ? dev_close_many+0xc8/0x120 [ 205.799070] ? unregister_netdevice_many+0x13d/0x890 [ 205.799073] ? unregister_netdevice_queue+0x90/0xe0 [ 205.799076] ? unregister_netdev+0x1d/0x30 [ 205.799080] ? mkiss_close+0x7c/0xc0 [mkiss] [ 205.799084] ? tty_ldisc_close+0x2e/0x40 [ 205.799089] ? tty_ldisc_hangup+0x137/0x210 [ 205.799092] ? __tty_hangup.part.0+0x208/0x350 [ 205.799098] ? tty_vhangup+0x15/0x20 [ 205.799103] ? pty_close+0x127/0x160 [ 205.799108] ? tty_release+0x139/0x5e0 [ 205.799112] ? __fput+0x9f/0x260 [ 205.799118] ax25_dev_device_down+0xd9/0x1b0 [ax25] [ 205.799126] ax25_device_event+0x9f/0x270 [ax25] [ 205.799135] raw_notifier_call_chain+0x49/0x60 [ 205.799140] call_netdevice_notifiers_info+0x52/0xa0 [ 205.799146] dev_close_many+0xc8/0x120 [ 205.799152] unregister_netdevice_many+0x13d/0x890 [ 205.799157] unregister_netdevice_queue+0x90/0xe0 [ 205.799161] unregister_netdev+0x1d/0x30 [ 205.799165] mkiss_close+0x7c/0xc0 [mkiss] [ 205.799170] tty_ldisc_close+0x2e/0x40 [ 205.799173] tty_ldisc_hangup+0x137/0x210 [ 205.799178] __tty_hangup.part.0+0x208/0x350 [ 205.799184] tty_vhangup+0x15/0x20 [ 205.799188] pty_close+0x127/0x160 [ 205.799193] tty_release+0x139/0x5e0 [ 205.799199] __fput+0x9f/0x260 [ 205.799203] ____fput+0xe/0x10 [ 205.799208] task_work_run+0x64/0xa0 [ 205.799213] do_exit+0x33b/0xab0 [ 205.799217] ? __handle_mm_fault+0xc4f/0x15f0 [ 205.799224] do_group_exit+0x35/0xa0 [ 205.799228] __x64_sys_exit_group+0x18/0x20 [ 205.799232] do_syscall_64+0x5c/0x80 [ 205.799238] ? handle_mm_fault+0xba/0x290 [ 205.799242] ? debug_smp_processor_id+0x17/0x20 [ 205.799246] ? fpregs_assert_state_consistent+0x26/0x50 [ 205.799251] ? exit_to_user_mode_prepare+0x49/0x190 [ 205.799256] ? irqentry_exit_to_user_mode+0x9/0x20 [ 205.799260] ? irqentry_exit+0x33/0x40 [ 205.799263] ? exc_page_fault+0x87/0x170 [ 205.799268] ? asm_exc_page_fault+0x8/0x30 [ 205.799273] entry_SYSCALL_64_after_hwframe+0x44/0xae [ 205.799277] RIP: 0033:0x7ff6b80eaca1 [ 205.799281] Code: Unable to access opcode bytes at RIP 0x7ff6b80eac77. [ 205.799283] RSP: 002b:00007fff6dfd4738 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7 [ 205.799287] RAX: ffffffffffffffda RBX: 00007ff6b8215a00 RCX: 00007ff6b80eaca1 [ 205.799290] RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000001 [ 205.799293] RBP: 0000000000000001 R08: ffffffffffffff80 R09: 0000000000000028 [ 205.799295] R10: 0000000000000000 R11: 0000000000000246 R12: 00007ff6b8215a00 [ 205.799298] R13: 0000000000000000 R14: 00007ff6b821aee8 R15: 00007ff6b821af00 [ 205.799304] </TASK>
--- include/net/ax25.h | 1 + net/ax25/af_ax25.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)
include/net/ax25.h +1 -0
@@ -236,6 +236,7 @@ typedef struct ax25_cb {ax25_address source_addr, dest_addr;ax25_digi *digipeat;ax25_dev *ax25_dev; +netdevice_tracker dev_tracker;unsigned char iamdigi;unsigned char state, modulus, pidincl;unsigned short vs, vr, va;
net/ax25/af_ax25.c +2 -2
@@ -1065,7 +1065,7 @@ static int ax25_release(struct socket *sock)del_timer_sync (&ax25->t3timer);del_timer_sync (&ax25->idletimer); } -dev_put_track (ax25_dev->dev, &ax25_dev->dev_tracker); +dev_put_track (ax25_dev->dev, &ax25->dev_tracker);ax25_dev_put (ax25_dev); }
@@ -1146,7 +1146,7 @@ static int ax25_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)if (ax25_dev) {ax25_fillin_cb (ax25, ax25_dev); -dev_hold_track (ax25_dev->dev, &ax25_dev->dev_tracker,GFP_ATOMIC ); +dev_hold_track (ax25_dev->dev, &ax25->dev_tracker,GFP_ATOMIC ); } done:
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 521/1095 crypto: hisilicon/hpre - dont use GFP_KERNEL to alloc mem during softirq
In reply to Greg Kroah-HartmanFrom: Zhengchao Shao <[email protected]>
[ Upstream commit 98dfa9343f37bdd4112966292751e3a93aaf2e56 ]
The hpre encryption driver may be used to encrypt and decrypt packets during the rx softirq, it is not allowed to use GFP_KERNEL.
--- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/hisilicon/hpre/hpre_crypto.c +1 -1
@@ -252,7 +252,7 @@ static int hpre_prepare_dma_buf(struct hpre_asym_request *hpre_req,if (unlikely (shift <0 ))return -EINVAL ; - ptr =dma_alloc_coherent (dev, ctx->key_sz, tmp,GFP_KERNEL ); + ptr =dma_alloc_coherent (dev, ctx->key_sz, tmp,GFP_ATOMIC );if (unlikely (!ptr))return -ENOMEM ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 522/1095 crypto: inside-secure - Add missing MODULE_DEVICE_TABLE for of
In reply to Greg Kroah-HartmanFrom: Pali Rohár <[email protected]>
[ Upstream commit fa4d57b85786ec0e16565c75a51c208834b0c24d ]
Without MODULE_DEVICE_TABLE, crypto_safexcel.ko module is not automatically loaded on platforms where inside-secure crypto HW is specified in device tree (e.g. Armada 3720). So add missing MODULE_DEVICE_TABLE for of.
--- drivers/crypto/inside-secure/safexcel.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/crypto/inside-secure/safexcel.c +2 -0
@@ -1831,6 +1831,8 @@ static const struct of_device_id safexcel_of_match_table[] = { {}, }; +MODULE_DEVICE_TABLE (of, safexcel_of_match_table); +static struct platform_driver crypto_safexcel = { .probe = safexcel_probe, .remove = safexcel_remove,
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 523/1095 crypto: hisilicon/sec - fix auth key size error
In reply to Greg Kroah-HartmanFrom: Kai Ye <[email protected]>
[ Upstream commit 45f5d0176d8426cc1ab0bab84fbd8ef5c57526c6 ]
The authentication algorithm supports a maximum of 128-byte keys. The allocated key memory is insufficient.
--- drivers/crypto/hisilicon/sec2/sec_crypto.c | 6 +++--- drivers/crypto/hisilicon/sec2/sec_crypto.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-)
drivers/crypto/hisilicon/sec2/sec_crypto.c +3 -3
@@ -620,7 +620,7 @@ static int sec_auth_init(struct sec_ctx *ctx) {struct sec_auth_ctx *a_ctx = &ctx->a_ctx; - a_ctx->a_key =dma_alloc_coherent (ctx->dev,SEC_MAX_KEY_SIZE , + a_ctx->a_key =dma_alloc_coherent (ctx->dev,SEC_MAX_AKEY_SIZE , &a_ctx->a_key_dma,GFP_KERNEL );if (!a_ctx->a_key)return -ENOMEM ;
@@ -632,8 +632,8 @@ static void sec_auth_uninit(struct sec_ctx *ctx) {struct sec_auth_ctx *a_ctx = &ctx->a_ctx; -memzero_explicit (a_ctx->a_key,SEC_MAX_KEY_SIZE ); -dma_free_coherent (ctx->dev,SEC_MAX_KEY_SIZE , +memzero_explicit (a_ctx->a_key,SEC_MAX_AKEY_SIZE ); +dma_free_coherent (ctx->dev,SEC_MAX_AKEY_SIZE , a_ctx->a_key, a_ctx->a_key_dma); }
drivers/crypto/hisilicon/sec2/sec_crypto.h +1 -0
@@ -7,6 +7,7 @@#define SEC_AIV_SIZE 12#define SEC_IV_SIZE 24#define SEC_MAX_KEY_SIZE 64 +#define SEC_MAX_AKEY_SIZE 128#define SEC_COMM_SCENE 0#define SEC_MIN_BLOCK_SZ 1
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 524/1095 inet: add READ_ONCE(sk->sk_bound_dev_if) in INET_MATCH()
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit 4915d50e300e96929d2462041d6f6c6f061167fd ]
INET_MATCH() runs without holding a lock on the socket.
We probably need to annotate most reads.
This patch makes INET_MATCH() an inline function to ease our changes.
v2:
We remove the 32bit version of it, as modern compilers should generate the same code really, no need to try to be smarter.
Also make 'struct net *net' the first argument.
--- include/net/inet_hashtables.h | 35 ++++++++++++++++------------------- include/net/sock.h | 3 --- net/ipv4/inet_hashtables.c | 15 +++++---------- net/ipv4/udp.c | 3 +-- 4 files changed, 22 insertions(+), 34 deletions(-)
include/net/inet_hashtables.h +16 -19
@@ -295,7 +295,6 @@ static inline struct sock *inet_lookup_listener(struct net *net, ((__force __portpair)(((__u32)(__dport) << 16) | (__force __u32)(__be16)(__sport)))#endif -#if (BITS_PER_LONG ==64 )#ifdef __BIG_ENDIAN#define INET_ADDR_COOKIE (__name, __saddr, __daddr) \ const __addrpair __name = (__force __addrpair) ( \
@@ -307,24 +306,22 @@ static inline struct sock *inet_lookup_listener(struct net *net, (((__force __u64)(__be32)(__daddr)) << 32) | \ ((__force __u64)(__be32)(__saddr)))#endif /* __BIG_ENDIAN */ -#define INET_MATCH (__sk, __net, __cookie, __saddr, __daddr, __ports, __dif, __sdif) \ - (((__sk)->sk_portpair == (__ports)) && \ - ((__sk)->sk_addrpair == (__cookie)) && \ - (((__sk)->sk_bound_dev_if == (__dif)) || \ - ((__sk)->sk_bound_dev_if == (__sdif))) && \ - net_eq(sock_net(__sk), (__net))) -#else /* 32-bit arch */ -#define INET_ADDR_COOKIE (__name, __saddr, __daddr) \ - const int __name __deprecated __attribute__((unused)) - -#define INET_MATCH (__sk, __net, __cookie, __saddr, __daddr, __ports, __dif, __sdif) \ - (((__sk)->sk_portpair == (__ports)) && \ - ((__sk)->sk_daddr == (__saddr)) && \ - ((__sk)->sk_rcv_saddr == (__daddr)) && \ - (((__sk)->sk_bound_dev_if == (__dif)) || \ - ((__sk)->sk_bound_dev_if == (__sdif))) && \ - net_eq(sock_net(__sk), (__net))) -#endif /* 64-bit arch */ + +static inline bool INET_MATCH (struct net *net,const struct sock *sk, +const __addrpair cookie,const __portpair ports, +int dif,int sdif) +{ +int bound_dev_if; + +if (!net_eq (sock_net (sk), net) || + sk->sk_portpair != ports || + sk->sk_addrpair != cookie) +return false; + +/* Paired with WRITE_ONCE() from sock_bindtoindex_locked() */ + bound_dev_if =READ_ONCE (sk->sk_bound_dev_if); +return bound_dev_if == dif || bound_dev_if == sdif; +}/* Sockets in TCP_CLOSE state are _always_ taken out of the hash, so we need * not check it for lookups anymore, thanks Alexey. -DaveM
include/net/sock.h +0 -3
@@ -161,9 +161,6 @@ typedef __u64 __bitwise __addrpair;* for struct sock and struct inet_timewait_sock. */ struct sock_common { - /* skc_daddr and skc_rcv_saddr must be grouped on a 8 bytes aligned - * address on 64bit arches : cf INET_MATCH() - */ union { __addrpair skc_addrpair; struct {
net/ipv4/inet_hashtables.c +5 -10
@@ -410,13 +410,11 @@ struct sock *__inet_lookup_established(struct net *net,sk_nulls_for_each_rcu (sk, node, &head->chain) {if (sk->sk_hash != hash)continue ; -if (likely (INET_MATCH (sk, net, acookie, - saddr, daddr, ports, dif, sdif))) { +if (likely (INET_MATCH (net, sk, acookie, ports, dif, sdif))) {if (unlikely (!refcount_inc_not_zero (&sk->sk_refcnt))) goto out; -if (unlikely (!INET_MATCH (sk, net, acookie, - saddr, daddr, ports, - dif, sdif))) { +if (unlikely (!INET_MATCH (net, sk, acookie, + ports, dif, sdif))) {sock_gen_put (sk); goto begin; }
@@ -465,8 +463,7 @@ static int __inet_check_established(struct inet_timewait_death_row *death_row,if (sk2->sk_hash != hash)continue ; -if (likely (INET_MATCH (sk2, net, acookie, - saddr, daddr, ports, dif, sdif))) { +if (likely (INET_MATCH (net, sk2, acookie, ports, dif, sdif))) {if (sk2->sk_state ==TCP_TIME_WAIT ) { tw =inet_twsk (sk2);if (twsk_unique (sk, sk2, twp))
@@ -532,9 +529,7 @@ static bool inet_ehash_lookup_by_sk(struct sock *sk,if (esk->sk_hash != sk->sk_hash)continue ;if (sk->sk_family ==AF_INET ) { -if (unlikely (INET_MATCH (esk, net, acookie, - sk->sk_daddr, - sk->sk_rcv_saddr, +if (unlikely (INET_MATCH (net, esk, acookie, ports, dif, sdif))) {return true; }
net/ipv4/udp.c +1 -2
@@ -2564,8 +2564,7 @@ static struct sock *__udp4_lib_demux_lookup(struct net *net,struct sock *sk;udp_portaddr_for_each_entry_rcu (sk, &hslot2->head) { -if (INET_MATCH (sk, net, acookie, rmt_addr, - loc_addr, ports, dif, sdif)) +if (INET_MATCH (net, sk, acookie, ports, dif, sdif))return sk;/* Only check first socket in chain */ break ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 525/1095 ipv6: add READ_ONCE(sk->sk_bound_dev_if) in INET6_MATCH()
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit 5d368f03280d3678433a7f119efe15dfbbb87bc8 ]
INET6_MATCH() runs without holding a lock on the socket.
We probably need to annotate most reads.
This patch makes INET6_MATCH() an inline function to ease our changes.
v2: inline function only defined if IS_ENABLED(CONFIG_IPV6)
Change the name to inet6_match(), this is no longer a macro.
--- include/net/inet6_hashtables.h | 28 +++++++++++++++++++--------- net/ipv4/inet_hashtables.c | 2 +- net/ipv6/inet6_hashtables.c | 6 +++--- net/ipv6/udp.c | 2 +- 4 files changed, 24 insertions(+), 14 deletions(-)
include/net/inet6_hashtables.h +19 -9
@@ -103,15 +103,25 @@ struct sock *inet6_lookup(struct net *net, struct inet_hashinfo *hashinfo, const int dif);int inet6_hash (struct sock *sk); -#endif /* IS_ENABLED(CONFIG_IPV6) */ -#define INET6_MATCH (__sk, __net, __saddr, __daddr, __ports, __dif, __sdif) \ - (((__sk)->sk_portpair == (__ports)) && \ - ((__sk)->sk_family == AF_INET6) && \ - ipv6_addr_equal(&(__sk)->sk_v6_daddr, (__saddr)) && \ - ipv6_addr_equal(&(__sk)->sk_v6_rcv_saddr, (__daddr)) && \ - (((__sk)->sk_bound_dev_if == (__dif)) || \ - ((__sk)->sk_bound_dev_if == (__sdif))) && \ - net_eq(sock_net(__sk), (__net))) +static inline bool inet6_match (struct net *net,const struct sock *sk, +const struct in6_addr *saddr, +const struct in6_addr *daddr, +const __portpair ports, +const int dif,const int sdif) +{ +int bound_dev_if; + +if (!net_eq (sock_net (sk), net) || + sk->sk_family !=AF_INET6 || + sk->sk_portpair != ports || + !ipv6_addr_equal (&sk->sk_v6_daddr, saddr) || + !ipv6_addr_equal (&sk->sk_v6_rcv_saddr, daddr)) +return false; + + bound_dev_if =READ_ONCE (sk->sk_bound_dev_if); +return bound_dev_if == dif || bound_dev_if == sdif; +} +#endif /* IS_ENABLED(CONFIG_IPV6) */ #endif /* _INET6_HASHTABLES_H */
net/ipv4/inet_hashtables.c +1 -1
@@ -536,7 +536,7 @@ static bool inet_ehash_lookup_by_sk(struct sock *sk, }#if IS_ENABLED (CONFIG_IPV6 ) else if (sk->sk_family == AF_INET6) { -if (unlikely (INET6_MATCH (esk, net, +if (unlikely (inet6_match (net, esk, &sk->sk_v6_daddr, &sk->sk_v6_rcv_saddr, ports, dif, sdif))) {
net/ipv6/inet6_hashtables.c +3 -3
@@ -71,12 +71,12 @@ struct sock *__inet6_lookup_established(struct net *net,sk_nulls_for_each_rcu (sk, node, &head->chain) {if (sk->sk_hash != hash)continue ; -if (!INET6_MATCH (sk, net, saddr, daddr, ports, dif, sdif)) +if (!inet6_match (net, sk, saddr, daddr, ports, dif, sdif))continue ;if (unlikely (!refcount_inc_not_zero (&sk->sk_refcnt))) goto out; -if (unlikely (!INET6_MATCH (sk, net, saddr, daddr, ports, dif, sdif))) { +if (unlikely (!inet6_match (net, sk, saddr, daddr, ports, dif, sdif))) {sock_gen_put (sk); goto begin; }
@@ -269,7 +269,7 @@ static int __inet6_check_established(struct inet_timewait_death_row *death_row,if (sk2->sk_hash != hash)continue ; -if (likely (INET6_MATCH (sk2, net, saddr, daddr, ports, +if (likely (inet6_match (net, sk2, saddr, daddr, ports, dif, sdif))) {if (sk2->sk_state ==TCP_TIME_WAIT ) { tw =inet_twsk (sk2);
net/ipv6/udp.c +1 -1
@@ -1044,7 +1044,7 @@ static struct sock *__udp6_lib_demux_lookup(struct net *net,udp_portaddr_for_each_entry_rcu (sk, &hslot2->head) {if (sk->sk_state ==TCP_ESTABLISHED && -INET6_MATCH (sk, net, rmt_addr, loc_addr, ports, dif, sdif)) +inet6_match (net, sk, rmt_addr, loc_addr, ports, dif, sdif))return sk;/* Only check first socket in chain */ break ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 526/1095 net: allow unbound socket for packets in VRF when tcp_l3mdev_accept set
In reply to Greg Kroah-HartmanFrom: Mike Manning <[email protected]>
[ Upstream commit 944fd1aeacb627fa617f85f8e5a34f7ae8ea4d8e ]
The commit 3c82a21f4320 ("net: allow binding socket in a VRF when there's an unbound socket") changed the inet socket lookup to avoid packets in a VRF from matching an unbound socket. This is to ensure the necessary isolation between the default and other VRFs for routing and forwarding. VRF-unaware processes running in the default VRF cannot access another VRF and have to be run with 'ip vrf exec <vrf>'. This is to be expected with tcp_l3mdev_accept disabled, but could be reallowed when this sysctl option is enabled. So instead of directly checking dif and sdif in inet[6]_match, here call inet_sk_bound_dev_eq(). This allows a match on unbound socket for non-zero sdif i.e. for packets in a VRF, if tcp_l3mdev_accept is enabled.
--- include/net/inet6_hashtables.h | 7 +++---- include/net/inet_hashtables.h | 19 +++---------------- include/net/inet_sock.h | 11 +++++++++++ 3 files changed, 17 insertions(+), 20 deletions(-)
include/net/inet6_hashtables.h +3 -4
@@ -110,8 +110,6 @@ static inline bool inet6_match(struct net *net, const struct sock *sk,const __portpair ports, const int dif, const int sdif) { - int bound_dev_if; - if (!net_eq(sock_net(sk), net) || sk->sk_family != AF_INET6 || sk->sk_portpair != ports ||
@@ -119,8 +117,9 @@ static inline bool inet6_match(struct net *net, const struct sock *sk, !ipv6_addr_equal(&sk->sk_v6_rcv_saddr, daddr))return false; - bound_dev_if =READ_ONCE (sk->sk_bound_dev_if); - return bound_dev_if == dif || bound_dev_if == sdif; +/* READ_ONCE() paired with WRITE_ONCE() in sock_bindtoindex_locked() */ +return inet_sk_bound_dev_eq (net,READ_ONCE (sk->sk_bound_dev_if), dif, + sdif); }#endif /* IS_ENABLED(CONFIG_IPV6) */
include/net/inet_hashtables.h +3 -16
@@ -203,17 +203,6 @@ static inline void inet_ehash_locks_free(struct inet_hashinfo *hashinfo) hashinfo->ehash_locks =NULL ; } -static inline bool inet_sk_bound_dev_eq (struct net *net,int bound_dev_if, -int dif,int sdif) -{ -#if IS_ENABLED (CONFIG_NET_L3_MASTER_DEV ) -return inet_bound_dev_eq (!!READ_ONCE (net->ipv4.sysctl_tcp_l3mdev_accept), - bound_dev_if, dif, sdif); -#else -return inet_bound_dev_eq (true, bound_dev_if, dif, sdif); -#endif -} -struct inet_bind_bucket * inet_bind_bucket_create(struct kmem_cache *cachep, struct net *net, struct inet_bind_hashbucket *head,
@@ -311,16 +300,14 @@ static inline bool INET_MATCH(struct net *net, const struct sock *sk, const __addrpair cookie, const __portpair ports, int dif, int sdif) { - int bound_dev_if; - if (!net_eq(sock_net(sk), net) || sk->sk_portpair != ports || sk->sk_addrpair != cookie) return false; -/* Paired with WRITE_ONCE() from sock_bindtoindex_locked() */ - bound_dev_if =READ_ONCE (sk->sk_bound_dev_if); -return bound_dev_if == dif || bound_dev_if == sdif; +/* READ_ONCE() paired with WRITE_ONCE() in sock_bindtoindex_locked() */ +return inet_sk_bound_dev_eq (net,READ_ONCE (sk->sk_bound_dev_if), dif, + sdif); }/* Sockets in TCP_CLOSE state are _always_ taken out of the hash, so we need
include/net/inet_sock.h +11 -0
@@ -149,6 +149,17 @@ static inline bool inet_bound_dev_eq(bool l3mdev_accept, int bound_dev_if,return bound_dev_if == dif || bound_dev_if == sdif; } +static inline bool inet_sk_bound_dev_eq (struct net *net,int bound_dev_if, +int dif,int sdif) +{ +#if IS_ENABLED (CONFIG_NET_L3_MASTER_DEV ) +return inet_bound_dev_eq (!!READ_ONCE (net->ipv4.sysctl_tcp_l3mdev_accept), + bound_dev_if, dif, sdif); +#else +return inet_bound_dev_eq (true, bound_dev_if, dif, sdif); +#endif +} +struct inet_cork {unsigned int flags;__be32 addr;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 527/1095 netdevsim: fib: Fix reference count leak on route deletion failure
In reply to Greg Kroah-HartmanFrom: Ido Schimmel <[email protected]>
[ Upstream commit 180a6a3ee60a7cb69ed1232388460644f6a21f00 ]
As part of FIB offload simulation, netdevsim stores IPv4 and IPv6 routes and holds a reference on FIB info structures that in turn hold a reference on the associated nexthop device(s).
In the unlikely case where we are unable to allocate memory to process a route deletion request, netdevsim will not release the reference from the associated FIB info structure, thereby preventing the associated nexthop device(s) from ever being removed [1].
Fix this by scheduling a work item that will flush netdevsim's FIB table upon route deletion failure. This will cause netdevsim to release its reference from all the FIB info structures in its table.
Reported by Lucas Leong of Trend Micro Zero Day Initiative.
--- drivers/net/netdevsim/fib.c | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-)
drivers/net/netdevsim/fib.c +26 -1
@@ -53,6 +53,7 @@ struct nsim_fib_data {struct rhashtable nexthop_ht;struct devlink *devlink;struct work_struct fib_event_work; +struct work_struct fib_flush_work;struct list_head fib_event_queue;spinlock_t fib_event_queue_lock;/* Protects fib event queue list */ struct mutex nh_lock;/* Protects NH HT */
@@ -977,7 +978,7 @@ static int nsim_fib_event_schedule_work(struct nsim_fib_data *data, fib_event =kzalloc (sizeof (*fib_event),GFP_ATOMIC );if (!fib_event) -return NOTIFY_BAD ; + goto err_fib_event_alloc; fib_event->data = data; fib_event->event = event;
@@ -1005,6 +1006,9 @@ static int nsim_fib_event_schedule_work(struct nsim_fib_data *data, err_fib_prepare_event:kfree (fib_event); +err_fib_event_alloc: +if (event ==FIB_EVENT_ENTRY_DEL ) +schedule_work (&data->fib_flush_work);return NOTIFY_BAD ; }
@@ -1482,6 +1486,24 @@ static void nsim_fib_event_work(struct work_struct *work)mutex_unlock (&data->fib_lock); } +static void nsim_fib_flush_work (struct work_struct *work) +{ + struct nsim_fib_data *data = container_of(work, struct nsim_fib_data, + fib_flush_work); +struct nsim_fib_rt *fib_rt, *fib_rt_tmp; + +/* Process pending work. */ +flush_work (&data->fib_event_work); + +mutex_lock (&data->fib_lock); +list_for_each_entry_safe (fib_rt, fib_rt_tmp, &data->fib_rt_list, list) { +rhashtable_remove_fast (&data->fib_rt_ht, &fib_rt->ht_node, + nsim_fib_rt_ht_params); +nsim_fib_rt_free (fib_rt, data); + } +mutex_unlock (&data->fib_lock); +} +static int nsim_fib_debugfs_init (struct nsim_fib_data *data,struct nsim_dev *nsim_dev) {
@@ -1540,6 +1562,7 @@ struct nsim_fib_data *nsim_fib_create(struct devlink *devlink, goto err_rhashtable_nexthop_destroy;INIT_WORK (&data->fib_event_work, nsim_fib_event_work); +INIT_WORK (&data->fib_flush_work, nsim_fib_flush_work);INIT_LIST_HEAD (&data->fib_event_queue);spin_lock_init (&data->fib_event_queue_lock);
@@ -1586,6 +1609,7 @@ struct nsim_fib_data *nsim_fib_create(struct devlink *devlink, err_nexthop_nb_unregister:unregister_nexthop_notifier (devlink_net (devlink), &data->nexthop_nb); err_rhashtable_fib_destroy: +cancel_work_sync (&data->fib_flush_work);flush_work (&data->fib_event_work);rhashtable_free_and_destroy (&data->fib_rt_ht, nsim_fib_rt_free, data);
@@ -1615,6 +1639,7 @@ void nsim_fib_destroy(struct devlink *devlink, struct nsim_fib_data *data) NSIM_RESOURCE_IPV4_FIB);unregister_fib_notifier (devlink_net (devlink), &data->fib_nb);unregister_nexthop_notifier (devlink_net (devlink), &data->nexthop_nb); +cancel_work_sync (&data->fib_flush_work);flush_work (&data->fib_event_work);rhashtable_free_and_destroy (&data->fib_rt_ht, nsim_fib_rt_free, data);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 528/1095 wifi: rtw88: check the return value of alloc_workqueue()
In reply to Greg Kroah-HartmanFrom: William Dean <[email protected]>
[ Upstream commit 42bbf810e155efc6129a3a648ae5300f00b79d7b ]
The function alloc_workqueue() in rtw_core_init() can fail, but there is no check of its return value. To fix this bug, its return value should be checked with new error handling code.
--- drivers/net/wireless/realtek/rtw88/main.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/wireless/realtek/rtw88/main.c +4 -0
@@ -1974,6 +1974,10 @@ int rtw_core_init(struct rtw_dev *rtwdev)timer_setup (&rtwdev->tx_report.purge_timer, rtw_tx_report_purge_timer,0 ); rtwdev->tx_wq =alloc_workqueue ("rtw_tx_wq" ,WQ_UNBOUND |WQ_HIGHPRI ,0 ); +if (!rtwdev->tx_wq) { +rtw_warn (rtwdev,"alloc_workqueue rtw_tx_wq failed\n" ); +return -ENOMEM ; + }INIT_DELAYED_WORK (&rtwdev->watch_dog_work, rtw_watch_dog_work);INIT_DELAYED_WORK (&coex->bt_relink_work, rtw_coex_bt_relink_work);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 529/1095 iavf: Fix max_rate limiting
In reply to Greg Kroah-HartmanFrom: Przemyslaw Patynowski <[email protected]>
[ Upstream commit ec60d54cb9a3d43a02c5612a03093c18233e6601 ]
Fix max_rate option in TC, check for proper quanta boundaries. Check for minimum value provided and if it fits expected 50Mbps quanta.
Without this patch, iavf could send settings for max_rate limiting that would be accepted from by PF even the max_rate option is less than expected 50Mbps quanta. It results in no rate limiting on traffic as rate limiting will be floored to 0.
Example:
tc qdisc add dev $vf root mqprio num_tc 3 map 0 2 1 queues \
2@0 2@2 2@4 hw 1 mode channel shaper bw_rlimit \max_rate 50Mbps 500Mbps 500Mbps
Should limit TC0 to circa 50 Mbps
tc qdisc add dev $vf root mqprio num_tc 3 map 0 2 1 queues \
2@0 2@2 2@4 hw 1 mode channel shaper bw_rlimit \max_rate 0Mbps 100Kbit 500Mbps
Should return error
--- drivers/net/ethernet/intel/iavf/iavf.h | 1 + drivers/net/ethernet/intel/iavf/iavf_main.c | 25 +++++++++++++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/iavf/iavf.h +1 -0
@@ -92,6 +92,7 @@ struct iavf_vsi {#define IAVF_HKEY_ARRAY_SIZE ((IAVF_VFQF_HKEY_MAX_INDEX + 1) * 4)#define IAVF_HLUT_ARRAY_SIZE ((IAVF_VFQF_HLUT_MAX_INDEX + 1) * 4)#define IAVF_MBPS_DIVISOR 125000/* divisor to convert to Mbps */ +#define IAVF_MBPS_QUANTA 50#define IAVF_VIRTCHNL_VF_RESOURCE_SIZE (sizeof(struct virtchnl_vf_resource) + \ (IAVF_MAX_VF_VSI * \
drivers/net/ethernet/intel/iavf/iavf_main.c +23 -2
@@ -3322,6 +3322,7 @@ static int iavf_validate_ch_config(struct iavf_adapter *adapter, struct tc_mqprio_qopt_offload *mqprio_qopt) {u64 total_max_rate =0 ; +u32 tx_rate_rem =0 ;int i, num_qps =0 ;u64 tx_rate =0 ;int ret =0 ;
@@ -3336,12 +3337,32 @@ static int iavf_validate_ch_config(struct iavf_adapter *adapter,return -EINVAL ;if (mqprio_qopt->min_rate[i]) {dev_err (&adapter->pdev->dev, -"Invalid min tx rate (greater than 0) specified\n" ); +"Invalid min tx rate (greater than 0) specified for TC%d\n" , + i);return -EINVAL ; } -/*convert to Mbps */ + +/* convert to Mbps */ tx_rate =div_u64 (mqprio_qopt->max_rate[i],IAVF_MBPS_DIVISOR ); + +if (mqprio_qopt->max_rate[i] && + tx_rate <IAVF_MBPS_QUANTA ) { +dev_err (&adapter->pdev->dev, +"Invalid max tx rate for TC%d, minimum %dMbps\n" , + i,IAVF_MBPS_QUANTA ); +return -EINVAL ; + } + + (void )div_u64_rem (tx_rate,IAVF_MBPS_QUANTA , &tx_rate_rem); + +if (tx_rate_rem !=0 ) { +dev_err (&adapter->pdev->dev, +"Invalid max tx rate for TC%d, not divisible by %d\n" , + i,IAVF_MBPS_QUANTA ); +return -EINVAL ; + } + total_max_rate += tx_rate; num_qps += mqprio_qopt->qopt.count[i]; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 530/1095 iavf: Fix tc qdisc show listing too many queues
In reply to Greg Kroah-HartmanFrom: Przemyslaw Patynowski <[email protected]>
[ Upstream commit 93cb804edab1b9a5bb7bb7b6824012dbb20abf22 ]
Fix tc qdisc show dev <ethX> root displaying too many fq_codel qdiscs.tc_modify_qdisc, which is caller of ndo_setup_tc, expects driver to callnetif_set_real_num_tx_queues, which prepares qdiscs.
Without this patch, fq_codel qdiscs would not be adjusted to number of
queues on VF.
e.g.:
tc qdisc show dev <ethX>
qdisc mq 0: root
qdisc fq_codel 0: parent :4 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64 qdisc fq_codel 0: parent :3 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64 qdisc fq_codel 0: parent :2 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64 qdisc fq_codel 0: parent :1 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64 tc qdisc add dev <ethX> root mqprio num_tc 2 map 1 0 0 0 0 0 0 0 queues 1@0 1@1 hw 1 mode channel shaper bw_rlimit max_rate 5000Mbit 150Mbit tc qdisc show dev <ethX>
qdisc mqprio 8003: root tc 2 map 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
queues:(0:0) (1:1)
mode:channel
shaper:bw_rlimit max_rate:5Gbit 150Mbit
qdisc fq_codel 0: parent 8003:4 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64 qdisc fq_codel 0: parent 8003:3 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64 qdisc fq_codel 0: parent 8003:2 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64 qdisc fq_codel 0: parent 8003:1 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64
While after fix:
tc qdisc add dev <ethX> root mqprio num_tc 2 map 1 0 0 0 0 0 0 0 queues 1@0 1@1 hw 1 mode channel shaper bw_rlimit max_rate 5000Mbit 150Mbit tc qdisc show dev <ethX> #should show 2, shows 4
qdisc mqprio 8004: root tc 2 map 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
queues:(0:0) (1:1)
mode:channel
shaper:bw_rlimit max_rate:5Gbit 150Mbit
qdisc fq_codel 0: parent 8004:2 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64 qdisc fq_codel 0: parent 8004:1 limit 10240p flows 1024 quantum 1514 target 5ms interval 100ms memory_limit 32Mb ecn drop_batch 64
--- drivers/net/ethernet/intel/iavf/iavf.h | 5 +++++ drivers/net/ethernet/intel/iavf/iavf_main.c | 21 +++++++++++++++++++++ 2 files changed, 26 insertions(+)
drivers/net/ethernet/intel/iavf/iavf.h +5 -0
@@ -431,6 +431,11 @@ struct iavf_adapter {/* lock to protect access to the cloud filter list */ spinlock_t cloud_filter_list_lock;u16 num_cloud_filters; +/* snapshot of "num_active_queues" before setup_tc for qdisc add +* is invoked. This information is useful during qdisc del flow, +* to restore correct number of queues +*/ +int orig_num_active_queues;#define IAVF_MAX_FDIR_FILTERS 128/* max allowed Flow Director filters */ u16 fdir_active_fltr;
drivers/net/ethernet/intel/iavf/iavf_main.c +21 -0
@@ -3429,6 +3429,7 @@ static int __iavf_setup_tc(struct net_device *netdev, void *type_data)netif_tx_disable (netdev);iavf_del_all_cloud_filters (adapter); adapter->aq_required =IAVF_FLAG_AQ_DISABLE_CHANNELS ; + total_qps = adapter->orig_num_active_queues; goto exit; }else {return -EINVAL ;
@@ -3472,7 +3473,21 @@ static int __iavf_setup_tc(struct net_device *netdev, void *type_data) adapter->ch_config.ch_info[i].offset =0 ; } } + +/* Take snapshot of original config such as "num_active_queues" +* It is used later when delete ADQ flow is exercised, so that +* once delete ADQ flow completes, VF shall go back to its +* original queue configuration +*/ + + adapter->orig_num_active_queues = adapter->num_active_queues; + +/* Store queue info based on TC so that VF gets configured +* with correct number of queues when VF completes ADQ config +* flow +*/ adapter->ch_config.total_qps = total_qps; +netif_tx_stop_all_queues (netdev);netif_tx_disable (netdev); adapter->aq_required |=IAVF_FLAG_AQ_ENABLE_CHANNELS ;
@@ -3489,6 +3504,12 @@ static int __iavf_setup_tc(struct net_device *netdev, void *type_data) } } exit: +if (test_bit (__IAVF_IN_REMOVE_TASK, &adapter->crit_section)) +return 0 ; + +netif_set_real_num_rx_queues (netdev, total_qps); +netif_set_real_num_tx_queues (netdev, total_qps); +return ret; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 531/1095 netdevsim: Avoid allocation warnings triggered from user space
In reply to Greg Kroah-HartmanFrom: Jakub Kicinski <[email protected]>
[ Upstream commit d0b80a9edb1a029ff913e81b47540e57ad034329 ]
We need to suppress warnings from sily map sizes. Also switch from GFP_USER to GFP_KERNEL_ACCOUNT, I'm pretty sure I misunderstood the flags when writing this code.
--- drivers/net/netdevsim/bpf.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/net/netdevsim/bpf.c +5 -3
@@ -351,10 +351,12 @@ nsim_map_alloc_elem(struct bpf_offloaded_map *offmap, unsigned int idx) {struct nsim_bpf_bound_map *nmap = offmap->dev_priv; - nmap->entry[idx].key =kmalloc (offmap->map.key_size,GFP_USER ); + nmap->entry[idx].key =kmalloc (offmap->map.key_size, +GFP_KERNEL_ACCOUNT | __GFP_NOWARN);if (!nmap->entry[idx].key)return -ENOMEM ; - nmap->entry[idx].value =kmalloc (offmap->map.value_size,GFP_USER ); + nmap->entry[idx].value =kmalloc (offmap->map.value_size, +GFP_KERNEL_ACCOUNT | __GFP_NOWARN);if (!nmap->entry[idx].value) {kfree (nmap->entry[idx].key); nmap->entry[idx].key =NULL ;
@@ -496,7 +498,7 @@ nsim_bpf_map_alloc(struct netdevsim *ns, struct bpf_offloaded_map *offmap)if (offmap->map.map_flags)return -EINVAL ; - nmap =kzalloc (sizeof (*nmap),GFP_USER ); + nmap =kzalloc (sizeof (*nmap),GFP_KERNEL_ACCOUNT );if (!nmap)return -ENOMEM ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 532/1095 net: rose: fix netdev reference changes
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit 931027820e4dafabc78aff82af59f8c1c4bd3128 ]
Bernard reported that trying to unload rose module would lead to infamous messages:
unregistered_netdevice: waiting for rose0 to become free. Usage count = xx
This patch solves the issue, by making sure each socket referring to a netdevice holds a reference count on it, and properly releases it in rose_release().
rose_dev_first() is also fixed to take a device reference before leaving the rcu_read_locked section.
Following patch will add ref_tracker annotations to ease future bug hunting.
--- net/rose/af_rose.c | 11 +++++++++-- net/rose/rose_route.c | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-)
net/rose/af_rose.c +9 -2
@@ -192,6 +192,7 @@ static void rose_kill_by_device(struct net_device *dev)rose_disconnect (s,ENETUNREACH ,ROSE_OUT_OF_ORDER ,0 );if (rose->neighbour) rose->neighbour->use--; +dev_put (rose->device); rose->device =NULL ; } }
@@ -592,6 +593,8 @@ static struct sock *rose_make_new(struct sock *osk) rose->idle = orose->idle; rose->defer = orose->defer; rose->device = orose->device; +if (rose->device) +dev_hold (rose->device); rose->qbitincl = orose->qbitincl;return sk;
@@ -645,6 +648,7 @@ static int rose_release(struct socket *sock)break ; } +dev_put (rose->device); sock->sk =NULL ;release_sock (sk);sock_put (sk);
@@ -721,7 +725,6 @@ static int rose_connect(struct socket *sock, struct sockaddr *uaddr, int addr_lestruct rose_sock *rose =rose_sk (sk);struct sockaddr_rose *addr = (struct sockaddr_rose *)uaddr;unsigned char cause, diagnostic; -struct net_device *dev;ax25_uid_assoc *user;int n, err =0 ;
@@ -778,9 +781,12 @@ static int rose_connect(struct socket *sock, struct sockaddr *uaddr, int addr_le }if (sock_flag (sk,SOCK_ZAPPED )) {/* Must bind first - autobinding in this may or may not work */ +struct net_device *dev; +sock_reset_flag (sk,SOCK_ZAPPED ); -if ((dev =rose_dev_first ()) ==NULL ) { + dev =rose_dev_first (); +if (!dev) { err = -ENETUNREACH ; goto out_release; }
@@ -788,6 +794,7 @@ static int rose_connect(struct socket *sock, struct sockaddr *uaddr, int addr_le user =ax25_findbyuid (current_euid ());if (!user) { err = -EINVAL ; +dev_put (dev); goto out_release; }
net/rose/rose_route.c +2 -0
@@ -615,6 +615,8 @@ struct net_device *rose_dev_first(void)if (first ==NULL ||strncmp (dev->name, first->name,3 ) <0 ) first = dev; } +if (first) +dev_hold (first);rcu_read_unlock ();return first;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 533/1095 net: ice: fix error NETIF_F_HW_VLAN_CTAG_FILTER check in ice_vsi_sync_fltr()
In reply to Greg Kroah-HartmanFrom: Jian Shen <[email protected]>
[ Upstream commit 7dc839fe47611e6995f370cae37b9797cf7d2672 ]
vsi->current_netdev_flags is used store the current net device flags, not the active netdevice features. So it should use vsi->netdev->featurs, rather than vsi->current_netdev_flags to check NETIF_F_HW_VLAN_CTAG_FILTER.
--- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/ice_main.c +1 -1
@@ -419,7 +419,7 @@ static int ice_vsi_sync_fltr(struct ice_vsi *vsi)IFF_PROMISC ; goto out_promisc; } -if (vsi->current_netdev_flags & +if (vsi->netdev->features &NETIF_F_HW_VLAN_CTAG_FILTER ) vlan_ops->ena_rx_filtering (vsi); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 534/1095 net: ionic: fix error check for vlan flags in ionic_set_nic_features()
In reply to Greg Kroah-HartmanFrom: Jian Shen <[email protected]>
[ Upstream commit a86e86db5e6d72c82724a63ca1c5293409a21518 ]
The prototype of input features of ionic_set_nic_features() is netdev_features_t, but the vlan_flags is using the private definition of ionic drivers. It should use the variable ctx.cmd.lif_setattr.features, rather than features to check the vlan flags. So fixes it.
--- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/pensando/ionic/ionic_lif.c +1 -1
@@ -1437,7 +1437,7 @@ static int ionic_set_nic_features(struct ionic_lif *lif,if ((old_hw_features ^ lif->hw_features) &IONIC_ETH_HW_RX_HASH )ionic_lif_rss_config (lif, lif->rss_types,NULL ,NULL ); -if ((vlan_flags & features) && +if ((vlan_flags &le64_to_cpu (ctx.cmd.lif_setattr.features)) && !(vlan_flags &le64_to_cpu (ctx.comp.lif_setattr.features)))dev_info_once (lif->ionic->dev,"NIC is not supporting vlan offload, likely in SmartNIC mode\n" );
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 535/1095 dccp: put dccp_qpolicy_full() and dccp_qpolicy_push() in the same lock
In reply to Greg Kroah-HartmanFrom: Hangyu Hua <[email protected]>
[ Upstream commit a41b17ff9dacd22f5f118ee53d82da0f3e52d5e3 ]
In the case of sk->dccps_qpolicy == DCCPQ_POLICY_PRIO, dccp_qpolicy_full will drop a skb when qpolicy is full. And the lock in dccp_sendmsg is released before sock_alloc_send_skb and then relocked after sock_alloc_send_skb. The following conditions may lead dccp_qpolicy_push to add skb to an already full sk_write_queue:
thread1--->lock
thread1--->dccp_qpolicy_full: queue is full. drop a skb thread1--->unlock
thread2--->lock
thread2--->dccp_qpolicy_full: queue is not full. no need to drop. thread2--->unlock
thread1--->lock
thread1--->dccp_qpolicy_push: add a skb. queue is full. thread1--->unlock
thread2--->lock
thread2--->dccp_qpolicy_push: add a skb! thread2--->unlock
Fix this by moving dccp_qpolicy_full.
--- net/dccp/proto.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
net/dccp/proto.c +5 -5
@@ -736,11 +736,6 @@ int dccp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)lock_sock (sk); -if (dccp_qpolicy_full (sk)) { - rc = -EAGAIN ; - goto out_release; - } - timeo =sock_sndtimeo (sk, noblock);/*
@@ -759,6 +754,11 @@ int dccp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)if (skb ==NULL ) goto out_release; +if (dccp_qpolicy_full (sk)) { + rc = -EAGAIN ; + goto out_discard; + } +if (sk->sk_state ==DCCP_CLOSED ) { rc = -ENOTCONN ; goto out_discard;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 536/1095 net: usb: make USB_RTL8153_ECM non user configurable
In reply to Greg Kroah-HartmanFrom: Maciej Żenczykowski <[email protected]>
[ Upstream commit f56530dcdb0684406661ac9f1accf48319d07600 ]
This refixes:
commit 7da17624e7948d5d9660b910f8079d26d26ce453
nt: usb: USB_RTL8153_ECM should not default to y
In general, device drivers should not be enabled by default.
which basically broke the commit it claimed to fix, ie:
commit 657bc1d10bfc23ac06d5d687ce45826c760744f9
r8153_ecm: avoid to be prior to r8152 driver
Avoid r8153_ecm is compiled as built-in, if r8152 driver is compiled as modules. Otherwise, the r8153_ecm would be used, even though the device is supported by r8152 driver.
this commit amounted to:
drivers/net/usb/Kconfig:
+config USB_RTL8153_ECM
+ tristate "RTL8153 ECM support" + depends on USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n) + default y + help + This option supports ECM mode for RTL8153 ethernet adapter, when + CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not + supported by r8152 driver.
drivers/net/usb/Makefile:
-obj-$(CONFIG_USB_NET_CDCETHER) += cdc_ether.o r8153_ecm.o +obj-$(CONFIG_USB_NET_CDCETHER) += cdc_ether.o +obj-$(CONFIG_USB_RTL8153_ECM) += r8153_ecm.o
And as can be seen it pulls a piece of the cdc_ether driver out into a separate config option to be able to make this piece modular in case cdc_ether is builtin, while r8152 is modular.
While in general, device drivers should indeed not be enabled by default:
this isn't a device driver per say, but rather this is support code for the CDCETHER (ECM) driver, and should thus be enabled if it is enabled.
See also email thread at:
https://www.spinics.net/lists/netdev/msg767649.html
In:
https://www.spinics.net/lists/netdev/msg768284.html
Jakub wrote:
And when we say "removed" we can just hide it from what's prompted to the user (whatever such internal options are called)? I believe this way we don't bring back Marek's complaint.
Side note: these incorrect defaults will result in Android 13 on 5.15 GKI kernels lacking USB_RTL8153_ECM support while having USB_NET_CDCETHER (luckily we also have USB_RTL8150 and USB_RTL8152, so it's probably only an issue for very new RTL815x hardware with no native 5.15 driver).
--- drivers/net/usb/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/usb/Kconfig +2 -1
@@ -637,8 +637,9 @@ config USB_NET_AQC111 * Aquantia AQtion USB to 5GbE config USB_RTL8153_ECM - tristate "RTL8153 ECM support" + tristate depends on USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n) + default y help This option supports ECM mode for RTL8153 ethernet adapter, when CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 537/1095 net/mlx5e: xsk: Discard unaligned XSK frames on striding RQ
In reply to Greg Kroah-HartmanFrom: Maxim Mikityanskiy <[email protected]>
[ Upstream commit 8eaa1d110800fac050bab44001732747a1c39894 ]
Striding RQ uses MTT page mapping, where each page corresponds to an XSK frame. MTT pages have alignment requirements, and XSK frames don't have any alignment guarantees in the unaligned mode. Frames with improper alignment must be discarded, otherwise the packet data will be written at a wrong address.
--- .../net/ethernet/mellanox/mlx5/core/en/xsk/rx.h | 14 ++++++++++++++ include/net/xdp_sock_drv.h | 11 +++++++++++ 2 files changed, 25 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.h +14 -0
@@ -7,6 +7,8 @@#include "en.h" #include <net/xdp_sock_drv.h> +#define MLX5E_MTT_PTAG_MASK 0xfffffffffffffff8ULL +/* RX data path */ struct sk_buff *mlx5e_xsk_skb_from_cqe_mpwrq_linear(struct mlx5e_rq *rq,
@@ -22,6 +24,7 @@ struct sk_buff *mlx5e_xsk_skb_from_cqe_linear(struct mlx5e_rq *rq,static inline int mlx5e_xsk_page_alloc_pool (struct mlx5e_rq *rq,struct mlx5e_dma_info *dma_info) { +retry: dma_info->xsk =xsk_buff_alloc (rq->xsk_pool);if (!dma_info->xsk)return -ENOMEM ;
@@ -33,6 +36,17 @@ static inline int mlx5e_xsk_page_alloc_pool(struct mlx5e_rq *rq,*/ dma_info->addr =xsk_buff_xdp_get_frame_dma (dma_info->xsk); +/* MTT page mapping has alignment requirements. If they are not +* satisfied, leak the descriptor so that it won't come again, and try +* to allocate a new one. +*/ +if (rq->wq_type ==MLX5_WQ_TYPE_LINKED_LIST_STRIDING_RQ ) { +if (unlikely (dma_info->addr & ~MLX5E_MTT_PTAG_MASK )) { +xsk_buff_discard (dma_info->xsk); + goto retry; + } + } +return 0 ; }
include/net/xdp_sock_drv.h +11 -0
@@ -95,6 +95,13 @@ static inline void xsk_buff_free(struct xdp_buff *xdp)xp_free (xskb); } +static inline void xsk_buff_discard (struct xdp_buff *xdp) +{ + struct xdp_buff_xsk *xskb = container_of(xdp, struct xdp_buff_xsk, xdp); + +xp_release (xskb); +} +static inline void xsk_buff_set_size (struct xdp_buff *xdp,u32 size) { xdp->data = xdp->data_hard_start +XDP_PACKET_HEADROOM ;
@@ -238,6 +245,10 @@ static inline void xsk_buff_free(struct xdp_buff *xdp) { } +static inline void xsk_buff_discard (struct xdp_buff *xdp) +{ +} +static inline void xsk_buff_set_size (struct xdp_buff *xdp,u32 size) { }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 538/1095 wireguard: ratelimiter: use hrtimer in selftest
In reply to Greg Kroah-HartmanFrom: Jason A. Donenfeld <[email protected]>
[ Upstream commit 151c8e499f4705010780189377f85b57400ccbf5 ]
Using msleep() is problematic because it's compared against ratelimiter.c's ktime_get_coarse_boottime_ns(), which means on systems with slow jiffies (such as UML's forced HZ=100), the result is inaccurate. So switch to using schedule_hrtimeout().
However, hrtimer gives us access only to the traditional posix timers, and none of the _COARSE variants. So now, rather than being too imprecise like jiffies, it's too precise.
One solution would be to give it a large "range" value, but this will still fire early on a loaded system. A better solution is to align the timeout to the actual coarse timer, and then round up to the nearest tick, plus change.
So add the timeout to the current coarse time, and then schedule_hrtimer() until the absolute computed time.
This should hopefully reduce flakes in CI as well. Note that we keep the retry loop in case the entire function is running behind, because the test could still be scheduled out, by either the kernel or by the hypervisor's kernel, in which case restarting the test and hoping to not be scheduled out still helps.
--- drivers/net/wireguard/selftest/ratelimiter.c | 25 +++++++++++--------- kernel/time/hrtimer.c | 1 + 2 files changed, 15 insertions(+), 11 deletions(-)
drivers/net/wireguard/selftest/ratelimiter.c +14 -11
@@ -6,28 +6,29 @@#ifdef DEBUG #include <linux/jiffies.h> +#include <linux/hrtimer.h> static const struct {bool result; -unsigned int msec_to_sleep_before; +u64 nsec_to_sleep_before; } expected_results[]__initconst = { [0 ...PACKETS_BURSTABLE -1 ] = { true,0 }, [PACKETS_BURSTABLE ] = { false,0 }, - [PACKETS_BURSTABLE +1 ] = { true,MSEC_PER_SEC /PACKETS_PER_SECOND }, + [PACKETS_BURSTABLE +1 ] = { true,NSEC_PER_SEC /PACKETS_PER_SECOND }, [PACKETS_BURSTABLE +2 ] = { false,0 }, - [PACKETS_BURSTABLE +3 ] = { true, (MSEC_PER_SEC /PACKETS_PER_SECOND ) *2 }, + [PACKETS_BURSTABLE +3 ] = { true, (NSEC_PER_SEC /PACKETS_PER_SECOND ) *2 }, [PACKETS_BURSTABLE +4 ] = { true,0 }, [PACKETS_BURSTABLE +5 ] = { false,0 } };static __init unsigned int maximum_jiffies_at_index (int index) { -unsigned int total_msecs =2 *MSEC_PER_SEC /PACKETS_PER_SECOND /3 ; +u64 total_nsecs =2 *NSEC_PER_SEC /PACKETS_PER_SECOND /3 ;int i;for (i =0 ; i <= index; ++i) - total_msecs += expected_results[i].msec_to_sleep_before; -return msecs_to_jiffies (total_msecs); + total_nsecs += expected_results[i].nsec_to_sleep_before; +return nsecs_to_jiffies (total_nsecs); } static __init int timings_test(struct sk_buff *skb4, struct iphdr *hdr4,
@@ -42,8 +43,12 @@ static __init int timings_test(struct sk_buff *skb4, struct iphdr *hdr4, loop_start_time = jiffies;for (i =0 ; i <ARRAY_SIZE (expected_results); ++i) { -if (expected_results[i].msec_to_sleep_before) -msleep (expected_results[i].msec_to_sleep_before); +if (expected_results[i].nsec_to_sleep_before) { +ktime_t timeout =ktime_add (ktime_add_ns (ktime_get_coarse_boottime (),TICK_NSEC *4 /3 ), +ns_to_ktime (expected_results[i].nsec_to_sleep_before)); +set_current_state (TASK_UNINTERRUPTIBLE ); +schedule_hrtimeout_range_clock (&timeout,0 ,HRTIMER_MODE_ABS ,CLOCK_BOOTTIME ); + }if (time_is_before_jiffies (loop_start_time +maximum_jiffies_at_index (i)))
@@ -127,7 +132,7 @@ bool __init wg_ratelimiter_selftest(void)if (IS_ENABLED (CONFIG_KASAN ) ||IS_ENABLED (CONFIG_UBSAN ))return true; -BUILD_BUG_ON (MSEC_PER_SEC %PACKETS_PER_SECOND !=0 ); +BUILD_BUG_ON (NSEC_PER_SEC %PACKETS_PER_SECOND !=0 );if (wg_ratelimiter_init ()) goto out;
@@ -176,7 +181,6 @@ bool __init wg_ratelimiter_selftest(void) test += test_count; goto err; } -msleep (500 );continue ; }else if (ret <0 ) { test += test_count;
@@ -195,7 +199,6 @@ bool __init wg_ratelimiter_selftest(void) test += test_count; goto err; } -msleep (50 );continue ; } test += test_count;
kernel/time/hrtimer.c +1 -0
@@ -2311,6 +2311,7 @@ schedule_hrtimeout_range_clock(ktime_t *expires, u64 delta,return !t.task ?0 : -EINTR ; } +EXPORT_SYMBOL_GPL (schedule_hrtimeout_range_clock);/** * schedule_hrtimeout_range - sleep until timeout
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 539/1095 wireguard: allowedips: dont corrupt stack when detecting overflow
In reply to Greg Kroah-HartmanFrom: Jason A. Donenfeld <[email protected]>
[ Upstream commit c31b14d86dfe7174361e8c6e5df6c2c3a4d5918c ]
In case push_rcu() and related functions are buggy, there's a WARN_ON(len >= 128), which the selftest tries to hit by being tricky. In case it is hit, we shouldn't corrupt the kernel's stack, though; otherwise it may be hard to even receive the report that it's buggy. So conditionalize the stack write based on that WARN_ON()'s return value.
Note that this never *actually* happens anyway. The WARN_ON() in the first place is bounded by IS_ENABLED(DEBUG), and isn't expected to ever actually hit. This is just a debugging sanity check.
Additionally, hoist the constant 128 into a named enum, MAX_ALLOWEDIPS_BITS, so that it's clear why this value is chosen.
--- drivers/net/wireguard/allowedips.c | 9 ++++++--- drivers/net/wireguard/selftest/allowedips.c | 6 +++--- 2 files changed, 9 insertions(+), 6 deletions(-)
drivers/net/wireguard/allowedips.c +6 -3
@@ -6,6 +6,8 @@#include "allowedips.h" #include "peer.h" +enum {MAX_ALLOWEDIPS_BITS =128 }; +static struct kmem_cache *node_cache;static void swap_endian (u8 *dst,const u8 *src,u8 bits)
@@ -40,7 +42,8 @@ static void push_rcu(struct allowedips_node **stack, struct allowedips_node __rcu *p, unsigned int *len) { if (rcu_access_pointer(p)) { - WARN_ON(IS_ENABLED(DEBUG) && *len >= 128); + if (WARN_ON(IS_ENABLED(DEBUG) && *len >= MAX_ALLOWEDIPS_BITS)) + return; stack[(*len)++] =rcu_dereference_raw (p); } }
@@ -52,7 +55,7 @@ static void node_free_rcu(struct rcu_head *rcu)static void root_free_rcu (struct rcu_head *rcu) { -struct allowedips_node *node, *stack[128 ] = { +struct allowedips_node *node, *stack[MAX_ALLOWEDIPS_BITS ] = { container_of(rcu, struct allowedips_node, rcu) };unsigned int len =1 ;
@@ -65,7 +68,7 @@ static void root_free_rcu(struct rcu_head *rcu)static void root_remove_peer_lists (struct allowedips_node *root) { -struct allowedips_node *node, *stack[128 ] = { root }; +struct allowedips_node *node, *stack[MAX_ALLOWEDIPS_BITS ] = { root };unsigned int len =1 ;while (len >0 && (node = stack[--len])) {
drivers/net/wireguard/selftest/allowedips.c +3 -3
@@ -593,10 +593,10 @@ bool __init wg_allowedips_selftest(void)wg_allowedips_remove_by_peer (&t, a, &mutex);test_negative (4 , a,192 ,168 ,0 ,1 ); -/* These will hit the WARN_ON(len >= 128) in free_node if something -* goes wrong. +/* These will hit the WARN_ON(len >= MAX_ALLOWEDIPS_BITS) in free_node +* if something goes wrong. */ -for (i =0 ; i <128 ; ++i) { +for (i =0 ; i <MAX_ALLOWEDIPS_BITS ; ++i) { part =cpu_to_be64 (~(1LLU << (i %64 )));memset (&ip,0xff ,16 );memcpy ((u8 *)&ip + (i <64 ) *8 , &part,8 );
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 540/1095 HID: amd_sfh: Dont show client init failed as error when discovery fails
In reply to Greg Kroah-HartmanFrom: Mario Limonciello <[email protected]>
[ Upstream commit e51d8d3ea3d773334d2c047c8d1623dba66f592a ]
When sensor discovery fails, this means that the system doesn't have any sensors connected and a user should only be notified at most one time. A message is already displayed at WARN level of "failed to discover, sensors not enabled". It's pointless to show that the client init failed at ERR level for the same condition.
Check the return code and don't display this message in those conditions.
--- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +2 -1
@@ -327,7 +327,8 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i rc =amd_sfh_hid_client_init (privdata);if (rc) {amd_sfh_clear_intr (privdata); -dev_err (&pdev->dev,"amd_sfh_hid_client_init failed\n" ); +if (rc != -EOPNOTSUPP ) +dev_err (&pdev->dev,"amd_sfh_hid_client_init failed\n" );return rc; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 541/1095 clk: renesas: r9a06g032: Fix UART clkgrp bitsel
In reply to Greg Kroah-HartmanFrom: Ralph Siemsen <[email protected]>
[ Upstream commit 2dee50ab9e72a3cae75b65e5934c8dd3e9bf01bc ]
There are two UART clock groups, each having a mux to select its upstream clock source. The register/bit definitions for accessing these two muxes appear to have been reversed since introduction. Correct them so as to match the hardware manual.
--- drivers/clk/renesas/r9a06g032-clocks.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/clk/renesas/r9a06g032-clocks.c +4 -4
@@ -286,8 +286,8 @@ static const struct r9a06g032_clkdesc r9a06g032_clocks[] = { .name = "uart_group_012", .type = K_BITSEL, .source = 1 + R9A06G032_DIV_UART, - /* R9A06G032_SYSCTRL_REG_PWRCTRL_PG1_PR2 */ - .dual.sel = ((0xec / 4) << 5) | 24, + /* R9A06G032_SYSCTRL_REG_PWRCTRL_PG0_0 */ + .dual.sel = ((0x34 / 4) << 5) | 30, .dual.group = 0, }, {
@@ -295,8 +295,8 @@ static const struct r9a06g032_clkdesc r9a06g032_clocks[] = { .name = "uart_group_34567", .type = K_BITSEL, .source = 1 + R9A06G032_DIV_P2_PG, -/* R9A06G032_SYSCTRL_REG_PWRCTRL_PG0_0 */ - .dual.sel = ((0x34 / 4) << 5) | 30, +/* R9A06G032_SYSCTRL_REG_PWRCTRL_PG1_PR2 */ + .dual.sel = ((0xec / 4) << 5) | 24, .dual.group =1 , }, D_UGATE(CLK_UART0, "clk_uart0", UART_GROUP_012, 0, 0, 0x1b2, 0x1b3, 0x1b4, 0x1b5),
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 542/1095 mtd: maps: Fix refcount leak in of_flash_probe_versatile
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit 33ec82a6d2b119938f26e5c8040ed5d92378eb54 ]
of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
--- drivers/mtd/maps/physmap-versatile.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/maps/physmap-versatile.c +1 -0
@@ -207,6 +207,7 @@ int of_flash_probe_versatile(struct platform_device *pdev, versatile_flashprot = (enum versatile_flashprot )devid->data; rmap =syscon_node_to_regmap (sysnp); +of_node_put (sysnp);if (IS_ERR (rmap))return PTR_ERR (rmap);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 543/1095 mtd: maps: Fix refcount leak in ap_flash_init
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit 77087a04c8fd554134bddcb8a9ff87b21f357926 ]
of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
--- drivers/mtd/maps/physmap-versatile.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/maps/physmap-versatile.c +1 -0
@@ -93,6 +93,7 @@ static int ap_flash_init(struct platform_device *pdev)return -ENODEV ; } ebi_base =of_iomap (ebi,0 ); +of_node_put (ebi);if (!ebi_base)return -ENODEV ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 544/1095 mtd: rawnand: meson: Fix a potential double free issue
In reply to Greg Kroah-HartmanFrom: Christophe JAILLET <[email protected]>
[ Upstream commit ec0da06337751b18f6dee06b6526e0f0d6e80369 ]
When meson_nfc_nand_chip_cleanup() is called, it will call:
meson_nfc_free_buffer(&meson_chip->nand); nand_cleanup(&meson_chip->nand);
nand_cleanup() in turn will call nand_detach() which calls the .detach_chip() which is here meson_nand_detach_chip().
meson_nand_detach_chip() already calls meson_nfc_free_buffer(), so we could double free some memory.
Fix it by removing the unneeded explicit call to meson_nfc_free_buffer().
--- drivers/mtd/nand/raw/meson_nand.c | 1 - 1 file changed, 1 deletion(-)
drivers/mtd/nand/raw/meson_nand.c +0 -1
@@ -1307,7 +1307,6 @@ static int meson_nfc_nand_chip_cleanup(struct meson_nfc *nfc)if (ret)return ret; -meson_nfc_free_buffer (&meson_chip->nand);nand_cleanup (&meson_chip->nand);list_del (&meson_chip->node); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 545/1095 clk: renesas: rzg2l: Fix reset status function
In reply to Greg Kroah-HartmanFrom: Biju Das <[email protected]>
[ Upstream commit 02c96ed9e4cd1f47bfcd10296fec6b0b69d6b3c6 ]
As per RZ/G2L HW(Rev.1.10) manual, reset monitor register value 0 means reset signal is not applied (deassert state) and 1 means reset signal is applied (assert state).
reset_control_status() expects a positive value if the reset line is asserted. But rzg2l_cpg_status function returns zero for asserted state.
This patch fixes the issue by adding double inverted logic, so that reset_control_status returns a positive value if the reset line is asserted.
--- drivers/clk/renesas/rzg2l-cpg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/renesas/rzg2l-cpg.c +1 -1
@@ -744,7 +744,7 @@ static int rzg2l_cpg_status(struct reset_controller_dev *rcdev,unsigned int reg = info->resets[id].off;u32 bitmask =BIT (info->resets[id].bit); -return !(readl (priv->base +CLK_MRST_R (reg)) & bitmask); +return !!(readl (priv->base +CLK_MRST_R (reg)) & bitmask); }static const struct reset_control_ops rzg2l_cpg_reset_ops = {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 546/1095 of: check previous kernels ima-kexec-buffer against memory bounds
In reply to Greg Kroah-HartmanFrom: Vaibhav Jain <[email protected]>
[ Upstream commit cbf9c4b9617b6767886a913705ca14b7600c77db ]
Presently ima_get_kexec_buffer() doesn't check if the previous kernel's ima-kexec-buffer lies outside the addressable memory range. This can result in a kernel panic if the new kernel is booted with 'mem=X' arg and the ima-kexec-buffer was allocated beyond that range by the previous kernel. The panic is usually of the form below:
$ sudo kexec --initrd initrd vmlinux --append='mem=16G'
<snip>
BUG: Unable to handle kernel data access on read at 0xc000c01fff7f0000 Faulting instruction address: 0xc000000000837974 Oops: Kernel access of bad area, sig: 11 [#1] <snip> NIP [c000000000837974] ima_restore_measurement_list+0x94/0x6c0 LR [c00000000083b55c] ima_load_kexec_buffer+0xac/0x160 Call Trace: [c00000000371fa80] [c00000000083b55c] ima_load_kexec_buffer+0xac/0x160 [c00000000371fb00] [c0000000020512c4] ima_init+0x80/0x108 [c00000000371fb70] [c0000000020514dc] init_ima+0x4c/0x120 [c00000000371fbf0] [c000000000012240] do_one_initcall+0x60/0x2c0 [c00000000371fcc0] [c000000002004ad0] kernel_init_freeable+0x344/0x3ec [c00000000371fda0] [c0000000000128a4] kernel_init+0x34/0x1b0 [c00000000371fe10] [c00000000000ce64] ret_from_kernel_thread+0x5c/0x64 Instruction dump: f92100b8 f92100c0 90e10090 910100a0 4182050c 282a0017 3bc00000 40810330 7c0802a6 fb610198 7c9b2378 f80101d0 <a1240000> 2c090001 40820614 e9240010 ---[ end trace 0000000000000000 ]---
Fix this issue by checking returned PFN range of previous kernel's ima-kexec-buffer with page_is_ram() to ensure correct memory bounds.
--- drivers/of/kexec.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
drivers/of/kexec.c +17 -0
@@ -126,6 +126,7 @@ int ima_get_kexec_buffer(void **addr, size_t *size) {int ret, len;unsigned long tmp_addr; +unsigned long start_pfn, end_pfn;size_t tmp_size;const void *prop;
@@ -140,6 +141,22 @@ int ima_get_kexec_buffer(void **addr, size_t *size)if (ret)return ret; +/* Do some sanity on the returned size for the ima-kexec buffer */ +if (!tmp_size) +return -ENOENT ; + +/* +* Calculate the PFNs for the buffer and ensure +* they are with in addressable memory. +*/ + start_pfn =PHYS_PFN (tmp_addr); + end_pfn =PHYS_PFN (tmp_addr + tmp_size -1 ); +if (!page_is_ram (start_pfn) || !page_is_ram (end_pfn)) { +pr_warn ("IMA buffer at 0x%lx, size = 0x%zx beyond memory\n" , + tmp_addr, tmp_size); +return -EINVAL ; + } + *addr =__va (tmp_addr); *size = tmp_size;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 547/1095 scsi: qla2xxx: edif: Reduce Initiator-Initiator thrashing
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit 9c40c36e75ffd49952cd4ead0672defc4b4dbdf7 ]
This patch uses GFFID switch command to scan whether remote device is Target or Initiator mode. Based on that info, driver will not pass up Initiator info to authentication application. This helps reduce unnecessary stress for authentication application to deal with unused connections.
--- drivers/scsi/qla2xxx/qla_def.h | 2 + drivers/scsi/qla2xxx/qla_edif.c | 32 ++++++++- drivers/scsi/qla2xxx/qla_gbl.h | 3 +- drivers/scsi/qla2xxx/qla_gs.c | 118 +++++++++++++++++++++++--------- drivers/scsi/qla2xxx/qla_iocb.c | 2 +- 5 files changed, 120 insertions(+), 37 deletions(-)
drivers/scsi/qla2xxx/qla_def.h +2 -0
@@ -3204,6 +3204,8 @@ struct ct_sns_rsp {#define GFF_NVME_OFFSET 23/* type = 28h */ struct {uint8_t fc4_features[128 ]; +#define FC4_FF_TARGET BIT_0 +#define FC4_FF_INITIATOR BIT_1 } gff_id;struct {uint8_t reserved;
drivers/scsi/qla2xxx/qla_edif.c +29 -3
@@ -517,16 +517,28 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job)if (atomic_read (&vha->loop_state) ==LOOP_DOWN )break ; - fcport->edif.app_started =1 ; fcport->login_retry = vha->hw->login_retry_count; -/* no activity */ fcport->edif.app_stop =0 ; + fcport->edif.app_sess_online =0 ; + fcport->edif.app_started =1 ; + +if (fcport->scan_state !=QLA_FCPORT_FOUND ) +continue ; + +if (fcport->port_type ==FCT_UNKNOWN && + !fcport->fc4_features) + rval =qla24xx_async_gffid (vha, fcport, true); + +if (!rval && !(fcport->fc4_features &FC4_FF_TARGET || + fcport->port_type & (FCT_TARGET |FCT_NVME_TARGET ))) +continue ; + + rval =0 ;ql_dbg (ql_dbg_edif, vha,0x911e ,"%s wwpn %8phC calling qla_edif_reset_auth_wait\n" , __func__, fcport->port_name); - fcport->edif.app_sess_online =0 ;qlt_schedule_sess_for_deletion (fcport);qla_edif_sa_ctl_init (vha, fcport); }
@@ -884,6 +896,20 @@ qla_edif_app_getfcinfo(scsi_qla_host_t *vha, struct bsg_job *bsg_job) app_reply->ports[pcnt].rekey_count = fcport->edif.rekey_cnt; +if (fcport->scan_state !=QLA_FCPORT_FOUND ) +continue ; + +if (fcport->port_type ==FCT_UNKNOWN && !fcport->fc4_features) + rval =qla24xx_async_gffid (vha, fcport, true); + +if (!rval && + !(fcport->fc4_features &FC4_FF_TARGET || + fcport->port_type & + (FCT_TARGET |FCT_NVME_TARGET ))) +continue ; + + rval =0 ; + app_reply->ports[pcnt].remote_type =VND_CMD_RTYPE_UNKNOWN ;if (fcport->port_type & (FCT_NVME_TARGET |FCT_TARGET ))
drivers/scsi/qla2xxx/qla_gbl.h +2 -1
@@ -335,6 +335,7 @@ extern int qla24xx_configure_prot_mode(srb_t *, uint16_t *);extern int qla24xx_issue_sa_replace_iocb (scsi_qla_host_t *vha,struct qla_work_evt *e);void qla2x00_sp_release (struct kref *kref); +void qla2x00_els_dcmd2_iocb_timeout (void *data);/* * Global Function Prototypes in qla_mbx.c source file.
@@ -727,7 +728,7 @@ int qla24xx_async_gpsc(scsi_qla_host_t *, fc_port_t *);void qla24xx_handle_gpsc_event (scsi_qla_host_t *,struct event_arg *);int qla2x00_mgmt_svr_login (scsi_qla_host_t *);void qla24xx_handle_gffid_event (scsi_qla_host_t *vha,struct event_arg *ea); -int qla24xx_async_gffid (scsi_qla_host_t *vha,fc_port_t *fcport); +int qla24xx_async_gffid (scsi_qla_host_t *vha,fc_port_t *fcport,bool );int qla24xx_async_gpnft (scsi_qla_host_t *,u8 ,srb_t *);void qla24xx_async_gpnft_done (scsi_qla_host_t *,srb_t *);void qla24xx_async_gnnft_done (scsi_qla_host_t *,srb_t *);
drivers/scsi/qla2xxx/qla_gs.c +86 -32
182 lines not on this page · raw message
drivers/scsi/qla2xxx/qla_iocb.c +1 -1
@@ -2819,7 +2819,7 @@ qla24xx_els_logo_iocb(srb_t *sp, struct els_entry_24xx *els_iocb) sp->vha->qla_stats.control_requests++; } -static void +void qla2x00_els_dcmd2_iocb_timeout (void *data) {srb_t *sp = data;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 548/1095 scsi: qla2xxx: edif: bsg refactor
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit 7a7b0b4865d3490f62d6ef1a3aa39fa2b47859a4 ]
- Add version field to edif bsg for future enhancement.
- Add version edif bsg version check
- Remove unused interfaces and fields.
--- drivers/scsi/qla2xxx/qla_edif.c | 32 +++++++--- drivers/scsi/qla2xxx/qla_edif_bsg.h | 90 ++++++++++++++++++----------- 2 files changed, 79 insertions(+), 43 deletions(-)
drivers/scsi/qla2xxx/qla_edif.c +23 -9
@@ -280,14 +280,19 @@ qla_edif_app_check(scsi_qla_host_t *vha, struct app_id appid) {/* check that the app is allow/known to the driver */ -if (appid.app_vid ==EDIF_APP_ID ) { -ql_dbg (ql_dbg_edif + ql_dbg_verbose, vha,0x911d ,"%s app id ok\n" , __func__); -return true; +if (appid.app_vid !=EDIF_APP_ID ) { +ql_dbg (ql_dbg_edif, vha,0x911d ,"%s app id not ok (%x)" , + __func__, appid.app_vid); +return false; + } + +if (appid.version !=EDIF_VERSION1 ) { +ql_dbg (ql_dbg_edif, vha,0x911d ,"%s app version is not ok (%x)" , + __func__, appid.version); +return false; } -ql_dbg (ql_dbg_edif, vha,0x911d ,"%s app id not ok (%x)" , - __func__, appid.app_vid); -return false; +return true; } static void
@@ -555,6 +560,7 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job) appreply.host_support_edif = vha->hw->flags.edif_enabled; appreply.edif_enode_active = vha->pur_cinfo.enode_flags; appreply.edif_edb_active = vha->e_dbell.db_flags; + appreply.version =EDIF_VERSION1 ; bsg_job->reply_len =sizeof (struct fc_bsg_reply );
@@ -685,6 +691,7 @@ qla_edif_app_authok(scsi_qla_host_t *vha, struct bsg_job *bsg_job) portid.b.area = appplogiok.u.d_id.b.area; portid.b.al_pa = appplogiok.u.d_id.b.al_pa; + appplogireply.version =EDIF_VERSION1 ;switch (appplogiok.type) {case PL_TYPE_WWPN : fcport = qla2x00_find_fcport_by_wwpn(vha,
@@ -877,6 +884,8 @@ qla_edif_app_getfcinfo(scsi_qla_host_t *vha, struct bsg_job *bsg_job) }else {struct fc_port *fcport =NULL , *tf; + app_reply->version =EDIF_VERSION1 ; +list_for_each_entry_safe (fcport, tf, &vha->vp_fcports, list) {if (!(fcport->flags &FCF_FCSP_DEVICE ))continue ;
@@ -893,9 +902,6 @@ qla_edif_app_getfcinfo(scsi_qla_host_t *vha, struct bsg_job *bsg_job)if (tdid.b24 !=0 && tdid.b24 != fcport->d_id.b24)continue ; - app_reply->ports[pcnt].rekey_count = - fcport->edif.rekey_cnt; -if (fcport->scan_state !=QLA_FCPORT_FOUND )continue ;
@@ -910,6 +916,7 @@ qla_edif_app_getfcinfo(scsi_qla_host_t *vha, struct bsg_job *bsg_job) rval =0 ; + app_reply->ports[pcnt].version =EDIF_VERSION1 ; app_reply->ports[pcnt].remote_type =VND_CMD_RTYPE_UNKNOWN ;if (fcport->port_type & (FCT_NVME_TARGET |FCT_TARGET ))
@@ -1006,6 +1013,8 @@ qla_edif_app_getstats(scsi_qla_host_t *vha, struct bsg_job *bsg_job) }else {struct fc_port *fcport =NULL , *tf; + app_reply->version =EDIF_VERSION1 ; +list_for_each_entry_safe (fcport, tf, &vha->vp_fcports, list) {if (fcport->edif.enable) {if (pcnt > app_req.num_ports)
@@ -2037,6 +2046,7 @@ qla_edb_eventcreate(scsi_qla_host_t *vha, uint32_t dbtype, edbnode->u.sa_aen.port_id = fcport->d_id; edbnode->u.sa_aen.status = data; edbnode->u.sa_aen.key_type = data2; + edbnode->u.sa_aen.version =EDIF_VERSION1 ;break ;default : ql_dbg(ql_dbg_edif, vha, 0x09102,
@@ -3380,6 +3390,10 @@ int qla_edif_process_els(scsi_qla_host_t *vha, struct bsg_job *bsg_job)port_id_t d_id;struct qla_bsg_auth_els_request *p = (struct qla_bsg_auth_els_request *)bsg_job->request; +struct qla_bsg_auth_els_reply *rpl = + (struct qla_bsg_auth_els_reply *)bsg_job->reply; + + rpl->version =EDIF_VERSION1 ; d_id.b.al_pa = bsg_request->rqst_data.h_els.port_id[2 ]; d_id.b.area = bsg_request->rqst_data.h_els.port_id[1 ];
drivers/scsi/qla2xxx/qla_edif_bsg.h +56 -34
192 lines not on this page · raw message
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 549/1095 scsi: qla2xxx: edif: Wait for app to ack on sess down
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit df648afa39da9c4d3af99c6c03dc3e9c7dfa99b0 ]
On session deletion, wait for app to acknowledge before moving on. This allows both app and driver to stay in sync. In addition, this gives a chance for authentication app to do any type of cleanup before moving on.
--- drivers/scsi/qla2xxx/qla_def.h | 2 +- drivers/scsi/qla2xxx/qla_edif.c | 66 +++++++++++++++++++++++++------ drivers/scsi/qla2xxx/qla_init.c | 4 -- drivers/scsi/qla2xxx/qla_target.c | 35 ++++++++-------- 4 files changed, 74 insertions(+), 33 deletions(-)
drivers/scsi/qla2xxx/qla_def.h +1 -1
@@ -2626,7 +2626,6 @@ typedef struct fc_port {struct {uint32_t enable:1 ;/* device is edif enabled/req'd */ uint32_t app_stop:2 ; -uint32_t app_started:1 ;uint32_t aes_gmac:1 ;uint32_t app_sess_online:1 ;uint32_t tx_sa_set:1 ;
@@ -2637,6 +2636,7 @@ typedef struct fc_port {uint32_t rx_rekey_cnt;uint64_t tx_bytes;uint64_t rx_bytes; +uint8_t sess_down_acked;uint8_t auth_state; uint16_t authok:1;uint16_t rekey_cnt;
drivers/scsi/qla2xxx/qla_edif.c +54 -12
110 lines not on this page · raw message
drivers/scsi/qla2xxx/qla_init.c +0 -4
@@ -1480,7 +1480,6 @@ static int qla_chk_secure_login(scsi_qla_host_t *vha, fc_port_t *fcport,ql_dbg (ql_dbg_disc, vha,0x20ef ,"%s %d %8phC EDIF: post DB_AUTH: AUTH needed\n" , __func__, __LINE__, fcport->port_name); - fcport->edif.app_started =1 ; fcport->edif.app_sess_online =1 ; qla_edb_eventcreate(vha, VND_CMD_AUTH_STATE_NEEDED,
@@ -5275,9 +5274,6 @@ qla2x00_alloc_fcport(scsi_qla_host_t *vha, gfp_t flags)INIT_LIST_HEAD (&fcport->edif.tx_sa_list);INIT_LIST_HEAD (&fcport->edif.rx_sa_list); -if (vha->e_dbell.db_flags ==EDB_ACTIVE ) - fcport->edif.app_started =1 ; -spin_lock_init (&fcport->edif.indx_list_lock);INIT_LIST_HEAD (&fcport->edif.edif_indx_list);
drivers/scsi/qla2xxx/qla_target.c +19 -16
@@ -988,22 +988,6 @@ void qlt_free_session_done(struct work_struct *work) sess->send_els_logo);if (!IS_SW_RESV_ADDR (sess->d_id)) { -if (ha->flags.edif_enabled && - (!own || own->iocb.u.isp24.status_subcode ==ELS_PLOGI )) { - sess->edif.authok =0 ; -if (!ha->flags.host_shutting_down) { -ql_dbg (ql_dbg_edif, vha,0x911e , -"%s wwpn %8phC calling qla2x00_release_all_sadb\n" , - __func__, sess->port_name); -qla2x00_release_all_sadb (vha, sess); - }else { -ql_dbg (ql_dbg_edif, vha,0x911e , -"%s bypassing release_all_sadb\n" , - __func__); - } -qla_edif_clear_appdata (vha, sess); -qla_edif_sess_down (vha, sess); - }qla2x00_mark_device_lost (vha, sess,0 );if (sess->send_els_logo) {
@@ -1049,6 +1033,25 @@ void qlt_free_session_done(struct work_struct *work) sess->nvme_flag |=NVME_FLAG_DELETING ;qla_nvme_unregister_remote_port (sess); } + +if (ha->flags.edif_enabled && + (!own || (own && + own->iocb.u.isp24.status_subcode ==ELS_PLOGI ))) { + sess->edif.authok =0 ; +if (!ha->flags.host_shutting_down) { +ql_dbg (ql_dbg_edif, vha,0x911e , +"%s wwpn %8phC calling qla2x00_release_all_sadb\n" , + __func__, sess->port_name); +qla2x00_release_all_sadb (vha, sess); + }else { +ql_dbg (ql_dbg_edif, vha,0x911e , +"%s bypassing release_all_sadb\n" , + __func__); + } + +qla_edif_clear_appdata (vha, sess); +qla_edif_sess_down (vha, sess); + } }/*
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 550/1095 scsi: qla2xxx: edif: Add bsg interface to read doorbell events
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit 5ecd241bd7b1088a189581c0b560a13fe93621f6 ]
Add bsg interface for app to read doorbell events. This interface lets driver know how much app can read based on return buffer size. When the next event(s) occur, driver will return the bsg_job with the event(s) in the return buffer.
If there is no event to read, driver will hold on to the bsg_job up to few seconds as a way to control the polling interval.
--- drivers/scsi/qla2xxx/qla_dbg.h | 2 +- drivers/scsi/qla2xxx/qla_edif.c | 249 ++++++++++++++++++++-------- drivers/scsi/qla2xxx/qla_edif.h | 3 +- drivers/scsi/qla2xxx/qla_edif_bsg.h | 14 ++ 4 files changed, 195 insertions(+), 73 deletions(-)
drivers/scsi/qla2xxx/qla_dbg.h +1 -1
@@ -383,5 +383,5 @@ ql_mask_match(uint level)if (ql2xextended_error_logging ==1 ) ql2xextended_error_logging =QL_DBG_DEFAULT1_MASK ; -return (level & ql2xextended_error_logging) == level; +return level && ((level & ql2xextended_error_logging) == level); }
drivers/scsi/qla2xxx/qla_edif.c +178 -71
345 lines not on this page · raw message
drivers/scsi/qla2xxx/qla_edif.h +2 -1
@@ -51,7 +51,8 @@ struct edif_dbell {enum db_flags_t db_flags;spinlock_t db_lock;struct list_head head; -struct completion dbell; +struct bsg_job *dbell_bsg_job; +unsigned long bsg_expire; };#define SA_UPDATE_IOCB_TYPE 0x71/* Security Association Update IOCB entry */
drivers/scsi/qla2xxx/qla_edif_bsg.h +14 -0
@@ -183,6 +183,20 @@ struct qla_sa_update_frame {#define QL_VND_SC_GET_FCINFO 7#define QL_VND_SC_GET_STATS 8#define QL_VND_SC_AEN_COMPLETE 9 +#define QL_VND_SC_READ_DBELL 10 + +/* +* bsg caller to provide empty buffer for doorbell events. +* +* sg_io_v4.din_xferp = empty buffer for door bell events +* sg_io_v4.dout_xferp = struct edif_read_dbell *buf +*/ +struct edif_read_dbell { +struct app_id app_info; +uint8_t version; +uint8_t pad[VND_CMD_PAD_SIZE ]; +uint8_t reserved[VND_CMD_APP_RESERVED_SIZE ]; +};/* Application interface data structure for rtn data */
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 551/1095 scsi: qla2xxx: edif: Fix potential stuck session in sa update
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit e0fb8ce2bb9e52c846e54ad2c58b5b7beb13eb09 ]
When a thread is in the process of reestablish a session, a flag is set to prevent multiple threads/triggers from doing the same task. This flag was left on, and any attempt to relogin was locked out. Clear this flag if the attempt has failed.
--- drivers/scsi/qla2xxx/qla_edif.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)
drivers/scsi/qla2xxx/qla_edif.c +14 -3
@@ -2332,6 +2332,7 @@ edif_doorbell_show(struct device *dev, struct device_attribute *attr,static void qla_noop_sp_done (srb_t *sp,int res) { + sp->fcport->flags &= ~(FCF_ASYNC_SENT |FCF_ASYNC_ACTIVE );/* ref: INIT */ kref_put (&sp->cmd_kref, qla2x00_sp_release); }
@@ -2356,7 +2357,8 @@ qla24xx_issue_sa_replace_iocb(scsi_qla_host_t *vha, struct qla_work_evt *e)if (!sa_ctl) {ql_dbg (ql_dbg_edif, vha,0x70e6 ,"sa_ctl allocation failed\n" ); -return -ENOMEM ; + rval = -ENOMEM ; + goto done; } fcport = sa_ctl->fcport;
@@ -2366,7 +2368,8 @@ qla24xx_issue_sa_replace_iocb(scsi_qla_host_t *vha, struct qla_work_evt *e)if (!sp) {ql_dbg (ql_dbg_edif, vha,0x70e6 ,"SRB allocation failed\n" ); -return -ENOMEM ; + rval = -ENOMEM ; + goto done; } fcport->flags |=FCF_ASYNC_SENT ;
@@ -2395,9 +2398,17 @@ qla24xx_issue_sa_replace_iocb(scsi_qla_host_t *vha, struct qla_work_evt *e) rval =qla2x00_start_sp (sp); -if (rval !=QLA_SUCCESS ) +if (rval !=QLA_SUCCESS ) { rval =QLA_FUNCTION_FAILED ; + goto done_free_sp; + } +return rval; +done_free_sp: +kref_put (&sp->cmd_kref, qla2x00_sp_release); + fcport->flags &= ~FCF_ASYNC_SENT ; +done: + fcport->flags &= ~FCF_ASYNC_ACTIVE ;return rval; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 552/1095 scsi: qla2xxx: edif: Synchronize NPIV deletion with authentication application
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit cf79716e6636400ae38c37bc8a652b1e522abbba ]
Notify authentication application of a NPIV deletion event is about to occur. This allows app to perform cleanup.
--- drivers/scsi/qla2xxx/qla_edif_bsg.h | 2 ++ drivers/scsi/qla2xxx/qla_mid.c | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_edif_bsg.h +2 -0
@@ -253,4 +253,6 @@ struct aen_complete_cmd {#define RX_DELAY_DELETE_TIMEOUT 20 +#define FCH_EVT_VENDOR_UNIQUE_VPORT_DOWN 1 +#endif /* QLA_EDIF_BSG_H */
drivers/scsi/qla2xxx/qla_mid.c +5 -1
@@ -166,9 +166,13 @@ qla24xx_disable_vp(scsi_qla_host_t *vha)int ret =QLA_SUCCESS ;fc_port_t *fcport; -if (vha->hw->flags.edif_enabled) +if (vha->hw->flags.edif_enabled) { +if (DBELL_ACTIVE (vha)) +qla2x00_post_aen_work (vha,FCH_EVT_VENDOR_UNIQUE , +FCH_EVT_VENDOR_UNIQUE_VPORT_DOWN );/* delete sessions and flush sa_indexes */ qla2x00_wait_for_sess_deletion (vha); + }if (vha->hw->flags.fw_started) ret =qla24xx_control_vp (vha,VCE_COMMAND_DISABLE_VPS_LOGO_ALL );
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 553/1095 scsi: qla2xxx: edif: Add retry for ELS passthrough
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit 0b3f3143d473b489a7aa0779c43bcdb344bd3014 ]
Relating to EDIF, when sending IKE message, updating key or deleting key, driver can encounter IOCB queue full. Add additional retries to reduce higher level recovery.
--- drivers/scsi/qla2xxx/qla_edif.c | 52 +++++++++++++++++++++++---------- drivers/scsi/qla2xxx/qla_os.c | 2 +- 2 files changed, 38 insertions(+), 16 deletions(-)
drivers/scsi/qla2xxx/qla_edif.c +37 -15
@@ -1468,6 +1468,8 @@ qla24xx_check_sadb_avail_slot(struct bsg_job *bsg_job, fc_port_t *fcport,#define QLA_SA_UPDATE_FLAGS_RX_KEY 0x0#define QLA_SA_UPDATE_FLAGS_TX_KEY 0x2 +#define EDIF_MSLEEP_INTERVAL 100 +#define EDIF_RETRY_COUNT 50int qla24xx_sadb_update (struct bsg_job *bsg_job)
@@ -1480,7 +1482,7 @@ qla24xx_sadb_update(struct bsg_job *bsg_job)struct edif_list_entry *edif_entry =NULL ;int found =0 ;int rval =0 ; -int result =0 ; +int result =0 , cnt;struct qla_sa_update_frame sa_frame;struct srb_iocb *iocb_cmd;port_id_t portid;
@@ -1721,11 +1723,23 @@ qla24xx_sadb_update(struct bsg_job *bsg_job) sp->done = qla2x00_bsg_job_done; iocb_cmd = &sp->u.iocb_cmd; iocb_cmd->u.sa_update.sa_frame = sa_frame; - + cnt =0 ; +retry: rval =qla2x00_start_sp (sp); -if (rval !=QLA_SUCCESS ) { +switch (rval) { +case QLA_SUCCESS : +break ; +case EAGAIN : +msleep (EDIF_MSLEEP_INTERVAL ); + cnt++; +if (cnt <EDIF_RETRY_COUNT ) + goto retry; + + fallthrough; +default :ql_log (ql_dbg_edif, vha,0x70e3 , -"qla2x00_start_sp failed=%d.\n" , rval); +"%s qla2x00_start_sp failed=%d.\n" , + __func__, rval);qla2x00_rel_sp (sp); rval = -EIO ;
@@ -2399,7 +2413,6 @@ qla24xx_issue_sa_replace_iocb(scsi_qla_host_t *vha, struct qla_work_evt *e) rval =qla2x00_start_sp (sp);if (rval !=QLA_SUCCESS ) { - rval =QLA_FUNCTION_FAILED ; goto done_free_sp; }
@@ -3531,7 +3544,7 @@ int qla_edif_process_els(scsi_qla_host_t *vha, struct bsg_job *bsg_job)fc_port_t *fcport =NULL ;struct qla_hw_data *ha = vha->hw;srb_t *sp; -int rval = (DID_ERROR <<16 ); +int rval = (DID_ERROR <<16 ), cnt;port_id_t d_id;struct qla_bsg_auth_els_request *p = (struct qla_bsg_auth_els_request *)bsg_job->request;
@@ -3626,17 +3639,26 @@ int qla_edif_process_els(scsi_qla_host_t *vha, struct bsg_job *bsg_job) sp->free = qla2x00_bsg_sp_free; sp->done = qla2x00_bsg_job_done; + cnt =0 ; +retry: rval =qla2x00_start_sp (sp); - -ql_dbg (ql_dbg_edif, vha,0x700a , -"%s %s %8phN xchg %x ctlflag %x hdl %x reqlen %xh bsg ptr %p\n" , - __func__,sc_to_str (p->e.sub_cmd), fcport->port_name, - p->e.extra_rx_xchg_address, p->e.extra_control_flags, - sp->handle, sp->remap.req.len, bsg_job); - -if (rval !=QLA_SUCCESS ) { +switch (rval) { +case QLA_SUCCESS : +ql_dbg (ql_dbg_edif, vha,0x700a , +"%s %s %8phN xchg %x ctlflag %x hdl %x reqlen %xh bsg ptr %p\n" , + __func__,sc_to_str (p->e.sub_cmd), fcport->port_name, + p->e.extra_rx_xchg_address, p->e.extra_control_flags, + sp->handle, sp->remap.req.len, bsg_job); +break ; +case EAGAIN : +msleep (EDIF_MSLEEP_INTERVAL ); + cnt++; +if (cnt <EDIF_RETRY_COUNT ) + goto retry; + fallthrough; +default :ql_log (ql_log_warn, vha,0x700e , -"qla2x00_start_sp failed = %d\n" , rval); +"%s qla2x00_start_sp failed = %d\n" , __func__, rval);SET_DID_STATUS (bsg_reply->result,DID_IMM_RETRY ); rval = -EIO ; goto done_free_remap_rsp;
drivers/scsi/qla2xxx/qla_os.c +1 -1
@@ -5473,7 +5473,7 @@ qla2x00_do_work(struct scsi_qla_host *vha) e->u.fcport.fcport, false);break ;case QLA_EVT_SA_REPLACE : -qla24xx_issue_sa_replace_iocb (vha, e); + rc =qla24xx_issue_sa_replace_iocb (vha, e);break ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 554/1095 scsi: qla2xxx: edif: Fix n2n discovery issue with secure target
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit 789d54a4178634850e441f60c0326124138e7269 ]
User failed to see disk via n2n topology. Driver used up all login retries before authentication application started. When authentication application started, driver did not have enough login retries to connect securely. On app_start, driver will reset the login retry attempt count.
--- drivers/scsi/qla2xxx/qla_edif.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/scsi/qla2xxx/qla_edif.c +3 -0
@@ -515,6 +515,9 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job) }if (N2N_TOPO (vha->hw)) { +list_for_each_entry_safe (fcport, tf, &vha->vp_fcports, list) + fcport->n2n_link_reset_cnt =0 ; +if (vha->hw->flags.n2n_fw_acc_sec)set_bit (N2N_LINK_RESET , &vha->dpc_flags);else
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 555/1095 scsi: qla2xxx: edif: Fix n2n login retry for secure device
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit aec55325ddec975216119da000092cb8664a3399 ]
After initiator has burned up all login retries, target authentication application begins to run. This triggers a link bounce on target side. Initiator will attempt another login. Due to N2N, the PRLI [nvme | fcp] can fail because of the mode mismatch with target. This patch add a few more login retries to revive the connection.
--- drivers/scsi/qla2xxx/qla_init.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/scsi/qla2xxx/qla_init.c +7 -0
@@ -2123,6 +2123,13 @@ qla24xx_handle_prli_done_event(struct scsi_qla_host *vha, struct event_arg *ea) }if (N2N_TOPO (vha->hw)) { +if (ea->fcport->n2n_link_reset_cnt == + vha->hw->login_retry_count && + ea->fcport->flags &FCF_FCSP_DEVICE ) { +/* remote authentication app just started */ + ea->fcport->n2n_link_reset_cnt =0 ; + } +if (ea->fcport->n2n_link_reset_cnt < vha->hw->login_retry_count) { ea->fcport->n2n_link_reset_cnt++;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 556/1095 KVM: SVM: Unwind "speculative" RIP advancement if INTn injection "fails"
In reply to Greg Kroah-HartmanFrom: Sean Christopherson <[email protected]>
[ Upstream commit cd9e6da8048c5b40315ee2d929b6230ce1252c3c ]
Unwind the RIP advancement done by svm_queue_exception() when injecting an INT3 ultimately "fails" due to the CPU encountering a VM-Exit while vectoring the injected event, even if the exception reported by the CPU isn't the same event that was injected. If vectoring INT3 encounters an exception, e.g. #NP, and vectoring the #NP encounters an intercepted exception, e.g. #PF when KVM is using shadow paging, then the #NP will be reported as the event that was in-progress.
Note, this is still imperfect, as it will get a false positive if the INT3 is cleanly injected, no VM-Exit occurs before the IRET from the INT3 handler in the guest, the instruction following the INT3 generates an exception (directly or indirectly), _and_ vectoring that exception encounters an exception that is intercepted by KVM. The false positives could theoretically be solved by further analyzing the vectoring event, e.g. by comparing the error code against the expected error code were an exception to occur when vectoring the original injected exception, but SVM without NRIPS is a complete disaster, trying to make it 100% correct is a waste of time.
Message-Id: <450133cf0a026cb9825a2ff55d02cb136a1cb111.1651440202.git.maciej.szmigiero@oracle.com>
--- arch/x86/kvm/svm/svm.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-)
arch/x86/kvm/svm/svm.c +15 -8
@@ -3613,6 +3613,18 @@ static void svm_complete_interrupts(struct kvm_vcpu *vcpu) vector = exitintinfo &SVM_EXITINTINFO_VEC_MASK ; type = exitintinfo &SVM_EXITINTINFO_TYPE_MASK ; +/* +* If NextRIP isn't enabled, KVM must manually advance RIP prior to +* injecting the soft exception/interrupt. That advancement needs to +* be unwound if vectoring didn't complete. Note, the _new_ event may +* not be the injected event, e.g. if KVM injected an INTn, the INTn +* hit a #NP in the guest, and the #NP encountered a #PF, the #NP will +* be the reported vectored event, but RIP still needs to be unwound. +*/ +if (int3_injected && type ==SVM_EXITINTINFO_TYPE_EXEPT && +kvm_is_linear_rip (vcpu, svm->int3_rip)) +kvm_rip_write (vcpu,kvm_rip_read (vcpu) - int3_injected); +switch (type) {case SVM_EXITINTINFO_TYPE_NMI : vcpu->arch.nmi_injected = true;
@@ -3626,16 +3638,11 @@ static void svm_complete_interrupts(struct kvm_vcpu *vcpu)/* * In case of software exceptions, do not reinject the vector, -* but re-execute the instruction instead. Rewind RIP first -* if we emulated INT3 before. +* but re-execute the instruction instead. */ -if (kvm_exception_is_soft (vector)) { -if (vector ==BP_VECTOR && int3_injected && -kvm_is_linear_rip (vcpu, svm->int3_rip)) -kvm_rip_write (vcpu, -kvm_rip_read (vcpu) - int3_injected); +if (kvm_exception_is_soft (vector))break ; - } +if (exitintinfo &SVM_EXITINTINFO_VALID_ERR ) {u32 err = svm->vmcb->control.exit_int_info_err;kvm_requeue_exception_e (vcpu, vector, err);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 557/1095 KVM: SVM: Stuff next_rip on emulated INT3 injection if NRIPS is supported
In reply to Greg Kroah-HartmanFrom: Sean Christopherson <[email protected]>
[ Upstream commit 3741aec4c38fa4123ab08ae552f05366d4fd05d8 ]
If NRIPS is supported in hardware but disabled in KVM, set next_rip to the next RIP when advancing RIP as part of emulating INT3 injection. There is no flag to tell the CPU that KVM isn't using next_rip, and so leaving next_rip is left as is will result in the CPU pushing garbage onto the stack when vectoring the injected event.
Message-Id: <cd328309a3b88604daa2359ad56f36cb565ce2d4.1651440202.git.maciej.szmigiero@oracle.com>
--- arch/x86/kvm/svm/svm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
arch/x86/kvm/svm/svm.c +5 -1
@@ -390,6 +390,10 @@ static void svm_queue_exception(struct kvm_vcpu *vcpu)*/ (void )svm_skip_emulated_instruction (vcpu); rip =kvm_rip_read (vcpu); + +if (boot_cpu_has (X86_FEATURE_NRIPS )) + svm->vmcb->control.next_rip = rip; + svm->int3_rip = rip + svm->vmcb->save.cs.base; svm->int3_injected = rip - old_rip; }
@@ -3616,7 +3620,7 @@ static void svm_complete_interrupts(struct kvm_vcpu *vcpu)/* * If NextRIP isn't enabled, KVM must manually advance RIP prior to * injecting the soft exception/interrupt. That advancement needs to -* be unwound if vectoring didn't complete. Note, the _new_ event may +* be unwound if vectoring didn't complete. Note, the new event may * not be the injected event, e.g. if KVM injected an INTn, the INTn * hit a #NP in the guest, and the #NP encountered a #PF, the #NP will * be the reported vectored event, but RIP still needs to be unwound.
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 558/1095 KVM: x86/mmu: Drop RWX=0 SPTEs during ept_sync_page()
In reply to Greg Kroah-HartmanFrom: Sean Christopherson <[email protected]>
[ Upstream commit 9fb3565743d58352f00964bf47213b88aff4bb82 ]
All of sync_page()'s existing checks filter out only !PRESENT gPTE, because without execute-only, all upper levels are guaranteed to be at least READABLE. However, if EPT with execute-only support is in use by L1, KVM can create an SPTE that is shadow-present but guest-inaccessible (RWX=0) if the upper level combined permissions are R (or RW) and the leaf EPTE is changed from R (or RW) to X. Because the EPTE is considered present when viewed in isolation, and no reserved bits are set, FNAME(prefetch_invalid_gpte) will consider the GPTE valid, and cause a not-present SPTE to be created.
The SPTE is "correct": the guest translation is inaccessible because the combined protections of all levels yield RWX=0, and KVM will just redirect any vmexits to the guest. If EPT A/D bits are disabled, KVM can mistake the SPTE for an access-tracked SPTE, but again such confusion isn't fatal, as the "saved" protections are also RWX=0. However, creating a useless SPTE in general means that KVM messed up something, even if this particular goof didn't manifest as a functional bug. So, drop SPTEs whose new protections will yield a RWX=0 SPTE, and add a WARN in make_spte() to detect creation of SPTEs that will result in RWX=0 protections.
Message-Id: <[email protected]>
--- arch/x86/kvm/mmu/paging_tmpl.h | 9 ++++++++- arch/x86/kvm/mmu/spte.c | 2 ++ 2 files changed, 10 insertions(+), 1 deletion(-)
arch/x86/kvm/mmu/paging_tmpl.h +8 -1
@@ -1044,7 +1044,14 @@ static int FNAME(sync_page)(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp)if (sync_mmio_spte (vcpu, &sp->spt[i], gfn, pte_access))continue ; -if (gfn != sp->gfns[i]) { +/* +* Drop the SPTE if the new protections would result in a RWX=0 +* SPTE or if the gfn is changing. The RWX=0 case only affects +* EPT with execute-only support, i.e. EPT without an effective +* "present" bit, as all other paging modes will create a +* read-only SPTE if pte_access is zero. +*/ +if ((!pte_access && !shadow_present_mask) || gfn != sp->gfns[i]) {drop_spte (vcpu->kvm, &sp->spt[i]); flush = true;continue ;
arch/x86/kvm/mmu/spte.c +2 -0
@@ -128,6 +128,8 @@ bool make_spte(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp,u64 spte =SPTE_MMU_PRESENT_MASK ;bool wrprot = false; +WARN_ON_ONCE (!pte_access && !shadow_present_mask); +if (sp->role.ad_disabled) spte |=SPTE_TDP_AD_DISABLED_MASK ;else if (kvm_mmu_page_ad_need_write_protect (sp))
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 559/1095 phy: samsung: exynosautov9-ufs: correct TSRV register configurations
In reply to Greg Kroah-HartmanFrom: Chanho Park <[email protected]>
[ Upstream commit f7fdc4db071f7ee7d408ea3f083222a060c76623 ]
For exynos auto v9's UFS MPHY, We should use 0x50 offset of TSRV register configurations. So, it must be
s/PHY_TRSV_REG_CFG/PHY_TRSV_REG_CFG_AUTOV9/g
--- drivers/phy/samsung/phy-exynosautov9-ufs.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/phy/samsung/phy-exynosautov9-ufs.c +9 -9
@@ -31,22 +31,22 @@ static const struct samsung_ufs_phy_cfg exynosautov9_pre_init_cfg[] = {PHY_COMN_REG_CFG (0x023 ,0xc0 ,PWR_MODE_ANY ),PHY_COMN_REG_CFG (0x023 ,0x00 ,PWR_MODE_ANY ), -PHY_TRSV_REG_CFG (0x042 ,0x5d ,PWR_MODE_ANY ), -PHY_TRSV_REG_CFG (0x043 ,0x80 ,PWR_MODE_ANY ), +PHY_TRSV_REG_CFG_AUTOV9 (0x042 ,0x5d ,PWR_MODE_ANY ), +PHY_TRSV_REG_CFG_AUTOV9 (0x043 ,0x80 ,PWR_MODE_ANY ), END_UFS_PHY_CFG, };/* Calibration for HS mode series A/B */ static const struct samsung_ufs_phy_cfg exynosautov9_pre_pwr_hs_cfg[] = { -PHY_TRSV_REG_CFG (0x032 ,0xbc ,PWR_MODE_HS_ANY ), -PHY_TRSV_REG_CFG (0x03c ,0x7f ,PWR_MODE_HS_ANY ), -PHY_TRSV_REG_CFG (0x048 ,0xc0 ,PWR_MODE_HS_ANY ), +PHY_TRSV_REG_CFG_AUTOV9 (0x032 ,0xbc ,PWR_MODE_HS_ANY ), +PHY_TRSV_REG_CFG_AUTOV9 (0x03c ,0x7f ,PWR_MODE_HS_ANY ), +PHY_TRSV_REG_CFG_AUTOV9 (0x048 ,0xc0 ,PWR_MODE_HS_ANY ), -PHY_TRSV_REG_CFG (0x04a ,0x00 ,PWR_MODE_HS_G3_SER_B ), -PHY_TRSV_REG_CFG (0x04b ,0x10 ,PWR_MODE_HS_G1_SER_B | -PWR_MODE_HS_G3_SER_B ), -PHY_TRSV_REG_CFG (0x04d ,0x63 ,PWR_MODE_HS_G3_SER_B ), +PHY_TRSV_REG_CFG_AUTOV9 (0x04a ,0x00 ,PWR_MODE_HS_G3_SER_B ), +PHY_TRSV_REG_CFG_AUTOV9 (0x04b ,0x10 ,PWR_MODE_HS_G1_SER_B | +PWR_MODE_HS_G3_SER_B ), +PHY_TRSV_REG_CFG_AUTOV9 (0x04d ,0x63 ,PWR_MODE_HS_G3_SER_B ),END_UFS_PHY_CFG , };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 560/1095 PCI: microchip: Fix refcount leak in mc_pcie_init_irq_domains()
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit f030304fdeb87ec8f1b518c73703214aec6cc24a ]
of_get_next_child() returns a node pointer with refcount incremented, so we should use of_node_put() on it when we don't need it anymore.
mc_pcie_init_irq_domains() only calls of_node_put() in the normal path, missing it in some error paths. Add missing of_node_put() to avoid refcount leak.
--- drivers/pci/controller/pcie-microchip-host.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/pci/controller/pcie-microchip-host.c +2 -0
@@ -904,6 +904,7 @@ static int mc_pcie_init_irq_domains(struct mc_pcie *port) &event_domain_ops, port);if (!port->event_domain) {dev_err (dev,"failed to get event domain\n" ); +of_node_put (pcie_intc_node);return -ENOMEM ; }
@@ -913,6 +914,7 @@ static int mc_pcie_init_irq_domains(struct mc_pcie *port) &intx_domain_ops, port);if (!port->intx_domain) {dev_err (dev,"failed to get an INTx IRQ domain\n" ); +of_node_put (pcie_intc_node);return -ENOMEM ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 561/1095 PCI: tegra194: Fix PM error handling in tegra_pcie_config_ep()
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit e8fbd344a5ea62663554b8546b6bf9f88b93785a ]
pm_runtime_enable() will increase power disable depth. If dw_pcie_ep_init() fails, we should use pm_runtime_disable() to balance it with pm_runtime_enable().
Add missing pm_runtime_disable() for tegra_pcie_config_ep().
--- drivers/pci/controller/dwc/pcie-tegra194.c | 1 + 1 file changed, 1 insertion(+)
drivers/pci/controller/dwc/pcie-tegra194.c +1 -0
@@ -1951,6 +1951,7 @@ static int tegra_pcie_config_ep(struct tegra194_pcie *pcie,if (ret) {dev_err (dev,"Failed to initialize DWC Endpoint subsystem: %d\n" , ret); +pm_runtime_disable (dev);return ret; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 562/1095 HID: cp2112: prevent a buffer overflow in cp2112_xfer()
In reply to Greg Kroah-HartmanFrom: Harshit Mogalapalli <[email protected]>
[ Upstream commit 381583845d19cb4bd21c8193449385f3fefa9caf ]
Smatch warnings:drivers/hid/hid-cp2112.c:793 cp2112_xfer() error: __memcpy() 'data->block[1]' too small (33 vs 255) drivers/hid/hid-cp2112.c:793 cp2112_xfer() error: __memcpy() 'buf' too small (64 vs 255)
The 'read_length' variable is provided by 'data->block[0]' which comes from user and it(read_length) can take a value between 0-255. Add an upper bound to 'read_length' variable to prevent a buffer overflow in memcpy().
--- drivers/hid/hid-cp2112.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/hid/hid-cp2112.c +5 -0
@@ -790,6 +790,11 @@ static int cp2112_xfer(struct i2c_adapter *adap, u16 addr, data->word =le16_to_cpup ((__le16 *)buf);break ;case I2C_SMBUS_I2C_BLOCK_DATA : +if (read_length >I2C_SMBUS_BLOCK_MAX ) { + ret = -EINVAL ; + goto power_normal; + } +memcpy (data->block +1 , buf, read_length);break ;case I2C_SMBUS_BLOCK_DATA :
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 563/1095 mtd: sm_ftl: Fix deadlock caused by cancel_work_sync in sm_release
In reply to Greg Kroah-HartmanFrom: Duoming Zhou <[email protected]>
[ Upstream commit a61528d997619a518ee8c51cf0ef0513021afaff ]
There is a deadlock between sm_release and sm_cache_flush_work which is a work item. The cancel_work_sync in sm_release will not return until sm_cache_flush_work is finished. If we hold mutex_lock and use cancel_work_sync to wait the work item to finish, the work item also requires mutex_lock. As a result, the sm_release will be blocked forever. The race condition is shown below:
(Thread 1) | (Thread 2)
sm_release |
mutex_lock(&ftl->mutex) | sm_cache_flush_work
| mutex_lock(&ftl->mutex)
cancel_work_sync | ...This patch moves del_timer_sync and cancel_work_sync out of mutex_lock in order to mitigate deadlock.
--- drivers/mtd/sm_ftl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/sm_ftl.c +1 -1
@@ -1111,9 +1111,9 @@ static void sm_release(struct mtd_blktrans_dev *dev) {struct sm_ftl *ftl = dev->priv; -mutex_lock (&ftl->mutex);del_timer_sync (&ftl->timer);cancel_work_sync (&ftl->flush_work); +mutex_lock (&ftl->mutex);sm_cache_flush (ftl);mutex_unlock (&ftl->mutex); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 564/1095 mtd: partitions: Fix refcount leak in parse_redboot_of
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit 9f7e62815cf3cbbcb1b8cb21649fb4dfdb3aa016 ]
of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
--- drivers/mtd/parsers/redboot.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/parsers/redboot.c +1 -0
@@ -58,6 +58,7 @@ static void parse_redboot_of(struct mtd_info *master)return ; ret =of_property_read_u32 (npart,"fis-index-block" , &dirblock); +of_node_put (npart);if (ret)return ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 565/1095 mtd: parsers: ofpart: Fix refcount leak in bcm4908_partitions_fw_offset
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit e607879b0da18c451de5e91daf239cc2f2f8ff2d ]
of_find_node_by_path() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
--- drivers/mtd/parsers/ofpart_bcm4908.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/mtd/parsers/ofpart_bcm4908.c +3 -0
@@ -35,12 +35,15 @@ static long long bcm4908_partitions_fw_offset(void) err =kstrtoul (s + len +1 ,0 , &offset);if (err) {pr_err ("failed to parse %s\n" , s + len +1 ); +of_node_put (root);return err; } +of_node_put (root);return offset <<10 ; } +of_node_put (root);return -ENOENT ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 566/1095 mtd: st_spi_fsm: Add a clk_disable_unprepare() in .probe()s error path
In reply to Greg Kroah-HartmanFrom: Uwe Kleine-König <[email protected]>
[ Upstream commit 28607b426c3d050714f250d0faeb99d2e9106e90 ]
For all but one error path clk_disable_unprepare() is already there. Add it to the one location where it's missing.
--- drivers/mtd/devices/st_spi_fsm.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/mtd/devices/st_spi_fsm.c +5 -3
@@ -2115,10 +2115,12 @@ static int stfsm_probe(struct platform_device *pdev) (long long )fsm->mtd.size, (long long )(fsm->mtd.size >>20 ), fsm->mtd.erasesize, (fsm->mtd.erasesize >> 10)); -return mtd_device_register (&fsm->mtd,NULL ,0 ); - + ret =mtd_device_register (&fsm->mtd,NULL ,0 ); +if (ret) { err_clk_unprepare: -clk_disable_unprepare (fsm->clk); +clk_disable_unprepare (fsm->clk); + } +return ret; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 567/1095 PCI: mediatek-gen3: Fix refcount leak in mtk_pcie_init_irq_domains()
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit bf038503d5fe90189743124233fe7aeb0984e961 ]
of_get_child_by_name() returns a node pointer with refcount incremented, so we should use of_node_put() on it when we don't need it anymore.
Add missing of_node_put() to avoid refcount leak.
--- drivers/pci/controller/pcie-mediatek-gen3.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/pci/controller/pcie-mediatek-gen3.c +5 -2
@@ -600,7 +600,8 @@ static int mtk_pcie_init_irq_domains(struct mtk_gen3_pcie *pcie) &intx_domain_ops, pcie);if (!pcie->intx_domain) {dev_err (dev,"failed to create INTx IRQ domain\n" ); -return -ENODEV ; + ret = -ENODEV ; + goto out_put_node; }/* Setup MSI */
@@ -623,13 +624,15 @@ static int mtk_pcie_init_irq_domains(struct mtk_gen3_pcie *pcie) goto err_msi_domain; } +of_node_put (intc_node);return 0 ; err_msi_domain:irq_domain_remove (pcie->msi_bottom_domain); err_msi_bottom_domain:irq_domain_remove (pcie->intx_domain); - +out_put_node: +of_node_put (intc_node);return ret; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 568/1095 fpga: altera-pr-ip: fix unsigned comparison with less than zero
In reply to Greg Kroah-HartmanFrom: Marco Pagani <[email protected]>
[ Upstream commit 2df84a757d87fd62869fc401119d429735377ec5 ]
Fix the "comparison with less than zero" warning reported by cppcheck for the unsigned (size_t) parameter count of the alt_pr_fpga_write() function.
--- drivers/fpga/altera-pr-ip-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/fpga/altera-pr-ip-core.c +1 -1
@@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,u32 *buffer_32 = (u32 *)buf;size_t i =0 ; -if (count <=0 ) +if (!count)return -EINVAL ;/* Write out the complete 32-bit chunks */
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 569/1095 usb: host: Fix refcount leak in ehci_hcd_ppc_of_probe
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit b5c5b13cb45e2c88181308186b0001992cb41954 ]
of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak.
--- drivers/usb/host/ehci-ppc-of.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/host/ehci-ppc-of.c +1 -0
@@ -148,6 +148,7 @@ static int ehci_hcd_ppc_of_probe(struct platform_device *op) }else { ehci->has_amcc_usb23 =1 ; } +of_node_put (np); }if (of_get_property (dn,"big-endian" ,NULL )) {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 570/1095 usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit 302970b4cad3ebfda2c05ce06c322ccdc447d17e ]
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
--- drivers/usb/host/ohci-nxp.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/host/ohci-nxp.c +1 -0
@@ -164,6 +164,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev) } isp1301_i2c_client =isp1301_get_client (isp1301_node); +of_node_put (isp1301_node);if (!isp1301_i2c_client)return -EPROBE_DEFER ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 571/1095 usb: gadget: tegra-xudc: Fix error check in tegra_xudc_powerdomain_init()
In reply to Greg Kroah-HartmanFrom: Tang Bin <[email protected]>
[ Upstream commit f08aa7c80dac27ee00fa6827f447597d2fba5465 ]
dev_pm_domain_attach_by_name() may return NULL in some cases, so IS_ERR() doesn't meet the requirements. Thus fix it.
--- drivers/usb/gadget/udc/tegra-xudc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/usb/gadget/udc/tegra-xudc.c +4 -4
@@ -3691,15 +3691,15 @@ static int tegra_xudc_powerdomain_init(struct tegra_xudc *xudc)int err; xudc->genpd_dev_device =dev_pm_domain_attach_by_name (dev,"dev" ); -if (IS_ERR (xudc->genpd_dev_device)) { - err =PTR_ERR (xudc->genpd_dev_device); +if (IS_ERR_OR_NULL (xudc->genpd_dev_device)) { + err =PTR_ERR (xudc->genpd_dev_device) ? : -ENODATA ;dev_err (dev,"failed to get device power domain: %d\n" , err);return err; } xudc->genpd_dev_ss =dev_pm_domain_attach_by_name (dev,"ss" ); -if (IS_ERR (xudc->genpd_dev_ss)) { - err =PTR_ERR (xudc->genpd_dev_ss); +if (IS_ERR_OR_NULL (xudc->genpd_dev_ss)) { + err =PTR_ERR (xudc->genpd_dev_ss) ? : -ENODATA ;dev_err (dev,"failed to get SuperSpeed power domain: %d\n" , err);return err; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 572/1095 usb: xhci: tegra: Fix error check
In reply to Greg Kroah-HartmanFrom: Tang Bin <[email protected]>
[ Upstream commit 18fc7c435be3f17ea26a21b2e2312fcb9088e01f ]
In the function tegra_xusb_powerdomain_init(), dev_pm_domain_attach_by_name() may return NULL in some cases, so IS_ERR() doesn't meet the requirements. Thus fix it.
--- drivers/usb/host/xhci-tegra.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/usb/host/xhci-tegra.c +4 -4
@@ -1010,15 +1010,15 @@ static int tegra_xusb_powerdomain_init(struct device *dev,int err; tegra->genpd_dev_host =dev_pm_domain_attach_by_name (dev,"xusb_host" ); -if (IS_ERR (tegra->genpd_dev_host)) { - err =PTR_ERR (tegra->genpd_dev_host); +if (IS_ERR_OR_NULL (tegra->genpd_dev_host)) { + err =PTR_ERR (tegra->genpd_dev_host) ? : -ENODATA ;dev_err (dev,"failed to get host pm-domain: %d\n" , err);return err; } tegra->genpd_dev_ss =dev_pm_domain_attach_by_name (dev,"xusb_ss" ); -if (IS_ERR (tegra->genpd_dev_ss)) { - err =PTR_ERR (tegra->genpd_dev_ss); +if (IS_ERR_OR_NULL (tegra->genpd_dev_ss)) { + err =PTR_ERR (tegra->genpd_dev_ss) ? : -ENODATA ;dev_err (dev,"failed to get superspeed pm-domain: %d\n" , err);return err; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 573/1095 netfilter: xtables: Bring SPDX identifier back
In reply to Greg Kroah-HartmanFrom: Thomas Gleixner <[email protected]>
[ Upstream commit 20646f5b1e798bcc20044ae90ac3702f177bf254 ]
Commit e2be04c7f995 ("License cleanup: add SPDX license identifier to uapi header files with a license") added the correct SPDX identifier to include/uapi/linux/netfilter/xt_IDLETIMER.h.
A subsequent commit removed it for no reason and reintroduced the UAPI license incorrectness as the file is now missing the UAPI exception again.
Add it back and remove the GPLv2 boilerplate while at it.
--- include/uapi/linux/netfilter/xt_IDLETIMER.h | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-)
include/uapi/linux/netfilter/xt_IDLETIMER.h +1 -16
@@ -1,6 +1,5 @@ +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */ /* -* linux/include/linux/netfilter/xt_IDLETIMER.h -* * Header file for Xtables timer target module. * * Copyright (C) 2004, 2010 Nokia Corporation
@@ -10,20 +9,6 @@* by Luciano Coelho <[email protected]> * * Contact: Luciano Coelho <[email protected]> -* -* This program is free software; you can redistribute it and/or -* modify it under the terms of the GNU General Public License -* version 2 as published by the Free Software Foundation. -* -* This program is distributed in the hope that it will be useful, but -* WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -* General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA -* 02110-1301 USA */ #ifndef _XT_IDLETIMER_H
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 574/1095 scsi: qla2xxx: edif: Send LOGO for unexpected IKE message
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit 2b659ed67a12f39f56d8dcad9b5d5a74d67c01b3 ]
If the session is down and the local port continues to receive AUTH ELS messages, the driver needs to send back LOGO so that the remote device knows to tear down its session. Terminate and clean up the AUTH ELS exchange followed by a passthrough LOGO.
--- drivers/scsi/qla2xxx/qla_edif.c | 19 +++++++++++++++++-- drivers/scsi/qla2xxx/qla_fw.h | 2 +- 2 files changed, 18 insertions(+), 3 deletions(-)
drivers/scsi/qla2xxx/qla_edif.c +17 -2
@@ -2644,8 +2644,7 @@ void qla24xx_auth_els(scsi_qla_host_t *vha, void **pkt, struct rsp_que **rsp) fcport =qla2x00_find_fcport_by_pid (host, &purex->pur_info.pur_sid); -if (DBELL_INACTIVE (vha) || - (fcport &&EDIF_SESSION_DOWN (fcport))) { +if (DBELL_INACTIVE (vha)) {ql_dbg (ql_dbg_edif, host,0x0910c ,"%s e_dbell.db_flags =%x %06x\n" , __func__, host->e_dbell.db_flags, fcport ? fcport->d_id.b24 :0 );
@@ -2655,6 +2654,22 @@ void qla24xx_auth_els(scsi_qla_host_t *vha, void **pkt, struct rsp_que **rsp)return ; } +if (fcport &&EDIF_SESSION_DOWN (fcport)) { +ql_dbg (ql_dbg_edif, host,0x13b6 , +"%s terminate exchange. Send logo to 0x%x\n" , + __func__, a.did.b24); + + a.tx_byte_count = a.tx_len =0 ; + a.tx_addr =0 ; + a.control_flags =EPD_RX_XCHG ;/* EPD_RX_XCHG = terminate cmd */ +qla_els_reject_iocb (host, (*rsp)->qpair, &a); +qla_enode_free (host, ptr); +/* send logo to let remote port knows to tear down session */ + fcport->send_els_logo =1 ; +qlt_schedule_sess_for_deletion (fcport); +return ; + } +/* add the local enode to the list */ qla_enode_add (host, ptr);
drivers/scsi/qla2xxx/qla_fw.h +1 -1
@@ -807,7 +807,7 @@ struct els_entry_24xx {#define EPD_ELS_COMMAND (0 << 13)#define EPD_ELS_ACC (1 << 13)#define EPD_ELS_RJT (2 << 13) -#define EPD_RX_XCHG (3 << 13) +#define EPD_RX_XCHG (3 << 13)/* terminate exchange */ #define ECF_CLR_PASSTHRU_PEND BIT_12#define ECF_INCL_FRAME_HDR BIT_11#define ECF_SEC_LOGIN BIT_3
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 575/1095 scsi: qla2xxx: edif: Reduce disruption due to multiple app start
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit 0dbfce5255fe8d069a1a3b712a25b263264cfa58 ]
Multiple app start can trigger a session bounce. Make driver skip over session teardown if app start is seen more than once.
--- drivers/scsi/qla2xxx/qla_edif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_edif.c +2 -2
@@ -510,8 +510,7 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job)/* mark doorbell as active since an app is now present */ vha->e_dbell.db_flags |=EDB_ACTIVE ; }else { -ql_dbg (ql_dbg_edif, vha,0x911e ,"%s doorbell already active\n" , - __func__); + goto out; }if (N2N_TOPO (vha->hw)) {
@@ -578,6 +577,7 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job) __func__); } +out: appreply.host_support_edif = vha->hw->flags.edif_enabled; appreply.edif_enode_active = vha->pur_cinfo.enode_flags; appreply.edif_edb_active = vha->e_dbell.db_flags;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 576/1095 scsi: qla2xxx: edif: Fix no login after app start
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit 24c796098f5395477f7f7ebf8e24f3f08a139f71 ]
The scenario is this: User loaded driver but has not started authentication app. All sessions to secure device will exhaust all login attempts, fail, and in stay in deleted state. Then some time later the app is started. The driver will replenish the login retry count, trigger delete to prepare for secure login. After deletion, relogin is triggered.
For the session that is already deleted, the delete trigger is a no-op. If none of the sessions trigger a relogin, no progress is made.
Add a relogin trigger.
--- drivers/scsi/qla2xxx/qla_edif.c | 1 + 1 file changed, 1 insertion(+)
drivers/scsi/qla2xxx/qla_edif.c +1 -0
@@ -567,6 +567,7 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job)qlt_schedule_sess_for_deletion (fcport);qla_edif_sa_ctl_init (vha, fcport); } +set_bit (RELOGIN_NEEDED , &vha->dpc_flags); }if (vha->pur_cinfo.enode_flags !=ENODE_ACTIVE ) {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 577/1095 scsi: qla2xxx: edif: Tear down session if keys have been removed
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit d7e2e4a68fc047a025afcd200e6b7e1fbc8b1999 ]
If all keys for a session have been deleted, trigger a session teardown.
--- drivers/scsi/qla2xxx/qla_def.h | 5 +++++ drivers/scsi/qla2xxx/qla_isr.c | 1 + 2 files changed, 6 insertions(+)
drivers/scsi/qla2xxx/qla_def.h +5 -0
@@ -2158,6 +2158,11 @@ typedef struct {#define CS_IOCB_ERROR 0x31/* Generic error for IOCB request failure */ #define CS_REJECT_RECEIVED 0x4E/* Reject received */ +#define CS_EDIF_AUTH_ERROR 0x63/* decrypt error */ +#define CS_EDIF_PAD_LEN_ERROR 0x65/* pad > frame size, not 4byte align */ +#define CS_EDIF_INV_REQ 0x66/* invalid request */ +#define CS_EDIF_SPI_ERROR 0x67/* rx frame unable to locate sa */ +#define CS_EDIF_HDR_ERROR 0x69/* data frame != expected len */ #define CS_BAD_PAYLOAD 0x80/* Driver defined */ #define CS_UNKNOWN 0x81/* Driver defined */ #define CS_RETRY 0x82/* Driver defined */
drivers/scsi/qla2xxx/qla_isr.c +1 -0
@@ -3424,6 +3424,7 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)case CS_PORT_UNAVAILABLE :case CS_TIMEOUT :case CS_RESET : +case CS_EDIF_INV_REQ :/* * We are going to have the fc class block the rport
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 578/1095 scsi: qla2xxx: edif: Fix session thrash
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit a8fdfb0b39c2b31722c70bdf2272b949d5af4b7b ]
Current code prematurely sends out PRLI before authentication application has given the OK to do so. This causes PRLI failure and session teardown.
Prevents PRLI from going out before authentication app gives the OK.
--- drivers/scsi/qla2xxx/qla_edif.c | 2 +- drivers/scsi/qla2xxx/qla_edif.h | 4 ++++ drivers/scsi/qla2xxx/qla_init.c | 10 +++++++++- 3 files changed, 14 insertions(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_edif.c +1 -1
@@ -3589,7 +3589,7 @@ int qla_edif_process_els(scsi_qla_host_t *vha, struct bsg_job *bsg_job)if (qla_bsg_check (vha, bsg_job, fcport))return 0 ; -if (fcport->loop_id ==FC_NO_LOOP_ID ) { +if (EDIF_SESS_DELETE (fcport)) {ql_dbg (ql_dbg_edif, vha,0x910d ,"%s ELS code %x, no loop id.\n" , __func__, bsg_request->rqst_data.r_els.els_code);
drivers/scsi/qla2xxx/qla_edif.h +4 -0
@@ -141,4 +141,8 @@ struct enode { (DBELL_ACTIVE (_fcport->vha) && \ (_fcport->disc_state == DSC_LOGIN_AUTH_PEND)) +#define EDIF_SESS_DELETE (_s) \ + (qla_ini_mode_enabled(_s->vha) && (_s->disc_state == DSC_DELETE_PEND || \ + _s->disc_state == DSC_DELETED)) +#endif /* __QLA_EDIF_H */
drivers/scsi/qla2xxx/qla_init.c +9 -1
@@ -1762,8 +1762,16 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport)break ;case DSC_LOGIN_PEND : -if (fcport->fw_login_state ==DSC_LS_PLOGI_COMP ) +if (vha->hw->flags.edif_enabled) +break ; + +if (fcport->fw_login_state ==DSC_LS_PLOGI_COMP ) { +ql_dbg (ql_dbg_disc, vha,0x2118 , +"%s %d %8phC post %s PRLI\n" , + __func__, __LINE__, fcport->port_name, +NVME_TARGET (vha->hw, fcport) ?"NVME" :"FC" );qla24xx_post_prli_work (vha, fcport); + }break ;case DSC_UPD_FCPORT :
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 579/1095 scsi: qla2xxx: edif: Fix no logout on delete for N2N
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit ec538eb838f334453b10e7e9b260f0c358018a37 ]
The driver failed to send implicit logout on session delete. For edif, this failed to flush any lingering SA index in FW.
Set a flag to turn on implicit logout early in the session recovery to make sure the logout will go out in case of error.
--- drivers/scsi/qla2xxx/qla_iocb.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/scsi/qla2xxx/qla_iocb.c +3 -0
@@ -2882,6 +2882,9 @@ static void qla2x00_els_dcmd2_sp_done(srb_t *sp, int res) sp->name, res, sp->handle, fcport->d_id.b24, fcport->port_name); fcport->flags &= ~(FCF_ASYNC_SENT |FCF_ASYNC_ACTIVE ); +/* For edif, set logout on delete to ensure any residual key from FW is flushed.*/ + fcport->logout_on_delete =1 ; + fcport->chip_reset = vha->hw->base_qpair->chip_reset;if (sp->flags &SRB_WAKEUP_ON_COMP )complete (&lio->u.els_plogi.comp);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 580/1095 scsi: qla2xxx: edif: Reduce N2N thrashing at app_start time
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit 37be3f9d6993a721bc019f03c97ea0fe66319997 ]
For N2N + remote WWPN is bigger than local adapter, remote adapter will login to local adapter while authentication application is not running. When authentication application starts, the current session in FW needs to to be invalidated.
Make sure the old session is torn down before triggering a relogin.
--- drivers/scsi/qla2xxx/qla_edif.c | 47 ++++++++++++++++++++++++--------- 1 file changed, 34 insertions(+), 13 deletions(-)
drivers/scsi/qla2xxx/qla_edif.c +34 -13
@@ -517,11 +517,28 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job)list_for_each_entry_safe (fcport, tf, &vha->vp_fcports, list) fcport->n2n_link_reset_cnt =0 ; -if (vha->hw->flags.n2n_fw_acc_sec) -set_bit (N2N_LINK_RESET , &vha->dpc_flags); -else +if (vha->hw->flags.n2n_fw_acc_sec) { +list_for_each_entry_safe (fcport, tf, &vha->vp_fcports, list) +qla_edif_sa_ctl_init (vha, fcport); + +/* +* While authentication app was not running, remote device +* could still try to login with this local port. Let's +* clear the state and try again. +*/ +qla2x00_wait_for_sess_deletion (vha); + +/* bounce the link to get the other guy to relogin */ +if (!vha->hw->flags.n2n_bigger) { +set_bit (N2N_LINK_RESET , &vha->dpc_flags); +qla2xxx_wake_dpc (vha); + } + }else { +qla2x00_wait_for_hba_online (vha);set_bit (ISP_ABORT_NEEDED , &vha->dpc_flags); -qla2xxx_wake_dpc (vha); +qla2xxx_wake_dpc (vha); +qla2x00_wait_for_hba_online (vha); + } }else {list_for_each_entry_safe (fcport, tf, &vha->vp_fcports, list) { ql_dbg(ql_dbg_edif, vha, 0x2058,
@@ -921,17 +938,21 @@ qla_edif_app_getfcinfo(scsi_qla_host_t *vha, struct bsg_job *bsg_job)if (tdid.b24 !=0 && tdid.b24 != fcport->d_id.b24)continue ; -if (fcport->scan_state !=QLA_FCPORT_FOUND ) -continue ; +if (!N2N_TOPO (vha->hw)) { +if (fcport->scan_state !=QLA_FCPORT_FOUND ) +continue ; -if (fcport->port_type ==FCT_UNKNOWN && !fcport->fc4_features) - rval =qla24xx_async_gffid (vha, fcport, true); +if (fcport->port_type ==FCT_UNKNOWN && + !fcport->fc4_features) + rval =qla24xx_async_gffid (vha, fcport, + true); -if (!rval && - !(fcport->fc4_features &FC4_FF_TARGET || - fcport->port_type & - (FCT_TARGET |FCT_NVME_TARGET ))) -continue ; +if (!rval && + !(fcport->fc4_features &FC4_FF_TARGET || + fcport->port_type & + (FCT_TARGET |FCT_NVME_TARGET ))) +continue ; + } rval =0 ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 581/1095 iio: accel: bma400: Fix the scale min and max macro values
In reply to Greg Kroah-HartmanFrom: Jagath Jog J <[email protected]>
[ Upstream commit 747c7cf1592e226d40543231b26502b332d0ea2f ]
Changing the scale macro values to match the bma400 sensitivity for 1 LSB of all the available ranges.
--- drivers/iio/accel/bma400.h | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-)
drivers/iio/accel/bma400.h +21 -2
@@ -83,8 +83,27 @@#define BMA400_ACC_ODR_MIN_WHOLE_HZ 25#define BMA400_ACC_ODR_MIN_HZ 12 -#define BMA400_SCALE_MIN 38357 -#define BMA400_SCALE_MAX 306864 +/* +* BMA400_SCALE_MIN macro value represents m/s^2 for 1 LSB before +* converting to micro values for +-2g range. +* +* For +-2g - 1 LSB = 0.976562 milli g = 0.009576 m/s^2 +* For +-4g - 1 LSB = 1.953125 milli g = 0.019153 m/s^2 +* For +-16g - 1 LSB = 7.8125 milli g = 0.076614 m/s^2 +* +* The raw value which is used to select the different ranges is determined +* by the first bit set position from the scale value, so BMA400_SCALE_MIN +* should be odd. +* +* Scale values for +-2g, +-4g, +-8g and +-16g are populated into bma400_scales +* array by left shifting BMA400_SCALE_MIN. +* e.g.: +* To select +-2g = 9577 << 0 = raw value to write is 0. +* To select +-8g = 9577 << 2 = raw value to write is 2. +* To select +-16g = 9577 << 3 = raw value to write is 3. +*/ +#define BMA400_SCALE_MIN 9577 +#define BMA400_SCALE_MAX 76617#define BMA400_NUM_REGULATORS 2#define BMA400_VDD_REGULATOR 0
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 582/1095 platform/chrome: cros_ec: Always expose last resume result
In reply to Greg Kroah-HartmanFrom: Stephen Boyd <[email protected]>
[ Upstream commit 74bb746407bf0d7c7d126c7731dbcd66d467619b ]
The last resume result exposing logic in cros_ec_sleep_event() incorrectly requires S0ix support, which doesn't work on ARM based systems where S0ix doesn't exist. That's because cros_ec_sleep_event() only reports the last resume result when the EC indicates the last sleep event was an S0ix resume. On ARM systems, the last sleep event is always S3 resume, but the EC can still detect sleep hang events in case some other part of the AP is blocking sleep.
Always expose the last resume result if the EC supports it so that this works on all devices regardless of S0ix support. This fixes sleep hang detection on ARM based chromebooks like Trogdor.
--- drivers/platform/chrome/cros_ec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/platform/chrome/cros_ec.c +4 -4
@@ -135,16 +135,16 @@ static int cros_ec_sleep_event(struct cros_ec_device *ec_dev, u8 sleep_event) buf.msg.command =EC_CMD_HOST_SLEEP_EVENT ; ret =cros_ec_cmd_xfer_status (ec_dev, &buf.msg); - -/* For now, report failure to transition to S0ix with a warning. */ +/* Report failure to transition to system wide suspend with a warning. */ if (ret >=0 && ec_dev->host_sleep_v1 && - (sleep_event ==HOST_SLEEP_EVENT_S0IX_RESUME )) { + (sleep_event ==HOST_SLEEP_EVENT_S0IX_RESUME || + sleep_event ==HOST_SLEEP_EVENT_S3_RESUME )) { ec_dev->last_resume_result = buf.u.resp1.resume_response.sleep_transitions;WARN_ONCE (buf.u.resp1.resume_response.sleep_transitions &EC_HOST_RESUME_SLEEP_TIMEOUT , -"EC detected sleep transition timeout. Total slp_s0 transitions: %d" , +"EC detected sleep transition timeout. Total sleep transitions: %d" , buf.u.resp1.resume_response.sleep_transitions &EC_HOST_RESUME_SLEEP_TRANSITIONS_MASK ); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 583/1095 iio: sx9324: Fix register field spelling
In reply to Greg Kroah-HartmanFrom: Gwendal Grignou <[email protected]>
[ Upstream commit 0b24034c7ffa20bcfb4fdfece1df770ec5b0a634 ]
Field for PROX_CTRL4 should contain PROX_CTRL4.
--- drivers/iio/proximity/sx9324.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/proximity/sx9324.c +2 -2
@@ -93,7 +93,7 @@#define SX9324_REG_PROX_CTRL4_AVGNEGFILT_MASK GENMASK(5, 3)#define SX9324_REG_PROX_CTRL4_AVGNEG_FILT_2 0x08#define SX9324_REG_PROX_CTRL4_AVGPOSFILT_MASK GENMASK(2, 0) -#define SX9324_REG_PROX_CTRL3_AVGPOS_FILT_256 0x04 +#define SX9324_REG_PROX_CTRL4_AVGPOS_FILT_256 0x04#define SX9324_REG_PROX_CTRL5 0x35#define SX9324_REG_PROX_CTRL5_HYST_MASK GENMASK(5, 4)#define SX9324_REG_PROX_CTRL5_CLOSE_DEBOUNCE_MASK GENMASK(3, 2)
@@ -810,7 +810,7 @@ static const struct sx_common_reg_default sx9324_default_regs[] = { {SX9324_REG_PROX_CTRL3 ,SX9324_REG_PROX_CTRL3_AVGDEB_2SAMPLES | SX9324_REG_PROX_CTRL3_AVGPOS_THRESH_16K }, { SX9324_REG_PROX_CTRL4, SX9324_REG_PROX_CTRL4_AVGNEG_FILT_2 | - SX9324_REG_PROX_CTRL3_AVGPOS_FILT_256 }, + SX9324_REG_PROX_CTRL4_AVGPOS_FILT_256 }, { SX9324_REG_PROX_CTRL5, 0x00 }, { SX9324_REG_PROX_CTRL6, SX9324_REG_PROX_CTRL6_PROXTHRESH_32 }, { SX9324_REG_PROX_CTRL7, SX9324_REG_PROX_CTRL6_PROXTHRESH_32 },
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 584/1095 iio: accel: bma400: Reordering of header files
In reply to Greg Kroah-HartmanFrom: Jagath Jog J <[email protected]>
[ Upstream commit 1bd2dc6ea863690aee5c45ebf09c9194c7a42c0d ]
Reordering of header files and removing the iio/sysfs.h since custom attributes are not being used in the driver.
--- drivers/iio/accel/bma400_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/accel/bma400_core.c +2 -2
@@ -13,14 +13,14 @@#include <linux/bitops.h> #include <linux/device.h> -#include <linux/iio/iio.h> -#include <linux/iio/sysfs.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/mutex.h> #include <linux/regmap.h> #include <linux/regulator/consumer.h> +#include <linux/iio/iio.h> +#include "bma400.h" /*
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 585/1095 iio: accel: bma400: conversion to device-managed function
In reply to Greg Kroah-HartmanFrom: Jagath Jog J <[email protected]>
[ Upstream commit 12c99f859fd3da5fc8f8491826e7023001f54821 ]
This is a conversion to device-managed by using devm_iio_device_register() inside probe function. Previously the bma400 was not put into power down mode in some error paths in probe where it now is, but that should cause no harm.
The dev_set_drvdata() call, bma400_remove() function and hooks in the I2C and SPI driver struct is removed as devm_iio_device_register() function is used to automatically unregister on driver detach.
--- drivers/iio/accel/bma400.h | 2 - drivers/iio/accel/bma400_core.c | 77 ++++++++++++++++----------------- drivers/iio/accel/bma400_i2c.c | 8 ---- drivers/iio/accel/bma400_spi.c | 6 --- 4 files changed, 38 insertions(+), 55 deletions(-)
drivers/iio/accel/bma400.h +0 -2
@@ -113,6 +113,4 @@ extern const struct regmap_config bma400_regmap_config;int bma400_probe (struct device *dev,struct regmap *regmap,const char *name); -void bma400_remove (struct device *dev); -#endif
drivers/iio/accel/bma400_core.c +38 -39
147 lines not on this page · raw message
drivers/iio/accel/bma400_i2c.c +0 -8
@@ -27,13 +27,6 @@ static int bma400_i2c_probe(struct i2c_client *client,return bma400_probe (&client->dev, regmap, id->name); } -static int bma400_i2c_remove (struct i2c_client *client) -{ -bma400_remove (&client->dev); - -return 0 ; -} -static const struct i2c_device_id bma400_i2c_ids[] = { {"bma400" ,0 }, { }
@@ -52,7 +45,6 @@ static struct i2c_driver bma400_i2c_driver = { .of_match_table = bma400_of_i2c_match, }, .probe = bma400_i2c_probe, - .remove = bma400_i2c_remove, .id_table = bma400_i2c_ids, };
drivers/iio/accel/bma400_spi.c +0 -6
@@ -87,11 +87,6 @@ static int bma400_spi_probe(struct spi_device *spi)return bma400_probe (&spi->dev, regmap, id->name); } -static void bma400_spi_remove (struct spi_device *spi) -{ -bma400_remove (&spi->dev); -} -static const struct spi_device_id bma400_spi_ids[] = { {"bma400" ,0 }, { }
@@ -110,7 +105,6 @@ static struct spi_driver bma400_spi_driver = { .of_match_table = bma400_of_spi_match, }, .probe = bma400_spi_probe, - .remove = bma400_spi_remove, .id_table = bma400_spi_ids, };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 586/1095 iio: core: Fix IIO_ALIGN and rename as it was not sufficiently large
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 12c4efe3509b8018e76ea3ebda8227cb53bf5887 ]
Discussion of the series:
https://lore.kernel.org/all/[email protected]/
mm, arm64: Reduce ARCH_KMALLOC_MINALIGN brought to my attention that our current IIO usage of L1CACHE_ALIGN is insufficient as their are Arm platforms out their with non coherent DMA and larger cache lines at at higher levels of their cache hierarchy.
Rename the define to make it's purpose more explicit. It will be used much more widely going forwards (to replace incorrect ____cacheline_aligned markings.
Note this patch will greatly reduce the padding on some architectures that have smaller requirements for DMA safe buffers.
The history of changing values of ARCH_KMALLOC_MINALIGN via ARCH_DMA_MINALIGN on arm64 is rather complex. I'm not tagging this as fixing a particular patch from that route as it's not clear what to tag.
Most recently a change to bring them back inline was reverted because of some Qualcomm Kryo cores with an L2 cache with 128-byte lines sitting above the point of coherency.
c1132702c71f Revert "arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)" That reverts:65688d2a05de arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES) which refers to the change originally being motivated by Thunder x1 performance rather than correctness.
--- drivers/iio/adc/adi-axi-adc.c | 7 ++++--- drivers/iio/industrialio-core.c | 4 ++-- include/linux/iio/iio.h | 10 ++++++++-- 3 files changed, 14 insertions(+), 7 deletions(-)
drivers/iio/adc/adi-axi-adc.c +4 -3
@@ -84,7 +84,8 @@ void *adi_axi_adc_conv_priv(struct adi_axi_adc_conv *conv) {struct adi_axi_adc_client *cl =conv_to_client (conv); -return (char *)cl +ALIGN (sizeof (struct adi_axi_adc_client ),IIO_ALIGN ); +return (char *)cl +ALIGN (sizeof (struct adi_axi_adc_client ), +IIO_DMA_MINALIGN ); }EXPORT_SYMBOL_GPL (adi_axi_adc_conv_priv);
@@ -169,9 +170,9 @@ static struct adi_axi_adc_conv *adi_axi_adc_conv_register(struct device *dev,struct adi_axi_adc_client *cl;size_t alloc_size; - alloc_size =ALIGN (sizeof (struct adi_axi_adc_client ),IIO_ALIGN ); + alloc_size =ALIGN (sizeof (struct adi_axi_adc_client ),IIO_DMA_MINALIGN );if (sizeof_priv) - alloc_size +=ALIGN (sizeof_priv,IIO_ALIGN ); + alloc_size +=ALIGN (sizeof_priv,IIO_DMA_MINALIGN ); cl =kzalloc (alloc_size,GFP_KERNEL );if (!cl)
drivers/iio/industrialio-core.c +2 -2
@@ -1655,7 +1655,7 @@ struct iio_dev *iio_device_alloc(struct device *parent, int sizeof_priv) alloc_size =sizeof (struct iio_dev_opaque );if (sizeof_priv) { - alloc_size =ALIGN (alloc_size,IIO_ALIGN ); + alloc_size =ALIGN (alloc_size,IIO_DMA_MINALIGN ); alloc_size += sizeof_priv; }
@@ -1665,7 +1665,7 @@ struct iio_dev *iio_device_alloc(struct device *parent, int sizeof_priv) indio_dev = &iio_dev_opaque->indio_dev; indio_dev->priv = (char *)iio_dev_opaque + -ALIGN (sizeof (struct iio_dev_opaque ),IIO_ALIGN ); +ALIGN (sizeof (struct iio_dev_opaque ),IIO_DMA_MINALIGN ); indio_dev->dev.parent = parent; indio_dev->dev.type = &iio_device_type;
include/linux/iio/iio.h +8 -2
@@ -9,6 +9,7 @@#include <linux/device.h> #include <linux/cdev.h> +#include <linux/slab.h> #include <linux/iio/types.h> #include <linux/of.h> /* IIO TODO LIST */
@@ -657,8 +658,13 @@ static inline void *iio_device_get_drvdata(const struct iio_dev *indio_dev)return dev_get_drvdata (&indio_dev->dev); } -/* Can we make this smaller? */ -#define IIO_ALIGN L1_CACHE_BYTES +/* +* Used to ensure the iio_priv() structure is aligned to allow that structure +* to in turn include IIO_DMA_MINALIGN'd elements such as buffers which +* must not share cachelines with the rest of the structure, thus making +* them safe for use with non-coherent DMA. +*/ +#define IIO_DMA_MINALIGN ARCH_KMALLOC_MINALIGNstruct iio_dev *iio_device_alloc (struct device *parent,int sizeof_priv);/* The information at the returned address is guaranteed to be cacheline aligned */
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 587/1095 iio: accel: adxl313: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit f68a0445ee86e48dafbfdea50163ad6fc6dba268 ]
____cacheline_aligned is insufficient guarantee for non-coherent DMA. Switch to the updated IIO_DMA_MINALIGN definition.
--- drivers/iio/accel/adxl313_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/accel/adxl313_core.c +1 -1
@@ -46,7 +46,7 @@ EXPORT_SYMBOL_NS_GPL(adxl313_writable_regs_table, IIO_ADXL313);struct adxl313_data {struct regmap *regmap;struct mutex lock;/* lock to protect transf_buf */ -__le16 transf_buf____cacheline_aligned ; +__le16 transf_buf__aligned(IIO_DMA_MINALIGN) ; };static const int adxl313_odr_freqs[][2 ] = {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 588/1095 iio: accel: adxl355: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 46403dcf3a7cbd24b86f809fd79962f4d6b137c5 ]
____cacheline_aligned is insufficient guarantee for non-coherent DMA.
Switch to the updated IIO_DMA_MINALIGN definition.
--- drivers/iio/accel/adxl355_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/accel/adxl355_core.c +1 -1
@@ -177,7 +177,7 @@ struct adxl355_data {u8 buf[14 ];s64 ts; } buffer; - }____cacheline_aligned ; + }__aligned(IIO_DMA_MINALIGN) ; }; static int adxl355_set_op_mode(struct adxl355_data *data,
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 589/1095 iio: accel: adxl367: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit e1f956a804df9074fb5de557563d153ae25252e7 ]
____cacheline_aligned is insufficient guarantee for non-coherent DMA. Switch to the updated IIO_DMA_MINALIGN definition.
Update comment to reflect that DMA safety may require separate cachelines.
--- drivers/iio/accel/adxl367.c | 2 +- drivers/iio/accel/adxl367_spi.c | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-)
drivers/iio/accel/adxl367.c +1 -1
@@ -179,7 +179,7 @@ struct adxl367_state {unsigned int fifo_set_size;unsigned int fifo_watermark; -__be16 fifo_buf[ADXL367_FIFO_SIZE ]____cacheline_aligned ; +__be16 fifo_buf[ADXL367_FIFO_SIZE ]__aligned(IIO_DMA_MINALIGN) ;__be16 sample_buf;u8 act_threshold_buf[2 ];u8 inact_time_buf[2 ];
drivers/iio/accel/adxl367_spi.c +5 -3
@@ -9,6 +9,8 @@#include <linux/regmap.h> #include <linux/spi/spi.h> +#include <linux/iio/iio.h> +#include "adxl367.h" #define ADXL367_SPI_WRITE_COMMAND 0x0A
@@ -28,10 +30,10 @@ struct adxl367_spi_state {struct spi_transfer fifo_xfer[2 ];/* -* DMA (thus cache coherency maintenance) requires the -* transfer buffers to live in their own cache lines. +* DMA (thus cache coherency maintenance) may require the +* transfer buffers live in their own cache lines. */ -u8 reg_write_tx_buf[1 ]____cacheline_aligned ; +u8 reg_write_tx_buf[1 ]__aligned(IIO_DMA_MINALIGN) ;u8 reg_read_tx_buf[2 ];u8 fifo_tx_buf[1 ]; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 590/1095 iio: accel: bma220: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 38e71240e2ff97184cdcdaf877cf62d3f16678e2 ]
____cacheline_aligned is insufficient guarantee for non-coherent DMA. Switch to the updated IIO_DMA_MINALIGN definition.
--- drivers/iio/accel/bma220_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/accel/bma220_spi.c +1 -1
@@ -67,7 +67,7 @@ struct bma220_data {/* Ensure timestamp is naturally aligned. */ s64 timestamp__aligned(8) ; } scan; -u8 tx_buf[2 ]____cacheline_aligned ; +u8 tx_buf[2 ]__aligned(IIO_DMA_MINALIGN) ; };static const struct iio_chan_spec bma220_channels[] = {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 591/1095 iio: accel: sca3000: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit a263456f0e27ec2f00d25119757f4d4bd656b2e9 ]
____cacheline_aligned is insufficient guarantee for non-coherent DMA. Switch to the updated IIO_DMA_MINALIGN definition.
The second alignment marking is left in place to avoid doing more than the simple fix in this patch.
--- drivers/iio/accel/sca3000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/accel/sca3000.c +2 -2
@@ -167,8 +167,8 @@ struct sca3000_state {int mo_det_use_count;struct mutex lock;/* Can these share a cacheline ? */ -u8 rx[384 ]____cacheline_aligned ; -u8 tx[6 ]____cacheline_aligned ; +u8 rx[384 ]__aligned(IIO_DMA_MINALIGN) ; +u8 tx[6 ]__aligned(IIO_DMA_MINALIGN) ; };/**
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 592/1095 iio: accel: sca3300: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit b1d3a806630dbbf3b4d75a2e850adccf4f4439e7 ]
____cacheline_aligned is insufficient guarantee for non-coherent DMA. Switch to the updated IIO_DMA_MINALIGN definition.
--- drivers/iio/accel/sca3300.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/accel/sca3300.c +1 -1
@@ -115,7 +115,7 @@ struct sca3300_data {s16 channels[4 ];s64 ts__aligned(sizeof(s64)) ; } scan; -u8 txbuf[4 ]____cacheline_aligned ; +u8 txbuf[4 ]__aligned(IIO_DMA_MINALIGN) ;u8 rxbuf[4 ]; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 593/1095 iio: adc: ad7266: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit b990cdfe7536a8da7e134d516350402981300016 ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
Update the comment to reflect that DMA safety 'may' require separate cachelines.
--- drivers/iio/adc/ad7266.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/ad7266.c +2 -2
@@ -37,7 +37,7 @@ struct ad7266_state {struct gpio_desc *gpios[3 ];/* -* DMA (thus cache coherency maintenance) requires the +* DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. * The buffer needs to be large enough to hold two samples (4 bytes) and * the naturally aligned timestamp (8 bytes).
@@ -45,7 +45,7 @@ struct ad7266_state {struct {__be16 sample[2 ];s64 timestamp; - } data____cacheline_aligned ; + } data__aligned(IIO_DMA_MINALIGN) ; };static int ad7266_wakeup (struct ad7266_state *st)
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 594/1095 iio: adc: ad7280a: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 4e2008429588b857bbc13d048b67b931a8d84816 ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
--- drivers/iio/adc/ad7280a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7280a.c +1 -1
@@ -183,7 +183,7 @@ struct ad7280_state {unsigned char cb_mask[AD7280A_MAX_CHAIN ];struct mutex lock;/* protect sensor state */ -__be32 tx____cacheline_aligned ; +__be32 tx__aligned(IIO_DMA_MINALIGN) ;__be32 rx; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 595/1095 iio: adc: ad7292: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 98295a206d04633bae31f279de11ff7d04724bce ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
--- drivers/iio/adc/ad7292.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7292.c +1 -1
@@ -80,7 +80,7 @@ struct ad7292_state {struct regulator *reg;unsigned short vref_mv; -__be16 d16____cacheline_aligned ; +__be16 d16__aligned(IIO_DMA_MINALIGN) ;u8 d8[2 ]; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 596/1095 iio: adc: ad7298: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 585c9772f883da3ac425e2e8277b2aaceb201f38 ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
--- drivers/iio/adc/ad7298.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7298.c +1 -1
@@ -49,7 +49,7 @@ struct ad7298_state {* DMA (thus cache coherency maintenance) requires the * transfer buffers to live in their own cache lines. */ -__be16 rx_buf[12 ]____cacheline_aligned ; +__be16 rx_buf[12 ]__aligned(IIO_DMA_MINALIGN) ;__be16 tx_buf[2 ]; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 597/1095 iio: adc: ad7476: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 58b74555afc8affe4ae4f57d396349158433fc80 ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
Update the comment to reflect that DMA safety 'may' require separate cachelines.
Fixes tag is unlikely to be the actual introdution of the problem but is far enough back to cover any likely backporting.
--- drivers/iio/adc/ad7476.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/iio/adc/ad7476.c +2 -3
@@ -44,13 +44,12 @@ struct ad7476_state {struct spi_transfer xfer;struct spi_message msg;/* -* DMA (thus cache coherency maintenance) requires the +* DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. * Make the buffer large enough for one 16 bit sample and one 64 bit * aligned 64 bit timestamp. */ -unsigned char data[ALIGN (2 ,sizeof (s64)) +sizeof (s64)] -____cacheline_aligned ; +unsigned char data[ALIGN (2 ,sizeof (s64)) +sizeof (s64)]__aligned(IIO_DMA_MINALIGN) ; };enum ad7476_supported_device_ids {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 598/1095 iio: adc: ad7606: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 6268c6eebb13f228d418f9adaca848b3ed5b3cf9 ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_ALIGN definition.
Update the comment to reflect the fact DMA safety 'may' require separate cachelines.
--- drivers/iio/adc/ad7606.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/ad7606.h +2 -2
@@ -116,11 +116,11 @@ struct ad7606_state {struct completion completion;/* -* DMA (thus cache coherency maintenance) requires the +* DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. * 16 * 16-bit samples + 64-bit timestamp */ -unsigned short data[20 ]____cacheline_aligned ; +unsigned short data[20 ]__aligned(IIO_DMA_MINALIGN) ;__be16 d16[2 ]; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 599/1095 iio: adc: ad7766: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 009ae227a1dace2d4d27c804e5bd65907e1d0557 ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
Update the comment to reflect the fact DMA safety 'may' require separate cachelines.
--- drivers/iio/adc/ad7766.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/iio/adc/ad7766.c +2 -3
@@ -45,13 +45,12 @@ struct ad7766 {struct spi_message msg;/* -* DMA (thus cache coherency maintenance) requires the +* DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. * Make the buffer large enough for one 24 bit sample and one 64 bit * aligned 64 bit timestamp. */ -unsigned char data[ALIGN (3 ,sizeof (s64)) +sizeof (s64)] -____cacheline_aligned ; +unsigned char data[ALIGN (3 ,sizeof (s64)) +sizeof (s64)]__aligned(IIO_DMA_MINALIGN) ; };/*
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 600/1095 iio: adc: ad7768-1: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 211f810f8fae05c1f78e531b2b113ea1ab3d1ce7 ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
Update the comment to reflect that separate cachelines 'may' be required.
--- drivers/iio/adc/ad7768-1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/ad7768-1.c +2 -2
@@ -163,7 +163,7 @@ struct ad7768_state {struct gpio_desc *gpio_sync_in;const char *labels[ARRAY_SIZE (ad7768_channels)];/* -* DMA (thus cache coherency maintenance) requires the +* DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. */ union {
@@ -173,7 +173,7 @@ struct ad7768_state { } scan;__be32 d32;u8 d8[2 ]; - } data____cacheline_aligned ; + } data__aligned(IIO_DMA_MINALIGN) ; }; static int ad7768_spi_reg_read(struct ad7768_state *st, unsigned int addr,
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 601/1095 iio: adc: ad7887: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit b330ea6bc52468e183ced79189ff064f36c64aa7 ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
Update the comment to include 'may'.
Fixes tag is clearly not where this was introduced but it is very unlikely anyone will back port it past that point.
--- drivers/iio/adc/ad7887.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/iio/adc/ad7887.c +2 -3
@@ -66,13 +66,12 @@ struct ad7887_state {unsigned char tx_cmd_buf[4 ];/* -* DMA (thus cache coherency maintenance) requires the +* DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. * Buffer needs to be large enough to hold two 16 bit samples and a * 64 bit aligned 64 bit timestamp. */ -unsigned char data[ALIGN (4 ,sizeof (s64)) +sizeof (s64)] -____cacheline_aligned ; +unsigned char data[ALIGN (4 ,sizeof (s64)) +sizeof (s64)]__aligned(IIO_DMA_MINALIGN) ; };enum ad7887_supported_device_ids {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 602/1095 iio: adc: ad7923: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 908af45d7057345bc910940a9340f7a1d8935875 ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
Update the comment to include 'may'.
Note that some other fixes have applied to this line of code that may complicate automated backporting.
--- drivers/iio/adc/ad7923.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/ad7923.c +2 -2
@@ -57,12 +57,12 @@ struct ad7923_state {unsigned int settings;/* -* DMA (thus cache coherency maintenance) requires the +* DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. * Ensure rx_buf can be directly used in iio_push_to_buffers_with_timetamp * Length = 8 channels + 4 extra for 8 byte timestamp */ -__be16 rx_buf[12 ]____cacheline_aligned ; +__be16 rx_buf[12 ]__aligned(IIO_DMA_MINALIGN) ;__be16 tx_buf[4 ]; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 603/1095 iio: adc: ad7949: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 9c6c7eff7d4a53efd4d0818f8664259a1862665a ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
Note the fixes tag predates some changes to this line of code so automated application of this fix may fail.
--- drivers/iio/adc/ad7949.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7949.c +1 -1
@@ -86,7 +86,7 @@ struct ad7949_adc_chip {u8 resolution;u16 cfg;unsigned int current_channel; -u16 buffer____cacheline_aligned ; +u16 buffer__aligned(IIO_DMA_MINALIGN) ;__be16 buf8b; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 604/1095 iio: adc: hi8435: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 48e4ae96b0b10f93de23b86fd34e573c44e95ab3 ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
--- drivers/iio/adc/hi8435.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/hi8435.c +1 -1
@@ -49,7 +49,7 @@ struct hi8435_priv {unsigned threshold_lo[2 ];/* GND-Open and Supply-Open thresholds */ unsigned threshold_hi[2 ];/* GND-Open and Supply-Open thresholds */ -u8 reg_buffer[3 ]____cacheline_aligned ; +u8 reg_buffer[3 ]__aligned(IIO_DMA_MINALIGN) ; };static int hi8435_readb (struct hi8435_priv *priv,u8 reg,u8 *val)
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 605/1095 iio: adc: ltc2496: Fix alignment for DMA safety
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 1673b7ca2dc1fb3b8d7c94a112496c02d34ae449 ]
____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition.
Update the comment to include 'may'.
--- drivers/iio/adc/ltc2496.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/ltc2496.c +2 -2
@@ -24,10 +24,10 @@ struct ltc2496_driverdata {struct spi_device *spi;/* -* DMA (thus cache coherency maintenance) requires the +* DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. */ -unsigned char rxbuf[3 ]____cacheline_aligned ; +unsigned char rxbuf[3 ]__aligned(IIO_DMA_MINALIGN) ;unsigned char txbuf[3 ]; };
Signature · 1 line
2.35.1