5.19.2-rc1 review
Subsystems (12)
Greg Kroah-Hartman
maintainerPATCH 235/1157 arm64: dts: renesas: r8a779m8: Drop operating points above 1.5 GHz
In reply to Greg Kroah-HartmanFrom: Geert Uytterhoeven <[email protected]>
[ Upstream commit f48cb21a28c07d0754d5f2f85444cfb0e7b1fd05 ]
The highest-performance mode for the Cortex-A57 CPU cores supported on R-Car H3Ne (R8A779M8) is the Power Optimized (1.5 GHz) mode. The Normal (1.6 GHz) and High Performance (1.7 GHz) modes are not supported.
Hence drop the "turbo-mode" entries from the operating points table inherited from r8a77951.dtsi.
--- arch/arm64/boot/dts/renesas/r8a779m8.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/renesas/r8a779m8.dtsi +5 -0
@@ -10,3 +10,8 @@ / { compatible = "renesas,r8a779m8", "renesas,r8a7795"; }; + +&cluster0_opp { + /delete-node/ opp-1600000000; + /delete-node/ opp-1700000000; +};
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 236/1157 arm64: dts: renesas: r9a07g054l2-smarc: Correct SoC name in comment
In reply to Greg Kroah-HartmanFrom: Chris Paterson <[email protected]>
[ Upstream commit d1273f541ab409242e08da6bb836bb564021274c ]
This dts is for the RZ/V2L SMARC EVK, not RZ/G2L.
--- arch/arm64/boot/dts/renesas/r9a07g054l2-smarc.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/renesas/r9a07g054l2-smarc.dts +1 -1
@@ -1,6 +1,6 @@ // SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) /* - * Device Tree Source for the RZ/G2L SMARC EVK board + * Device Tree Source for the RZ/V2L SMARC EVK board * * Copyright (C) 2021 Renesas Electronics Corp. */
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 237/1157 regulator: qcom_smd: Fix pm8916_pldo range
In reply to Greg Kroah-HartmanFrom: Stephan Gerhold <[email protected]>
[ Upstream commit e8977917e116d1571dacb8e9864474551c1c12bd ]
The PM8916 device specification [1] documents a programmable range of 1.75V to 3.337V with 12.5mV steps for the PMOS LDOs in PM8916. This range is also used when controlling the regulator directly using the qcom_spmi-regulator driver ("ult_pldo" there).
However, for some reason the qcom_smd-regulator driver allows a much larger range for the same hardware component. This could be simply a typo, since the start of the range is essentially just missing a '1'.
In practice this does not cause any major problems, since the driver just sends the actual voltage to the RPM firmware instead of making use of the incorrect voltage selector. Still, having the wrong range there is confusing and prevents the regulator core from validating requests correctly.
--- drivers/regulator/qcom_smd-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/qcom_smd-regulator.c +2 -2
@@ -357,10 +357,10 @@ static const struct regulator_desc pm8941_switch = {static const struct regulator_desc pm8916_pldo = { .linear_ranges = (struct linear_range []) { -REGULATOR_LINEAR_RANGE (750000 ,0 ,208 ,12500 ), +REGULATOR_LINEAR_RANGE (1750000 ,0 ,127 ,12500 ), }, .n_linear_ranges =1 , - .n_voltages =209 , + .n_voltages =128 , .ops = &rpm_smps_ldo_ops, };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 238/1157 ACPI: APEI: Fix _EINJ vs EFI_MEMORY_SP
In reply to Greg Kroah-HartmanFrom: Dan Williams <[email protected]>
[ Upstream commit b13a3e5fd40b7d1b394c5ecbb5eb301a4c38e7b2 ]
When a platform marks a memory range as "special purpose" it is not onlined as System RAM by default. However, it is still suitable for error injection. Add IORES_DESC_SOFT_RESERVED to einj_error_inject() as a permissible memory type in the sanity checking of the arguments to _EINJ.
--- drivers/acpi/apei/einj.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/acpi/apei/einj.c +2 -0
@@ -546,6 +546,8 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, != REGION_INTERSECTS) && (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_PERSISTENT_MEMORY ) !=REGION_INTERSECTS ) && + (region_intersects (base_addr, size,IORESOURCE_MEM ,IORES_DESC_SOFT_RESERVED ) + !=REGION_INTERSECTS ) && !arch_is_platform_page(base_addr))) return -EINVAL;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 239/1157 ARM: dts: qcom: replace gcc PXO with pxo_board fixed clock
In reply to Greg Kroah-HartmanFrom: Ansuel Smith <[email protected]>
[ Upstream commit eb9e93937756a05787977875830c0dc482cb57e0 ]
Replace gcc PXO phandle to pxo_board fixed clock declared in the dts. gcc driver doesn't provide PXO_SRC as it's a fixed-clock. This cause a kernel panic if any driver actually try to use it.
--- arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom-ipq8064.dtsi +1 -1
@@ -784,7 +784,7 @@ tcsr: syscon@1a400000 { l2cc: clock-controller@2011000 { compatible = "qcom,kpss-gcc", "syscon"; reg = <0x2011000 0x1000>; - clocks = <&gcc PLL8_VOTE>, <&gcc PXO_SRC>; + clocks = <&gcc PLL8_VOTE>, <&pxo_board>; clock-names = "pll8_vote", "pxo"; clock-output-names = "acpu_l2_aux"; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 240/1157 ARM: dts: qcom-msm8974: fix irq type on blsp2_uart1
In reply to Greg Kroah-HartmanFrom: Luca Weiss <[email protected]>
[ Upstream commit ab1489017aa7a9f02e24bee73cf9ec8079cd3909 ]
IRQ_TYPE_NONE is invalid, so use the correct interrupt type.
--- arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8974.dtsi +1 -1
@@ -580,7 +580,7 @@ blsp2_dma: dma-controller@f9944000 { blsp2_uart1: serial@f995d000 { compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm"; reg = <0xf995d000 0x1000>; - interrupts = <GIC_SPI 113 IRQ_TYPE_NONE>; + interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>; clocks = <&gcc GCC_BLSP2_UART1_APPS_CLK>, <&gcc GCC_BLSP2_AHB_CLK>; clock-names = "core", "iface"; pinctrl-names = "default", "sleep";
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 241/1157 soc: qcom: ocmem: Fix refcount leak in of_get_ocmem
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit 92a563fcf14b3093226fb36f12e9b5cf630c5a5d ]
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. of_node_put() will check NULL pointer.
--- drivers/soc/qcom/ocmem.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/soc/qcom/ocmem.c +3 -0
@@ -194,14 +194,17 @@ struct ocmem *of_get_ocmem(struct device *dev) devnode =of_parse_phandle (dev->of_node,"sram" ,0 );if (!devnode || !devnode->parent) {dev_err (dev,"Cannot look up sram phandle\n" ); +of_node_put (devnode);return ERR_PTR (-ENODEV ); } pdev =of_find_device_by_node (devnode->parent);if (!pdev) {dev_err (dev,"Cannot find device node %s\n" , devnode->name); +of_node_put (devnode);return ERR_PTR (-EPROBE_DEFER ); } +of_node_put (devnode); ocmem =platform_get_drvdata (pdev);if (!ocmem) {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 242/1157 soc: qcom: aoss: Fix refcount leak in qmp_cooling_devices_register
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit e6e0951414a314e7db3e9e24fd924b3e15515288 ]
Every iteration of for_each_available_child_of_node() decrements the reference count of the previous node.
When breaking early from a for_each_available_child_of_node() loop, we need to explicitly call of_node_put() on the child node. Add missing of_node_put() to avoid refcount leak.
--- drivers/soc/qcom/qcom_aoss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/soc/qcom/qcom_aoss.c +3 -1
@@ -399,8 +399,10 @@ static int qmp_cooling_devices_register(struct qmp *qmp)continue ; ret =qmp_cooling_device_add (qmp, &qmp->cooling_devs[count++], child); -if (ret) +if (ret) { +of_node_put (child); goto unroll; + } }if (!count)
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 243/1157 ARM: dts: qcom: msm8974: add required ranges to OCMEM
In reply to Greg Kroah-HartmanFrom: Krzysztof Kozlowski <[email protected]>
[ Upstream commit 7a16ea7f3a5ec0f30b146b058c273b7a9c8ceadf ]
The OCMEM bindings require ranges property.
--- arch/arm/boot/dts/qcom-msm8974.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/qcom-msm8974.dtsi +1 -0
@@ -1630,6 +1630,7 @@ ocmem@fdd00000 { reg = <0xfdd00000 0x2000>, <0xfec00000 0x180000>; reg-names = "ctrl", "mem"; + ranges = <0 0xfec00000 0x180000>; clocks = <&rpmcc RPM_SMD_OCMEMGX_CLK>, <&mmcc OCMEMCX_OCMEMNOC_CLK>; clock-names = "core", "iface";
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 244/1157 ARM: dts: qcom: pm8841: add required thermal-sensor-cells
In reply to Greg Kroah-HartmanFrom: Krzysztof Kozlowski <[email protected]>
[ Upstream commit e2759fa0676c9a32bbddb9aff955b54bb35066ad ]
The PM8841 temperature sensor has to define thermal-sensor-cells.
--- arch/arm/boot/dts/qcom-pm8841.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/qcom-pm8841.dtsi +1 -0
@@ -24,6 +24,7 @@ temp-alarm@2400 { compatible = "qcom,spmi-temp-alarm"; reg = <0x2400>; interrupts = <4 0x24 0 IRQ_TYPE_EDGE_RISING>; + #thermal-sensor-cells = <0>; }; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 245/1157 bus: hisi_lpc: fix missing platform_device_put() in hisi_lpc_acpi_probe()
In reply to Greg Kroah-HartmanFrom: Yang Yingliang <[email protected]>
[ Upstream commit 54872fea6a5ac967ec2272aea525d1438ac6735a ]
In error case in hisi_lpc_acpi_probe() after calling platform_device_add(), hisi_lpc_acpi_remove() can't release the failed 'pdev', so it will be leak, call platform_device_put() to fix this problem.
I'v constructed this error case and tested this patch on D05 board.
--- drivers/bus/hisi_lpc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/bus/hisi_lpc.c +6 -4
@@ -503,13 +503,13 @@ static int hisi_lpc_acpi_probe(struct device *hostdev) {struct acpi_device *adev =ACPI_COMPANION (hostdev);struct acpi_device *child; +struct platform_device *pdev;int ret;/* Only consider the children of the host */ list_for_each_entry (child, &adev->children, node) {const char *hid =acpi_device_hid (child);const struct hisi_lpc_acpi_cell *cell; -struct platform_device *pdev;const struct resource *res;bool found = false;int num_res;
@@ -571,22 +571,24 @@ static int hisi_lpc_acpi_probe(struct device *hostdev) ret =platform_device_add_resources (pdev, res, num_res);if (ret) - goto fail; + goto fail_put_device; ret =platform_device_add_data (pdev, cell->pdata, cell->pdata_size);if (ret) - goto fail; + goto fail_put_device; ret =platform_device_add (pdev);if (ret) - goto fail; + goto fail_put_device;acpi_device_set_enumerated (child); }return 0 ; +fail_put_device: +platform_device_put (pdev); fail:hisi_lpc_acpi_remove (hostdev);return ret;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 246/1157 usercopy: use unsigned long instead of uintptr_t
In reply to Greg Kroah-HartmanFrom: Jason A. Donenfeld <[email protected]>
[ Upstream commit 170b2c350cfcb6f74074e44dd9f916787546db0d ]
A recent commit factored out a series of annoying (unsigned long) casts into a single variable declaration, but made the pointer type a uintptr_t rather than the usual unsigned long. This patch changes it to be the integer type more typically used by the kernel to represent addresses.
--- mm/usercopy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/usercopy.c +1 -1
@@ -161,7 +161,7 @@ static inline void check_bogus_address(const unsigned long ptr, unsigned long n,static inline void check_heap_object (const void *ptr,unsigned long n,bool to_user) { -uintptr_t addr = (uintptr_t )ptr; +unsigned long addr = (unsigned long )ptr;unsigned long offset;struct folio *folio;
Signature · 1 line
2.35.1
Re: [PATCH 5.19 0246/1157] usercopy: use unsigned long instead of uintptr_t
Quoted 11 lines · Greg Kroah-Hartman
From: Jason A. Donenfeld <[email protected]>
[ Upstream commit
170b2c350cfcb6f74074e44dd9f916787546db0d]A recent commit factored out a series of annoying (unsigned long) casts into a single variable declaration, but made the pointer type a
uintptr_trather than the usualunsigned long. This patch changes it to be the integer type more typically used by the kernel to represent addresses.Fixes 35fb9ae4aa2e ("usercopy: Cast pointer to an integer once")
Not sure why this needs to be backported?
Quoted 31 lines
Cc Matthew Wilcox <[email protected]>Cc Uladzislau Rezki <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Linus Torvalds <[email protected]>Cc Joe Perches <[email protected]>Signed-off-by Jason A. Donenfeld <[email protected]>Signed-off-by Kees Cook <[email protected]>Signed-off-by Sasha Levin <[email protected]>--- mm/usercopy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/usercopy.c +1
-1@@ -161,7 +161,7 @@ static inline void check_bogus_address(const unsigned long ptr, unsigned long n,static inline void check_heap_object (const void *ptr,unsigned long n,bool to_user) { -uintptr_t addr = (uintptr_t )ptr; +unsigned long addr = (unsigned long )ptr;unsigned long offset;struct folio *folio;Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerRe: [PATCH 5.19 0246/1157] usercopy: use unsigned long instead of uintptr_t
Quoted 11 lines · Matthew Wilcox
Quoted 10 lines · Greg Kroah-Hartman
From: Jason A. Donenfeld <[email protected]>
[ Upstream commit
170b2c350cfcb6f74074e44dd9f916787546db0d]A recent commit factored out a series of annoying (unsigned long) casts into a single variable declaration, but made the pointer type a
uintptr_trather than the usualunsigned long. This patch changes it to be the integer type more typically used by the kernel to represent addresses.
Quoted 3 lines
Quoted 1 line
Fixes 35fb9ae4aa2e ("usercopy: Cast pointer to an integer once")Not sure why this needs to be backported?
Odd, shouldn't be, now dropped.
greg k-h
Greg Kroah-Hartman
maintainerPATCH 247/1157 lib: overflow: Do not define 64-bit tests on 32-bit
In reply to Greg Kroah-HartmanFrom: Kees Cook <[email protected]>
[ Upstream commit 6a022dd29f2cefbac4895a34e2e1f14b2d12d819 ]
The 64-bit overflow tests will trigger 64-bit division on 32-bit hosts, which is not currently used anywhere in the kernel, and tickles bugs in at least Clang 13 and earlier:
https://github.com/ClangBuiltLinux/linux/issues/1636
In reality, there shouldn't be a reason to not build the 64-bit test cases on 32-bit systems, so these #ifdefs can be removed once the minimum Clang version reaches 13.
In the meantime, silence W=1 warnings given by the current code:
../lib/overflow_kunit.c:191:19: warning: 's64_tests' defined but not used [-Wunused-const-variable=]
191 | DEFINE_TEST_ARRAY(s64) = {
| ^~~../lib/overflow_kunit.c:24:11: note: in definition of macro 'DEFINE_TEST_ARRAY'
24 | } t ## _tests[]
| ^../lib/overflow_kunit.c:94:19: warning: 'u64_tests' defined but not used [-Wunused-const-variable=]
94 | DEFINE_TEST_ARRAY(u64) = {
| ^~~../lib/overflow_kunit.c:24:11: note: in definition of macro 'DEFINE_TEST_ARRAY'
24 | } t ## _tests[]
| ^
--- lib/overflow_kunit.c | 6 ++++++ 1 file changed, 6 insertions(+)
lib/overflow_kunit.c +6 -0
@@ -91,6 +91,7 @@ DEFINE_TEST_ARRAY(u32) = { {-4U, 5U, 1U, -9U, -20U, true, false, true}, }; +#if BITS_PER_LONG ==64 DEFINE_TEST_ARRAY (u64) = { {0 ,0 ,0 ,0 ,0 , false, false, false}, {1, 1, 2, 0, 1, false, false, false},
@@ -114,6 +115,7 @@ DEFINE_TEST_ARRAY(u64) = { false, true, false}, {-15ULL, 10ULL, -5ULL, -25ULL, -150ULL, false, false, true}, }; +#endif DEFINE_TEST_ARRAY (s8) = { {0 ,0 ,0 ,0 ,0 , false, false, false},
@@ -188,6 +190,8 @@ DEFINE_TEST_ARRAY(s32) = { {S32_MIN, S32_MIN, 0, 0, 0, true, false, true}, {S32_MAX, S32_MAX, -2, 0, 1, true, false, true}, }; + +#if BITS_PER_LONG ==64 DEFINE_TEST_ARRAY (s64) = { {0, 0, 0, 0, 0, false, false, false},
@@ -216,6 +220,7 @@ DEFINE_TEST_ARRAY(s64) = { {-128, -1, -129, -127, 128, false, false, false}, {0, -S64_MAX, -S64_MAX, S64_MAX, 0, false, false, false}, }; +#endif #define check_one_op (t, fmt, op, sym, a, b, r, of) do { \ t _r; \
@@ -650,6 +655,7 @@ static struct kunit_case overflow_test_cases[] = {KUNIT_CASE (s16_overflow_test),KUNIT_CASE (u32_overflow_test),KUNIT_CASE (s32_overflow_test), +/* Clang 13 and earlier generate unwanted libcalls on 32-bit. */ #if BITS_PER_LONG == 64KUNIT_CASE (u64_overflow_test), KUNIT_CASE(s64_overflow_test),
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 248/1157 stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
In reply to Greg Kroah-HartmanFrom: GONG, Ruiqi <[email protected]>
[ Upstream commit 375561bd6195a31bf4c109732bd538cb97a941f4 ]
Fix the following Sparse warnings that got noticed when the PPC-dev patchwork was checking another patch (see the link below):
init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static? init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
Which in fact are triggered on all architectures that have HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64 etc).
--- init/main.c | 1 + 1 file changed, 1 insertion(+)
init/main.c +1 -0
@@ -99,6 +99,7 @@#include <linux/kcsan.h> #include <linux/init_syscalls.h> #include <linux/stackdepot.h> +#include <linux/randomize_kstack.h> #include <net/net_namespace.h> #include <asm/io.h>
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 249/1157 arm64: dts: qcom: msm8916: Fix typo in pronto remoteproc node
In reply to Greg Kroah-HartmanFrom: Sireesh Kodali <[email protected]>
[ Upstream commit 5458d6f2827cd30218570f266b8d238417461f2f ]
The smem-state properties for the pronto node were incorrectly labelled, reading qcom,state* rather than qcom,smem-state*. Fix that, allowing the stop state to be used.
--- arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/msm8916.dtsi +2 -2
@@ -1788,8 +1788,8 @@ pronto: remoteproc@a21b000 { <&rpmpd MSM8916_VDDMX>; power-domain-names = "cx", "mx"; - qcom,state = <&wcnss_smp2p_out 0>; - qcom,state-names = "stop"; + qcom,smem-states = <&wcnss_smp2p_out 0>; + qcom,smem-state-names = "stop"; pinctrl-names = "default"; pinctrl-0 = <&wcnss_pin_a>;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 250/1157 arm64: dts: qcom: msm8994: add required ranges to OCMEM
In reply to Greg Kroah-HartmanFrom: Krzysztof Kozlowski <[email protected]>
[ Upstream commit 07f3c7a11dadbead580b6d6e7d86bcc87119fe74 ]
The OCMEM bindings require ranges property.
--- arch/arm64/boot/dts/qcom/msm8994.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/msm8994.dtsi +1 -0
@@ -1074,6 +1074,7 @@ ocmem: ocmem@fdd00000 { reg = <0xfdd00000 0x2000>, <0xfec00000 0x200000>; reg-names = "ctrl", "mem"; + ranges = <0 0xfec00000 0x200000>; clocks = <&rpmcc RPM_SMD_OCMEMGX_CLK>, <&mmcc OCMEMCX_OCMEMNOC_CLK>; clock-names = "core", "iface";
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 251/1157 perf/x86/intel: Fix PEBS memory access info encoding for ADL
In reply to Greg Kroah-HartmanFrom: Kan Liang <[email protected]>
[ Upstream commit 39a41278f041e4b7ee6c83caefac845c9b19fc61 ]
The PEBS memory access latency encoding for the e-core is slightly different from the p-core. The bit 4 is Lock, while the bit 5 is TLB access.
Add a new flag to indicate the load/store latency event on a hybrid platform.
Add a new function pointer to retrieve the latency data for a hybrid platform. Only implement the new flag and function for the e-core on ADL. Still use the existing PERF_X86_EVENT_PEBS_LDLAT/STLAT flag for the p-core on ADL.
Factor out pebs_set_tlb_lock() to set the generic memory data source information of the TLB access and lock for both load and store latency.
Move the intel_get_event_constraints() to ahead of the :ppp check, otherwise the new flag never gets a chance to be set for the :ppp events.
--- arch/x86/events/intel/core.c | 5 ++- arch/x86/events/intel/ds.c | 80 ++++++++++++++++++++++-------------- arch/x86/events/perf_event.h | 8 ++++ 3 files changed, 60 insertions(+), 33 deletions(-)
arch/x86/events/intel/core.c +3 -2
@@ -4141,6 +4141,8 @@ tnt_get_event_constraints(struct cpu_hw_events *cpuc, int idx, {struct event_constraint *c; + c =intel_get_event_constraints (cpuc, idx, event); +/* * :ppp means to do reduced skid PEBS, * which is available on PMC0 and fixed counter 0.
@@ -4153,8 +4155,6 @@ tnt_get_event_constraints(struct cpu_hw_events *cpuc, int idx,return &counter0_constraint; } - c =intel_get_event_constraints (cpuc, idx, event); -return c; }
@@ -6242,6 +6242,7 @@ __init int intel_pmu_init(void) x86_pmu.flags |=PMU_FL_MEM_LOADS_AUX ; x86_pmu.lbr_pt_coexist = true;intel_pmu_pebs_data_source_skl (false); + x86_pmu.pebs_latency_data = adl_latency_data_small; x86_pmu.num_topdown_events =8 ; x86_pmu.update_topdown_event = adl_update_topdown_event; x86_pmu.set_topdown_event_period = adl_set_topdown_event_period;
arch/x86/events/intel/ds.c +49 -31
111 lines not on this page · raw message
arch/x86/events/perf_event.h +8 -0
@@ -84,6 +84,7 @@ static inline bool constraint_match(struct event_constraint *c, u64 ecode)#define PERF_X86_EVENT_TOPDOWN 0x04000/* Count Topdown slots/metrics events */ #define PERF_X86_EVENT_PEBS_STLAT 0x08000/* st+stlat data address sampling */ #define PERF_X86_EVENT_AMD_BRS 0x10000/* AMD Branch Sampling */ +#define PERF_X86_EVENT_PEBS_LAT_HYBRID 0x20000/* ld and st lat for hybrid */ static inline bool is_topdown_count (struct perf_event *event) {
@@ -460,6 +461,10 @@ struct cpu_hw_events {__EVENT_CONSTRAINT (c, n,INTEL_ARCH_EVENT_MASK |X86_ALL_EVENT_FLAGS , \ HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_ST) +#define INTEL_HYBRID_LAT_CONSTRAINT (c, n) \ + __EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS, \ + HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_LAT_HYBRID) +/* Event constraint, but match on all event flags too. */ #define INTEL_FLAGS_EVENT_CONSTRAINT (c, n) \ EVENT_CONSTRAINT(c, n, ARCH_PERFMON_EVENTSEL_EVENT|X86_ALL_EVENT_FLAGS)
@@ -825,6 +830,7 @@ struct x86_pmu {void (*drain_pebs)(struct pt_regs *regs,struct perf_sample_data *data);struct event_constraint *pebs_constraints;void (*pebs_aliases)(struct perf_event *event); +u64 (*pebs_latency_data)(struct perf_event *event,u64 status);unsigned long large_pebs_flags;u64 rtm_abort_event;
@@ -1392,6 +1398,8 @@ void intel_pmu_disable_bts(void);int intel_pmu_drain_bts_buffer (void ); +u64 adl_latency_data_small (struct perf_event *event,u64 status); +extern struct event_constraint intel_core2_pebs_event_constraints[];extern struct event_constraint intel_atom_pebs_event_constraints[];
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 252/1157 perf/x86/intel: Fix PEBS data source encoding for ADL
In reply to Greg Kroah-HartmanFrom: Kan Liang <[email protected]>
[ Upstream commit ccf170e9d8fdacfe435bbe3749c897c7d86d32f8 ]
The PEBS data source encoding for the e-core is different from the p-core.
Add the pebs_data_source[] in the struct x86_hybrid_pmu to store the data source encoding for each type of the core.
Add intel_pmu_pebs_data_source_grt() for the e-core. There is nothing changed for the data source encoding of the p-core, which still reuse the intel_pmu_pebs_data_source_skl().
--- arch/x86/events/intel/core.c | 2 +- arch/x86/events/intel/ds.c | 51 +++++++++++++++++++++++++++--------- arch/x86/events/perf_event.h | 6 +++++ 3 files changed, 45 insertions(+), 14 deletions(-)
arch/x86/events/intel/core.c +1 -1
@@ -6241,7 +6241,7 @@ __init int intel_pmu_init(void) x86_pmu.flags |=PMU_FL_INSTR_LATENCY ; x86_pmu.flags |=PMU_FL_MEM_LOADS_AUX ; x86_pmu.lbr_pt_coexist = true; -intel_pmu_pebs_data_source_skl (false); +intel_pmu_pebs_data_source_adl (); x86_pmu.pebs_latency_data = adl_latency_data_small; x86_pmu.num_topdown_events =8 ; x86_pmu.update_topdown_event = adl_update_topdown_event;
arch/x86/events/intel/ds.c +38 -13
97 lines not on this page · raw message
arch/x86/events/perf_event.h +6 -0
@@ -643,6 +643,8 @@ enum { x86_lbr_exclusive_max, }; +#define PERF_PEBS_DATA_SOURCE_MAX 0x10 +struct x86_hybrid_pmu {struct pmu pmu;const char *name;
@@ -670,6 +672,8 @@ struct x86_hybrid_pmu { unsigned int late_ack :1, mid_ack :1, enabled_ack :1; + +u64 pebs_data_source[PERF_PEBS_DATA_SOURCE_MAX ]; }; static __always_inline struct x86_hybrid_pmu *hybrid_pmu(struct pmu *pmu)
@@ -1507,6 +1511,8 @@ void intel_pmu_pebs_data_source_nhm(void);void intel_pmu_pebs_data_source_skl (bool pmem); +void intel_pmu_pebs_data_source_adl (void ); +int intel_pmu_setup_lbr_filter (struct perf_event *event);void intel_pt_interrupt (void );
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 253/1157 arm64: dts: exynosautov9: correct spi11 pin names
In reply to Greg Kroah-HartmanFrom: Chanho Park <[email protected]>
[ Upstream commit ba205449828f47f80532a1453beef5eed2982176 ]
They should be started with "gpp5-".
--- arch/arm64/boot/dts/exynos/exynosautov9-pinctrl.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/exynos/exynosautov9-pinctrl.dtsi +3 -3
@@ -1089,21 +1089,21 @@ spi10_cs_func: spi10-cs-func-pins { /* PERIC1 USI11_SPI */ spi11_bus: spi11-pins { - samsung,pins = "gpp3-6", "gpp3-5", "gpp3-4"; + samsung,pins = "gpp5-6", "gpp5-5", "gpp5-4"; samsung,pin-function = <EXYNOS_PIN_FUNC_2>; samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>; }; spi11_cs: spi11-cs-pins { - samsung,pins = "gpp3-7"; + samsung,pins = "gpp5-7"; samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>; }; spi11_cs_func: spi11-cs-func-pins { - samsung,pins = "gpp3-7"; + samsung,pins = "gpp5-7"; samsung,pin-function = <EXYNOS_PIN_FUNC_2>; samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 254/1157 ACPI: VIOT: Fix ACS setup
In reply to Greg Kroah-HartmanFrom: Eric Auger <[email protected]>
[ Upstream commit 3dcb861dbc6ab101838a1548b1efddd00ca3c3ec ]
Currently acpi_viot_init() gets called after the pci device has been scanned and pci_enable_acs() has been called. So pci_request_acs() fails to be taken into account leading to wrong single iommu group topologies when dealing with multi-function root ports for instance.
We cannot simply move the acpi_viot_init() earlier, similarly as the IORT init because the VIOT parsing relies on the pci scan. However we can detect VIOT is present earlier and in such a case, request ACS. Introduce a new acpi_viot_early_init() routine that allows to call pci_request_acs() before the scan.
While at it, guard the call to pci_request_acs() with #ifdef CONFIG_PCI.
--- drivers/acpi/bus.c | 1 + drivers/acpi/viot.c | 26 ++++++++++++++++++++------ include/linux/acpi_viot.h | 2 ++ 3 files changed, 23 insertions(+), 6 deletions(-)
drivers/acpi/bus.c +1 -0
@@ -1399,6 +1399,7 @@ static int __init acpi_init(void)pci_mmcfg_late_init ();acpi_iort_init (); +acpi_viot_early_init ();acpi_hest_init ();acpi_ghes_init ();acpi_scan_init ();
drivers/acpi/viot.c +20 -6
@@ -248,6 +248,26 @@ static int __init viot_parse_node(const struct acpi_viot_header *hdr)return ret; } +/** +* acpi_viot_early_init - Test the presence of VIOT and enable ACS +* +* If the VIOT does exist, ACS must be enabled. This cannot be +* done in acpi_viot_init() which is called after the bus scan +*/ +void __init acpi_viot_early_init (void ) +{ +#ifdef CONFIG_PCI +acpi_status status; +struct acpi_table_header *hdr; + + status =acpi_get_table (ACPI_SIG_VIOT ,0 , &hdr); +if (ACPI_FAILURE (status)) +return ; +pci_request_acs (); +acpi_put_table (hdr); +#endif +} +/** * acpi_viot_init - Parse the VIOT table *
@@ -319,12 +339,6 @@ static int viot_pci_dev_iommu_init(struct pci_dev *pdev, u16 dev_id, void *data) epid = ((domain_nr - ep->segment_start) <<16 ) + dev_id - ep->bdf_start + ep->endpoint_id; -/* -* If we found a PCI range managed by the viommu, we're -* the one that has to request ACS. -*/ -pci_request_acs (); -return viot_dev_iommu_init (&pdev->dev, ep->viommu, epid); }
include/linux/acpi_viot.h +2 -0
@@ -6,9 +6,11 @@#include <linux/acpi.h> #ifdef CONFIG_ACPI_VIOT +void __init acpi_viot_early_init (void );void __init acpi_viot_init (void );int viot_iommu_configure (struct device *dev);#else +static inline void acpi_viot_early_init (void ) {}static inline void acpi_viot_init (void ) {}static inline int viot_iommu_configure (struct device *dev) {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 255/1157 m68k: virt: Fix missing platform_device_unregister() on error in virt_platform_init()
In reply to Greg Kroah-HartmanFrom: Yang Yingliang <[email protected]>
[ Upstream commit 566a2d6d8e429727832c7e347cbe736b12ad7297 ]
Add the missing platform_device_unregister() before return from virt_platform_init() in the error handling case.
--- arch/m68k/virt/platform.c | 58 ++++++++++++++++++++++----------------- 1 file changed, 33 insertions(+), 25 deletions(-)
arch/m68k/virt/platform.c +33 -25
@@ -8,20 +8,15 @@#define VIRTIO_BUS_NB 128 -static int __init virt_virtio_init (unsigned int id) +static struct platform_device *__init virt_virtio_init (unsigned int id) {const struct resource res[] = {DEFINE_RES_MEM (virt_bi_data.virtio.mmio + id *0x200 ,0x200 ),DEFINE_RES_IRQ (virt_bi_data.virtio.irq + id), }; -struct platform_device *pdev; - pdev =platform_device_register_simple ("virtio-mmio" , id, +return platform_device_register_simple ("virtio-mmio" , id, res,ARRAY_SIZE (res)); -if (IS_ERR (pdev)) -return PTR_ERR (pdev); - -return 0 ; }static int __init virt_platform_init (void )
@@ -35,8 +30,10 @@ static int __init virt_platform_init(void)DEFINE_RES_MEM (virt_bi_data.rtc.mmio +0x1000 ,0x1000 ), DEFINE_RES_IRQ(virt_bi_data.rtc.irq + 1), }; -struct platform_device *pdev; +struct platform_device *pdev1, *pdev2; +struct platform_device *pdevs[VIRTIO_BUS_NB ];unsigned int i; +int ret =0 ;if (!MACH_IS_VIRT )return -ENODEV ;
@@ -44,29 +41,40 @@ static int __init virt_platform_init(void)/* We need this to have DMA'able memory provided to goldfish-tty */ min_low_pfn =0 ; - pdev =platform_device_register_simple ("goldfish_tty" , -PLATFORM_DEVID_NONE , - goldfish_tty_res, -ARRAY_SIZE (goldfish_tty_res)); -if (IS_ERR (pdev)) -return PTR_ERR (pdev); + pdev1 =platform_device_register_simple ("goldfish_tty" , +PLATFORM_DEVID_NONE , + goldfish_tty_res, +ARRAY_SIZE (goldfish_tty_res)); +if (IS_ERR (pdev1)) +return PTR_ERR (pdev1); - pdev =platform_device_register_simple ("goldfish_rtc" , -PLATFORM_DEVID_NONE , - goldfish_rtc_res, -ARRAY_SIZE (goldfish_rtc_res)); -if (IS_ERR (pdev)) -return PTR_ERR (pdev); + pdev2 =platform_device_register_simple ("goldfish_rtc" , +PLATFORM_DEVID_NONE , + goldfish_rtc_res, +ARRAY_SIZE (goldfish_rtc_res)); +if (IS_ERR (pdev2)) { + ret =PTR_ERR (pdev2); + goto err_unregister_tty; + }for (i =0 ; i <VIRTIO_BUS_NB ; i++) { -int err; - - err =virt_virtio_init (i); -if (err) -return err; + pdevs[i] =virt_virtio_init (i); +if (IS_ERR (pdevs[i])) { + ret =PTR_ERR (pdevs[i]); + goto err_unregister_rtc_virtio; + } }return 0 ; + +err_unregister_rtc_virtio: +while (i >0 ) +platform_device_unregister (pdevs[--i]); +platform_device_unregister (pdev2); +err_unregister_tty: +platform_device_unregister (pdev1); + +return ret; }arch_initcall (virt_platform_init);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 256/1157 arm64: dts: qcom: sm6125: Move sdc2 pinctrl from seine-pdx201 to sm6125
In reply to Greg Kroah-HartmanFrom: Marijn Suijten <[email protected]>
[ Upstream commit 6990640a93ba4e76dd62ca3ea1082a7354db09d7 ]
Both the sdc2-on and sdc2-off pinctrl nodes are used by the sdhci@4784000 node in sm6125.dtsi. Surprisingly sdc2-off is defined in sm6125, yet its sdc2-on counterpart is only defined in board-specific DT for the Sony Seine PDX201 board/device resulting in an "undefined label &sdc2_state_on" error if sm6125.dtsi were included elsewhere. This sm6125 base dtsi should not rely on externally defined labels; the properties referencing it should then also be written externally. Since the sdc2-on pin configuration is board-independent just like sdc2-off, move it from seine-pdx201.dts into sm6125.dtsi.
The SDCard-detect pin (gpio98) is however board-specific, and remains as an overwrite in seine-pdx201.dts for both the on and off state.
As a drive-by cleanup, reorder bias- and drive-strength properties.
--- .../qcom/sm6125-sony-xperia-seine-pdx201.dts | 34 +++++-------------- arch/arm64/boot/dts/qcom/sm6125.dtsi | 24 +++++++++++-- 2 files changed, 30 insertions(+), 28 deletions(-)
arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts +8 -26
@@ -91,8 +91,16 @@ &hsusb_phy1 { &sdc2_state_off { sd-cd { pins = "gpio98"; + drive-strength = <2>; bias-disable; + }; +}; + +&sdc2_state_on { + sd-cd { + pins = "gpio98"; drive-strength = <2>; + bias-pull-up; }; };
@@ -102,32 +110,6 @@ &sdhc_1 { &tlmm { gpio-reserved-ranges = <22 2>, <28 6>; - - sdc2_state_on: sdc2-on { - clk { - pins = "sdc2_clk"; - bias-disable; - drive-strength = <16>; - }; - - cmd { - pins = "sdc2_cmd"; - bias-pull-up; - drive-strength = <10>; - }; - - data { - pins = "sdc2_data"; - bias-pull-up; - drive-strength = <10>; - }; - - sd-cd { - pins = "gpio98"; - bias-pull-up; - drive-strength = <2>; - }; - }; }; &usb3 {
arch/arm64/boot/dts/qcom/sm6125.dtsi +22 -2
@@ -389,20 +389,40 @@ tlmm: pinctrl@500000 { sdc2_state_off: sdc2-off { clk { pins = "sdc2_clk"; - bias-disable; drive-strength = <2>; + bias-disable; }; cmd { pins = "sdc2_cmd"; + drive-strength = <2>; bias-pull-up; + }; + + data { + pins = "sdc2_data"; drive-strength = <2>; + bias-pull-up; + }; + }; + + sdc2_state_on: sdc2-on { + clk { + pins = "sdc2_clk"; + drive-strength = <16>; + bias-disable; + }; + + cmd { + pins = "sdc2_cmd"; + drive-strength = <10>; + bias-pull-up; }; data { pins = "sdc2_data"; + drive-strength = <10>; bias-pull-up; - drive-strength = <2>; }; }; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 257/1157 arm64: dts: qcom: sm6125: Append -state suffix to pinctrl nodes
In reply to Greg Kroah-HartmanFrom: Marijn Suijten <[email protected]>
[ Upstream commit cbfb5668aece448877fa7826cde81c9d06f4a4ac ]
According to qcom,sm6125-pinctrl.yaml all nodes inside the tlmm must be suffixed by -state:
qcom/sm6125-sony-xperia-seine-pdx201.dtb: pinctrl@500000: 'sdc2-off', 'sdc2-on' do not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
The label names have been updated to match, going from sdc2_state_X to sdc2_X_state.
--- .../boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 4 ++-- arch/arm64/boot/dts/qcom/sm6125.dtsi | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts +2 -2
@@ -88,7 +88,7 @@ &hsusb_phy1 { status = "okay"; }; -&sdc2_state_off { +&sdc2_off_state { sd-cd { pins = "gpio98"; drive-strength = <2>;
@@ -96,7 +96,7 @@ sd-cd { }; }; -&sdc2_state_on { +&sdc2_on_state { sd-cd { pins = "gpio98"; drive-strength = <2>;
arch/arm64/boot/dts/qcom/sm6125.dtsi +4 -4
@@ -386,7 +386,7 @@ tlmm: pinctrl@500000 { interrupt-controller; #interrupt-cells = <2>; - sdc2_state_off: sdc2-off { + sdc2_off_state: sdc2-off-state { clk { pins = "sdc2_clk"; drive-strength = <2>;
@@ -406,7 +406,7 @@ data { }; }; - sdc2_state_on: sdc2-on { + sdc2_on_state: sdc2-on-state { clk { pins = "sdc2_clk"; drive-strength = <16>;
@@ -490,8 +490,8 @@ sdhc_2: sdhci@4784000 { <&xo_board>; clock-names = "iface", "core", "xo"; - pinctrl-0 = <&sdc2_state_on>; - pinctrl-1 = <&sdc2_state_off>; + pinctrl-0 = <&sdc2_on_state>; + pinctrl-1 = <&sdc2_off_state>; pinctrl-names = "default", "sleep"; power-domains = <&rpmpd SM6125_VDDCX>;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 258/1157 arm64: dts: qcom: msm8996: correct #clock-cells for QMP PHY nodes
In reply to Greg Kroah-HartmanFrom: Dmitry Baryshkov <[email protected]>
[ Upstream commit b874fff9a7683df30e5aff16d5a85b1f8a43aa5d ]
The commit 82d61e19fccb ("arm64: dts: qcom: msm8996: Move '#clock-cells' to QMP PHY child node") moved the '#clock-cells' properties to the child nodes. However it missed the fact that the property must have been set to <0> (as all pipe clocks use of_clk_hw_simple_get as the xlate function. Also the mentioned commit didn't add '#clock-cells' properties to second and third PCIe PHY nodes. Correct both these mistakes:
- Set '#clock-cells' to <0>,
- Add the property to pciephy_1 and pciephy_2 nodes.
--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/msm8996.dtsi +4 -2
@@ -609,7 +609,7 @@ pciephy_0: phy@35000 { <0x00035400 0x1dc>; #phy-cells = <0>; - #clock-cells = <1>; + #clock-cells = <0>; clock-output-names = "pcie_0_pipe_clk_src"; clocks = <&gcc GCC_PCIE_0_PIPE_CLK>; clock-names = "pipe0";
@@ -623,6 +623,7 @@ pciephy_1: phy@36000 { <0x00036400 0x1dc>; #phy-cells = <0>; + #clock-cells = <0>; clock-output-names = "pcie_1_pipe_clk_src"; clocks = <&gcc GCC_PCIE_1_PIPE_CLK>; clock-names = "pipe1";
@@ -636,6 +637,7 @@ pciephy_2: phy@37000 { <0x00037400 0x1dc>; #phy-cells = <0>; + #clock-cells = <0>; clock-output-names = "pcie_2_pipe_clk_src"; clocks = <&gcc GCC_PCIE_2_PIPE_CLK>; clock-names = "pipe2";
@@ -2769,7 +2771,7 @@ ssusb_phy_0: phy@7410200 { <0x07410600 0x1a8>; #phy-cells = <0>; - #clock-cells = <1>; + #clock-cells = <0>; clock-output-names = "usb3_phy_pipe_clk_src"; clocks = <&gcc GCC_USB3_PHY_PIPE_CLK>; clock-names = "pipe0";
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 259/1157 arm64: dts: qcom: sc7280: drop PCIe PHY clock index
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
[ Upstream commit 531c738fb36069d60aff267a0b25533a35d59fd0 ]
The QMP PCIe PHY provides a single clock so drop the redundant clock index.
--- arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sc7280.dtsi +2 -2
@@ -818,7 +818,7 @@ gcc: clock-controller@100000 { reg = <0 0x00100000 0 0x1f0000>; clocks = <&rpmhcc RPMH_CXO_CLK>, <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>, - <0>, <&pcie1_lane 0>, + <0>, <&pcie1_lane>, <0>, <0>, <0>, <0>; clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk", "pcie_0_pipe_clk", "pcie_1_pipe_clk",
@@ -2110,7 +2110,7 @@ pcie1_lane: phy@1c0e200 { clock-names = "pipe0"; #phy-cells = <0>; - #clock-cells = <1>; + #clock-cells = <0>; clock-output-names = "pcie_1_pipe_clk"; }; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 260/1157 arm64: dts: qcom: sm8250: add missing PCIe PHY clock-cells
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
[ Upstream commit d9fd162ce764c227fcfd4242f6c1639895a9481f ]
Add the missing '#clock-cells' properties to the PCIe QMP PHY nodes.
--- arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/qcom/sm8250.dtsi +6 -0
@@ -1884,6 +1884,8 @@ pcie0_lane: phy@1c06200 { clock-names = "pipe0"; #phy-cells = <0>; + + #clock-cells = <0>; clock-output-names = "pcie_0_pipe_clk"; }; };
@@ -1990,6 +1992,8 @@ pcie1_lane: phy@1c0e200 { clock-names = "pipe0"; #phy-cells = <0>; + + #clock-cells = <0>; clock-output-names = "pcie_1_pipe_clk"; }; };
@@ -2096,6 +2100,8 @@ pcie2_lane: phy@1c16200 { clock-names = "pipe0"; #phy-cells = <0>; + + #clock-cells = <0>; clock-output-names = "pcie_2_pipe_clk"; }; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 261/1157 arm64: dts: mt7622: fix BPI-R64 WPS button
In reply to Greg Kroah-HartmanFrom: Nick Hainke <[email protected]>
[ Upstream commit c98e6e683632386a3bd284acda4342e68aec4c41 ]
The bananapi R64 (BPI-R64) experiences wrong WPS button signals. In OpenWrt pushing the WPS button while powering on the device will set it to recovery mode. Currently, this also happens without any user interaction. In particular, the wrong signals appear while booting the device or restarting it, e.g. after doing a system upgrade. If the device is in recovery mode the user needs to manually power cycle or restart it.
The official BPI-R64 sources set the WPS button to GPIO_ACTIVE_LOW in the device tree. This setting seems to suppress the unwanted WPS button press signals. So this commit changes the button from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW.
The official BPI-R64 sources can be found on
https://github.com/BPI-SINOVOIP/BPI-R64-openwrt
--- arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts +1 -1
@@ -49,7 +49,7 @@ factory { wps { label = "wps"; linux,code = <KEY_WPS_BUTTON>; - gpios = <&pio 102 GPIO_ACTIVE_HIGH>; + gpios = <&pio 102 GPIO_ACTIVE_LOW>; }; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 262/1157 arm64: tegra: Mark BPMP channels as no-memory-wc
In reply to Greg Kroah-HartmanFrom: Mikko Perttunen <[email protected]>
[ Upstream commit 61192a9d8a6367ae1b8234876941b037910a2459 ]
The Tegra SYSRAM contains regions access to which is restricted to certain hardware blocks on the system, and speculative accesses to those will cause issues.
Patch 'misc: sram: Only map reserved areas in Tegra SYSRAM' attempted to resolve this by only mapping the regions specified in the device tree on the assumption that there are no such restricted areas within the 64K-aligned area of memory that contains the memory we wish to map.
Turns out this assumption is wrong, as there are such areas above the 4K pages described in the device trees. As such, we need to use the bigger hammer that is no-memory-wc, which causes the memory to be mapped as Device memory to which speculative accesses are disallowed.
As such, the previous patch in the series,
'firmware: tegra: bpmp: do only aligned access to IPC memory area',
is required with this patch to make the BPMP driver only issue aligned memory accesses as those are also required with Device memory.
--- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 1 + arch/arm64/boot/dts/nvidia/tegra194.dtsi | 1 + arch/arm64/boot/dts/nvidia/tegra234.dtsi | 1 + 3 files changed, 3 insertions(+)
arch/arm64/boot/dts/nvidia/tegra186.dtsi +1 -0
@@ -1820,6 +1820,7 @@ sram@30000000 { #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x0 0x30000000 0x50000>; + no-memory-wc; cpu_bpmp_tx: sram@4e000 { reg = <0x4e000 0x1000>;
arch/arm64/boot/dts/nvidia/tegra194.dtsi +1 -0
@@ -2684,6 +2684,7 @@ sram@40000000 { #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x0 0x40000000 0x50000>; + no-memory-wc; cpu_bpmp_tx: sram@4e000 { reg = <0x4e000 0x1000>;
arch/arm64/boot/dts/nvidia/tegra234.dtsi +1 -0
@@ -1325,6 +1325,7 @@ sram@40000000 { #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x0 0x40000000 0x80000>; + no-memory-wc; cpu_bpmp_tx: sram@70000 { reg = <0x70000 0x1000>;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 263/1157 arm64: tegra: Fix SDMMC1 CD on P2888
In reply to Greg Kroah-HartmanFrom: Tamás Szűcs <[email protected]>
[ Upstream commit b415bb7c976f1d595ed752001c0938f702645dab ]
Hook SDMMC1 CD up with CVM GPIO02 (SOC_GPIO11) used for card detection on J4 (uSD socket) on the carrier.
--- arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi +1 -1
@@ -75,7 +75,7 @@ eeprom@50 { /* SDMMC1 (SD/MMC) */ mmc@3400000 { - cd-gpios = <&gpio TEGRA194_MAIN_GPIO(A, 0) GPIO_ACTIVE_LOW>; + cd-gpios = <&gpio TEGRA194_MAIN_GPIO(G, 7) GPIO_ACTIVE_LOW>; }; /* SDMMC4 (eMMC) */
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 264/1157 arm64: dts: qcom: sc7280: fix PCIe clock reference
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
[ Upstream commit 330fc08dbdd913ac37a31f8aec1a88f68e39ae39 ]
The recent commit that dropped the PCIe PHY clock index failed to update the PCIe node reference.
--- arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sc7280.dtsi +1 -1
@@ -2035,7 +2035,7 @@ pcie1: pci@1c08000 { clocks = <&gcc GCC_PCIE_1_PIPE_CLK>, <&gcc GCC_PCIE_1_PIPE_CLK_SRC>, - <&pcie1_lane 0>, + <&pcie1_lane>, <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_PCIE_1_AUX_CLK>, <&gcc GCC_PCIE_1_CFG_AHB_CLK>,
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 265/1157 erofs: wake up all waiters after z_erofs_lzma_head ready
In reply to Greg Kroah-HartmanFrom: Yuwen Chen <[email protected]>
[ Upstream commit 2df7c4bd7c1d2bc5ece5e9ed19dbd386810c2a65 ]
When the user mounts the erofs second times, the decompression thread may hung. The problem happens due to a sequence of steps like the following:
1) Task A called z_erofs_load_lzma_config which obtain all of the node from the z_erofs_lzma_head.
2) At this time, task B called the z_erofs_lzma_decompress and wanted to get a node. But the z_erofs_lzma_head was empty, the Task B had to sleep.
3) Task A release nodes and push nodes into the z_erofs_lzma_head. But task B was still sleeping.
One example report when the hung happens:
task:kworker/u3:1 state:D stack:14384 pid: 86 ppid: 2 flags:0x00004000
Workqueue: erofs_unzipd z_erofs_decompressqueue_work Call Trace: <TASK> __schedule+0x281/0x760 schedule+0x49/0xb0 z_erofs_lzma_decompress+0x4bc/0x580 ? cpu_core_flags+0x10/0x10 z_erofs_decompress_pcluster+0x49b/0xba0 ? __update_load_avg_se+0x2b0/0x330 ? __update_load_avg_se+0x2b0/0x330 ? update_load_avg+0x5f/0x690 ? update_load_avg+0x5f/0x690 ? set_next_entity+0xbd/0x110 ? _raw_spin_unlock+0xd/0x20 z_erofs_decompress_queue.isra.0+0x2e/0x50 z_erofs_decompressqueue_work+0x30/0x60 process_one_work+0x1d3/0x3a0 worker_thread+0x45/0x3a0 ? process_one_work+0x3a0/0x3a0 kthread+0xe2/0x110 ? kthread_complete_and_exit+0x20/0x20 ret_from_fork+0x22/0x30 </TASK>
--- fs/erofs/decompressor_lzma.c | 1 + 1 file changed, 1 insertion(+)
fs/erofs/decompressor_lzma.c +1 -0
@@ -143,6 +143,7 @@ int z_erofs_load_lzma_config(struct super_block *sb,DBG_BUGON (z_erofs_lzma_head); z_erofs_lzma_head = head;spin_unlock (&z_erofs_lzma_lock); +wake_up_all (&z_erofs_lzma_wq); z_erofs_lzma_max_dictsize = dict_size;mutex_unlock (&lzma_resize_mutex);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 266/1157 erofs: avoid consecutive detection for Highmem memory
In reply to Greg Kroah-HartmanFrom: Gao Xiang <[email protected]>
[ Upstream commit 448b5a1548d87c246c3d0c3df8480d3c6eb6c11a ]
Currently, vmap()s are avoided if physical addresses are consecutive for decompressed buffers.
I observed that is very common for 4KiB pclusters since the numbers of decompressed pages are almost 2 or 3.
However, such detection doesn't work for Highmem pages on 32-bit machines, let's fix it now.
--- fs/erofs/decompressor.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
fs/erofs/decompressor.c +10 -6
@@ -91,14 +91,18 @@ static int z_erofs_lz4_prepare_dstpages(struct z_erofs_lz4_decompress_ctx *ctx,if (page) {__clear_bit (j, bounced); -if (kaddr) { -if (kaddr +PAGE_SIZE ==page_address (page)) +if (!PageHighMem (page)) { +if (!i) { + kaddr =page_address (page); +continue ; + } +if (kaddr && + kaddr +PAGE_SIZE ==page_address (page)) { kaddr +=PAGE_SIZE ; -else - kaddr =NULL ; - }else if (!i) { - kaddr =page_address (page); +continue ; + } } + kaddr =NULL ;continue ; } kaddr =NULL ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 267/1157 spi: Return deferred probe error when controller isnt yet available
In reply to Greg Kroah-HartmanFrom: Andy Shevchenko <[email protected]>
[ Upstream commit 9c22ec4ac27bcc5a54dd406da168f403327a5b55 ]
If the controller is not available, it might be in the future and we would like to re-probe the peripheral again. For that purpose return deferred probe.
--- drivers/spi/spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi.c +1 -1
@@ -2398,7 +2398,7 @@ static int acpi_spi_add_resource(struct acpi_resource *ares, void *data) ctlr =acpi_spi_find_controller_by_adev (adev);if (!ctlr) -return -ENODEV ; +return -EPROBE_DEFER ; lookup->ctlr = ctlr; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 268/1157 blk-mq: dont create hctx debugfs dir until q->debugfs_dir is created
In reply to Greg Kroah-HartmanFrom: Ming Lei <[email protected]>
[ Upstream commit f3ec5d11554778c24ac8915e847223ed71d104fc ]
blk_mq_debugfs_register_hctx() can be called by blk_mq_update_nr_hw_queues when gendisk isn't added yet, such as nvme tcp.
Fixes the warning of 'debugfs: Directory 'hctx0' with parent '/' already present!' which can be observed reliably when running blktests nvme/005.
--- block/blk-mq-debugfs.c | 3 +++ 1 file changed, 3 insertions(+)
block/blk-mq-debugfs.c +3 -0
@@ -730,6 +730,9 @@ void blk_mq_debugfs_register_hctx(struct request_queue *q,char name[20 ];int i; +if (!q->debugfs_dir) +return ; +snprintf (name,sizeof (name),"hctx%u" , hctx->queue_num); hctx->debugfs_dir =debugfs_create_dir (name, q->debugfs_dir);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 269/1157 spi: dw: Fix IP-core versions macro
In reply to Greg Kroah-HartmanFrom: Nandhini Srikandan <[email protected]>
[ Upstream commit 5d76b7509cb223e94ff73a672273e58f1957ac68 ]
Add the missing underscore in IP version macro to avoid compilation issue. The macro is used for IP version comparison in the current patchset.
--- drivers/spi/spi-dw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-dw.h +1 -1
@@ -23,7 +23,7 @@ ((_dws)->ip == DW_ ## _ip ## _ID)#define __dw_spi_ver_cmp (_dws, _ip, _ver, _op) \ - (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ver) + (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ ## _ver)#define dw_spi_ver_is (_dws, _ip, _ver) __dw_spi_ver_cmp(_dws, _ip, _ver, ==)
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 270/1157 spi: Fix simplification of devm_spi_register_controller
In reply to Greg Kroah-HartmanFrom: Yang Yingliang <[email protected]>
[ Upstream commit 43cc5a0afe4184a7fafe1eba32b5a11bb69c9ce0 ]
This reverts commit 59ebbe40fb51 ("spi: simplifydevm_spi_register_controller").
If devm_add_action() fails in devm_add_action_or_reset(), devm_spi_unregister() will be called, it decreases the refcount of 'ctlr->dev' to 0, then it will cause uaf in the drivers that calling spi_put_controller() in error path.
--- drivers/spi/spi.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)
drivers/spi/spi.c +14 -5
@@ -3050,9 +3050,9 @@ int spi_register_controller(struct spi_controller *ctlr) }EXPORT_SYMBOL_GPL (spi_register_controller); -static void devm_spi_unregister (void *ctlr) +static void devm_spi_unregister (struct device *dev,void *res) { -spi_unregister_controller (ctlr); +spi_unregister_controller (*(struct spi_controller **)res); }/**
@@ -3071,13 +3071,22 @@ static void devm_spi_unregister(void *ctlr)int devm_spi_register_controller (struct device *dev,struct spi_controller *ctlr) { +struct spi_controller **ptr;int ret; + ptr =devres_alloc (devm_spi_unregister,sizeof (*ptr),GFP_KERNEL ); +if (!ptr) +return -ENOMEM ; + ret =spi_register_controller (ctlr); -if (ret) -return ret; +if (!ret) { + *ptr = ctlr; +devres_add (dev, ptr); + }else { +devres_free (ptr); + } -return devm_add_action_or_reset (dev, devm_spi_unregister, ctlr); +return ret; }EXPORT_SYMBOL_GPL (devm_spi_register_controller);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 271/1157 spi: tegra20-slink: fix UAF in tegra_slink_remove()
In reply to Greg Kroah-HartmanFrom: Yang Yingliang <[email protected]>
[ Upstream commit 7e9984d183bb1e99e766c5c2b950ff21f7f7b6c0 ]
After calling spi_unregister_master(), the refcount of master will be decrease to 0, and it will be freed in spi_controller_release(), the device data also will be freed, so it will lead a UAF when using 'tspi'. To fix this, get the master before unregister and put it when finish using it.
--- drivers/spi/spi-tegra20-slink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/spi/spi-tegra20-slink.c +2 -1
@@ -1136,7 +1136,7 @@ static int tegra_slink_probe(struct platform_device *pdev)static int tegra_slink_remove (struct platform_device *pdev) { -struct spi_master *master =platform_get_drvdata (pdev); +struct spi_master *master =spi_master_get (platform_get_drvdata (pdev));struct tegra_slink_data *tspi =spi_master_get_devdata (master);spi_unregister_master (master);
@@ -1151,6 +1151,7 @@ static int tegra_slink_remove(struct platform_device *pdev)if (tspi->rx_dma_chan)tegra_slink_deinit_dma_param (tspi, true); +spi_master_put (master);return 0 ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 272/1157 hwmon: (sch56xx-common) Add DMI override table
In reply to Greg Kroah-HartmanFrom: Armin Wolf <[email protected]>
[ Upstream commit fd2d53c367ae9983c2100ac733a834e0c79d7537 ]
Some devices like the Fujitsu Celsius W380 do contain a working sch56xx hardware monitoring device, but do not contain the necessary DMI onboard device.
Do not check for the presence of an suitable onboard device on these machines. The list of affected machines was created using data collected by the Linux Hardware Project.
Tested on a Fujitsu Esprimo P720, but sadly not on a affected machine.
--- drivers/hwmon/sch56xx-common.c | 44 ++++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 10 deletions(-)
drivers/hwmon/sch56xx-common.c +34 -10
@@ -523,6 +523,28 @@ static int __init sch56xx_device_add(int address, const char *name)return PTR_ERR_OR_ZERO (sch56xx_pdev); } +static const struct dmi_system_id sch56xx_dmi_override_table[]__initconst = { + { + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"FUJITSU" ), +DMI_MATCH (DMI_PRODUCT_NAME ,"CELSIUS W380" ), + }, + }, + { + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"FUJITSU" ), +DMI_MATCH (DMI_PRODUCT_NAME ,"ESPRIMO P710" ), + }, + }, + { + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"FUJITSU" ), +DMI_MATCH (DMI_PRODUCT_NAME ,"ESPRIMO E9900" ), + }, + }, + { } +}; +/* For autoloading only */ static const struct dmi_system_id sch56xx_dmi_table[]__initconst = { {
@@ -543,16 +565,18 @@ static int __init sch56xx_init(void)if (!dmi_check_system (sch56xx_dmi_table))return -ENODEV ; -/* -* Some machines like the Esprimo P720 and Esprimo C700 have -* onboard devices named " Antiope"/" Theseus" instead of -* "Antiope"/"Theseus", so we need to check for both. -*/ -if (!dmi_find_device (DMI_DEV_TYPE_OTHER ,"Antiope" ,NULL ) && - !dmi_find_device (DMI_DEV_TYPE_OTHER ," Antiope" ,NULL ) && - !dmi_find_device (DMI_DEV_TYPE_OTHER ,"Theseus" ,NULL ) && - !dmi_find_device (DMI_DEV_TYPE_OTHER ," Theseus" ,NULL )) -return -ENODEV ; +if (!dmi_check_system (sch56xx_dmi_override_table)) { +/* +* Some machines like the Esprimo P720 and Esprimo C700 have +* onboard devices named " Antiope"/" Theseus" instead of +* "Antiope"/"Theseus", so we need to check for both. +*/ +if (!dmi_find_device (DMI_DEV_TYPE_OTHER ,"Antiope" ,NULL ) && + !dmi_find_device (DMI_DEV_TYPE_OTHER ," Antiope" ,NULL ) && + !dmi_find_device (DMI_DEV_TYPE_OTHER ,"Theseus" ,NULL ) && + !dmi_find_device (DMI_DEV_TYPE_OTHER ," Theseus" ,NULL )) +return -ENODEV ; + } }/*
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 273/1157 hwmon: (drivetemp) Add module alias
In reply to Greg Kroah-HartmanFrom: Linus Walleij <[email protected]>
[ Upstream commit 5918036cfa8ded7aa8094db70295011ce2275447 ]
Adding a MODULE_ALIAS() to drivetemp will make the driver easier for modprobe to autoprobe.
--- drivers/hwmon/drivetemp.c | 1 + 1 file changed, 1 insertion(+)
drivers/hwmon/drivetemp.c +1 -0
@@ -621,3 +621,4 @@ module_exit(drivetemp_exit);MODULE_AUTHOR ("Guenter Roeck <[email protected]>" );MODULE_DESCRIPTION ("Hard drive temperature monitor" );MODULE_LICENSE ("GPL" ); +MODULE_ALIAS ("platform:drivetemp" );
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 274/1157 blktrace: Trace remapped requests correctly
In reply to Greg Kroah-HartmanFrom: Bart Van Assche <[email protected]>
[ Upstream commit 22c80aac882f712897b88b7ea8f5a74ea19019df ]
Trace the remapped operation and its flags instead of only the data direction of remapped operations. This issue was detected by analyzing the warnings reported by sparse related to the new blk_opf_t type.
--- kernel/trace/blktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/blktrace.c +1 -1
@@ -1058,7 +1058,7 @@ static void blk_add_trace_rq_remap(void *ignore, struct request *rq, dev_t dev, r.sector_from =cpu_to_be64 (from);__blk_add_trace (bt,blk_rq_pos (rq),blk_rq_bytes (rq), -rq_data_dir (rq),0 ,BLK_TA_REMAP ,0 , +req_op (rq), rq->cmd_flags,BLK_TA_REMAP ,0 ,sizeof (r), &r,blk_trace_request_get_cgid (rq));rcu_read_unlock (); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 275/1157 PM: domains: Ensure genpd_debugfs_dir exists before remove
In reply to Greg Kroah-HartmanFrom: Hsin-Yi Wang <[email protected]>
[ Upstream commit 37101d3c719386040ded735a5ec06974f1d94d1f ]
Both genpd_debug_add() and genpd_debug_remove() may be called indirectly by other drivers while genpd_debugfs_dir is not yet set. For example, drivers can call pm_genpd_init() in probe or pm_genpd_init() in probe fail/cleanup path:
pm_genpd_init()
--> genpd_debug_add()
pm_genpd_remove()
--> genpd_remove()
--> genpd_debug_remove()
At this time, genpd_debug_init() may not yet be called.
genpd_debug_add() checks that if genpd_debugfs_dir is NULL, it will return directly. Make sure this is also checked in pm_genpd_remove(), otherwise components under debugfs root which has the same name as other components under pm_genpd may be accidentally removed, since NULL represents debugfs root.
--- drivers/base/power/domain.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/base/power/domain.c +3 -0
@@ -222,6 +222,9 @@ static void genpd_debug_remove(struct generic_pm_domain *genpd) {struct dentry *d; +if (!genpd_debugfs_dir) +return ; + d =debugfs_lookup (genpd->name, genpd_debugfs_dir);debugfs_remove (d); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 276/1157 dm writecache: return void from functions
In reply to Greg Kroah-HartmanFrom: Mikulas Patocka <[email protected]>
[ Upstream commit 9bc0c92e4b82adb017026dbb2aa816b1ac2bef31 ]
The functions writecache_map_remap_origin and writecache_bio_copy_ssd only return a single value, thus they can be made to return void.
This helps simplify the following IO accounting changes.
--- drivers/md/dm-writecache.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)
drivers/md/dm-writecache.c +13 -13
@@ -1329,8 +1329,8 @@ enum wc_map_op { WC_MAP_ERROR, }; -static enum wc_map_op writecache_map_remap_origin (struct dm_writecache *wc,struct bio *bio, -struct wc_entry *e) +static void writecache_map_remap_origin (struct dm_writecache *wc,struct bio *bio, +struct wc_entry *e) {if (e) { sector_t next_boundary =
@@ -1338,8 +1338,6 @@ static enum wc_map_op writecache_map_remap_origin(struct dm_writecache *wc, struif (next_boundary < bio->bi_iter.bi_size >>SECTOR_SHIFT )dm_accept_partial_bio (bio, next_boundary); } - -return WC_MAP_REMAP_ORIGIN ; }static enum wc_map_op writecache_map_read (struct dm_writecache *wc,struct bio *bio)
@@ -1366,14 +1364,15 @@ static enum wc_map_op writecache_map_read(struct dm_writecache *wc, struct bio * map_op =WC_MAP_REMAP ; } }else { - map_op =writecache_map_remap_origin (wc, bio, e); +writecache_map_remap_origin (wc, bio, e); + map_op =WC_MAP_REMAP_ORIGIN ; }return map_op; } -static enum wc_map_op writecache_bio_copy_ssd (struct dm_writecache *wc,struct bio *bio, -struct wc_entry *e,bool search_used) +static void writecache_bio_copy_ssd (struct dm_writecache *wc,struct bio *bio, +struct wc_entry *e,bool search_used) {unsigned bio_size = wc->block_size;sector_t start_cache_sec =cache_sector (wc, e);
@@ -1419,8 +1418,6 @@ static enum wc_map_op writecache_bio_copy_ssd(struct dm_writecache *wc, struct b }else {writecache_schedule_autocommit (wc); } - -return WC_MAP_REMAP ; }static enum wc_map_op writecache_map_write (struct dm_writecache *wc,struct bio *bio)
@@ -1458,7 +1455,8 @@ static enum wc_map_op writecache_map_write(struct dm_writecache *wc, struct bio direct_write: wc->stats.writes_around++; e =writecache_find_entry (wc, bio->bi_iter.bi_sector,WFE_RETURN_FOLLOWING ); -return writecache_map_remap_origin (wc, bio, e); +writecache_map_remap_origin (wc, bio, e); +return WC_MAP_REMAP_ORIGIN ; } wc->stats.writes_blocked_on_freelist++;writecache_wait_on_freelist (wc);
@@ -1469,10 +1467,12 @@ static enum wc_map_op writecache_map_write(struct dm_writecache *wc, struct bio wc->uncommitted_blocks++; wc->stats.writes_allocate++; bio_copy: -if (WC_MODE_PMEM (wc)) +if (WC_MODE_PMEM (wc)) {bio_copy_block (wc, bio,memory_data (wc, e)); -else -return writecache_bio_copy_ssd (wc, bio, e, search_used); + }else { +writecache_bio_copy_ssd (wc, bio, e, search_used); +return WC_MAP_REMAP ; + } }while (bio->bi_iter.bi_size);if (unlikely (bio->bi_opf &REQ_FUA || wc->uncommitted_blocks >= wc->autocommit_blocks))
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 277/1157 dm writecache: count number of blocks read, not number of read bios
In reply to Greg Kroah-HartmanFrom: Mikulas Patocka <[email protected]>
[ Upstream commit 2c6e755b49d273243431f5f1184654e71221fc78 ]
Change dm-writecache, so that it counts the number of blocks read instead of the number of read bios. Bios can be split and requeued using the dm_accept_partial_bio function, so counting bios caused inaccurate results.
--- Documentation/admin-guide/device-mapper/writecache.rst | 4 ++-- drivers/md/dm-writecache.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-)
Documentation/admin-guide/device-mapper/writecache.rst +2 -2
@@ -78,8 +78,8 @@ Status: 2. the number of blocks 3. the number of free blocks 4. the number of blocks under writeback -5. the number of read requests -6. the number of read requests that hit the cache +5. the number of read blocks +6. the number of read blocks that hit the cache 7. the number of write requests 8. the number of write requests that hit uncommitted block 9. the number of write requests that hit committed block
drivers/md/dm-writecache.c +1 -0
@@ -1365,6 +1365,7 @@ static enum wc_map_op writecache_map_read(struct dm_writecache *wc, struct bio * } }else {writecache_map_remap_origin (wc, bio, e); + wc->stats.reads += (bio->bi_iter.bi_size - wc->block_size) >> wc->block_size_bits; map_op =WC_MAP_REMAP_ORIGIN ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 278/1157 dm writecache: count number of blocks written, not number of write bios
In reply to Greg Kroah-HartmanFrom: Mikulas Patocka <[email protected]>
[ Upstream commit b2676e1482af89714af6988ce5d31a84692e2530 ]
Change dm-writecache, so that it counts the number of blocks written instead of the number of write bios. Bios can be split and requeued using the dm_accept_partial_bio function, so counting bios caused inaccurate results.
--- .../admin-guide/device-mapper/writecache.rst | 10 +++++----- drivers/md/dm-writecache.c | 12 +++++++++--- 2 files changed, 14 insertions(+), 8 deletions(-)
Documentation/admin-guide/device-mapper/writecache.rst +5 -5
@@ -80,11 +80,11 @@ Status: 4. the number of blocks under writeback 5. the number of read blocks 6. the number of read blocks that hit the cache -7. the number of write requests -8. the number of write requests that hit uncommitted block -9. the number of write requests that hit committed block -10. the number of write requests that bypass the cache -11. the number of write requests that are allocated in the cache +7. the number of write blocks +8. the number of write blocks that hit uncommitted block +9. the number of write blocks that hit committed block +10. the number of write blocks that bypass the cache +11. the number of write blocks that are allocated in the cache 12. the number of write requests that are blocked on the freelist 13. the number of flush requests 14. the number of discard requests
drivers/md/dm-writecache.c +9 -3
@@ -1413,6 +1413,9 @@ static void writecache_bio_copy_ssd(struct dm_writecache *wc, struct bio *bio, bio->bi_iter.bi_sector = start_cache_sec;dm_accept_partial_bio (bio, bio_size >>SECTOR_SHIFT ); + wc->stats.writes += bio->bi_iter.bi_size >> wc->block_size_bits; + wc->stats.writes_allocate += (bio->bi_iter.bi_size - wc->block_size) >> wc->block_size_bits; +if (unlikely (wc->uncommitted_blocks >= wc->autocommit_blocks)) { wc->uncommitted_blocks =0 ;queue_work (wc->writeback_wq, &wc->flush_work);
@@ -1428,9 +1431,10 @@ static enum wc_map_op writecache_map_write(struct dm_writecache *wc, struct bio do { bool found_entry = false; bool search_used = false; - wc->stats.writes++; - if (writecache_has_error(wc)) + if (writecache_has_error(wc)) { + wc->stats.writes += bio->bi_iter.bi_size >> wc->block_size_bits; return WC_MAP_ERROR; + } e = writecache_find_entry(wc, bio->bi_iter.bi_sector, 0); if (e) { if (!writecache_entry_is_committed(wc, e)) {
@@ -1454,9 +1458,10 @@ static enum wc_map_op writecache_map_write(struct dm_writecache *wc, struct bioif (unlikely (!e)) {if (!WC_MODE_PMEM (wc) && !found_entry) { direct_write: - wc->stats.writes_around++; e =writecache_find_entry (wc, bio->bi_iter.bi_sector,WFE_RETURN_FOLLOWING );writecache_map_remap_origin (wc, bio, e); + wc->stats.writes_around += bio->bi_iter.bi_size >> wc->block_size_bits; + wc->stats.writes += bio->bi_iter.bi_size >> wc->block_size_bits;return WC_MAP_REMAP_ORIGIN ; } wc->stats.writes_blocked_on_freelist++;
@@ -1470,6 +1475,7 @@ static enum wc_map_op writecache_map_write(struct dm_writecache *wc, struct bio bio_copy:if (WC_MODE_PMEM (wc)) {bio_copy_block (wc, bio,memory_data (wc, e)); + wc->stats.writes++; }else {writecache_bio_copy_ssd (wc, bio, e, search_used);return WC_MAP_REMAP ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 279/1157 dm writecache: count number of blocks discarded, not number of discard bios
In reply to Greg Kroah-HartmanFrom: Mikulas Patocka <[email protected]>
[ Upstream commit 2ee73ef60db4d79b9f9b8cd501e8188b5179449f ]
Change dm-writecache, so that it counts the number of blocks discarded instead of the number of discard bios. Make it consistent with the read and write statistics counters that were changed to count the number of blocks instead of bios.
--- Documentation/admin-guide/device-mapper/writecache.rst | 2 +- drivers/md/dm-writecache.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/admin-guide/device-mapper/writecache.rst +1 -1
@@ -87,7 +87,7 @@ Status: 11. the number of write blocks that are allocated in the cache 12. the number of write requests that are blocked on the freelist 13. the number of flush requests -14. the number of discard requests +14. the number of discarded blocks Messages: flush
drivers/md/dm-writecache.c +1 -1
@@ -1514,7 +1514,7 @@ static enum wc_map_op writecache_map_flush(struct dm_writecache *wc, struct biostatic enum wc_map_op writecache_map_discard (struct dm_writecache *wc,struct bio *bio) { - wc->stats.discards++; + wc->stats.discards += bio->bi_iter.bi_size >> wc->block_size_bits;if (writecache_has_error (wc))return WC_MAP_ERROR ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 280/1157 regulator: of: Fix refcount leak bug in of_get_regulation_constraints()
In reply to Greg Kroah-HartmanFrom: Liang He <[email protected]>
[ Upstream commit 66efb665cd5ad69b27dca8571bf89fc6b9c628a4 ]
We should call the of_node_put() for the reference returned by of_get_child_by_name() which has increased the refcount.
--- drivers/regulator/of_regulator.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/regulator/of_regulator.c +5 -1
@@ -264,8 +264,12 @@ static int of_get_regulation_constraints(struct device *dev, } suspend_np =of_get_child_by_name (np, regulator_states[i]); -if (!suspend_np || !suspend_state) +if (!suspend_np)continue ; +if (!suspend_state) { +of_node_put (suspend_np); +continue ; + }if (!of_property_read_u32 (suspend_np,"regulator-mode" , &pval)) {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 281/1157 soc: qcom: Make QCOM_RPMPD depend on PM
In reply to Greg Kroah-HartmanFrom: Konrad Dybcio <[email protected]>
[ Upstream commit a6232f2aa99ce470799992e99e0012945bb5308f ]
QCOM_RPMPD requires PM_GENERIC_DOMAINS/_OF, which in turns requires CONFIG_PM. I forgot about the latter in my earlier patch (it's still in -next as of the time of committing, hence no Fixes: tag). Fix it.
--- drivers/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/soc/qcom/Kconfig +1 -0
@@ -129,6 +129,7 @@ config QCOM_RPMHPD config QCOM_RPMPD tristate "Qualcomm RPM Power domain driver" + depends on PM depends on QCOM_SMD_RPM help QCOM RPM Power domain driver to support power-domains with
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 282/1157 soc: qcom: socinfo: Fix the id of SA8540P SoC
In reply to Greg Kroah-HartmanFrom: Parikshit Pareek <[email protected]>
[ Upstream commit 5bed21af0005cc7d8bb05d2c4a63afbcede23382 ]
Change the id of SA8540P to its correct value, i.e., 461. Also, map the id 460 to its correct values, i.e. SA8295P.
--- drivers/soc/qcom/socinfo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/soc/qcom/socinfo.c +2 -1
@@ -328,7 +328,8 @@ static const struct soc_id soc_id[] = { { 455, "QRB5165" }, { 457, "SM8450" }, { 459, "SM7225" }, - { 460, "SA8540P" }, + { 460, "SA8295P" }, + { 461, "SA8540P" }, { 480, "SM8450" }, { 482, "SM8450" }, { 487, "SC7280" },
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 283/1157 arm64: dts: qcom: msm8998: Make regulator voltages multiple of step-size
In reply to Greg Kroah-HartmanFrom: Marijn Suijten <[email protected]>
[ Upstream commit 2aa54fa87cca1fa43870a9caf4fcce00eb087fa5 ]
These voltages are not a multiple of the given step-size 8000 (with base voltage 1664000) in pm8998_pldo, resulting in PLDO regulators l18 and l22 failing to validate and in turn not probing the rpm-pm8998-regulator driver:
l18: unsupportable voltage constraints 2856000-2848000uV
qcom_rpm_smd_regulator rpm-glink:rpm-requests:pm8998-regulators: l18: devm_regulator_register() failed, ret=-22
Round the voltages down for the sake of erring on the safe side, leaving a comment in place to document this discrepancy wrt downstream sources.
--- .../dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts +6 -4
@@ -26,11 +26,13 @@ &lab { }; &vreg_l18a_2p85 { - regulator-min-microvolt = <2850000>; - regulator-max-microvolt = <2850000>; + /* Note: Round-down from 2850000 to be a multiple of PLDO step-size 8000 */ + regulator-min-microvolt = <2848000>; + regulator-max-microvolt = <2848000>; }; &vreg_l22a_2p85 { - regulator-min-microvolt = <2700000>; - regulator-max-microvolt = <2700000>; + /* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 */ + regulator-min-microvolt = <2696000>; + regulator-max-microvolt = <2696000>; };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 284/1157 arm64: dts: qcom: qcs404: Fix incorrect USB2 PHYs assignment
In reply to Greg Kroah-HartmanFrom: Sumit Garg <[email protected]>
[ Upstream commit 58577966a42fc0b660b5e2c7c9e5a2241363ea83 ]
Currently the DT for QCS404 SoC has setup for 2 USB2 PHYs with one each assigned to USB3 controller and USB2 controller. This assignment is incorrect which only works by luck: as when each USB HCI comes up it configures the *other* controllers PHY which is enough to make them happy. If, for any reason, we were to disable one of the controllers then both would stop working.
This was a difficult inconsistency to be caught which was found while trying to enable USB support in u-boot. So with all the required drivers ported to u-boot, I couldn't get the same USB storage device enumerated in u-boot which was being enumerated fine by the kernel.
The root cause of the problem came out to be that I wasn't enabling USB2
PHY: "usb2_phy_prim" in u-boot. Then I realised that via simply disabling the same USB2 PHY currently assigned to USB2 host controller in the kernel disabled enumeration for USB3 host controller as well.
So fix this inconsistency by correctly assigning USB2 PHYs.
--- arch/arm64/boot/dts/qcom/qcs404.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/qcs404.dtsi +2 -2
@@ -548,7 +548,7 @@ usb3_dwc3: usb@7580000 { compatible = "snps,dwc3"; reg = <0x07580000 0xcd00>; interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>; - phys = <&usb2_phy_sec>, <&usb3_phy>; + phys = <&usb2_phy_prim>, <&usb3_phy>; phy-names = "usb2-phy", "usb3-phy"; snps,has-lpm-erratum; snps,hird-threshold = /bits/ 8 <0x10>;
@@ -577,7 +577,7 @@ usb@78c0000 { compatible = "snps,dwc3"; reg = <0x078c0000 0xcc00>; interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; - phys = <&usb2_phy_prim>; + phys = <&usb2_phy_sec>; phy-names = "usb2-phy"; snps,has-lpm-erratum; snps,hird-threshold = /bits/ 8 <0x10>;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 285/1157 ARM: dts: qcom: msm8974: Disable remoteprocs by default
In reply to Greg Kroah-HartmanFrom: Stephan Gerhold <[email protected]>
[ Upstream commit 8d8be8dd7c1f5d50f84ecc7a6a41962da48c6164 ]
The remoteproc configuration in qcom-msm8974.dtsi is incomplete because it lacks the regulator supplies that should be added in the board DT files. Some of the msm8974 boards are currently missing the regulator supplies and should have the remoteprocs disabled to avoid making use of the incomplete configuration.
This also fixes dtbs_check warnings after moving "qcom,msm8974-mss-pil" to DT schema, which rightfully complains that the -supply properties are missing for some boards:
qcom-apq8074-dragonboard.dtb:
remoteproc@fc880000: 'pll-supply' is a required property
From schema: remoteproc/qcom,msm8916-mss-pil.yaml
remoteproc@fc880000: 'mss-supply' is a required property
From schema: remoteproc/qcom,msm8916-mss-pil.yaml
remoteproc@fc880000: 'oneOf' conditional failed, one must be fixed:
'power-domains' is a required property 'power-domain-names' is a required property, or 'cx-supply' is a required property
'mx-supply' is a required property
--- arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++++ arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts | 2 ++ arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts | 2 ++ 3 files changed, 8 insertions(+)
arch/arm/boot/dts/qcom-msm8974.dtsi +4 -0
@@ -1182,6 +1182,8 @@ remoteproc_mss: remoteproc@fc880000 { qcom,smem-states = <&modem_smp2p_out 0>; qcom,smem-state-names = "stop"; + status = "disabled"; + mba { memory-region = <&mba_region>; };
@@ -1662,6 +1664,8 @@ remoteproc_adsp: remoteproc@fe200000 { qcom,smem-states = <&adsp_smp2p_out 0>; qcom,smem-state-names = "stop"; + status = "disabled"; + smd-edge { interrupts = <GIC_SPI 156 IRQ_TYPE_EDGE_RISING>;
arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts +2 -0
@@ -147,10 +147,12 @@ wcnss { }; &remoteproc_adsp { + status = "okay"; cx-supply = <&pm8841_s2>; }; &remoteproc_mss { + status = "okay"; cx-supply = <&pm8841_s2>; mss-supply = <&pm8841_s3>; mx-supply = <&pm8841_s1>;
arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts +2 -0
@@ -457,10 +457,12 @@ fuelgauge_pin: fuelgauge-int-pin { }; &remoteproc_adsp { + status = "okay"; cx-supply = <&pma8084_s2>; }; &remoteproc_mss { + status = "okay"; cx-supply = <&pma8084_s2>; mss-supply = <&pma8084_s6>; mx-supply = <&pma8084_s1>;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 286/1157 irqdomain: Report irq number for NOMAP domains
In reply to Greg Kroah-HartmanFrom: Xu Qiang <[email protected]>
[ Upstream commit 6f194c99f466147148cc08452718b46664112548 ]
When using a NOMAP domain, __irq_resolve_mapping() doesn't store the Linux IRQ number at the address optionally provided by the caller. While this isn't a huge deal (the returned value is guaranteed to the hwirq that was passed as a parameter), let's honour the letter of the API by writing the expected value.
--- kernel/irq/irqdomain.c | 2 ++ 1 file changed, 2 insertions(+)
kernel/irq/irqdomain.c +2 -0
@@ -910,6 +910,8 @@ struct irq_desc *__irq_resolve_mapping(struct irq_domain *domain, data =irq_domain_get_irq_data (domain, hwirq);if (data && data->hwirq == hwirq) desc =irq_data_to_desc (data); +if (irq && desc) + *irq = hwirq; }return desc;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 287/1157 perf: RISC-V: Add of_node_put() when breaking out of for_each_of_cpu_node()
In reply to Greg Kroah-HartmanFrom: Liang He <[email protected]>
[ Upstream commit 491f10d08fdae10a177edf6af4f43b83b293114b ]
In pmu_sbi_setup_irqs(), we should call of_node_put() for the 'cpu' when breaking out of for_each_of_cput_node() as its refcount will be automatically increased and decreased during the iteration.
--- drivers/perf/riscv_pmu_sbi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/perf/riscv_pmu_sbi.c +4 -1
@@ -682,12 +682,15 @@ static int pmu_sbi_setup_irqs(struct riscv_pmu *pmu, struct platform_device *pde child =of_get_compatible_child (cpu,"riscv,cpu-intc" );if (!child) {pr_err ("Failed to find INTC node\n" ); +of_node_put (cpu);return -ENODEV ; } domain =irq_find_host (child);of_node_put (child); -if (domain) +if (domain) { +of_node_put (cpu);break ; + } }if (!domain) {pr_err ("Failed to find INTC IRQ root domain\n" );
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 288/1157 drivers/perf: arm_spe: Fix consistency of SYS_PMSCR_EL1.CX
In reply to Greg Kroah-HartmanFrom: Anshuman Khandual <[email protected]>
[ Upstream commit 92f2b8bafa3d6e89c750e9d301a8b7ab76aaa8b6 ]
The arm_spe_pmu driver will enable SYS_PMSCR_EL1.CX in order to add CONTEXT packets into the traces, if the owner of the perf event runs with required capabilities i.e CAP_PERFMON or CAP_SYS_ADMIN via perfmon_capable() helper.
The value of this bit is computed in the arm_spe_event_to_pmscr() function but the check for capabilities happens in the pmu event init callback i.e arm_spe_pmu_event_init(). This suggests that the value of the CX bit should remain consistent for the duration of the perf session.
However, the function arm_spe_event_to_pmscr() may be called later during the event start callback i.e arm_spe_pmu_start() when the "current" process is not the owner of the perf session, hence the CX bit setting is currently not consistent.
One way to fix this, is by caching the required value of the CX bit during the initialization of the PMU event, so that it remains consistent for the duration of the session. It uses currently unused 'event->hw.flags' element to cache perfmon_capable() value, which can be referred during event start callback to compute SYS_PMSCR_EL1.CX. This ensures consistent availability of context packets in the trace as per event owner capabilities.
Drop BIT(SYS_PMSCR_EL1_CX_SHIFT) check in arm_spe_pmu_event_init(), because now CX bit cannot be set in arm_spe_event_to_pmscr() with perfmon_capable() disabled.
--- drivers/perf/arm_spe_pmu.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)
drivers/perf/arm_spe_pmu.c +20 -2
@@ -39,6 +39,24 @@#include <asm/mmu.h> #include <asm/sysreg.h> +/* +* Cache if the event is allowed to trace Context information. +* This allows us to perform the check, i.e, perfmon_capable(), +* in the context of the event owner, once, during the event_init(). +*/ +#define SPE_PMU_HW_FLAGS_CX BIT(0) + +static void set_spe_event_has_cx (struct perf_event *event) +{ +if (IS_ENABLED (CONFIG_PID_IN_CONTEXTIDR ) &&perfmon_capable ()) + event->hw.flags |=SPE_PMU_HW_FLAGS_CX ; +} + +static bool get_spe_event_has_cx (struct perf_event *event) +{ +return !!(event->hw.flags &SPE_PMU_HW_FLAGS_CX ); +} +#define ARM_SPE_BUF_PAD_BYTE 0struct arm_spe_pmu_buf {
@@ -272,7 +290,7 @@ static u64 arm_spe_event_to_pmscr(struct perf_event *event)if (!attr->exclude_kernel) reg |=BIT (SYS_PMSCR_EL1_E1SPE_SHIFT ); -if (IS_ENABLED (CONFIG_PID_IN_CONTEXTIDR ) &&perfmon_capable ()) +if (get_spe_event_has_cx (event)) reg |=BIT (SYS_PMSCR_EL1_CX_SHIFT );return reg;
@@ -709,10 +727,10 @@ static int arm_spe_pmu_event_init(struct perf_event *event) !(spe_pmu->features & SPE_PMU_FEAT_FILT_LAT))return -EOPNOTSUPP ; +set_spe_event_has_cx (event); reg =arm_spe_event_to_pmscr (event);if (!perfmon_capable () && (reg & (BIT (SYS_PMSCR_EL1_PA_SHIFT ) | -BIT (SYS_PMSCR_EL1_CX_SHIFT ) |BIT (SYS_PMSCR_EL1_PCT_SHIFT ))))return -EACCES ;
Signature · 9 lines
2.35.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Greg Kroah-Hartman
maintainerPATCH 289/1157 nohz/full, sched/rt: Fix missed tick-reenabling bug in dequeue_task_rt()
In reply to Greg Kroah-HartmanFrom: Nicolas Saenz Julienne <[email protected]>
[ Upstream commit 5c66d1b9b30f737fcef85a0b75bfe0590e16b62a ]
dequeue_task_rt() only decrements 'rt_rq->rt_nr_running' after having called sched_update_tick_dependency() preventing it from re-enabling the tick on systems that no longer have pending SCHED_RT tasks but have multiple runnable SCHED_OTHER tasks:
dequeue_task_rt()
dequeue_rt_entity()
dequeue_rt_stack()
dequeue_top_rt_rq()
sub_nr_running() // decrements rq->nr_running
sched_update_tick_dependency()
sched_can_stop_tick() // checks rq->rt.rt_nr_running,
...
__dequeue_rt_entity()
dec_rt_tasks() // decrements rq->rt.rt_nr_running
...Every other scheduler class performs the operation in the opposite order, and sched_update_tick_dependency() expects the values to be updated as such. So avoid the misbehaviour by inverting the order in which the above operations are performed in the RT scheduler.
--- kernel/sched/rt.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
kernel/sched/rt.c +9 -6
@@ -480,7 +480,7 @@ static inline void rt_queue_push_tasks(struct rq *rq)#endif /* CONFIG_SMP */ static void enqueue_top_rt_rq (struct rt_rq *rt_rq); -static void dequeue_top_rt_rq (struct rt_rq *rt_rq); +static void dequeue_top_rt_rq (struct rt_rq *rt_rq,unsigned int count);static inline int on_rt_rq (struct sched_rt_entity *rt_se) {
@@ -601,7 +601,7 @@ static void sched_rt_rq_dequeue(struct rt_rq *rt_rq) rt_se = rt_rq->tg->rt_se[cpu];if (!rt_se) { -dequeue_top_rt_rq (rt_rq); +dequeue_top_rt_rq (rt_rq, rt_rq->rt_nr_running);/* Kick cpufreq (see the comment in kernel/sched/sched.h). */ cpufreq_update_util (rq_of_rt_rq (rt_rq),0 ); }
@@ -687,7 +687,7 @@ static inline void sched_rt_rq_enqueue(struct rt_rq *rt_rq)static inline void sched_rt_rq_dequeue (struct rt_rq *rt_rq) { -dequeue_top_rt_rq (rt_rq); +dequeue_top_rt_rq (rt_rq, rt_rq->rt_nr_running); }static inline int rt_rq_throttled (struct rt_rq *rt_rq)
@@ -1089,7 +1089,7 @@ static void update_curr_rt(struct rq *rq) }static void -dequeue_top_rt_rq (struct rt_rq *rt_rq) +dequeue_top_rt_rq (struct rt_rq *rt_rq,unsigned int count) {struct rq *rq =rq_of_rt_rq (rt_rq);
@@ -1100,7 +1100,7 @@ dequeue_top_rt_rq(struct rt_rq *rt_rq)BUG_ON (!rq->nr_running); -sub_nr_running (rq, rt_rq->rt_nr_running); +sub_nr_running (rq, count); rt_rq->rt_queued =0 ; }
@@ -1486,18 +1486,21 @@ static void __dequeue_rt_entity(struct sched_rt_entity *rt_se, unsigned int flagstatic void dequeue_rt_stack (struct sched_rt_entity *rt_se,unsigned int flags) {struct sched_rt_entity *back =NULL ; +unsigned int rt_nr_running;for_each_sched_rt_entity (rt_se) { rt_se->back = back; back = rt_se; } -dequeue_top_rt_rq (rt_rq_of_se (back)); + rt_nr_running =rt_rq_of_se (back)->rt_nr_running;for (rt_se = back; rt_se; rt_se = rt_se->back) {if (on_rt_rq (rt_se))__dequeue_rt_entity (rt_se, flags); } + +dequeue_top_rt_rq (rt_rq_of_se (back), rt_nr_running); }static void enqueue_rt_entity (struct sched_rt_entity *rt_se,unsigned int flags)
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 290/1157 sched: only perform capability check on privileged operation
In reply to Greg Kroah-HartmanFrom: Christian Göttsche <[email protected]>
[ Upstream commit 700a78335fc28a59c307f420857fd2d4521549f8 ]
sched_setattr(2) issues via kernel/sched/core.c:__sched_setscheduler() a CAP_SYS_NICE audit event unconditionally, even when the requested operation does not require that capability / is unprivileged, i.e. for reducing niceness.
This is relevant in connection with SELinux, where a capability check results in a policy decision and by default a denial message on insufficient permission is issued.
It can lead to three undesired cases:
1. A denial message is generated, even in case the operation was an unprivileged one and thus the syscall succeeded, creating noise.
2. To avoid the noise from 1. the policy writer adds a rule to ignore those denial messages, hiding future syscalls, where the task performs an actual privileged operation, leading to hidden limited functionality of that task.
3. To avoid the noise from 1. the policy writer adds a rule to allow the task the capability CAP_SYS_NICE, while it does not need it, violating the principle of least privilege.
Conduct privilged/unprivileged categorization first and perform a capable test (and at most once) only if needed.
--- kernel/sched/core.c | 138 ++++++++++++++++++++++++++------------------ 1 file changed, 83 insertions(+), 55 deletions(-)
kernel/sched/core.c +83 -55
@@ -7002,17 +7002,29 @@ void set_user_nice(struct task_struct *p, long nice)EXPORT_SYMBOL (set_user_nice);/* -* can_nice - check if a task can reduce its nice value +* is_nice_reduction - check if nice value is an actual reduction +* +* Similar to can_nice() but does not perform a capability check. +* * @p: task * @nice: nice value */ -int can_nice (const struct task_struct *p,const int nice) +static bool is_nice_reduction (const struct task_struct *p,const int nice) {/* Convert nice value [19,-20] to rlimit style value [1,40]: */ int nice_rlim =nice_to_rlimit (nice); -return (nice_rlim <=task_rlimit (p,RLIMIT_NICE ) || -capable (CAP_SYS_NICE )); +return (nice_rlim <=task_rlimit (p,RLIMIT_NICE )); +} + +/* +* can_nice - check if a task can reduce its nice value +* @p: task +* @nice: nice value +*/ +int can_nice (const struct task_struct *p,const int nice) +{ +return is_nice_reduction (p, nice) ||capable (CAP_SYS_NICE ); }#ifdef __ARCH_WANT_SYS_NICE
@@ -7291,6 +7303,69 @@ static bool check_same_owner(struct task_struct *p)return match; } +/* +* Allow unprivileged RT tasks to decrease priority. +* Only issue a capable test if needed and only once to avoid an audit +* event on permitted non-privileged operations: +*/ +static int user_check_sched_setscheduler (struct task_struct *p, +const struct sched_attr *attr, +int policy,int reset_on_fork) +{ +if (fair_policy (policy)) { +if (attr->sched_nice <task_nice (p) && + !is_nice_reduction (p, attr->sched_nice)) + goto req_priv; + } + +if (rt_policy (policy)) { +unsigned long rlim_rtprio =task_rlimit (p,RLIMIT_RTPRIO ); + +/* Can't set/change the rt policy: */ +if (policy != p->policy && !rlim_rtprio) + goto req_priv; + +/* Can't increase priority: */ +if (attr->sched_priority > p->rt_priority && + attr->sched_priority > rlim_rtprio) + goto req_priv; + } + +/* +* Can't set/change SCHED_DEADLINE policy at all for now +* (safest behavior); in the future we would like to allow +* unprivileged DL tasks to increase their relative deadline +* or reduce their runtime (both ways reducing utilization) +*/ +if (dl_policy (policy)) + goto req_priv; + +/* +* Treat SCHED_IDLE as nice 20. Only allow a switch to +* SCHED_NORMAL if the RLIMIT_NICE would normally permit it. +*/ +if (task_has_idle_policy (p) && !idle_policy (policy)) { +if (!is_nice_reduction (p,task_nice (p))) + goto req_priv; + } + +/* Can't change other user's priorities: */ +if (!check_same_owner (p)) + goto req_priv; + +/* Normal users shall not reset the sched_reset_on_fork flag: */ +if (p->sched_reset_on_fork && !reset_on_fork) + goto req_priv; + +return 0 ; + +req_priv: +if (!capable (CAP_SYS_NICE )) +return -EPERM ; + +return 0 ; +} +static int __sched_setscheduler (struct task_struct *p,const struct sched_attr *attr,bool user,bool pi)
@@ -7332,58 +7407,11 @@ static int __sched_setscheduler(struct task_struct *p, (rt_policy(policy) != (attr->sched_priority != 0)))return -EINVAL ; -/* -* Allow unprivileged RT tasks to decrease priority: -*/ -if (user && !capable (CAP_SYS_NICE )) { -if (fair_policy (policy)) { -if (attr->sched_nice <task_nice (p) && - !can_nice (p, attr->sched_nice)) -return -EPERM ; - } - -if (rt_policy (policy)) { -unsigned long rlim_rtprio = -task_rlimit (p,RLIMIT_RTPRIO ); - -/* Can't set/change the rt policy: */ -if (policy != p->policy && !rlim_rtprio) -return -EPERM ; - -/* Can't increase priority: */ -if (attr->sched_priority > p->rt_priority && - attr->sched_priority > rlim_rtprio) -return -EPERM ; - } - -/* -* Can't set/change SCHED_DEADLINE policy at all for now -* (safest behavior); in the future we would like to allow -* unprivileged DL tasks to increase their relative deadline -* or reduce their runtime (both ways reducing utilization) -*/ -if (dl_policy (policy)) -return -EPERM ; - -/* -* Treat SCHED_IDLE as nice 20. Only allow a switch to -* SCHED_NORMAL if the RLIMIT_NICE would normally permit it. -*/ -if (task_has_idle_policy (p) && !idle_policy (policy)) { -if (!can_nice (p,task_nice (p))) -return -EPERM ; - } - -/* Can't change other user's priorities: */ -if (!check_same_owner (p)) -return -EPERM ; - -/* Normal users shall not reset the sched_reset_on_fork flag: */ -if (p->sched_reset_on_fork && !reset_on_fork) -return -EPERM ; - } -if (user) { + retval =user_check_sched_setscheduler (p, attr, policy, reset_on_fork); +if (retval) +return retval; +if (attr->sched_flags &SCHED_FLAG_SUGOV )return -EINVAL ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 291/1157 sched/numa: Initialise numa_migrate_retry
In reply to Greg Kroah-HartmanFrom: Mel Gorman <[email protected]>
[ Upstream commit 70ce3ea9aa4ed901c8a90de667df5ef307766e71 ]
On clone, numa_migrate_retry is inherited from the parent which means that the first NUMA placement of a task is non-deterministic. This affects when load balancing recognises numa tasks and whether to migrate "regular", "remote" or "all" tasks between NUMA scheduler domains.
--- kernel/sched/fair.c | 1 + 1 file changed, 1 insertion(+)
kernel/sched/fair.c +1 -0
@@ -2885,6 +2885,7 @@ void init_numa_balancing(unsigned long clone_flags, struct task_struct *p) p->node_stamp =0 ; p->numa_scan_seq = mm ? mm->numa_scan_seq :0 ; p->numa_scan_period = sysctl_numa_balancing_scan_delay; + p->numa_migrate_retry =0 ;/* Protect against double add, see task_tick_numa and task_numa_work */ p->numa_work.next = &p->numa_work; p->numa_faults =NULL ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 292/1157 x86/extable: Fix ex_handler_msr() print condition
In reply to Greg Kroah-HartmanFrom: Peter Zijlstra <[email protected]>
[ Upstream commit a1a5482a2c6e38a3ebed32e571625c56a8cc41a6 ]
Quoted 10 lines · Stephane Eranian
Some changes to the way invalid MSR accesses are reported by the kernel is causing some problems with messages printed on the console.
We have seen several cases of
ex_handler_msr()printing invalid MSR accesses once but the callstack multiple times causing confusion on the console.The problem here is that another earlier commit (5.13):
Quoted 7 lines
a358f40600b3("once: implementDO_ONCE_LITEfor non-fast-path "do once" functionality")Modifies all the pr_*_once() calls to always return true claiming that no caller is ever checking the return value of the functions.
This is why we are seeing the callstack printed without the associated
printk()msg.
Extract the ONCE_IF(cond) part into __ONCE_LTE_IF() and use that to implement DO_ONCE_LITE_IF() and fix the extable code.
--- arch/x86/mm/extable.c | 16 +++++++++------- include/linux/once_lite.h | 20 ++++++++++++++++---- 2 files changed, 25 insertions(+), 11 deletions(-)
arch/x86/mm/extable.c +9 -7
@@ -94,16 +94,18 @@ static bool ex_handler_copy(const struct exception_table_entry *fixup,static bool ex_handler_msr (const struct exception_table_entry *fixup,struct pt_regs *regs,bool wrmsr,bool safe,int reg) { -if (!safe && wrmsr && -pr_warn_once ("unchecked MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x) at rIP: 0x%lx (%pS)\n" , - (unsigned int )regs->cx, (unsigned int )regs->dx, - (unsigned int )regs->ax, regs->ip, (void *)regs->ip)) +if (__ONCE_LITE_IF (!safe && wrmsr)) { +pr_warn ("unchecked MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x) at rIP: 0x%lx (%pS)\n" , + (unsigned int )regs->cx, (unsigned int )regs->dx, + (unsigned int )regs->ax, regs->ip, (void *)regs->ip);show_stack_regs (regs); + } -if (!safe && !wrmsr && -pr_warn_once ("unchecked MSR access error: RDMSR from 0x%x at rIP: 0x%lx (%pS)\n" , - (unsigned int )regs->cx, regs->ip, (void *)regs->ip)) +if (__ONCE_LITE_IF (!safe && !wrmsr)) { +pr_warn ("unchecked MSR access error: RDMSR from 0x%x at rIP: 0x%lx (%pS)\n" , + (unsigned int )regs->cx, regs->ip, (void *)regs->ip);show_stack_regs (regs); + }if (!wrmsr) {/* Pretend that the read succeeded and returned 0. */
include/linux/once_lite.h +16 -4
@@ -9,15 +9,27 @@*/ #define DO_ONCE_LITE (func, ...) \ DO_ONCE_LITE_IF(true, func, ##__VA_ARGS__) -#define DO_ONCE_LITE_IF (condition, func, ...) \ + +#define __ONCE_LITE_IF (condition) \ ({ \ static bool __section(".data.once") __already_done; \ - bool __ret_do_once = !!(condition); \ + bool __ret_cond = !!(condition); \ + bool __ret_once = false; \ \ - if (unlikely(__ret_do_once && !__already_done)) { \ + if (unlikely(__ret_cond && !__already_done)) { \ __already_done = true; \ - func(__VA_ARGS__); \ + __ret_once = true; \ } \ + unlikely(__ret_once); \ + }) + +#define DO_ONCE_LITE_IF (condition, func, ...) \ + ({ \ + bool __ret_do_once = !!(condition); \ + \ + if (__ONCE_LITE_IF(__ret_do_once)) \ + func(__VA_ARGS__); \ + \ unlikely(__ret_do_once); \ })
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 293/1157 io_uring: move to separate directory
In reply to Greg Kroah-HartmanFrom: Jens Axboe <[email protected]>
[ Upstream commit ed29b0b4fd835b058ddd151c49d021e28d631ee6 ]
In preparation for splitting io_uring up a bit, move it into its own top level directory. It didn't really belong in fs/ anyway, as it's not a file system only API.
This adds io_uring/ and moves the core files in there, and updates the MAINTAINERS file for the new location.
---
MAINTAINERS | 7 +------
Makefile | 1 +
fs/Makefile | 2 --
io_uring/Makefile | 6 ++++++
{fs => io_uring}/io-wq.c | 0
{fs => io_uring}/io-wq.h | 0
{fs => io_uring}/io_uring.c | 2 +-
kernel/sched/core.c | 2 +-
8 files changed, 10 insertions(+), 10 deletions(-)
create mode 100644 io_uring/Makefile
rename {fs => io_uring}/io-wq.c (100%)
rename {fs => io_uring}/io-wq.h (100%)
rename {fs => io_uring}/io_uring.c (99%)MAINTAINERS +1 -6
@@ -7773,9 +7773,6 @@ F: include/linux/fs.h F: include/linux/fs_types.h F: include/uapi/linux/fs.h F: include/uapi/linux/openat2.h -X: fs/io-wq.c -X: fs/io-wq.h -X: fs/io_uring.c FINTEK F75375S HARDWARE MONITOR AND FAN CONTROLLER DRIVER M: Riku Voipio <[email protected]>
@@ -10476,9 +10473,7 @@ L: [email protected] S: Maintained T: git git://git.kernel.dk/linux-block T: git git://git.kernel.dk/liburing -F: fs/io-wq.c -F: fs/io-wq.h -F: fs/io_uring.c +F: io_uring/ F: include/linux/io_uring.h F: include/uapi/linux/io_uring.h F: tools/io_uring/
Makefile +1 -0
@@ -1102,6 +1102,7 @@ export MODULES_NSDEPS := $(extmod_prefix)modules.nsdeps ifeq ($(KBUILD_EXTMOD),) core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ core-$(CONFIG_BLOCK) += block/ +core-$(CONFIG_IO_URING) += io_uring/ vmlinux-dirs := $(patsubst %/,%,$(filter %/, \ $(core-y) $(core-m) $(drivers-y) $(drivers-m) \
fs/Makefile +0 -2
@@ -34,8 +34,6 @@ obj-$(CONFIG_TIMERFD) += timerfd.o obj-$(CONFIG_EVENTFD) += eventfd.o obj-$(CONFIG_USERFAULTFD) += userfaultfd.o obj-$(CONFIG_AIO) += aio.o -obj-$(CONFIG_IO_URING) += io_uring.o -obj-$(CONFIG_IO_WQ) += io-wq.o obj-$(CONFIG_FS_DAX) += dax.o obj-$(CONFIG_FS_ENCRYPTION) += crypto/ obj-$(CONFIG_FS_VERITY) += verity/
io_uring/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Makefile for io_uring + +obj-$(CONFIG_IO_URING) += io_uring.o +obj-$(CONFIG_IO_WQ) += io-wq.o
io_uring/io-wq.c renamed from fs/io-wq.c +0 -0
io_uring/io-wq.h renamed from fs/io-wq.h +0 -0
io_uring/io_uring.c renamed from fs/io_uring.c +1 -1
@@ -87,7 +87,7 @@#include <uapi/linux/io_uring.h> -#include "internal.h" +#include "../fs/internal.h" #include "io-wq.h" #define IORING_MAX_ENTRIES 32768
kernel/sched/core.c +1 -1
@@ -91,7 +91,7 @@#include "stats.h" #include "../workqueue_internal.h" -#include "../../fs/io-wq.h" +#include "../../io_uring/io-wq.h" #include "../smpboot.h" /*
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 294/1157 io_uring: define a prep and issue handler for each opcode
In reply to Greg Kroah-HartmanFrom: Jens Axboe <[email protected]>
[ Upstream commit 0702e5364f643bc86683d9f585edfe76dbabae39 ]
Rather than have two giant switches for doing request preparation and then for doing request issue, add a prep and issue handler for each of them in the io_op_defs[] request definition.
--- io_uring/io_uring.c | 838 +++++++++++++++++++------------------------- 1 file changed, 365 insertions(+), 473 deletions(-)
io_uring/io_uring.c +365 -473
@@ -1110,231 +1110,13 @@ struct io_op_def { unsigned iopoll : 1;/* size of async data needed, if any */ unsigned short async_size; -}; -static const struct io_op_def io_op_defs[] = { - [IORING_OP_NOP ] = { - .audit_skip =1 , - .iopoll =1 , - }, - [IORING_OP_READV ] = { - .needs_file =1 , - .unbound_nonreg_file =1 , - .pollin =1 , - .buffer_select =1 , - .needs_async_setup =1 , - .plug =1 , - .audit_skip =1 , - .ioprio =1 , - .iopoll =1 , - .async_size =sizeof (struct io_async_rw ), - }, - [IORING_OP_WRITEV ] = { - .needs_file =1 , - .hash_reg_file =1 , - .unbound_nonreg_file =1 , - .pollout =1 , - .needs_async_setup =1 , - .plug =1 , - .audit_skip =1 , - .ioprio =1 , - .iopoll =1 , - .async_size =sizeof (struct io_async_rw ), - }, - [IORING_OP_FSYNC ] = { - .needs_file =1 , - .audit_skip =1 , - }, - [IORING_OP_READ_FIXED ] = { - .needs_file =1 , - .unbound_nonreg_file =1 , - .pollin =1 , - .plug =1 , - .audit_skip =1 , - .ioprio =1 , - .iopoll =1 , - .async_size =sizeof (struct io_async_rw ), - }, - [IORING_OP_WRITE_FIXED ] = { - .needs_file =1 , - .hash_reg_file =1 , - .unbound_nonreg_file =1 , - .pollout =1 , - .plug =1 , - .audit_skip =1 , - .ioprio =1 , - .iopoll =1 , - .async_size =sizeof (struct io_async_rw ), - }, - [IORING_OP_POLL_ADD ] = { - .needs_file =1 , - .unbound_nonreg_file =1 , - .audit_skip =1 , - }, - [IORING_OP_POLL_REMOVE ] = { - .audit_skip =1 , - }, - [IORING_OP_SYNC_FILE_RANGE ] = { - .needs_file =1 , - .audit_skip =1 , - }, - [IORING_OP_SENDMSG ] = { - .needs_file =1 , - .unbound_nonreg_file =1 , - .pollout =1 , - .needs_async_setup =1 , - .ioprio =1 , - .async_size =sizeof (struct io_async_msghdr ), - }, - [IORING_OP_RECVMSG ] = { - .needs_file =1 , - .unbound_nonreg_file =1 , - .pollin =1 , - .buffer_select =1 , - .needs_async_setup =1 , - .ioprio =1 , - .async_size =sizeof (struct io_async_msghdr ), - }, - [IORING_OP_TIMEOUT ] = { - .audit_skip =1 , - .async_size =sizeof (struct io_timeout_data ), - }, - [IORING_OP_TIMEOUT_REMOVE ] = { -/* used by timeout updates' prep() */ - .audit_skip =1 , - }, - [IORING_OP_ACCEPT ] = { - .needs_file =1 , - .unbound_nonreg_file =1 , - .pollin =1 , - .poll_exclusive =1 , - .ioprio =1 ,/* used for flags */ - }, - [IORING_OP_ASYNC_CANCEL ] = { - .audit_skip =1 , - }, - [IORING_OP_LINK_TIMEOUT ] = { - .audit_skip =1 , - .async_size =sizeof (struct io_timeout_data ), - }, - [IORING_OP_CONNECT ] = { - .needs_file =1 , - .unbound_nonreg_file =1 , - .pollout =1 , - .needs_async_setup =1 , - .async_size =sizeof (struct io_async_connect ), - }, - [IORING_OP_FALLOCATE ] = { - .needs_file =1 , - }, - [IORING_OP_OPENAT ] = {}, - [IORING_OP_CLOSE ] = {}, - [IORING_OP_FILES_UPDATE ] = { - .audit_skip =1 , - .iopoll =1 , - }, - [IORING_OP_STATX ] = { - .audit_skip =1 , - }, - [IORING_OP_READ ] = { - .needs_file =1 , - .unbound_nonreg_file =1 , - .pollin =1 , - .buffer_select =1 , - .plug =1 , - .audit_skip =1 , - .ioprio =1 , - .iopoll =1 , - .async_size =sizeof (struct io_async_rw ), - }, - [IORING_OP_WRITE ] = { - .needs_file =1 , - .hash_reg_file =1 , - .unbound_nonreg_file =1 , - .pollout =1 , - .plug =1 , - .audit_skip =1 , - .ioprio =1 , - .iopoll =1 , - .async_size =sizeof (struct io_async_rw ), - }, - [IORING_OP_FADVISE ] = { - .needs_file =1 , - .audit_skip =1 , - }, - [IORING_OP_MADVISE ] = {}, - [IORING_OP_SEND ] = { - .needs_file =1 , - .unbound_nonreg_file =1 , - .pollout =1 , - .audit_skip =1 , - .ioprio =1 , - }, - [IORING_OP_RECV ] = { - .needs_file =1 , - .unbound_nonreg_file =1 , - .pollin =1 , - .buffer_select =1 , - .audit_skip =1 , - .ioprio =1 , - }, - [IORING_OP_OPENAT2 ] = { - }, - [IORING_OP_EPOLL_CTL ] = { - .unbound_nonreg_file =1 , - .audit_skip =1 , - }, - [IORING_OP_SPLICE ] = { - .needs_file =1 , - .hash_reg_file =1 , - .unbound_nonreg_file =1 , - .audit_skip =1 , - }, - [IORING_OP_PROVIDE_BUFFERS ] = { - .audit_skip =1 , - .iopoll =1 , - }, - [IORING_OP_REMOVE_BUFFERS ] = { - .audit_skip =1 , - .iopoll =1 , - }, - [IORING_OP_TEE ] = { - .needs_file =1 , - .hash_reg_file =1 , - .unbound_nonreg_file =1 , - .audit_skip =1 , - }, - [IORING_OP_SHUTDOWN ] = { - .needs_file =1 , - }, - [IORING_OP_RENAMEAT ] = {}, - [IORING_OP_UNLINKAT ] = {}, - [IORING_OP_MKDIRAT ] = {}, - [IORING_OP_SYMLINKAT ] = {}, - [IORING_OP_LINKAT ] = {}, - [IORING_OP_MSG_RING ] = { - .needs_file =1 , - .iopoll =1 , - }, - [IORING_OP_FSETXATTR ] = { - .needs_file =1 - }, - [IORING_OP_SETXATTR ] = {}, - [IORING_OP_FGETXATTR ] = { - .needs_file =1 - }, - [IORING_OP_GETXATTR ] = {}, - [IORING_OP_SOCKET ] = { - .audit_skip =1 , - }, - [IORING_OP_URING_CMD ] = { - .needs_file =1 , - .plug =1 , - .needs_async_setup =1 , - .async_size =uring_cmd_pdu_size (1 ), - }, +int (*prep)(struct io_kiocb *,const struct io_uring_sqe *); +int (*issue)(struct io_kiocb *,unsigned int ); }; +static const struct io_op_def io_op_defs[]; +/* requests with any of those set should undergo io_disarm_next() */ #define IO_DISARM_MASK (REQ_F_ARM_LTIMEOUT | REQ_F_LINK_TIMEOUT | REQ_F_FAIL)#define IO_REQ_LINK_FLAGS (REQ_F_LINK | REQ_F_HARDLINK)
@@ -8039,96 +7821,33 @@ static int io_files_update(struct io_kiocb *req, unsigned int issue_flags)return 0 ; } -static int io_req_prep (struct io_kiocb *req,const struct io_uring_sqe *sqe) +static int io_req_prep_async (struct io_kiocb *req) { +const struct io_op_def *def = &io_op_defs[req->opcode]; + +/* assign early for deferred execution for non-fixed file */ +if (def->needs_file && !(req->flags &REQ_F_FIXED_FILE )) + req->file =io_file_get_normal (req, req->cqe.fd); +if (!def->needs_async_setup) +return 0 ; +if (WARN_ON_ONCE (req_has_async_data (req))) +return -EFAULT ; +if (io_alloc_async_data (req)) +return -EAGAIN ; +switch (req->opcode) { -case IORING_OP_NOP : -return io_nop_prep (req, sqe);case IORING_OP_READV : -case IORING_OP_READ_FIXED : -case IORING_OP_READ : +return io_readv_prep_async (req);case IORING_OP_WRITEV : -case IORING_OP_WRITE_FIXED : -case IORING_OP_WRITE : -return io_prep_rw (req, sqe); -case IORING_OP_POLL_ADD : -return io_poll_add_prep (req, sqe); -case IORING_OP_POLL_REMOVE : -return io_poll_remove_prep (req, sqe); -case IORING_OP_FSYNC : -return io_fsync_prep (req, sqe); -case IORING_OP_SYNC_FILE_RANGE : -return io_sfr_prep (req, sqe); +return io_writev_prep_async (req);case IORING_OP_SENDMSG : -case IORING_OP_SEND : -return io_sendmsg_prep (req, sqe); +return io_sendmsg_prep_async (req);case IORING_OP_RECVMSG : -case IORING_OP_RECV : -return io_recvmsg_prep (req, sqe); +return io_recvmsg_prep_async (req);case IORING_OP_CONNECT : -return io_connect_prep (req, sqe); -case IORING_OP_TIMEOUT : -return io_timeout_prep (req, sqe); -case IORING_OP_TIMEOUT_REMOVE : -return io_timeout_remove_prep (req, sqe); -case IORING_OP_ASYNC_CANCEL : -return io_async_cancel_prep (req, sqe); -case IORING_OP_LINK_TIMEOUT : -return io_link_timeout_prep (req, sqe); -case IORING_OP_ACCEPT : -return io_accept_prep (req, sqe); -case IORING_OP_FALLOCATE : -return io_fallocate_prep (req, sqe); -case IORING_OP_OPENAT : -return io_openat_prep (req, sqe); -case IORING_OP_CLOSE : -return io_close_prep (req, sqe); -case IORING_OP_FILES_UPDATE : -return io_files_update_prep (req, sqe); -case IORING_OP_STATX : -return io_statx_prep (req, sqe); -case IORING_OP_FADVISE : -return io_fadvise_prep (req, sqe); -case IORING_OP_MADVISE : -return io_madvise_prep (req, sqe); -case IORING_OP_OPENAT2 : -return io_openat2_prep (req, sqe); -case IORING_OP_EPOLL_CTL : -return io_epoll_ctl_prep (req, sqe); -case IORING_OP_SPLICE : -return io_splice_prep (req, sqe); -case IORING_OP_PROVIDE_BUFFERS : -return io_provide_buffers_prep (req, sqe); -case IORING_OP_REMOVE_BUFFERS : -return io_remove_buffers_prep (req, sqe); -case IORING_OP_TEE : -return io_tee_prep (req, sqe); -case IORING_OP_SHUTDOWN : -return io_shutdown_prep (req, sqe); -case IORING_OP_RENAMEAT : -return io_renameat_prep (req, sqe); -case IORING_OP_UNLINKAT : -return io_unlinkat_prep (req, sqe); -case IORING_OP_MKDIRAT : -return io_mkdirat_prep (req, sqe); -case IORING_OP_SYMLINKAT : -return io_symlinkat_prep (req, sqe); -case IORING_OP_LINKAT : -return io_linkat_prep (req, sqe); -case IORING_OP_MSG_RING : -return io_msg_ring_prep (req, sqe); -case IORING_OP_FSETXATTR : -return io_fsetxattr_prep (req, sqe); -case IORING_OP_SETXATTR : -return io_setxattr_prep (req, sqe); -case IORING_OP_FGETXATTR : -return io_fgetxattr_prep (req, sqe); -case IORING_OP_GETXATTR : -return io_getxattr_prep (req, sqe); -case IORING_OP_SOCKET : -return io_socket_prep (req, sqe); +return io_connect_prep_async (req);case IORING_OP_URING_CMD : -return io_uring_cmd_prep (req, sqe); +return io_uring_cmd_prep_async (req); } printk_once(KERN_WARNING "io_uring: unhandled opcode %d\n",
@@ -8136,39 +7855,6 @@ static int io_req_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)return -EINVAL ; } -static int io_req_prep_async (struct io_kiocb *req) -{ -const struct io_op_def *def = &io_op_defs[req->opcode]; - -/* assign early for deferred execution for non-fixed file */ -if (def->needs_file && !(req->flags &REQ_F_FIXED_FILE )) - req->file =io_file_get_normal (req, req->cqe.fd); -if (!def->needs_async_setup) -return 0 ; -if (WARN_ON_ONCE (req_has_async_data (req))) -return -EFAULT ; -if (io_alloc_async_data (req)) -return -EAGAIN ; - -switch (req->opcode) { -case IORING_OP_READV : -return io_readv_prep_async (req); -case IORING_OP_WRITEV : -return io_writev_prep_async (req); -case IORING_OP_SENDMSG : -return io_sendmsg_prep_async (req); -case IORING_OP_RECVMSG : -return io_recvmsg_prep_async (req); -case IORING_OP_CONNECT : -return io_connect_prep_async (req); -case IORING_OP_URING_CMD : -return io_uring_cmd_prep_async (req); - } -printk_once (KERN_WARNING "io_uring: prep_async() bad opcode %d\n" , - req->opcode); -return -EFAULT ; -} -static u32 io_get_sequence (struct io_kiocb *req) {u32 seq = req->ctx->cached_sq_head;
@@ -8335,141 +8021,7 @@ static int io_issue_sqe(struct io_kiocb *req, unsigned int issue_flags)if (!def->audit_skip)audit_uring_entry (req->opcode); -switch (req->opcode) { -case IORING_OP_NOP : - ret =io_nop (req, issue_flags); -break ; -case IORING_OP_READV : -case IORING_OP_READ_FIXED : -case IORING_OP_READ : - ret =io_read (req, issue_flags); -break ; -case IORING_OP_WRITEV : -case IORING_OP_WRITE_FIXED : -case IORING_OP_WRITE : - ret =io_write (req, issue_flags); -break ; -case IORING_OP_FSYNC : - ret =io_fsync (req, issue_flags); -break ; -case IORING_OP_POLL_ADD : - ret =io_poll_add (req, issue_flags); -break ; -case IORING_OP_POLL_REMOVE : - ret =io_poll_remove (req, issue_flags); -break ; -case IORING_OP_SYNC_FILE_RANGE : - ret =io_sync_file_range (req, issue_flags); -break ; -case IORING_OP_SENDMSG : - ret =io_sendmsg (req, issue_flags); -break ; -case IORING_OP_SEND : - ret =io_send (req, issue_flags); -break ; -case IORING_OP_RECVMSG : - ret =io_recvmsg (req, issue_flags); -break ; -case IORING_OP_RECV : - ret =io_recv (req, issue_flags); -break ; -case IORING_OP_TIMEOUT : - ret =io_timeout (req, issue_flags); -break ; -case IORING_OP_TIMEOUT_REMOVE : - ret =io_timeout_remove (req, issue_flags); -break ; -case IORING_OP_ACCEPT : - ret =io_accept (req, issue_flags); -break ; -case IORING_OP_CONNECT : - ret =io_connect (req, issue_flags); -break ; -case IORING_OP_ASYNC_CANCEL : - ret =io_async_cancel (req, issue_flags); -break ; -case IORING_OP_FALLOCATE : - ret =io_fallocate (req, issue_flags); -break ; -case IORING_OP_OPENAT : - ret =io_openat (req, issue_flags); -break ; -case IORING_OP_CLOSE : - ret =io_close (req, issue_flags); -break ; -case IORING_OP_FILES_UPDATE : - ret =io_files_update (req, issue_flags); -break ; -case IORING_OP_STATX : - ret =io_statx (req, issue_flags); -break ; -case IORING_OP_FADVISE : - ret =io_fadvise (req, issue_flags); -break ; -case IORING_OP_MADVISE : - ret =io_madvise (req, issue_flags); -break ; -case IORING_OP_OPENAT2 : - ret =io_openat2 (req, issue_flags); -break ; -case IORING_OP_EPOLL_CTL : - ret =io_epoll_ctl (req, issue_flags); -break ; -case IORING_OP_SPLICE : - ret =io_splice (req, issue_flags); -break ; -case IORING_OP_PROVIDE_BUFFERS : - ret =io_provide_buffers (req, issue_flags); -break ; -case IORING_OP_REMOVE_BUFFERS : - ret =io_remove_buffers (req, issue_flags); -break ; -case IORING_OP_TEE : - ret =io_tee (req, issue_flags); -break ; -case IORING_OP_SHUTDOWN : - ret =io_shutdown (req, issue_flags); -break ; -case IORING_OP_RENAMEAT : - ret =io_renameat (req, issue_flags); -break ; -case IORING_OP_UNLINKAT : - ret =io_unlinkat (req, issue_flags); -break ; -case IORING_OP_MKDIRAT : - ret =io_mkdirat (req, issue_flags); -break ; -case IORING_OP_SYMLINKAT : - ret =io_symlinkat (req, issue_flags); -break ; -case IORING_OP_LINKAT : - ret =io_linkat (req, issue_flags); -break ; -case IORING_OP_MSG_RING : - ret =io_msg_ring (req, issue_flags); -break ; -case IORING_OP_FSETXATTR : - ret =io_fsetxattr (req, issue_flags); -break ; -case IORING_OP_SETXATTR : - ret =io_setxattr (req, issue_flags); -break ; -case IORING_OP_FGETXATTR : - ret =io_fgetxattr (req, issue_flags); -break ; -case IORING_OP_GETXATTR : - ret =io_getxattr (req, issue_flags); -break ; -case IORING_OP_SOCKET : - ret =io_socket (req, issue_flags); -break ; -case IORING_OP_URING_CMD : - ret =io_uring_cmd (req, issue_flags); -break ; -default : - ret = -EINVAL ; -break ; - } + ret = def->issue (req, issue_flags);if (!def->audit_skip)audit_uring_exit (!ret, ret);
@@ -8898,7 +8450,7 @@ static int io_init_req(struct io_ring_ctx *ctx, struct io_kiocb *req, req->flags |=REQ_F_CREDS ; } -return io_req_prep (req, sqe); +return def->prep (req, sqe); } static __cold int io_submit_fail_init(const struct io_uring_sqe *sqe,
@@ -13200,8 +12752,343 @@ SYSCALL_DEFINE4(io_uring_register, unsigned int, fd, unsigned int, opcode,return ret; } +static int io_no_issue (struct io_kiocb *req,unsigned int issue_flags) +{ +WARN_ON_ONCE (1 ); +return -ECANCELED ; +} + +static const struct io_op_def io_op_defs[] = { + [IORING_OP_NOP ] = { + .audit_skip =1 , + .iopoll =1 , + .prep = io_nop_prep, + .issue = io_nop, + }, + [IORING_OP_READV ] = { + .needs_file =1 , + .unbound_nonreg_file =1 , + .pollin =1 , + .buffer_select =1 , + .needs_async_setup =1 , + .plug =1 , + .audit_skip =1 , + .ioprio =1 , + .iopoll =1 , + .async_size =sizeof (struct io_async_rw ), + .prep = io_prep_rw, + .issue = io_read, + }, + [IORING_OP_WRITEV ] = { + .needs_file =1 , + .hash_reg_file =1 , + .unbound_nonreg_file =1 , + .pollout =1 , + .needs_async_setup =1 , + .plug =1 , + .audit_skip =1 , + .ioprio =1 , + .iopoll =1 , + .async_size =sizeof (struct io_async_rw ), + .prep = io_prep_rw, + .issue = io_write, + }, + [IORING_OP_FSYNC ] = { + .needs_file =1 , + .audit_skip =1 , + .prep = io_fsync_prep, + .issue = io_fsync, + }, + [IORING_OP_READ_FIXED ] = { + .needs_file =1 , + .unbound_nonreg_file =1 , + .pollin =1 , + .plug =1 , + .audit_skip =1 , + .ioprio =1 , + .iopoll =1 , + .async_size =sizeof (struct io_async_rw ), + .prep = io_prep_rw, + .issue = io_read, + }, + [IORING_OP_WRITE_FIXED ] = { + .needs_file =1 , + .hash_reg_file =1 , + .unbound_nonreg_file =1 , + .pollout =1 , + .plug =1 , + .audit_skip =1 , + .ioprio =1 , + .iopoll =1 , + .async_size =sizeof (struct io_async_rw ), + .prep = io_prep_rw, + .issue = io_write, + }, + [IORING_OP_POLL_ADD ] = { + .needs_file =1 , + .unbound_nonreg_file =1 , + .audit_skip =1 , + .prep = io_poll_add_prep, + .issue = io_poll_add, + }, + [IORING_OP_POLL_REMOVE ] = { + .audit_skip =1 , + .prep = io_poll_remove_prep, + .issue = io_poll_remove, + }, + [IORING_OP_SYNC_FILE_RANGE ] = { + .needs_file =1 , + .audit_skip =1 , + .prep = io_sfr_prep, + .issue = io_sync_file_range, + }, + [IORING_OP_SENDMSG ] = { + .needs_file =1 , + .unbound_nonreg_file =1 , + .pollout =1 , + .needs_async_setup =1 , + .ioprio =1 , + .async_size =sizeof (struct io_async_msghdr ), + .prep = io_sendmsg_prep, + .issue = io_sendmsg, + }, + [IORING_OP_RECVMSG ] = { + .needs_file =1 , + .unbound_nonreg_file =1 , + .pollin =1 , + .buffer_select =1 , + .needs_async_setup =1 , + .ioprio =1 , + .async_size =sizeof (struct io_async_msghdr ), + .prep = io_recvmsg_prep, + .issue = io_recvmsg, + }, + [IORING_OP_TIMEOUT ] = { + .audit_skip =1 , + .async_size =sizeof (struct io_timeout_data ), + .prep = io_timeout_prep, + .issue = io_timeout, + }, + [IORING_OP_TIMEOUT_REMOVE ] = { +/* used by timeout updates' prep() */ + .audit_skip =1 , + .prep = io_timeout_remove_prep, + .issue = io_timeout_remove, + }, + [IORING_OP_ACCEPT ] = { + .needs_file =1 , + .unbound_nonreg_file =1 , + .pollin =1 , + .poll_exclusive =1 , + .ioprio =1 ,/* used for flags */ + .prep = io_accept_prep, + .issue = io_accept, + }, + [IORING_OP_ASYNC_CANCEL ] = { + .audit_skip =1 , + .prep = io_async_cancel_prep, + .issue = io_async_cancel, + }, + [IORING_OP_LINK_TIMEOUT ] = { + .audit_skip =1 , + .async_size =sizeof (struct io_timeout_data ), + .prep = io_link_timeout_prep, + .issue = io_no_issue, + }, + [IORING_OP_CONNECT ] = { + .needs_file =1 , + .unbound_nonreg_file =1 , + .pollout =1 , + .needs_async_setup =1 , + .async_size =sizeof (struct io_async_connect ), + .prep = io_connect_prep, + .issue = io_connect, + }, + [IORING_OP_FALLOCATE ] = { + .needs_file =1 , + .prep = io_fallocate_prep, + .issue = io_fallocate, + }, + [IORING_OP_OPENAT ] = { + .prep = io_openat_prep, + .issue = io_openat, + }, + [IORING_OP_CLOSE ] = { + .prep = io_close_prep, + .issue = io_close, + }, + [IORING_OP_FILES_UPDATE ] = { + .audit_skip =1 , + .iopoll =1 , + .prep = io_files_update_prep, + .issue = io_files_update, + }, + [IORING_OP_STATX ] = { + .audit_skip =1 , + .prep = io_statx_prep, + .issue = io_statx, + }, + [IORING_OP_READ ] = { + .needs_file =1 , + .unbound_nonreg_file =1 , + .pollin =1 , + .buffer_select =1 , + .plug =1 , + .audit_skip =1 , + .ioprio =1 , + .iopoll =1 , + .async_size =sizeof (struct io_async_rw ), + .prep = io_prep_rw, + .issue = io_read, + }, + [IORING_OP_WRITE ] = { + .needs_file =1 , + .hash_reg_file =1 , + .unbound_nonreg_file =1 , + .pollout =1 , + .plug =1 , + .audit_skip =1 , + .ioprio =1 , + .iopoll =1 , + .async_size =sizeof (struct io_async_rw ), + .prep = io_prep_rw, + .issue = io_write, + }, + [IORING_OP_FADVISE ] = { + .needs_file =1 , + .audit_skip =1 , + .prep = io_fadvise_prep, + .issue = io_fadvise, + }, + [IORING_OP_MADVISE ] = { + .prep = io_madvise_prep, + .issue = io_madvise, + }, + [IORING_OP_SEND ] = { + .needs_file =1 , + .unbound_nonreg_file =1 , + .pollout =1 , + .audit_skip =1 , + .ioprio =1 , + .prep = io_sendmsg_prep, + .issue = io_send, + }, + [IORING_OP_RECV ] = { + .needs_file =1 , + .unbound_nonreg_file =1 , + .pollin =1 , + .buffer_select =1 , + .audit_skip =1 , + .ioprio =1 , + .prep = io_recvmsg_prep, + .issue = io_recv, + }, + [IORING_OP_OPENAT2 ] = { + .prep = io_openat2_prep, + .issue = io_openat2, + }, + [IORING_OP_EPOLL_CTL ] = { + .unbound_nonreg_file =1 , + .audit_skip =1 , + .prep = io_epoll_ctl_prep, + .issue = io_epoll_ctl, + }, + [IORING_OP_SPLICE ] = { + .needs_file =1 , + .hash_reg_file =1 , + .unbound_nonreg_file =1 , + .audit_skip =1 , + .prep = io_splice_prep, + .issue = io_splice, + }, + [IORING_OP_PROVIDE_BUFFERS ] = { + .audit_skip =1 , + .iopoll =1 , + .prep = io_provide_buffers_prep, + .issue = io_provide_buffers, + }, + [IORING_OP_REMOVE_BUFFERS ] = { + .audit_skip =1 , + .iopoll =1 , + .prep = io_remove_buffers_prep, + .issue = io_remove_buffers, + }, + [IORING_OP_TEE ] = { + .needs_file =1 , + .hash_reg_file =1 , + .unbound_nonreg_file =1 , + .audit_skip =1 , + .prep = io_tee_prep, + .issue = io_tee, + }, + [IORING_OP_SHUTDOWN ] = { + .needs_file =1 , + .prep = io_shutdown_prep, + .issue = io_shutdown, + }, + [IORING_OP_RENAMEAT ] = { + .prep = io_renameat_prep, + .issue = io_renameat, + }, + [IORING_OP_UNLINKAT ] = { + .prep = io_unlinkat_prep, + .issue = io_unlinkat, + }, + [IORING_OP_MKDIRAT ] = { + .prep = io_mkdirat_prep, + .issue = io_mkdirat, + }, + [IORING_OP_SYMLINKAT ] = { + .prep = io_symlinkat_prep, + .issue = io_symlinkat, + }, + [IORING_OP_LINKAT ] = { + .prep = io_linkat_prep, + .issue = io_linkat, + }, + [IORING_OP_MSG_RING ] = { + .needs_file =1 , + .iopoll =1 , + .prep = io_msg_ring_prep, + .issue = io_msg_ring, + }, + [IORING_OP_FSETXATTR ] = { + .needs_file =1 , + .prep = io_fsetxattr_prep, + .issue = io_fsetxattr, + }, + [IORING_OP_SETXATTR ] = { + .prep = io_setxattr_prep, + .issue = io_setxattr, + }, + [IORING_OP_FGETXATTR ] = { + .needs_file =1 , + .prep = io_fgetxattr_prep, + .issue = io_fgetxattr, + }, + [IORING_OP_GETXATTR ] = { + .prep = io_getxattr_prep, + .issue = io_getxattr, + }, + [IORING_OP_SOCKET ] = { + .audit_skip =1 , + .prep = io_socket_prep, + .issue = io_socket, + }, + [IORING_OP_URING_CMD ] = { + .needs_file =1 , + .plug =1 , + .needs_async_setup =1 , + .async_size =uring_cmd_pdu_size (1 ), + .prep = io_uring_cmd_prep, + .issue = io_uring_cmd, + }, +}; +static int __init io_uring_init (void ) { +int i; +#define __BUILD_BUG_VERIFY_ELEMENT (stype, eoffset, etype, ename) do { \ BUILD_BUG_ON(offsetof(stype, ename) != eoffset); \ BUILD_BUG_ON(sizeof(etype) != sizeof_field(stype, ename)); \
@@ -13266,6 +13153,11 @@ static int __init io_uring_init(void)BUILD_BUG_ON (sizeof (struct io_uring_cmd ) >64 ); +for (i =0 ; i <ARRAY_SIZE (io_op_defs); i++) { +BUG_ON (!io_op_defs[i].prep); +BUG_ON (!io_op_defs[i].issue); + } + req_cachep =KMEM_CACHE (io_kiocb,SLAB_HWCACHE_ALIGN |SLAB_PANIC |SLAB_ACCOUNT );return 0 ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 295/1157 io_uring: Dont require reinitable percpu_ref
In reply to Greg Kroah-HartmanFrom: Michal Koutný <[email protected]>
[ Upstream commit 48904229928d941ce1db181b991948387ab463cd ]
The commit 8bb649ee1da3 ("io_uring: remove ring quiesce for io_uring_register") removed the worklow relying on reinit/resurrection of the percpu_ref, hence, initialization with that requested is a relic.
This is based on code review, this causes no real bug (and theoretically can't). Technically it's a revert of commit 214828962dea ("io_uring:
initialize percpu refcounters using PERCU_REF_ALLOW_REINIT") but since the flag omission is now justified, I'm not making this a revert.
--- io_uring/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
io_uring/io_uring.c +1 -1
@@ -1701,7 +1701,7 @@ static __cold struct io_ring_ctx *io_ring_ctx_alloc(struct io_uring_params *p) ctx->dummy_ubuf->ubuf =-1UL ;if (percpu_ref_init (&ctx->refs, io_ring_ctx_ref_free, -PERCPU_REF_ALLOW_REINIT ,GFP_KERNEL )) +0 ,GFP_KERNEL )) goto err; ctx->flags = p->flags;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 296/1157 selftests/seccomp: Fix compile warning when CC=clang
In reply to Greg Kroah-HartmanFrom: YiFei Zhu <[email protected]>
[ Upstream commit 3ce4b78f73e8e00fb86bad67ee7f6fe12019707e ]
clang has -Wconstant-conversion by default, and the constant 0xAAAAAAAAA (9 As) being converted to an int, which is generally 32 bits, results in the compile warning:
clang -Wl,-no-as-needed -Wall -isystem ../../../../usr/include/ -lpthread seccomp_bpf.c -lcap -o seccomp_bpf seccomp_bpf.c:812:67: warning: implicit conversion from 'long' to 'int' changes value from 45812984490 to -1431655766 [-Wconstant-conversion]
int kill = kill_how == KILL_PROCESS ? SECCOMP_RET_KILL_PROCESS : 0xAAAAAAAAA;
~~~~ ^~~~~~~~~~~1 warning generated.
-1431655766 is the expected truncation, 0xAAAAAAAA (8 As), so use this directly in the code to avoid the warning.
--- tools/testing/selftests/seccomp/seccomp_bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/seccomp/seccomp_bpf.c +1 -1
@@ -809,7 +809,7 @@ void kill_thread_or_group(struct __test_metadata *_metadata, .len = (unsigned short)ARRAY_SIZE(filter_thread), .filter = filter_thread, }; -int kill = kill_how ==KILL_PROCESS ?SECCOMP_RET_KILL_PROCESS :0xAAAAAAAAA ; +int kill = kill_how ==KILL_PROCESS ?SECCOMP_RET_KILL_PROCESS :0xAAAAAAAA ;struct sock_filter filter_process[] = {BPF_STMT (BPF_LD |BPF_W |BPF_ABS , offsetof(struct seccomp_data , nr)),
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 297/1157 thermal/tools/tmon: Include pthread and time headers in tmon.h
In reply to Greg Kroah-HartmanFrom: Markus Mayer <[email protected]>
[ Upstream commit 0cf51bfe999524377fbb71becb583b4ca6d07cfc ]
Include sys/time.h and pthread.h in tmon.h, so that types "pthread_mutex_t" and "struct timeval tv" are known when tmon.h references them.
Without these headers, compiling tmon against musl-libc will fail with these errors:
In file included from sysfs.c:31:0:
tmon.h:47:8: error: unknown type name 'pthread_mutex_t'
extern pthread_mutex_t input_lock;
^~~~~~~~~~~~~~~make[3]: *** [<builtin>: sysfs.o] Error 1 make[3]: *** Waiting for unfinished jobs.... In file included from tui.c:31:0:
tmon.h:54:17: error: field 'tv' has incomplete type
struct timeval tv;
^~make[3]: *** [<builtin>: tui.o] Error 1
make[2]: *** [Makefile:83: tmon] Error 2
--- tools/thermal/tmon/tmon.h | 3 +++ 1 file changed, 3 insertions(+)
tools/thermal/tmon/tmon.h +3 -0
@@ -27,6 +27,9 @@#define NR_LINES_TZDATA 1#define TMON_LOG_FILE "/var/tmp/tmon.log" +#include <sys/time.h> +#include <pthread.h> +extern unsigned long ticktime;extern double time_elapsed;extern unsigned long target_temp_user;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 298/1157 tools/power turbostat: Fix file pointer leak
In reply to Greg Kroah-HartmanFrom: Colin Ian King <[email protected]>
[ Upstream commit 5e5fd36c58d6c820f7292ee492c3731c9a104a41 ]
Currently if a fscanf fails then an early return leaks an open file pointer. Fix this by fclosing the file before the return. Detected using static analysis with cppcheck:
tools/power/x86/turbostat/turbostat.c:2039:3: error: Resource leak: fp [resourceLeak]
--- tools/power/x86/turbostat/turbostat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/power/x86/turbostat/turbostat.c +1 -1
@@ -2035,9 +2035,9 @@ int get_core_throt_cnt(int cpu, unsigned long long *cnt)if (!fp)return -1 ; ret =fscanf (fp,"%lld" , &tmp); +fclose (fp);if (ret !=1 )return -1 ; -fclose (fp); *cnt = tmp;return 0 ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 299/1157 dm: return early from dm_pr_call() if DM device is suspended
In reply to Greg Kroah-HartmanFrom: Mike Snitzer <[email protected]>
[ Upstream commit e120a5f1e78fab6223544e425015f393d90d6f0d ]
Otherwise PR ops may be issued while the broader DM device is being reconfigured, etc.
--- drivers/md/dm.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/md/dm.c +5 -0
@@ -3066,6 +3066,11 @@ static int dm_call_pr(struct block_device *bdev, iterate_devices_callout_fn fn, goto out; ti =dm_table_get_target (table,0 ); +if (dm_suspended_md (md)) { + ret = -EAGAIN ; + goto out; + } + ret = -EINVAL ;if (!ti->type->iterate_devices) goto out;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 300/1157 pwm: sifive: Simplify offset calculation for PWMCMP registers
In reply to Greg Kroah-HartmanFrom: Uwe Kleine-König <[email protected]>
[ Upstream commit 20550a61880fc55e68a0d290ad195b74729c0e7b ]
Instead of explicitly using PWM_SIFIVE_PWMCMP0 + pwm->hwpwm * PWM_SIFIVE_SIZE_PWMCMP for each access to one of the PWMCMP registers, introduce a macro that takes the hwpwm id as parameter.
For the register definition using a plain 4 instead of the cpp constant PWM_SIFIVE_SIZE_PWMCMP is easier to read, so define the offset macro without the constant. The latter can then be dropped as there are no users left.
--- drivers/pwm/pwm-sifive.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/pwm/pwm-sifive.c +3 -7
@@ -23,7 +23,7 @@#define PWM_SIFIVE_PWMCFG 0x0#define PWM_SIFIVE_PWMCOUNT 0x8#define PWM_SIFIVE_PWMS 0x10 -#define PWM_SIFIVE_PWMCMP0 0x20 +#define PWM_SIFIVE_PWMCMP (i) (0x20 + 4 * (i))/* PWMCFG fields */ #define PWM_SIFIVE_PWMCFG_SCALE GENMASK(3, 0)
@@ -36,8 +36,6 @@#define PWM_SIFIVE_PWMCFG_GANG BIT(24)#define PWM_SIFIVE_PWMCFG_IP BIT(28) -/* PWM_SIFIVE_SIZE_PWMCMP is used to calculate offset for pwmcmpX registers */ -#define PWM_SIFIVE_SIZE_PWMCMP 4#define PWM_SIFIVE_CMPWIDTH 16#define PWM_SIFIVE_DEFAULT_PERIOD 10000000
@@ -112,8 +110,7 @@ static void pwm_sifive_get_state(struct pwm_chip *chip, struct pwm_device *pwm,struct pwm_sifive_ddata *ddata =pwm_sifive_chip_to_ddata (chip);u32 duty, val; - duty =readl (ddata->regs +PWM_SIFIVE_PWMCMP0 + - pwm->hwpwm *PWM_SIFIVE_SIZE_PWMCMP ); + duty =readl (ddata->regs +PWM_SIFIVE_PWMCMP (pwm->hwpwm)); state->enabled = duty >0 ;
@@ -193,8 +190,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_device *pwm,pwm_sifive_update_clock (ddata,clk_get_rate (ddata->clk)); } -writel (frac, ddata->regs +PWM_SIFIVE_PWMCMP0 + - pwm->hwpwm *PWM_SIFIVE_SIZE_PWMCMP ); +writel (frac, ddata->regs +PWM_SIFIVE_PWMCMP (pwm->hwpwm));if (state->enabled != enabled)pwm_sifive_enable (chip, state->enabled);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 301/1157 pwm: sifive: Ensure the clk is enabled exactly once per running PWM
In reply to Greg Kroah-HartmanFrom: Uwe Kleine-König <[email protected]>
[ Upstream commit ace41d7564e655c39f709a78c035188a460c7cbd ]
.apply() assumes the clk to be for a given PWM iff the PWM is enabled. So make sure this is the case when .probe() completes. And in .remove() disable the according number of times.
This fixes a clk enable/disable imbalance, if some PWMs are already running at probe time.
--- drivers/pwm/pwm-sifive.c | 46 ++++++++++++++++++++++++++++++++-------- 1 file changed, 37 insertions(+), 9 deletions(-)
drivers/pwm/pwm-sifive.c +37 -9
@@ -228,6 +228,8 @@ static int pwm_sifive_probe(struct platform_device *pdev)struct pwm_sifive_ddata *ddata;struct pwm_chip *chip;int ret; +u32 val; +unsigned int enabled_pwms =0 , enabled_clks =1 ; ddata =devm_kzalloc (dev,sizeof (*ddata),GFP_KERNEL );if (!ddata)
@@ -254,6 +256,33 @@ static int pwm_sifive_probe(struct platform_device *pdev)return ret; } + val =readl (ddata->regs +PWM_SIFIVE_PWMCFG ); +if (val &PWM_SIFIVE_PWMCFG_EN_ALWAYS ) { +unsigned int i; + +for (i =0 ; i < chip->npwm; ++i) { + val =readl (ddata->regs +PWM_SIFIVE_PWMCMP (i)); +if (val >0 ) + ++enabled_pwms; + } + } + +/* The clk should be on once for each running PWM. */ +if (enabled_pwms) { +while (enabled_clks < enabled_pwms) { +/* This is not expected to fail as the clk is already on */ + ret =clk_enable (ddata->clk); +if (unlikely (ret)) { +dev_err_probe (dev, ret,"Failed to enable clk\n" ); + goto disable_clk; + } + ++enabled_clks; + } + }else { +clk_disable (ddata->clk); + enabled_clks =0 ; + } +/* Watch for changes to underlying clock frequency */ ddata->notifier.notifier_call = pwm_sifive_clock_notifier; ret =clk_notifier_register (ddata->clk, &ddata->notifier);
@@ -276,7 +305,11 @@ static int pwm_sifive_probe(struct platform_device *pdev) unregister_clk:clk_notifier_unregister (ddata->clk, &ddata->notifier); disable_clk: -clk_disable_unprepare (ddata->clk); +while (enabled_clks) { +clk_disable (ddata->clk); + --enabled_clks; + } +clk_unprepare (ddata->clk);return ret; }
@@ -284,21 +317,16 @@ static int pwm_sifive_probe(struct platform_device *pdev)static int pwm_sifive_remove (struct platform_device *dev) {struct pwm_sifive_ddata *ddata =platform_get_drvdata (dev); -bool is_enabled = false;struct pwm_device *pwm;int ch;for (ch =0 ; ch < ddata->chip.npwm; ch++) { pwm = &ddata->chip.pwms[ch]; -if (pwm->state.enabled) { - is_enabled = true; -break ; - } +if (pwm->state.enabled) +clk_disable (ddata->clk); } -if (is_enabled) -clk_disable (ddata->clk); -clk_disable_unprepare (ddata->clk); +clk_unprepare (ddata->clk);pwmchip_remove (&ddata->chip);clk_notifier_unregister (ddata->clk, &ddata->notifier);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 302/1157 pwm: sifive: Shut down hardware only after pwmchip_remove() completed
In reply to Greg Kroah-HartmanFrom: Uwe Kleine-König <[email protected]>
[ Upstream commit 2375e964d541bb09158cd2dff67b5d74e8de61cd ]
The PWMs are expected to be functional until pwmchip_remove() is called. So disable the clks only afterwards.
--- drivers/pwm/pwm-sifive.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pwm/pwm-sifive.c +3 -2
@@ -320,6 +320,9 @@ static int pwm_sifive_remove(struct platform_device *dev)struct pwm_device *pwm;int ch; +pwmchip_remove (&ddata->chip); +clk_notifier_unregister (ddata->clk, &ddata->notifier); +for (ch =0 ; ch < ddata->chip.npwm; ch++) { pwm = &ddata->chip.pwms[ch];if (pwm->state.enabled)
@@ -327,8 +330,6 @@ static int pwm_sifive_remove(struct platform_device *dev) }clk_unprepare (ddata->clk); -pwmchip_remove (&ddata->chip); -clk_notifier_unregister (ddata->clk, &ddata->notifier);return 0 ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 303/1157 pwm: lpc18xx: Fix period handling
In reply to Greg Kroah-HartmanFrom: Uwe Kleine-König <[email protected]>
[ Upstream commit 8933d30c5f468d6cc1e4bf9bb535149da35f202e ]
The calculation:
val = (u64)NSEC_PER_SEC * LPC18XX_PWM_TIMER_MAX; do_div(val, lpc18xx_pwm->clk_rate); lpc18xx_pwm->max_period_ns = val;
is bogus because with NSEC_PER_SEC = 1000000000, LPC18XX_PWM_TIMER_MAX = 0xffffffff and clk_rate < NSEC_PER_SEC this overflows the (on lpc18xx (i.e. ARM32) 32 bit wide) unsigned int .max_period_ns. This results (dependant of the actual clk rate) in an arbitrary limitation of the maximal period. E.g. for clkrate = 333333333 (Hz) we get max_period_ns = 9 instead of 12884901897.
So make .max_period_ns an u64 and pass period and duty as u64 to not discard relevant digits. And also make use of mul_u64_u64_div_u64() which prevents all overflows assuming clk_rate < NSEC_PER_SEC.
--- drivers/pwm/pwm-lpc18xx-sct.c | 55 +++++++++++++++++++++++++---------- 1 file changed, 39 insertions(+), 16 deletions(-)
drivers/pwm/pwm-lpc18xx-sct.c +39 -16
@@ -98,7 +98,7 @@ struct lpc18xx_pwm_chip {unsigned long clk_rate;unsigned int period_ns;unsigned int min_period_ns; -unsigned int max_period_ns; +u64 max_period_ns;unsigned int period_event;unsigned long event_map;struct mutex res_lock;
@@ -145,40 +145,48 @@ static void lpc18xx_pwm_set_conflict_res(struct lpc18xx_pwm_chip *lpc18xx_pwm,mutex_unlock (&lpc18xx_pwm->res_lock); } -static void lpc18xx_pwm_config_period (struct pwm_chip *chip,int period_ns) +static void lpc18xx_pwm_config_period (struct pwm_chip *chip,u64 period_ns) {struct lpc18xx_pwm_chip *lpc18xx_pwm =to_lpc18xx_pwm_chip (chip); -u64 val; +u32 val; - val = (u64 )period_ns * lpc18xx_pwm->clk_rate; -do_div (val,NSEC_PER_SEC ); +/* +* With clk_rate < NSEC_PER_SEC this cannot overflow. +* With period_ns < max_period_ns this also fits into an u32. +* As period_ns >= min_period_ns = DIV_ROUND_UP(NSEC_PER_SEC, lpc18xx_pwm->clk_rate); +* we have val >= 1. +*/ + val =mul_u64_u64_div_u64 (period_ns, lpc18xx_pwm->clk_rate,NSEC_PER_SEC );lpc18xx_pwm_writel (lpc18xx_pwm,LPC18XX_PWM_MATCH (lpc18xx_pwm->period_event), - (u32 )val -1 ); + val -1 );lpc18xx_pwm_writel (lpc18xx_pwm,LPC18XX_PWM_MATCHREL (lpc18xx_pwm->period_event), - (u32 )val -1 ); + val -1 ); }static void lpc18xx_pwm_config_duty (struct pwm_chip *chip, -struct pwm_device *pwm,int duty_ns) +struct pwm_device *pwm,u64 duty_ns) {struct lpc18xx_pwm_chip *lpc18xx_pwm =to_lpc18xx_pwm_chip (chip);struct lpc18xx_pwm_data *lpc18xx_data = &lpc18xx_pwm->channeldata[pwm->hwpwm]; -u64 val; +u32 val; - val = (u64 )duty_ns * lpc18xx_pwm->clk_rate; -do_div (val,NSEC_PER_SEC ); +/* +* With clk_rate < NSEC_PER_SEC this cannot overflow. +* With duty_ns <= period_ns < max_period_ns this also fits into an u32. +*/ + val =mul_u64_u64_div_u64 (duty_ns, lpc18xx_pwm->clk_rate,NSEC_PER_SEC );lpc18xx_pwm_writel (lpc18xx_pwm,LPC18XX_PWM_MATCH (lpc18xx_data->duty_event), - (u32 )val); + val);lpc18xx_pwm_writel (lpc18xx_pwm,LPC18XX_PWM_MATCHREL (lpc18xx_data->duty_event), - (u32 )val); + val); } static int lpc18xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
@@ -377,12 +385,27 @@ static int lpc18xx_pwm_probe(struct platform_device *pdev) goto disable_pwmclk; } +/* +* If clkrate is too fast, the calculations in .apply() might overflow. +*/ +if (lpc18xx_pwm->clk_rate >NSEC_PER_SEC ) { + ret =dev_err_probe (&pdev->dev, -EINVAL ,"pwm clock to fast\n" ); + goto disable_pwmclk; + } + +/* +* If clkrate is too fast, the calculations in .apply() might overflow. +*/ +if (lpc18xx_pwm->clk_rate >NSEC_PER_SEC ) { + ret =dev_err_probe (&pdev->dev, -EINVAL ,"pwm clock to fast\n" ); + goto disable_pwmclk; + } +mutex_init (&lpc18xx_pwm->res_lock);mutex_init (&lpc18xx_pwm->period_lock); - val = (u64 )NSEC_PER_SEC *LPC18XX_PWM_TIMER_MAX ; -do_div (val, lpc18xx_pwm->clk_rate); - lpc18xx_pwm->max_period_ns = val; + lpc18xx_pwm->max_period_ns = +mul_u64_u64_div_u64 (NSEC_PER_SEC ,LPC18XX_PWM_TIMER_MAX , lpc18xx_pwm->clk_rate); lpc18xx_pwm->min_period_ns =DIV_ROUND_UP (NSEC_PER_SEC , lpc18xx_pwm->clk_rate);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 304/1157 erofs: update ctx->pos for every emitted dirent
In reply to Greg Kroah-HartmanFrom: Hongnan Li <[email protected]>
[ Upstream commit ecce9212d0fd7a2d4a4998f0c4623a66887e14c8 ]
erofs_readdir update ctx->pos after filling a batch of dentries and it may cause dir/files duplication for NFS readdirplus which depends on ctx->pos to fill dir correctly. So update ctx->pos for every emitted dirent in erofs_fill_dentries to fix it.
Also fix the update of ctx->pos when the initial file position has exceeded nameoff.
--- fs/erofs/dir.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-)
fs/erofs/dir.c +7 -9
@@ -22,10 +22,9 @@ static void debug_one_dentry(unsigned char d_type, const char *de_name, }static int erofs_fill_dentries (struct inode *dir,struct dir_context *ctx, -void *dentry_blk,unsigned int *ofs, +void *dentry_blk,struct erofs_dirent *de,unsigned int nameoff,unsigned int maxsize) { -struct erofs_dirent *de = dentry_blk + *ofs;const struct erofs_dirent *end = dentry_blk + nameoff;while (de < end) {
@@ -59,9 +58,8 @@ static int erofs_fill_dentries(struct inode *dir, struct dir_context *ctx,/* stopped by some reason */ return 1 ; ++de; - *ofs +=sizeof (struct erofs_dirent ); + ctx->pos +=sizeof (struct erofs_dirent ); } - *ofs = maxsize;return 0 ; }
@@ -95,7 +93,7 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)"invalid de[0].nameoff %u @ nid %llu" , nameoff, EROFS_I(dir)->nid); err = -EFSCORRUPTED ; - goto skip_this; +break ; } maxsize = min_t(unsigned int,
@@ -106,17 +104,17 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx) initial = false; ofs =roundup (ofs,sizeof (struct erofs_dirent )); + ctx->pos =blknr_to_addr (i) + ofs;if (ofs >= nameoff) goto skip_this; } - err =erofs_fill_dentries (dir, ctx, de, &ofs, + err =erofs_fill_dentries (dir, ctx, de, (void *)de + ofs, nameoff, maxsize); -skip_this: - ctx->pos =blknr_to_addr (i) + ofs; -if (err)break ; +skip_this: + ctx->pos =blknr_to_addr (i) + maxsize; ++i; ofs =0 ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 305/1157 dt-bindings: display: bridge: ldb: Fill in reg property
In reply to Greg Kroah-HartmanFrom: Marek Vasut <[email protected]>
[ Upstream commit 16c8d76abe83d75b578d72ee22d25a52c764e14a ]
Add missing reg and reg-names properties for both 'LDB_CTRL' and 'LVDS_CTRL' registers.
--- .../bindings/display/bridge/fsl,ldb.yaml | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml +15 -1
@@ -24,6 +24,15 @@ properties: clock-names: const: ldb + reg: + minItems: 2 + maxItems: 2 + + reg-names: + items: + - const: ldb + - const: lvds + ports: $ref: /schemas/graph.yaml#/properties/ports
@@ -56,10 +65,15 @@ examples: #include <dt-bindings/clock/imx8mp-clock.h> blk-ctrl { - bridge { + #address-cells = <1>; + #size-cells = <1>; + + bridge@5c { compatible = "fsl,imx8mp-ldb"; clocks = <&clk IMX8MP_CLK_MEDIA_LDB>; clock-names = "ldb"; + reg = <0x5c 0x4>, <0x128 0x4>; + reg-names = "ldb", "lvds"; ports { #address-cells = <1>;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 306/1157 drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON()
In reply to Greg Kroah-HartmanFrom: Jani Nikula <[email protected]>
[ Upstream commit 1b93ff4d0679190e8812cd0d0b3aebfcba1ed883 ]
There are already too many choices here, take away the unused ones.
--- drivers/gpu/drm/i915/i915_gem.h | 4 ---- 1 file changed, 4 deletions(-)
drivers/gpu/drm/i915/i915_gem.h +0 -4
@@ -54,9 +54,7 @@ struct drm_i915_private; } while(0)#define GEM_WARN_ON (expr) WARN_ON(expr) -#define GEM_DEBUG_DECL (var) var#define GEM_DEBUG_EXEC (expr) expr -#define GEM_DEBUG_BUG_ON (expr) GEM_BUG_ON(expr)#define GEM_DEBUG_WARN_ON (expr) GEM_WARN_ON(expr)#else
@@ -66,9 +64,7 @@ struct drm_i915_private;#define GEM_BUG_ON (expr) BUILD_BUG_ON_INVALID(expr)#define GEM_WARN_ON (expr) ({ unlikely(!!(expr)); }) -#define GEM_DEBUG_DECL (var)#define GEM_DEBUG_EXEC (expr) do { } while (0) -#define GEM_DEBUG_BUG_ON (expr)#define GEM_DEBUG_WARN_ON (expr) ({ BUILD_BUG_ON_INVALID(expr); 0; })#endif
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 307/1157 drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit 98526c5bbe3267d447ddd076b685439e3e1396c6 ]
This error path needs an unlock before returning.
--- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +1 -0
@@ -1524,6 +1524,7 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc,if (ret <0 ) {drm_err (vop2->drm,"failed to enable dclk for video port%d - %d\n" , vp->id, ret); +vop2_unlock (vop2);return ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 308/1157 drm: bridge: DRM_FSL_LDB should depend on ARCH_MXC
In reply to Greg Kroah-HartmanFrom: Geert Uytterhoeven <[email protected]>
[ Upstream commit a9ad5822366c5065e6a65fe5ff5090295ba98986 ]
The Freescale i.MX8MP LDB bridge is only present on Freescale i.MX8MP SoCs. Hence add a dependency on ARCH_MXC, to prevent asking the user about this driver when configuring a kernel without i.MX SoC support.
--- drivers/gpu/drm/bridge/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/bridge/Kconfig +1 -0
@@ -78,6 +78,7 @@ config DRM_DISPLAY_CONNECTOR config DRM_FSL_LDB tristate "Freescale i.MX8MP LDB bridge" depends on OF + depends on ARCH_MXC || COMPILE_TEST select DRM_KMS_HELPER select DRM_PANEL_BRIDGE help
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 309/1157 drm/bridge: anx7625: Use DPI bus type
In reply to Greg Kroah-HartmanFrom: Xin Ji <[email protected]>
[ Upstream commit a77c2af0994e24ee36c7ffb6dc852770bdf06fb1 ]
As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
--- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/bridge/analogix/anx7625.c +4 -4
@@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,anx7625_get_swing_setting (dev, pdata); - pdata->is_dpi =1 ;/* default dpi mode */ + pdata->is_dpi =0 ;/* default dsi mode */ pdata->mipi_host_node =of_graph_get_remote_node (np,0 ,0 );if (!pdata->mipi_host_node) {DRM_DEV_ERROR (dev,"fail to get internal panel.\n" );return -ENODEV ; } - bus_type =V4L2_FWNODE_BUS_TYPE_PARALLEL ; + bus_type =0 ; mipi_lanes =MAX_LANES_SUPPORT ; ep0 =of_graph_get_endpoint_by_regs (np,0 ,0 );if (ep0) {
@@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, mipi_lanes =of_property_count_u32_elems (ep0,"data-lanes" ); } -if (bus_type ==V4L2_FWNODE_BUS_TYPE_PARALLEL )/* bus type is Parallel(DSI) */ - pdata->is_dpi =0 ; +if (bus_type ==V4L2_FWNODE_BUS_TYPE_DPI )/* bus type is DPI */ + pdata->is_dpi =1 ; pdata->mipi_lanes = mipi_lanes;if (pdata->mipi_lanes >MAX_LANES_SUPPORT || pdata->mipi_lanes <=0 )
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 310/1157 drm/mgag200: Acquire I/O lock while reading EDID
In reply to Greg Kroah-HartmanFrom: Thomas Zimmermann <[email protected]>
[ Upstream commit 5913ab941d6ea782e841234c76958c6872ea752d ]
DDC operation conflicts with concurrent mode setting. Acquire the driver's I/O lock in get_modes to prevent this. This change should have been part of commit 931e3f3a0e99 ("drm/mgag200: Protect concurrent access to I/O registers with lock"), but apparently got lost somewhere.
v3:
* fix commit message to say 'drm/mgag200' (Jocelyn)
--- drivers/gpu/drm/mgag200/mgag200_mode.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/gpu/drm/mgag200/mgag200_mode.c +10 -0
@@ -667,16 +667,26 @@ static void mgag200_disable_display(struct mga_device *mdev)static int mga_vga_get_modes (struct drm_connector *connector) { +struct mga_device *mdev =to_mga_device (connector->dev);struct mga_connector *mga_connector =to_mga_connector (connector);struct edid *edid;int ret =0 ; +/* +* Protect access to I/O registers from concurrent modesetting +* by acquiring the I/O-register lock. +*/ +mutex_lock (&mdev->rmmio_lock); + edid =drm_get_edid (connector, &mga_connector->i2c->adapter);if (edid) {drm_connector_update_edid_property (connector, edid); ret =drm_add_edid_modes (connector, edid);kfree (edid); } + +mutex_unlock (&mdev->rmmio_lock); +return ret; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 311/1157 drm/meson: Fix refcount leak in meson_encoder_hdmi_init
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit 7381076809586528e2a812a709e2758916318a99 ]
of_find_device_by_node() takes reference, we should use put_device() to release it when not need anymore.
Add missing put_device() in error path to avoid refcount leak.
--- drivers/gpu/drm/meson/meson_encoder_hdmi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/meson/meson_encoder_hdmi.c +3 -1
@@ -435,8 +435,10 @@ int meson_encoder_hdmi_init(struct meson_drm *priv)cec_fill_conn_info_from_drm (&conn_info, meson_encoder_hdmi->connector); notifier =cec_notifier_conn_register (&pdev->dev,NULL , &conn_info); -if (!notifier) +if (!notifier) { +put_device (&pdev->dev);return -ENOMEM ; + } meson_encoder_hdmi->cec_notifier = notifier; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 312/1157 drm/dp: Export symbol / kerneldoc fixes for DP AUX bus
In reply to Greg Kroah-HartmanFrom: Douglas Anderson <[email protected]>
[ Upstream commit 39c28cdfb719f0e306b447f0827dfd712f81858b ]
While working on the DP AUX bus code I found a few small things that should be fixed. Namely the non-devm version of of_dp_aux_populate_ep_devices() was missing an export. There was also an extra blank line in a kerneldoc and a kerneldoc that incorrectly documented a return value. Fix these.
--- drivers/gpu/drm/display/drm_dp_aux_bus.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/display/drm_dp_aux_bus.c +1 -3
@@ -66,7 +66,6 @@ static int dp_aux_ep_probe(struct device *dev)* @dev: The device to remove. * * Calls through to the endpoint driver remove. -* */ static void dp_aux_ep_remove (struct device *dev) {
@@ -120,8 +119,6 @@ ATTRIBUTE_GROUPS(dp_aux_ep_dev);/** * dp_aux_ep_dev_release() - Free memory for the dp_aux_ep device * @dev: The device to free. -* -* Return: 0 if no error or negative error code. */ static void dp_aux_ep_dev_release (struct device *dev) {
@@ -256,6 +253,7 @@ int of_dp_aux_populate_ep_devices(struct drm_dp_aux *aux)return 0 ; } +EXPORT_SYMBOL_GPL (of_dp_aux_populate_ep_devices);static void of_dp_aux_depopulate_ep_devices_void (void *data) {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 313/1157 drm/bridge: tc358767: Handle dsi_lanes == 0 as invalid
In reply to Greg Kroah-HartmanFrom: Marek Vasut <[email protected]>
[ Upstream commit 0d662350928e6787d29ab205e47e5aa6f1f792f9 ]
Handle empty data-lanes = < >; property, which translates to dsi_lanes = 0 as invalid.
--- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/tc358767.c +1 -1
@@ -1871,7 +1871,7 @@ static int tc_mipi_dsi_host_attach(struct tc_data *tc)of_node_put (host_node);of_node_put (endpoint); -if (dsi_lanes <0 || dsi_lanes >4 ) +if (dsi_lanes <=0 || dsi_lanes >4 )return -EINVAL ;if (!host)
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 314/1157 drm/bridge: tc358767: Make sure Refclk clock are enabled
In reply to Greg Kroah-HartmanFrom: Marek Vasut <[email protected]>
[ Upstream commit 0b4c48f3e315d172e4cc06e10f2c8ba180788baf ]
The Refclk may be supplied by SoC clock output instead of crystal oscillator, make sure the clock are enabled before any other action is performed with the bridge chip, otherwise it may either fail to operate at all, or miss reset GPIO toggle.
--- drivers/gpu/drm/bridge/tc358767.c | 32 ++++++++++++++++++++++++------- 1 file changed, 25 insertions(+), 7 deletions(-)
drivers/gpu/drm/bridge/tc358767.c +25 -7
@@ -2004,6 +2004,13 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc)return -EINVAL ; } +static void tc_clk_disable (void *data) +{ +struct clk *refclk = data; + +clk_disable_unprepare (refclk); +} +static int tc_probe (struct i2c_client *client,const struct i2c_device_id *id) {struct device *dev = &client->dev;
@@ -2020,6 +2027,24 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)if (ret)return ret; + tc->refclk =devm_clk_get (dev,"ref" ); +if (IS_ERR (tc->refclk)) { + ret =PTR_ERR (tc->refclk); +dev_err (dev,"Failed to get refclk: %d\n" , ret); +return ret; + } + + ret =clk_prepare_enable (tc->refclk); +if (ret) +return ret; + + ret =devm_add_action_or_reset (dev, tc_clk_disable, tc->refclk); +if (ret) +return ret; + +/* tRSTW = 100 cycles , at 13 MHz that is ~7.69 us */ +usleep_range (10 ,15 ); +/* Shut down GPIO is optional */ tc->sd_gpio =devm_gpiod_get_optional (dev,"shutdown" ,GPIOD_OUT_HIGH );if (IS_ERR (tc->sd_gpio))
@@ -2040,13 +2065,6 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)usleep_range (5000 ,10000 ); } - tc->refclk =devm_clk_get (dev,"ref" ); -if (IS_ERR (tc->refclk)) { - ret =PTR_ERR (tc->refclk); -dev_err (dev,"Failed to get refclk: %d\n" , ret); -return ret; - } - tc->regmap =devm_regmap_init_i2c (client, &tc_regmap_config);if (IS_ERR (tc->regmap)) { ret =PTR_ERR (tc->regmap);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 315/1157 ath10k: do not enforce interrupt trigger type
In reply to Greg Kroah-HartmanFrom: Krzysztof Kozlowski <[email protected]>
[ Upstream commit 1ee6c5abebd3cacf2ac4378d0ed4f57fd4850421 ]
Interrupt line can be configured on different hardware in different way, even inverted. Therefore driver should not enforce specific trigger type - edge rising - but instead rely on Devicetree to configure it.
All Qualcomm DTSI with WCN3990 define the interrupt type as level high, so the mismatch between DTSI and driver causes rebind issues:
$ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/unbind $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/bind [ 44.763114] irq: type mismatch, failed to map hwirq-446 for interrupt-controller@17a00000! [ 44.763130] ath10k_snoc 18800000.wifi: error -ENXIO: IRQ index 0 not found [ 44.763140] ath10k_snoc 18800000.wifi: failed to initialize resource: -6
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.0.c8-00009-QCAHLSWSC8180XMTPLZ-1
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1
--- drivers/net/wireless/ath/ath10k/snoc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath10k/snoc.c +2 -3
@@ -1249,13 +1249,12 @@ static void ath10k_snoc_init_napi(struct ath10k *ar)static int ath10k_snoc_request_irq (struct ath10k *ar) {struct ath10k_snoc *ar_snoc =ath10k_snoc_priv (ar); -int irqflags =IRQF_TRIGGER_RISING ;int ret, id;for (id =0 ; id <CE_COUNT_MAX ; id++) { ret =request_irq (ar_snoc->ce_irqs[id].irq_line, - ath10k_snoc_per_engine_handler, - irqflags, ce_name[id], ar); + ath10k_snoc_per_engine_handler,0 , + ce_name[id], ar);if (ret) { ath10k_err(ar, "failed to register IRQ handler for CE %d: %d\n",
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 316/1157 ath11k: Fix warning on variable sar dereference before check
In reply to Greg Kroah-HartmanFrom: Baochen Qiang <[email protected]>
[ Upstream commit 77bbbd5e0ed3b5998a353b0948584faa4f565f0e ]
We are seeing below warning:
warn: variable dereferenced before check 'sar'
Fix it by moving ahead pointer check on 'sar'.
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
--- drivers/net/wireless/ath/ath11k/mac.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
drivers/net/wireless/ath/ath11k/mac.c +6 -7
@@ -8297,11 +8297,15 @@ static int ath11k_mac_op_set_bios_sar_specs(struct ieee80211_hw *hw, const struct cfg80211_sar_specs *sar) {struct ath11k *ar = hw->priv; -const struct cfg80211_sar_sub_specs *sspec = sar->sub_specs; +const struct cfg80211_sar_sub_specs *sspec;int ret, index;u8 *sar_tbl;u32 i; +if (!sar || sar->type !=NL80211_SAR_TYPE_POWER || + sar->num_sub_specs ==0 ) +return -EINVAL ; +mutex_lock (&ar->conf_mutex); if (!test_bit(WMI_TLV_SERVICE_BIOS_SAR_SUPPORT, ar->ab->wmi_ab.svc_map) ||
@@ -8310,12 +8314,6 @@ static int ath11k_mac_op_set_bios_sar_specs(struct ieee80211_hw *hw, goto exit; } -if (!sar || sar->type !=NL80211_SAR_TYPE_POWER || - sar->num_sub_specs ==0 ) { - ret = -EINVAL ; - goto exit; - } - ret =ath11k_wmi_pdev_set_bios_geo_table_param (ar);if (ret) {ath11k_warn (ar->ab,"failed to set geo table: %d\n" , ret);
@@ -8328,6 +8326,7 @@ static int ath11k_mac_op_set_bios_sar_specs(struct ieee80211_hw *hw, goto exit; } + sspec = sar->sub_specs;for (i =0 ; i < sar->num_sub_specs; i++) {if (sspec->freq_range_index >= (BIOS_SAR_TABLE_LEN >>1 )) { ath11k_warn(ar->ab, "Ignore bad frequency index %u, max allowed %u\n",
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 317/1157 ath11k: Init hw_params before setting up AHB resources
In reply to Greg Kroah-HartmanFrom: Manikanta Pubbisetty <[email protected]>
[ Upstream commit bebcfd2534a63ab7e7325f5337662bc84ca038b6 ]
As part of adding the support of WCN6750 to ath11k, bus_params were moved to hw_params and this regressed the initialization of WCN6750. By the time AHB resources are setup for WCN6750, hw_params will not be initialized and therefore initialization for WCN6750 will fail. This is applicable only for WCN6750, no other device is impacted.
Fix this by moving the initialization of hw_params before setting up AHB resources.
Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
--- drivers/net/wireless/ath/ath11k/ahb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath11k/ahb.c +2 -2
@@ -976,11 +976,11 @@ static int ath11k_ahb_probe(struct platform_device *pdev) ab->hw_rev = hw_rev;platform_set_drvdata (pdev, ab); - ret =ath11k_ahb_setup_resources (ab); + ret =ath11k_core_pre_init (ab);if (ret) goto err_core_free; - ret =ath11k_core_pre_init (ab); + ret =ath11k_ahb_setup_resources (ab);if (ret) goto err_core_free;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 318/1157 drm/edid: reset display info in drm_add_edid_modes() for NULL edid
In reply to Greg Kroah-HartmanFrom: Jani Nikula <[email protected]>
[ Upstream commit d10f7117aa43b0b0d1c4b878afafb6d151da441d ]
If a NULL edid gets passed to drm_add_edid_modes(), we should probably also reset the display info.
--- drivers/gpu/drm/drm_edid.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_edid.c +1 -0
@@ -5697,6 +5697,7 @@ static int drm_edid_connector_update(struct drm_connector *connector,u32 quirks;if (edid ==NULL ) { +drm_reset_display_info (connector);clear_eld (connector);return 0 ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 319/1157 drm/bridge: lt9611: Use both bits for HDMI sensing
In reply to Greg Kroah-HartmanFrom: John Stultz <[email protected]>
[ Upstream commit 649eb3828fb22e829e222ebd83f4e11dc503a565 ]
In commit 19cf41b64e3b ("lontium-lt9611: check a different register bit for HDMI sensing"), the bit flag used to detect HDMI cable connect was switched from BIT(2) to BIT(0) to improve compatibility with some monitors that didn't seem to set BIT(2).
However, with that change, I've seen occasional issues where the detection failed, because BIT(2) was set, but not BIT(0).
Unfortunately, as I understand it, the bits and their function was never clearly documented. So lets instead check both (BIT(2) | BIT(0)) when checking the register.
--- drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/lontium-lt9611.c +1 -1
@@ -586,7 +586,7 @@ lt9611_connector_detect(struct drm_connector *connector, bool force)int connected =0 ;regmap_read (lt9611->regmap,0x825e , ®_val); - connected = (reg_val &BIT (0 )); + connected = (reg_val & (BIT (2 ) |BIT (0 ))); lt9611->status = connected ? connector_status_connected : connector_status_disconnected;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 320/1157 drm/st7735r: Fix module autoloading for Okaya RH128128T
In reply to Greg Kroah-HartmanFrom: Javier Martinez Canillas <[email protected]>
[ Upstream commit 9ad6f181ad9a19a26bda73a7b199df44ccfcdaba ]
The SPI core always reports a "MODALIAS=spi:<foo>", even if the device was registered via OF. This means that the st7735r.ko module won't autoload if a DT has a node with a compatible "okaya,rh128128t" string.
In that case, kmod expects a "MODALIAS=of:N*T*Cokaya,rh128128t" uevent but instead will get a "MODALIAS=spi:rh128128t", which is not present in the list of aliases:
$ modinfo drivers/gpu/drm/tiny/st7735r.ko | grep alias alias: of:N*T*Cokaya,rh128128tC* alias: of:N*T*Cokaya,rh128128t alias: of:N*T*Cjianda,jd-t18003-t01C* alias: of:N*T*Cjianda,jd-t18003-t01 alias: spi:jd-t18003-t01
To workaround this issue, add in the SPI table an entry for that device.
--- drivers/gpu/drm/tiny/st7735r.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/tiny/st7735r.c +1 -0
@@ -174,6 +174,7 @@ MODULE_DEVICE_TABLE(of, st7735r_of_match);static const struct spi_device_id st7735r_id[] = { {"jd-t18003-t01" , (uintptr_t )&jd_t18003_t01_cfg }, + {"rh128128t" , (uintptr_t )&rh128128t_cfg }, { }, };MODULE_DEVICE_TABLE (spi, st7735r_id);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 321/1157 drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
In reply to Greg Kroah-HartmanFrom: Gao Chao <[email protected]>
[ Upstream commit a67664860f7833015a683ea295f7c79ac2901332 ]
If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m, bulding fails:
drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
`drm_panel_dp_aux_backlight'
make: *** [vmlinux] Error 1
Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and CONFIG_DRM_DISPLAY_HELPER to fix this error.
--- drivers/gpu/drm/panel/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/Kconfig +2 -0
@@ -438,6 +438,8 @@ config DRM_PANEL_SAMSUNG_ATNA33XC20 depends on OF depends on BACKLIGHT_CLASS_DEVICE depends on PM + select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_DP_AUX_BUS help DRM panel driver for the Samsung ATNA33XC20 panel. This panel can't
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 322/1157 drm: bridge: adv7511: Move CEC definitions to adv7511_cec.c
In reply to Greg Kroah-HartmanFrom: Fabio Estevam <[email protected]>
[ Upstream commit 91776af1d8deb8f36cbec6bf2bf24b661b2b5cbb ]
ADV7511_REG_CEC_RX_FRAME_HDR[] and ADV7511_REG_CEC_RX_FRAME_LEN[] are only used inside adv7511_cec.c.
Move their definitions to this file to avoid the following build warnings when CONFIG_DRM_I2C_ADV7511_CEC is not selected:
drivers/gpu/drm/bridge/adv7511/adv7511.h:229:17: warning: 'ADV7511_REG_CEC_RX_FRAME_HDR' defined but not used [-Wunused-const-variable=] drivers/gpu/drm/bridge/adv7511/adv7511.h:235:17: warning: 'ADV7511_REG_CEC_RX_FRAME_LEN' defined but not used [-Wunused-const-variable=]
--- drivers/gpu/drm/bridge/adv7511/adv7511.h | 12 ------------ drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 12 ++++++++++++ 2 files changed, 12 insertions(+), 12 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511.h +0 -12
@@ -226,18 +226,6 @@#define ADV7511_REG_CEC_CLK_DIV 0x4e#define ADV7511_REG_CEC_SOFT_RESET 0x50 -static const u8 ADV7511_REG_CEC_RX_FRAME_HDR [] = { -ADV7511_REG_CEC_RX1_FRAME_HDR , -ADV7511_REG_CEC_RX2_FRAME_HDR , -ADV7511_REG_CEC_RX3_FRAME_HDR , -}; - -static const u8 ADV7511_REG_CEC_RX_FRAME_LEN [] = { -ADV7511_REG_CEC_RX1_FRAME_LEN , -ADV7511_REG_CEC_RX2_FRAME_LEN , -ADV7511_REG_CEC_RX3_FRAME_LEN , -}; -#define ADV7533_REG_CEC_OFFSET 0x70enum adv7511_input_clock {
drivers/gpu/drm/bridge/adv7511/adv7511_cec.c +12 -0
@@ -15,6 +15,18 @@#include "adv7511.h" +static const u8 ADV7511_REG_CEC_RX_FRAME_HDR [] = { +ADV7511_REG_CEC_RX1_FRAME_HDR , +ADV7511_REG_CEC_RX2_FRAME_HDR , +ADV7511_REG_CEC_RX3_FRAME_HDR , +}; + +static const u8 ADV7511_REG_CEC_RX_FRAME_LEN [] = { +ADV7511_REG_CEC_RX1_FRAME_LEN , +ADV7511_REG_CEC_RX2_FRAME_LEN , +ADV7511_REG_CEC_RX3_FRAME_LEN , +}; +#define ADV7511_INT1_CEC_MASK \ (ADV7511_INT1_CEC_TX_READY | ADV7511_INT1_CEC_TX_ARBIT_LOST | \ ADV7511_INT1_CEC_TX_RETRY_TIMEOUT | ADV7511_INT1_CEC_RX_READY1 | \
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 323/1157 wifi: rtlwifi: fix error codes in rtl_debugfs_set_write_h2c()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit b88d28146c30a8e14f0f012d56ebf19b68a348f4 ]
If the copy_from_user() fails or the user gives invalid date then the correct thing to do is to return a negative error code. (Currently it returns success).
I made a copy additional related cleanups:
1) There is no need to check "buffer" for NULL. That's handled by copy_from_user().
2) The "h2c_len" variable cannot be negative because it is unsigned and because sscanf() does not return negative error codes.
--- drivers/net/wireless/realtek/rtlwifi/debug.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/net/wireless/realtek/rtlwifi/debug.c +4 -4
@@ -329,8 +329,8 @@ static ssize_t rtl_debugfs_set_write_h2c(struct file *filp, tmp_len = (count >sizeof (tmp) -1 ?sizeof (tmp) -1 : count); -if (!buffer ||copy_from_user (tmp, buffer, tmp_len)) -return count; +if (copy_from_user (tmp, buffer, tmp_len)) +return -EFAULT ; tmp[tmp_len] ='\0' ;
@@ -340,8 +340,8 @@ static ssize_t rtl_debugfs_set_write_h2c(struct file *filp, &h2c_data[4 ], &h2c_data[5 ], &h2c_data[6], &h2c_data[7]); -if (h2c_len <=0 ) -return count; +if (h2c_len ==0 ) +return -EINVAL ;for (i =0 ; i < h2c_len; i++) h2c_data_packed[i] = (u8 )h2c_data[i];
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 324/1157 wifi: wilc1000: use correct sequence of RESET for chip Power-UP/Down
In reply to Greg Kroah-HartmanFrom: Ajay Singh <[email protected]>
[ Upstream commit fcf690b0b47494df51d214db5c5a714a400b0257 ]
For power-up sequence, WILC expects RESET set to high 5ms after making chip_en(enable) so corrected chip power-up sequence by making RESET high. For Power-Down sequence, the correct sequence make RESET and CHIP_EN low without any extra delay.
--- drivers/net/wireless/microchip/wilc1000/spi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/microchip/wilc1000/spi.c +3 -3
@@ -191,11 +191,11 @@ static void wilc_wlan_power(struct wilc *wilc, bool on)/* assert ENABLE: */ gpiod_set_value (gpios->enable,1 );mdelay (5 ); -/* deassert RESET: */ -gpiod_set_value (gpios->reset,0 ); - }else {/* assert RESET: */ gpiod_set_value (gpios->reset,1 ); + }else { +/* deassert RESET: */ +gpiod_set_value (gpios->reset,0 );/* deassert ENABLE: */ gpiod_set_value (gpios->enable,0 ); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 325/1157 ath11k: fix netdev open race
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
[ Upstream commit d4ba1ff87b17e81686ada8f429300876f55f95ad ]
Make sure to allocate resources needed before registering the device.
This specifically avoids having a racing open() trigger a BUG_ON() in mod_timer() when ath11k_mac_op_start() is called before the mon_reap_timer as been set up.
I did not see this issue with next-20220310, but I hit it on every probe with next-20220511. Perhaps some timing changed in between.
Here's the backtrace:
[ 51.346947] kernel BUG at kernel/time/timer.c:990! [ 51.346958] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ... [ 51.578225] Call trace: [ 51.583293] __mod_timer+0x298/0x390 [ 51.589518] mod_timer+0x14/0x20 [ 51.595368] ath11k_mac_op_start+0x41c/0x4a0 [ath11k] [ 51.603165] drv_start+0x38/0x60 [mac80211] [ 51.610110] ieee80211_do_open+0x29c/0x7d0 [mac80211] [ 51.617945] ieee80211_open+0x60/0xb0 [mac80211] [ 51.625311] __dev_open+0x100/0x1c0 [ 51.631420] __dev_change_flags+0x194/0x210 [ 51.638214] dev_change_flags+0x24/0x70 [ 51.644646] do_setlink+0x228/0xdb0 [ 51.650723] __rtnl_newlink+0x460/0x830 [ 51.657162] rtnl_newlink+0x4c/0x80 [ 51.663229] rtnetlink_rcv_msg+0x124/0x390 [ 51.669917] netlink_rcv_skb+0x58/0x130 [ 51.676314] rtnetlink_rcv+0x18/0x30 [ 51.682460] netlink_unicast+0x250/0x310 [ 51.688960] netlink_sendmsg+0x19c/0x3e0 [ 51.695458] ____sys_sendmsg+0x220/0x290 [ 51.701938] ___sys_sendmsg+0x7c/0xc0 [ 51.708148] __sys_sendmsg+0x68/0xd0 [ 51.714254] __arm64_sys_sendmsg+0x28/0x40 [ 51.720900] invoke_syscall+0x48/0x120
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
--- drivers/net/wireless/ath/ath11k/core.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/net/wireless/ath/ath11k/core.c +8 -8
@@ -1225,23 +1225,23 @@ static int ath11k_core_pdev_create(struct ath11k_base *ab)return ret; } - ret =ath11k_mac_register (ab); + ret =ath11k_dp_pdev_alloc (ab);if (ret) { -ath11k_err (ab,"failed register the radio with mac80211: %d\n" , ret); +ath11k_err (ab,"failed to attach DP pdev: %d\n" , ret); goto err_pdev_debug; } - ret =ath11k_dp_pdev_alloc (ab); + ret =ath11k_mac_register (ab);if (ret) { -ath11k_err (ab,"failed to attach DP pdev: %d\n" , ret); - goto err_mac_unregister; +ath11k_err (ab,"failed register the radio with mac80211: %d\n" , ret); + goto err_dp_pdev_free; } ret =ath11k_thermal_register (ab);if (ret) {ath11k_err (ab,"could not register thermal device: %d\n" , ret); - goto err_dp_pdev_free; + goto err_mac_unregister; } ret =ath11k_spectral_init (ab);
@@ -1254,10 +1254,10 @@ static int ath11k_core_pdev_create(struct ath11k_base *ab) err_thermal_unregister:ath11k_thermal_unregister (ab); -err_dp_pdev_free: -ath11k_dp_pdev_free (ab); err_mac_unregister:ath11k_mac_unregister (ab); +err_dp_pdev_free: +ath11k_dp_pdev_free (ab); err_pdev_debug:ath11k_debugfs_pdev_destroy (ab);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 326/1157 ath11k: fix IRQ affinity warning on shutdown
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
[ Upstream commit 3bd0c69653ac636eae8872aacdcd4156f772f928 ]
Make sure to clear the IRQ affinity hint also on shutdown to avoid triggering a WARN_ON_ONCE() in __free_irq() when stopping MHI while using a single MSI vector.
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
--- drivers/net/wireless/ath/ath11k/pci.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/wireless/ath/ath11k/pci.c +2 -0
@@ -920,7 +920,9 @@ static void ath11k_pci_remove(struct pci_dev *pdev)static void ath11k_pci_shutdown (struct pci_dev *pdev) {struct ath11k_base *ab =pci_get_drvdata (pdev); +struct ath11k_pci *ab_pci =ath11k_pci_priv (ab); +ath11k_pci_set_irq_affinity_hint (ab_pci,NULL );ath11k_pci_power_down (ab); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 327/1157 drm/mipi-dbi: align max_chunk to 2 in spi_transfer
In reply to Greg Kroah-HartmanFrom: Yunhao Tian <[email protected]>
[ Upstream commit 435c249008cba04ed6a7975e9411f3b934620204 ]
In __spi_validate, there's a validation that no partial transfers are accepted (xfer->len % w_size must be zero). When max_chunk is not a multiple of bpw (e.g. max_chunk = 65535, bpw = 16), the transfer will be rejected.
This patch aligns max_chunk to 2 bytes (the maximum value of bpw is 16), so that no partial transfer will occur.
--- drivers/gpu/drm/drm_mipi_dbi.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/gpu/drm/drm_mipi_dbi.c +7 -0
@@ -1199,6 +1199,13 @@ int mipi_dbi_spi_transfer(struct spi_device *spi, u32 speed_hz,size_t chunk;int ret; +/* In __spi_validate, there's a validation that no partial transfers +* are accepted (xfer->len % w_size must be zero). +* Here we align max_chunk to multiple of 2 (16bits), +* to prevent transfers from being rejected. +*/ + max_chunk =ALIGN_DOWN (max_chunk,2 ); +spi_message_init_with_transfers (&m, &tr,1 );while (len) {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 328/1157 drm/ssd130x: Only define a SPI device ID table when built as a module
In reply to Greg Kroah-HartmanFrom: Javier Martinez Canillas <[email protected]>
[ Upstream commit 01ece65132e2980ece4eca91105dfc9eed504881 ]
The kernel test robot reports a compile warning due the ssd130x_spi_table variable being defined but not used. This happen when ssd130x-spi driver is built-in instead of being built as a module, i.e:
CC drivers/gpu/drm/solomon/ssd130x-spi.o
AR drivers/base/firmware_loader/built-in.a
AR drivers/base/built-in.a
CC kernel/trace/trace.o
drivers/gpu/drm/solomon/ssd130x-spi.c:155:35: warning: ‘ssd130x_spi_table’ defined but not used [-Wunused-const-variable=]
155 | static const struct spi_device_id ssd130x_spi_table[] = {
| ^~~~~~~~~~~~~~~~~The driver shouldn't need a SPI device ID table and only have an OF device ID table, but the former is needed to workaround an issue in the SPI core. This always reports a MODALIAS of the form "spi:<device>" even for devices registered through Device Trees.
But the table is only needed when the driver built as a module to populate the .ko alias info. It's not needed when the driver is built-in the kernel.
--- drivers/gpu/drm/solomon/ssd130x-spi.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/solomon/ssd130x-spi.c +2 -0
@@ -143,6 +143,7 @@ static const struct of_device_id ssd130x_of_match[] = { };MODULE_DEVICE_TABLE (of, ssd130x_of_match); +#if IS_MODULE (CONFIG_DRM_SSD130X_SPI )/* * The SPI core always reports a MODALIAS uevent of the form "spi:<dev>", even * if the device was registered via OF. This means that the module will not be
@@ -160,6 +161,7 @@ static const struct spi_device_id ssd130x_spi_table[] = { {/* sentinel */ } };MODULE_DEVICE_TABLE (spi, ssd130x_spi_table); +#endif static struct spi_driver ssd130x_spi_driver = { .driver = {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 329/1157 selftests/bpf: Fix test_run logic in fexit_stress.c
In reply to Greg Kroah-HartmanFrom: Yuntao Wang <[email protected]>
[ Upstream commit eb7b36ce47f830a01ad9405e673b563cc3638d5d ]
In the commit da00d2f117a0 ("bpf: Add test ops for BPF_PROG_TYPE_TRACING"), the bpf_fentry_test1 function was moved into bpf_prog_test_run_tracing(), which is the test_run function of the tracing BPF programs.
Thus calling 'bpf_prog_test_run_opts(filter_fd, &topts)' will not trigger bpf_fentry_test1 function as filter_fd is a sk_filter BPF program.
Fix it by replacing filter_fd with fexit_fd in the bpf_prog_test_run_opts() function.
--- .../selftests/bpf/prog_tests/fexit_stress.c | 32 +++---------------- 1 file changed, 4 insertions(+), 28 deletions(-)
tools/testing/selftests/bpf/prog_tests/fexit_stress.c +4 -28
@@ -7,11 +7,9 @@void serial_test_fexit_stress (void ) { -char test_skb[128 ] = {};int fexit_fd[CNT ] = {};int link_fd[CNT ] = {}; -char error[4096 ]; -int err, i, filter_fd; +int err, i;const struct bpf_insn trace_program[] = {BPF_MOV64_IMM (BPF_REG_0 ,0 ),
@@ -20,25 +18,9 @@ void serial_test_fexit_stress(void)LIBBPF_OPTS (bpf_prog_load_opts, trace_opts, .expected_attach_type = BPF_TRACE_FEXIT, - .log_buf = error, - .log_size = sizeof(error), ); -const struct bpf_insn skb_program[] = { -BPF_MOV64_IMM (BPF_REG_0 ,0 ), -BPF_EXIT_INSN (), - }; - -LIBBPF_OPTS (bpf_prog_load_opts, skb_opts, - .log_buf = error, - .log_size = sizeof(error), - ); - -LIBBPF_OPTS (bpf_test_run_opts, topts, - .data_in = test_skb, - .data_size_in = sizeof(test_skb), - .repeat = 1, - ); +LIBBPF_OPTS (bpf_test_run_opts, topts); err =libbpf_find_vmlinux_btf_id ("bpf_fentry_test1" , trace_opts.expected_attach_type);
@@ -58,15 +40,9 @@ void serial_test_fexit_stress(void) goto out; } - filter_fd =bpf_prog_load (BPF_PROG_TYPE_SOCKET_FILTER ,NULL ,"GPL" , - skb_program,sizeof (skb_program) /sizeof (struct bpf_insn ), - &skb_opts); -if (!ASSERT_GE (filter_fd,0 ,"test_program_loaded" )) - goto out; + err =bpf_prog_test_run_opts (fexit_fd[0 ], &topts); +ASSERT_OK (err,"bpf_prog_test_run_opts" ); - err =bpf_prog_test_run_opts (filter_fd, &topts); -close (filter_fd); -CHECK_FAIL (err); out:for (i =0 ; i <CNT ; i++) {if (link_fd[i])
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 330/1157 sample: bpf: xdp_router_ipv4: Allow the kernel to send arp requests
In reply to Greg Kroah-HartmanFrom: Lorenzo Bianconi <[email protected]>
[ Upstream commit 200a89e3e88786b52bc1dd5f26a310c097f4c6a7 ]
Forward the packet to the kernel if the gw router mac address is missing in to trigger ARP discovery.
--- samples/bpf/xdp_router_ipv4.bpf.c | 9 +++++++++ 1 file changed, 9 insertions(+)
samples/bpf/xdp_router_ipv4.bpf.c +9 -0
@@ -150,6 +150,15 @@ int xdp_router_ipv4_prog(struct xdp_md *ctx) dest_mac =bpf_map_lookup_elem (&arp_table, &prefix_value->gw); +if (!dest_mac) { +/* Forward the packet to the kernel in +* order to trigger ARP discovery for +* the default gw. +*/ +if (rec) +NO_TEAR_INC (rec->xdp_pass); +return XDP_PASS ; + } } }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 331/1157 selftests/bpf: Fix tc_redirect_dtime
In reply to Greg Kroah-HartmanFrom: Martin KaFai Lau <[email protected]>
[ Upstream commit e6ff92f41b65fce07365f1066fb13b5e42aca08d ]
tc_redirect_dtime was reported flaky from time to time. It always fails at the udp test and complains about the bpf@tc-ingress got a skb->tstamp when handling udp packet. It is unexpected because the skb->tstamp should have been cleared when crossing different netns.
The most likely cause is that the skb is actually a tcp packet from the earlier tcp test. It could be the final TCP_FIN handling.
This patch tightens the skb->tstamp check in the bpf prog. It ensures the skb is the current testing traffic. First, it checks that skb matches the IPPROTO of the running test (i.e. tcp vs udp). Second, it checks the server port (dst_ns_port). The server port is unique for each test (50000 + test_enum).
Also fixed a typo in test_udp_dtime(): s/P100/P101/
--- .../selftests/bpf/prog_tests/tc_redirect.c | 8 +-- .../selftests/bpf/progs/test_tc_dtime.c | 53 ++++++++++++++++++- 2 files changed, 55 insertions(+), 6 deletions(-)
tools/testing/selftests/bpf/prog_tests/tc_redirect.c +4 -4
@@ -646,7 +646,7 @@ static void test_tcp_clear_dtime(struct test_tc_dtime *skel)__u32 *errs = skel->bss->errs[t]; skel->bss->test = t; -test_inet_dtime (AF_INET6 ,SOCK_STREAM ,IP6_DST ,0 ); +test_inet_dtime (AF_INET6 ,SOCK_STREAM ,IP6_DST ,50000 + t);ASSERT_EQ (dtimes[INGRESS_FWDNS_P100 ],0 ,dtime_cnt_str (t,INGRESS_FWDNS_P100 ));
@@ -683,7 +683,7 @@ static void test_tcp_dtime(struct test_tc_dtime *skel, int family, bool bpf_fwd) errs = skel->bss->errs[t]; skel->bss->test = t; -test_inet_dtime (family,SOCK_STREAM , addr,0 ); +test_inet_dtime (family,SOCK_STREAM , addr,50000 + t);/* fwdns_prio100 prog does not read delivery_time_type, so * kernel puts the (rcv) timetamp in __sk_buff->tstamp
@@ -715,13 +715,13 @@ static void test_udp_dtime(struct test_tc_dtime *skel, int family, bool bpf_fwd) errs = skel->bss->errs[t]; skel->bss->test = t; -test_inet_dtime (family,SOCK_DGRAM , addr,0 ); +test_inet_dtime (family,SOCK_DGRAM , addr,50000 + t);ASSERT_EQ (dtimes[INGRESS_FWDNS_P100 ],0 ,dtime_cnt_str (t,INGRESS_FWDNS_P100 ));/* non mono delivery time is not forwarded */ ASSERT_EQ (dtimes[INGRESS_FWDNS_P101 ],0 , -dtime_cnt_str (t,INGRESS_FWDNS_P100 )); +dtime_cnt_str (t,INGRESS_FWDNS_P101 ));for (i =EGRESS_FWDNS_P100 ; i <SET_DTIME ; i++)ASSERT_GT (dtimes[i],0 ,dtime_cnt_str (t, i));
tools/testing/selftests/bpf/progs/test_tc_dtime.c +51 -2
95 lines not on this page · raw message
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 332/1157 libbpf: Fix is_pow_of_2
In reply to Greg Kroah-HartmanFrom: Yuze Chi <[email protected]>
[ Upstream commit 611edf1bacc51355ccb497915695db7f869cb382 ]
Move the correct definition from linker.c into libbpf_internal.h.
--- tools/lib/bpf/libbpf.c | 5 ----- tools/lib/bpf/libbpf_internal.h | 5 +++++ tools/lib/bpf/linker.c | 5 ----- 3 files changed, 5 insertions(+), 10 deletions(-)
tools/lib/bpf/libbpf.c +0 -5
@@ -4943,11 +4943,6 @@ bpf_object__populate_internal_map(struct bpf_object *obj, struct bpf_map *map)static void bpf_map__destroy (struct bpf_map *map); -static bool is_pow_of_2 (size_t x) -{ -return x && (x & (x -1 )); -} -static size_t adjust_ringbuf_sz (size_t sz) {__u32 page_sz =sysconf (_SC_PAGE_SIZE);
tools/lib/bpf/libbpf_internal.h +5 -0
@@ -580,4 +580,9 @@ struct bpf_link * usdt_manager_attach_usdt(struct usdt_manager *man, const char *usdt_provider, const char *usdt_name, __u64 usdt_cookie); +static inline bool is_pow_of_2 (size_t x) +{ +return x && (x & (x -1 )) ==0 ; +} +#endif /* __LIBBPF_LIBBPF_INTERNAL_H */
tools/lib/bpf/linker.c +0 -5
@@ -697,11 +697,6 @@ static int linker_load_obj_file(struct bpf_linker *linker, const char *filename,return err; } -static bool is_pow_of_2 (size_t x) -{ -return x && (x & (x -1 )) ==0 ; -} -static int linker_sanity_check_elf (struct src_obj *obj) {struct src_sec *sec;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 333/1157 ath11k: fix missing skb drop on htc_tx_completion error
In reply to Greg Kroah-HartmanFrom: Christian 'Ansuel' Marangi <[email protected]>
[ Upstream commit e5646fe3b7ef739c392e59da7db6adf5e1fdef42 ]
On htc_tx_completion error the skb is not dropped. This is wrong since the completion_handler logic expect the skb to be consumed anyway even when an error is triggered. Not freeing the skb on error is a memory leak since the skb won't be freed anywere else. Correctly free the packet on eid >= ATH11K_HTC_EP_COUNT before returning.
Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1
--- drivers/net/wireless/ath/ath11k/htc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/htc.c +3 -1
@@ -258,8 +258,10 @@ void ath11k_htc_tx_completion_handler(struct ath11k_base *ab,u8 eid; eid =ATH11K_SKB_CB (skb)->eid; -if (eid >=ATH11K_HTC_EP_COUNT ) +if (eid >=ATH11K_HTC_EP_COUNT ) { +dev_kfree_skb_any (skb);return ; + } ep = &htc->endpoint[eid];spin_lock_bh (&htc->tx_lock);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 334/1157 ath11k: Fix incorrect debug_mask mappings
In reply to Greg Kroah-HartmanFrom: Manikanta Pubbisetty <[email protected]>
[ Upstream commit 9331f7d3c54a263bede5055e106e40b28d0bd937 ]
Currently a couple of debug_mask entries are mapped to the same value, this could enable unintended driver logging. If enabling DP_TX logs was the intention, then this could also enable PCI logs flooding the dmesg buffer or vice versa. Fix this by correctly assigning the debug masks.
Found during code review.
Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
--- drivers/net/wireless/ath/ath11k/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath11k/debug.h +2 -2
@@ -23,8 +23,8 @@ enum ath11k_debug_mask {ATH11K_DBG_TESTMODE =0x00000400 , ATH11k_DBG_HAL =0x00000800 ,ATH11K_DBG_PCI =0x00001000 , -ATH11K_DBG_DP_TX =0x00001000 , -ATH11K_DBG_DP_RX =0x00002000 , +ATH11K_DBG_DP_TX =0x00002000 , +ATH11K_DBG_DP_RX =0x00004000 , ATH11K_DBG_ANY = 0xffffffff, };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 335/1157 ath11k: Avoid REO CMD failed prints during firmware recovery
In reply to Greg Kroah-HartmanFrom: Manikanta Pubbisetty <[email protected]>
[ Upstream commit 0ab52b2bd7be8fd49c8ade7703c1faa15359c6c5 ]
Currently when firmware recovery is in progress, we do not queue REO commands to the firmware, instead -ESHUTDOWN will be returned to the caller leading to a failure print on the console. The REO command in the problem scenario is sent for all tids of a peer in which case we will have 16 failure prints on the console for a single peer. For an AP usecase, this count would be even higher in a worst case scenario. Since these commands are bound to fail during firmware recovery, it is better to avoid printing these failures and thereby avoid message flooding on the console.
Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
--- drivers/net/wireless/ath/ath11k/dp_rx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath11k/dp_rx.c +3 -2
@@ -835,8 +835,9 @@ void ath11k_peer_rx_tid_delete(struct ath11k *ar,HAL_REO_CMD_UPDATE_RX_QUEUE , &cmd, ath11k_dp_rx_tid_del_func);if (ret) { -ath11k_err (ar->ab,"failed to send HAL_REO_CMD_UPDATE_RX_QUEUE cmd, tid %d (%d)\n" , - tid, ret); +if (ret != -ESHUTDOWN ) +ath11k_err (ar->ab,"failed to send HAL_REO_CMD_UPDATE_RX_QUEUE cmd, tid %d (%d)\n" , + tid, ret);dma_unmap_single (ar->ab->dev, rx_tid->paddr, rx_tid->size,DMA_BIDIRECTIONAL );kfree (rx_tid->vaddr);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 336/1157 drm/radeon: fix potential buffer overflow in ni_set_mc_special_registers()
In reply to Greg Kroah-HartmanFrom: Alexey Kodanev <[email protected]>
[ Upstream commit 136f614931a2bb73616b292cf542da3a18daefd5 ]
The last case label can write two buffers 'mc_reg_address[j]' and 'mc_data[j]' with 'j' offset equal to SMC_NISLANDS_MC_REGISTER_ARRAY_SIZE since there are no checks for this value in both case labels after the last 'j++'.
Instead of changing '>' to '>=' there, add the bounds check at the start of the second 'case' (the first one already has it).
Also, remove redundant last checks for 'j' index bigger than array size. The expression is always false. Moreover, before or after the patch 'table->last' can be equal to SMC_NISLANDS_MC_REGISTER_ARRAY_SIZE and it seems it can be a valid value.
Detected using the static analysis tool - Svace.
--- drivers/gpu/drm/radeon/ni_dpm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/radeon/ni_dpm.c +2 -4
@@ -2741,10 +2741,10 @@ static int ni_set_mc_special_registers(struct radeon_device *rdev, table->mc_reg_table_entry[k].mc_data[j] |=0x100 ; } j++; -if (j >SMC_NISLANDS_MC_REGISTER_ARRAY_SIZE ) -return -EINVAL ;break ;case MC_SEQ_RESERVE_M >>2 : +if (j >=SMC_NISLANDS_MC_REGISTER_ARRAY_SIZE ) +return -EINVAL ; temp_reg =RREG32 (MC_PMG_CMD_MRS1 ); table->mc_reg_address[j].s1 =MC_PMG_CMD_MRS1 >>2 ; table->mc_reg_address[j].s0 =MC_SEQ_PMG_CMD_MRS1_LP >>2 ;
@@ -2753,8 +2753,6 @@ static int ni_set_mc_special_registers(struct radeon_device *rdev, (temp_reg &0xffff0000 ) | (table->mc_reg_table_entry[k].mc_data[i] &0x0000ffff ); j++; -if (j >SMC_NISLANDS_MC_REGISTER_ARRAY_SIZE ) -return -EINVAL ;break ;default :break ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 337/1157 drm/mediatek: Modify dsi funcs to atomic operations
In reply to Greg Kroah-HartmanFrom: Xinlei Lee <[email protected]>
[ Upstream commit 7f6335c6a258edf4d5ff1b904bc033188dc7b48b ]
Because .enable & .disable are deprecated. Use .atomic_enable & .atomic_disable instead.
--- drivers/gpu/drm/mediatek/mtk_dsi.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/gpu/drm/mediatek/mtk_dsi.c +6 -4
@@ -763,14 +763,16 @@ static void mtk_dsi_bridge_mode_set(struct drm_bridge *bridge,drm_display_mode_to_videomode (adjusted, &dsi->vm); } -static void mtk_dsi_bridge_disable (struct drm_bridge *bridge) +static void mtk_dsi_bridge_atomic_disable (struct drm_bridge *bridge, +struct drm_bridge_state *old_bridge_state) {struct mtk_dsi *dsi =bridge_to_dsi (bridge);mtk_output_dsi_disable (dsi); } -static void mtk_dsi_bridge_enable (struct drm_bridge *bridge) +static void mtk_dsi_bridge_atomic_enable (struct drm_bridge *bridge, +struct drm_bridge_state *old_bridge_state) {struct mtk_dsi *dsi =bridge_to_dsi (bridge);
@@ -779,8 +781,8 @@ static void mtk_dsi_bridge_enable(struct drm_bridge *bridge)static const struct drm_bridge_funcs mtk_dsi_bridge_funcs = { .attach = mtk_dsi_bridge_attach, - .disable = mtk_dsi_bridge_disable, - .enable = mtk_dsi_bridge_enable, + .atomic_disable = mtk_dsi_bridge_atomic_disable, + .atomic_enable = mtk_dsi_bridge_atomic_enable, .mode_set = mtk_dsi_bridge_mode_set, };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 338/1157 drm/mediatek: Separate poweron/poweroff from enable/disable and define new funcs
In reply to Greg Kroah-HartmanFrom: Jitao Shi <[email protected]>
[ Upstream commit cde7e2e35c2866d22a3a012e72a41052dfcc255d ]
In order to match the changes of "Use the drm_panel_bridge API", the poweron/poweroff of dsi is extracted from enable/disable and defined as new funcs (atomic_pre_enable/atomic_post_disable).
Since dsi_poweron is moved from dsi_enable to pre_enable function, in order to avoid poweron failure, the operation of dsi register fails to cause bus hang. Therefore, the protection mechanism is added to the dsi_enable function.
--- drivers/gpu/drm/mediatek/mtk_dsi.c | 53 +++++++++++++++++++----------- 1 file changed, 34 insertions(+), 19 deletions(-)
drivers/gpu/drm/mediatek/mtk_dsi.c +34 -19
@@ -691,16 +691,6 @@ static void mtk_dsi_poweroff(struct mtk_dsi *dsi)if (--dsi->refcount !=0 )return ; -/* -* mtk_dsi_stop() and mtk_dsi_start() is asymmetric, since -* mtk_dsi_stop() should be called after mtk_drm_crtc_atomic_disable(), -* which needs irq for vblank, and mtk_dsi_stop() will disable irq. -* mtk_dsi_start() needs to be called in mtk_output_dsi_enable(), -* after dsi is fully set. -*/ -mtk_dsi_stop (dsi); - -mtk_dsi_switch_to_cmd_mode (dsi,VM_DONE_INT_FLAG ,500 );mtk_dsi_reset_engine (dsi);mtk_dsi_lane0_ulp_mode_enter (dsi);mtk_dsi_clk_ulp_mode_enter (dsi);
@@ -715,17 +705,9 @@ static void mtk_dsi_poweroff(struct mtk_dsi *dsi)static void mtk_output_dsi_enable (struct mtk_dsi *dsi) { -int ret; -if (dsi->enabled)return ; - ret =mtk_dsi_poweron (dsi); -if (ret <0 ) { -DRM_ERROR ("failed to power on dsi\n" ); -return ; - } -mtk_dsi_set_mode (dsi);mtk_dsi_clk_hs_mode (dsi,1 );
@@ -739,7 +721,16 @@ static void mtk_output_dsi_disable(struct mtk_dsi *dsi)if (!dsi->enabled)return ; -mtk_dsi_poweroff (dsi); +/* +* mtk_dsi_stop() and mtk_dsi_start() is asymmetric, since +* mtk_dsi_stop() should be called after mtk_drm_crtc_atomic_disable(), +* which needs irq for vblank, and mtk_dsi_stop() will disable irq. +* mtk_dsi_start() needs to be called in mtk_output_dsi_enable(), +* after dsi is fully set. +*/ +mtk_dsi_stop (dsi); + +mtk_dsi_switch_to_cmd_mode (dsi,VM_DONE_INT_FLAG ,500 ); dsi->enabled = false; }
@@ -776,13 +767,37 @@ static void mtk_dsi_bridge_atomic_enable(struct drm_bridge *bridge, {struct mtk_dsi *dsi =bridge_to_dsi (bridge); +if (dsi->refcount ==0 ) +return ; +mtk_output_dsi_enable (dsi); } +static void mtk_dsi_bridge_atomic_pre_enable (struct drm_bridge *bridge, +struct drm_bridge_state *old_bridge_state) +{ +struct mtk_dsi *dsi =bridge_to_dsi (bridge); +int ret; + + ret =mtk_dsi_poweron (dsi); +if (ret <0 ) +DRM_ERROR ("failed to power on dsi\n" ); +} + +static void mtk_dsi_bridge_atomic_post_disable (struct drm_bridge *bridge, +struct drm_bridge_state *old_bridge_state) +{ +struct mtk_dsi *dsi =bridge_to_dsi (bridge); + +mtk_dsi_poweroff (dsi); +} +static const struct drm_bridge_funcs mtk_dsi_bridge_funcs = { .attach = mtk_dsi_bridge_attach, .atomic_disable = mtk_dsi_bridge_atomic_disable, .atomic_enable = mtk_dsi_bridge_atomic_enable, + .atomic_pre_enable = mtk_dsi_bridge_atomic_pre_enable, + .atomic_post_disable = mtk_dsi_bridge_atomic_post_disable, .mode_set = mtk_dsi_bridge_mode_set, };
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 339/1157 drm/mediatek: Add pull-down MIPI operation in mtk_dsi_poweroff function
In reply to Greg Kroah-HartmanFrom: Xinlei Lee <[email protected]>
[ Upstream commit fa5d0a0205c34734c5b8daa77e39ac2817f63a10 ]
In the dsi_enable function, mtk_dsi_rxtx_control is to pull up the MIPI signal operation. Before dsi_disable, MIPI should also be pulled down by writing a register instead of disabling dsi.
If disable dsi without pulling the mipi signal low, the value of the register will still maintain the setting of the mipi signal being pulled high.
After resume, even if the mipi signal is not pulled high, it will still be in the high state.
--- drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/mediatek/mtk_dsi.c +2 -0
@@ -694,6 +694,8 @@ static void mtk_dsi_poweroff(struct mtk_dsi *dsi)mtk_dsi_reset_engine (dsi);mtk_dsi_lane0_ulp_mode_enter (dsi);mtk_dsi_clk_ulp_mode_enter (dsi); +/* set the lane number as 0 to pull down mipi */ +writel (0 , dsi->regs +DSI_TXRX_CTRL );mtk_dsi_disable (dsi);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 340/1157 drm/meson: encoder_cvbs: Fix refcount leak in meson_encoder_cvbs_init
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit 7d255ddbbf679aa47e041cbf68520fd985ed2279 ]
of_graph_get_remote_node() returns remote device nodepointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak.
--- drivers/gpu/drm/meson/meson_encoder_cvbs.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/meson/meson_encoder_cvbs.c +1 -0
@@ -238,6 +238,7 @@ int meson_encoder_cvbs_init(struct meson_drm *priv) } meson_encoder_cvbs->next_bridge =of_drm_find_bridge (remote); +of_node_put (remote);if (!meson_encoder_cvbs->next_bridge) {dev_err (priv->dev,"Failed to find CVBS Connector bridge\n" );return -EPROBE_DEFER ;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 341/1157 drm/meson: encoder_hdmi: Fix refcount leak in meson_encoder_hdmi_init
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit d82a5a4aae9d0203234737caed1bf470aa317568 ]
of_graph_get_remote_node() returns remote device nodepointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak.
--- drivers/gpu/drm/meson/meson_encoder_hdmi.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
drivers/gpu/drm/meson/meson_encoder_hdmi.c +11 -4
@@ -365,7 +365,8 @@ int meson_encoder_hdmi_init(struct meson_drm *priv) meson_encoder_hdmi->next_bridge =of_drm_find_bridge (remote);if (!meson_encoder_hdmi->next_bridge) {dev_err (priv->dev,"Failed to find HDMI transceiver bridge\n" ); -return -EPROBE_DEFER ; + ret = -EPROBE_DEFER ; + goto err_put_node; }/* HDMI Encoder Bridge */
@@ -383,7 +384,7 @@ int meson_encoder_hdmi_init(struct meson_drm *priv) DRM_MODE_ENCODER_TMDS);if (ret) {dev_err (priv->dev,"Failed to init HDMI encoder: %d\n" , ret); -return ret; + goto err_put_node; } meson_encoder_hdmi->encoder.possible_crtcs =BIT (0 );
@@ -393,7 +394,7 @@ int meson_encoder_hdmi_init(struct meson_drm *priv) DRM_BRIDGE_ATTACH_NO_CONNECTOR);if (ret) {dev_err (priv->dev,"Failed to attach bridge: %d\n" , ret); -return ret; + goto err_put_node; }/* Initialize & attach Bridge Connector */
@@ -401,7 +402,8 @@ int meson_encoder_hdmi_init(struct meson_drm *priv) &meson_encoder_hdmi->encoder);if (IS_ERR (meson_encoder_hdmi->connector)) {dev_err (priv->dev,"Unable to create HDMI bridge connector\n" ); -return PTR_ERR (meson_encoder_hdmi->connector); + ret =PTR_ERR (meson_encoder_hdmi->connector); + goto err_put_node; }drm_connector_attach_encoder (meson_encoder_hdmi->connector, &meson_encoder_hdmi->encoder);
@@ -428,6 +430,7 @@ int meson_encoder_hdmi_init(struct meson_drm *priv) meson_encoder_hdmi->connector->ycbcr_420_allowed = true; pdev =of_find_device_by_node (remote); +of_node_put (remote);if (pdev) {struct cec_connector_info conn_info;struct cec_notifier *notifier;
@@ -446,4 +449,8 @@ int meson_encoder_hdmi_init(struct meson_drm *priv)dev_dbg (priv->dev,"HDMI encoder initialized\n" );return 0 ; + +err_put_node: +of_node_put (remote); +return ret; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 342/1157 drm/bridge: lt9611uxc: Cancel only drivers work
In reply to Greg Kroah-HartmanFrom: Bjorn Andersson <[email protected]>
[ Upstream commit dfa687bffc8a4a21ed929c7dececf01b8f1f52ee ]
During device remove care needs to be taken that no work is pending before it removes the underlying DRM bridge etc, but this can be done on the specific work rather than waiting for the flush of the system-wide workqueue.
--- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/lontium-lt9611uxc.c +1 -1
@@ -982,7 +982,7 @@ static int lt9611uxc_remove(struct i2c_client *client)struct lt9611uxc *lt9611uxc =i2c_get_clientdata (client);disable_irq (client->irq); -flush_scheduled_work (); +cancel_work_sync (<9611uxc->work);lt9611uxc_audio_exit (lt9611uxc);drm_bridge_remove (<9611uxc->bridge);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 343/1157 drm/amdgpu: fix scratch register access method in SRIOV
In reply to Greg Kroah-HartmanFrom: ZhenGuo Yin <[email protected]>
[ Upstream commit 851dd8625320fb626b6ab6399b2402fd84abcdfb ]
The scratch register should be accessed through MMIO instead of RLCG in SRIOV, since it being used in RLCG register access function.
--- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +4 -3
@@ -3780,11 +3780,12 @@ static void gfx_v10_0_wait_reg_mem(struct amdgpu_ring *ring, int eng_sel,static int gfx_v10_0_ring_test_ring (struct amdgpu_ring *ring) {struct amdgpu_device *adev = ring->adev; +uint32_t scratch =SOC15_REG_OFFSET (GC ,0 , mmSCRATCH_REG0);uint32_t tmp =0 ;unsigned i;int r; -WREG32_SOC15 (GC ,0 , mmSCRATCH_REG0,0xCAFEDEAD ); +WREG32 (scratch,0xCAFEDEAD ); r =amdgpu_ring_alloc (ring,3 );if (r) { DRM_ERROR("amdgpu: cp failed to lock ring %d (%d).\n",
@@ -3793,13 +3794,13 @@ static int gfx_v10_0_ring_test_ring(struct amdgpu_ring *ring) }amdgpu_ring_write (ring,PACKET3 (PACKET3_SET_UCONFIG_REG ,1 )); -amdgpu_ring_write (ring,SOC15_REG_OFFSET (GC ,0 , mmSCRATCH_REG0) - +amdgpu_ring_write (ring, scratch -PACKET3_SET_UCONFIG_REG_START );amdgpu_ring_write (ring,0xDEADBEEF );amdgpu_ring_commit (ring);for (i =0 ; i < adev->usec_timeout; i++) { - tmp =RREG32_SOC15 (GC ,0 , mmSCRATCH_REG0); + tmp =RREG32 (scratch);if (tmp ==0xDEADBEEF )break ;if (amdgpu_emu_mode ==1 )
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 344/1157 drm/amdgpu/display: Prepare for new interfaces
In reply to Greg Kroah-HartmanFrom: Leung, Martin <[email protected]>
[ Upstream commit a820190204aef0739aa3a067d00273d117f9367c ]
why:
lut pipeline will be hooked up differently in some asics need to add new interfaces
how:
add them
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 + drivers/gpu/drm/amd/display/dc/core/dc_link.c | 17 +++++- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 52 +++++++++++-------- drivers/gpu/drm/amd/display/dc/dc.h | 1 + .../display/dc/dce110/dce110_hw_sequencer.c | 23 ++++++-- .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.c | 13 +++-- .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.h | 2 +- drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h | 4 +- drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h | 5 ++ .../amd/display/dc/inc/hw_sequencer_private.h | 2 + 10 files changed, 83 insertions(+), 38 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -0
@@ -1563,6 +1563,8 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)DRM_INFO ("Seamless boot condition check passed\n" ); } + init_data.flags.enable_mipi_converter_optimization = true; +INIT_LIST_HEAD (&adev->dm.da_list);retrieve_dmi_info (&adev->dm);
drivers/gpu/drm/amd/display/dc/core/dc_link.c +15 -2
@@ -235,7 +235,8 @@ bool dc_link_detect_sink(struct dc_link *link, enum dc_connection_type *type)if (link->connector_signal ==SIGNAL_TYPE_EDP ) {/*in case it is not on*/ - link->dc->hwss.edp_power_control (link, true); +if (!link->dc->config.edp_no_power_sequencing) + link->dc->hwss.edp_power_control (link, true); link->dc->hwss.edp_wait_for_hpd_ready (link, true); }
@@ -1016,6 +1017,7 @@ static bool detect_link_and_local_sink(struct dc_link *link,bool same_edid = false;enum dc_edid_status edid_status;struct dc_context *dc_ctx = link->ctx; +struct dc *dc = dc_ctx->dc;struct dc_sink *sink =NULL ;struct dc_sink *prev_sink =NULL ;struct dpcd_caps prev_dpcd_caps;
@@ -1095,6 +1097,16 @@ static bool detect_link_and_local_sink(struct dc_link *link,detect_edp_sink_caps (link);read_current_link_settings_on_detect (link); + +/* Disable power sequence on MIPI panel + converter +*/ +if (dc->config.enable_mipi_converter_optimization && + dc_ctx->dce_version ==DCN_VERSION_3_01 && + link->dpcd_caps.sink_dev_id ==DP_BRANCH_DEVICE_ID_0022B9 && +memcmp (&link->dpcd_caps.branch_dev_name,DP_SINK_BRANCH_DEV_NAME_7580 , +sizeof (link->dpcd_caps.branch_dev_name)) ==0 ) + dc->config.edp_no_power_sequencing = true; + sink_caps.transaction_type =DDC_TRANSACTION_TYPE_I2C_OVER_AUX ; sink_caps.signal =SIGNAL_TYPE_EDP ;break ;
@@ -1993,7 +2005,8 @@ static enum dc_status enable_link_dp(struct dc_state *state,if (pipe_ctx->stream->signal ==SIGNAL_TYPE_EDP ) {/*in case it is not on*/ - link->dc->hwss.edp_power_control (link, true); +if (!link->dc->config.edp_no_power_sequencing) + link->dc->hwss.edp_power_control (link, true); link->dc->hwss.edp_wait_for_hpd_ready (link, true); }
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +31 -21
129 lines not on this page · raw message
drivers/gpu/drm/amd/display/dc/dc.h +1 -0
@@ -337,6 +337,7 @@ struct dc_config {bool is_single_rank_dimm;bool use_pipe_ctx_sync_logic;bool ignore_dpref_ss; +bool enable_mipi_converter_optimization; };enum visual_confirm {
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +18 -5
@@ -1245,8 +1245,18 @@ void dce110_blank_stream(struct pipe_ctx *pipe_ctx)* has changed or they enter protection state and hang. */ msleep (60 ); - }else if (pipe_ctx->stream->signal ==SIGNAL_TYPE_EDP ) -edp_receiver_ready_T9 (link); + }else if (pipe_ctx->stream->signal ==SIGNAL_TYPE_EDP ) { +if (!link->dc->config.edp_no_power_sequencing) { +/* +* Sometimes, DP receiver chip power-controlled externally by an +* Embedded Controller could be treated and used as eDP, +* if it drives mobile display. In this case, +* we shouldn't be doing power-sequencing, hence we can skip +* waiting for T9-ready. +*/ +edp_receiver_ready_T9 (link); + } + } } }
@@ -2161,15 +2171,18 @@ static void dce110_setup_audio_dto(build_audio_output (context, pipe_ctx, &audio_output);if (dc->res_pool->dccg && dc->res_pool->dccg->funcs->set_audio_dtbclk_dto) { -/* disable audio DTBCLK DTO */ - dc->res_pool->dccg->funcs->set_audio_dtbclk_dto ( - dc->res_pool->dccg,0 ); +struct dtbclk_dto_params dto_params = {0 }; pipe_ctx->stream_res.audio->funcs->wall_dto_setup ( pipe_ctx->stream_res.audio, pipe_ctx->stream->signal, &audio_output.crtc_info, &audio_output.pll_info); + + dc->res_pool->dccg->funcs->set_audio_dtbclk_dto ( + dc->res_pool->dccg, + &dto_params); + }else pipe_ctx->stream_res.audio->funcs->wall_dto_setup( pipe_ctx->stream_res.audio,
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_dccg.c +6 -7
@@ -513,7 +513,7 @@ void dccg31_set_physymclk(/* Controls the generation of pixel valid for OTG in (OTG -> HPO case) */ static void dccg31_set_dtbclk_dto (struct dccg *dccg, -struct dtbclk_dto_params *params) +const struct dtbclk_dto_params *params) {struct dcn_dccg *dccg_dcn =TO_DCN_DCCG (dccg);int req_dtbclk_khz = params->pixclk_khz;
@@ -579,18 +579,17 @@ static void dccg31_set_dtbclk_dto(void dccg31_set_audio_dtbclk_dto (struct dccg *dccg, -uint32_t req_audio_dtbclk_khz) +const struct dtbclk_dto_params *params) {struct dcn_dccg *dccg_dcn =TO_DCN_DCCG (dccg); -if (dccg->ref_dtbclk_khz && req_audio_dtbclk_khz) { +if (params->ref_dtbclk_khz && params->req_audio_dtbclk_khz) {uint32_t modulo, phase;// phase / modulo = dtbclk / dtbclk ref - modulo = dccg->ref_dtbclk_khz *1000 ; - phase =div_u64 ((((unsigned long long )modulo * req_audio_dtbclk_khz) + dccg->ref_dtbclk_khz -1 ), - dccg->ref_dtbclk_khz); - + modulo = params->ref_dtbclk_khz *1000 ; + phase =div_u64 ((((unsigned long long )modulo * params->req_audio_dtbclk_khz) + params->ref_dtbclk_khz -1 ), + params->ref_dtbclk_khz);REG_WRITE (DCCG_AUDIO_DTBCLK_DTO_MODULO , modulo);REG_WRITE (DCCG_AUDIO_DTBCLK_DTO_PHASE , phase);
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_dccg.h +1 -1
@@ -192,7 +192,7 @@ void dccg31_set_physymclk(void dccg31_set_audio_dtbclk_dto (struct dccg *dccg, -uint32_t req_audio_dtbclk_khz); +const struct dtbclk_dto_params *params); void dccg31_set_hdmistreamclk( struct dccg *dccg,
drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h +2 -2
@@ -120,11 +120,11 @@ struct dccg_funcs {void (*set_dtbclk_dto)(struct dccg *dccg, -struct dtbclk_dto_params *dto_params); +const struct dtbclk_dto_params *params);void (*set_audio_dtbclk_dto)(struct dccg *dccg, -uint32_t req_audio_dtbclk_khz); +const struct dtbclk_dto_params *params); void (*set_dispclk_change_mode)( struct dccg *dccg,
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h +5 -0
@@ -346,6 +346,11 @@ struct mpc_funcs {int mpcc_id, const struct mpc_grph_gamut_adjustment *adjust); +bool (*program_1dlut)( +struct mpc *mpc, +const struct pwl_params *params, +uint32_t rmu_idx); + bool (*program_shaper)( struct mpc *mpc, const struct pwl_params *params,
drivers/gpu/drm/amd/display/dc/inc/hw_sequencer_private.h +2 -0
@@ -140,6 +140,8 @@ struct hwseq_private_funcs { const struct dc_plane_state *plane_state);bool (*set_shaper_3dlut)(struct pipe_ctx *pipe_ctx,const struct dc_plane_state *plane_state); +bool (*set_mcm_luts)(struct pipe_ctx *pipe_ctx, +const struct dc_plane_state *plane_state);void (*PLAT_58856_wa)(struct dc_state *context,struct pipe_ctx *pipe_ctx);void (*setup_hpo_hw_control)(const struct dce_hwseq *hws,bool enable);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 345/1157 i2c: npcm: Remove own slave addresses 2:10
In reply to Greg Kroah-HartmanFrom: Tali Perry <[email protected]>
[ Upstream commit 47d506d1a28fd10a9fb1f33df5622d88fae72095 ]
NPCM can support up to 10 own slave addresses. In practice, only one address is actually being used. In order to access addresses 2 and above, need to switch register banks. The switch needs spinlock.
To avoid using spinlock for this useless feature removed support of SA >=
2. Also fix returned slave event enum.
Remove some comment since the bank selection is not required. The bank selection is not required since the supported slave addresses are reduced.
--- drivers/i2c/busses/i2c-npcm7xx.c | 41 +++++++++++++------------------- 1 file changed, 16 insertions(+), 25 deletions(-)
drivers/i2c/busses/i2c-npcm7xx.c +16 -25
@@ -123,11 +123,11 @@ enum i2c_addr {* Since the addr regs are sprinkled all over the address space, * use this array to get the address or each register. */ -#define I2C_NUM_OWN_ADDR 10 +#define I2C_NUM_OWN_ADDR 2 +#define I2C_NUM_OWN_ADDR_SUPPORTED 2 +static const int npcm_i2caddr[I2C_NUM_OWN_ADDR ] = { -NPCM_I2CADDR1 ,NPCM_I2CADDR2 ,NPCM_I2CADDR3 ,NPCM_I2CADDR4 , -NPCM_I2CADDR5 ,NPCM_I2CADDR6 ,NPCM_I2CADDR7 ,NPCM_I2CADDR8 , -NPCM_I2CADDR9 ,NPCM_I2CADDR10 , +NPCM_I2CADDR1 ,NPCM_I2CADDR2 , };#endif
@@ -392,14 +392,10 @@ static void npcm_i2c_disable(struct npcm_i2c *bus)#if IS_ENABLED (CONFIG_I2C_SLAVE )int i; -/* select bank 0 for I2C addresses */ -npcm_i2c_select_bank (bus,I2C_BANK_0 ); -/* Slave addresses removal */ -for (i =I2C_SLAVE_ADDR1 ; i <I2C_NUM_OWN_ADDR ; i++) +for (i =I2C_SLAVE_ADDR1 ; i <I2C_NUM_OWN_ADDR_SUPPORTED ; i++)iowrite8 (0 , bus->reg + npcm_i2caddr[i]); -npcm_i2c_select_bank (bus,I2C_BANK_1 );#endif /* Disable module */ i2cctl2 =ioread8 (bus->reg +NPCM_I2CCTL2 );
@@ -604,8 +600,7 @@ static int npcm_i2c_slave_enable(struct npcm_i2c *bus, enum i2c_addr addr_type, i2cctl1 &= ~NPCM_I2CCTL1_GCMEN ;iowrite8 (i2cctl1, bus->reg +NPCM_I2CCTL1 );return 0 ; - } -if (addr_type ==I2C_ARP_ADDR ) { + }else if (addr_type ==I2C_ARP_ADDR ) { i2cctl3 =ioread8 (bus->reg +NPCM_I2CCTL3 );if (enable) i2cctl3 |=I2CCTL3_ARPMEN ;
@@ -614,16 +609,16 @@ static int npcm_i2c_slave_enable(struct npcm_i2c *bus, enum i2c_addr addr_type,iowrite8 (i2cctl3, bus->reg +NPCM_I2CCTL3 ); return 0; } +if (addr_type >I2C_SLAVE_ADDR2 && addr_type <=I2C_SLAVE_ADDR10 ) +dev_err (bus->dev,"try to enable more than 2 SA not supported\n" ); +if (addr_type >=I2C_ARP_ADDR )return -EFAULT ; -/* select bank 0 for address 3 to 10 */ -if (addr_type >I2C_SLAVE_ADDR2 ) -npcm_i2c_select_bank (bus,I2C_BANK_0 ); +/* Set and enable the address */ iowrite8 (sa_reg, bus->reg + npcm_i2caddr[addr_type]);npcm_i2c_slave_int_enable (bus, enable); -if (addr_type >I2C_SLAVE_ADDR2 ) -npcm_i2c_select_bank (bus,I2C_BANK_1 ); +return 0 ; }#endif
@@ -846,15 +841,11 @@ static u8 npcm_i2c_get_slave_addr(struct npcm_i2c *bus, enum i2c_addr addr_type) {u8 slave_add; -/* select bank 0 for address 3 to 10 */ -if (addr_type >I2C_SLAVE_ADDR2 ) -npcm_i2c_select_bank (bus,I2C_BANK_0 ); +if (addr_type >I2C_SLAVE_ADDR2 && addr_type <=I2C_SLAVE_ADDR10 ) +dev_err (bus->dev,"get slave: try to use more than 2 SA not supported\n" ); slave_add =ioread8 (bus->reg + npcm_i2caddr[(int )addr_type]); -if (addr_type >I2C_SLAVE_ADDR2 ) -npcm_i2c_select_bank (bus,I2C_BANK_1 ); -return slave_add; }
@@ -864,12 +855,12 @@ static int npcm_i2c_remove_slave_addr(struct npcm_i2c *bus, u8 slave_add)/* Set the enable bit */ slave_add |=0x80 ; -npcm_i2c_select_bank (bus,I2C_BANK_0 ); -for (i =I2C_SLAVE_ADDR1 ; i <I2C_NUM_OWN_ADDR ; i++) { + +for (i =I2C_SLAVE_ADDR1 ; i <I2C_NUM_OWN_ADDR_SUPPORTED ; i++) {if (ioread8 (bus->reg + npcm_i2caddr[i]) == slave_add)iowrite8 (0 , bus->reg + npcm_i2caddr[i]); } -npcm_i2c_select_bank (bus,I2C_BANK_1 ); +return 0 ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 346/1157 i2c: npcm: Correct slave role behavior
In reply to Greg Kroah-HartmanFrom: Tali Perry <[email protected]>
[ Upstream commit d7aa1b149b8fc04d802879cf4662010aa4a42deb ]
Correct the slave transaction logic to be compatible with the generic slave backend driver.
--- drivers/i2c/busses/i2c-npcm7xx.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-npcm7xx.c +6 -3
@@ -915,11 +915,15 @@ static int npcm_i2c_slave_get_wr_buf(struct npcm_i2c *bus)for (i =0 ; i <I2C_HW_FIFO_SIZE ; i++) {if (bus->slv_wr_size >=I2C_HW_FIFO_SIZE )break ; -i2c_slave_event (bus->slave,I2C_SLAVE_READ_REQUESTED , &value); +if (bus->state ==I2C_SLAVE_MATCH ) { +i2c_slave_event (bus->slave,I2C_SLAVE_READ_REQUESTED , &value); + bus->state =I2C_OPER_STARTED ; + }else { +i2c_slave_event (bus->slave,I2C_SLAVE_READ_PROCESSED , &value); + } ind = (bus->slv_wr_ind + bus->slv_wr_size) %I2C_HW_FIFO_SIZE ; bus->slv_wr_buf[ind] = value; bus->slv_wr_size++; -i2c_slave_event (bus->slave,I2C_SLAVE_READ_PROCESSED , &value); }return I2C_HW_FIFO_SIZE - ret; }
@@ -967,7 +971,6 @@ static void npcm_i2c_slave_xmit(struct npcm_i2c *bus, u16 nwrite,if (nwrite ==0 )return ; - bus->state =I2C_OPER_STARTED ; bus->operation =I2C_WRITE_OPER ;/* get the next buffer */
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 347/1157 i2c: mxs: Silence a clang warning
In reply to Greg Kroah-HartmanFrom: Fabio Estevam <[email protected]>
[ Upstream commit 3d43273d7d1e1a5374d531e901d3c537b4c97bbf ]
Change the of_device_get_match_data() cast to (uintptr_t) to silence the following clang warning:
drivers/i2c/busses/i2c-mxs.c:802:18: warning: cast to smaller integer type 'enum mxs_i2c_devtype' from 'const void *' [-Wvoid-pointer-to-enum-cast]
--- drivers/i2c/busses/i2c-mxs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-mxs.c +1 -1
@@ -799,7 +799,7 @@ static int mxs_i2c_probe(struct platform_device *pdev)if (!i2c)return -ENOMEM ; - i2c->dev_type = (enum mxs_i2c_devtype )of_device_get_match_data (&pdev->dev); + i2c->dev_type = (uintptr_t )of_device_get_match_data (&pdev->dev); i2c->regs =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (i2c->regs))
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 348/1157 virtio-gpu: fix a missing check to avoid NULL dereference
In reply to Greg Kroah-HartmanFrom: Xiaomeng Tong <[email protected]>
[ Upstream commit bd63f11f4c3c46afec07d821f74736161ff6e526 ]
'cache_ent' could be set NULL inside virtio_gpu_cmd_get_capset() and it will lead to a NULL dereference by a lately use of it (i.e., ptr = cache_ent->caps_cache). Fix it with a NULL check.
[ kraxel: minor codestyle fixup ]
--- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/virtio/virtgpu_ioctl.c +4 -2
@@ -580,8 +580,10 @@ static int virtio_gpu_get_caps_ioctl(struct drm_device *dev,spin_unlock (&vgdev->display_info_lock);/* not in cache - need to talk to hw */ -virtio_gpu_cmd_get_capset (vgdev, found_valid, args->cap_set_ver, - &cache_ent); + ret =virtio_gpu_cmd_get_capset (vgdev, found_valid, args->cap_set_ver, + &cache_ent); +if (ret) +return ret;virtio_gpu_notify (vgdev); copy_exit:
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 349/1157 drm/virtio: Fix NULL vs IS_ERR checking in virtio_gpu_object_shmem_init
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit c24968734abfed81c8f93dc5f44a7b7a9aecadfa ]
Since drm_prime_pages_to_sg() function return error pointers. The drm_gem_shmem_get_sg_table() function returns error pointers too. Using IS_ERR() to check the return value to fix this.
--- drivers/gpu/drm/virtio/virtgpu_object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/virtio/virtgpu_object.c +2 -2
@@ -168,9 +168,9 @@ static int virtio_gpu_object_shmem_init(struct virtio_gpu_device *vgdev,* since virtio_gpu doesn't support dma-buf import from other devices. */ shmem->pages =drm_gem_shmem_get_sg_table (&bo->base); -if (!shmem->pages) { +if (IS_ERR (shmem->pages)) {drm_gem_shmem_unpin (&bo->base); -return -EINVAL ; +return PTR_ERR (shmem->pages); }if (use_dma_api) {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 350/1157 libbpf: Fix uprobe symbol file offset calculation logic
In reply to Greg Kroah-HartmanFrom: Andrii Nakryiko <[email protected]>
[ Upstream commit fe92833524e368e59bba9c57e00f7359f133667f ]
Fix libbpf's bpf_program__attach_uprobe() logic of determining function's *file offset* (which is what kernel is actually expecting) when attaching uprobe/uretprobe by function name. Previously calculation was determining virtual address offset relative to base load address, which (offset) is not always the same as file offset (though very frequently it is which is why this went unnoticed for a while).
--- tools/lib/bpf/libbpf.c | 63 +++++++++++++++--------------------------- 1 file changed, 22 insertions(+), 41 deletions(-)
tools/lib/bpf/libbpf.c +22 -41
@@ -10983,43 +10983,6 @@ static int perf_event_uprobe_open_legacy(const char *probe_name, bool retprobe,return pfd; } -/* uprobes deal in relative offsets; subtract the base address associated with -* the mapped binary. See Documentation/trace/uprobetracer.rst for more -* details. -*/ -static long elf_find_relative_offset (const char *filename,Elf *elf,long addr) -{ -size_t n; -int i; - -if (elf_getphdrnum (elf, &n)) { -pr_warn ("elf: failed to find program headers for '%s': %s\n" , filename, -elf_errmsg (-1 )); -return -ENOENT ; - } - -for (i =0 ; i < n; i++) { -int seg_start, seg_end, seg_offset; -GElf_Phdr phdr; - -if (!gelf_getphdr (elf, i, &phdr)) { -pr_warn ("elf: failed to get program header %d from '%s': %s\n" , i, filename, -elf_errmsg (-1 )); -return -ENOENT ; - } -if (phdr.p_type !=PT_LOAD || !(phdr.p_flags &PF_X )) -continue ; - - seg_start = phdr.p_vaddr; - seg_end = seg_start + phdr.p_memsz; - seg_offset = phdr.p_offset; -if (addr >= seg_start && addr < seg_end) -return addr - seg_start + seg_offset; - } -pr_warn ("elf: failed to find prog header containing 0x%lx in '%s'\n" , addr, filename); -return -ENOENT ; -} -/* Return next ELF section of sh_type after scn, or first of that type if scn is NULL. */ static Elf_Scn *elf_find_next_scn_by_type (Elf *elf,int sh_type,Elf_Scn *scn) {
@@ -11106,6 +11069,8 @@ static long elf_find_func_offset(const char *binary_path, const char *name)for (idx =0 ; idx < nr_syms; idx++) {int curr_bind;GElf_Sym sym; +Elf_Scn *sym_scn; +GElf_Shdr sym_sh;if (!gelf_getsym (symbols, idx, &sym))continue ;
@@ -11143,12 +11108,28 @@ static long elf_find_func_offset(const char *binary_path, const char *name)continue ; } } - ret = sym.st_value; + +/* Transform symbol's virtual address (absolute for +* binaries and relative for shared libs) into file +* offset, which is what kernel is expecting for +* uprobe/uretprobe attachment. +* See Documentation/trace/uprobetracer.rst for more +* details. +* This is done by looking up symbol's containing +* section's header and using it's virtual address +* (sh_addr) and corresponding file offset (sh_offset) +* to transform sym.st_value (virtual address) into +* desired final file offset. +*/ + sym_scn =elf_getscn (elf, sym.st_shndx); +if (!sym_scn) +continue ; +if (!gelf_getshdr (sym_scn, &sym_sh)) +continue ; + + ret = sym.st_value - sym_sh.sh_addr + sym_sh.sh_offset; last_bind = curr_bind; } -/* For binaries that are not shared libraries, we need relative offset */ -if (ret >0 && !is_shared_lib) - ret =elf_find_relative_offset (binary_path, elf, ret);if (ret >0 )break ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 351/1157 drm: adv7511: override i2c address of cec before accessing it
In reply to Greg Kroah-HartmanFrom: Antonio Borneo <[email protected]>
[ Upstream commit 9cc4853e4781bf0dd0f35355dc92d97c9da02f5d ]
Commit 680532c50bca ("drm: adv7511: Add support for i2c_new_secondary_device") allows a device tree node to override the default addresses of the secondary i2c devices. This is useful for solving address conflicts on the i2c bus.
In adv7511_init_cec_regmap() the new i2c address of cec device is read from device tree and immediately accessed, well before it is written in the proper register to override the default address. This can cause an i2c error during probe and a consequent probe failure.
Once the new i2c address is read from the device tree, override the default address before any attempt to access the cec.
Tested with adv7533 and stm32mp157f.
--- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +4 -3
@@ -1065,6 +1065,10 @@ static int adv7511_init_cec_regmap(struct adv7511 *adv) ADV7511_CEC_I2C_ADDR_DEFAULT);if (IS_ERR (adv->i2c_cec))return PTR_ERR (adv->i2c_cec); + +regmap_write (adv->regmap,ADV7511_REG_CEC_I2C_ADDR , + adv->i2c_cec->addr <<1 ); +i2c_set_clientdata (adv->i2c_cec, adv); adv->regmap_cec = devm_regmap_init_i2c(adv->i2c_cec,
@@ -1271,9 +1275,6 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)if (ret) goto err_i2c_unregister_packet; -regmap_write (adv7511->regmap,ADV7511_REG_CEC_I2C_ADDR , - adv7511->i2c_cec->addr <<1 ); -INIT_WORK (&adv7511->hpd_work, adv7511_hpd_work);if (i2c->irq) {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 352/1157 crypto: sun8i-ss - fix error codes in allocate_flows()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit d2765e1b9ac4b2d5a5d5bf17f468c9b3566c3770 ]
These failure paths should return -ENOMEM. Currently they return success.
--- .../crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c +12 -4
@@ -528,25 +528,33 @@ static int allocate_flows(struct sun8i_ss_dev *ss) ss->flows[i].biv =devm_kmalloc (ss->dev,AES_BLOCK_SIZE ,GFP_KERNEL |GFP_DMA ); -if (!ss->flows[i].biv) +if (!ss->flows[i].biv) { + err = -ENOMEM ; goto error_engine; + }for (j =0 ; j <MAX_SG ; j++) { ss->flows[i].iv[j] =devm_kmalloc (ss->dev,AES_BLOCK_SIZE ,GFP_KERNEL |GFP_DMA ); -if (!ss->flows[i].iv[j]) +if (!ss->flows[i].iv[j]) { + err = -ENOMEM ; goto error_engine; + } }/* the padding could be up to two block. */ ss->flows[i].pad =devm_kmalloc (ss->dev,MAX_PAD_SIZE ,GFP_KERNEL |GFP_DMA ); -if (!ss->flows[i].pad) +if (!ss->flows[i].pad) { + err = -ENOMEM ; goto error_engine; + } ss->flows[i].result =devm_kmalloc (ss->dev,SHA256_DIGEST_SIZE ,GFP_KERNEL |GFP_DMA ); -if (!ss->flows[i].result) +if (!ss->flows[i].result) { + err = -ENOMEM ; goto error_engine; + } ss->flows[i].engine =crypto_engine_alloc_init (ss->dev, true);if (!ss->flows[i].engine) {
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 353/1157 crypto: sun8i-ss - Fix error codes for dma_mapping_error()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit 6cb3f9b25c55928b95a02b9ed8e87ed653b3cce8 ]
If there is a dma_mapping_error() then return negative error codes. Currently this code returns success.
--- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c +4 -2
@@ -586,7 +586,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq) rctx->t_dst[k +1 ].len = rctx->t_dst[k].len; } addr_xpad =dma_map_single (ss->dev, tfmctx->ipad, bs,DMA_TO_DEVICE ); -if (dma_mapping_error (ss->dev, addr_xpad)) { + err =dma_mapping_error (ss->dev, addr_xpad); +if (err) {dev_err (ss->dev,"Fail to create DMA mapping of ipad\n" ); goto err_dma_xpad; }
@@ -612,7 +613,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq) goto err_dma_result; } addr_xpad =dma_map_single (ss->dev, tfmctx->opad, bs,DMA_TO_DEVICE ); -if (dma_mapping_error (ss->dev, addr_xpad)) { + err =dma_mapping_error (ss->dev, addr_xpad); +if (err) {dev_err (ss->dev,"Fail to create DMA mapping of opad\n" ); goto err_dma_xpad; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 354/1157 crypto: sun8i-ss - fix a NULL vs IS_ERR() check in sun8i_ss_hashkey
In reply to Greg Kroah-HartmanFrom: Peng Wu <[email protected]>
[ Upstream commit 7e8df1fc2d669d04c1f8a9e2d61d7afba1b43df4 ]
The crypto_alloc_shash() function never returns NULL. It returns error pointers.
--- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c +2 -2
@@ -30,8 +30,8 @@ static int sun8i_ss_hashkey(struct sun8i_ss_hash_tfm_ctx *tfmctx, const u8 *key,int ret =0 ; xtfm =crypto_alloc_shash ("sha1" ,0 ,CRYPTO_ALG_NEED_FALLBACK ); -if (!xtfm) -return -ENOMEM ; +if (IS_ERR (xtfm)) +return PTR_ERR (xtfm); len =sizeof (*sdesc) +crypto_shash_descsize (xtfm); sdesc =kmalloc (len,GFP_KERNEL );
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 355/1157 net: fix sk_wmem_schedule() and sk_rmem_schedule() errors
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit 7c80b038d23e1f4c7fcc311f43f83b8c60e7fb80 ]
If sk->sk_forward_alloc is 150000, and we need to schedule 150001 bytes, we want to allocate 1 byte more (rounded up to one page), instead of 150001 :/
--- include/net/sock.h | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
include/net/sock.h +8 -4
@@ -1552,19 +1552,23 @@ static inline bool sk_has_account(struct sock *sk)static inline bool sk_wmem_schedule (struct sock *sk,int size) { +int delta; +if (!sk_has_account (sk))return true; -return size <= sk->sk_forward_alloc || -__sk_mem_schedule (sk, size,SK_MEM_SEND ); + delta = size - sk->sk_forward_alloc; +return delta <=0 ||__sk_mem_schedule (sk, delta,SK_MEM_SEND ); }static inline bool sk_rmem_schedule (struct sock *sk,struct sk_buff *skb,int size) { +int delta; +if (!sk_has_account (sk))return true; -return size <= sk->sk_forward_alloc || -__sk_mem_schedule (sk, size,SK_MEM_RECV ) || + delta = size - sk->sk_forward_alloc; +return delta <=0 ||__sk_mem_schedule (sk, delta,SK_MEM_RECV ) ||skb_pfmemalloc (skb); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 356/1157 can: netlink: allow configuring of fixed bit rates without need for do_set_bittiming callback
In reply to Greg Kroah-HartmanFrom: Marc Kleine-Budde <[email protected]>
[ Upstream commit 7e193a42c37cf40eba8ac5af2d5e8eeb8b9506f9 ]
Usually CAN devices support configurable bit rates. The limits are defined by struct can_priv::bittiming_const. Another way is to implement the struct can_priv::do_set_bittiming callback.
If the bit rate is configured via netlink, the can_changelink() function checks that either can_priv::bittiming_const or struct can_priv::do_set_bittiming is implemented.
In commit 431af779256c ("can: dev: add CAN interface API for fixed bitrates") an API for configuring bit rates on CAN interfaces that only support fixed bit rates was added. The supported bit rates are defined by struct can_priv::bitrate_const.
However the above mentioned commit forgot to add the struct can_priv::bitrate_const to the check in can_changelink().
In order to avoid to implement a no-op can_priv::do_set_bittiming callback on devices with fixed bit rates, extend the check in can_changelink() accordingly.
--- drivers/net/can/dev/netlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/can/dev/netlink.c +2 -1
@@ -176,7 +176,8 @@ static int can_changelink(struct net_device *dev, struct nlattr *tb[],* directly via do_set_bitrate(). Bail out if neither * is given. */ -if (!priv->bittiming_const && !priv->do_set_bittiming) +if (!priv->bittiming_const && !priv->do_set_bittiming && + !priv->bitrate_const)return -EOPNOTSUPP ;memcpy (&bt,nla_data (data[IFLA_CAN_BITTIMING ]),sizeof (bt));
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 357/1157 drm/vkms: check plane_composer->map[0] before using it
In reply to Greg Kroah-HartmanFrom: Tales Lelo da Aparecida <[email protected]>
[ Upstream commit 24f6fe3226c6f9f1b8406311a96b59c6e650b707 ]
Fix a copypasta error. The caller of compose_plane() already checks primary_composer->map. In contrast, plane_composer->map is never verified here before handling.
--- drivers/gpu/drm/vkms/vkms_composer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vkms/vkms_composer.c +1 -1
@@ -157,7 +157,7 @@ static void compose_plane(struct vkms_composer *primary_composer,void *vaddr;void (*pixel_blend)(const u8 *p_src,u8 *p_dst); -if (WARN_ON (iosys_map_is_null (&primary_composer->map[0 ]))) +if (WARN_ON (iosys_map_is_null (&plane_composer->map[0 ])))return ; vaddr = plane_composer->map[0 ].vaddr;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 358/1157 can: netlink: allow configuring of fixed data bit rates without need for do_set_data_bittiming callback
In reply to Greg Kroah-HartmanFrom: Marc Kleine-Budde <[email protected]>
[ Upstream commit ec30c109391c5eac9b1d689a61e4bfed88148947 ]
This patch is similar to 7e193a42c37c ("can: netlink: allow configuring of fixed bit rates without need for do_set_bittiming callback") but for data bit rates instead of bit rates.
Usually CAN devices support configurable data bit rates. The limits are defined by struct can_priv::data_bittiming_const. Another way is to implement the struct can_priv::do_set_data_bittiming callback.
If the bit rate is configured via netlink, the can_changelink() function checks that either can_priv::data_bittiming_const or struct can_priv::do_set_data_bittiming is implemented.
In commit 431af779256c ("can: dev: add CAN interface API for fixed bitrates") an API for configuring bit rates on CAN interfaces that only support fixed bit rates was added. The supported bit rates are defined by struct can_priv::bitrate_const.
However the above mentioned commit forgot to add the struct can_priv::data_bitrate_const to the check in can_changelink().
In order to avoid to implement a no-op can_priv::do_set_data_bittiming callback on devices with fixed data bit rates, extend the check in can_changelink() accordingly.
--- drivers/net/can/dev/netlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/can/dev/netlink.c +2 -1
@@ -279,7 +279,8 @@ static int can_changelink(struct net_device *dev, struct nlattr *tb[],* directly via do_set_bitrate(). Bail out if neither * is given. */ -if (!priv->data_bittiming_const && !priv->do_set_data_bittiming) +if (!priv->data_bittiming_const && !priv->do_set_data_bittiming && + !priv->data_bitrate_const)return -EOPNOTSUPP ; memcpy(&dbt, nla_data(data[IFLA_CAN_DATA_BITTIMING]),
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 359/1157 drm/bridge: anx7625: Zero error variable when panel bridge not present
In reply to Greg Kroah-HartmanFrom: Nícolas F. R. A. Prado <[email protected]>
[ Upstream commit 3f49f7591e7150c502aa8d04354941ec2394153f ]
While parsing the DT, the anx7625 driver checks for the presence of a panel bridge on endpoint 1. If it is missing, pdata->panel_bridge stores the error pointer and the function returns successfully without first cleaning that variable. This is an issue since other functions later check for the presence of a panel bridge by testing the trueness of that variable.
In order to ensure proper behavior, zero out pdata->panel_bridge before returning when no panel bridge is found.
--- drivers/gpu/drm/bridge/analogix/anx7625.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/bridge/analogix/anx7625.c +3 -1
@@ -1657,8 +1657,10 @@ static int anx7625_parse_dt(struct device *dev, pdata->panel_bridge =devm_drm_of_get_bridge (dev, np,1 ,0 );if (IS_ERR (pdata->panel_bridge)) { -if (PTR_ERR (pdata->panel_bridge) == -ENODEV ) +if (PTR_ERR (pdata->panel_bridge) == -ENODEV ) { + pdata->panel_bridge =NULL ;return 0 ; + }return PTR_ERR (pdata->panel_bridge); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 360/1157 drm/bridge: it6505: Add missing CRYPTO_HASH dependency
In reply to Greg Kroah-HartmanFrom: Zheng Bin <[email protected]>
[ Upstream commit abf0ba5a34eae0d7359228f4319a6659676fbd0a ]
The driver uses crypto hash functions so it needs to select CRYPTO_HASH. This fixes build errors:
drivers/gpu/drm/bridge/ite-it6505.o: in function `it6505_hdcp_wait_ksv_list':
ite-it6505.c:(.text+0x4c26): undefined reference to crypto_alloc_shash' ite-it6505.c:(.text+0x4c6d): undefined reference to crypto_shash_digest' ite-it6505.c:(.text+0x4c7d): undefined reference to crypto_destroy_tfm' ite-it6505.c:(.text+0x4d69): undefined reference to crypto_destroy_tfm'
--- drivers/gpu/drm/bridge/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/bridge/Kconfig +2 -0
@@ -94,6 +94,8 @@ config DRM_ITE_IT6505 select DRM_KMS_HELPER select DRM_DP_HELPER select EXTCON + select CRYPTO + select CRYPTO_HASH help ITE IT6505 DisplayPort bridge chip driver.
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 361/1157 i2c: Fix a potential use after free
In reply to Greg Kroah-HartmanFrom: Xu Wang <[email protected]>
[ Upstream commit e4c72c06c367758a14f227c847f9d623f1994ecf ]
Free the adap structure only after we are done using it. This patch just moves the put_device() down a bit to avoid the use after free.
--- drivers/i2c/i2c-core-base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/i2c/i2c-core-base.c +2 -1
@@ -2467,8 +2467,9 @@ void i2c_put_adapter(struct i2c_adapter *adap)if (!adap)return ; -put_device (&adap->dev);module_put (adap->owner); +/* Should be last, otherwise we risk use-after-free with 'adap' */ +put_device (&adap->dev); }EXPORT_SYMBOL (i2c_put_adapter);
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 362/1157 libbpf: Fix internal USDT address translation logic for shared libraries
In reply to Greg Kroah-HartmanFrom: Andrii Nakryiko <[email protected]>
[ Upstream commit 3e6fe5ce4d4860c3a111c246fddc6f31492f4fb0 ]
Perform the same virtual address to file offset translation that libbpf is doing for executable ELF binaries also for shared libraries. Currently libbpf is making a simplifying and sometimes wrong assumption that for shared libraries relative virtual addresses inside ELF are always equal to file offsets.
Unfortunately, this is not always the case with LLVM's lld linker, which now by default generates quite more complicated ELF segments layout. E.g., for liburandom_read.so from selftests/bpf, here's an excerpt from readelf output listing ELF segments (a.k.a. program headers):
Type Offset VirtAddr PhysAddr FileSiz MemSiz Flg Align PHDR 0x000040 0x0000000000000040 0x0000000000000040 0x0001f8 0x0001f8 R 0x8 LOAD 0x000000 0x0000000000000000 0x0000000000000000 0x0005e4 0x0005e4 R 0x1000 LOAD 0x0005f0 0x00000000000015f0 0x00000000000015f0 0x000160 0x000160 R E 0x1000 LOAD 0x000750 0x0000000000002750 0x0000000000002750 0x000210 0x000210 RW 0x1000 LOAD 0x000960 0x0000000000003960 0x0000000000003960 0x000028 0x000029 RW 0x1000
Compare that to what is generated by GNU ld (or LLVM lld's with extra -znoseparate-code argument which disables this cleverness in the name of file size reduction):
Type Offset VirtAddr PhysAddr FileSiz MemSiz Flg Align LOAD 0x000000 0x0000000000000000 0x0000000000000000 0x000550 0x000550 R 0x1000 LOAD 0x001000 0x0000000000001000 0x0000000000001000 0x000131 0x000131 R E 0x1000 LOAD 0x002000 0x0000000000002000 0x0000000000002000 0x0000ac 0x0000ac R 0x1000 LOAD 0x002dc0 0x0000000000003dc0 0x0000000000003dc0 0x000262 0x000268 RW 0x1000
You can see from the first example above that for executable (Flg == "R E") PT_LOAD segment (LOAD #2), Offset doesn't match VirtAddr columns. And it does in the second case (GNU ld output).
This is important because all the addresses, including USDT specs, operate in a virtual address space, while kernel is expecting file offsets when performing uprobe attach. So such mismatches have to be properly taken care of and compensated by libbpf, which is what this patch is fixing.
Also patch clarifies few function and variable names, as well as updates comments to reflect this important distinction (virtaddr vs file offset) and to ephasize that shared libraries are not all that different from executables in this regard.
This patch also changes selftests/bpf Makefile to force urand_read and liburand_read.so to be built with Clang and LLVM's lld (and explicitly request this ELF file size optimization through -znoseparate-code linker parameter) to validate libbpf logic and ensure regressions don't happen in the future. I've bundled these selftests changes together with libbpf changes to keep the above description tied with both libbpf and selftests changes.
--- tools/lib/bpf/usdt.c | 123 ++++++++++++++------------- tools/testing/selftests/bpf/Makefile | 14 +-- 2 files changed, 72 insertions(+), 65 deletions(-)
tools/lib/bpf/usdt.c +63 -60
@@ -441,7 +441,7 @@ static int parse_elf_segs(Elf *elf, const char *path, struct elf_seg **segs, sizreturn 0 ; } -static int parse_lib_segs (int pid,const char *lib_path,struct elf_seg **segs,size_t *seg_cnt) +static int parse_vma_segs (int pid,const char *lib_path,struct elf_seg **segs,size_t *seg_cnt) {char path[PATH_MAX ], line[PATH_MAX ], mode[16 ];size_t seg_start, seg_end, seg_off;
@@ -531,35 +531,40 @@ static int parse_lib_segs(int pid, const char *lib_path, struct elf_seg **segs,return err; } -static struct elf_seg *find_elf_seg (struct elf_seg *segs,size_t seg_cnt,long addr,bool relative) +static struct elf_seg *find_elf_seg (struct elf_seg *segs,size_t seg_cnt,long virtaddr) {struct elf_seg *seg;int i; -if (relative) { -/* for shared libraries, address is relative offset and thus -* should be fall within logical offset-based range of -* [offset_start, offset_end) -*/ -for (i =0 , seg = segs; i < seg_cnt; i++, seg++) { -if (seg->offset <= addr && addr < seg->offset + (seg->end - seg->start)) -return seg; - } - }else { -/* for binaries, address is absolute and thus should be within -* absolute address range of [seg_start, seg_end) -*/ -for (i =0 , seg = segs; i < seg_cnt; i++, seg++) { -if (seg->start <= addr && addr < seg->end) -return seg; - } +/* for ELF binaries (both executables and shared libraries), we are +* given virtual address (absolute for executables, relative for +* libraries) which should match address range of [seg_start, seg_end) +*/ +for (i =0 , seg = segs; i < seg_cnt; i++, seg++) { +if (seg->start <= virtaddr && virtaddr < seg->end) +return seg; } +return NULL ; +} +static struct elf_seg *find_vma_seg (struct elf_seg *segs,size_t seg_cnt,long offset) +{ +struct elf_seg *seg; +int i; + +/* for VMA segments from /proc/<pid>/maps file, provided "address" is +* actually a file offset, so should be fall within logical +* offset-based range of [offset_start, offset_end) +*/ +for (i =0 , seg = segs; i < seg_cnt; i++, seg++) { +if (seg->offset <= offset && offset < seg->offset + (seg->end - seg->start)) +return seg; + }return NULL ; } -static int parse_usdt_note (Elf *elf,const char *path,long base_addr, -GElf_Nhdr *nhdr,const char *data,size_t name_off,size_t desc_off, +static int parse_usdt_note (Elf *elf,const char *path,GElf_Nhdr *nhdr, +const char *data,size_t name_off,size_t desc_off,struct usdt_note *usdt_note);static int parse_usdt_spec (struct usdt_spec *spec,const struct usdt_note *note,__u64 usdt_cookie);
@@ -568,8 +573,8 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char * const char *usdt_provider, const char *usdt_name, __u64 usdt_cookie, struct usdt_target **out_targets, size_t *out_target_cnt) { - size_t off, name_off, desc_off, seg_cnt = 0, lib_seg_cnt = 0, target_cnt = 0; -struct elf_seg *segs =NULL , *lib_segs =NULL ; + size_t off, name_off, desc_off, seg_cnt = 0, vma_seg_cnt = 0, target_cnt = 0; +struct elf_seg *segs =NULL , *vma_segs =NULL ;struct usdt_target *targets =NULL , *target;long base_addr =0 ;Elf_Scn *notes_scn, *base_scn;
@@ -613,8 +618,7 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char *struct elf_seg *seg =NULL ;void *tmp; - err =parse_usdt_note (elf, path, base_addr, &nhdr, - data->d_buf, name_off, desc_off, ¬e); + err =parse_usdt_note (elf, path, &nhdr, data->d_buf, name_off, desc_off, ¬e);if (err) goto err_out;
@@ -654,30 +658,29 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char * usdt_rel_ip += base_addr - note.base_addr; } -if (ehdr.e_type ==ET_EXEC ) { -/* When attaching uprobes (which what USDTs basically -* are) kernel expects a relative IP to be specified, -* so if we are attaching to an executable ELF binary -* (i.e., not a shared library), we need to calculate -* proper relative IP based on ELF's load address -*/ - seg =find_elf_seg (segs, seg_cnt, usdt_abs_ip, false/* relative */ ); -if (!seg) { - err = -ESRCH ; -pr_warn ("usdt: failed to find ELF program segment for '%s:%s' in '%s' at IP 0x%lx\n" , - usdt_provider, usdt_name, path, usdt_abs_ip); - goto err_out; - } -if (!seg->is_exec) { - err = -ESRCH ; -pr_warn ("usdt: matched ELF binary '%s' segment [0x%lx, 0x%lx) for '%s:%s' at IP 0x%lx is not executable\n" , - path, seg->start, seg->end, usdt_provider, usdt_name, - usdt_abs_ip); - goto err_out; - } +/* When attaching uprobes (which is what USDTs basically are) +* kernel expects file offset to be specified, not a relative +* virtual address, so we need to translate virtual address to +* file offset, for both ET_EXEC and ET_DYN binaries. +*/ + seg =find_elf_seg (segs, seg_cnt, usdt_abs_ip); +if (!seg) { + err = -ESRCH ; +pr_warn ("usdt: failed to find ELF program segment for '%s:%s' in '%s' at IP 0x%lx\n" , + usdt_provider, usdt_name, path, usdt_abs_ip); + goto err_out; + } +if (!seg->is_exec) { + err = -ESRCH ; +pr_warn ("usdt: matched ELF binary '%s' segment [0x%lx, 0x%lx) for '%s:%s' at IP 0x%lx is not executable\n" , + path, seg->start, seg->end, usdt_provider, usdt_name, + usdt_abs_ip); + goto err_out; + } +/* translate from virtual address to file offset */ + usdt_rel_ip = usdt_abs_ip - seg->start + seg->offset; - usdt_rel_ip = usdt_abs_ip - (seg->start - seg->offset); - }else if (!man->has_bpf_cookie) {/* ehdr.e_type == ET_DYN */ +if (ehdr.e_type ==ET_DYN && !man->has_bpf_cookie) {/* If we don't have BPF cookie support but need to * attach to a shared library, we'll need to know and * record absolute addresses of attach points due to
@@ -697,9 +700,9 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char * goto err_out; } -/* lib_segs are lazily initialized only if necessary */ -if (lib_seg_cnt ==0 ) { - err =parse_lib_segs (pid, path, &lib_segs, &lib_seg_cnt); +/* vma_segs are lazily initialized only if necessary */ +if (vma_seg_cnt ==0 ) { + err =parse_vma_segs (pid, path, &vma_segs, &vma_seg_cnt);if (err) {pr_warn ("usdt: failed to get memory segments in PID %d for shared library '%s': %d\n" , pid, path, err);
@@ -707,7 +710,7 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char * } } - seg =find_elf_seg (lib_segs, lib_seg_cnt, usdt_rel_ip, true/* relative */ ); + seg =find_vma_seg (vma_segs, vma_seg_cnt, usdt_rel_ip);if (!seg) { err = -ESRCH ; pr_warn("usdt: failed to find shared lib memory segment for '%s:%s' in '%s' at relative IP 0x%lx\n",
@@ -715,7 +718,7 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char * goto err_out; } - usdt_abs_ip = seg->start + (usdt_rel_ip - seg->offset); + usdt_abs_ip = seg->start - seg->offset + usdt_rel_ip; } pr_debug("usdt: probe for '%s:%s' in %s '%s': addr 0x%lx base 0x%lx (resolved abs_ip 0x%lx rel_ip 0x%lx) args '%s' in segment [0x%lx, 0x%lx) at offset 0x%lx\n",
@@ -723,7 +726,7 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char * note.loc_addr, note.base_addr, usdt_abs_ip, usdt_rel_ip, note.args, seg ? seg->start : 0, seg ? seg->end : 0, seg ? seg->offset : 0); -/* Adjust semaphore address to be a relative offset */ +/* Adjust semaphore address to be a file offset */ if (note.sema_addr) {if (!man->has_sema_refcnt) { pr_warn("usdt: kernel doesn't support USDT semaphore refcounting for '%s:%s' in '%s'\n",
@@ -732,7 +735,7 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char * goto err_out; } - seg =find_elf_seg (segs, seg_cnt, note.sema_addr, false/* relative */ ); + seg =find_elf_seg (segs, seg_cnt, note.sema_addr);if (!seg) { err = -ESRCH ; pr_warn("usdt: failed to find ELF loadable segment with semaphore of '%s:%s' in '%s' at 0x%lx\n",
@@ -747,7 +750,7 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char * goto err_out; } - usdt_sema_off = note.sema_addr - (seg->start - seg->offset); + usdt_sema_off = note.sema_addr - seg->start + seg->offset; pr_debug("usdt: sema for '%s:%s' in %s '%s': addr 0x%lx base 0x%lx (resolved 0x%lx) in segment [0x%lx, 0x%lx] at offset 0x%lx\n", usdt_provider, usdt_name, ehdr.e_type == ET_EXEC ? "exec" : "lib ",
@@ -770,7 +773,7 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char * target->rel_ip = usdt_rel_ip; target->sema_off = usdt_sema_off; -/* notes->args references strings from Elf itself, so they can +/* notes.args references strings from Elf itself, so they can * be referenced safely until elf_end() call */ target->spec_str = note.args;
@@ -788,7 +791,7 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char * err_out:free (segs); -free (lib_segs); +free (vma_segs);if (err <0 )free (targets);return err;
@@ -1089,8 +1092,8 @@ struct bpf_link *usdt_manager_attach_usdt(struct usdt_manager *man, const struct/* Parse out USDT ELF note from '.note.stapsdt' section. * Logic inspired by perf's code. */ -static int parse_usdt_note (Elf *elf,const char *path,long base_addr, -GElf_Nhdr *nhdr,const char *data,size_t name_off,size_t desc_off, +static int parse_usdt_note (Elf *elf,const char *path,GElf_Nhdr *nhdr, +const char *data,size_t name_off,size_t desc_off,struct usdt_note *note) {const char *provider, *name, *args;
tools/testing/selftests/bpf/Makefile +9 -5
@@ -172,13 +172,15 @@ $(OUTPUT)/%:%.c # do not fail. Static builds leave urandom_read relying on system-wide shared libraries. $(OUTPUT)/liburandom_read.so: urandom_read_lib1.c urandom_read_lib2.c $(call msg,LIB,,$@) - $(Q)$(CC) $(filter-out -static,$(CFLAGS) $(LDFLAGS)) $^ $(LDLIBS) -fPIC -shared -o $@ + $(Q)$(CLANG) $(filter-out -static,$(CFLAGS) $(LDFLAGS)) $^ $(LDLIBS) \ + -fuse-ld=lld -Wl,-znoseparate-code -fPIC -shared -o $@ $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_read.so $(call msg,BINARY,,$@) - $(Q)$(CC) $(filter-out -static,$(CFLAGS) $(LDFLAGS)) $(filter %.c,$^) \ - liburandom_read.so $(LDLIBS) \ - -Wl,-rpath=. -Wl,--build-id=sha1 -o $@ + $(Q)$(CLANG) $(filter-out -static,$(CFLAGS) $(LDFLAGS)) $(filter %.c,$^) \ + liburandom_read.so $(LDLIBS) \ + -fuse-ld=lld -Wl,-znoseparate-code \ + -Wl,-rpath=. -Wl,--build-id=sha1 -o $@ $(OUTPUT)/bpf_testmod.ko: $(VMLINUX_BTF) $(wildcard bpf_testmod/Makefile bpf_testmod/*.[ch]) $(call msg,MOD,,$@)
@@ -578,6 +580,8 @@ $(OUTPUT)/bench: $(OUTPUT)/bench.o \ EXTRA_CLEAN := $(TEST_CUSTOM_PROGS) $(SCRATCH_DIR) $(HOST_SCRATCH_DIR) \ prog_tests/tests.h map_tests/tests.h verifier/tests.h \ feature bpftool \ - $(addprefix $(OUTPUT)/,*.o *.skel.h *.lskel.h *.subskel.h no_alu32 bpf_gcc bpf_testmod.ko) + $(addprefix $(OUTPUT)/,*.o *.skel.h *.lskel.h *.subskel.h \ + no_alu32 bpf_gcc bpf_testmod.ko \ + liburandom_read.so) .PHONY: docs docs-clean
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 363/1157 selftests/bpf: Dont force lld on non-x86 architectures
In reply to Greg Kroah-HartmanFrom: Andrii Nakryiko <[email protected]>
[ Upstream commit 08c79c9cd67fffd0d5538ddbd3a97b0a865b5eb5 ]
LLVM's lld linker doesn't have a universal architecture support (e.g., it definitely doesn't work on s390x), so be safe and force lld for urandom_read and liburandom_read.so only on x86 architectures.
This should fix s390x CI runs.
--- tools/testing/selftests/bpf/Makefile | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
tools/testing/selftests/bpf/Makefile +9 -2
@@ -168,18 +168,25 @@ $(OUTPUT)/%:%.c $(call msg,BINARY,,$@) $(Q)$(LINK.c) $^ $(LDLIBS) -o $@ +# LLVM's ld.lld doesn't support all the architectures, so use it only on x86 +ifeq ($(SRCARCH),x86) +LLD := lld +else +LLD := ld +endif + # Filter out -static for liburandom_read.so and its dependent targets so that static builds # do not fail. Static builds leave urandom_read relying on system-wide shared libraries. $(OUTPUT)/liburandom_read.so: urandom_read_lib1.c urandom_read_lib2.c $(call msg,LIB,,$@) $(Q)$(CLANG) $(filter-out -static,$(CFLAGS) $(LDFLAGS)) $^ $(LDLIBS) \ - -fuse-ld=lld -Wl,-znoseparate-code -fPIC -shared -o $@ + -fuse-ld=$(LLD) -Wl,-znoseparate-code -fPIC -shared -o $@ $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_read.so $(call msg,BINARY,,$@) $(Q)$(CLANG) $(filter-out -static,$(CFLAGS) $(LDFLAGS)) $(filter %.c,$^) \ liburandom_read.so $(LDLIBS) \ - -fuse-ld=lld -Wl,-znoseparate-code \ + -fuse-ld=$(LLD) -Wl,-znoseparate-code \ -Wl,-rpath=. -Wl,--build-id=sha1 -o $@ $(OUTPUT)/bpf_testmod.ko: $(VMLINUX_BTF) $(wildcard bpf_testmod/Makefile bpf_testmod/*.[ch])
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 364/1157 tcp: fix possible freeze in tx path under memory pressure
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit 849b425cd091e1804af964b771761cfbefbafb43 ]
Blamed commit only dealt with applications issuing small writes.
Issue here is that we allow to force memory schedule for the sk_buff allocation, but we have no guarantee that sendmsg() is able to copy some payload in it.
In this patch, I make sure the socket can use up to tcp_wmem[0] bytes.
For example, if we consider tcp_wmem[0] = 4096 (default on x86), and initial skb->truesize being 1280, tcp_sendmsg() is able to copy up to 2816 bytes under memory pressure.
Before this patch a sendmsg() sending more than 2816 bytes would either block forever (if persistent memory pressure), or return -EAGAIN.
For bigger MTU networks, it is advised to increase tcp_wmem[0] to avoid sending too small packets.
v2: deal with zero copy paths.
--- net/ipv4/tcp.c | 33 +++++++++++++++++++++++++++++---- 1 file changed, 29 insertions(+), 4 deletions(-)
net/ipv4/tcp.c +29 -4
@@ -952,6 +952,23 @@ static int tcp_downgrade_zcopy_pure(struct sock *sk, struct sk_buff *skb)return 0 ; } +static int tcp_wmem_schedule (struct sock *sk,int copy) +{ +int left; + +if (likely (sk_wmem_schedule (sk, copy))) +return copy; + +/* We could be in trouble if we have nothing queued. +* Use whatever is left in sk->sk_forward_alloc and tcp_wmem[0] +* to guarantee some progress. +*/ + left =sock_net (sk)->ipv4.sysctl_tcp_wmem[0 ] - sk->sk_wmem_queued; +if (left >0 ) +sk_forced_mem_schedule (sk,min (left, copy)); +return min (copy, sk->sk_forward_alloc); +} +static struct sk_buff *tcp_build_frag (struct sock *sk,int size_goal,int flags,struct page *page,int offset,size_t *size) {
@@ -987,7 +1004,11 @@ static struct sk_buff *tcp_build_frag(struct sock *sk, int size_goal, int flags,tcp_mark_push (tp, skb); goto new_segment; } -if (tcp_downgrade_zcopy_pure (sk, skb) || !sk_wmem_schedule (sk, copy)) +if (tcp_downgrade_zcopy_pure (sk, skb)) +return NULL ; + + copy =tcp_wmem_schedule (sk, copy); +if (!copy)return NULL ;if (can_coalesce) {
@@ -1336,8 +1357,11 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size) copy =min_t (int, copy, pfrag->size - pfrag->offset); -if (tcp_downgrade_zcopy_pure (sk, skb) || - !sk_wmem_schedule (sk, copy)) +if (tcp_downgrade_zcopy_pure (sk, skb)) + goto wait_for_space; + + copy =tcp_wmem_schedule (sk, copy); +if (!copy) goto wait_for_space; err = skb_copy_to_page_nocache(sk, &msg->msg_iter, skb,
@@ -1364,7 +1388,8 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)skb_shinfo (skb)->flags |=SKBFL_PURE_ZEROCOPY ;if (!skb_zcopy_pure (skb)) { -if (!sk_wmem_schedule (sk, copy)) + copy =tcp_wmem_schedule (sk, copy); +if (!copy) goto wait_for_space; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 365/1157 crypto: sun8i-ss - fix infinite loop in sun8i_ss_setup_ivs()
In reply to Greg Kroah-HartmanFrom: Alexey Khoroshilov <[email protected]>
[ Upstream commit d61a7b3decf7f0cf4121a7204303deefd2c7151b ]
There is no i decrement in while (i >= 0) loop.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
--- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 1 + 1 file changed, 1 insertion(+)
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c +1 -0
@@ -170,6 +170,7 @@ static int sun8i_ss_setup_ivs(struct skcipher_request *areq)while (i >=0 ) {dma_unmap_single (ss->dev, rctx->p_iv[i], ivsize,DMA_TO_DEVICE );memzero_explicit (sf->iv[i], ivsize); + i--; }return err; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 366/1157 net: ag71xx: fix discards const qualifier warning
In reply to Greg Kroah-HartmanFrom: Oleksij Rempel <[email protected]>
[ Upstream commit 225b0ed27e6ac523e5e98e7395392446859c7f20 ]
Current kernel will compile this driver with warnings. This patch will fix it.
drivers/net/ethernet/atheros/ag71xx.c: In function 'ag71xx_fast_reset':drivers/net/ethernet/atheros/ag71xx.c:996:31: warning: passing argument 2 of 'ag71xx_hw_set _macaddr' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
996 | ag71xx_hw_set_macaddr(ag, dev->dev_addr);
| ~~~^~~~~~~~~~
drivers/net/ethernet/atheros/ag71xx.c:951:69: note: expected 'unsigned char *' but argument
is of type 'const unsigned char *'
951 | static void ag71xx_hw_set_macaddr(struct ag71xx *ag, unsigned char *mac)
| ~~~~~~~~~~~~~~~^~~
drivers/net/ethernet/atheros/ag71xx.c: In function 'ag71xx_open':
drivers/net/ethernet/atheros/ag71xx.c:1441:32: warning: passing argument 2 of 'ag71xx_hw_se
t_macaddr' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
1441 | ag71xx_hw_set_macaddr(ag, ndev->dev_addr);
| ~~~~^~~~~~~~~~
drivers/net/ethernet/atheros/ag71xx.c:951:69: note: expected 'unsigned char *' but argument
is of type 'const unsigned char *'
951 | static void ag71xx_hw_set_macaddr(struct ag71xx *ag, unsigned char *mac)
| ~~~~~~~~~~~~~~~^~~--- drivers/net/ethernet/atheros/ag71xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/atheros/ag71xx.c +1 -1
@@ -946,7 +946,7 @@ static unsigned int ag71xx_max_frame_len(unsigned int mtu)return ETH_HLEN +VLAN_HLEN + mtu +ETH_FCS_LEN ; } -static void ag71xx_hw_set_macaddr (struct ag71xx *ag,unsigned char *mac) +static void ag71xx_hw_set_macaddr (struct ag71xx *ag,const unsigned char *mac) {u32 t;
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 367/1157 ping: convert to RCU lookups, get rid of rwlock
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit dbca1596bbb08318f5e3b3b99f8ca0a0d3830a65 ]
Using rwlock in networking code is extremely risky. writers can starve if enough readers are constantly grabing the rwlock.
I thought rwlock were at fault and sent this patch:
https://lkml.org/lkml/2022/6/17/272
But Peter and Linus essentially told me rwlock had to be unfair.
We need to get rid of rwlock in networking code.
--- net/ipv4/ping.c | 36 ++++++++++++++++-------------------- 1 file changed, 16 insertions(+), 20 deletions(-)
net/ipv4/ping.c +16 -20
@@ -50,7 +50,7 @@struct ping_table {struct hlist_nulls_head hash[PING_HTABLE_SIZE ]; -rwlock_t lock; +spinlock_t lock; };static struct ping_table ping_table;
@@ -82,7 +82,7 @@ int ping_get_port(struct sock *sk, unsigned short ident)struct sock *sk2 =NULL ; isk =inet_sk (sk); -write_lock_bh (&ping_table.lock); +spin_lock (&ping_table.lock);if (ident ==0 ) {u32 i;u16 result = ping_port_rover +1 ;
@@ -128,14 +128,15 @@ int ping_get_port(struct sock *sk, unsigned short ident)if (sk_unhashed (sk)) {pr_debug ("was not hashed\n" );sock_hold (sk); -hlist_nulls_add_head (&sk->sk_nulls_node, hlist); +sock_set_flag (sk,SOCK_RCU_FREE ); +hlist_nulls_add_head_rcu (&sk->sk_nulls_node, hlist);sock_prot_inuse_add (sock_net (sk), sk->sk_prot,1 ); } -write_unlock_bh (&ping_table.lock); +spin_unlock (&ping_table.lock);return 0 ; fail: -write_unlock_bh (&ping_table.lock); +spin_unlock (&ping_table.lock);return 1 ; }EXPORT_SYMBOL_GPL (ping_get_port);
@@ -153,19 +154,19 @@ void ping_unhash(struct sock *sk)struct inet_sock *isk =inet_sk (sk);pr_debug ("ping_unhash(isk=%p,isk->num=%u)\n" , isk, isk->inet_num); -write_lock_bh (&ping_table.lock); +spin_lock (&ping_table.lock);if (sk_hashed (sk)) { -hlist_nulls_del (&sk->sk_nulls_node); -sk_nulls_node_init (&sk->sk_nulls_node); +hlist_nulls_del_init_rcu (&sk->sk_nulls_node);sock_put (sk); isk->inet_num =0 ; isk->inet_sport =0 ;sock_prot_inuse_add (sock_net (sk), sk->sk_prot,-1 ); } -write_unlock_bh (&ping_table.lock); +spin_unlock (&ping_table.lock); }EXPORT_SYMBOL_GPL (ping_unhash); +/* Called under rcu_read_lock() */ static struct sock *ping_lookup (struct net *net,struct sk_buff *skb,u16 ident) {struct hlist_nulls_head *hslot =ping_hashslot (&ping_table, net, ident);
@@ -190,8 +191,6 @@ static struct sock *ping_lookup(struct net *net, struct sk_buff *skb, u16 ident)return NULL ; } -read_lock_bh (&ping_table.lock); -ping_portaddr_for_each_entry (sk, hnode, hslot) { isk =inet_sk (sk);
@@ -230,13 +229,11 @@ static struct sock *ping_lookup(struct net *net, struct sk_buff *skb, u16 ident) sk->sk_bound_dev_if != sdif)continue ; -sock_hold (sk); goto exit; } sk =NULL ; exit: -read_unlock_bh (&ping_table.lock);return sk; }
@@ -592,7 +589,7 @@ void ping_err(struct sk_buff *skb, int offset, u32 info) sk->sk_err = err;sk_error_report (sk); out: -sock_put (sk); +return ; }EXPORT_SYMBOL_GPL (ping_err);
@@ -998,7 +995,6 @@ enum skb_drop_reason ping_rcv(struct sk_buff *skb) reason =__ping_queue_rcv_skb (sk, skb2); else reason =SKB_DROP_REASON_NOMEM ; -sock_put (sk); }if (reason)
@@ -1084,13 +1080,13 @@ static struct sock *ping_get_idx(struct seq_file *seq, loff_t pos) }void *ping_seq_start (struct seq_file *seq,loff_t *pos,sa_family_t family) - __acquires(ping_table.lock) +__acquires (RCU ) {struct ping_iter_state *state = seq->private; state->bucket =0 ; state->family = family; -read_lock_bh (&ping_table.lock); +rcu_read_lock ();return *pos ?ping_get_idx (seq, *pos-1 ) :SEQ_START_TOKEN ; }
@@ -1116,9 +1112,9 @@ void *ping_seq_next(struct seq_file *seq, void *v, loff_t *pos)EXPORT_SYMBOL_GPL (ping_seq_next);void ping_seq_stop (struct seq_file *seq,void *v) - __releases(ping_table.lock) +__releases (RCU ) { -read_unlock_bh (&ping_table.lock); +rcu_read_unlock (); }EXPORT_SYMBOL_GPL (ping_seq_stop);
@@ -1202,5 +1198,5 @@ void __init ping_init(void)for (i =0 ; i <PING_HTABLE_SIZE ; i++)INIT_HLIST_NULLS_HEAD (&ping_table.hash[i], i); -rwlock_init (&ping_table.lock); +spin_lock_init (&ping_table.lock); }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 368/1157 raw: use more conventional iterators
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit ba44f8182ec299c5d1c8a72fc0fde4ec127b5a6d ]
In order to prepare the following patch,
I change raw v4 & v6 code to use more conventional iterators.
--- include/net/raw.h | 5 +-- include/net/rawv6.h | 6 +-- net/ipv4/raw.c | 93 ++++++++++++++------------------------- net/ipv4/raw_diag.c | 33 +++++++------- net/ipv6/raw.c | 105 ++++++++++++++++---------------------------- 5 files changed, 92 insertions(+), 150 deletions(-)
include/net/raw.h +2 -3
@@ -20,9 +20,8 @@extern struct proto raw_prot;extern struct raw_hashinfo raw_v4_hashinfo; -struct sock *__raw_v4_lookup (struct net *net,struct sock *sk, -unsigned short num,__be32 raddr, -__be32 laddr,int dif,int sdif); +bool raw_v4_match (struct net *net,struct sock *sk,unsigned short num, +__be32 raddr,__be32 laddr,int dif,int sdif);int raw_abort (struct sock *sk,int err);void raw_icmp_error (struct sk_buff *,int ,u32 );
include/net/rawv6.h +3 -3
@@ -5,9 +5,9 @@#include <net/protocol.h> extern struct raw_hashinfo raw_v6_hashinfo; -struct sock *__raw_v6_lookup (struct net *net,struct sock *sk, -unsigned short num,const struct in6_addr *loc_addr, -const struct in6_addr *rmt_addr,int dif,int sdif); +bool raw_v6_match (struct net *net,struct sock *sk,unsigned short num, +const struct in6_addr *loc_addr, +const struct in6_addr *rmt_addr,int dif,int sdif);int raw_abort (struct sock *sk,int err);
net/ipv4/raw.c +33 -60
140 lines not on this page · raw message
net/ipv4/raw_diag.c +16 -17
@@ -34,31 +34,30 @@ raw_get_hashinfo(const struct inet_diag_req_v2 *r)* use helper to figure it out. */ -static struct sock *raw_lookup (struct net *net,struct sock *from, -const struct inet_diag_req_v2 *req) +static bool raw_lookup (struct net *net,struct sock *sk, +const struct inet_diag_req_v2 *req) {struct inet_diag_req_raw *r = (void *)req; -struct sock *sk =NULL ;if (r->sdiag_family ==AF_INET ) - sk =__raw_v4_lookup (net, from, r->sdiag_raw_protocol, - r->id.idiag_dst[0 ], - r->id.idiag_src[0 ], - r->id.idiag_if,0 ); +return raw_v4_match (net, sk, r->sdiag_raw_protocol, + r->id.idiag_dst[0 ], + r->id.idiag_src[0 ], + r->id.idiag_if,0 );#if IS_ENABLED (CONFIG_IPV6 ) else - sk =__raw_v6_lookup (net, from, r->sdiag_raw_protocol, - (const struct in6_addr *)r->id.idiag_src, - (const struct in6_addr *)r->id.idiag_dst, - r->id.idiag_if,0 ); + return raw_v6_match(net, sk, r->sdiag_raw_protocol, + (const struct in6_addr *)r->id.idiag_src, + (const struct in6_addr *)r->id.idiag_dst, + r->id.idiag_if,0 );#endif -return sk; +return false; }static struct sock *raw_sock_get (struct net *net,const struct inet_diag_req_v2 *r) {struct raw_hashinfo *hashinfo =raw_get_hashinfo (r); -struct sock *sk =NULL , *s; +struct sock *sk;int slot;if (IS_ERR (hashinfo))
@@ -66,9 +65,8 @@ static struct sock *raw_sock_get(struct net *net, const struct inet_diag_req_v2read_lock (&hashinfo->lock);for (slot =0 ; slot <RAW_HTABLE_SIZE ; slot++) { -sk_for_each (s, &hashinfo->ht[slot]) { - sk =raw_lookup (net, s, r); -if (sk) { +sk_for_each (sk, &hashinfo->ht[slot]) { +if (raw_lookup (net, sk, r)) {/* * Grab it and keep until we fill * diag meaage to be reported, so
@@ -81,10 +79,11 @@ static struct sock *raw_sock_get(struct net *net, const struct inet_diag_req_v2 } } } + sk =ERR_PTR (-ENOENT ); out_unlock:read_unlock (&hashinfo->lock); -return sk ? sk :ERR_PTR (-ENOENT ); +return sk; } static int raw_diag_dump_one(struct netlink_callback *cb,
net/ipv6/raw.c +38 -67
161 lines not on this page · raw message
Signature · 1 line
2.35.1