Skip to contentSkip to conversation

PCI: endpoint: fix Kconfig indent style

PATCH Applied Shunsuke Mie 3 participants 7 messages Aug 15, 2022 – Nov 11, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: endpoint: fix Kconfig indent style

Change to follow the Kconfig style guide. This patch fixes to use tab rather than space to indent, while help text is indented an additional two spaces.

Fixes e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
---
 drivers/pci/endpoint/functions/Kconfig | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/pci/endpoint/functions/Kconfig +9 -9
index 295a033ee9a2..9fd560886871 100644
@@ -27,13 +27,13 @@ config PCI_EPF_NTB
 	  If in doubt, say "N" to disable Endpoint NTB driver.
 
 config PCI_EPF_VNTB
-        tristate "PCI Endpoint NTB driver"
-        depends on PCI_ENDPOINT
-        depends on NTB
-        select CONFIGFS_FS
-        help
-          Select this configuration option to enable the Non-Transparent
-          Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
-          between PCI Root Port and PCIe Endpoint.
+	tristate "PCI Endpoint NTB driver"
+	depends on PCI_ENDPOINT
+	depends on NTB
+	select CONFIGFS_FS
+	help
+	  Select this configuration option to enable the Non-Transparent
+	  Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
+	  between PCI Root Port and PCIe Endpoint.
 
-          If in doubt, say "N" to disable Endpoint NTB driver.
+	  If in doubt, say "N" to disable Endpoint NTB driver.
Signature · 1 line
2.17.1
#1 lore raw

I have a question, not related to the patch. Could you please tell me why the ntb related patches are managed outside the pci branch, Helgaas's branch? It confused me a little to find the ntb branch.

Thanks,
Shunsuke

2022年8月15日(月) 11:50 Shunsuke Mie <[email protected]>:

Quoted 41 lines

Change to follow the Kconfig style guide. This patch fixes to use tab rather than space to indent, while help text is indented an additional two spaces.

Fixes e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
---
 drivers/pci/endpoint/functions/Kconfig | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/pci/endpoint/functions/Kconfig +9 -10
index 295a033ee9a2..9fd560886871 100644
@@ -27,13 +27,13 @@ config PCI_EPF_NTB
          If in doubt, say "N" to disable Endpoint NTB driver.
 
 config PCI_EPF_VNTB
-        tristate "PCI Endpoint NTB driver"
-        depends on PCI_ENDPOINT
-        depends on NTB
-        select CONFIGFS_FS
-        help
-          Select this configuration option to enable the Non-Transparent
-          Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
-          between PCI Root Port and PCIe Endpoint.
+       tristate "PCI Endpoint NTB driver"
+       depends on PCI_ENDPOINT
+       depends on NTB
+       select CONFIGFS_FS
+       help
+         Select this configuration option to enable the Non-Transparent
+         Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
+         between PCI Root Port and PCIe Endpoint.
 
-          If in doubt, say "N" to disable Endpoint NTB driver.
+         If in doubt, say "N" to disable Endpoint NTB driver.
--

2.17.1

#2 lore raw
Quoted 3 lines · Shunsuke Mie

I have a question, not related to the patch. Could you please tell me why the ntb related patches are managed outside the pci branch, Helgaas's branch? It confused me a little to find the ntb branch.

My understanding is that the recent drivers/pci/endpoint/functions/*ntb.c patches were merged by Jon because they had dependencies on other patches in his tree.

In the future, I think most NTB-related patches in drivers/pci/ will be merged via my PCI tree.

Bjorn

#3 lore raw

Hi Bjom,

2022年8月16日(火) 3:39 Bjorn Helgaas <[email protected]>:

Quoted 9 lines · Shunsuke Mie
Quoted 3 lines

I have a question, not related to the patch. Could you please tell me why the ntb related patches are managed outside the pci branch, Helgaas's branch? It confused me a little to find the ntb branch.

My understanding is that the recent drivers/pci/endpoint/functions/*ntb.c patches were merged by Jon because they had dependencies on other patches in his tree.

That makes sense.

Quoted 4 lines

In the future, I think most NTB-related patches in drivers/pci/ will be merged via my PCI tree.

Bjorn

Thanks,
Shunsuke

#4 lore raw
In reply to Shunsuke Mie
Quoted 6 lines · Shunsuke Mie

Change to follow the Kconfig style guide. This patch fixes to use tab rather than space to indent, while help text is indented an additional two spaces.

Fixes e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")

Thanks for doing this. In the future make the subject line match the history, e.g.,

  $ git log --oneline drivers/pci/endpoint/functions/Kconfig
  556a2c7dca33 ("PCI: endpoint: Fix Kconfig dependency")
  e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
  8b821cf76150 ("PCI: endpoint: Add EP function driver to provide NTB functionality")
  98dbf5af4fdd ("PCI: endpoint: Select CRC32 to fix test build error")
  349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI")

Note that these are all capitalized ("Fix Kconfig indent style").

Lorenzo will likely fix this up when applying, so no need to repost for this.

Quoted 34 lines
---
 drivers/pci/endpoint/functions/Kconfig | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/pci/endpoint/functions/Kconfig +9 -9
index 295a033ee9a2..9fd560886871 100644
@@ -27,13 +27,13 @@ config PCI_EPF_NTB
 	  If in doubt, say "N" to disable Endpoint NTB driver.
 
 config PCI_EPF_VNTB
-        tristate "PCI Endpoint NTB driver"
-        depends on PCI_ENDPOINT
-        depends on NTB
-        select CONFIGFS_FS
-        help
-          Select this configuration option to enable the Non-Transparent
-          Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
-          between PCI Root Port and PCIe Endpoint.
+	tristate "PCI Endpoint NTB driver"
+	depends on PCI_ENDPOINT
+	depends on NTB
+	select CONFIGFS_FS
+	help
+	  Select this configuration option to enable the Non-Transparent
+	  Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
+	  between PCI Root Port and PCIe Endpoint.
 
-          If in doubt, say "N" to disable Endpoint NTB driver.
+	  If in doubt, say "N" to disable Endpoint NTB driver.
Signature · 1 line
2.17.1
#5 lore raw

Hi Lorenzo,

2022年8月16日(火) 3:41 Bjorn Helgaas <[email protected]>:

Quoted 19 lines · Shunsuke Mie
Quoted 6 lines

Change to follow the Kconfig style guide. This patch fixes to use tab rather than space to indent, while help text is indented an additional two spaces.

Fixes e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")

Thanks for doing this. In the future make the subject line match the history, e.g.,

  $ git log --oneline drivers/pci/endpoint/functions/Kconfig
  556a2c7dca33 ("PCI: endpoint: Fix Kconfig dependency")
  e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
  8b821cf76150 ("PCI: endpoint: Add EP function driver to provide NTB functionality")
  98dbf5af4fdd ("PCI: endpoint: Select CRC32 to fix test build error")
  349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI")
Quoted 4 lines

Note that these are all capitalized ("Fix Kconfig indent style").

Lorenzo will likely fix this up when applying, so no need to repost for this.

This is a gentle ping.

Quoted 30 lines
Quoted 30 lines
---
 drivers/pci/endpoint/functions/Kconfig | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/pci/endpoint/functions/Kconfig +8 -8
index 295a033ee9a2..9fd560886871 100644
@@ -27,13 +27,13 @@ config PCI_EPF_NTB
        If in doubt, say "N" to disable Endpoint NTB driver.
 
 config PCI_EPF_VNTB
-        tristate "PCI Endpoint NTB driver"
-        depends on PCI_ENDPOINT
-        depends on NTB
-        select CONFIGFS_FS
-        help
-          Select this configuration option to enable the Non-Transparent
-          Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
-          between PCI Root Port and PCIe Endpoint.
+     tristate "PCI Endpoint NTB driver"
+     depends on PCI_ENDPOINT
+     depends on NTB
+     select CONFIGFS_FS
+     help
+       Select this configuration option to enable the Non-Transparent
+       Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
+       between PCI Root Port and PCIe Endpoint.
 
Quoted 5 lines
Quoted 5 lines
drivers/pci/endpoint/functions/Kconfig +1 -2
-          If in doubt, say "N" to disable Endpoint NTB driver.
+       If in doubt, say "N" to disable Endpoint NTB driver.
--

2.17.1

thanks,
Shunsuke