Detect warning options during configure
Subsystems (2)
PATCH 1/2 Detect warning options during configure
Certain options maybe compiler specific therefore its better to detect them before use.
nfs_error copies the format string and appends newline to it but compiler can forget that it was format string since its not same fmt string that was passed. Ignore the warning
Wdiscarded-qualifiers is gcc specific and this is no longer needed
Upstream-Status: Pending
Signed-off-by Khem Raj <[email protected]>
%% original patch: clang-warnings.patch
Signed-off-by Khem Raj <[email protected]>
--- support/nfs/xcommon.c | 3 +++ 1 file changed, 3 insertions(+)
support/nfs/xcommon.c +3 -0
@@ -98,7 +98,10 @@ nfs_error (const char *fmt, ...) { fmt2 =xstrconcat2 (fmt,"\n" );va_start (args, fmt); +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wformat-nonliteral"vfprintf (stderr, fmt2, args); +#pragma GCC diagnostic popva_end (args);free (fmt2); }
Signature · 1 line
2.37.2
PATCH 2/2 mountd: Check for return of stat function
simplify the check, stat() return 0 on success -1 on failure
Fixes clang reported errors e.g.
| v4clients.c:29:6: error: logical not is only applied to the left hand side of this comparison [-Werror,-Wlogical-not-parentheses]
| if (!stat("/proc/fs/nfsd/clients", &sb) == 0 ||
| ^ ~~Signed-off-by Khem Raj <[email protected]>
Cc Konstantin Khorenko <[email protected]>
Cc Steve Dickson <[email protected]>
Signed-off-by Khem Raj <[email protected]>
--- support/export/v4clients.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
support/export/v4clients.c +1 -1
@@ -26,7 +26,7 @@ void v4clients_init(void) {struct stat sb; -if (!stat ("/proc/fs/nfsd/clients" , &sb) ==0 || +if (stat ("/proc/fs/nfsd/clients" , &sb) !=0 || !S_ISDIR (sb.st_mode))return ;if (clients_fd >=0 )
Signature · 1 line
2.37.2
Please ignore this patch. It was not right one. I am sending a v2