Skip to contentSkip to conversation

distrooverrides.bbclass: use IMAGE_CLASSES

PATCH In review [email protected] 3 participants 4 messages Aug 16, 2022 – Aug 18, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 distrooverrides.bbclass: use IMAGE_CLASSES

From: Kai Kang <[email protected]>

Update comment in distrooverrides.bbclass to use IMAGE_CLASSES rather than globally with INHERIT.

---
 meta/classes-recipe/distrooverrides.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes-recipe/distrooverrides.bbclass +1 -1
index 8d9d7cda7d..b5346b465e 100644
@@ -17,7 +17,7 @@
 #
 # The class is meant to be used in a layer.conf or distro
 # .inc file with:
-# INHERIT += "distrooverrides"
+# IMAGE_CLASSES += "distrooverrides"
 # DISTRO_FEATURES_OVERRIDES += "my-feature"
 #
 # Beware that this part of OVERRIDES changes during parsing, so usage
Signature · 1 line
2.17.1
#1 lore raw

This class functionality isn't limited to images.

Quoted 39 lines · kai

From: Kai Kang <[email protected]>

Update comment in distrooverrides.bbclass to use IMAGE_CLASSES rather than globally with INHERIT.

---
 meta/classes-recipe/distrooverrides.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes-recipe/distrooverrides.bbclass +1 -2
index 8d9d7cda7d..b5346b465e 100644
@@ -17,7 +17,7 @@
 #
 # The class is meant to be used in a layer.conf or distro
 # .inc file with:
-# INHERIT += "distrooverrides"
+# IMAGE_CLASSES += "distrooverrides"
 # DISTRO_FEATURES_OVERRIDES += "my-feature"
 #
 # Beware that this part of OVERRIDES changes during parsing, so usage
--

2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#169428):
https://lists.openembedded.org/g/openembedded-core/message/169428
Mute This Topic: https://lists.openembedded.org/mt/93054585/3617123
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 4 lines
Christopher Larson
[email protected], [email protected], [email protected]
Principal Software Engineer, Embedded Linux Solutions, Siemens Digital
Industries Software
author
#2 lore raw
Quoted 1 line · Christopher Larson

This class functionality isn't limited to images.

If not, it may need to move to classes-global. Otherwise it fails to parse:

ERROR: ParseError in configuration INHERITs: Could not inherit file classes/distrooverrides.bbclass

Quoted 48 lines · kai
    From: Kai Kang <[email protected]>

    Update comment in distrooverrides.bbclass to use IMAGE_CLASSES rather
    than globally with INHERIT.

    Signed-off-by: Kai Kang <[email protected]>
    ---
     meta/classes-recipe/distrooverrides.bbclass | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/meta/classes-recipe/distrooverrides.bbclass
    b/meta/classes-recipe/distrooverrides.bbclass
    index 8d9d7cda7d..b5346b465e 100644
    --- a/meta/classes-recipe/distrooverrides.bbclass
    +++ b/meta/classes-recipe/distrooverrides.bbclass
    @@ -17,7 +17,7 @@
     #
     # The class is meant to be used in a layer.conf or distro
     # .inc file with:
    -# INHERIT += "distrooverrides"
    +# IMAGE_CLASSES += "distrooverrides"
     # DISTRO_FEATURES_OVERRIDES += "my-feature"
     #
     # Beware that this part of OVERRIDES changes during parsing, so usage
    -- 
    2.17.1
Signature · 11 lines
Christopher Larson
[email protected], [email protected], [email protected]
Principal Software Engineer, Embedded Linux Solutions, Siemens Digital Industries Software

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#169439):https://lists.openembedded.org/g/openembedded-core/message/169439
Mute This Topic:https://lists.openembedded.org/mt/93054585/3616933
Group Owner:[email protected]
Unsubscribe:https://lists.openembedded.org/g/openembedded-core/unsub  [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 2 lines
Kai Kang
Wind River Linux
#3 lore raw
Quoted 9 lines · kai

On 8/16/22 22:55, Christopher Larson wrote:

Quoted 1 line

This class functionality isn't limited to images.

If not, it may need to move to classes-global. Otherwise it fails to parse:
ERROR: ParseError in configuration INHERITs: Could not inherit file classes/distrooverrides.bbclass

I've moved this back to the classes directory for now until we can decide on how it should be used. It is one of those cases where either can work.

Cheers,

Richard