Skip to contentSkip to conversation

MAINTAINERS: CC Anthony on Xen's build system changes

PATCH In review Anthony PERARD 2 participants 2 messages Aug 16, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: CC Anthony on Xen's build system changes

I'd like to keep an eye on any changes in the Makefiles, to avoid further break of the build system.

With this entries, it means that THE REST will not be CCed anymore for changes in
- xen/Makefile
- xen/*.mk
- xen/scripts/Kbuild.include
- xen/scripts/Makefile.*
This could be an issue.

Most other files are also listed in other sections so would have a maintainer. There's probably a few Makefiles in subdirectory that would have CC THE REST but won't with this new section.

---

I'm not sure if adding a maintainers would be needed, but maybe Jan?

I could look at using lei from public-inbox, or just the search from public-inbox, but it's easier to tell people to CC me.

Thanks.

---
 MAINTAINERS | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
MAINTAINERS +14 -0
index e12c499a28..088647ba11 100644
@@ -260,6 +260,20 @@ M:	Rahul Singh <[email protected]>
 S:	Supported
 F:	xen/drivers/passthrough/arm/smmu-v3.c
 
+BUILD SYSTEM XEN
+R:	Anthony PERARD <[email protected]>
+S:	Supported
+F:	xen/Makefile
+F:	xen/*.mk
+F:	xen/scripts/Kbuild.include
+F:	xen/scripts/Makefile.*
+F:	xen/common/efi/efi-common.mk
+F:	xen/arch/*/*.mk
+F:	xen/*/Makefile
+F:	xen/*/*/Makefile
+F:	xen/*/*/*/Makefile
+F:	xen/*/*/*/*/Makefile
+
 Change Log
 M:	Henry Wang <[email protected]>
 R:	Community Manager <[email protected]>
Signature · 1 line
Anthony PERARD
#1 lore raw
Quoted 11 lines · Anthony PERARD

I'd like to keep an eye on any changes in the Makefiles, to avoid further break of the build system.

With this entries, it means that THE REST will not be CCed anymore for changes in
- xen/Makefile
- xen/*.mk
- xen/scripts/Kbuild.include
- xen/scripts/Makefile.*
This could be an issue.

Quoted 3 lines

Most other files are also listed in other sections so would have a maintainer. There's probably a few Makefiles in subdirectory that would have CC THE REST but won't with this new section.

Ideally the script would still pick REST if there's no M: entry; I have no idea whether that's already the case.

Quoted 9 lines
MAINTAINERS +3 -0
@@ -260,6 +260,20 @@ M:	Rahul Singh <[email protected]>
 S:	Supported
 F:	xen/drivers/passthrough/arm/smmu-v3.c
 
+BUILD SYSTEM XEN
+R:	Anthony PERARD <[email protected]>
+S:	Supported

MAINTAINERS M: Rahul Singh <[email protected]> · line 275

Quoted 10 lines
MAINTAINERS +10 -0
+F:	xen/Makefile
+F:	xen/*.mk
+F:	xen/scripts/Kbuild.include
+F:	xen/scripts/Makefile.*
+F:	xen/common/efi/efi-common.mk
+F:	xen/arch/*/*.mk
+F:	xen/*/Makefile
+F:	xen/*/*/Makefile
+F:	xen/*/*/*/Makefile
+F:	xen/*/*/*/*/Makefile

I'm curious what the sorting criteria (if any) was for the individual
F: lines. And I guess the last four lines can't really be collapsed into xen/**/Makefile ...

Jan