Skip to contentSkip to conversation

tests/i915/kms_psr2_su: Convert tests to dynamic

PATCH Superseded Jeevan B 3 participants 4 messages Aug 17, 2022 – Aug 19, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Jeevan B

author
#0 lore raw

PATCH 1/1 tests/i915/kms_psr2_su: Convert tests to dynamic

Converting the existing subtests to dynamic subtests.

Signed-off-by Jeevan B <[email protected]>
---
 tests/i915/kms_psr2_su.c | 64 +++++++++++++++++++++++++---------------
 1 file changed, 41 insertions(+), 23 deletions(-)
tests/i915/kms_psr2_su.c +41 -23
index caccf713..fcc3105b 100644
@@ -123,9 +123,15 @@ static void display_fini(data_t *data)
 	igt_display_fini(&data->display);
 }
 
-static void prepare(data_t *data)
+static void prepare(data_t *data, enum pipe pipe)
 {
 	igt_plane_t *primary;
+	igt_output_t *output;
+	igt_display_t *display = &data->display;
+
+	igt_display_reset(display);
+	output = data->output;
+	igt_output_set_pipe(output, pipe);
 
 	/* all green frame */
 	igt_create_color_fb(data->drm_fd,

@@ -263,6 +269,7 @@ static void cleanup(data_t *data)
 igt_main
 {
 	data_t data = {};
+	enum pipe pipe;
 
 	igt_fixture {
 		struct itimerspec interval;

@@ -287,12 +294,17 @@ igt_main
 			      "Error enabling PSR2\n");
 		data.op = FRONTBUFFER;
 		data.format = DRM_FORMAT_XRGB8888;
-		prepare(&data);
-		r = psr_wait_entry(data.debugfs_fd, PSR_MODE_2);
-		cleanup(&data);
-		if (!r)
-			psr_print_debugfs(data.debugfs_fd);
-		igt_require_f(r, "PSR2 can not be enabled\n");
+
+		for_each_pipe_with_valid_output(&data.display, pipe, data.output) {
+			if (pipe != PIPE_A)
+				break;
+			prepare(&data, pipe);
+			r = psr_wait_entry(data.debugfs_fd, PSR_MODE_2);
+			cleanup(&data);
+			if (!r)
+				psr_print_debugfs(data.debugfs_fd);
+			igt_require_f(r, "PSR2 can not be enabled\n");
+		}
 
 		/* blocking timerfd */
 		data.change_screen_timerfd = timerfd_create(CLOCK_MONOTONIC, 0);

@@ -312,23 +324,29 @@ igt_main
 		while (*format != DRM_FORMAT_INVALID) {
 			data.format = *format++;
 			igt_describe("Test that selective update works when screen changes");
-			igt_subtest_f("%s-%s", op_str(data.op), igt_format_str(data.format)) {
-				if (data.op == FRONTBUFFER &&
-				    intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 12) {
-					/*
-					 * FIXME: Display 12+ platforms now have PSR2
-					 * selective fetch enabled by default but we
-					 * still can't properly handle frontbuffer
-					 * rendering, so right it does full frame
-					 * fetches at every frontbuffer rendering.
-					 * So it is expected that this test will fail
-					 * in display 12+ platform for now.
-					 */
-					igt_skip("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n");
+			igt_subtest_with_dynamic_f("%s-%s", op_str(data.op), igt_format_str(data.format)) {
+				for_each_pipe_with_valid_output(&data.display, pipe, data.output) {
+					if (pipe != PIPE_A)
+		                                break;
+					igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
+						if (data.op == FRONTBUFFER &&
+						    intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 12) {
+						/*
+						 * FIXME: Display 12+ platforms now have PSR2
+						 * selective fetch enabled by default but we
+						 * still can't properly handle frontbuffer
+						 * rendering, so right it does full frame
+						 * fetches at every frontbuffer rendering.
+						 * So it is expected that this test will fail
+						 * in display 12+ platform for now.
+						 */
+						igt_skip("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n");
+						}
+					prepare(&data, pipe);
+					run(&data);
+					cleanup(&data);
+					}
 				}
-				prepare(&data);
-				run(&data);
-				cleanup(&data);
 			}
 		}
 	}
Signature · 1 line
2.36.0
CI
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_psr2_su: Convert tests to dynamic

== Series Details ==

== Series Details ==

Series: tests/i915/kms_psr2_su: Convert tests to dynamic
URL : https://patchwork.freedesktop.org/series/107349/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11991 -> IGTPW_7652
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with IGTPW_7652 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_7652, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/index.html

Participating hosts (33 -> 32)
------------------------------

Missing (1): bat-adls-5

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_7652:

### IGT changes ###

#### Warnings ####

* igt@gem_exec_suspend@basic-s3@smem:
- fi-hsw-g3258: [INCOMPLETE][1] ([i915#4939]) -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/fi-hsw-g3258/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/fi-hsw-g3258/igt@gem_exec_suspend@[email protected]

Known issues
------------

Here are the changes found in IGTPW_7652 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@gem:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][3] ([i915#4528])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/fi-pnv-d510/igt@i915_selftest@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [DMESG-FAIL][4] ([i915#4494] / [i915#4957]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/bat-dg1-6/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/bat-dg1-6/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][6] ([i915#4528]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/fi-pnv-d510/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/fi-pnv-d510/igt@i915_selftest@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][8] ([i915#6298]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]

[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6629 -> IGTPW_7652

CI-20190529: 20190529
CI_DRM_11991: 4753c139edecb571c6bb477d8488a54cef3aedf1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7652: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/index.html
IGT_6629: d24e986fb3b2ab6d755498d27828bc85931d12ff @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/index.html

CI
#2 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for tests/i915/kms_psr2_su: Convert tests to dynamic

In reply to Jeevan B
== Series Details ==

== Series Details ==

Series: tests/i915/kms_psr2_su: Convert tests to dynamic
URL : https://patchwork.freedesktop.org/series/107349/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11991_full -> IGTPW_7652_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_7652_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_7652_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/index.html

Participating hosts (12 -> 9)
------------------------------

Missing (3): pig-skl-6260u pig-kbl-iris shard-dg1

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_7652_full:

### IGT changes ###

#### Possible regressions ####

* igt@i915_module_load@reload:
- shard-kbl: NOTRUN -> [WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl1/igt@[email protected]
- shard-tglb: NOTRUN -> [WARN][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb7/igt@[email protected]

* igt@i915_module_load@reload-no-display:
- shard-kbl: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl4/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl4/igt@[email protected]
- shard-snb: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-snb5/igt@[email protected]
- shard-tglb: NOTRUN -> [FAIL][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][7] +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl8/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-vga-1:
- shard-snb: NOTRUN -> [INCOMPLETE][8] +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-snb6/igt@kms_pipe_crc_basic@[email protected]

Known issues
------------

Here are the changes found in IGTPW_7652_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][9] ([i915#4991])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl7/igt@[email protected]
- shard-snb: NOTRUN -> [DMESG-WARN][10] ([i915#4991])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-snb6/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][11] ([i915#4991])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl8/igt@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [PASS][12] -> [FAIL][13] ([i915#6268])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-tglb2/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb5/igt@[email protected]

* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][14] -> [DMESG-WARN][15] ([i915#180]) +6 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-kbl7/igt@gem_ctx_isolation@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl4/igt@gem_ctx_isolation@[email protected]

* igt@gem_ctx_param@set-priority-not-supported:
- shard-tglb: NOTRUN -> [SKIP][16] ([fdo#109314])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb7/igt@[email protected]

* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#1099]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-snb5/igt@[email protected]

* igt@gem_ctx_sseu@mmap-args:
- shard-tglb: NOTRUN -> [SKIP][18] ([i915#280])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb5/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][19] ([i915#3354])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-snb7/igt@[email protected]
- shard-tglb: NOTRUN -> [FAIL][20] ([i915#5784])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@[email protected]

* igt@gem_exec_balancer@parallel-ordering:
- shard-kbl: NOTRUN -> [FAIL][21] ([i915#6117])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl4/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-apl: NOTRUN -> [FAIL][22] ([i915#2846])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl8/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-kbl: [PASS][23] -> [SKIP][24] ([fdo#109271])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-kbl4/igt@gem_exec_fair@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][25] -> [FAIL][26] ([i915#2842]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-kbl4/igt@gem_exec_fair@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-tglb: [PASS][27] -> [FAIL][28] ([i915#2842]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-tglb2/igt@gem_exec_fair@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_params@no-blt:
- shard-tglb: NOTRUN -> [SKIP][29] ([fdo#109283])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#4613]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl1/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-verify:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#4613]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl4/igt@[email protected]

* igt@gem_pxp@reject-modify-context-protection-off-3:
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#4270])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb2/igt@[email protected]

* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271]) +315 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl8/igt@[email protected]

* igt@gem_softpin@evict-single-offset:
- shard-apl: NOTRUN -> [FAIL][34] ([i915#4171])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl1/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3323])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl1/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3323])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl1/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#3297]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb5/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][38] ([i915#3318])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl2/igt@[email protected]
- shard-snb: NOTRUN -> [FAIL][39] ([i915#2724])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-snb5/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][40] ([i915#3318])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl1/igt@[email protected]

* igt@gen7_exec_parse@chained-batch:
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#109289]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@[email protected]

* igt@gen9_exec_parse@batch-zero-length:
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#2527] / [i915#2856]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#1937])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl2/igt@i915_pm_lpsp@[email protected]

* igt@i915_suspend@forcewake:
- shard-kbl: NOTRUN -> [DMESG-WARN][44] ([i915#180]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl4/igt@[email protected]
- shard-snb: NOTRUN -> [INCOMPLETE][45] ([i915#4817])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-snb2/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-tglb: NOTRUN -> [SKIP][46] ([i915#5286]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb7/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

* igt@kms_big_fb@x-tiled-8bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#111614])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb7/igt@[email protected]

* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#111615]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb5/igt@[email protected]

* igt@kms_big_joiner@invalid-modeset:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#2705])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb5/igt@[email protected]

* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#3886]) +10 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl3/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-a-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#111615] / [i915#3689]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb7/igt@kms_ccs@pipe-a-missing-ccs-buffer-yf_tiled_ccs.html

* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#3886]) +6 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl4/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#3689] / [i915#3886]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][54] ([i915#3689] / [i915#6095]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb7/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#6095]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb2/igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs.html

* igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][56] ([i915#3689]) +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb5/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_ccs.html

* igt@kms_chamelium@dp-hpd-enable-disable-mode:
- shard-kbl: NOTRUN -> [SKIP][57] ([fdo#109271] / [fdo#111827]) +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl7/igt@[email protected]

* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +15 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl7/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +13 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-snb2/igt@[email protected]

* igt@kms_color_chamelium@ctm-blue-to-red:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109284] / [fdo#111827]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb2/igt@[email protected]

* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][61] ([i915#1319]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl1/igt@[email protected]
- shard-kbl: NOTRUN -> [TIMEOUT][62] ([i915#1319])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl1/igt@[email protected]

* igt@kms_content_protection@uevent:
- shard-kbl: NOTRUN -> [FAIL][63] ([i915#2105])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl7/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][64] ([i915#2105])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl2/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#4103])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb7/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb@varying-size:
- shard-tglb: NOTRUN -> [SKIP][66] ([fdo#109274] / [fdo#111825]) +5 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb2/igt@kms_cursor_legacy@[email protected]

* igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#3528])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb7/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-4tiled:
- shard-tglb: NOTRUN -> [SKIP][68] ([i915#5287])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@[email protected]

* igt@kms_flip@2x-flip-vs-absolute-wf_vblank:
- shard-tglb: NOTRUN -> [SKIP][69] ([fdo#109274] / [fdo#111825] / [i915#3637]) +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb5/igt@kms_flip@2x-flip-vs-absolute-wf_vblank.html

* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#2672]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff:
- shard-tglb: NOTRUN -> [SKIP][71] ([fdo#109280] / [fdo#111825]) +21 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#6497]) +4 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271]) +171 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-cpu:
- shard-snb: NOTRUN -> [SKIP][74] ([fdo#109271]) +378 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-snb4/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-cpu.html

* igt@kms_hdr@bpc-switch:
- shard-tglb: NOTRUN -> [SKIP][75] ([i915#3555])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb5/igt@[email protected]

* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-kbl: [PASS][76] -> [FAIL][77] ([i915#1188])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-kbl4/igt@kms_hdr@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl7/igt@kms_hdr@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-apl: [PASS][78] -> [INCOMPLETE][79] ([i915#4939])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-apl1/igt@kms_plane@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl7/igt@kms_plane@[email protected]
- shard-snb: [PASS][80] -> [INCOMPLETE][81] ([i915#4939])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-snb7/igt@kms_plane@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-snb2/igt@kms_plane@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][82] ([fdo#108145] / [i915#265]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][83] ([fdo#108145] / [i915#265])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl1/igt@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-d-edp-1:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#5176]) +3 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@kms_plane_scaling@[email protected]

* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#658]) +6 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#2920])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb5/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#658]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl7/igt@[email protected]

* igt@kms_psr@psr2_cursor_blt:
- shard-tglb: NOTRUN -> [FAIL][88] ([i915#132] / [i915#3467]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb2/igt@kms_psr@psr2_cursor_blt.html

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-snb: NOTRUN -> [INCOMPLETE][89] ([i915#4939]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-snb4/igt@[email protected]

* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: NOTRUN -> [INCOMPLETE][90] ([i915#4939]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl2/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-kbl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2437])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl4/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2437]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl3/igt@[email protected]

* igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#2530]) +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@[email protected]

* igt@perf_pmu@rc6-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][94] ([i915#180])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl2/igt@[email protected]

* igt@prime_nv_pcopy@test1_macro:
- shard-tglb: NOTRUN -> [SKIP][95] ([fdo#109291])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb5/igt@prime_nv_pcopy@test1_macro.html

* igt@sysfs_clients@fair-0:
- shard-kbl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#2994]) +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl7/igt@[email protected]

* igt@sysfs_clients@pidname:
- shard-apl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2994]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl6/igt@[email protected]

* igt@sysfs_clients@sema-50:
- shard-tglb: NOTRUN -> [SKIP][98] ([i915#2994])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb3/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][99] ([i915#2846]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-kbl7/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl7/igt@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][101] ([i915#2842]) -> [PASS][102] +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-kbl7/igt@gem_exec_fair@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl1/igt@gem_exec_fair@[email protected]

* igt@gem_workarounds@suspend-resume:
- shard-apl: [INCOMPLETE][103] ([i915#4939] / [i915#5129]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-apl4/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl7/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][105] ([i915#5566] / [i915#716]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-apl1/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl6/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-modeset:
- shard-apl: [INCOMPLETE][107] ([i915#4939]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-apl7/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl2/igt@[email protected]

* igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1:
- shard-kbl: [DMESG-WARN][109] ([i915#180]) -> [PASS][110] +3 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-kbl4/igt@kms_cursor_crc@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl4/igt@kms_cursor_crc@[email protected]

* igt@perf@polling-parameterized:
- shard-tglb: [FAIL][111] ([i915#5639]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-tglb5/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-tglb2/igt@[email protected]

#### Warnings ####

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][113] ([i915#2842]) -> [SKIP][114] ([fdo#109271])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-kbl7/igt@gem_exec_fair@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-kbl1/igt@gem_exec_fair@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [INCOMPLETE][115] -> [INCOMPLETE][116] ([i915#180])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-apl8/igt@kms_flip@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl4/igt@kms_flip@[email protected]

* igt@runner@aborted:
- shard-apl: ([FAIL][117], [FAIL][118], [FAIL][119]) ([fdo#109271] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123]) ([i915#3002] / [i915#4312] / [i915#5257])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-apl6/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-apl6/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11991/shard-apl1/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl2/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl7/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl8/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/shard-apl2/igt@[email protected]

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3354]: https://gitlab.freedesktop.org/drm/intel/issues/3354
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5129]: https://gitlab.freedesktop.org/drm/intel/issues/5129
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6629 -> IGTPW_7652
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_11991: 4753c139edecb571c6bb477d8488a54cef3aedf1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7652: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/index.html
IGT_6629: d24e986fb3b2ab6d755498d27828bc85931d12ff @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7652/index.html

#3 lore raw
In reply to Jeevan B
Quoted 1 line · Jeevan B

Converting the existing subtests to dynamic subtests.

Can you please add a bit more on why you are doing this. Also you are now adding own subtest for each pipe? Maybe couple of words about that also.

Quoted 41 lines
Signed-off-by Jeevan B <[email protected]>
---
 tests/i915/kms_psr2_su.c | 64 +++++++++++++++++++++++++-------------
--
 1 file changed, 41 insertions(+), 23 deletions(-)
tests/i915/kms_psr2_su.c +8 -2
index caccf713..fcc3105b 100644
@@ -123,9 +123,15 @@ static void display_fini(data_t *data)
 	igt_display_fini(&data->display);
 }
 
-static void prepare(data_t *data)
+static void prepare(data_t *data, enum pipe pipe)
 {
 	igt_plane_t *primary;
+	igt_output_t *output;
+	igt_display_t *display = &data->display;
+
+	igt_display_reset(display);
+	output = data->output;
+	igt_output_set_pipe(output, pipe);
 
 	/* all green frame */
 	igt_create_color_fb(data->drm_fd,

@@ -263,6 +269,7 @@ static void cleanup(data_t *data)
 igt_main
 {
 	data_t data = {};
+	enum pipe pipe;
 
 	igt_fixture {
 		struct itimerspec interval;

@@ -287,12 +294,17 @@ igt_main
 			      "Error enabling PSR2\n");
 		data.op = FRONTBUFFER;
 		data.format = DRM_FORMAT_XRGB8888;
-		prepare(&data);

tests/i915/kms_psr2_su.c igt_main · line 301

Quoted 10 lines
tests/i915/kms_psr2_su.c +4 -5
-		r = psr_wait_entry(data.debugfs_fd, PSR_MODE_2);
-		cleanup(&data);
-		if (!r)
-			psr_print_debugfs(data.debugfs_fd);
-		igt_require_f(r, "PSR2 can not be enabled\n");
+
+		for_each_pipe_with_valid_output(&data.display, pipe,
 data.output) {
+			if (pipe != PIPE_A)
+				break;

Isn't "continue" more correct here? Why can't you just do prepare(&data, PIPE_A) as anyways your loop is doing that? Maybe adding more descriptive commit message would help me to understand what you are doing here and why.

Quoted 44 lines
tests/i915/kms_psr2_su.c +7 -0
+			prepare(&data, pipe);
+			r = psr_wait_entry(data.debugfs_fd,
 PSR_MODE_2);
+			cleanup(&data);
+			if (!r)
+				psr_print_debugfs(data.debugfs_fd);
+			igt_require_f(r, "PSR2 can not be enabled\n");
+		}
tests/i915/kms_psr2_su.c +0 -0
 		/* blocking timerfd */
 		data.change_screen_timerfd =

timerfd_create(CLOCK_MONOTONIC, 0);

tests/i915/kms_psr2_su.c +0 -5
@@ -312,23 +324,29 @@ igt_main
 		while (*format != DRM_FORMAT_INVALID) {
 			data.format = *format++;
 			igt_describe("Test that selective update works
 when screen changes");
-			igt_subtest_f("%s-%s", op_str(data.op),
 igt_format_str(data.format)) {
-				if (data.op == FRONTBUFFER &&
-				    intel_display_ver(intel_get_drm_dev
 id(data.drm_fd)) >= 12) {
-					/*
-					 * FIXME: Display 12+ platforms

now have PSR2

tests/i915/kms_psr2_su.c +0 -1
-					 * selective fetch enabled by

default but we

tests/i915/kms_psr2_su.c +0 -1
-					 * still can't properly handle

frontbuffer

tests/i915/kms_psr2_su.c +0 -1
-					 * rendering, so right it does

full frame

tests/i915/kms_psr2_su.c +0 -1
-					 * fetches at every frontbuffer

rendering.

tests/i915/kms_psr2_su.c +0 -1
-					 * So it is expected that this

test will fail

tests/i915/kms_psr2_su.c +0 -1
-					 * in display 12+ platform for

now.

tests/i915/kms_psr2_su.c +0 -2
-					 */
-					igt_skip("PSR2 selective fetch

is doing full frame fetches for frontbuffer rendering\n");

tests/i915/kms_psr2_su.c +1 -0
+			igt_subtest_with_dynamic_f("%s-%s",

op_str(data.op), igt_format_str(data.format)) {

tests/i915/kms_psr2_su.c +1 -0
+				for_each_pipe_with_valid_output(&data.d

isplay, pipe, data.output) {

tests/i915/kms_psr2_su.c

Quoted 2 lines
tests/i915/kms_psr2_su.c +2 -0
+					if (pipe != PIPE_A)
+		                                break;

Same comment here as above.

Quoted 27 lines
tests/i915/kms_psr2_su.c +1 -0
+					igt_dynamic_f("pipe-%s",

kmstest_pipe_name(pipe)) {

tests/i915/kms_psr2_su.c +1 -0
+						if (data.op ==

FRONTBUFFER &&

tests/i915/kms_psr2_su.c +1 -0
+						    intel_display_ver(i

ntel_get_drm_devid(data.drm_fd)) >= 12) {

tests/i915/kms_psr2_su.c +2 -0
+						/*
+						 * FIXME: Display 12+

platforms now have PSR2

tests/i915/kms_psr2_su.c +1 -0
+						 * selective fetch

enabled by default but we

tests/i915/kms_psr2_su.c +1 -0
+						 * still can't properly

handle frontbuffer

tests/i915/kms_psr2_su.c +1 -0
+						 * rendering, so right

it does full frame

tests/i915/kms_psr2_su.c +1 -0
+						 * fetches at every

frontbuffer rendering.

tests/i915/kms_psr2_su.c +1 -0
+						 * So it is expected

that this test will fail

tests/i915/kms_psr2_su.c +1 -0
+						 * in display 12+

platform for now.

tests/i915/kms_psr2_su.c +2 -0
+						 */
+						igt_skip("PSR2

selective fetch is doing full frame fetches for frontbuffer rendering\n");

tests/i915/kms_psr2_su.c +2 -0
+						}
+					prepare(&data, pipe);

tests/i915/kms_psr2_su.c igt_main · line 352

Quoted 10 lines
tests/i915/kms_psr2_su.c +3 -3
+					run(&data);
+					cleanup(&data);
+					}
 				}
-				prepare(&data);
-				run(&data);
-				cleanup(&data);
 			}
 		}
 	}

BR,

Jouni Högander