Skip to contentSkip to conversation

Github Actions: update used actions

PATCH Superseded Timo Rothenpieler 3 participants 6 messages Aug 17, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Github Actions: update used actions

---
 .github/workflows/build.yaml | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
.github/workflows/build.yaml +12 -12
index c89d3c8c..49b7d6d1 100644
@@ -13,7 +13,7 @@ jobs:
       - name: Install dependencies
         run: sudo apt update && sudo apt install -y uncrustify
       - name: Checkout OpenVPN
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           path: openvpn
       - name: Show uncrustify version
@@ -27,7 +27,7 @@ jobs:
       - name: Show changes on standard output
         run: git diff
         working-directory: openvpn
-      - uses: actions/[email protected]...
+      - uses: actions/[email protected]...
         with:
           name: uncrustify-changes.patch
           path: 'openvpn/uncrustify-changes.patch'
@@ -60,12 +60,12 @@ jobs:
       - name: Install dependencies
         run: sudo apt update && sudo apt install -y mingw-w64 libtool automake autoconf man2html unzip
       - name: Checkout ovpn-dco-win
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           repository: OpenVPN/ovpn-dco-win
           path: ovpn-dco-win
       - name: Checkout OpenVPN
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           path: openvpn
 
@@ -75,7 +75,7 @@ jobs:
 
       - name: Cache dependencies
         id: cache
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           path: '~/mingw/'
           key: ${{ matrix.target }}-mingw-${{ env.OPENSSL_VERSION }}-${{ env.LZO_VERSION }}-${{ env.PKCS11_HELPER_VERSION }}-${{ env.TAP_WINDOWS_VERSION }}
@@ -226,7 +226,7 @@ jobs:
       - name: Install dependencies
         run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev libcap-ng-dev linux-libc-dev man2html libcmocka-dev python3-docutils libtool automake autoconf ${SSLPKG} ${NLPKG}
       - name: Checkout OpenVPN
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
       - name: autoconf
         run: autoreconf -fvi
       - name: configure
@@ -250,7 +250,7 @@ jobs:
       - name: Install dependencies
         run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev libcap-ng-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils libtool automake autoconf libmbedtls-dev
       - name: Checkout OpenVPN
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
       - name: autoconf
         run: autoreconf -fvi
       - name: configure
@@ -288,7 +288,7 @@ jobs:
       - name: Install dependencies
         run: brew install [email protected]... [email protected]... lzo lz4 man2html cmocka libtool automake autoconf
       - name: Checkout OpenVPN
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
       - name: autoconf
         run: autoreconf -fvi
       - name: configure
@@ -319,13 +319,13 @@ jobs:
 
       runs-on: windows-latest
       steps:
-      - uses: actions/[email protected]...
+      - uses: actions/[email protected]...
 
       - name: Add MSBuild to PATH
-        uses: microsoft/[email protected]...
+        uses: microsoft/[email protected]...
 
       - name: Set up Python
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           python-version: '3.x'
 
@@ -345,7 +345,7 @@ jobs:
             msbuild /m /p:Configuration=${{env.BUILD_CONFIGURATION}} /p:Platform="${{ matrix.plat }}" .
 
       - name: Archive artifacts
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           name: artifacts-${{ matrix.plat }}
           path: |
Signature · 1 line
2.34.1
#1 lore raw

Hey,

newest and greatest is always nice but could you give a bit more rationale why we should update? The commit message is unfortunately not giving any details.

Arne

#2 lore raw
Quoted 3 lines · Arne Schwabe

Hey,

newest and greatest is always nice but could you give a bit more rationale why we should update? The commit message is unfortunately not giving any details.

In the case of the Microsoft action, it actually fixes security relevant issues according to their release notes:

https://github.com/microsoft/setup-msbuild/releases

Unfortunately they don't appear to be following the usual scheme of v1 referring to all v1.x.x, but instead v1 just points to v1.0.0.

The primary change with all the Github-Provided actions is the switch to a more up-to-date NodeJS version (16). Not all that relevant when you just use the action as is, but on top of that, the old versions are in low-maintenance mode, and basically are considered obsolete. Github is actively migrating people to the latest ones via dependabot wherever they can.

#3 lore raw

PATCH v2 1/1 Github Actions: update used actions

In reply to Timo Rothenpieler

In the case of the Microsoft action, this fixes security relevant issues according to their release notes:
https://github.com/microsoft/setup-msbuild/releases

Unfortunately they don't appear to be following the usual scheme of v1 referring to all v1.x.x, but instead v1 just points to v1.0.0.

The primary change with all the Github-Provided actions is the switch to a more up-to-date NodeJS version (16). Not all that relevant when you just use the action as is, but on top of that, the old versions are in low-maintenance mode, and basically are considered obsolete. Github is actively migrating people to the latest ones via dependabot wherever they can.

---
 .github/workflows/build.yaml | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
.github/workflows/build.yaml +12 -12
index c89d3c8c..49b7d6d1 100644
@@ -13,7 +13,7 @@ jobs:
       - name: Install dependencies
         run: sudo apt update && sudo apt install -y uncrustify
       - name: Checkout OpenVPN
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           path: openvpn
       - name: Show uncrustify version
@@ -27,7 +27,7 @@ jobs:
       - name: Show changes on standard output
         run: git diff
         working-directory: openvpn
-      - uses: actions/[email protected]...
+      - uses: actions/[email protected]...
         with:
           name: uncrustify-changes.patch
           path: 'openvpn/uncrustify-changes.patch'
@@ -60,12 +60,12 @@ jobs:
       - name: Install dependencies
         run: sudo apt update && sudo apt install -y mingw-w64 libtool automake autoconf man2html unzip
       - name: Checkout ovpn-dco-win
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           repository: OpenVPN/ovpn-dco-win
           path: ovpn-dco-win
       - name: Checkout OpenVPN
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           path: openvpn
 
@@ -75,7 +75,7 @@ jobs:
 
       - name: Cache dependencies
         id: cache
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           path: '~/mingw/'
           key: ${{ matrix.target }}-mingw-${{ env.OPENSSL_VERSION }}-${{ env.LZO_VERSION }}-${{ env.PKCS11_HELPER_VERSION }}-${{ env.TAP_WINDOWS_VERSION }}
@@ -226,7 +226,7 @@ jobs:
       - name: Install dependencies
         run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev libcap-ng-dev linux-libc-dev man2html libcmocka-dev python3-docutils libtool automake autoconf ${SSLPKG} ${NLPKG}
       - name: Checkout OpenVPN
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
       - name: autoconf
         run: autoreconf -fvi
       - name: configure
@@ -250,7 +250,7 @@ jobs:
       - name: Install dependencies
         run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev libcap-ng-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils libtool automake autoconf libmbedtls-dev
       - name: Checkout OpenVPN
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
       - name: autoconf
         run: autoreconf -fvi
       - name: configure
@@ -288,7 +288,7 @@ jobs:
       - name: Install dependencies
         run: brew install [email protected]... [email protected]... lzo lz4 man2html cmocka libtool automake autoconf
       - name: Checkout OpenVPN
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
       - name: autoconf
         run: autoreconf -fvi
       - name: configure
@@ -319,13 +319,13 @@ jobs:
 
       runs-on: windows-latest
       steps:
-      - uses: actions/[email protected]...
+      - uses: actions/[email protected]...
 
       - name: Add MSBuild to PATH
-        uses: microsoft/[email protected]...
+        uses: microsoft/[email protected]...
 
       - name: Set up Python
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           python-version: '3.x'
 
@@ -345,7 +345,7 @@ jobs:
             msbuild /m /p:Configuration=${{env.BUILD_CONFIGURATION}} /p:Platform="${{ matrix.plat }}" .
 
       - name: Archive artifacts
-        uses: actions/[email protected]...
+        uses: actions/[email protected]...
         with:
           name: artifacts-${{ matrix.plat }}
           path: |
Signature · 1 line
2.34.1
Acked-by on v2 1/1
#4 lore raw

Am 17.08.22 um 15:23 schrieb Timo Rothenpieler:

Quoted 8 lines

In the case of the Microsoft action, this fixes security relevant issues according to their release notes:
https://github.com/microsoft/setup-msbuild/releases

Unfortunately they don't appear to be following the usual scheme of v1 referring to all v1.x.x, but instead v1 just points to v1.0.0.

The primary change with all the Github-Provided actions is the switch to a more up-to-date NodeJS version (16). Not all that relevant when you just use the action as is, but on top of that, the old versions are in low-maintenance mode, and basically are considered obsolete. Github is actively migrating people to the latest ones via dependabot wherever they can.

Thanks for the quick update.

Arne

#5 lore raw
In reply to Timo Rothenpieler

Applied :-) - had a look, looks as discused, GHA has to do the testing.

Your patch has been applied to the master branch.

commit 9b17fed14bc534353d9a5e2d90d902bb093df3c2

Author: Timo Rothenpieler
Date:   Wed Aug 17 15:23:02 2022 +0200
     Github Actions: update used actions

     Acked-by: Arne Schwabe <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg24954.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering