Skip to contentSkip to conversation

dt-bindings: timer: Add compatible for MediaTek MT8188

PATCH RESEND Applied Johnson Wang 4 participants 7 messages Aug 18, 2022 – Oct 4, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 dt-bindings: timer: Add compatible for MediaTek MT8188

Add dt-binding documentation of timer for MediaTek MT8188 SoC platform.

---
 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt +1 -0
index f1c848af91d3..8bbb6e94508b 100644
@@ -25,6 +25,7 @@ Required properties:
 	For those SoCs that use SYST
 	* "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
 	* "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
+	* "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)
 	* "mediatek,mt8192-timer" for MT8192 compatible timers (SYST)
 	* "mediatek,mt8195-timer" for MT8195 compatible timers (SYST)
 	* "mediatek,mt7629-timer" for MT7629 compatible timers (SYST)
Signature · 1 line
2.18.0
#1 lore raw
Quoted 14 lines · Johnson Wang

Add dt-binding documentation of timer for MediaTek MT8188 SoC platform.

---
 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt +0 -0
index f1c848af91d3..8bbb6e94508b 100644

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt Required properties: · line 28

Quoted 4 lines
Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt +1 -0
@@ -25,6 +25,7 @@ Required properties:
 	For those SoCs that use SYST
 	* "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
 	* "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
+	* "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)

Where is the driver change implementing this?

Best regards,
Krzysztof

#2 lore raw
Quoted 10 lines · Krzysztof Kozlowski
Quoted 9 lines · Johnson Wang

Add dt-binding documentation of timer for MediaTek MT8188 SoC platform.

---
 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt Required properties: · line 28

Quoted 9 lines
Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt +1 -0
index f1c848af91d3..8bbb6e94508b 100644
@@ -25,6 +25,7 @@ Required properties:
 	For those SoCs that use SYST
 	* "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
 	* "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
+	* "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)

Where is the driver change implementing this?

Or is there a generic fallback and you just added a specific one (not visible on the diff)?

Best regards,
Krzysztof

#3 lore raw
Quoted 28 lines · Krzysztof Kozlowski
Quoted 11 lines · Krzysztof Kozlowski
Quoted 10 lines · Johnson Wang

Add dt-binding documentation of timer for MediaTek MT8188 SoC platform.

---
Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt |
1 +

 1 file changed, 1 insertion(+)
Quoted 15 lines

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt Required properties: · line 28

Quoted 13 lines

diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt index f1c848af91d3..8bbb6e94508b 100644
--- a/Documentation/devicetree/bindings/timer/mediatek,mtk- timer.txt
+++ b/Documentation/devicetree/bindings/timer/mediatek,mtk- timer.txt

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt +1 -0
@@ -25,6 +25,7 @@ Required properties:
 	For those SoCs that use SYST
 	* "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
 	* "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
+	* "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)

Where is the driver change implementing this?

Quoted 5 lines

Or is there a generic fallback and you just added a specific one (not visible on the diff)?

Best regards,
Krzysztof

Hi Krzysztof,

Yes, MT8188 uses "mediatek,mt6765-timer" as fallback compatible.

BRs,
Johnson Wang

#4 lore raw
In reply to Johnson Wang
Quoted 16 lines · Johnson Wang

Add dt-binding documentation of timer for MediaTek MT8188 SoC platform.

---
 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk- timer.txt
index f1c848af91d3..8bbb6e94508b 100644

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt Required properties: · line 31

Quoted 7 lines
Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt +1 -0
@@ -25,6 +25,7 @@ Required properties:
 	For those SoCs that use SYST
 	* "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
 	* "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
+	* "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)
 	* "mediatek,mt8192-timer" for MT8192 compatible timers (SYST)
 	* "mediatek,mt8195-timer" for MT8195 compatible timers (SYST)
 	* "mediatek,mt7629-timer" for MT7629 compatible timers (SYST)

Hi Daniel,

Just a gentle ping on this.
Could you please review this patch and give us some suggestion?

Thanks.

BRs,
Johnson Wang

#5 lore raw
Quoted 27 lines · Johnson Wang
Quoted 16 lines · Johnson Wang

Add dt-binding documentation of timer for MediaTek MT8188 SoC platform.

---
  Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
  1 file changed, 1 insertion(+)
(quoted diff) +0 -0

timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk- timer.txt
index f1c848af91d3..8bbb6e94508b 100644

Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt Required properties: · line 31

Quoted 7 lines
Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt +1 -0
@@ -25,6 +25,7 @@ Required properties:
  	For those SoCs that use SYST
  	* "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
  	* "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
+	* "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)
  	* "mediatek,mt8192-timer" for MT8192 compatible timers (SYST)
  	* "mediatek,mt8195-timer" for MT8195 compatible timers (SYST)
  	* "mediatek,mt7629-timer" for MT7629 compatible timers (SYST)

Hi Daniel,

Quoted 2 lines

Just a gentle ping on this.
Could you please review this patch and give us some suggestion?

I've applied the patch

Thanks

-- D.

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
merge bot Applied
#6 lore raw
In reply to Johnson Wang
The following commit has been merged into the timers/core branch of tip:

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     b830774c7e4168997ba42deb186f72e6a845742b
Gitweb:        https://git.kernel.org/tip/b830774c7e4168997ba42deb186f72e6a845742b
Author:        Johnson Wang <[email protected]>
AuthorDate:    Thu, 18 Aug 2022 20:46:02 +08:00
Committer:     Daniel Lezcano <[email protected]>
CommitterDate: Fri, 19 Aug 2022 11:06:54 +02:00

dt-bindings: timer: Add compatible for MediaTek MT8188

Add dt-binding documentation of timer for MediaTek MT8188 SoC platform.

---
 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt +1 -0
index f1c848a..8bbb6e9 100644
@@ -25,6 +25,7 @@ Required properties:
 	For those SoCs that use SYST
 	* "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
 	* "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
+	* "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)
 	* "mediatek,mt8192-timer" for MT8192 compatible timers (SYST)
 	* "mediatek,mt8195-timer" for MT8195 compatible timers (SYST)
 	* "mediatek,mt7629-timer" for MT7629 compatible timers (SYST)