Skip to contentSkip to conversation

tools: kwboot: Change KWBOOT_MSG_RSP_TIMEO_AXP to 10ms

PATCH In review Stefan Roese 2 participants 4 messages Aug 19, 2022 – Sep 27, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools: kwboot: Change KWBOOT_MSG_RSP_TIMEO_AXP to 10ms

Testing on the theadorable Armada XP platform has shown, thaz using the current value of 1000ms as response timeout does not result in reliable booting via kwboot. Using 10ms seems to be much better. So let's change this value to this 10ms instead.

---
 tools/kwboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/kwboot.c +1 -1
index 16bcd4d9a778..da4fe32da226 100644
@@ -84,7 +84,7 @@ static unsigned char kwboot_msg_debug[] = {
 #define KWBOOT_MSG_RSP_TIMEO	50 /* ms */
 
 /* Defines known to work on Armada XP */
-#define KWBOOT_MSG_RSP_TIMEO_AXP	1000 /* ms */
+#define KWBOOT_MSG_RSP_TIMEO_AXP	10 /* ms */
 
 /*
  * Xmodem Transfers
Signature · 1 line
2.37.2
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · On Friday 19 August 2022 09:43:59 Stefan Roese wrote:

Testing on the theadorable Armada XP platform has shown, thaz using the current value of 1000ms as response timeout does not result in reliable booting via kwboot. Using 10ms seems to be much better. So let's change this value to this 10ms instead.

Quoted 20 lines
---
 tools/kwboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/kwboot.c +1 -1
index 16bcd4d9a778..da4fe32da226 100644
@@ -84,7 +84,7 @@ static unsigned char kwboot_msg_debug[] = {
 #define KWBOOT_MSG_RSP_TIMEO	50 /* ms */
 
 /* Defines known to work on Armada XP */
-#define KWBOOT_MSG_RSP_TIMEO_AXP	1000 /* ms */
+#define KWBOOT_MSG_RSP_TIMEO_AXP	10 /* ms */
 
 /*
  * Xmodem Transfers
Signature · 1 line
2.37.2
#2 lore raw
Quoted 9 lines · On Friday 19 August 2022 10:20:46 Pali Rohár wrote:
Quoted 6 lines · On Friday 19 August 2022 09:43:59 Stefan Roese wrote:

Testing on the theadorable Armada XP platform has shown, thaz using the current value of 1000ms as response timeout does not result in reliable booting via kwboot. Using 10ms seems to be much better. So let's change this value to this 10ms instead.

Hello Stefan! You should update also documentation file doc/kwboot.1 because it mention "1000 ms" for Option \fB-a\fP.

Quoted 20 lines
Quoted 20 lines
---
 tools/kwboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/kwboot.c +1 -1
index 16bcd4d9a778..da4fe32da226 100644
@@ -84,7 +84,7 @@ static unsigned char kwboot_msg_debug[] = {
 #define KWBOOT_MSG_RSP_TIMEO	50 /* ms */
 
 /* Defines known to work on Armada XP */
-#define KWBOOT_MSG_RSP_TIMEO_AXP	1000 /* ms */
+#define KWBOOT_MSG_RSP_TIMEO_AXP	10 /* ms */
 
 /*
  * Xmodem Transfers
Signature · 1 line
2.37.2
#3 lore raw
In reply to Stefan Roese
Quoted 6 lines · Stefan Roese

Testing on the theadorable Armada XP platform has shown, thaz using the current value of 1000ms as response timeout does not result in reliable booting via kwboot. Using 10ms seems to be much better. So let's change this value to this 10ms instead.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 9 lines
---
  tools/kwboot.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tools/kwboot.c +0 -0
index 16bcd4d9a778..da4fe32da226 100644

tools/kwboot.c static unsigned char kwboot_msg_debug[] = { · line 90

Quoted 8 lines
tools/kwboot.c +1 -1
@@ -84,7 +84,7 @@ static unsigned char kwboot_msg_debug[] = {
  #define KWBOOT_MSG_RSP_TIMEO	50 /* ms */
 
  /* Defines known to work on Armada XP */
-#define KWBOOT_MSG_RSP_TIMEO_AXP	1000 /* ms */
+#define KWBOOT_MSG_RSP_TIMEO_AXP	10 /* ms */
 
  /*
   * Xmodem Transfers

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]