Skip to contentSkip to conversation

video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci_init()

PATCH Applied Yang Yingliang 2 participants 2 messages Aug 19, 2022 – Aug 22, 2022 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci_init()

Add missing pci_disable_device() in error path in chipsfb_pci_init().

---
 drivers/video/fbdev/chipsfb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/fbdev/chipsfb.c +1 -0
index 393894af26f8..2b00a9d554fc 100644
@@ -430,6 +430,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
  err_release_fb:
 	framebuffer_release(p);
  err_disable:
+	pci_disable_device(dp);
  err_out:
 	return rc;
 }
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 3 lines · Yang Yingliang

Add missing pci_disable_device() in error path in chipsfb_pci_init().

applied.
Thanks!
Helge

Quoted 16 lines
---
 drivers/video/fbdev/chipsfb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/fbdev/chipsfb.c +1 -0
index 393894af26f8..2b00a9d554fc 100644
@@ -430,6 +430,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
  err_release_fb:
 	framebuffer_release(p);
  err_disable:
+	pci_disable_device(dp);
  err_out:
 	return rc;
 }